https://bugs.freedesktop.org/show_bug.cgi?id=97879
hofmann.zach...@gmail.com changed:
What|Removed |Added
CC||hofmann.zach...@gmail.com
--
Nice work!
Reviewed-by: Tapani Pälli
On 11/02/2016 03:18 AM, Timothy Arceri wrote:
This moves the delete linked shaders call to
_mesa_clear_shader_program_data() which makes sure we delete them
before returning due to any validation problems.
It also reduces some code
The GM107 had a bunch of prepareEmission needlessly duplicated because
the sched block size is different. Move that knowledge into the target,
and generalize the existing code.
Signed-off-by: Ilia Mirkin
---
.../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 4 +--
This doesn't seem to cause real issues, but it makes compiled code
easier to follow when the jumps go to the right place.
Signed-off-by: Ilia Mirkin
---
.../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 27 +-
1 file changed, 21 insertions(+), 6
On Tue, 2016-11-01 at 20:09 -0700, Jason Ekstrand wrote:
> Before we were caching the prog data but we weren't doing anything
> with
> brw_stage_prog_data::param so anything with push constants wasn't
> getting
> cached properly. This commit fixes that.
>
> Signed-off-by: Jason Ekstrand
On 01/11/16 08:10 PM, Chris Wilson wrote:
> glXSwapBuffers() is translated internally into glXSwapBuffersMsc() with
> a target and divisor of 0.
>
> https://www.opengl.org/registry/specs/OML/glx_sync_control.txt
>
> "If = 0, the swap will occur when MSC becomes greater than
> or equal
---
src/intel/blorp/blorp.c | 28 +++-
src/intel/blorp/blorp_blit.c | 2 +-
src/intel/blorp/blorp_clear.c | 2 +-
src/intel/blorp/blorp_genX_exec.h | 31 ---
src/intel/blorp/blorp_priv.h | 31
---
src/intel/blorp/blorp.h | 5 +++--
src/intel/blorp/blorp_blit.c | 2 +-
src/intel/blorp/blorp_clear.c | 2 +-
src/intel/vulkan/anv_blorp.c | 3 ++-
src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++-
5 files changed, 9 insertions(+), 6 deletions(-)
diff
While we can simply calculate offsets to get to things such as the
prog_data and the key, it's much more user-friendly if there are just
pointers. Also, it's a bit more fool-proof.
While we're at it, we rework the pipeline cache API to use the
brw_stage_prog_data type directly.
Signed-off-by:
Before we were caching the prog data but we weren't doing anything with
brw_stage_prog_data::param so anything with push constants wasn't getting
cached properly. This commit fixes that.
Signed-off-by: Jason Ekstrand
---
src/intel/vulkan/anv_pipeline.c | 3 ++-
https://bugs.freedesktop.org/show_bug.cgi?id=97879
John-Michael Mulesa changed:
What|Removed |Added
CC|
I'm about to do some refactoring that will move a bunch of glsl only
fields from gl_linked_program into gl_program.
If we wan't to share memory it makes sense to do it while I move
things. I just wanted to see what people think about this before
I get started as it's not going to be fun to go
From: Dave Airlie
This fixes a bunch of GPU hangs introduced in some CTS
tests like
dEQP-VK.memory.pipeline_barrier.host_write_uniform_buffer.65536
It works around an issue seen in the LLVM backend, but
also makes the radv code work more like the radeonsi stack.
From: Dave Airlie
This is ported from GLSL and converts
if (cond)
discard;
into
discard_if(cond);
This removes a block, but also is needed by radv
to workaround a bug in the LLVM backend.
Signed-off-by: Dave Airlie
---
From: Dave Airlie
We are going to start lowering to this in NIR code,
so prepare radv for it.
Signed-off-by: Dave Airlie
---
src/amd/common/ac_nir_to_llvm.c | 13 +
1 file changed, 13 insertions(+)
diff --git
So it appears at least the LLVM 3.9 backend can get confused
when it gets hit with if (cond) discard type constructs, and we
have a GLSL optimisation to convert this to discard_if, so I've
ported that to NIR, and enabled it for radv. It fixes the hangs
and the tests here.
Dave.
https://bugs.freedesktop.org/show_bug.cgi?id=98502
--- Comment #9 from Michel Dänzer ---
I'm not sure what exactly you're asking me to do. Can you just ask on the
amd-gfx mailing list directly?
--
You are receiving this mail because:
You are the assignee for the bug.
You
This moves the delete linked shaders call to
_mesa_clear_shader_program_data() which makes sure we delete them
before returning due to any validation problems.
It also reduces some code duplication.
From the OpenGL 4.5 Core spec:
"If LinkProgram failed, any information about a previous link
On 22/10/16 07:00 PM, Chris Wilson wrote:
> This applies a synchronisation point to GetBuffers() such that binding a
> texture-from-pixmap its rendering is serialised with X. This matches the
> synchronisation point inside DRI2, but it is also arguable that implied
> sync should be explicitly
https://bugs.freedesktop.org/show_bug.cgi?id=98012
Matt Turner changed:
What|Removed |Added
Summary|[anv] Segfault when running |[IVB] Segfault when
For all 3,
Reviewed-by: Dave Airlie
On 2 November 2016 at 10:56, Jason Ekstrand wrote:
> Without this fix, the function would still end up returning NULL but it
> would put that NULL connection in the hash table which would be bad.
>
> Signed-off-by:
Without this fix, the function would still end up returning NULL but it
would put that NULL connection in the hash table which would be bad.
Signed-off-by: Jason Ekstrand
Cc: "13.0"
Cc: Dave Airlie
---
Signed-off-by: Jason Ekstrand
Cc: "13.0"
Cc: Dave Airlie
---
src/vulkan/wsi/wsi_common_x11.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c
The case where we just want the loop to continue is INCOMPATIBLE_DRIVER
because that simply means that whatever FD we opened isn't a supported
Intel chip. Other error codes such as OUT_OF_HOST_MEMORY are actual errors
and we should be returning early in that case.
Signed-off-by: Jason Ekstrand
Acked-by: Edward O'Callaghan
On 11/02/2016 11:35 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> Dolphin tried to use this, but we hadn't had any tests for it properly.
>
> All that is required is the shader output format needs to be set
> for 0
From: Dave Airlie
Dolphin tried to use this, but we hadn't had any tests for it properly.
All that is required is the shader output format needs to be set
for 0 and 1 exports.
Cc: "13.0"
Signed-off-by: Dave Airlie
---
On Tue, Nov 1, 2016 at 4:47 PM, Timothy Arceri
wrote:
> This move the delete linked shaders call to
> _mesa_clear_shader_program_data() which makes sure we delete them
> before returning due to any validation problems.
I would love some sort of description of what
Reviewed-by: Bas Nieuwenhuizen
On Wed, Nov 2, 2016 at 12:53 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> I missed this when I added the xlib code, this allows
> dolphin emu to start and crash later.
>
> Cc: "13.0"
From: Dave Airlie
I missed this when I added the xlib code, this allows
dolphin emu to start and crash later.
Cc: "13.0"
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_device.c | 6 ++
1 file changed, 6
On Tuesday, November 1, 2016 2:25:49 PM PDT Francisco Jerez wrote:
> Assuming the hardware is set-up to use a screen coordinate system
> flipped vertically with respect to the GL's window coordinate system,
> the SYSTEM_VALUE_SAMPLE_POS vector will also be flipped vertically
> with respect to the
This move the delete linked shaders call to
_mesa_clear_shader_program_data() which makes sure we delete them
before returning due to any validation problems.
It also reduces some code duplication.
Cc: Tapani Pälli
Bugzilla:
This wrapper ensures that we always update all anv_bo::offset fields based
on the offsets returned by the kernel.
Signed-off-by: Jason Ekstrand
---
src/intel/vulkan/anv_device.c | 51 +-
src/intel/vulkan/anv_private.h | 4
2
This ensures that we're always setting all of the fields in anv_bo
Signed-off-by: Jason Ekstrand
---
src/intel/vulkan/anv_allocator.c | 9 ++---
src/intel/vulkan/anv_device.c| 10 +++---
src/intel/vulkan/anv_intel.c | 11 +--
This series is a revival of a patch of Kristian's from earlier this year to
do relocations in userspace before handing the batch off to the kernel.
The kernel refuses to write a relocation into a busy buffer (for obvious
reasons). Because we use a single surface state buffer that is shared
across
The previous implementation was being overly clever and using the
anv_bo::size field as its mutex. Scratch pool allocations don't happen
often, will happen at most a fixed number of times, and never happen in the
critical path (they only happen in shader compilation). We can make this
much
Because our relocation processing happens at EndCommandBuffer time and
because RENDER_SURFACE_STATE objects may be shared by batches, we really
have no clue whatsoever what address is actually written to the relocation
offset in the BO. We need to stop making such claims to the kernel and
just
Since -1 is an invalid GPU address, this lets us know whether or not we
have a valid address for a buffer. We don't get a valid address until the
first time that buffer is used in an execbuf2 ioctl.
Signed-off-by: Jason Ekstrand
---
src/intel/vulkan/anv_private.h | 2 +-
From: Kristian Høgsberg Kristensen
Since our surface state buffer is shared by all batches, the kernel does a
full stall and sync with the CPU between batches every time we call
execbuf2 because it refuses to do relocations on an active buffer. Doing
them in
On Tue, Nov 1, 2016 at 5:42 PM, Mauro Rossi wrote:
>> Mauro or Chih-Wei should be able to answer this (being do static
>> wallpapers work in i965?).
>>
>> Rob
>
> Hi, I've perfomed tests with mesa
> https://github.com/maurossi/mesa/commits/13.0.0_nougat-x86
> and the
>-Original Message-
>From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of
>Lionel Landwerlin
>Sent: Monday, October 17, 2016 1:57 PM
>To: mesa-dev@lists.freedesktop.org
>Cc: Landwerlin, Lionel G
>Subject: [Mesa-dev] [PATCH 1/3] intel:
https://bugs.freedesktop.org/show_bug.cgi?id=98526
--- Comment #3 from Vinson Lee ---
This is so far a regression with clang builds only.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the
>-Original Message-
>From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of
>Lionel Landwerlin
>Sent: Monday, October 17, 2016 1:57 PM
>To: mesa-dev@lists.freedesktop.org
>Cc: Landwerlin, Lionel G
>Subject: [Mesa-dev] [PATCH 3/3] intel:
>-Original Message-
>From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of
>Lionel Landwerlin
>Sent: Monday, October 17, 2016 1:57 PM
>To: mesa-dev@lists.freedesktop.org
>Cc: Landwerlin, Lionel G
>Subject: [Mesa-dev] [PATCH 2/3] intel:
https://bugs.freedesktop.org/show_bug.cgi?id=98526
--- Comment #2 from Marek Olšák ---
I can't reproduce this.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev
> Mauro or Chih-Wei should be able to answer this (being do static
> wallpapers work in i965?).
>
> Rob
Hi, I've perfomed tests with mesa
https://github.com/maurossi/mesa/commits/13.0.0_nougat-x86
and the deafult pink wallpaper of nougat-x86 is working on i965
NOTE: I have cherry-picked
Assuming the hardware is set-up to use a screen coordinate system
flipped vertically with respect to the GL's window coordinate system,
the SYSTEM_VALUE_SAMPLE_POS vector will also be flipped vertically
with respect to the value expected by the GL, so we need to give it
the same treatment as
On Tue, Nov 01, 2016 at 12:58:22PM -0400, Adam Jackson wrote:
> On Sat, 2016-10-22 at 11:00 +0100, Chris Wilson wrote:
>
> > @@ -113,6 +113,11 @@ loader_dri3_drawable_fini(struct loader_dri3_drawable
> > *draw)
> > dri3_free_render_buffer(draw, draw->buffers[i]);
> > }
> >
> > +
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/swr/rasterizer/core/api.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/swr/rasterizer/core/api.cpp
b/src/gallium/drivers/swr/rasterizer/core/api.cpp
index 5f941e8..b1a426d
Signed-off-by: Ilia Mirkin
---
This fails one sub-case of the piglit depth_bounds test:
Test 10, bounds=(0.00, 0.50), z=(0.50, 0.50, 0.50, 0.50)
Probe color at (0,20)
Expected: 255 255 255
Observed: 26 26 26
I'm blaming it on the floating point boogey man.
https://bugs.freedesktop.org/show_bug.cgi?id=98428
--- Comment #11 from Kyle Brenneman ---
(In reply to Emil Velikov from comment #10)
> (In reply to Kyle Brenneman from comment #9)
> > > > > - And last but not least - reuse GLVND dispatch. For this we would
> > > > >
On 1 November 2016 at 23:49, Nicolai Hähnle wrote:
> On 01.11.2016 05:32, Dave Airlie wrote:
>>
>> From: Dave Airlie
>>
>> This just a discussion holder patch, radv has generated a shader
>> using discard that lowers the kilp intrinsic into
>>
>> s_mov_b64
On Mon, 2016-10-31 at 20:28 +, Emil Velikov wrote:
> >
> > One user, xdriinfo(1), which is admittedly pretty useless. But the
> > glvnd code in mesa definitely implements dispatch for it (libglvnd
> > itself does not, but is not expected to).
>
> libglvnd doesn't dispatch to it one cannot
https://bugs.freedesktop.org/show_bug.cgi?id=98526
Vinson Lee changed:
What|Removed |Added
OS|Mac OS X (All) |All
On Mon, Oct 31, 2016 at 9:53 PM, Jason Ekstrand wrote:
> This makes more sense than OUT_OF_HOST_MEMORY. Technically, you can
> recover from a failed execbuf2 but the batch you just submitted didn't
> fully execute so things are in an ill-defined state. The app doesn't want
Hi all
It's time to announce Mesa 13.0.0.
This release has huge amount of features, but without a doubt the biggest
ones are:
- Vulkan driver for hardware supported by the AMDGPU kernel driver*
- OpenGL 4.4/4.5 capability, yet the drivers may expose lower version due to
pending Khronos CTS
On Sat, 2016-10-22 at 11:00 +0100, Chris Wilson wrote:
> Xorg may implement fine grained per-drawable serialisation. If the
> client is reading from shared pixmap sources, flushing rendering to the
> current drawable is not enough (even if the current code did that, it
> does not). Instead,
On Sat, 2016-10-22 at 11:00 +0100, Chris Wilson wrote:
> @@ -113,6 +113,11 @@ loader_dri3_drawable_fini(struct loader_dri3_drawable
> *draw)
> dri3_free_render_buffer(draw, draw->buffers[i]);
> }
>
> + if (draw->sync_fence) {
> + xcb_sync_destroy_fence(draw->conn,
Much better. Thanks!
Reviewed-by: Jason Ekstrand
On Tue, Nov 1, 2016 at 8:03 AM, Topi Pohjolainen wrote:
> From: Ben Widawsky
>
> v2 (Jason):
>- Use PRM citation for SKL now that it is available
>- Also return
https://bugs.freedesktop.org/show_bug.cgi?id=98502
--- Comment #8 from Emil Velikov ---
The kernel patch is out and should fit the mailing list archives in due time.
Michel since Jammy is no longer around can you check (forward to AMDGPU-PRO
team) about the
From: Kristian Høgsberg Kristensen
This reduces the amount of stalling that the kernel does between batches
and improves the performance of Dota 2 on a Sky Lake GT2 desktop by around
30%.
v2 (Jason Ekstrand):
- Use canonical form addresses on gen8+ (Chris
https://bugs.freedesktop.org/show_bug.cgi?id=98502
--- Comment #7 from Mauro Santos ---
As a user, any band aid that will mask the problem until the proper long term
fix is in place will be very much welcomed.
As to how it is implemented, I am not familiar with the
On Tue, Nov 01, 2016 at 08:39:16AM -0700, Jason Ekstrand wrote:
>On Tue, Nov 1, 2016 at 1:07 AM, Chris Wilson <[1]ch...@chris-wilson.co.uk>
>wrote:
>
> On Mon, Oct 31, 2016 at 09:48:15PM -0700, Jason Ekstrand wrote:
> > From: Kristian Høgsberg Kristensen
>
On Tue, Nov 1, 2016 at 1:07 AM, Chris Wilson
wrote:
> On Mon, Oct 31, 2016 at 09:48:15PM -0700, Jason Ekstrand wrote:
> > From: Kristian Høgsberg Kristensen
> >
> > This reduces the amount of stalling that the kernel does between
On Sat, Oct 22, 2016 at 10:31:39PM -0700, Jason Ekstrand wrote:
> At least on Sky Lake, after emitting 3DSTATE_CONSTANT_*, you are required
> to re-emit the 3DSTATE_BINDING_TABLE_POINTERS packet for the corresponding
> stage. If you don't, double-buffering may fail and you may get the wrong
>
From: Ben Widawsky
On SKL (also fast clear is used for level 0, layer 0):
Manhattan 3.0: 3.88434% +/- 0.814659%
Manhattan 3.0 off: 3.25542% +/- 0.101149%
Trex: 3.43501% +/- 0.31223%
Trex off: 4.13781% +/- 0.0993569%
ON BDW:
From: Ben Widawsky
v2 (Jason):
- Use PRM citation for SKL now that it is available
- Also return false for gen < 8 mipmapped/arrayed
Signed-off-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 51
On Tue, Nov 1, 2016 at 2:01 AM, Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Tue, Nov 01, 2016 at 07:24:50AM +0200, Pohjolainen, Topi wrote:
> > On Mon, Oct 31, 2016 at 02:51:06PM -0700, Jason Ekstrand wrote:
> > >On Mon, Oct 31, 2016 at 2:38 PM, Jason Ekstrand
> > >
On 01.11.2016 05:32, Dave Airlie wrote:
From: Dave Airlie
This just a discussion holder patch, radv has generated a shader
using discard that lowers the kilp intrinsic into
s_mov_b64 exec, 0 ; BEFE0180
however that means exports never happen,
https://bugs.freedesktop.org/show_bug.cgi?id=98428
--- Comment #10 from Emil Velikov ---
(In reply to Kyle Brenneman from comment #9)
> > > > - And last but not least - reuse GLVND dispatch. For this we would
> > > > need to
> > > > convince Kyle that GLdisplatch.so
glXSwapBuffers() is translated internally into glXSwapBuffersMsc() with
a target and divisor of 0.
https://www.opengl.org/registry/specs/OML/glx_sync_control.txt
"If = 0, the swap will occur when MSC becomes greater than
or equal to ."
It does not require waiting until the next MSC,
The commit message is total non-sense. Exports are always executed
regardless of EXEC.
Marek
On Tue, Nov 1, 2016 at 5:32 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This just a discussion holder patch, radv has generated a shader
> using discard that
https://bugs.freedesktop.org/show_bug.cgi?id=98512
Laurent carlier changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
https://bugs.freedesktop.org/show_bug.cgi?id=98512
--- Comment #4 from Christian König ---
Well done, thanks for that.
Brian, Marek, Nicolai any idea what's causing this?
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact
https://bugs.freedesktop.org/show_bug.cgi?id=98512
Christian König changed:
What|Removed |Added
Assignee|dri-devel@lists.freedesktop
On 01.11.2016 00:25, Marek Olšák wrote:
On Mon, Oct 31, 2016 at 10:04 PM, Nicolai Hähnle wrote:
On 29.10.2016 13:17, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_texture.c | 13 +
On Tue, Nov 01, 2016 at 07:24:50AM +0200, Pohjolainen, Topi wrote:
> On Mon, Oct 31, 2016 at 02:51:06PM -0700, Jason Ekstrand wrote:
> >On Mon, Oct 31, 2016 at 2:38 PM, Jason Ekstrand
> ><[1]ja...@jlekstrand.net> wrote:
> >
> >On Tue, Oct 11, 2016 at 12:26 PM, Topi Pohjolainen
> >
On Tue, Nov 01, 2016 at 08:07:36AM +, Chris Wilson wrote:
> On Mon, Oct 31, 2016 at 09:48:15PM -0700, Jason Ekstrand wrote:
> > + * By doing relocations on the CPU, we can tell the kernel that it doesn't
> > + * need to bother. We want to do this because the surface state buffer is
> > + *
https://bugs.freedesktop.org/show_bug.cgi?id=98526
Bug ID: 98526
Summary: glsl/tests/general-ir-test regression
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: NEW
Keywords:
On lun, 2016-10-31 at 14:51 -0700, Kenneth Graunke wrote:
> On Monday, October 31, 2016 6:22:43 PM PDT Antia Puentes wrote:
> >
> > The emission of vertex attributes corresponding to dvec3 and dvec4
> > vertex shader input variables was not correct when the
> > passed
> > to the VertexAttribL*
On Mon, Oct 31, 2016 at 09:48:15PM -0700, Jason Ekstrand wrote:
> From: Kristian Høgsberg Kristensen
>
> This reduces the amount of stalling that the kernel does between batches
> and improves the performance of Dota 2 on a Sky Lake GT2 desktop by around
> 30%.
On 1 November 2016 6:00:46 pm AEDT, Timothy Arceri
wrote:
>On Tue, 2016-11-01 at 08:06 +0200, Tapani Pälli wrote:
>>
>> On 10/29/2016 03:29 AM, Kenneth Graunke wrote:
>> >
>> > On Friday, October 28, 2016 10:39:01 AM PDT Tapani Pälli wrote:
>> > >
>> > > On
On Tue, 2016-11-01 at 08:06 +0200, Tapani Pälli wrote:
>
> On 10/29/2016 03:29 AM, Kenneth Graunke wrote:
> >
> > On Friday, October 28, 2016 10:39:01 AM PDT Tapani Pälli wrote:
> > >
> > > On 10/28/2016 05:15 AM, Timothy Arceri wrote:
> > > >
> > > > On Thu, 2016-10-27 at 18:51 -0700, Kenneth
On Monday, October 31, 2016 9:53:44 PM PDT Jason Ekstrand wrote:
> This makes more sense than OUT_OF_HOST_MEMORY. Technically, you can
> recover from a failed execbuf2 but the batch you just submitted didn't
> fully execute so things are in an ill-defined state. The app doesn't want
> to
On 10/29/2016 03:29 AM, Kenneth Graunke wrote:
On Friday, October 28, 2016 10:39:01 AM PDT Tapani Pälli wrote:
On 10/28/2016 05:15 AM, Timothy Arceri wrote:
On Thu, 2016-10-27 at 18:51 -0700, Kenneth Graunke wrote:
On Thursday, October 27, 2016 9:03:12 PM PDT Timothy Arceri wrote:
On Thu,
84 matches
Mail list logo