Re: [Mesa-dev] [PATCH 0/0] gallium, radeonsi: pixel (un)packing fixes

For the series: Reviewed-by: Edward O'Callaghan Thanks, the PBO stuff fixes a problem I had with my video stream application also. On 11/10/2016 02:01 AM, Nicolai Hähnle wrote: > Hi, > > this is a series of assorted patches that together fix >

Re: [Mesa-dev] [PATCH 1/2] Fix races during _mesa_HashWalk().

I've pushed this one. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 Jani Kärkkäinen changed: What|Removed |Added CC|

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #44 from Jani Kärkkäinen --- I'm quite sure I'm getting this as well. I'm however on a HD6850, so that'd be the r600 driver I believe? Anything I can do to help pinpoint the culprit? Some specs: OpenGL

[Mesa-dev] [Bug 94979] dolphin-emu rendering broken on gallium/SWR + crashing often

https://bugs.freedesktop.org/show_bug.cgi?id=94979 Markus Wick changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 98691] egl.h:55: error: redefinition of typedef ‘EGLDisplay’

https://bugs.freedesktop.org/show_bug.cgi?id=98691 Bug ID: 98691 Summary: egl.h:55: error: redefinition of typedef ‘EGLDisplay’ Product: Mesa Version: 13.0 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] Mesa 13.0.1 release candidate

On Fri, Nov 11, 2016 at 10:13 AM, Emil Velikov wrote: > Hello list, > > The candidate for the Mesa 12.0.4 is now available. Currently we have: > - 51 queued > - 18 nominated (outstanding) > - and 0 (self-)rejected patches > > As one can imagine huge hunk of the

Re: [Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver

On 10 November 2016 at 20:42, Emil Velikov wrote: > On 10 November 2016 at 20:18, Kyriazis, George > wrote: >> Emil, >> >> I've followed the approach of trying to localize the swr changes to where >> they belong in order to avoid "polluting"

Re: [Mesa-dev] [PATCH 4/4] nir/spirv: Make gl_PrimitiveId a system value

On Fri, Nov 11, 2016 at 1:39 PM, Ilia Mirkin wrote: > On Fri, Nov 11, 2016 at 10:23 AM, Jason Ekstrand > wrote: > > On Nov 11, 2016 6:16 AM, "Ilia Mirkin" wrote: > >> > >> I haven't checked spirv for the specific naming, but

Re: [Mesa-dev] [PATCH 3/3] i965: Fix KBL typo in string

On Thu, Nov 10, 2016 at 10:24 AM, Ben Widawsky wrote: > On 16-11-10 10:20:13, Ben Widawsky wrote: >> >> From: Ben Widawsky >> >> Signed-off-by: Ben Widawsky >> --- >> include/pci_ids/i965_pci_ids.h | 2 +- >> 1 file changed, 1

Re: [Mesa-dev] Mesa 13.0.1 release candidate

On Fri, Nov 11, 2016 at 8:10 PM, Emil Velikov wrote: > On 11 November 2016 at 18:36, Laurent Carlier wrote: >> Le vendredi 11 novembre 2016, 18:13:25 CET Emil Velikov a écrit : >>> Hello list, >>> >>> The candidate for the Mesa 12.0.4 is now

Re: [Mesa-dev] [PATCH] ac/nir/llvm: Fix setting function attributes for intrinsics

On Fri, Nov 11, 2016 at 10:35 PM, Daniel Scharrer wrote: > On 2016-11-11 22:24, Bas Nieuwenhuizen wrote: >> Maybe also add an assert in ac_add_function_attr that the attr is a >> single flag? Something like >> >> assert(attr && util_is_power_of_two(attr)); > > There is

Re: [Mesa-dev] [PATCH 4/4] nir/spirv: Make gl_PrimitiveId a system value

On Fri, Nov 11, 2016 at 10:23 AM, Jason Ekstrand wrote: > On Nov 11, 2016 6:16 AM, "Ilia Mirkin" wrote: >> >> I haven't checked spirv for the specific naming, but note that prim ID can >> be an output in gs. > > You're right. I'm not 100% site how we

Re: [Mesa-dev] [PATCH] ac/nir/llvm: Fix setting function attributes for intrinsics

On 2016-11-11 22:24, Bas Nieuwenhuizen wrote: > Maybe also add an assert in ac_add_function_attr that the attr is a > single flag? Something like > > assert(attr && util_is_power_of_two(attr)); There is already a warning printed for unknown attributes in ac_attr_to_llvm_attr / attr_to_str that

Re: [Mesa-dev] [PATCH] ac/nir/llvm: Fix setting function attributes for intrinsics

Maybe also add an assert in ac_add_function_attr that the attr is a single flag? Something like assert(attr && util_is_power_of_two(attr)); Either way, this patch is Reviewed-by: Bas Nieuwenhuizen On Fri, Nov 11, 2016 at 9:36 PM, Daniel Scharrer

Re: [Mesa-dev] [PATCH 00/14] swr: update rasterizer

Reviewed-by: Bruce Cherniak > On Nov 9, 2016, at 9:18 PM, Tim Rowley wrote: > > Highlights include more 8x2 render work, fix for alphatest, and > archrast updates. > > Tim Rowley (14): > swr: [rasterizer jitter] code style fix > swr:

[Mesa-dev] [PATCH] ac/nir/llvm: Fix setting function attributes for intrinsics

This fixes a NULL pointer dereference for intrinsics with more than one function attribute introduced in commit 2fdaf38. The fix is ported from the lp_build_intrinsic changes in commit 8bdd52c. --- I'm a bit unsure about the index change from 0 to -1, but the gallium code does this as well and

[Mesa-dev] [Bug 97422] trying to call a number as a function results into a crash

https://bugs.freedesktop.org/show_bug.cgi?id=97422 Karol Herbst changed: What|Removed |Added Summary|function call to function |trying to call a

Re: [Mesa-dev] [Intel-gfx] [PATCH] intel: Add Geminilake PCI IDs

On Thu, Nov 10, 2016 at 10:28 AM, Ben Widawsky wrote: > > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > --- > intel/intel_chipset.h | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git

[Mesa-dev] [Bug 97422] function call to function with "|" in name crashes glsl_compiler

https://bugs.freedesktop.org/show_bug.cgi?id=97422 --- Comment #3 from Karol Herbst --- Created attachment 127920 --> https://bugs.freedesktop.org/attachment.cgi?id=127920=edit more simple example seems like this crashes mesa already -- You are receiving this mail

Re: [Mesa-dev] Mesa 13.0.1 release candidate

On 11 November 2016 at 18:36, Laurent Carlier wrote: > Le vendredi 11 novembre 2016, 18:13:25 CET Emil Velikov a écrit : >> Hello list, >> >> The candidate for the Mesa 12.0.4 is now available. Currently we have: >> - 51 queued >> - 18 nominated (outstanding) >> - and 0

Re: [Mesa-dev] Mesa 13.0.1 release candidate

Le vendredi 11 novembre 2016, 18:13:25 CET Emil Velikov a écrit : > Hello list, > > The candidate for the Mesa 12.0.4 is now available. Currently we have: > - 51 queued > - 18 nominated (outstanding) > - and 0 (self-)rejected patches > > As one can imagine huge hunk of the commits are fixes

Re: [Mesa-dev] [PATCH 1/2] mesa: add NV_image_formats extension support

On Fri, Nov 11, 2016 at 10:40 AM, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98480 > --- > src/compiler/glsl/glsl_parser.yy | 5 +-- >

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #43 from Steven --- I also experience the issue. If someone can explain or point me to how I can profile it I can also try to provide some api traces. I'm running Mesa 12.0.3 OpenGL renderer string: Gallium

[Mesa-dev] Mesa 13.0.1 release candidate

Hello list, The candidate for the Mesa 12.0.4 is now available. Currently we have: - 51 queued - 18 nominated (outstanding) - and 0 (self-)rejected patches As one can imagine huge hunk of the commits are fixes in the Vulkan drivers. Up-to 30% performance increase using the Intel ANV Vulkan

Re: [Mesa-dev] [PATCH 3/3] egl/wayland: unify dri2_wl_create_surface implementations

On 11 November 2016 at 17:19, Daniel Stone wrote: > Hi, > > On 11 November 2016 at 16:45, Emil Velikov wrote: >> @@ -174,14 +172,24 @@ dri2_wl_create_surface(_EGLDriver *drv, _EGLDisplay >> *disp, >> config = dri2_get_dri_config(dri2_conf,

[Mesa-dev] [Bug 98681] ir_builder_print_visitor.cpp:401:67: error: expected ')' before 'PRIx64'

https://bugs.freedesktop.org/show_bug.cgi?id=98681 Brian Paul changed: What|Removed |Added Status|REOPENED|RESOLVED

Re: [Mesa-dev] [PATCH 1/3] egl/wayland: use the destroy_window_callback for swrast

On 11 November 2016 at 17:12, Daniel Stone wrote: > Hi, > > On 11 November 2016 at 16:44, Emil Velikov wrote: >> As described in commit 690ead4a135 ("egl/wayland-egl: Fix for segfault >> in dri2_wl_destroy_surface.") if we attempt to destroy a EGL

Re: [Mesa-dev] [PATCH] egl/wayland: fix return value in dri2_wl_swrast_commit_backbuffer

Hi, On 11 November 2016 at 16:27, Emil Velikov wrote: > The function returns "void" rather than int. We could rework that, yet > again there will be no benefit since all the callers have no use of it. > > Fixes: 9ca6711faa0 ("Revert "wayland: Block for the frame

Re: [Mesa-dev] [PATCH 3/3] egl/wayland: unify dri2_wl_create_surface implementations

Hi, On 11 November 2016 at 16:45, Emil Velikov wrote: > @@ -174,14 +172,24 @@ dri2_wl_create_surface(_EGLDriver *drv, _EGLDisplay > *disp, > config = dri2_get_dri_config(dri2_conf, EGL_WINDOW_BIT, > dri2_surf->base.GLColorspace); >

Re: [Mesa-dev] [PATCH 1/3] egl/wayland: use the destroy_window_callback for swrast

Hi, On 11 November 2016 at 16:44, Emil Velikov wrote: > As described in commit 690ead4a135 ("egl/wayland-egl: Fix for segfault > in dri2_wl_destroy_surface.") if we attempt to destroy a EGL surface > attached to already destroyed Wayland window we'll get a segfault.

Re: [Mesa-dev] [PATCH] glsl: define __STDC_FORMAT_MACROS to get PRIx64 macro

On 11/11/16 16:18, Brian Paul wrote: Otherwise, inttypes.h may not define the macro for C++ on MinGW. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98681 --- src/compiler/glsl/ir_builder_print_visitor.cpp | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH 2/2] mesa: fold always true conditional

On 11/11/2016 09:43 AM, Emil Velikov wrote: From: Emil Velikov Signed-off-by: Emil Velikov --- src/mesa/main/context.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/context.c

Re: [Mesa-dev] [PATCH 1/2] mesa: drop unneeded assert

On 11/11/2016 09:43 AM, Emil Velikov wrote: From: Emil Velikov As seen a couple of lines above - there's no way for the assert to trigger. Signed-off-by: Emil Velikov --- src/mesa/main/framebuffer.c | 1 - 1 file changed, 1

[Mesa-dev] [PATCH 1/3] egl/wayland: use the destroy_window_callback for swrast

From: Emil Velikov As described in commit 690ead4a135 ("egl/wayland-egl: Fix for segfault in dri2_wl_destroy_surface.") if we attempt to destroy a EGL surface attached to already destroyed Wayland window we'll get a segfault. Cc: "12.0 13.0"

[Mesa-dev] [PATCH 3/3] egl/wayland: unify dri2_wl_create_surface implementations

From: Emil Velikov Rather than having two almost identical codepaths (one for HW/wl_drm and another for SW/wl_shm), just factorise and reuse in both places. Signed-off-by: Emil Velikov --- Another fine example of useless duplication that

[Mesa-dev] [PATCH 2/3] egl/wayland: remove non-applicable destroyDrawable from error path

From: Emil Velikov If we fail to create the drawable there's not much point in attampting to destroy it. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[Mesa-dev] [PATCH 1/2] mesa: drop unneeded assert

From: Emil Velikov As seen a couple of lines above - there's no way for the assert to trigger. Signed-off-by: Emil Velikov --- src/mesa/main/framebuffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/framebuffer.c

[Mesa-dev] [PATCH 2/2] mesa: fold always true conditional

From: Emil Velikov Signed-off-by: Emil Velikov --- src/mesa/main/context.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 80bee16..bd4551e 100644 ---

[Mesa-dev] [PATCH 1/3] egl/x11: factor out dri2_get_xcb_connection()

From: Emil Velikov Identical throughout dri2, dri3 and drisw. Next patch will add more common code, so rather than duplicating it factor out the function. Note: this also sets eglError on failure. Something that's quite inconsistent throughout the codebase.

[Mesa-dev] [PATCH 2/3] egl/x11: store xcb_screen_t *screen instead of int screen

From: Emil Velikov Just fetch and store it once, rather than doing the xcb_setup_roots_iterator + get_xcb_screen dance five times. Signed-off-by: Emil Velikov --- These two patches are an example of the duplication we have within each

[Mesa-dev] [PATCH 3/3] auxiliary/vl/dri: call get_xcb_screen() only once

From: Emil Velikov Signed-off-by: Emil Velikov --- src/gallium/auxiliary/vl/vl_winsys_dri.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri.c

[Mesa-dev] [PATCH] egl/wayland: fix return value in dri2_wl_swrast_commit_backbuffer

From: Emil Velikov The function returns "void" rather than int. We could rework that, yet again there will be no benefit since all the callers have no use of it. Fixes: 9ca6711faa0 ("Revert "wayland: Block for the frame callback in get_back_bo not

Re: [Mesa-dev] [PATCH] glsl: define __STDC_FORMAT_MACROS to get PRIx64 macro

On 11 November 2016 at 16:18, Brian Paul wrote: > Otherwise, inttypes.h may not define the macro for C++ on MinGW. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98681 > --- > src/compiler/glsl/ir_builder_print_visitor.cpp | 1 + > 1 file changed, 1 insertion(+) >

[Mesa-dev] [PATCH 2/2] st/va: fix gop size for rate control

From: Boyuan Zhang The gop_size in rate control is the budget window for internal rate control calculation, and shouldn't always equal to idr period. Define a coefficient to let budget window contains a number of idr period for proper rate control calculation. Adjust the

[Mesa-dev] [PATCH 1/2] st/va: force to submit two consecutive single jobs

From: Boyuan Zhang When using dual instance and rate control, driver needs to submit jobs either in dual submissions or 2 consecutive single submissions to keep the pattern constant for rate control Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=98005 Signed-off-by:

[Mesa-dev] [PATCH] glsl: define __STDC_FORMAT_MACROS to get PRIx64 macro

Otherwise, inttypes.h may not define the macro for C++ on MinGW. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98681 --- src/compiler/glsl/ir_builder_print_visitor.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/ir_builder_print_visitor.cpp

Re: [Mesa-dev] [PATCH] glsl: try again to fix PRIx64 / MinGW build problem

On 11/11/2016 09:03 AM, Jose Fonseca wrote: On 11/11/16 15:48, Brian Paul wrote: inttypes.h doesn't always define the PRIx64 macro when compiling C++ code with MinGW. For that case, simply define PRIx64 to be "lx". This generates a format/argument type mismatch warning. And using "llx"

Re: [Mesa-dev] [PATCH] glsl: try again to fix PRIx64 / MinGW build problem

On 11/11/16 15:48, Brian Paul wrote: inttypes.h doesn't always define the PRIx64 macro when compiling C++ code with MinGW. For that case, simply define PRIx64 to be "lx". This generates a format/argument type mismatch warning. And using "llx" generates other warnings. Just live with it.

Re: [Mesa-dev] [PATCH] clover: fix building since llvm r286566

On Fri, Nov 11, 2016 at 02:00:26PM +0100, Laurent Carlier wrote: Reviewed-by: Tom Stellard > pretty trivial fix > --- > src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git

[Mesa-dev] [PATCH] glsl: try again to fix PRIx64 / MinGW build problem

inttypes.h doesn't always define the PRIx64 macro when compiling C++ code with MinGW. For that case, simply define PRIx64 to be "lx". This generates a format/argument type mismatch warning. And using "llx" generates other warnings. Just live with it.

[Mesa-dev] [PATCH 0/2] NV_image_formats extension support

Hi, There is some interest in having broader image format support in GLES 3.1 (mostly for R8/RG8). Ilia pointed out that NV_image_formats could be the extension we need to enable this. So here are a couple of patches to add the extension to Mesa and enable it on the i965 driver. An associated

[Mesa-dev] [PATCH 2/2] i965: enable NV_image_formats support

Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98480 --- src/mesa/drivers/dri/i965/intel_extensions.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c

[Mesa-dev] [PATCH 1/2] mesa: add NV_image_formats extension support

Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98480 --- src/compiler/glsl/glsl_parser.yy | 5 +-- src/compiler/glsl/glsl_parser_extras.cpp | 58

[Mesa-dev] [Bug 98681] ir_builder_print_visitor.cpp:401:67: error: expected ')' before 'PRIx64'

https://bugs.freedesktop.org/show_bug.cgi?id=98681 --- Comment #5 from Brian Paul --- (In reply to Roland Scheidegger from comment #4) > (In reply to Brian Paul from comment #3) > > Actually, this is still failing with our Jenkins build. Hmm... > > I've got some feeling this

Re: [Mesa-dev] [PATCH 4/4] nir/spirv: Make gl_PrimitiveId a system value

On Nov 11, 2016 6:16 AM, "Ilia Mirkin" wrote: > > I haven't checked spirv for the specific naming, but note that prim ID can be an output in gs. You're right. I'm not 100% site how we handle that today. We probably just pass it through as a varying. It looks like the

[Mesa-dev] [Bug 98681] ir_builder_print_visitor.cpp:401:67: error: expected ')' before 'PRIx64'

https://bugs.freedesktop.org/show_bug.cgi?id=98681 --- Comment #4 from Roland Scheidegger --- (In reply to Brian Paul from comment #3) > Actually, this is still failing with our Jenkins build. Hmm... I've got some feeling this is due this being in c++ code? -- You are

Re: [Mesa-dev] [PATCH 9/9] radeonsi: fix a subtle bounds checking corner case with 3-component attributes

For the series: Reviewed-by: Marek Olšák Marek On Wed, Nov 9, 2016 at 4:01 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > I'm also sending out a piglit test, gl-2.0/vertexattribpointer-size-3, > which exposes this corner

[Mesa-dev] [Bug 98681] ir_builder_print_visitor.cpp:401:67: error: expected ')' before 'PRIx64'

https://bugs.freedesktop.org/show_bug.cgi?id=98681 Brian Paul changed: What|Removed |Added Resolution|FIXED |---

[Mesa-dev] [Bug 98681] ir_builder_print_visitor.cpp:401:67: error: expected ')' before 'PRIx64'

https://bugs.freedesktop.org/show_bug.cgi?id=98681 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 4/4] nir/spirv: Make gl_PrimitiveId a system value

I haven't checked spirv for the specific naming, but note that prim ID can be an output in gs. On Nov 11, 2016 1:34 AM, "Jason Ekstrand" wrote: > Before, we were treating it as an output which is just completely bogus. > We could go for an input but a system value makes

[Mesa-dev] [PATCH] clover: fix building since llvm r286566

pretty trivial fix --- src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp b/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp index 108f8d5..8e89a49 100644 ---

[Mesa-dev] [Bug 97230] MATLAB hangs if DRI3 enabled with intel driver

https://bugs.freedesktop.org/show_bug.cgi?id=97230 --- Comment #11 from Eero Tamminen --- (In reply to f.mach4 from comment #8) > Created attachment 127912 [details] > GDB full trace when MATLAB has hanged Ok, so everything is in pthread_cond_wait(), except couple of

[Mesa-dev] [Bug 98681] ir_builder_print_visitor.cpp:401:67: error: expected ')' before 'PRIx64'

https://bugs.freedesktop.org/show_bug.cgi?id=98681 Vinson Lee changed: What|Removed |Added CC||i...@freedesktop.org,

[Mesa-dev] [PATCH] i965/vec4: skip registers already marked as no_spill

Do not evaluate spill costs for registers that were already marked as no_spill. --- src/mesa/drivers/dri/i965/brw_vec4_reg_allocate.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_reg_allocate.cpp

[Mesa-dev] [Bug 98681] ir_builder_print_visitor.cpp:401:67: error: expected ')' before 'PRIx64'

https://bugs.freedesktop.org/show_bug.cgi?id=98681 Bug ID: 98681 Summary: ir_builder_print_visitor.cpp:401:67: error: expected ')' before 'PRIx64' Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: