Re: [Mesa-dev] [PATCH] glsl: Use ir_var_temporary when generating inline functions.

2016-12-19 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2016-12-19 at 15:29 -0800, Kenneth Graunke wrote: > We were using ir_var_auto for the inlined function parameter > variables, > which is wrong, as it suggests that those are real variables declared > by the program. > > Normally this

Re: [Mesa-dev] [PATCH 1/3] gallium: add renderonly library

2016-12-19 Thread Christian Gmeiner
2016-12-19 22:50 GMT+01:00 Thierry Reding : > On Mon, Dec 19, 2016 at 08:54:04PM +0100, Christian Gmeiner wrote: >> 2016-12-19 14:08 GMT+01:00 Thierry Reding : >> > On Wed, Nov 30, 2016 at 02:44:34PM +0100, Christian Gmeiner wrote: > [...] >> >>

[Mesa-dev] [PATCH] egl/dri2: implement query surface hook

2016-12-19 Thread Tapani Pälli
This makes better guarantee that the values we return are in sync what the underlying drawable currently has. Together with dEQP change bug #98327 this fixes following test: dEQP-EGL.functional.resize.surface_size.grow Signed-off-by: Tapani Pälli Bugzilla:

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

2016-12-19 Thread Samuel Iglesias Gonsálvez
On Mon, 2016-12-19 at 11:31 -0600, Matt Turner wrote: > On Mon, Dec 19, 2016 at 2:00 AM, Samuel Iglesias Gonsálvez > wrote: > > Hello Matt, > > > > We have done most of the suggestions you made to our patches. > > However, > > we have replied to some of your

Re: [Mesa-dev] [PATCH] new EGL internal SyncSurface hook

2016-12-19 Thread Tapani Pälli
Forget about this ... with some more coffee I realized I can just go and implement the geometry fetching in QuerySurface hook for dri2 x11, will send a patch for that! Sorry about the noise! On 12/19/2016 02:36 PM, Tapani Pälli wrote: Hi; I've been investigating dEQP EGL bugs. Following

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

2016-12-19 Thread Edward O'Callaghan
Acked-by: Edward O'Callaghan On 12/20/2016 02:59 PM, Arda Coskunses wrote: > Without this check driver crash when application window > closed unexpectedly. > --- > src/vulkan/wsi/wsi_common_x11.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

[Mesa-dev] [PATCH] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-19 Thread Jason Ekstrand
This sequence shows up The Talos Principal, at least under Vulkan, and prevents loop analysis from properly computing trip counts in a few loops. --- src/compiler/nir/nir_opt_algebraic.py | 8 1 file changed, 8 insertions(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py

[Mesa-dev] [Bug 99076] dEQP-GLES3.functional.negative_api.texture#teximage3d fails due to wrong Error code

2016-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99076 Gary Wang changed: What|Removed |Added CC||gary.c.w...@intel.com

[Mesa-dev] [PATCH 2/2] i965: make use of nir_lower_returns() for GL

2016-12-19 Thread Timothy Arceri
Fixes two new piglit tests: spec/glsl-1.10/execution/vs-nested-return-sibling-loop.shader_test spec/glsl-1.10/execution/vs-nested-return-sibling-loop2.shader_test shader-db results for BDW: total instructions in shared programs: 12903158 -> 12903134 (-0.00%) instructions in affected programs:

[Mesa-dev] [PATCH 1/2] nir: update nir_lower_returns to only predicate instructions when needed

2016-12-19 Thread Timothy Arceri
Unless an if statement contains nested returns we can simply add any following instructions to the branch without the return. V2: fix handling if_nested_return value when there is a sibling if/loop that doesn't contain a return. (Spotted by Ken) --- src/compiler/nir/nir_lower_returns.c | 37

[Mesa-dev] [PATCH 0/6] nir: A couple of SPIR-V focused loop optimizations

2016-12-19 Thread Jason Ekstrand
While working with Tim on loop unrolling, I realized that the new NIR loop unrolling pass couldn't actually unroll any loops coming out of SPIR-V thanks to the way we handle continues. This little series adds two relatively small optimization passes that deal with this by peeling apart ifs at the

[Mesa-dev] [PATCH 3/6] nir: Expose function_impl versions of copy-prop and dce

2016-12-19 Thread Jason Ekstrand
--- src/compiler/nir/nir.h| 2 ++ src/compiler/nir/nir_opt_copy_propagate.c | 2 +- src/compiler/nir/nir_opt_dce.c| 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 0fd6a77..89b0c70 100644

[Mesa-dev] [PATCH 5/6] nir: Add a pass for moving SPIR-V continue blocks to the ends of loops

2016-12-19 Thread Jason Ekstrand
When shaders come in from SPIR-V, we handle continue blocks by placing the contents of the continue inside of a "if (!first_iteration)". We do this so that we can properly handle the fact that continues in SPIR-V jump to the continue block at the end of the loop rather than jumping directly to

[Mesa-dev] [PATCH 2/6] nir: Correctly handle blocks in cf_node_cf_tree_next

2016-12-19 Thread Jason Ekstrand
--- src/compiler/nir/nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c index e522a67..b8d1abd 100644 --- a/src/compiler/nir/nir.c +++ b/src/compiler/nir/nir.c @@ -1754,7 +1754,7 @@ nir_block

[Mesa-dev] [PATCH 6/6] i965: Use nir_opt_trivial_continues and nir_opt_if

2016-12-19 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_nir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_nir.c b/src/mesa/drivers/dri/i965/brw_nir.c index 0c1fb44..a091861 100644 --- a/src/mesa/drivers/dri/i965/brw_nir.c +++ b/src/mesa/drivers/dri/i965/brw_nir.c @@ -429,6

[Mesa-dev] [PATCH 4/6] nir: Add an optimization pass to remove trivial continues

2016-12-19 Thread Jason Ekstrand
--- src/compiler/Makefile.sources| 1 + src/compiler/nir/nir.h | 2 + src/compiler/nir/nir_opt_trivial_continues.c | 141 +++ 3 files changed, 144 insertions(+) create mode 100644 src/compiler/nir/nir_opt_trivial_continues.c diff

[Mesa-dev] [PATCH 1/6] nir: Add a couple quick-and-dirty out-of-SSA helpers

2016-12-19 Thread Jason Ekstrand
These are designed for use within an optimization pass when SSA becomes more pain than it's worth. They're very naive and don't generate anything close to optimal register-based NIR. Also, they may result in shaders which do not validate because of, for instance, registers in phi sources.

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Kenneth Graunke
On Monday, December 19, 2016 8:41:17 PM PST Matt Turner wrote: > On Mon, Dec 19, 2016 at 4:13 PM, Kenneth Graunke > wrote: > > For what it's worth, the OpenGL wiki's Program Introspection page(*), > > under "Interface block member naming" gives an example matching my above

[Mesa-dev] [PATCH] vulkan/wsi/x11: don't crash on null wsi x11 connection

2016-12-19 Thread Arda Coskunses
Without this check driver crash when application window closed unexpectedly. --- src/vulkan/wsi/wsi_common_x11.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c index 25ba0c1..afb7809 100644 ---

Re: [Mesa-dev] [PATCH v3] compiler/glsl: fix precision problem of tanh

2016-12-19 Thread Roland Scheidegger
Am 20.12.2016 um 00:12 schrieb Giuseppe Bilotta: > Hello, > > I realize that I'm a little late to comment about this, but I think > the formula used for > tanh should be changed again. Specifically, as suggested by Roland > > On Fri, Dec 9, 2016 at 5:41 AM, Roland Scheidegger

Re: [Mesa-dev] [PATCH] glsl: Elminate the open-coded version of process_block_array_leaf

2016-12-19 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Matt Turner
On Mon, Dec 19, 2016 at 4:13 PM, Kenneth Graunke wrote: > For what it's worth, the OpenGL wiki's Program Introspection page(*), > under "Interface block member naming" gives an example matching my above > reply. It says: > > uniform BlockName3 > { > int mem;

[Mesa-dev] [PATCH] radeonsi: Bugfix needed for hashcat

2016-12-19 Thread Christian Inci
Hashcat needs MAX_GLOBAL_BUFFERS to be 21 or even 22 for some modes. It'll crash otherwise. I'm adding an assert to see if programs need it to be even higher. Signed-off-by: Christian Inci --- src/gallium/drivers/radeonsi/si_compute.c | 3 ++- 1 file changed,

[Mesa-dev] [PATCH] glsl: Elminate the open-coded version of process_block_array_leaf

2016-12-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/link_uniform_blocks.cpp | 40 +++ 1 file changed, 9 insertions(+), 31 deletions(-) diff --git a/src/compiler/glsl/link_uniform_blocks.cpp

Re: [Mesa-dev] [PATCH v3] compiler/glsl: fix precision problem of tanh

2016-12-19 Thread Ilia Mirkin
On Mon, Dec 19, 2016 at 8:17 PM, Matt Turner wrote: > On Mon, Dec 19, 2016 at 5:12 PM, Giuseppe Bilotta > wrote: >> Just one question though —not knowing much of the shader language, can >> I expect expm1 to be available? > > No, expm1 doesn't

Re: [Mesa-dev] [PATCH v3] compiler/glsl: fix precision problem of tanh

2016-12-19 Thread Matt Turner
On Mon, Dec 19, 2016 at 5:12 PM, Giuseppe Bilotta wrote: > Just one question though —not knowing much of the shader language, can > I expect expm1 to be available? No, expm1 doesn't exist in GLSL. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] mesa: don't attempt to unlock an unlocked debug state mutex

2016-12-19 Thread Jonathan Gray
Can someone push this to master? On Sun, Dec 11, 2016 at 07:21:36PM +0100, Eduardo Lima Mitev wrote: > Looks good. > > Reviewed-by: Eduardo Lima Mitev > > On 12/11/2016 04:42 PM, Jonathan Gray wrote: > > Commit 929fcee47e46781c57f2a354ce0a013915c033d1 introduced code that > >

Re: [Mesa-dev] [PATCH] glsl: Use ir_var_temporary when generating inline functions.

2016-12-19 Thread Ilia Mirkin
Makes sense. Reviewed-by: Ilia Mirkin On Mon, Dec 19, 2016 at 6:33 PM, Kenneth Graunke wrote: > On Monday, December 19, 2016 3:29:13 PM PST Kenneth Graunke wrote: >> We were using ir_var_auto for the inlined function parameter variables, >> which is

Re: [Mesa-dev] [PATCH] glsl: Use ir_var_temporary when generating inline functions.

2016-12-19 Thread Kenneth Graunke
On Monday, December 19, 2016 3:29:13 PM PST Kenneth Graunke wrote: > We were using ir_var_auto for the inlined function parameter variables, > which is wrong, as it suggests that those are real variables declared > by the program. > > Normally this doesn't matter. However, if you called

[Mesa-dev] [Bug 99154] Link time error when using multiple builtin functions

2016-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99154 Kenneth Graunke changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] glsl: Use ir_var_temporary when generating inline functions.

2016-12-19 Thread Kenneth Graunke
We were using ir_var_auto for the inlined function parameter variables, which is wrong, as it suggests that those are real variables declared by the program. Normally this doesn't matter. However, if you called built-ins at global scope, it would pollute the global variable namespace with these

Re: [Mesa-dev] [PATCH v3] compiler/glsl: fix precision problem of tanh

2016-12-19 Thread Giuseppe Bilotta
Hello, I realize that I'm a little late to comment about this, but I think the formula used for tanh should be changed again. Specifically, as suggested by Roland On Fri, Dec 9, 2016 at 5:41 AM, Roland Scheidegger wrote: > btw I'm wondering if some vendors wouldn't implement

[Mesa-dev] [PATCH v2] st/nine: Upload on secondary context for Draw*Up

2016-12-19 Thread Axel Davy
Avoid synchronization by using the secondary context for uploading the vertex data for Draw*Up. v2: Rely on u_upload_mgr to use persistent coherent buffers. Do not flush. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 23 +++ 1

[Mesa-dev] [PATCH 84/84 v7] st/nine: Implement new buffer upload path

2016-12-19 Thread Axel Davy
This new buffer upload path enables to lock faster than the normal path when using DISCARD/NOOVERWRITE. v2: Diverse cleanups and fixes. v3: Fix allocation size for 'lone' buffers and add more debug info. v4: Rewrite of the path to handle when DISCARD/NOOVERWRITE is not used anymore. The resource

[Mesa-dev] [PATCH 1/2] radeonsi: add Polaris12 support (v3)

2016-12-19 Thread Alex Deucher
From: Junwei Zhang v2: use gfxip names for llvm 4.0+ v3: use tonga for llvm <= 3.8 Signed-off-by: Junwei Zhang Reviewed-by: Nicolai Hähnle Acked-by: Christian König ---

Re: [Mesa-dev] [PATCH] glsl: Drop bogus is_vertex_input from add_shader_variable().

2016-12-19 Thread Anuj Phogat
On Fri, Dec 16, 2016 at 9:46 PM, Kenneth Graunke wrote: > > stage_mask is a bitmask of shader stages, so the proper comparison would > be (1 << MESA_SHADER_VERTEX), not MESA_SHADER_VERTEX itself. > > But we only care for structure types, and VS inputs cannot be structs. >

Re: [Mesa-dev] [PATCH 04/19] glsl: Use simpler visitor to determine which UBO and SSBO blocks are used

2016-12-19 Thread Ian Romanick
On 12/18/2016 10:09 PM, Timothy Arceri wrote: > On Thu, 2016-12-15 at 20:10 -0800, Ian Romanick wrote: >> From: Ian Romanick >> >> Very soon this visitor will get more complicated. The users of the >> existing ir_variable_refcount visitor won't need the coming >>

Re: [Mesa-dev] [PATCH 03/19] glsl: Track the linearized array index for each UBO instance array element

2016-12-19 Thread Ian Romanick
On 12/18/2016 09:54 PM, Timothy Arceri wrote: > On Thu, 2016-12-15 at 20:10 -0800, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> Cc: mesa-sta...@lists.freedesktop.org >> --- >>

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Kenneth Graunke
On Monday, December 19, 2016 1:36:00 PM PST Ian Romanick wrote: > On 12/16/2016 09:35 PM, Kenneth Graunke wrote: > > This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's > > arb_program_interface_query/arb_program_interface_query-resource-query, > > and

Re: [Mesa-dev] [PATCH v2 043/103] i965/vec4: handle 32 and 64 bit channels in liveness analysis

2016-12-19 Thread Francisco Jerez
Iago Toral Quiroga writes: > From: "Juan A. Suarez Romero" > > Our current data flow analysis does not take into account that channels > on 64-bit operands are 64-bit. This is a problem when the same register > is accessed using both 64-bit and 32-bit

Re: [Mesa-dev] [PATCH 1/3] gallium: add renderonly library

2016-12-19 Thread Thierry Reding
On Mon, Dec 19, 2016 at 08:54:04PM +0100, Christian Gmeiner wrote: > 2016-12-19 14:08 GMT+01:00 Thierry Reding : > > On Wed, Nov 30, 2016 at 02:44:34PM +0100, Christian Gmeiner wrote: [...] > >> GALLIUM_WINSYS_CFLAGS = \ > >> -I$(top_srcdir)/src \ > >>

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Ian Romanick
On 12/16/2016 09:35 PM, Kenneth Graunke wrote: > This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's > arb_program_interface_query/arb_program_interface_query-resource-query, > and GL45-CTS.program_interface_query.separate-programs-{tess-control, > tess-eval,geometry}. Only one

[Mesa-dev] [Bug 99154] Link time error when using multiple builtin functions

2016-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99154 Bug ID: 99154 Summary: Link time error when using multiple builtin functions Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

[Mesa-dev] [Bug 99154] Link time error when using multiple builtin functions

2016-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99154 Niels Ole Salscheider changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 3/3] imx: gallium driver for imx-drm scanout driver

2016-12-19 Thread Thierry Reding
On Mon, Dec 19, 2016 at 04:04:34PM +, Emil Velikov wrote: > On Monday, 19 December 2016, Thierry Reding > wrote: > > > On Wed, Nov 30, 2016 at 02:44:36PM +0100, Christian Gmeiner wrote: > > [...] > > > +static struct pipe_screen *imx_open_render_node(struct

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add Polaris12 support (v2)

2016-12-19 Thread Andreas Boll
2016-12-19 21:41 GMT+01:00 Alex Deucher : > diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c > b/src/gallium/drivers/radeon/r600_pipe_common.c > index 0b5c6dc..76a34fe 100644 > --- a/src/gallium/drivers/radeon/r600_pipe_common.c > +++

[Mesa-dev] [PATCH 1/2] radeonsi: add Polaris12 support (v2)

2016-12-19 Thread Alex Deucher
From: Junwei Zhang v2: use gfxip names for llvm 4.0+ Signed-off-by: Junwei Zhang Reviewed-by: Nicolai Hähnle Acked-by: Christian König --- src/amd/addrlib/r800/ciaddrlib.cpp| 3 ++-

Re: [Mesa-dev] [PATCH 08/19] glsl: Walk a list of ir_dereference_array to mark array elements as accessed

2016-12-19 Thread Kenneth Graunke
On Thursday, December 15, 2016 8:10:20 PM PST Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Cc: mesa-sta...@lists.freedesktop.org > --- > src/compiler/glsl/ir_array_refcount.cpp | 73 +++- >

Re: [Mesa-dev] [PATCH 1/3] gallium: add renderonly library

2016-12-19 Thread Christian Gmeiner
Hi Thierry, 2016-12-19 14:08 GMT+01:00 Thierry Reding : > On Wed, Nov 30, 2016 at 02:44:34PM +0100, Christian Gmeiner wrote: >> This a very lightweight library to add basic support for >> renderonly GPUs. It does all the magic regarding in/exporting >> buffers etc. This

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add Polaris12 support

2016-12-19 Thread Tom Stellard
On Mon, Dec 19, 2016 at 02:04:05PM -0500, Alex Deucher wrote: > From: Junwei Zhang > > Signed-off-by: Junwei Zhang > Reviewed-by: Nicolai Hähnle > Acked-by: Christian König > --- >

[Mesa-dev] [PATCH] i965: Don't bail on vertex element processing if we need draw params.

2016-12-19 Thread Kenneth Graunke
BaseVertex, BaseInstance, DrawID, and some edge flag conditions need vertex buffer and elements structs. We can't bail early in this case. Gen4-7 already do this properly. Gen8+ did not. Thanks to Ilia Mirkin for helping track this down. Cc: mesa-sta...@lists.freedesktop.org Bugzilla:

[Mesa-dev] [PATCH 2/2] gallium-docs: Add documentation for when using several contexts

2016-12-19 Thread Axel Davy
Add documentation to explicit what can be expected and what is allowed when using several contexts. Signed-off-by: Axel Davy --- src/gallium/docs/source/context.rst | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/gallium/docs/source/context.rst

[Mesa-dev] [RFCv2] New gallium documentation to explicit threading requirements

2016-12-19 Thread Axel Davy
This is a new RFC to replace "New gallium flags for using different contexts in several threads". Please comment. Yours, Axel Davy Axel Davy (2): gallium-docs: Add documentation for threading requirements gallium-docs: Add documentation for when using several contexts

[Mesa-dev] [PATCH 1/2] gallium-docs: Add documentation for threading requirements

2016-12-19 Thread Axel Davy
Add documentation for the requirements related to threading for screens and contexts. Signed-off-by: Axel Davy --- src/gallium/docs/source/screen.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/docs/source/screen.rst

[Mesa-dev] [PATCH 2/2] radeonsi: add Polaris12 PCI ID

2016-12-19 Thread Alex Deucher
From: Junwei Zhang Signed-off-by: Junwei Zhang Reviewed-by: Nicolai Hähnle --- include/pci_ids/radeonsi_pci_ids.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h

[Mesa-dev] [PATCH 1/2] radeonsi: add Polaris12 support

2016-12-19 Thread Alex Deucher
From: Junwei Zhang Signed-off-by: Junwei Zhang Reviewed-by: Nicolai Hähnle Acked-by: Christian König --- src/amd/addrlib/r800/ciaddrlib.cpp| 3 ++- src/amd/addrlib/r800/ciaddrlib.h

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

2016-12-19 Thread Matt Turner
On Mon, Dec 19, 2016 at 2:00 AM, Samuel Iglesias Gonsálvez wrote: > Hello Matt, > > We have done most of the suggestions you made to our patches. However, > we have replied to some of your questions/suggestions and we are > waiting for a reply before marking them as R-b or

Re: [Mesa-dev] [PATCH 3/3] imx: gallium driver for imx-drm scanout driver

2016-12-19 Thread Emil Velikov
On Monday, 19 December 2016, Thierry Reding wrote: > On Wed, Nov 30, 2016 at 02:44:36PM +0100, Christian Gmeiner wrote: > [...] > > +static struct pipe_screen *imx_open_render_node(struct renderonly *ro) > > +{ > > + return etna_drm_screen_create_rendernode(ro); > >

Re: [Mesa-dev] [PATCH 3/3] imx: gallium driver for imx-drm scanout driver

2016-12-19 Thread Thierry Reding
On Wed, Nov 30, 2016 at 02:44:36PM +0100, Christian Gmeiner wrote: [...] > +static struct pipe_screen *imx_open_render_node(struct renderonly *ro) > +{ > + return etna_drm_screen_create_rendernode(ro); > +} Patch 2/3 never made it into my inbox for some reason, and had to find it in some

Re: [Mesa-dev] [PATCH] configure.ac: Respect LLVM_CFLAGS in LLVM version detection

2016-12-19 Thread Tomasz Figa
On Mon, Dec 19, 2016 at 8:06 PM, Emil Velikov wrote: > On 19 December 2016 at 08:52, Tomasz Figa wrote: >> Hi Tobias, >> >> On Sat, Dec 17, 2016 at 2:15 AM, Tobias Droste wrote: >>> Hi Tomasz, >>> >>> does this actually fix anything?

Re: [Mesa-dev] [PATCH 1/3] gallium: add renderonly library

2016-12-19 Thread Thierry Reding
On Wed, Nov 30, 2016 at 02:44:34PM +0100, Christian Gmeiner wrote: > This a very lightweight library to add basic support for > renderonly GPUs. It does all the magic regarding in/exporting > buffers etc. This library will likely break android support and > hopefully will get replaced with a

Re: [Mesa-dev] [PATCH 3/3] imx: gallium driver for imx-drm scanout driver

2016-12-19 Thread Thierry Reding
On Thu, Dec 01, 2016 at 03:00:20PM +, Emil Velikov wrote: > On 30 November 2016 at 13:44, Christian Gmeiner > wrote: > > The imx (stub) driver is needed to get hardware acceleration from > > etnaviv on a platform using imx-drm kms driver. This adds support > > for

[Mesa-dev] [PATCH] egl: syncronize surface information with driver RFC

2016-12-19 Thread Tapani Pälli
This makes sure that the values we return are in sync what the driver currently has. Together with dEQP change bug #98327 this fixes following test: dEQP-EGL.functional.resize.surface_size.grow v2: implement callback also for dri3 v3: make optional for dri2 drivers, only x11 dri2 seems

[Mesa-dev] [PATCH] new EGL internal SyncSurface hook

2016-12-19 Thread Tapani Pälli
Hi; I've been investigating dEQP EGL bugs. Following test seems to fail now and then and only on X11 when using DRI2: dEQP-EGL.functional.resize.surface_size.grow This patch is RFC for a 'SyncSurface' API that will query surface geometry (xcb_get_geometry) before returning current stored

Re: [Mesa-dev] [PATCH] glsl: Drop bogus is_vertex_input from add_shader_variable().

2016-12-19 Thread Alejandro Piñeiro
lgtm Reviewed-by: Alejandro Piñeiro On 17/12/16 03:46, Kenneth Graunke wrote: > stage_mask is a bitmask of shader stages, so the proper comparison would > be (1 << MESA_SHADER_VERTEX), not MESA_SHADER_VERTEX itself. > > But we only care for structure types, and VS inputs

Re: [Mesa-dev] [PATCH] configure.ac: Respect LLVM_CFLAGS in LLVM version detection

2016-12-19 Thread Emil Velikov
On 19 December 2016 at 08:52, Tomasz Figa wrote: > Hi Tobias, > > On Sat, Dec 17, 2016 at 2:15 AM, Tobias Droste wrote: >> Hi Tomasz, >> >> does this actually fix anything? >> >> Because right now llvm-config.h does not include anything and I doubt it will >>

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Alejandro Piñeiro
On 17/12/16 17:57, Kenneth Graunke wrote: > On Saturday, December 17, 2016 5:41:35 PM PST Alejandro Piñeiro wrote: >> On 17/12/16 03:35, Kenneth Graunke wrote: >>> This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's >>>

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Alejandro Piñeiro
On 17/12/16 17:57, Kenneth Graunke wrote: > On Saturday, December 17, 2016 5:41:35 PM PST Alejandro Piñeiro wrote: >> On 17/12/16 03:35, Kenneth Graunke wrote: >>> This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's >>>

Re: [Mesa-dev] V7 Loop unrolling in NIR

2016-12-19 Thread Timothy Arceri
On Mon, 2016-12-19 at 17:38 +1100, Timothy Arceri wrote: > On Sun, 2016-12-18 at 21:58 -0800, Jason Ekstrand wrote: > > On Dec 18, 2016 9:48 PM, "Timothy Arceri" > .c > > om> wrote: > > V7: > >  - paritally out of ssa in unrolling pass to avoid phis > >  - lots of

Re: [Mesa-dev] [PATCH] configure.ac: Respect LLVM_CFLAGS in LLVM version detection

2016-12-19 Thread Tomasz Figa
Hi Tobias, On Sat, Dec 17, 2016 at 2:15 AM, Tobias Droste wrote: > Hi Tomasz, > > does this actually fix anything? > > Because right now llvm-config.h does not include anything and I doubt it will > in the future, as it's just a collection of defines. > The path to the header

Re: [Mesa-dev] [PATCH 3/6] cso: Optimize cso_save/restore_fragment_samplers

2016-12-19 Thread Nicolai Hähnle
On 19.12.2016 09:11, Michel Dänzer wrote: On 16/12/16 08:22 PM, Nicolai Hähnle wrote: On 16.12.2016 10:52, Michel Dänzer wrote: From: Michel Dänzer Only copy/memset the pointers that actually need to be. Signed-off-by: Michel Dänzer ---

Re: [Mesa-dev] [PATCH 3/6] cso: Optimize cso_save/restore_fragment_samplers

2016-12-19 Thread Michel Dänzer
On 16/12/16 08:22 PM, Nicolai Hähnle wrote: > On 16.12.2016 10:52, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Only copy/memset the pointers that actually need to be. >> >> Signed-off-by: Michel Dänzer >> --- >>

Re: [Mesa-dev] [PATCH v2 000/103] i965 Haswell ARB_gpu_shader_fp64 / OpenGL 4.0

2016-12-19 Thread Samuel Iglesias Gonsálvez
Hello Matt, We have done most of the suggestions you made to our patches. However, we have replied to some of your questions/suggestions and we are waiting for a reply before marking them as R-b or not. You can clone the new version of the patch series by running this command: $ git clone -b