Reviewed-by: Iago Toral Quiroga
On Mon, 2016-12-19 at 15:29 -0800, Kenneth Graunke wrote:
> We were using ir_var_auto for the inlined function parameter
> variables,
> which is wrong, as it suggests that those are real variables declared
> by the program.
>
> Normally this
2016-12-19 22:50 GMT+01:00 Thierry Reding :
> On Mon, Dec 19, 2016 at 08:54:04PM +0100, Christian Gmeiner wrote:
>> 2016-12-19 14:08 GMT+01:00 Thierry Reding :
>> > On Wed, Nov 30, 2016 at 02:44:34PM +0100, Christian Gmeiner wrote:
> [...]
>> >>
This makes better guarantee that the values we return are
in sync what the underlying drawable currently has.
Together with dEQP change bug #98327 this fixes following test:
dEQP-EGL.functional.resize.surface_size.grow
Signed-off-by: Tapani Pälli
Bugzilla:
On Mon, 2016-12-19 at 11:31 -0600, Matt Turner wrote:
> On Mon, Dec 19, 2016 at 2:00 AM, Samuel Iglesias Gonsálvez
> wrote:
> > Hello Matt,
> >
> > We have done most of the suggestions you made to our patches.
> > However,
> > we have replied to some of your
Forget about this ... with some more coffee I realized I can just go and
implement the geometry fetching in QuerySurface hook for dri2 x11, will
send a patch for that!
Sorry about the noise!
On 12/19/2016 02:36 PM, Tapani Pälli wrote:
Hi;
I've been investigating dEQP EGL bugs. Following
Acked-by: Edward O'Callaghan
On 12/20/2016 02:59 PM, Arda Coskunses wrote:
> Without this check driver crash when application window
> closed unexpectedly.
> ---
> src/vulkan/wsi/wsi_common_x11.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git
This sequence shows up The Talos Principal, at least under Vulkan,
and prevents loop analysis from properly computing trip counts in a
few loops.
---
src/compiler/nir/nir_opt_algebraic.py | 8
1 file changed, 8 insertions(+)
diff --git a/src/compiler/nir/nir_opt_algebraic.py
https://bugs.freedesktop.org/show_bug.cgi?id=99076
Gary Wang changed:
What|Removed |Added
CC||gary.c.w...@intel.com
Fixes two new piglit tests:
spec/glsl-1.10/execution/vs-nested-return-sibling-loop.shader_test
spec/glsl-1.10/execution/vs-nested-return-sibling-loop2.shader_test
shader-db results for BDW:
total instructions in shared programs: 12903158 -> 12903134 (-0.00%)
instructions in affected programs:
Unless an if statement contains nested returns we can simply add
any following instructions to the branch without the return.
V2: fix handling if_nested_return value when there is a sibling if/loop
that doesn't contain a return. (Spotted by Ken)
---
src/compiler/nir/nir_lower_returns.c | 37
While working with Tim on loop unrolling, I realized that the new NIR loop
unrolling pass couldn't actually unroll any loops coming out of SPIR-V
thanks to the way we handle continues. This little series adds two
relatively small optimization passes that deal with this by peeling apart
ifs at the
---
src/compiler/nir/nir.h| 2 ++
src/compiler/nir/nir_opt_copy_propagate.c | 2 +-
src/compiler/nir/nir_opt_dce.c| 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
index 0fd6a77..89b0c70 100644
When shaders come in from SPIR-V, we handle continue blocks by placing
the contents of the continue inside of a "if (!first_iteration)". We do
this so that we can properly handle the fact that continues in SPIR-V
jump to the continue block at the end of the loop rather than jumping
directly to
---
src/compiler/nir/nir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c
index e522a67..b8d1abd 100644
--- a/src/compiler/nir/nir.c
+++ b/src/compiler/nir/nir.c
@@ -1754,7 +1754,7 @@ nir_block
---
src/mesa/drivers/dri/i965/brw_nir.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_nir.c
b/src/mesa/drivers/dri/i965/brw_nir.c
index 0c1fb44..a091861 100644
--- a/src/mesa/drivers/dri/i965/brw_nir.c
+++ b/src/mesa/drivers/dri/i965/brw_nir.c
@@ -429,6
---
src/compiler/Makefile.sources| 1 +
src/compiler/nir/nir.h | 2 +
src/compiler/nir/nir_opt_trivial_continues.c | 141 +++
3 files changed, 144 insertions(+)
create mode 100644 src/compiler/nir/nir_opt_trivial_continues.c
diff
These are designed for use within an optimization pass when SSA becomes
more pain than it's worth. They're very naive and don't generate
anything close to optimal register-based NIR. Also, they may result in
shaders which do not validate because of, for instance, registers in phi
sources.
On Monday, December 19, 2016 8:41:17 PM PST Matt Turner wrote:
> On Mon, Dec 19, 2016 at 4:13 PM, Kenneth Graunke
> wrote:
> > For what it's worth, the OpenGL wiki's Program Introspection page(*),
> > under "Interface block member naming" gives an example matching my above
Without this check driver crash when application window
closed unexpectedly.
---
src/vulkan/wsi/wsi_common_x11.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c
index 25ba0c1..afb7809 100644
---
Am 20.12.2016 um 00:12 schrieb Giuseppe Bilotta:
> Hello,
>
> I realize that I'm a little late to comment about this, but I think
> the formula used for
> tanh should be changed again. Specifically, as suggested by Roland
>
> On Fri, Dec 9, 2016 at 5:41 AM, Roland Scheidegger
Reviewed-by: Timothy Arceri
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, Dec 19, 2016 at 4:13 PM, Kenneth Graunke wrote:
> For what it's worth, the OpenGL wiki's Program Introspection page(*),
> under "Interface block member naming" gives an example matching my above
> reply. It says:
>
> uniform BlockName3
> {
> int mem;
Hashcat needs MAX_GLOBAL_BUFFERS to be 21 or even 22 for some modes. It'll
crash otherwise.
I'm adding an assert to see if programs need it to be even higher.
Signed-off-by: Christian Inci
---
src/gallium/drivers/radeonsi/si_compute.c | 3 ++-
1 file changed,
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/compiler/glsl/link_uniform_blocks.cpp | 40 +++
1 file changed, 9 insertions(+), 31 deletions(-)
diff --git a/src/compiler/glsl/link_uniform_blocks.cpp
On Mon, Dec 19, 2016 at 8:17 PM, Matt Turner wrote:
> On Mon, Dec 19, 2016 at 5:12 PM, Giuseppe Bilotta
> wrote:
>> Just one question though —not knowing much of the shader language, can
>> I expect expm1 to be available?
>
> No, expm1 doesn't
On Mon, Dec 19, 2016 at 5:12 PM, Giuseppe Bilotta
wrote:
> Just one question though —not knowing much of the shader language, can
> I expect expm1 to be available?
No, expm1 doesn't exist in GLSL.
___
mesa-dev mailing list
Can someone push this to master?
On Sun, Dec 11, 2016 at 07:21:36PM +0100, Eduardo Lima Mitev wrote:
> Looks good.
>
> Reviewed-by: Eduardo Lima Mitev
>
> On 12/11/2016 04:42 PM, Jonathan Gray wrote:
> > Commit 929fcee47e46781c57f2a354ce0a013915c033d1 introduced code that
> >
Makes sense.
Reviewed-by: Ilia Mirkin
On Mon, Dec 19, 2016 at 6:33 PM, Kenneth Graunke wrote:
> On Monday, December 19, 2016 3:29:13 PM PST Kenneth Graunke wrote:
>> We were using ir_var_auto for the inlined function parameter variables,
>> which is
On Monday, December 19, 2016 3:29:13 PM PST Kenneth Graunke wrote:
> We were using ir_var_auto for the inlined function parameter variables,
> which is wrong, as it suggests that those are real variables declared
> by the program.
>
> Normally this doesn't matter. However, if you called
https://bugs.freedesktop.org/show_bug.cgi?id=99154
Kenneth Graunke changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop.
We were using ir_var_auto for the inlined function parameter variables,
which is wrong, as it suggests that those are real variables declared
by the program.
Normally this doesn't matter. However, if you called built-ins at
global scope, it would pollute the global variable namespace with
these
Hello,
I realize that I'm a little late to comment about this, but I think
the formula used for
tanh should be changed again. Specifically, as suggested by Roland
On Fri, Dec 9, 2016 at 5:41 AM, Roland Scheidegger wrote:
> btw I'm wondering if some vendors wouldn't implement
Avoid synchronization by using the secondary context
for uploading the vertex data for Draw*Up.
v2: Rely on u_upload_mgr to use persistent coherent
buffers. Do not flush.
Signed-off-by: Axel Davy
---
src/gallium/state_trackers/nine/device9.c | 23 +++
1
This new buffer upload path enables to lock
faster than the normal path when using
DISCARD/NOOVERWRITE.
v2: Diverse cleanups and fixes.
v3: Fix allocation size for 'lone' buffers and
add more debug info.
v4: Rewrite of the path to handle when DISCARD/NOOVERWRITE
is not used anymore. The resource
From: Junwei Zhang
v2: use gfxip names for llvm 4.0+
v3: use tonga for llvm <= 3.8
Signed-off-by: Junwei Zhang
Reviewed-by: Nicolai Hähnle
Acked-by: Christian König
---
On Fri, Dec 16, 2016 at 9:46 PM, Kenneth Graunke wrote:
>
> stage_mask is a bitmask of shader stages, so the proper comparison would
> be (1 << MESA_SHADER_VERTEX), not MESA_SHADER_VERTEX itself.
>
> But we only care for structure types, and VS inputs cannot be structs.
>
On 12/18/2016 10:09 PM, Timothy Arceri wrote:
> On Thu, 2016-12-15 at 20:10 -0800, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> Very soon this visitor will get more complicated. The users of the
>> existing ir_variable_refcount visitor won't need the coming
>>
On 12/18/2016 09:54 PM, Timothy Arceri wrote:
> On Thu, 2016-12-15 at 20:10 -0800, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> Signed-off-by: Ian Romanick
>> Cc: mesa-sta...@lists.freedesktop.org
>> ---
>>
On Monday, December 19, 2016 1:36:00 PM PST Ian Romanick wrote:
> On 12/16/2016 09:35 PM, Kenneth Graunke wrote:
> > This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's
> > arb_program_interface_query/arb_program_interface_query-resource-query,
> > and
Iago Toral Quiroga writes:
> From: "Juan A. Suarez Romero"
>
> Our current data flow analysis does not take into account that channels
> on 64-bit operands are 64-bit. This is a problem when the same register
> is accessed using both 64-bit and 32-bit
On Mon, Dec 19, 2016 at 08:54:04PM +0100, Christian Gmeiner wrote:
> 2016-12-19 14:08 GMT+01:00 Thierry Reding :
> > On Wed, Nov 30, 2016 at 02:44:34PM +0100, Christian Gmeiner wrote:
[...]
> >> GALLIUM_WINSYS_CFLAGS = \
> >> -I$(top_srcdir)/src \
> >>
On 12/16/2016 09:35 PM, Kenneth Graunke wrote:
> This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's
> arb_program_interface_query/arb_program_interface_query-resource-query,
> and GL45-CTS.program_interface_query.separate-programs-{tess-control,
> tess-eval,geometry}. Only one
https://bugs.freedesktop.org/show_bug.cgi?id=99154
Bug ID: 99154
Summary: Link time error when using multiple builtin functions
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity:
https://bugs.freedesktop.org/show_bug.cgi?id=99154
Niels Ole Salscheider changed:
What|Removed |Added
CC|
On Mon, Dec 19, 2016 at 04:04:34PM +, Emil Velikov wrote:
> On Monday, 19 December 2016, Thierry Reding
> wrote:
>
> > On Wed, Nov 30, 2016 at 02:44:36PM +0100, Christian Gmeiner wrote:
> > [...]
> > > +static struct pipe_screen *imx_open_render_node(struct
2016-12-19 21:41 GMT+01:00 Alex Deucher :
> diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c
> b/src/gallium/drivers/radeon/r600_pipe_common.c
> index 0b5c6dc..76a34fe 100644
> --- a/src/gallium/drivers/radeon/r600_pipe_common.c
> +++
From: Junwei Zhang
v2: use gfxip names for llvm 4.0+
Signed-off-by: Junwei Zhang
Reviewed-by: Nicolai Hähnle
Acked-by: Christian König
---
src/amd/addrlib/r800/ciaddrlib.cpp| 3 ++-
On Thursday, December 15, 2016 8:10:20 PM PST Ian Romanick wrote:
> From: Ian Romanick
>
> Signed-off-by: Ian Romanick
> Cc: mesa-sta...@lists.freedesktop.org
> ---
> src/compiler/glsl/ir_array_refcount.cpp | 73 +++-
>
Hi Thierry,
2016-12-19 14:08 GMT+01:00 Thierry Reding :
> On Wed, Nov 30, 2016 at 02:44:34PM +0100, Christian Gmeiner wrote:
>> This a very lightweight library to add basic support for
>> renderonly GPUs. It does all the magic regarding in/exporting
>> buffers etc. This
On Mon, Dec 19, 2016 at 02:04:05PM -0500, Alex Deucher wrote:
> From: Junwei Zhang
>
> Signed-off-by: Junwei Zhang
> Reviewed-by: Nicolai Hähnle
> Acked-by: Christian König
> ---
>
BaseVertex, BaseInstance, DrawID, and some edge flag conditions need
vertex buffer and elements structs. We can't bail early in this case.
Gen4-7 already do this properly. Gen8+ did not.
Thanks to Ilia Mirkin for helping track this down.
Cc: mesa-sta...@lists.freedesktop.org
Bugzilla:
Add documentation to explicit what can be expected and what is allowed
when using several contexts.
Signed-off-by: Axel Davy
---
src/gallium/docs/source/context.rst | 23 +++
1 file changed, 23 insertions(+)
diff --git a/src/gallium/docs/source/context.rst
This is a new RFC to replace "New gallium flags for using different
contexts in several threads".
Please comment.
Yours,
Axel Davy
Axel Davy (2):
gallium-docs: Add documentation for threading requirements
gallium-docs: Add documentation for when using several contexts
Add documentation for the requirements related to threading
for screens and contexts.
Signed-off-by: Axel Davy
---
src/gallium/docs/source/screen.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/gallium/docs/source/screen.rst
From: Junwei Zhang
Signed-off-by: Junwei Zhang
Reviewed-by: Nicolai Hähnle
---
include/pci_ids/radeonsi_pci_ids.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/pci_ids/radeonsi_pci_ids.h
From: Junwei Zhang
Signed-off-by: Junwei Zhang
Reviewed-by: Nicolai Hähnle
Acked-by: Christian König
---
src/amd/addrlib/r800/ciaddrlib.cpp| 3 ++-
src/amd/addrlib/r800/ciaddrlib.h
On Mon, Dec 19, 2016 at 2:00 AM, Samuel Iglesias Gonsálvez
wrote:
> Hello Matt,
>
> We have done most of the suggestions you made to our patches. However,
> we have replied to some of your questions/suggestions and we are
> waiting for a reply before marking them as R-b or
On Monday, 19 December 2016, Thierry Reding
wrote:
> On Wed, Nov 30, 2016 at 02:44:36PM +0100, Christian Gmeiner wrote:
> [...]
> > +static struct pipe_screen *imx_open_render_node(struct renderonly *ro)
> > +{
> > + return etna_drm_screen_create_rendernode(ro);
> >
On Wed, Nov 30, 2016 at 02:44:36PM +0100, Christian Gmeiner wrote:
[...]
> +static struct pipe_screen *imx_open_render_node(struct renderonly *ro)
> +{
> + return etna_drm_screen_create_rendernode(ro);
> +}
Patch 2/3 never made it into my inbox for some reason, and had to find
it in some
On Mon, Dec 19, 2016 at 8:06 PM, Emil Velikov wrote:
> On 19 December 2016 at 08:52, Tomasz Figa wrote:
>> Hi Tobias,
>>
>> On Sat, Dec 17, 2016 at 2:15 AM, Tobias Droste wrote:
>>> Hi Tomasz,
>>>
>>> does this actually fix anything?
On Wed, Nov 30, 2016 at 02:44:34PM +0100, Christian Gmeiner wrote:
> This a very lightweight library to add basic support for
> renderonly GPUs. It does all the magic regarding in/exporting
> buffers etc. This library will likely break android support and
> hopefully will get replaced with a
On Thu, Dec 01, 2016 at 03:00:20PM +, Emil Velikov wrote:
> On 30 November 2016 at 13:44, Christian Gmeiner
> wrote:
> > The imx (stub) driver is needed to get hardware acceleration from
> > etnaviv on a platform using imx-drm kms driver. This adds support
> > for
This makes sure that the values we return are in sync what the
driver currently has.
Together with dEQP change bug #98327 this fixes following test:
dEQP-EGL.functional.resize.surface_size.grow
v2: implement callback also for dri3
v3: make optional for dri2 drivers, only x11 dri2 seems
Hi;
I've been investigating dEQP EGL bugs. Following test seems to fail now
and then and only on X11 when using DRI2:
dEQP-EGL.functional.resize.surface_size.grow
This patch is RFC for a 'SyncSurface' API that will query surface
geometry (xcb_get_geometry) before returning current stored
lgtm
Reviewed-by: Alejandro Piñeiro
On 17/12/16 03:46, Kenneth Graunke wrote:
> stage_mask is a bitmask of shader stages, so the proper comparison would
> be (1 << MESA_SHADER_VERTEX), not MESA_SHADER_VERTEX itself.
>
> But we only care for structure types, and VS inputs
On 19 December 2016 at 08:52, Tomasz Figa wrote:
> Hi Tobias,
>
> On Sat, Dec 17, 2016 at 2:15 AM, Tobias Droste wrote:
>> Hi Tomasz,
>>
>> does this actually fix anything?
>>
>> Because right now llvm-config.h does not include anything and I doubt it will
>>
On 17/12/16 17:57, Kenneth Graunke wrote:
> On Saturday, December 17, 2016 5:41:35 PM PST Alejandro Piñeiro wrote:
>> On 17/12/16 03:35, Kenneth Graunke wrote:
>>> This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's
>>>
On 17/12/16 17:57, Kenneth Graunke wrote:
> On Saturday, December 17, 2016 5:41:35 PM PST Alejandro Piñeiro wrote:
>> On 17/12/16 03:35, Kenneth Graunke wrote:
>>> This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's
>>>
On Mon, 2016-12-19 at 17:38 +1100, Timothy Arceri wrote:
> On Sun, 2016-12-18 at 21:58 -0800, Jason Ekstrand wrote:
> > On Dec 18, 2016 9:48 PM, "Timothy Arceri" > .c
> > om> wrote:
> > V7:
> > - paritally out of ssa in unrolling pass to avoid phis
> > - lots of
Hi Tobias,
On Sat, Dec 17, 2016 at 2:15 AM, Tobias Droste wrote:
> Hi Tomasz,
>
> does this actually fix anything?
>
> Because right now llvm-config.h does not include anything and I doubt it will
> in the future, as it's just a collection of defines.
> The path to the header
On 19.12.2016 09:11, Michel Dänzer wrote:
On 16/12/16 08:22 PM, Nicolai Hähnle wrote:
On 16.12.2016 10:52, Michel Dänzer wrote:
From: Michel Dänzer
Only copy/memset the pointers that actually need to be.
Signed-off-by: Michel Dänzer
---
On 16/12/16 08:22 PM, Nicolai Hähnle wrote:
> On 16.12.2016 10:52, Michel Dänzer wrote:
>> From: Michel Dänzer
>>
>> Only copy/memset the pointers that actually need to be.
>>
>> Signed-off-by: Michel Dänzer
>> ---
>>
Hello Matt,
We have done most of the suggestions you made to our patches. However,
we have replied to some of your questions/suggestions and we are
waiting for a reply before marking them as R-b or not.
You can clone the new version of the patch series by running this
command:
$ git clone -b
73 matches
Mail list logo