Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-06 Thread Michel Dänzer
On 06/01/17 05:50 AM, Andy Furniss wrote: > Christian König wrote: >> Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: >>> dri3 allows us to send handle of a texture directly to X >>> so this patch allows a state tracker to directly send its >>> texture to X to be used as back buffer and avoids

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97542 Michel Dänzer changed: What|Removed |Added Version|13.0|12.0 --- Comment

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94512 --- Comment #9 from EoD --- (In reply to Emil Velikov from comment #8) > Double-checking the logs - seems like TLS is built/used throughout the board. > One thing which comes to mind - can you try with --disable-asm. I'm fairly >

[Mesa-dev] [PATCH 1/2] anv/pipeline: Only call remove_dead_variables once

2017-01-06 Thread Jason Ekstrand
It can handle multiple modes at a time now so there's no reason to call it repeatedly. --- src/intel/vulkan/anv_pipeline.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index db35d70..fadc76a 100644 ---

[Mesa-dev] [PATCH 2/2] anv/pipeline: Call NIR passes using NIR_PASS_V

2017-01-06 Thread Jason Ekstrand
This lets us get validation without having to do it manually. --- src/intel/vulkan/anv_pipeline.c | 46 ++--- 1 file changed, 15 insertions(+), 31 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index

Re: [Mesa-dev] [PATCH] radv: fix depth transitions with layerCount = VK_REMAINING_ARRAY_LAYERS

2017-01-06 Thread Bas Nieuwenhuizen
Thanks, pushed. - Bas On Sat, Jan 7, 2017 at 12:08 AM, Pierre-Loup A. Griffais wrote: > Yep, sorry about that and thanks for the review... Please ignore the other > thread on mesa-dev now that this one is in the right place :( > > On 01/06/2017 02:05 PM, Jason

Re: [Mesa-dev] [PATCH 1/2] isl: Mark A4B4G4R4_UNORM as supported on gen8

2017-01-06 Thread Kenneth Graunke
On Friday, January 6, 2017 2:22:42 PM PST Jason Ekstrand wrote: > Cc: "13.1" > --- > src/intel/isl/isl_format.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c > index

Re: [Mesa-dev] [PATCH 3/3] anv/image: Disable HiZ for depth buffer arrays

2017-01-06 Thread Nanley Chery
On Fri, Jan 06, 2017 at 03:08:12PM -0800, Jason Ekstrand wrote: > 2017-01-06 14:46 GMT-08:00 Nanley Chery : > > > We currently don't perform clears or resolves on multiple array layers > > with HiZ. > > > > Glancing through the code, it looks like you're right. I'm not

Re: [Mesa-dev] [PATCH] i965: Allow a per gen timebase scale factor

2017-01-06 Thread Jason Ekstrand
While you're at it, would you mind making Vulkan use this as well? It should be a 2-line change to GetPhysicalDeviceProperties. On Fri, Jan 6, 2017 at 1:17 PM, Kenneth Graunke wrote: > From: Robert Bragg > > v2: (Ken) Update timebase_scale for

Re: [Mesa-dev] [PATCH 1/6] nir/dead_variables: Remove shader-local variables that are only written

2017-01-06 Thread Jason Ekstrand
On Wed, Jan 4, 2017 at 3:20 PM, Timothy Arceri wrote: > On Mon, 2016-12-12 at 19:39 -0800, Jason Ekstrand wrote: > > --- > > src/compiler/nir/nir_remove_dead_variables.c | 66 > > > > 1 file changed, 58 insertions(+), 8 deletions(-) >

Re: [Mesa-dev] [PATCH] radv: fix depth transitions with layerCount = VK_REMAINING_ARRAY_LAYERS

2017-01-06 Thread Pierre-Loup A. Griffais
Yep, sorry about that and thanks for the review... Please ignore the other thread on mesa-dev now that this one is in the right place :( On 01/06/2017 02:05 PM, Jason Ekstrand wrote: Bah... cc mesa-dev On Fri, Jan 6, 2017 at 2:04 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH 3/3] anv/image: Disable HiZ for depth buffer arrays

2017-01-06 Thread Jason Ekstrand
2017-01-06 14:46 GMT-08:00 Nanley Chery : > We currently don't perform clears or resolves on multiple array layers > with HiZ. > Glancing through the code, it looks like you're right. I'm not even sure that you can do layered HiZ clears and/or resolves with the HZ op;

Re: [Mesa-dev] [PATCH 2/3] anv/cmd_buffer: Fix programmed HiZ qpitch

2017-01-06 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Jan 6, 2017 at 2:46 PM, Nanley Chery wrote: > Match the comment above the field by using units of pixels and not HiZ > blocks. > > Cc: mesa-sta...@lists.freedesktop.org > Suggested-by: Jason Ekstrand

Re: [Mesa-dev] [PATCH 1/3] anv/cmd_buffer: Fix arrayed depth/stencil attachments

2017-01-06 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Jan 6, 2017 at 2:46 PM, Nanley Chery wrote: > Enable multiple layers of the depth/stencil buffers to be accessible. > > Fixes the crucible test, func.depthstencil.arrayed_clear. > > Cc:

Re: [Mesa-dev] [PATCH 1/3] radeonsi: cleanly communicate whether si_shader_dump should check R600_DEBUG

2017-01-06 Thread Marek Olšák
Ping for Rb for the first 2 patches. Marek On Tue, Jan 3, 2017 at 8:17 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_compute.c | 2 +- > src/gallium/drivers/radeonsi/si_debug.c | 2 +- >

[Mesa-dev] [PATCH 2/3] anv/cmd_buffer: Fix programmed HiZ qpitch

2017-01-06 Thread Nanley Chery
Match the comment above the field by using units of pixels and not HiZ blocks. Cc: mesa-sta...@lists.freedesktop.org Suggested-by: Jason Ekstrand Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 3/3] anv/image: Disable HiZ for depth buffer arrays

2017-01-06 Thread Nanley Chery
We currently don't perform clears or resolves on multiple array layers with HiZ. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 1/3] anv/cmd_buffer: Fix arrayed depth/stencil attachments

2017-01-06 Thread Nanley Chery
Enable multiple layers of the depth/stencil buffers to be accessible. Fixes the crucible test, func.depthstencil.arrayed_clear. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 7 +-- 1 file changed, 5

[Mesa-dev] [PATCH 1/2] isl: Mark A4B4G4R4_UNORM as supported on gen8

2017-01-06 Thread Jason Ekstrand
Cc: "13.1" --- src/intel/isl/isl_format.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c index 98806f4..43c2f4f 100644 --- a/src/intel/isl/isl_format.c +++

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #47 from Marek Olšák --- The freezes are not caused by shader compilation. I don't know what's causing them. They are too long (even 10 seconds). A CPU profiler shows the time is not spent in the driver. It's spent

[Mesa-dev] [PATCH 2/2] anv/formats: Use the real format for B4G4R4A4_UNORM_PACK16 on gen8

2017-01-06 Thread Jason Ekstrand
Because border color is handled pre-swizzle, when we move the alpha channel around in the format, the OPAQUE_BLACK border colors don't work correctly on B4G4R4A4_UNORM_PACK16 with the hack. This fixes the following Vulkan CTS tests on Broadwell:

Re: [Mesa-dev] [PATCH] radv: fix depth transitions with layerCount = VK_REMAINING_ARRAY_LAYERS

2017-01-06 Thread Jason Ekstrand
Bah... cc mesa-dev On Fri, Jan 6, 2017 at 2:04 PM, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > I'll let Dave or Bas push though. :-) > > On Fri, Jan 6, 2017 at 12:57 PM, Pierre-Loup A. Griffais < > pgriff...@valvesoftware.com> wrote: > >>

Re: [Mesa-dev] [PATCH] gallium/radeon: use the internal clear_buffer callback to fix r600g

2017-01-06 Thread Alex Deucher
On Fri, Jan 6, 2017 at 4:26 PM, Marek Olšák wrote: > From: Marek Olšák > > r600g doesn't set pipe_context::clear_buffer. Mention the bug report here: https://bugs.freedesktop.org/show_bug.cgi?id=99303 With that: Reviewed-by: Alex Deucher

Re: [Mesa-dev] [PATCH] i965: Allow a per gen timebase scale factor

2017-01-06 Thread Kenneth Graunke
On Friday, January 6, 2017 1:17:39 PM PST Kenneth Graunke wrote: > From: Robert Bragg > > v2: (Ken) Update timebase_scale for platforms past Skylake/Broxton too. Hi Robert! Your patch had merge conflicts in gen_device_info.c at this point, so I fixed those and re-sent it.

Re: [Mesa-dev] [PATCH] i965: Fix texturing in the vec4 TCS and GS backends.

2017-01-06 Thread Matt Turner
On Fri, Jan 6, 2017 at 10:27 AM, Jason Ekstrand wrote: > Sorry I didn't fix vec4 when I fixed fs. :-( > > Reciewed-by: Jason Ekstrand Ken, make sure to fix the "Reciewed" typo when applying the patch. ___

[Mesa-dev] [PATCH] gallium/radeon: use the internal clear_buffer callback to fix r600g

2017-01-06 Thread Marek Olšák
From: Marek Olšák r600g doesn't set pipe_context::clear_buffer. --- src/gallium/drivers/radeon/r600_pipe_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c

Re: [Mesa-dev] [PATCH] i965: Allow a per gen timebase scale factor

2017-01-06 Thread Matt Turner
On Fri, Jan 6, 2017 at 1:17 PM, Kenneth Graunke wrote: > From: Robert Bragg > > v2: (Ken) Update timebase_scale for platforms past Skylake/Broxton too. > --- > src/intel/common/gen_device_info.c| 13 ++-- >

[Mesa-dev] [PATCH] i965: Allow a per gen timebase scale factor

2017-01-06 Thread Kenneth Graunke
From: Robert Bragg v2: (Ken) Update timebase_scale for platforms past Skylake/Broxton too. --- src/intel/common/gen_device_info.c| 13 ++-- src/intel/common/gen_device_info.h| 24 ++ src/mesa/drivers/dri/i965/brw_context.c | 15 +

Re: [Mesa-dev] [PATCH] radv: fix depth transitions with layerCount = VK_REMAINING_ARRAY_LAYERS

2017-01-06 Thread Kai Wasserbäch
Hey Pierre, this looks like it went to the wrong list. radv patches should be sent to AFAIK (CCed with this message). Cheers, Kai Pierre-Loup A. Griffais wrote on 06.01.2017 21:57: > Interpreting layerCount literally would try to create billions of image

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97542 Christian changed: What|Removed |Added Version|12.0|13.0 -- You

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #13 from Christian --- Same problem, different version: mesa-13.0.2 llvm: sys-devel/llvm-3.9.1 sys-devel/clang-3.9.1-r100 Error: libtool: compile: x86_64-pc-linux-gnu-g++ -m32 -DPACKAGE_NAME=\"Mesa\"

[Mesa-dev] [Bug 99305] account creation request

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99305 --- Comment #1 from George Kyriazis --- Created attachment 128799 --> https://bugs.freedesktop.org/attachment.cgi?id=128799=edit ssh public key -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 99305] account creation request

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99305 Bug ID: 99305 Summary: account creation request Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH 5/7] st/nine: Process pending commands on Reset

2017-01-06 Thread Axel Davy
Some nine_state_* and nine_context_* functions used for Reset() require all pending commands are flushed. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 1 + src/gallium/state_trackers/nine/device9ex.c | 1 +

[Mesa-dev] [PATCH 3/7] st/nine: Rework CreatePipeSurface

2017-01-06 Thread Axel Davy
Create both surfaces in one call. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/surface9.c | 49 ++ src/gallium/state_trackers/nine/surface9.h | 3 -- 2 files changed, 30 insertions(+), 22 deletions(-) diff --git

[Mesa-dev] [PATCH 4/7] st/nine: Flush pending commands if needed for surface9 changes

2017-01-06 Thread Axel Davy
nine_context uses NineSurface9 fields, thus we need to flush pending commands using the surface before changing the fields. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/surface9.c | 28 src/gallium/state_trackers/nine/surface9.h |

[Mesa-dev] [PATCH 2/7] st/nine: Remove duplicated checks

2017-01-06 Thread Axel Davy
There is no need to check on csmt_active before calling nine_csmt_process, because the function checks already. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 3 +-- src/gallium/state_trackers/nine/nine_state.c | 14 ++ 2 files

[Mesa-dev] [PATCH 7/7] st/nine: Protect dtors with mutex

2017-01-06 Thread Axel Davy
When the flag D3DCREATE_MULTITHREAD is set, a global mutex is used to protect nine calls. However for performance reasons, AddRef and Release didn't hold the mutex, and instead used atomics. Unfortunately at item release, the item can be destroyed, and that destruction path should be protected by

[Mesa-dev] [PATCH 6/7] st/nine: Flush the queue at device dtor

2017-01-06 Thread Axel Davy
Flush the queue to get refcounts right, and properly release the items, instead of throwing away all pending commands. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/7] st/nine: Don't call u_box_union_* when dirty region is empty

2017-01-06 Thread Axel Davy
From: Masanori Kakura When dirty region is empty, u_box_union_* incorrectly expands the new region. This fixes broken font rendering issue in WOLF RPG Editor v2.10 games. Signed-off-by: Masanori Kakura Reviewed-by: Axel Davy ---

Re: [Mesa-dev] [PATCH] i965: Properly flush in hsw_pause_transform_feedback().

2017-01-06 Thread Anuj Phogat
On Fri, Jan 6, 2017 at 12:09 AM, Kenneth Graunke wrote: > Fixes a number of transform feedback tests when run with Linux 4.8, > which allows us to use the MI_LOAD_REGISTER_REG command, at which point > we started using this new broken path. > >

[Mesa-dev] [PATCH] configure: Add a condition for compiling for ARM.

2017-01-06 Thread Eric Anholt
This will let VC4 do some ARM-specific optimizations while still having the simulator build on x86. --- I'm finishing building the series for doing NEON optimizations today, but I wanted to get this out there for review since it touches shared code. I didn't replicate the 'case "$host_os"' for

Re: [Mesa-dev] [PATCH] anv: don't skip the VUE header if we are reading gl_Layer in a fragment shader

2017-01-06 Thread Jason Ekstrand
Thanks! Reviewed-by: Jason Ekstrand On Jan 5, 2017 05:10, "Iago Toral Quiroga" wrote: > This is the same we do in the GL driver: the hardware provides gl_Layer > in the VUE header, so when the fragment shader reads it we can't skip it. > --- > > With

Re: [Mesa-dev] [PATCH] i965: Fix texturing in the vec4 TCS and GS backends.

2017-01-06 Thread Jason Ekstrand
Sorry I didn't fix vec4 when I fixed fs. :-( Reciewed-by: Jason Ekstrand On Jan 6, 2017 02:00, "Kenneth Graunke" wrote: We were failing to zero m0.2 of the sampler message header for TCS and GS messages in the simple case. fs_generator has done

Re: [Mesa-dev] [PATCH] isl: render target cube maps should be handled as 2D images, not cubes

2017-01-06 Thread Jason Ekstrand
On Jan 6, 2017 10:18, "Jason Ekstrand" wrote: Thanks for catching this. I wonder how I managed to switch the GL driver over to using ISL for emitting surface states without regressing anything... Reviewed-by: Jason Ekstrand On Jan 6, 2017 05:42,

Re: [Mesa-dev] [PATCH] isl: render target cube maps should be handled as 2D images, not cubes

2017-01-06 Thread Jason Ekstrand
Thanks for catching this. I wonder how I managed to switch the GL driver over to using ISL for emitting surface states without regressing anything... Reviewed-by: Jason Ekstrand On Jan 6, 2017 05:42, "Iago Toral Quiroga" wrote: > This fixes layered

Re: [Mesa-dev] [PATCH 7/8] android: support creating texture from gralloc buffer

2017-01-06 Thread Rob Herring
On Fri, Jan 6, 2017 at 11:35 AM, Wu Zhen wrote: > From: WuZhen > > Change-Id: Ifabf40fe94007f73171a89b23545002707817053 > Reviewed-by: Mauro Rossi > Reviewed-by: Chih-Wei Huang > --- >

[Mesa-dev] [PATCH 8/8] android: egl: add support for software rasterizer

2017-01-06 Thread Wu Zhen
From: WuZhen this commit enable software rendering on android with llvmpipe. the system boots fine antutu 3D benchmark is passing this commit incorporates some further work done by: Paulo Sergio Travaglia Mauro Rossi Change-Id:

[Mesa-dev] [PATCH 6/8] drisw: support fence externsion and image extension

2017-01-06 Thread Wu Zhen
From: WuZhen adds a new type of winsys handle type that allows passing a pointer sized handle to winsys Change-Id: I3bf1732619206d2bc50f6aca6b27258bb026a212 Reviewed-by: Mauro Rossi Reviewed-by: Chih-Wei Huang ---

[Mesa-dev] [PATCH 7/8] android: support creating texture from gralloc buffer

2017-01-06 Thread Wu Zhen
From: WuZhen Change-Id: Ifabf40fe94007f73171a89b23545002707817053 Reviewed-by: Mauro Rossi Reviewed-by: Chih-Wei Huang --- src/gallium/targets/dri/Android.mk| 1 + src/gallium/winsys/sw/dri/dri_sw_winsys.c | 65

[Mesa-dev] [PATCH 5/8] android: add Android.mk for llvmpipe

2017-01-06 Thread Wu Zhen
From: WuZhen rename old swrast to softpipe, add a new driver llvmpipe Change-Id: Ia8bc1005ad6846df78bc1f6d0a4196310a049aca Reviewed-by: Mauro Rossi Reviewed-by: Chih-Wei Huang --- Android.common.mk|

[Mesa-dev] [PATCH 4/8] android: fix llvmpipe build

2017-01-06 Thread Wu Zhen
From: WuZhen since (cf410574 gallivm: Make MCJIT a runtime optioni.), llvmpipe assume MCJIT is available on x86(_64). this is not the case for android prior to M. Change-Id: I6c82915b043f65e15ffc73aecff6779a1d02f1f1 Reviewed-by: Mauro Rossi

[Mesa-dev] [PATCH 3/8] android: remove static linking LLVM parts.

2017-01-06 Thread Wu Zhen
From: WuZhen linking against llvm with both static and shared lib will cause problems. requires a companion changes in android llvm Change-Id: I1d459135f7e5e242164abe38cd15f0a49448e495 Reviewed-by: Mauro Rossi Reviewed-by: Chih-Wei Huang

[Mesa-dev] [PATCH 2/8] android: fix building on lollipop

2017-01-06 Thread Wu Zhen
From: WuZhen this commit fixes mesa building on lollipop, however, llvm on lollipop is too old to build amdgpu based on initial work by Mauro Rossi Change-Id: I98d646f9e1c61fe2754479382885718386a8bbb7 Reviewed-by: Mauro Rossi

[Mesa-dev] [PATCH 1/8] android: print debug info to logcat

2017-01-06 Thread Wu Zhen
From: WuZhen Redirect logs printed to stderr to logcat. Change-Id: I58e3966a608af361b86c54b4c95a92561b711968 Signed-off-by: Chih-Wei Huang Reviewed-by: Mauro Rossi Reviewed-by: Chih-Wei Huang ---

[Mesa-dev] [PATCH 0/8] enable llvmpipe on android

2017-01-06 Thread Wu Zhen
This series of patches enables llvmpipe on anroid-x86 as a fallback renderer, llvmpipe has been enabled and tested on Remix OS(a variant of Android-x86) for about a year. WuZhen (8): android: print debug info to logcat android: fix building on lollipop android: remove static linking LLVM

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 --- Comment #10 from Tim Rowley --- I think the right fix for CalculateProcessorTopology is to prune empty nodes at the end: for (auto it = out_nodes.begin(); it != out_nodes.end(); ) { if

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 --- Comment #9 from Jan Ziak <0xe2.0x9a.0...@gmail.com> --- Created attachment 128795 --> https://bugs.freedesktop.org/attachment.cgi?id=128795=edit /proc/cpuinfo -- You are receiving this mail because: You are the assignee for the bug. You

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 --- Comment #8 from Jan Ziak <0xe2.0x9a.0...@gmail.com> --- (In reply to Bruce Cherniak from comment #7) > I also see you are on an AVX capable processor. It would be helpful to know > which model. AMD A10-7850K > The segfault you've

Re: [Mesa-dev] [PATCH] winsys/amdgpu: fix a race condition between fence updates and IB submissions

2017-01-06 Thread Marek Olšák
On Fri, Jan 6, 2017 at 1:02 PM, Nicolai Hähnle wrote: > On 02.01.2017 21:20, Marek Olšák wrote: >> >> From: Marek Olšák >> >> The CS thread is needed to ensure proper ordering of operations and can't >> be disabled (without complicating the code). >> >>

Re: [Mesa-dev] [PATCH 2/9] radeonsi: clean up more HAVE_LLVM #ifdefs

2017-01-06 Thread Marek Olšák
On Fri, Jan 6, 2017 at 12:42 PM, Nicolai Hähnle wrote: > On 02.01.2017 21:16, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/r600_pipe_common.c | 14 +- >> src/gallium/drivers/radeonsi/si_shader.c | 19

Re: [Mesa-dev] [PATCH 2/5] st/nine: Remove all usage of ureg_SUB in nine_ff

2017-01-06 Thread Marek Olšák
On Fri, Jan 6, 2017 at 12:43 PM, Jose Fonseca wrote: > I think this is a good idea. > > We still use them but I'm happy to see them go > > It would be much easier for you and for us if you just implemented a > ureg_ABS() / ureg_SUB inline helper that would call

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 --- Comment #7 from Bruce Cherniak --- I also see you are on an AVX capable processor. It would be helpful to know which model. The segfault you've referenced below is in a section of code that figures out processor

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 --- Comment #6 from Bruce Cherniak --- What are your configure and run options? I have not installing these as the default drivers, rather using a test sandbox . I am simply configuring using: --prefix=

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 Bruce Cherniak changed: What|Removed |Added Status|RESOLVED|REOPENED

[Mesa-dev] [PATCH] isl: render target cube maps should be handled as 2D images, not cubes

2017-01-06 Thread Iago Toral Quiroga
This fixes layered rendering Vulkan CTS tests with cube (arrays). We also do this in the GL driver, see this code from gen8_depth_state.c for example: case GL_TEXTURE_CUBE_MAP_ARRAY: case GL_TEXTURE_CUBE_MAP: /* The PRM claims that we should use BRW_SURFACE_CUBE for this * situation, but

[Mesa-dev] [PATCH] glx: Add missing glproto dependency for gallium-xlib glx

2017-01-06 Thread Chuck Atkins
Cc: mesa-sta...@lists.freedesktop.org Cc: Bruce Cherniak Signed-of-by: Chuck Atkins --- configure.ac| 4 +++- src/gallium/state_trackers/glx/xlib/Makefile.am | 1 + 2 files changed, 4 insertions(+), 1

Re: [Mesa-dev] [PATCH] glsl: fix opt_minmax redundancy checks against baserange

2017-01-06 Thread Iago Toral
Hi Tim, it's been a while, so off the top of my head I don't have any particular suggestions or the capacity to tell whether your fix is correct or not :-/. I'll try to spend some time re-acquainting myself with that code on Monday and see if I can see what is going on here. Iago On Fri,

Re: [Mesa-dev] [PATCH] glsl: fix opt_minmax redundancy checks against baserange

2017-01-06 Thread Timothy Arceri
On Fri, 2017-01-06 at 12:36 +0100, Nicolai Hähnle wrote: > On 06.01.2017 00:26, Timothy Arceri wrote: > > Marking operations as redundant if they are equal to the base > > range is fine when the tree structure is something like this: > > > > max > >   / \ > >  max b > >    

Re: [Mesa-dev] [PATCH] winsys/amdgpu: fix a race condition between fence updates and IB submissions

2017-01-06 Thread Nicolai Hähnle
On 02.01.2017 21:20, Marek Olšák wrote: From: Marek Olšák The CS thread is needed to ensure proper ordering of operations and can't be disabled (without complicating the code). Discovered by Nine CSMT, which ended up in a deadlock. I'm curious why the thread makes a

Re: [Mesa-dev] [PATCH 3/3] radeonsi: add TC L2 prefetch for shaders and VBO descriptors

2017-01-06 Thread Nicolai Hähnle
On 02.01.2017 21:18, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_cp_dma.c | 12 + src/gallium/drivers/radeonsi/si_pipe.h | 2 ++ src/gallium/drivers/radeonsi/si_state_draw.c | 37 +++- 3 files

Re: [Mesa-dev] [PATCH 9/9] gallium/radeon: add new HUD query num-SDMA-IBs

2017-01-06 Thread Nicolai Hähnle
Apart from the question on patch #2, this series is Reviewed-by: Nicolai Hähnle On 02.01.2017 21:17, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_query.c | 4 src/gallium/drivers/radeon/r600_query.h

Re: [Mesa-dev] [PATCH 2/5] st/nine: Remove all usage of ureg_SUB in nine_ff

2017-01-06 Thread Jose Fonseca
I think this is a good idea. We still use them but I'm happy to see them go It would be much easier for you and for us if you just implemented a ureg_ABS() / ureg_SUB inline helper that would call ureg_MOV/ureg_ADD internally: fewer chances of a typo somewhere, and less work necessary all

Re: [Mesa-dev] [PATCH 2/9] radeonsi: clean up more HAVE_LLVM #ifdefs

2017-01-06 Thread Nicolai Hähnle
On 02.01.2017 21:16, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 14 +- src/gallium/drivers/radeonsi/si_shader.c | 19 +++ 2 files changed, 20 insertions(+), 13 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] glsl: fix opt_minmax redundancy checks against baserange

2017-01-06 Thread Nicolai Hähnle
On 06.01.2017 00:26, Timothy Arceri wrote: Marking operations as redundant if they are equal to the base range is fine when the tree structure is something like this: max / \ max b / \ 3max / \ 3 a But the opt falls apart with a tree

Re: [Mesa-dev] [PATCH] glsl: fix opt_minmax redundancy checks against baserange

2017-01-06 Thread Timothy Arceri
Hi Iago/Petri, Just Ccing you guys in case you have a better solution (I know its been a while since this was written). This is causing incorrect shaders in at least Serious Sam 3 possibly others. I've sent some piglit tests to reproduce it to the piglit list. Thanks, Tim On Fri, 2017-01-06 at

Re: [Mesa-dev] [PATCH 3/7] gallium: add FBFETCH opcode to retrieve the current sample value

2017-01-06 Thread Nicolai Hähnle
On 05.01.2017 17:59, Ilia Mirkin wrote: On Thu, Jan 5, 2017 at 11:30 AM, Nicolai Hähnle wrote: On 05.01.2017 17:02, Ilia Mirkin wrote: On Thu, Jan 5, 2017 at 10:48 AM, Nicolai Hähnle wrote: On 02.01.2017 21:41, Marek Olšák wrote: On Mon, Jan 2,

Re: [Mesa-dev] [PATCH 0/5] nvc0: better instruction pipelining for Maxwell GPUs

2017-01-06 Thread Samuel Pitoiset
On 01/06/2017 11:53 AM, Jan Vesely wrote: On Fri, 2016-12-23 at 00:15 +0100, Samuel Pitoiset wrote: Hello, This series makes use of the scheduling control code in order to improve the instruction pipelining on Maxwell GPUs. Starting with the Kepler architecture, where a control instruction

Re: [Mesa-dev] [PATCH 0/5] nvc0: better instruction pipelining for Maxwell GPUs

2017-01-06 Thread Jan Vesely
On Fri, 2016-12-23 at 00:15 +0100, Samuel Pitoiset wrote: > Hello, > > This series makes use of the scheduling control code in order to improve the > instruction pipelining on Maxwell GPUs. > > Starting with the Kepler architecture, where a control instruction has to be > inserted every 7

[Mesa-dev] [PATCH] i965: Fix texturing in the vec4 TCS and GS backends.

2017-01-06 Thread Kenneth Graunke
We were failing to zero m0.2 of the sampler message header for TCS and GS messages in the simple case. fs_generator has done this for about a year now, but we missed it in vec4_generator. Fixes ES31-CTS.core.texture_cube_map_array.sampling, GL45-CTS.texture_cube_map_array.sampling, and many

[Mesa-dev] [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs())

2017-01-06 Thread Samuel Pitoiset
D3D always computes the absolute value while GLSL says that the result of inversesqrt() is undefined if x <= 0 (and undefined if x < 0 for sqrt()). But some apps rely on this specific behaviour which is not clearly defined by OpenGL. Computing the absolute value before sqrt()/inversesqrt() will

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 --- Comment #4 from Jan Ziak <0xe2.0x9a.0...@gmail.com> --- (In reply to Jan Ziak from comment #3) > $ LIBGL_ALWAYS_SOFTWARE=1 GALLIUM_DRIVER=swr $ LIBGL_ALWAYS_SOFTWARE=1 GALLIUM_DRIVER=swr ./gl -- You are receiving this mail because: You are

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 --- Comment #3 from Jan Ziak <0xe2.0x9a.0...@gmail.com> --- I am unable to confirm whether this bug has been resolved. $ LIBGL_ALWAYS_SOFTWARE=1 GALLIUM_DRIVER=swr SWR detected AVX Segmentation fault $ gdb (gdb) bt #0 CreateThreadPool

Re: [Mesa-dev] [PATCH] anv: don't skip the VUE header if we are reading gl_Layer in a fragment shader

2017-01-06 Thread Iago Toral
On Thu, 2017-01-05 at 14:08 +0100, Iago Toral Quiroga wrote: > This is the same we do in the GL driver: the hardware provides > gl_Layer > in the VUE header, so when the fragment shader reads it we can't skip > it. Forgot to add that this fixes the following Vulkan CTS tests:

Re: [Mesa-dev] [PATCH 0/5] nvc0: better instruction pipelining for Maxwell GPUs

2017-01-06 Thread Samuel Pitoiset
On 01/06/2017 03:34 AM, Alexandre Courbot wrote: On 12/23/2016 08:15 AM, Samuel Pitoiset wrote: This series makes use of the scheduling control code in order to improve the instruction pipelining on Maxwell GPUs. Tested this on Jetson TX1. The performance improvement on glmark2 was only

[Mesa-dev] [PATCH] i965: Properly flush in hsw_pause_transform_feedback().

2017-01-06 Thread Kenneth Graunke
Fixes a number of transform feedback tests when run with Linux 4.8, which allows us to use the MI_LOAD_REGISTER_REG command, at which point we started using this new broken path. ES3-CTS.functional.transform_feedback.array_element.interleaved.lines.* and Piglit's arb_transform_feedback2/draw-auto

Re: [Mesa-dev] [PATCH mesa] drirc: remove spurious tabs

2017-01-06 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 01/06/2017 08:06 AM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/mesa/drivers/dri/common/drirc | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git