[Mesa-dev] [PATCH V4 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-20 Thread Timothy Arceri
For gpu generations that use LLVM we create a timestamp string containing both the LLVM and Mesa build times, otherwise we just use the Mesa build time. V2: share code in r600_pipe_common as suggested by Marek. V3: send the correct revision of V2 V4: rework the order we check chip_class so that

[Mesa-dev] [PATCH] util/disk_cache: create timestamp and gpu_id dirs when MESA_GLSL_CACHE_DIR is used

2017-02-20 Thread Timothy Arceri
The make check test is also updated to make sure these dirs are created. --- src/compiler/glsl/tests/cache_test.c | 40 src/util/disk_cache.c| 10 +++-- 2 files changed, 48 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH] st/nine: make use of common uploaders v4

2017-02-20 Thread Constantine Charlamov
Make use of common uploaders that landed recently to Mesa v2: fixed formatting, broken due to thunderbird configuration v3: per Axel comment: added a comment into NineDevice9_DrawPrimitiveUP v4: per Axel comment: changed style of the comment --- src/gallium/state_trackers/nine/device9.c|

[Mesa-dev] [PATCH 2/3] radv/ac: pass clips properly from vertex->geometry shader stages.

2017-02-20 Thread Dave Airlie
From: Dave Airlie This works out the geometry shader clip/cull inputs separately to the outputs, and uses that information to read from the ES->GS ring buffer. It stores the clip/cull distances packed into one or two slots. It fixes the es output emission and gs input reading

[Mesa-dev] [PATCH 1/3] radv/ac: rename num clips/cull to output clips/culls

2017-02-20 Thread Dave Airlie
From: Dave Airlie As geom shaders can have different ones on entry and exit. also move to uint8_t as these are never that big. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 20 ++-- 1 file changed, 10 insertions(+),

[Mesa-dev] [PATCH 3/3] radv/ac: handle gs->copy shader clip distances.

2017-02-20 Thread Dave Airlie
From: Dave Airlie This fixes up the clip distance passing between the geometry shader and the copy shader. It packs the clip and cull distances into one or two consecutive slots, and avoids wasting space and make sure the gs output and copy shader input agree on where things

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-20 Thread Roland Scheidegger
Am 20.02.2017 um 21:58 schrieb Marek Olšák: > On Mon, Feb 20, 2017 at 9:28 PM, Roland Scheidegger > wrote: >> Am 20.02.2017 um 20:56 schrieb Marek Olšák: >>> On Mon, Feb 20, 2017 at 8:29 PM, Axel Davy wrote: On 20/02/2017 20:11, Ilia Mirkin wrote:

Re: [Mesa-dev] [PATCH v2] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

2017-02-20 Thread Michel Dänzer
On 20/02/17 07:15 PM, Edward O'Callaghan wrote: > The name has become a little misleading now that it applies > to both r600g and radeonsi. > > V.2: Michel Dänzer - R600_DEBUG must continue to work. > > Signed-off-by: Edward O'Callaghan In addition to others'

[Mesa-dev] [PATCH V2 3.5/4] st/mesa: get on-disk shader cache

2017-02-20 Thread Timothy Arceri
V2: make sure callback exists before calling it --- src/mesa/state_tracker/st_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index f4ad6d8..6321309 100644 --- a/src/mesa/state_tracker/st_context.c +++

Re: [Mesa-dev] [PATCH 3.5/4] st/mesa: get on-disk shader cache

2017-02-20 Thread Timothy Arceri
On 21/02/17 13:20, Michel Dänzer wrote: On 21/02/17 08:23 AM, Timothy Arceri wrote: --- src/mesa/state_tracker/st_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index f4ad6d8..153f01c 100644 ---

Re: [Mesa-dev] [PATCH 2/2] vulkan/wsi/radv: add initial prime support

2017-02-20 Thread Mike Lothian
Feel free to add my "Tested by" to these Tested with vulkaninfo, vulkancube, vulkanscene and The Talos Principle 32bit & 64bit Cheers Mike On 21 February 2017 at 02:26, Dave Airlie wrote: > From: Dave Airlie > > This is a complete rewrite of my previous

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: move image count to shared structure.

2017-02-20 Thread Jason Ekstrand
Fine by me Reviewed-by: Jason Ekstrand On Mon, Feb 20, 2017 at 6:26 PM, Dave Airlie wrote: > From: Dave Airlie > > For prime support I need to access this, so move it in advance. > > Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH 2/2] vulkan/wsi/radv: add initial prime support

2017-02-20 Thread Dave Airlie
From: Dave Airlie This is a complete rewrite of my previous rfc patches. This adds the ability to present to a different GPU that rendering using a driver side operation that can copy from the tiled to linear shared image. This does prime support completely in the swapchain

[Mesa-dev] [PATCH 1/2] vulkan/wsi: move image count to shared structure.

2017-02-20 Thread Dave Airlie
From: Dave Airlie For prime support I need to access this, so move it in advance. Signed-off-by: Dave Airlie --- src/vulkan/wsi/wsi_common.h | 1 + src/vulkan/wsi/wsi_common_wayland.c | 20 +--- src/vulkan/wsi/wsi_common_x11.c

Re: [Mesa-dev] [PATCH 3.5/4] st/mesa: get on-disk shader cache

2017-02-20 Thread Michel Dänzer
On 21/02/17 08:23 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_context.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/state_tracker/st_context.c > b/src/mesa/state_tracker/st_context.c > index f4ad6d8..153f01c 100644 > ---

[Mesa-dev] [Bug 99849] Dashed lines (drawn via GLAMOR) are not rendered correctly

2017-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99849 --- Comment #5 from Michel Dänzer --- Xephyr -glamor is basically an OpenGL application like any other. E.g. you can create an apitrace reproducing the problem, if that helps. -- You are receiving this mail because: You are

Re: [Mesa-dev] [PATCH] glx/glvnd: Fix GLXdispatchIndex sorting

2017-02-20 Thread Hans de Goede
Hi Emil, On 16-02-17 16:38, Emil Velikov wrote: Hi Hans, On 6 February 2017 at 13:09, Hans de Goede wrote: Commit 8bca8d89ef3b ("glx/glvnd: Fix dispatch function names and indices") fixed the sorting of the array initializers in g_glxglvnddispatchfuncs.c because

Re: [Mesa-dev] [PATCH V3] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-20 Thread Timothy Arceri
On 21/02/17 10:35, Marek Olšák wrote: v2 looked better, because HAVE_LLVM can be > 0, but r600g doesn't need llvm_timestamp. (note that drivers/radeon is a static lib used by r600g and radeonsi) Sure but my thinking was that it wouldn't hurt much to append llvm anyway, but if

[Mesa-dev] [PATCH v2 1/5] intel/blorp: Explicitly flush all allocated state

2017-02-20 Thread Jason Ekstrand
Found by inspection. However, I expect it fixes real bugs when using blorp from Vulkan on little-core platforms. Cc: "13.0 17.0" --- src/intel/blorp/blorp_genX_exec.h | 17 - src/intel/vulkan/genX_blorp_exec.c | 8

Re: [Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

2017-02-20 Thread Marek Olšák
Pushed. Marek On Mon, Feb 20, 2017 at 11:40 PM, Grazvydas Ignotas wrote: > So, as there are no better solutions in sight, can somebody please > push this patch? > > Gražvydas > > On Wed, Feb 15, 2017 at 5:33 AM, Alex Deucher wrote: >> On Tue, Feb 14,

Re: [Mesa-dev] [PATCH V3] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-20 Thread Marek Olšák
v2 looked better, because HAVE_LLVM can be > 0, but r600g doesn't need llvm_timestamp. (note that drivers/radeon is a static lib used by r600g and radeonsi) Marek On Tue, Feb 21, 2017 at 12:31 AM, Timothy Arceri wrote: > For gpu generations that use LLVM we create a

[Mesa-dev] [PATCH V3] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-20 Thread Timothy Arceri
For gpu generations that use LLVM we create a timestamp string containing both the LLVM and Mesa build times, otherwise we just use the Mesa build time. V2: share code in r600_pipe_common as suggested by Marek. V3: send the correct revision of V2 ---

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] radeonsi: handle MultiDrawIndirect in si_get_draw_start_count

2017-02-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Feb 20, 2017 at 12:21 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Also handle the GL_ARB_indirect_parameters case where the count itself > is in a buffer. > > Use transfers rather

[Mesa-dev] [PATCH v2 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-20 Thread Timothy Arceri
For gpu generations that use LLVM we create a timestamp string containing both the LLVM and Mesa build times, otherwise we just use the Mesa build time. V2: share code in r600_pipe_common as suggested by Marek. --- src/gallium/drivers/radeon/r600_pipe_common.c | 44 +++

[Mesa-dev] [PATCH 3.5/4] st/mesa: get on-disk shader cache

2017-02-20 Thread Timothy Arceri
--- src/mesa/state_tracker/st_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index f4ad6d8..153f01c 100644 --- a/src/mesa/state_tracker/st_context.c +++ b/src/mesa/state_tracker/st_context.c @@ -538,6

Re: [Mesa-dev] [PATCH v2] radeonsi: handle MultiDrawIndirect in si_get_draw_start_count

2017-02-20 Thread Edward O'Callaghan
v2 is, Acked-by: Edward O'Callaghan On 02/21/2017 09:05 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Also handle the GL_ARB_indirect_parameters case where the count itself > is in a buffer. > > Use transfers rather than mapping the

Re: [Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

2017-02-20 Thread Grazvydas Ignotas
So, as there are no better solutions in sight, can somebody please push this patch? Gražvydas On Wed, Feb 15, 2017 at 5:33 AM, Alex Deucher wrote: > On Tue, Feb 14, 2017 at 10:27 PM, Michel Dänzer wrote: >> On 14/02/17 08:25 PM, Marek Olšák wrote: >>>

[Mesa-dev] [PATCH v2] radeonsi: handle MultiDrawIndirect in si_get_draw_start_count

2017-02-20 Thread Nicolai Hähnle
From: Nicolai Hähnle Also handle the GL_ARB_indirect_parameters case where the count itself is in a buffer. Use transfers rather than mapping the buffers directly. This anticipates the possibility that the buffers are sparse (once ARB_sparse_buffer is implemented), in

Re: [Mesa-dev] [PATCH] st/nine: make use of common uploaders v3

2017-02-20 Thread Axel Davy
On 20/02/2017 21:30, Constantine Charlamov wrote: Make use of common uploaders that landed recently to Mesa v2: fixed formatting, broken due to thunderbird configuration v3: per Axel comment: added a comment into NineDevice9_DrawPrimitiveUP --- src/gallium/state_trackers/nine/device9.c|

Re: [Mesa-dev] [PATCH] st/nine: make use of common uploaders v2

2017-02-20 Thread Constantine Charlamov
Version 3 sent. Sorry, I haven't figured out — I ought to add you to CC. On 20.02.2017 22:49, Axel Davy wrote: > On 20/02/2017 20:22, Constantine Charlamov wrote: >> Make use of common uploaders that landed recently to Mesa >> >> v2: fixed formatting, broken due to thunderbird configuration >>

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-20 Thread Marek Olšák
On Mon, Feb 20, 2017 at 9:28 PM, Roland Scheidegger wrote: > Am 20.02.2017 um 20:56 schrieb Marek Olšák: >> On Mon, Feb 20, 2017 at 8:29 PM, Axel Davy wrote: >>> On 20/02/2017 20:11, Ilia Mirkin wrote: On Mon, Feb 20, 2017 at 2:01 PM, Marek Olšák

Re: [Mesa-dev] [PATCH v2 1/3] i965/fs: fix indirect load DF uniforms on BSW/BXT

2017-02-20 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On Mon, 2017-02-20 at 08:58 +0100, Samuel Iglesias Gonsálvez wrote: >> On Sat, 2017-02-18 at 18:58 -0800, Francisco Jerez wrote: >> > Samuel Iglesias Gonsálvez writes: >> > >> > > The lowered BSW/BXT indirect move

[Mesa-dev] [PATCH] st/nine: make use of common uploaders v3

2017-02-20 Thread Constantine Charlamov
Make use of common uploaders that landed recently to Mesa v2: fixed formatting, broken due to thunderbird configuration v3: per Axel comment: added a comment into NineDevice9_DrawPrimitiveUP --- src/gallium/state_trackers/nine/device9.c| 50 +---

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-20 Thread Roland Scheidegger
Am 20.02.2017 um 20:56 schrieb Marek Olšák: > On Mon, Feb 20, 2017 at 8:29 PM, Axel Davy wrote: >> On 20/02/2017 20:11, Ilia Mirkin wrote: >>> >>> On Mon, Feb 20, 2017 at 2:01 PM, Marek Olšák wrote: Hi, I'd like to remove

[Mesa-dev] [Bug 98502] Delay when starting firefox, thunderbird or chromium and dmesg spam

2017-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98502 --- Comment #10 from Emil Velikov --- Guys, the kernel (v4.10) has been updated to provide the revision field [1], at the same time libdrm (v2.4.75) has API which does not fetch it [2] and the mesa patches [3] to us the

Re: [Mesa-dev] [PATCH] gallium: reorder fields in pipe_draw_info

2017-02-20 Thread Marek Olšák
On Mon, Feb 20, 2017 at 8:36 PM, Roland Scheidegger wrote: > Am 20.02.2017 um 20:08 schrieb Marek Olšák: >> On Mon, Feb 20, 2017 at 8:03 PM, Roland Scheidegger >> wrote: >>> This doesn't quite just do what the commit log says, since at least one >>>

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-20 Thread Marek Olšák
On Mon, Feb 20, 2017 at 8:29 PM, Axel Davy wrote: > On 20/02/2017 20:11, Ilia Mirkin wrote: >> >> On Mon, Feb 20, 2017 at 2:01 PM, Marek Olšák wrote: >>> >>> Hi, >>> >>> I'd like to remove pipe_context::set_index_buffer. It's not useful to >>> most drivers and

Re: [Mesa-dev] [PATCH v2 0/6] anv: Query cleanups and fixes

2017-02-20 Thread Lionel Landwerlin
This series is : Reviewed-by: Lionel Landwerlin On 20/02/17 19:25, Jason Ekstrand wrote: This series is a v2 of some of the patches I sent out on Saturday to fix queries. I've incorporated the review feedback from Lionel. All but the last two patches are CC'd

Re: [Mesa-dev] [PATCH] gallium: reorder fields in pipe_draw_info

2017-02-20 Thread Roland Scheidegger
Am 20.02.2017 um 20:08 schrieb Marek Olšák: > On Mon, Feb 20, 2017 at 8:03 PM, Roland Scheidegger > wrote: >> This doesn't quite just do what the commit log says, since at least one >> parameter is changed from unsigned to ubyte (I hope vertices_per_patch >> can't exceed that

Re: [Mesa-dev] [PATCH mesa 7/8] eglapi: make sure list is always sorted

2017-02-20 Thread Emil Velikov
On 19 February 2017 at 23:23, Eric Engestrom wrote: > Starting with the next commit, badly sorting this list will break the > eglGetProcAddress(). > > Signed-off-by: Eric Engestrom > --- > src/egl/Makefile.am | 3 ++- > src/egl/egl-entrypoint-check

Re: [Mesa-dev] [PATCH] st/nine: make use of common uploaders v2

2017-02-20 Thread Axel Davy
On 20/02/2017 20:22, Constantine Charlamov wrote: Make use of common uploaders that landed recently to Mesa v2: fixed formatting, broken due to thunderbird configuration --- src/gallium/state_trackers/nine/device9.c| 48

Re: [Mesa-dev] [PATCH 3/3] anv: Enable MSAA compression

2017-02-20 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 20/02/17 18:09, Jason Ekstrand wrote: This just enables basic MSAA compression (no fast clears) for all multisampled surfaces. This improves the framerate of the Sascha "multisampling" demo by 76% on my Sky Lake laptop. Running

Re: [Mesa-dev] [PATCH] docs/releasing.html: reword "distro breaking changes" hunk

2017-02-20 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh On Tue, Feb 21, 2017 at 12:57 AM, Emil Velikov wrote: > From: Emil Velikov > > Suggested-by: Eric Engestrom > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH v2] softpipe: implement clear_texture

2017-02-20 Thread Roland Scheidegger
Am 20.02.2017 um 18:01 schrieb Lars Hamre: > v2: rework util clear functions such that they operate on a resource > instead of a surface (Roland Scheidegger) > > Implements the ARB_clear_texture extension for softpipe. > Passes all corresponding piglit tests. > > Signed-off-by: Lars Hamre

Re: [Mesa-dev] [PATCH mesa 6/8] eglapi: move list out to its own file

2017-02-20 Thread Emil Velikov
2017-02-19 23:23 GMT+00:00 Eric Engestrom : > This will allow us to make sure the list is always sorted in the next > commit. > > Signed-off-by: Eric Engestrom > --- > src/egl/main/eglapi.c | 78 > +- >

Re: [Mesa-dev] [PATCH 2/3] isl: add MCS width constraint 16 samples

2017-02-20 Thread Lionel Landwerlin
On 20/02/17 19:12, Jason Ekstrand wrote: On Mon, Feb 20, 2017 at 10:33 AM, Lionel Landwerlin > wrote: On 20/02/17 18:09, Jason Ekstrand wrote: From: Lionel Landwerlin

Re: [Mesa-dev] [PATCH mesa 3/8] eglapi: add entrypoint for eglClientWaitSyncKHR

2017-02-20 Thread Emil Velikov
On 20 February 2017 at 00:03, Eric Engestrom wrote: > On Sunday, 2017-02-19 18:54:51 -0500, Ilia Mirkin wrote: >> On Sun, Feb 19, 2017 at 6:51 PM, Eric Engestrom wrote: >> > On Sunday, 2017-02-19 18:33:16 -0500, Ilia Mirkin wrote: >> >> Why are patches 1-3

[Mesa-dev] [PATCH] docs/releasing.html: reword "distro breaking changes" hunk

2017-02-20 Thread Emil Velikov
From: Emil Velikov Suggested-by: Eric Engestrom Signed-off-by: Emil Velikov --- docs/releasing.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/releasing.html

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-20 Thread Axel Davy
On 20/02/2017 20:11, Ilia Mirkin wrote: On Mon, Feb 20, 2017 at 2:01 PM, Marek Olšák wrote: Hi, I'd like to remove pipe_context::set_index_buffer. It's not useful to most drivers and the interface is inconvenient for Mesa/OpenGL, because it's a draw state that is set with a

[Mesa-dev] [PATCH v2 5/6] anv/Makefile: alphabetize

2017-02-20 Thread Jason Ekstrand
--- src/intel/vulkan/Makefile.sources | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/Makefile.sources b/src/intel/vulkan/Makefile.sources index bd78805..b99 100644 --- a/src/intel/vulkan/Makefile.sources +++ b/src/intel/vulkan/Makefile.sources @@

[Mesa-dev] [PATCH v2 6/6] anv: Put everything about queries in genX_query.c

2017-02-20 Thread Jason Ekstrand
--- src/intel/vulkan/Makefile.sources | 5 +- src/intel/vulkan/anv_query.c | 171 - src/intel/vulkan/genX_cmd_buffer.c | 306 --- src/intel/vulkan/genX_query.c | 480 + 4 files changed, 484 insertions(+), 478

[Mesa-dev] [PATCH v2 1/6] anv: Add an invalidate_range helper

2017-02-20 Thread Jason Ekstrand
This is similar to clflush_range except that it puts the mfence on the other side to ensure caches are flushed prior to reading. Cc: "13.0 17.0" --- src/intel/vulkan/anv_private.h | 13 + 1 file changed, 13 insertions(+) diff --git

[Mesa-dev] [PATCH v2 2/6] anv/query: clflush the bo map on non-LLC platforms

2017-02-20 Thread Jason Ekstrand
Found by inspection Cc: "13.0 17.0" --- src/intel/vulkan/anv_query.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_query.c b/src/intel/vulkan/anv_query.c index 293257b..da0deb8 100644 --- a/src/intel/vulkan/anv_query.c +++

[Mesa-dev] [PATCH v2 4/6] anv/query: Perform CmdResetQueryPool on the GPU

2017-02-20 Thread Jason Ekstrand
This fixes a some rendering corruption in The Talos Principle Cc: "13.0 17.0" --- src/intel/vulkan/anv_query.c | 22 -- src/intel/vulkan/genX_cmd_buffer.c | 30 ++ 2 files changed, 30 insertions(+), 22

[Mesa-dev] [PATCH v2 0/6] anv: Query cleanups and fixes

2017-02-20 Thread Jason Ekstrand
This series is a v2 of some of the patches I sent out on Saturday to fix queries. I've incorporated the review feedback from Lionel. All but the last two patches are CC'd to stable for both 13.0 and 17.0 as queries are pretty well busted without them. This series fixes some rendering errors in

[Mesa-dev] [PATCH v2 3/6] genxml: Make MI_STORE_DATA_IMM more consistent

2017-02-20 Thread Jason Ekstrand
Cc: "13.0 17.0" --- src/intel/genxml/gen6.xml | 2 +- src/intel/genxml/gen7.xml | 2 +- src/intel/genxml/gen75.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index

[Mesa-dev] [PATCH] st/nine: make use of common uploaders v2

2017-02-20 Thread Constantine Charlamov
Make use of common uploaders that landed recently to Mesa v2: fixed formatting, broken due to thunderbird configuration --- src/gallium/state_trackers/nine/device9.c| 48 src/gallium/state_trackers/nine/device9.h| 5 ---

[Mesa-dev] [PATCH 3/5] anv: Remove the unused state_pool_emit macro

2017-02-20 Thread Jason Ekstrand
--- src/intel/vulkan/anv_private.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 7bdbfab..73a3f29 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h @@ -791,20 +791,6 @@

[Mesa-dev] [PATCH 5/5] anv: Take a device parameter in anv_state_flush

2017-02-20 Thread Jason Ekstrand
This allows the helper to check for llc instead of having to do it manually at all the call sites. --- src/intel/vulkan/anv_cmd_buffer.c | 12 src/intel/vulkan/anv_device.c | 6 ++ src/intel/vulkan/anv_image.c | 9 +++-- src/intel/vulkan/anv_private.h | 15

[Mesa-dev] [PATCH 4/5] anv: Pull all clflushing into a clflush_range helper

2017-02-20 Thread Jason Ekstrand
All this cache line address calculation stuff is tricky. Let's not duplicate it more places than we have to. --- src/intel/vulkan/anv_device.c | 15 --- src/intel/vulkan/anv_private.h | 18 +- 2 files changed, 13 insertions(+), 20 deletions(-) diff --git

[Mesa-dev] [PATCH 2/5] anv: Rename clflush_range and state_clflush

2017-02-20 Thread Jason Ekstrand
It's a bit shorter and easier to work with. Also, we're about to add a helper called clflush which does the clflush but without any memory fencing. --- src/intel/vulkan/anv_batch_chain.c | 2 +- src/intel/vulkan/anv_cmd_buffer.c | 8 src/intel/vulkan/anv_device.c | 6 +++---

[Mesa-dev] [PATCH 0/5] anv: Fix and rework flushing

2017-02-20 Thread Jason Ekstrand
The first patch in this little series should fix actual bugs on little-core platforms because it makes BLORP properly clflush it's dynamic state in Vulkan. The GL driver is fine because it allocates it all out of the batch which gets implicitly flushed when it's submitted. The other patches just

[Mesa-dev] [PATCH 1/5] intel/blorp: Explicitly flush all allocated state

2017-02-20 Thread Jason Ekstrand
Found by inspection. However, I expect it fixes real bugs when using blorp from Vulkan on little-core platforms. Cc: "13.0 17.0" --- src/intel/blorp/blorp_genX_exec.h | 17 - src/intel/vulkan/genX_blorp_exec.c | 8

Re: [Mesa-dev] [PATCH 2/3] isl: add MCS width constraint 16 samples

2017-02-20 Thread Jason Ekstrand
On Mon, Feb 20, 2017 at 10:33 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 20/02/17 18:09, Jason Ekstrand wrote: > >> From: Lionel Landwerlin >> >> v3 (Jason Ekstrand): Add a comment explaining why >> >> Signed-off-by: Lionel Landwerlin

Re: [Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-20 Thread Ilia Mirkin
On Mon, Feb 20, 2017 at 2:01 PM, Marek Olšák wrote: > Hi, > > I'd like to remove pipe_context::set_index_buffer. It's not useful to > most drivers and the interface is inconvenient for Mesa/OpenGL, > because it's a draw state that is set with a separate driver callback, > which

Re: [Mesa-dev] [PATCH] gallium: reorder fields in pipe_draw_info

2017-02-20 Thread Marek Olšák
On Mon, Feb 20, 2017 at 8:03 PM, Roland Scheidegger wrote: > This doesn't quite just do what the commit log says, since at least one > parameter is changed from unsigned to ubyte (I hope vertices_per_patch > can't exceed that for any driver...) vertices_per_patch must be in

[Mesa-dev] [Bug 99849] Dashed lines (drawn via GLAMOR) are not rendered correctly

2017-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99849 --- Comment #4 from Roland Scheidegger --- Looks like this isn't using line stippling or anything like that, but just drawing a line with a texture attached, with a shader which discards pixel based on the texture value (I

Re: [Mesa-dev] [PATCH] gallium: reorder fields in pipe_draw_info

2017-02-20 Thread Roland Scheidegger
This doesn't quite just do what the commit log says, since at least one parameter is changed from unsigned to ubyte (I hope vertices_per_patch can't exceed that for any driver...) Otherwise seems reasonable. Roland Am 20.02.2017 um 19:35 schrieb Marek Olšák: > From: Marek Olšák

[Mesa-dev] Gallium: Removal of set_index_buffer (discussion)

2017-02-20 Thread Marek Olšák
Hi, I'd like to remove pipe_context::set_index_buffer. It's not useful to most drivers and the interface is inconvenient for Mesa/OpenGL, because it's a draw state that is set with a separate driver callback, which is an unnecessary driver roundtrip taking some CPU cycles. I'd prefer to pass the

[Mesa-dev] [PATCH] st/nine: make use of common uploaders

2017-02-20 Thread Constantine Charlamov
Make use of common uploaders that landed recently to Mesa --- src/gallium/state_trackers/nine/device9.c| 48 src/gallium/state_trackers/nine/device9.h| 5 --- src/gallium/state_trackers/nine/nine_ff.c| 8 ++---

Re: [Mesa-dev] [PATCH 4/4] anv: Put everything about queries in genX_query.c

2017-02-20 Thread Jason Ekstrand
On Mon, Feb 20, 2017 at 10:35 AM, Emil Velikov wrote: > On 18 February 2017 at 23:59, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/Makefile.sources | 5 +- > > src/intel/vulkan/anv_query.c | 171 - > Won't this lead to

[Mesa-dev] [PATCH] gallium: reorder fields in pipe_draw_info

2017-02-20 Thread Marek Olšák
From: Marek Olšák sizeof(struct pipe_draw_info) = 104 -> 88 --- src/gallium/include/pipe/p_state.h | 49 -- 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/src/gallium/include/pipe/p_state.h

Re: [Mesa-dev] [PATCH 4/4] anv: Put everything about queries in genX_query.c

2017-02-20 Thread Emil Velikov
On 18 February 2017 at 23:59, Jason Ekstrand wrote: > --- > src/intel/vulkan/Makefile.sources | 5 +- > src/intel/vulkan/anv_query.c | 171 - Won't this lead to this [albeit trivial] code built 4 times instead of once ? Worth mentioning in the commit

[Mesa-dev] [PATCH] vbo: kill primitive restart lowering in glDrawArrays

2017-02-20 Thread Marek Olšák
From: Marek Olšák --- src/mesa/vbo/vbo_exec_array.c | 56 ++- 1 file changed, 7 insertions(+), 49 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index 6a96167..30c52d5 100644 ---

Re: [Mesa-dev] [PATCH 2/3] isl: add MCS width constraint 16 samples

2017-02-20 Thread Lionel Landwerlin
On 20/02/17 18:09, Jason Ekstrand wrote: From: Lionel Landwerlin v3 (Jason Ekstrand): Add a comment explaining why Signed-off-by: Lionel Landwerlin Reviewed-by: Jason Ekstrand --- src/intel/isl/isl.c | 10

[Mesa-dev] [Bug 99849] Dashed lines (drawn via GLAMOR) are not rendered correctly

2017-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99849 --- Comment #3 from Max Staudt --- I've also reproduced this on the most recent openSUSE Tumbleweed snapshot, which includes Mesa 17.0.0 and Xorg 1.19.1. -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [PATCH 2/3] isl: add MCS width constraint 16 samples

2017-02-20 Thread Jason Ekstrand
From: Lionel Landwerlin v3 (Jason Ekstrand): Add a comment explaining why Signed-off-by: Lionel Landwerlin Reviewed-by: Jason Ekstrand --- src/intel/isl/isl.c | 10 ++ 1 file changed, 10 insertions(+)

[Mesa-dev] [PATCH 1/3] isl: Return surface creation success from aux helpers

2017-02-20 Thread Jason Ekstrand
The isl_surf_init call that each of these helpers make can, in theory, fail. We should propagate that up to the caller rather than just silently ignoring it. Reviewed-by: Topi Pohjolainen --- src/intel/isl/isl.c | 72

[Mesa-dev] [PATCH 3/3] anv: Enable MSAA compression

2017-02-20 Thread Jason Ekstrand
This just enables basic MSAA compression (no fast clears) for all multisampled surfaces. This improves the framerate of the Sascha "multisampling" demo by 76% on my Sky Lake laptop. Running Talos on medium settings with 8x MSAA, this improves the framerate in the benchmark by 80%. ---

[Mesa-dev] [PATCH 1/5] etnaviv: add support for user index buffers

2017-02-20 Thread Marek Olšák
From: Marek Olšák v2: fix a bug in u_helpers --- src/gallium/auxiliary/util/u_helpers.c| 29 +++ src/gallium/auxiliary/util/u_helpers.h| 5 + src/gallium/drivers/etnaviv/etnaviv_context.c | 12 +++

[Mesa-dev] [Bug 99849] Dashed lines (drawn via GLAMOR) are not rendered correctly

2017-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99849 --- Comment #2 from Max Staudt --- (In reply to Brian Paul from comment #1) > Which software renderer? swrast, softpipe, llvmpipe, swr? I just did a > quick test of softpipe and llvmpipe and stippled lines look OK here. > >

[Mesa-dev] [PATCH 4/4] gallium/hud: handle a thread switch for API-thread-busy monitoring

2017-02-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_cpu.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_cpu.c b/src/gallium/auxiliary/hud/hud_cpu.c index 1cba353..302445d 100644 ---

[Mesa-dev] [PATCH 3/4] gallium/hud: prevent an infinite loop

2017-02-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index aaa52d5..488fe66 100644 ---

[Mesa-dev] [PATCH 2/4] gallium/u_queue: isolate util_queue_fence implementation

2017-02-20 Thread Marek Olšák
From: Marek Olšák it's cleaner this way. --- src/gallium/auxiliary/util/u_queue.c| 42 ++--- src/gallium/auxiliary/util/u_queue.h| 2 +- src/gallium/drivers/freedreno/freedreno_batch.c | 2 +-

[Mesa-dev] [PATCH 1/4] gallium/u_queue: fix random crashes when the app calls exit()

2017-02-20 Thread Marek Olšák
From: Marek Olšák This fixes: vdpauinfo: ../lib/CodeGen/TargetPassConfig.cpp:579: virtual void llvm::TargetPassConfig::addMachinePasses(): Assertion `TPI && IPI && "Pass ID not registered!"' failed. Cc: 13.0 17.0 ---

Re: [Mesa-dev] [PATCH v2] isl: add MCS width constraint 16 samples

2017-02-20 Thread Jason Ekstrand
On Mon, Feb 20, 2017 at 8:10 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Applies on top of Jason's patch : > >https://patchwork.freedesktop.org/patch/139603/ > > Signed-off-by: Lionel Landwerlin > Cc: Jason Ekstrand >

Re: [Mesa-dev] [PATCH 00/13] Misc extern C fixes

2017-02-20 Thread Emil Velikov
On 20 February 2017 at 16:14, Brian Paul wrote: > On 02/16/2017 08:16 AM, Emil Velikov wrote: >> >> Just a bunch of extern C issues flagged by [1]. There's a few more >> remaining such as the glsl_types C API living in nir_types.{cpp,h} but >> that can be resolved at a later

Re: [Mesa-dev] [PATCH] android: glsl: build shader cache sources

2017-02-20 Thread Emil Velikov
On 20 February 2017 at 09:31, Tapani Pälli wrote: > On 02/19/2017 03:06 AM, Timothy Arceri wrote: >> >> I would have thought this commit [1] should have fixed it for android as >> weel as scons. >> >> [1] >> >>

Re: [Mesa-dev] [PATCH] android: glsl: build shader cache sources

2017-02-20 Thread Emil Velikov
On 19 February 2017 at 01:06, Timothy Arceri wrote: > I would have thought this commit [1] should have fixed it for android as > weel as scons. > As Tapani mentioned - I've opted to disable the code for scons (since it doesn't build) and enable it for everyone else... but

[Mesa-dev] [PATCH v2] softpipe: implement clear_texture

2017-02-20 Thread Lars Hamre
v2: rework util clear functions such that they operate on a resource instead of a surface (Roland Scheidegger) Implements the ARB_clear_texture extension for softpipe. Passes all corresponding piglit tests. Signed-off-by: Lars Hamre --- CC: Roland Scheidegger

[Mesa-dev] [Bug 99875] [radv] gears demo triggers an assertion error on window resize

2017-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99875 Bug ID: 99875 Summary: [radv] gears demo triggers an assertion error on window resize Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [Bug 99681] [vulkan/radeon] dota2 -vulkan assertion failure with LLVM 4.0.0-rc1

2017-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99681 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 98588] [vulkan/radeon] vulkancube & vulkansmoketest rendering issue on R9-390

2017-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98588 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-20 Thread Marek Olšák
You could do all of this in r600_pipe_common.c by using HAVE_LLVM and rscreen->chip_class. Marek On Mon, Feb 20, 2017 at 1:15 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/r600/r600_pipe.c | 19 +++ >

Re: [Mesa-dev] [PATCH] util/build-id: define ElfW and NT_GNU_BUILD_ID if needed

2017-02-20 Thread Emil Velikov
On 18 February 2017 at 07:56, Jonathan Gray wrote: > Define ElfW() and NT_GNU_BUILD_ID if needed as these defines are not > present on at least OpenBSD and FreeBSD. Fixes the build on OpenBSD. > > Signed-off-by: Jonathan Gray R-b and pushed to master. Thank you

Re: [Mesa-dev] [PATCH 1/7] gallium/util: remove unused helper util_draw_texquad

2017-02-20 Thread Brian Paul
I verified that the removed functions are not needed by our in-house code. Other than comments on patch 5, the series is Reviewed-by: Brian Paul On 02/16/2017 05:52 AM, Marek Olšák wrote: From: Marek Olšák ---

Re: [Mesa-dev] [PATCH 5/7] gallium/u_suballoc: allow setting pipe_resource::flags

2017-02-20 Thread Brian Paul
On 02/16/2017 05:52 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/util/u_suballoc.c | 22 ++ src/gallium/auxiliary/util/u_suballoc.h | 2 +- src/gallium/drivers/r600/r600_pipe.c | 5 +++--

Re: [Mesa-dev] [PATCH 6/6] radeonsi: fix issues with monolithic shaders

2017-02-20 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 19.02.2017 17:27, Marek Olšák wrote: From: Marek Olšák R600_DEBUG=mono has had no effect since: commit 1fabb297177069e95ec1bb7053acb32f8ec3e092 Author: Marek Olšák

Re: [Mesa-dev] [PATCH 00/13] Misc extern C fixes

2017-02-20 Thread Brian Paul
On 02/16/2017 08:16 AM, Emil Velikov wrote: Just a bunch of extern C issues flagged by [1]. There's a few more remaining such as the glsl_types C API living in nir_types.{cpp,h} but that can be resolved at a later date. -Emil [1] git grep -B2 "#.*\" -- src/ | grep

[Mesa-dev] [Bug 98279] [vulkan/radeon] dota2 -vulkan hangs the GPU on R9-390

2017-02-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98279 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added Resolution|--- |FIXED

  1   2   >