Re: [Mesa-dev] [PATCH] isl/state: fix assert on raw buffer surface state minimum size

On 22/02/17 17:32, Jason Ekstrand wrote: > Seems reasonable Are you sure this isn't somehow required on old hardware? > This assert is inside if (gen >= 7) block. I have checked all gen7+ specs and they all say the same. What I saw was that for PLANAR* surface formats, num_elements must be a

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix crash in shader cache cased by race condition

On 23/02/17 12:59 PM, Timothy Arceri wrote: > If a thread doesn't load GLSL IR from cache but does load TGSI > from cache (that was created by another thread) than it will > crash due to expecting gl_program_parameter_list to have been > restored from the GLSL IR cache and not be null. > --- >

Re: [Mesa-dev] [PATCH] glsl: enable early_fragment_tests implicitly with post_depth_coverage

On Wed, 2017-02-22 at 21:15 +0100, Marek Olšák wrote: > On Wed, Feb 22, 2017 at 9:11 PM, Matt Turner > wrote: > > > > On Wed, Feb 22, 2017 at 12:06 AM, Iago Toral Quiroga > .com> wrote: > > > > > > From: Iago Toral Quiroga

Re: [Mesa-dev] [PATCH 1/4] gallium/u_queue: fix random crashes when the app calls exit()

On 23/02/17 03:44 PM, Michel Dänzer wrote: > On 22/02/17 06:05 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> This fixes: >> vdpauinfo: ../lib/CodeGen/TargetPassConfig.cpp:579: virtual void >> llvm::TargetPassConfig::addMachinePasses(): Assertion `TPI && IPI && >>

Re: [Mesa-dev] [PATCH] anv: ensure that we do not emit negative Depth in 3DSTATE_DEPTH_BUFFER

Hi Lionel, this is because the tests this fixes are in review process and have not landed yet, I'll send you the links so you can have a look. Iago On Wed, 2017-02-22 at 15:11 +, Lionel Landwerlin wrote: > I can't reproduce on the vulkan-cts-next-dev (I just pull -r, so I  > shouldn't miss

Re: [Mesa-dev] [PATCH 1/4] gallium/u_queue: fix random crashes when the app calls exit()

On 22/02/17 06:05 AM, Marek Olšák wrote: > From: Marek Olšák > > This fixes: > vdpauinfo: ../lib/CodeGen/TargetPassConfig.cpp:579: virtual void > llvm::TargetPassConfig::addMachinePasses(): Assertion `TPI && IPI && > "Pass ID not registered!"' failed. > > v2:

[Mesa-dev] [Bug 99677] heap-use-after-free in glsl

https://bugs.freedesktop.org/show_bug.cgi?id=99677 Samuel Iglesias Gonsálvez changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH 2/6] radv: enable location at sample when persample is forced.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index dd6deef..5b7564c 100644 ---

[Mesa-dev] [PATCH 6/6] radv: add sample mask output support

From: Dave Airlie This adds support to write to sample mask from the fragment shader. We can optimise this later like radeonsi. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 8 ++-- src/amd/common/ac_nir_to_llvm.h | 1 +

[Mesa-dev] [PATCH 4/6] radv: fetch sample index via fmask for image coord as well.

From: Dave Airlie This follows the txf_ms code, I can't figure out why amdgpu-pro doesn't do this in their shaders, they must know someone we don't. This fixes: dEQP-VK.pipeline.multisample_shader_builtin.sample_id.* Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH 1/6] radv: fix interpolation at wrong place for offset interp

From: Dave Airlie The code was interpolating at the offset from the sample, not the offset from the center. Also fix for persample interpolation modes we should force the pixel center to be at the sample. Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH 5/6] radv/ac: refactor our fmask sample index fixup.

From: Dave Airlie This refactors out the sample index fixup between txf and image load. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 229 +++- 1 file changed, 107 insertions(+), 122 deletions(-)

[Mesa-dev] radv multisample interpolation fixes

This is a bunch of changes to fix some of the radv multisample interpolation bugs. Still not perfect but gets a run of CTS multisample tests from 180/231 to 216/231. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 3/6] radv: add sample mask input support

From: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index ca1416d..0cc5810 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

Re: [Mesa-dev] [Mesa-stable] [PATCH v2 1/3] i965/fs: fix indirect load DF uniforms on BSW/BXT

Samuel Iglesias Gonsálvez writes: > On 21/02/17 21:07, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >>> On 20/02/17 21:31, Francisco Jerez wrote: Samuel Iglesias Gonsálvez writes: > On Mon,

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix crash in shader cache cased by race condition

1&2 are, Reviewed-by: Edward O'Callaghan On 02/23/2017 02:59 PM, Timothy Arceri wrote: > If a thread doesn't load GLSL IR from cache but does load TGSI > from cache (that was created by another thread) than it will > crash due to expecting gl_program_parameter_list

Re: [Mesa-dev] [PATCH 2/2] haiku/winsys: fix dt prototype args

On 02/22/2017 03:56 PM, Alexander von Gluck IV wrote: From: Jerome Duval --- src/gallium/winsys/sw/hgl/hgl_sw_winsys.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/sw/hgl/hgl_sw_winsys.c

Re: [Mesa-dev] [PATCH 2/2] st/wgl: flush with ST_FLUSH_WAIT before releasing shared contexts

For both, Reviewed-by: Brian Paul On 02/18/2017 02:45 AM, Charmaine Lee wrote: Before releasing a shared context, flush the context with ST_FLUSH_WAIT to make sure all commands are executed. This ensures that rendering to any shared resources is completed before they will

Re: [Mesa-dev] [PATCH 5/5] st/mesa: don't update unrelated states in non-draw calls such as Clear

Series LGTM. Reviewed-by: Brian Paul On 02/22/2017 05:07 PM, Marek Olšák wrote: From: Marek Olšák If a VAO isn't bound and u_vbuf isn't enabled because of the Core profile, we'll get user vertex buffers in drivers if we update vertex buffers in

[Mesa-dev] [PATCH 1/2] st/mesa: fix crash in shader cache cased by race condition

If a thread doesn't load GLSL IR from cache but does load TGSI from cache (that was created by another thread) than it will crash due to expecting gl_program_parameter_list to have been restored from the GLSL IR cache and not be null. --- src/mesa/state_tracker/st_shader_cache.c | 14

[Mesa-dev] [PATCH 2/2] st/mesa: free shader cache buffer on fallback

--- src/mesa/state_tracker/st_shader_cache.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_shader_cache.c b/src/mesa/state_tracker/st_shader_cache.c index eb66f99..fba4b0a 100644 --- a/src/mesa/state_tracker/st_shader_cache.c +++

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-diskcache

On 23/02/17 09:44, Marc Dietrich wrote: Am Mittwoch, 22. Februar 2017, 22:27:42 CET schrieb Timothy Arceri: On 23/02/17 01:57, Marc Dietrich wrote: Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov: On 22 February 2017 at 13:31, Marc Dietrich wrote: Am

Re: [Mesa-dev] [PATCH] radeon: fix r600 builds when old version of llvm is present

Reviewed-by: Edward O'Callaghan On 02/23/2017 01:37 PM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c >

[Mesa-dev] [PATCH] radeon: fix r600 builds when old version of llvm is present

--- src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index bae6d6f..9a514e3 100644 ---

Re: [Mesa-dev] [PATCH 1/4 v3] gallium: implement util_clear_texture

On 02/23/2017 12:52 PM, Roland Scheidegger wrote: > For the series: > Reviewed-by: Roland Scheidegger Reviewed-by: Edward O'Callaghan > > (I'll commit this tomorrow). > > Roland > > Am 22.02.2017 um 16:56 schrieb Lars Hamre: >> v3: have

[Mesa-dev] [PATCH 1/2] radeonsi: add support for an on-disk shader cache

From: kdj0c V2 (Timothy Arceri): - when loading from disk cache also binary insert into memory cache. - check that the binary loaded from disk is the correct size. If not delete the cache item and skip loading from cache. --- src/gallium/drivers/radeonsi/si_state_shaders.c |

[Mesa-dev] [PATCH 2/2] Revert "glsl: Switch to disable-by-default for the GLSL shader cache"

This reverts commit 0f60c6616e93cba72bff4fbfedb72a753ef78e05. Piglit and all games tested so far seem to be working without issue. This change will allow wide user testing and we can decided before the next release if we need to turn it off again. --- I'm in the process of doing some CTS

[Mesa-dev] [PATCH] glsl: Raise a link error for non-SSO ES programs with a TES but no TCS.

OpenGL allows the TCS to be missing and supplies an implicit passthrough shader, but OpenGL ES does not. One open question is how to handle this for ARB_ES3_2_compatibility. This patch raises the link error for all ES shading language programs, but it might make sense to base it on the API. The

Re: [Mesa-dev] [PATCH 4/4] mesa: Avoid out-of-bounds stack read via _mesa_Materiali

On 02/22/2017 11:04 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > MATERIALFV may end up reading up to 4 floats from the passed parameter. > > This should really set a GL_INVALID_ENUM error in the cases where it > matters, but does anybody really care? Probably

Re: [Mesa-dev] [PATCH 1/4 v3] gallium: implement util_clear_texture

For the series: Reviewed-by: Roland Scheidegger (I'll commit this tomorrow). Roland Am 22.02.2017 um 16:56 schrieb Lars Hamre: > v3: have util_clear_texture mirror the pipe function (Roland Scheidegger) > v2: rework util clear functions such that they operate on a resource

Re: [Mesa-dev] [PATCH 1/4] mesa/main: fix MultiDrawElements[BaseVertex] validation of primcount

On 02/22/2017 11:04 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > primcount must be a GLsizei as in the signature for MultiDrawElements > or bad things can happen. > > Furthermore, an error should be flagged when primcount is negative > (plus there is an argument

Re: [Mesa-dev] [PATCH 1/2] glsl: fix heap-use-after-free in ast_declarator_list::hir()

On 02/09/2017 06:23 AM, Samuel Iglesias Gonsálvez wrote: > The get_variable_being_redeclared() function can free 'var' because > a re-declaration of an unsized array variable can establish the size, so > we set the array type to the 'earlier' declaration and free 'var' as it is > not needed

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] glsl: fix use-after-free when processing array re-declarations

On 02/22/2017 03:08 PM, Timothy Arceri wrote: > On 23/02/17 07:44, Ian Romanick wrote: >> I thought we already landed a different patch for this. I'll look >> through the archives when I get back in front of a computer... >> > > It looks like the patches are still waiting on a review: > >

Re: [Mesa-dev] [PATCH 3/3] radv/ac: handle gs->copy shader clip distances.

Series is: Reviewed-by: Bas Nieuwenhuizen On Tue, Feb 21, 2017 at 5:14 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes up the clip distance passing between the geometry > shader and the copy shader. It packs the clip

Re: [Mesa-dev] [PATCH mesa v2] glx: add GLXdispatchIndex sort check

Hi, On 22-02-17 12:24, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- v2: make sure the list is in the order C's strcmp uses (Ilia) Ilia: I used LC_ALL instead of LANG, as it takes precedence (ie. LANG=C in this script would be overridden by

Re: [Mesa-dev] [PATCH] vulkan: Fix gen_enum_to_str in out of tree builds

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] vulkan: Fix gen_enum_to_str in out of tree builds

This fixes the build for me and I've tested vulkan programs still work Reviewed-and-Tested-by: Mike Lothian On 23 February 2017 at 00:38, Dylan Baker wrote: > In some configurations the util directory is created when building out > of tree, but not

[Mesa-dev] [PATCH] vulkan: Fix gen_enum_to_str in out of tree builds

In some configurations the util directory is created when building out of tree, but not others. This patch ensures that it's created. cc: Matt Turner Signed-off-by: Dylan Baker --- src/vulkan/Makefile.am | 6 +- 1 file changed, 5 insertions(+),

[Mesa-dev] [PATCH] anv/image: Remove extra dependency on HiZ-specific variable

Depth buffers aren't allowed to be used as storage images. Fixes: 055ff2ec521 ("anv: Replace anv_image_has_hiz() with ISL_AUX_USAGE_HIZ") Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 4/5] st/mesa: set blend state for PBO readbacks

From: Marek Olšák v2: restore the state Cc: 13.0 17.0 --- src/mesa/state_tracker/st_cb_readpixels.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_readpixels.c

Re: [Mesa-dev] [PATCH 4/5] st/mesa: set blend state for PBO readbacks

BTW, the blend state here doesn't matter, because the framebuffer has no attachments. The idea is to have any non-NULL blend state set, so that drivers don't have to check for NULL everywhere. Marek On Thu, Feb 23, 2017 at 1:07 AM, Marek Olšák wrote: > From: Marek Olšák

[Mesa-dev] [PATCH 2/5] st/mesa: don't check st->vp in update_clip

From: Marek Olšák The clip state is updated before VS, so it can be NULL for the first draw call. Just remove the unnecessary dependency on st->vp. --- src/mesa/state_tracker/st_atom_clip.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 5/5] st/mesa: don't update unrelated states in non-draw calls such as Clear

From: Marek Olšák If a VAO isn't bound and u_vbuf isn't enabled because of the Core profile, we'll get user vertex buffers in drivers if we update vertex buffers in glClear. So don't do that. This fixes a regression since disabling u_vbuf for Core profiles. ---

[Mesa-dev] [PATCH 4/5] st/mesa: set blend state for PBO readbacks

From: Marek Olšák Cc: 13.0 17.0 --- src/mesa/state_tracker/st_cb_readpixels.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_cb_readpixels.c b/src/mesa/state_tracker/st_cb_readpixels.c index

[Mesa-dev] [PATCH 3/5] st/mesa: reset sample_mask, min_sample, and render_condition for PBO ops

From: Marek Olšák Cc: 13.0 17.0 --- src/mesa/state_tracker/st_cb_readpixels.c | 7 +++ src/mesa/state_tracker/st_cb_texture.c| 6 ++ 2 files changed, 13 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_readpixels.c

[Mesa-dev] [PATCH 1/5] trace: remove pipe_resource wrapping

From: Marek Olšák Not needed. ddebug does the same thing. The limitation is that drivers can only use pipe_resource::screen through pipe_resource_reference. This unbreaks trace, because pipe_context uploaders aren't wrapped, so trace doesn't understand buffers returned by

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

FWIW I'm seeing a build failure with llvm 3.3 (in a autotools build): ../../../../../src/gallium/drivers/radeon/r600_pipe_common.c:47:34: fatal error: llvm-c/TargetMachine.h: No such file or directory Not sure why though, the file would certainly exist... Roland Am 22.02.2017 um 04:45 schrieb

[Mesa-dev] [PATCH 2/2] gallivm, ac: add function attributes at call sites instead of declarations

From: Marek Olšák They can vary at call sites if the intrinsic is NOT a legacy SI intrinsic. We need this to force readnone or inaccessiblememonly on some amdgcn intrinsics. This is only used with LLVM 4.0 and later. Intrinsics only used with LLVM <= 3.9 don't need the

[Mesa-dev] [PATCH 1/2] gallivm, ac: remove unused FUNC_ATTR_LAST enums

From: Marek Olšák --- src/amd/common/ac_llvm_util.h | 1 - src/gallium/auxiliary/gallivm/lp_bld_intr.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/amd/common/ac_llvm_util.h b/src/amd/common/ac_llvm_util.h index 1f37a12..93d3d27 100644 ---

Re: [Mesa-dev] [PATCH 4/4] mesa: Avoid out-of-bounds stack read via _mesa_Materiali

indeed 1, 3 & 4 - good catches, Reviewed-by: Edward O'Callaghan On 02/23/2017 07:29 AM, Marek Olšák wrote: > For 1, 3, 4: > > Reviewed-by: Marek Olšák > > I need some time to review patch 2 unless someone else beats me to it. > > Marek > >

Re: [Mesa-dev] [PATCH 02/13] anv: Use python style in anv_entrypoints_gen.py

Quoting Jason Ekstrand (2017-02-22 15:28:50) > On Wed, Feb 22, 2017 at 3:15 PM, Dylan Baker wrote: > > These are all fairly small cleanups/tweaks that don't really deserve > their own patch. > > - Prefer comprehensions to map() and filter(), since they're faster

[Mesa-dev] [RESEND 03/13] anv: make constants capitals in anv_entrypoints_gen.py

Again, it's standard python style. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [RESEND 06/13] anv: convert header generation in anv_entrypoints_gen.py to mako

This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 75 ++--- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [RESEND 11/13] anv: use dict.get in anv_entrypoints_gen.py

Instead of using an if and a check, use dict.get, which does the same thing, but more succinctly. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[Mesa-dev] [RESEND 13/13] anv: use cElementTree in anv_entrypoints_gen.py

It's written in C rather than pure python and is strictly faster, the only reason not to use it that it's classes cannot be subclassed. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [RESEND 02/13] anv: Use python style in anv_entrypoints_gen.py

These are all fairly small cleanups/tweaks that don't really deserve their own patch. - Prefer comprehensions to map() and filter(), since they're faster - replace unused variables with _ - Use 4 spaces of indent - drop semicolons from the end of lines - Don't use parens around if conditions -

[Mesa-dev] [RESEND 07/13] anv: convert C generation to template in anv_entrypoints_gen.py

This produces a file that is identical except for whitespace, there is a table that has 8 columns in the original and is easy to do with prints, but is ugly using mako, so it doesn't have columns; the data is not inherently tabular. Signed-off-by: Dylan Baker ---

[Mesa-dev] [RESEND 10/13] anv: anv_entrypoints_gen.py: use reduce function.

Reduce is it's own reward. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index

[Mesa-dev] [RESEND 09/13] anv: anv-entrypoints_gen.py: rename hash to cal_hash.

hash is reserved name in python, it's the interface to access an object's hash protocol. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [RESEND 01/13] anv: anv_entrypoints_gen.py: use a main function

This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [RESEND 05/13] anv: split main into two functions in anv_entrypoints_gen.py

This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 96 +

[Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

This changes the python generator to write the files itself, rather than piping them out. This has a couple of advantages: first, it encapsulates the encoding. Second, it ensures that the header file and code file are generated at the same time with the same data. Signed-off-by: Dylan Baker

[Mesa-dev] [RESEND 12/13] anv: don't use Element.get in anv_entrypoints_gen.py

This has the potential to mask errors, since Element.get works like dict.get, returning None if the element isn't found. I think the reason that Element.get was used is that vulkan has one extension that isn't really an extension, and thus is missing the 'protect' field. This patch changes the

[Mesa-dev] [RESEND 04/13] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

It's slow, and has the potential for encoding issues. Signed-off-by: Dylan Baker --- src/intel/vulkan/Makefile.am| 6 ++ src/intel/vulkan/anv_entrypoints_gen.py | 6 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [RESEND 13/13] anv: use cElementTree in anv_entrypoints_gen.py

It's written in C rather than pure python and is strictly faster, the only reason not to use it that it's classes cannot be subclassed. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [RESEND 06/13] anv: convert header generation in anv_entrypoints_gen.py to mako

This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 75 ++--- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [RESEND 09/13] anv: anv-entrypoints_gen.py: rename hash to cal_hash.

hash is reserved name in python, it's the interface to access an object's hash protocol. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [RESEND 07/13] anv: convert C generation to template in anv_entrypoints_gen.py

This produces a file that is identical except for whitespace, there is a table that has 8 columns in the original and is easy to do with prints, but is ugly using mako, so it doesn't have columns; the data is not inherently tabular. Signed-off-by: Dylan Baker ---

[Mesa-dev] [RESEND 10/13] anv: anv_entrypoints_gen.py: use reduce function.

Reduce is it's own reward. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index

[Mesa-dev] [RESEND 02/13] anv: Use python style in anv_entrypoints_gen.py

These are all fairly small cleanups/tweaks that don't really deserve their own patch. - Prefer comprehensions to map() and filter(), since they're faster - replace unused variables with _ - Use 4 spaces of indent - drop semicolons from the end of lines - Don't use parens around if conditions -

[Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

This changes the python generator to write the files itself, rather than piping them out. This has a couple of advantages: first, it encapsulates the encoding. Second, it ensures that the header file and code file are generated at the same time with the same data. Signed-off-by: Dylan Baker

[Mesa-dev] [RESEND 05/13] anv: split main into two functions in anv_entrypoints_gen.py

This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 96 +

[Mesa-dev] [RESEND 11/13] anv: use dict.get in anv_entrypoints_gen.py

Instead of using an if and a check, use dict.get, which does the same thing, but more succinctly. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[Mesa-dev] [RESEND 12/13] anv: don't use Element.get in anv_entrypoints_gen.py

This has the potential to mask errors, since Element.get works like dict.get, returning None if the element isn't found. I think the reason that Element.get was used is that vulkan has one extension that isn't really an extension, and thus is missing the 'protect' field. This patch changes the

[Mesa-dev] [RESEND 04/13] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

It's slow, and has the potential for encoding issues. Signed-off-by: Dylan Baker --- src/intel/vulkan/Makefile.am| 6 ++ src/intel/vulkan/anv_entrypoints_gen.py | 6 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [RESEND 03/13] anv: make constants capitals in anv_entrypoints_gen.py

Again, it's standard python style. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [RESEND 01/13] anv: anv_entrypoints_gen.py: use a main function

This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

Re: [Mesa-dev] [PATCH 02/13] anv: Use python style in anv_entrypoints_gen.py

On Wed, Feb 22, 2017 at 3:15 PM, Dylan Baker wrote: > These are all fairly small cleanups/tweaks that don't really deserve > their own patch. > > - Prefer comprehensions to map() and filter(), since they're faster > - replace unused variables with _ > - Use 4 spaces of

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-diskcache

On 23/02/17 09:44, Marc Dietrich wrote: Am Mittwoch, 22. Februar 2017, 22:27:42 CET schrieb Timothy Arceri: On 23/02/17 01:57, Marc Dietrich wrote: Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov: On 22 February 2017 at 13:31, Marc Dietrich wrote: Am

[Mesa-dev] [PATCH 00/13] cleanup anv_entrpoints_gen.py

There are a number of small style cleanups and simplifications in this series, but the main changes are: - use a mako template to generate the header and code rather than prints - be python 3.x ready (the goal isn't to write python 3 code, but to write code that is easy to port or hybridize)

[Mesa-dev] [PATCH 05/13] anv: split main into two functions in anv_entrypoints_gen.py

This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 96 +

[Mesa-dev] [PATCH 06/13] anv: convert header generation in anv_entrypoints_gen.py to mako

This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 75 ++--- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH 02/13] anv: Use python style in anv_entrypoints_gen.py

These are all fairly small cleanups/tweaks that don't really deserve their own patch. - Prefer comprehensions to map() and filter(), since they're faster - replace unused variables with _ - Use 4 spaces of indent - drop semicolons from the end of lines - Don't use parens around if conditions -

[Mesa-dev] [PATCH 01/13] anv: anv_entrypoints_gen.py: use a main function

This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] glsl: fix use-after-free when processing array re-declarations

On 23/02/17 07:44, Ian Romanick wrote: I thought we already landed a different patch for this. I'll look through the archives when I get back in front of a computer... It looks like the patches are still waiting on a review: https://patchwork.freedesktop.org/series/19382/ On February

[Mesa-dev] [PATCH 1/2] haiku: build fixes around debug defines

From: Jerome Duval --- src/gallium/auxiliary/util/u_debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_debug.h b/src/gallium/auxiliary/util/u_debug.h index 7da7f53..63940b7 100644 ---

[Mesa-dev] [PATCH 2/2] haiku/winsys: fix dt prototype args

From: Jerome Duval --- src/gallium/winsys/sw/hgl/hgl_sw_winsys.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/sw/hgl/hgl_sw_winsys.c b/src/gallium/winsys/sw/hgl/hgl_sw_winsys.c index 89dd547..f7bc907 100644 ---

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-diskcache

Am Mittwoch, 22. Februar 2017, 22:27:42 CET schrieb Timothy Arceri: > On 23/02/17 01:57, Marc Dietrich wrote: > > Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov: > >> On 22 February 2017 at 13:31, Marc Dietrich wrote: > >>> Am Mittwoch, 22. Februar 2017,

Re: [Mesa-dev] [PATCH] anv/blorp/clear_subpass: Only set surface clear color for fast clears

This patch is also needed for MSAA compression. On Tue, Feb 21, 2017 at 7:31 PM, Jason Ekstrand wrote: > Not all clear colors are valid. In particular, on Broadwell and > earlier, only 0/1 colors are allowed in surface state. No CTS tests are > affected outright by this

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

On Wed, Feb 22, 2017 at 2:12 PM, Timothy Arceri wrote: > On 23/02/17 08:46, Matt Turner wrote: >> On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri >> wrote: >>> >>> For gpu generations that use LLVM we create a timestamp string >>> containing both the

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

On 23/02/17 08:46, Matt Turner wrote: On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri wrote: For gpu generations that use LLVM we create a timestamp string containing both the LLVM and Mesa build times, otherwise we just use the Mesa build time. Why not use the build

[Mesa-dev] [PATCH 1/2] st: add ST_FLUSH_WAIT to st_context_flush()

When st_context_flush() is called with ST_FLUSH_WAIT, the function will return after the fence is completed. --- src/gallium/include/state_tracker/st_api.h | 1 + src/mesa/state_tracker/st_manager.c| 7 +++ 2 files changed, 8 insertions(+) diff --git

[Mesa-dev] [PATCH 2/2] st/wgl: flush with ST_FLUSH_WAIT before releasing shared contexts

Before releasing a shared context, flush the context with ST_FLUSH_WAIT to make sure all commands are executed. This ensures that rendering to any shared resources is completed before they will be referenced by another context. Fixes an intermittent flickering with Photoshop. (VMware bug#

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri wrote: > For gpu generations that use LLVM we create a timestamp string > containing both the LLVM and Mesa build times, otherwise we just > use the Mesa build time. Why not use the build id for Mesa?

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

On 23/02/17 01:57, Marc Dietrich wrote: Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov: On 22 February 2017 at 13:31, Marc Dietrich wrote: Am Mittwoch, 22. Februar 2017, 04:45:46 CET schrieb Timothy Arceri: For gpu generations that use LLVM we create a

Re: [Mesa-dev] [PATCH 1/1] clover: Dump linked module to a different file

> On Feb 22, 2017, at 07:51, Jan Vesely wrote: > > This allows to pass the generated files directly to llc or bugpoint. > Note that if program links multiple binaries they will still be in the same > file, the module name is "link”. Can you add a counter ID or

Re: [Mesa-dev] [PATCH] vl: u_upload_alloc might fail to allocate buffer in bicubic filter

Pushed, thanks. Marek On Wed, Feb 22, 2017 at 9:20 PM, Nayan Deshmukh wrote: > Can you please push the patch. > > On Thu, Feb 23, 2017 at 1:46 AM, Marek Olšák wrote: >> OK sounds good. >> >> Reviewed-by: Marek Olšák >> >> Marek

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] glsl: fix use-after-free when processing array re-declarations

I thought we already landed a different patch for this. I'll look through the archives when I get back in front of a computer... On February 22, 2017 11:05:26 AM Nicolai Hähnle wrote: From: Nicolai Hähnle When determining whether the array is

Re: [Mesa-dev] [PATCH 4/4] mesa: Avoid out-of-bounds stack read via _mesa_Materiali

For 1, 3, 4: Reviewed-by: Marek Olšák I need some time to review patch 2 unless someone else beats me to it. Marek On Wed, Feb 22, 2017 at 8:04 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > MATERIALFV may end up

Re: [Mesa-dev] [PATCH 0/6] Removal of PIPE_CAP_USER_INDEX_BUFFERS (take 3)

On 02/22/2017 01:00 PM, Marek Olšák wrote: Hi, This version is hopefully final. I moved the helper code into a separate commit and fixed a pipe_resource leak there. (thanks Brian for the clue) The rest didn't really change. Please review, For the series, Reviewed-by: Brian Paul

  1   2   >