[Mesa-dev] [Bug 99959] egl-entrypoint-check fails

https://bugs.freedesktop.org/show_bug.cgi?id=99959 --- Comment #1 from Vinson Lee --- *** Bug 99960 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 99960] egl-entrypoint-check fails

https://bugs.freedesktop.org/show_bug.cgi?id=99960 Vinson Lee changed: What|Removed |Added Resolution|--- |DUPLICATE

[Mesa-dev] [Bug 99960] egl-entrypoint-check fails

https://bugs.freedesktop.org/show_bug.cgi?id=99960 Bug ID: 99960 Summary: egl-entrypoint-check fails Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords: bisected,

[Mesa-dev] [Bug 99959] egl-entrypoint-check fails

https://bugs.freedesktop.org/show_bug.cgi?id=99959 Bug ID: 99959 Summary: egl-entrypoint-check fails Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords: bisected,

Re: [Mesa-dev] [PATCH] glx/tests: Fix bash-specific code in dispatch-index-check

On Fri, Feb 24, 2017 at 8:03 PM, Aaron Watry wrote: > Using <<< for variable redirection is bash-specific behavior. > Ubuntu redirects sh -> dash, so this was erroring out. > > Also, the initial error that led me to this was that srcdir is null when > running make check > so I

[Mesa-dev] [Bug 99918] disk_cache.h:57:20: error: no member named 'st_mtim' in 'struct stat'

https://bugs.freedesktop.org/show_bug.cgi?id=99918 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] st/nine: Remove code for no USER_INDEX_BUFFERS as these are always on

On Fri, Feb 24, 2017 at 9:23 PM, Mike Lothian wrote: > This fixes 4a883966c1f74f43afc145d2c3d27af7b8c5e01a where the pipe cap > was removed > > Now USER_INDEX_BUFFERS are always enabled remove code that checks for > them and works around them not being available > >

[Mesa-dev] [PATCH] st/nine: Remove code for no USER_INDEX_BUFFERS as these are always on

This fixes 4a883966c1f74f43afc145d2c3d27af7b8c5e01a where the pipe cap was removed Now USER_INDEX_BUFFERS are always enabled remove code that checks for them and works around them not being available Signed-off-by: Mike Lothian Cc: Marek Olšák Cc: Axel

Re: [Mesa-dev] Mesa git: compilation error in NINE after your latest commit - 'PIPE_CAP_USER_INDEX_BUFFERS' undeclared

I've got a patch for this, just testing it now On Sat, 25 Feb 2017 at 00:10 Dieter Nützel wrote: > Making all in state_trackers/nine > make[4]: Entering directory '/opt/mesa/src/gallium/state_trackers/nine' >CC device9.lo > device9.c: In function

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for an on-disk shader cache

On 24/02/17 21:02, Marek Olšák wrote: On Fri, Feb 24, 2017 at 3:18 AM, Timothy Arceri wrote: On 24/02/17 08:49, Timothy Arceri wrote: On 24/02/17 05:12, Marek Olšák wrote: On Thu, Feb 23, 2017 at 3:09 AM, Timothy Arceri wrote: From:

[Mesa-dev] [PATCH] glx/tests: Fix bash-specific code in dispatch-index-check

Using <<< for variable redirection is bash-specific behavior. Ubuntu redirects sh -> dash, so this was erroring out. Also, the initial error that led me to this was that srcdir is null when running make check so I just copied something similar to what the optimization-test script does. ---

[Mesa-dev] [Bug 99319] godot engine poor performance

https://bugs.freedesktop.org/show_bug.cgi?id=99319 --- Comment #6 from i9i7s...@gmail.com --- Posting to say I have this problem on my RX 460. Mesa 17, I get good performance in other games but I get <10fps in the Godot platformer demo. Is there anything I can do to help test or debug this? --

[Mesa-dev] [AppVeyor] mesa master #3563 completed

Build mesa 3563 completed Commit fcf466383a by Brian Paul on 2/25/2017 2:02 AM: svga: fix MSVC build error after PIPE_CAP_USER_INDEX_BUFFERS removal\n\nNeed to specify the zero for the struct initializer. My earlier test\nof the patch series was with MinGW,

Re: [Mesa-dev] [PATCH] anv/image: Remove extra dependency on HiZ-specific variable

seems reasonable Reviewed-by: Jason Ekstrand On Wed, Feb 22, 2017 at 4:33 PM, Nanley Chery wrote: > Depth buffers aren't allowed to be used as storage images. > > Fixes: 055ff2ec521 ("anv: Replace anv_image_has_hiz() with > ISL_AUX_USAGE_HIZ") >

Re: [Mesa-dev] [PATCH 3/5] anv: automake: add TODO to the tarball

Why? On Thu, Feb 23, 2017 at 8:48 AM, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/intel/vulkan/Makefile.am | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[Mesa-dev] [Bug 99956] build_id.c:36:20: error: unknown type name 'Elf_Nhdr'

https://bugs.freedesktop.org/show_bug.cgi?id=99956 --- Comment #1 from Jonathan Gray --- Looking at the FreeBSD headers it appears they define Elf_Note not Elf_Nhdr. https://svnweb.freebsd.org/base/head/sys/sys/elf_common.h?revision=HEAD=co The OpenBSD headers define both at

[Mesa-dev] [Bug 99956] build_id.c:36:20: error: unknown type name 'Elf_Nhdr'

https://bugs.freedesktop.org/show_bug.cgi?id=99956 Bug ID: 99956 Summary: build_id.c:36:20: error: unknown type name 'Elf_Nhdr' Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: FreeBSD Status: NEW

Re: [Mesa-dev] [PATCH] doc: GL_ARB_buffer_storage is supported on llvmpipe/swr

Acked-by: Edward O'Callaghan On 02/25/2017 07:45 AM, Gregory Hainaut wrote: > At least, the extension is exported (gallium capability > PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT is 1) > > Signed-off-by: Gregory Hainaut > --- >

[Mesa-dev] [PATCH 1/2] util/build-id: Return a pointer rather than copying the data

We're about to use the build-id as the starting point for another SHA1 hash in the Intel Vulkan driver, and returning a pointer is far more convenient. --- src/intel/vulkan/anv_device.c | 2 +- src/util/build_id.c | 7 +++ src/util/build_id.h | 5 ++--- 3 files changed, 6

[Mesa-dev] [PATCH 2/2] anv: Add the pci_id into the shader cache UUID

This prevents a user from using a cache created on one hardware generation on a different one. Of course, with Intel hardware, this requires moving their drive from one machine to another but it's still possible and we should prevent it. --- src/intel/vulkan/anv_device.c | 20

[Mesa-dev] [Bug 99919] Wrong and unstable image rendering from GLSL fragment shaders

https://bugs.freedesktop.org/show_bug.cgi?id=99919 Grazvydas Ignotas changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

[Mesa-dev] Mesa git: compilation error in NINE after your latest commit - 'PIPE_CAP_USER_INDEX_BUFFERS' undeclared

Making all in state_trackers/nine make[4]: Entering directory '/opt/mesa/src/gallium/state_trackers/nine' CC device9.lo device9.c: In function 'NineDevice9_ctor': device9.c:122:49: error: 'PIPE_CAP_USER_INDEX_BUFFERS' undeclared (first use in this function) #define GET_PCAP(n)

Re: [Mesa-dev] [PATCH v3 6/8] nir: Add a simple int64 lowering pass

On Fri, Feb 24, 2017 at 3:58 PM, Matt Turner wrote: > On Fri, Feb 24, 2017 at 3:48 PM, Jason Ekstrand > wrote: > > The algorithms used by this pass, especially for division, are heavily > > based on the work Ian Romanick did for the similar int64

[Mesa-dev] [Bug 99953] device9.c:122:49: error: ‘PIPE_CAP_USER_INDEX_BUFFERS’ undeclared (first use in this function)

https://bugs.freedesktop.org/show_bug.cgi?id=99953 Bug ID: 99953 Summary: device9.c:122:49: error: ‘PIPE_CAP_USER_INDEX_BUFFERS’ undeclared (first use in this function) Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH v3 6/8] nir: Add a simple int64 lowering pass

On Fri, Feb 24, 2017 at 3:48 PM, Jason Ekstrand wrote: > The algorithms used by this pass, especially for division, are heavily > based on the work Ian Romanick did for the similar int64 lowering pass > in the GLSL compiler. > > v2: Properly handle vectors > > v3: Get rid of

[Mesa-dev] [PATCH v3 6/8] nir: Add a simple int64 lowering pass

The algorithms used by this pass, especially for division, are heavily based on the work Ian Romanick did for the similar int64 lowering pass in the GLSL compiler. v2: Properly handle vectors v3: Get rid of log2_denom stuff. Since we're using bcsel, we do all the calculations anyway and

[Mesa-dev] [PATCH] glsl/int64: Fix a typo in imod64

The zy swizzle gives us one component of quotient and one component of remainder. What we wanted was zw for the remainder. Cc: Ian Romanick --- src/compiler/glsl/builtin_int64.h | 22 -- src/compiler/glsl/int64.glsl | 2 +- 2 files changed, 9

Re: [Mesa-dev] [PATCH] radv/ac: enable loop unrolling.

> On Feb 24, 2017, at 14:39, Marek Olšák wrote: > > On Fri, Feb 24, 2017 at 7:20 PM, Matt Arsenault wrote: >> >> On Feb 24, 2017, at 01:45, Marek Olšák wrote: >> >> The main requirement is that if there is indirect indexing inside a >>

[Mesa-dev] [AppVeyor] mesa master #3559 failed

Build mesa 3559 failed Commit c7878b0167 by Marek Olšák on 2/23/2017 12:34 AM: ac: silence a warning\n\ntrivial Configure your notification preferences ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] radv/ac: enable loop unrolling.

On Fri, Feb 24, 2017 at 7:20 PM, Matt Arsenault wrote: > > On Feb 24, 2017, at 01:45, Marek Olšák wrote: > > The main requirement is that if there is indirect indexing inside a > loop, we always want to unroll the whole loop to get rid of the > indexing,

Re: [Mesa-dev] [PATCH 2/2] glsl: use is_sampler() anywhere it's possible

Series is: Reviewed-by: Timothy Arceri On 25/02/17 00:40, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ast_to_hir.cpp| 22 +++--- src/compiler/glsl/ir.cpp

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

On Fri, Feb 24, 2017 at 8:33 AM, tournier.elie wrote: > Ping. > > > On 13 February 2017 at 10:17, tournier.elie > wrote: > >> Whoops I answer 2 times. >> >> Would the comment bellow be appropriate? >> >> This limit is chosen fairly arbitrarily.

Re: [Mesa-dev] [PATCH 1/8] nir/builder: Add support for easily building control-flow

On Fri, Feb 24, 2017 at 6:05 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > > > On 24/02/17 02:14, Jason Ekstrand wrote: > > Each of the pop functions (and push_else) take a control flow parameter > as > > their second argument. If NULL, it assumes that the builder is in a >

Re: [Mesa-dev] [PATCH 0/8] anv: Add int64 support for gen8+

On Thu, Feb 23, 2017 at 11:08 PM, Michael Schellenberger Costa < mschellenbergerco...@googlemail.com> wrote: > Hi Jason, > > how much of a noob task would the expansion to other operations be? > It shouldn't be too bad. Last night, I cracked out a bunch more lowering helpers. I haven't tested

[Mesa-dev] [PATCH] doc: GL_ARB_buffer_storage is supported on llvmpipe/swr

At least, the extension is exported (gallium capability PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT is 1) Signed-off-by: Gregory Hainaut --- docs/features.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index

[Mesa-dev] [Bug 99919] Wrong and unstable image rendering from GLSL fragment shaders

https://bugs.freedesktop.org/show_bug.cgi?id=99919 --- Comment #4 from Ilia Mirkin --- As an aside, for gallium-based drivers this seems to generate a checkerboard. (Tested with at least llvmpipe and softpipe.) Both the original and the variant. -- You are receiving this

[Mesa-dev] [Bug 99919] Wrong and unstable image rendering from GLSL fragment shaders

https://bugs.freedesktop.org/show_bug.cgi?id=99919 Lars Hamre changed: What|Removed |Added CC||cheme...@gmail.com --

[Mesa-dev] [Bug 99919] Wrong and unstable image rendering from GLSL fragment shaders

https://bugs.freedesktop.org/show_bug.cgi?id=99919 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added CC|

[Mesa-dev] [Bug 99919] Wrong and unstable image rendering from GLSL fragment shaders

https://bugs.freedesktop.org/show_bug.cgi?id=99919 Matt Turner changed: What|Removed |Added CC||matts...@gmail.com

[Mesa-dev] [Bug 99919] Wrong and unstable image rendering from GLSL fragment shaders

https://bugs.freedesktop.org/show_bug.cgi?id=99919 --- Comment #2 from Ilia Mirkin --- Created attachment 129905 --> https://bugs.freedesktop.org/attachment.cgi?id=129905=edit apitrace of variant shader For convenience, attaching a trace of the variant. Very surprising

Re: [Mesa-dev] [PATCH 0/4] glsl/tests: completely broken or strange design ?

Quoting Emil Velikov (2017-02-23 08:43:06) > Hi all, > > As some of you may know we have a bunch of interesting tests in glsl. > > A bit earlier I've spotted that they are competely broken, as they would > happily return "success" even when 0 tests were generated. > > As an example I will take

[Mesa-dev] [PATCH v2 1/1] clover: Dump linked binary to a different file

this allows to pass the generated files directly to llc or bugpoint v2: add atomic counter ID Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v3 10/15] anv: anv-entrypoints_gen.py: rename hash to cal_hash.

hash is reserved name in python, it's the interface to access an object's hash protocol. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v3 12/15] anv: use dict.get in anv_entrypoints_gen.py

Instead of using an if and a check, use dict.get, which does the same thing, but more succinctly. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH v3 14/15] anv: use cElementTree in anv_entrypoints_gen.py

It's written in C rather than pure python and is strictly faster, the only reason not to use it that it's classes cannot be subclassed. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH v3 13/15] anv: don't use Element.get in anv_entrypoints_gen.py

This has the potential to mask errors, since Element.get works like dict.get, returning None if the element isn't found. I think the reason that Element.get was used is that vulkan has one extension that isn't really an extension, and thus is missing the 'protect' field. This patch changes the

[Mesa-dev] [PATCH v3 05/15] anv: split main into two functions in anv_entrypoints_gen.py

This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 108 - 1 file

[Mesa-dev] [PATCH v3 06/15] anv: Update "do not edit" comments with proper filename

This does two things, first it updates both the .h and the .c file to have the same do not edit string. Second, it uses __file__ to ensure that even if the file is moved or renamed that the name will be correct. One thing to note is the use of '{{' and '}}' in the C template. This is to instruct

[Mesa-dev] [PATCH v3 07/15] anv: convert header generation in anv_entrypoints_gen.py to mako

This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 77 ++ 1 file changed, 42 insertions(+), 35 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH v3 08/15] anv: convert C generation to template in anv_entrypoints_gen.py

This produces a file that is identical except for whitespace, there is a table that has 8 columns in the original and is easy to do with prints, but is ugly using mako, so it doesn't have columns; the data is not inherently tabular. Signed-off-by: Dylan Baker ---

[Mesa-dev] [PATCH v3 11/15] anv: anv_entrypoints_gen.py: use reduce function.

Reduce is it's own reward. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index

[Mesa-dev] [PATCH v3 09/15] anv: anv_entrypoints_gen.py: directly write files instead of piping

This changes the output to be written as a file rather than being piped. This had one critical advantage, it encapsulates the encoding. This prevents bugs where a symbol (generally unicode like ?? [copyright]) is printed and the system being built on doesn't have a unicode locale. v2: - Update

[Mesa-dev] [PATCH v3 00/15] cleanup anv_entrpoints_gen.py

There are a number of small style cleanups and simplifications in this series, but the main changes are: - use a mako template to generate the header and code rather than prints - be python 3.x ready (the goal isn't to write python 3 code, but to write code that is easy to port or hybridize)

[Mesa-dev] [PATCH v3 15/15] anv: Remove dead prototype from entrypoints

Spotted by Emil. v2: - Add this patch Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 72d8c17..ecdff13

[Mesa-dev] [PATCH v3 01/15] anv: anv_entrypoints_gen.py: use a main function

This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 - 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH v3 03/15] anv: make constants capitals in anv_entrypoints_gen.py

Again, it's standard python style. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 38 +- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH v3 04/15] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

It's slow, and has the potential for encoding issues. v2: - pass xml file location via argument - update Android.mk Signed-off-by: Dylan Baker --- src/intel/vulkan/Android.mk | 4 ++-- src/intel/vulkan/Makefile.am| 6 ++

[Mesa-dev] [PATCH v3 02/15] anv: Use python style in anv_entrypoints_gen.py

These are all fairly small cleanups/tweaks that don't really deserve their own patch. - Prefer comprehensions to map() and filter(), since they're faster - replace unused variables with _ - Use 4 spaces of indent - drop semicolons from the end of lines - Don't use parens around if conditions -

Re: [Mesa-dev] [PATCH] radv/ac: enable loop unrolling.

> On Feb 24, 2017, at 01:45, Marek Olšák wrote: > > The main requirement is that if there is indirect indexing inside a > loop, we always want to unroll the whole loop to get rid of the > indexing, which can decrease scratch usage. > > Marek We boost the unroll thresholds

Re: [Mesa-dev] X test suite regression due to gallivm change

On Fri, Feb 24, 2017 at 12:32 PM, Jose Fonseca wrote: > On 23/02/17 21:54, Adam Jackson wrote: >> >> On Thu, 2017-02-23 at 21:59 +0100, Roland Scheidegger wrote: >> >>> So, what does the failing test do? >> >> >> Not much, curiously. There are five that fail and they're all

Re: [Mesa-dev] X test suite regression due to gallivm change

On 23/02/17 21:54, Adam Jackson wrote: On Thu, 2017-02-23 at 21:59 +0100, Roland Scheidegger wrote: So, what does the failing test do? Not much, curiously. There are five that fail and they're all fairly trivial, although the xts harness makes that hard to see. XClearArea/6 and

Re: [Mesa-dev] [PATCH 1/5] util/sha1: add non-typedef name for the SHA1_CTX struct

Humble ping anyone ? -Emil On 24 January 2017 at 21:21, Emil Velikov wrote: > From: Emil Velikov > > Using typedef(s) is not always the answer and makes it harder for people > to do clever (or one might call nasty) things with the code. > >

Re: [Mesa-dev] [PATCH] util/disk_cache: Use backward compatible st_mtime.

On 23.02.2017 23:29, Vinson Lee wrote: Fix Mac OS X build error. CC libmesautil_la-disk_cache.lo In file included from disk_cache.c:46: ./disk_cache.h:57:20: error: no member named 'st_mtim' in 'struct stat' *timestamp = st.st_mtim.tv_sec; ~~ ^ Bugzilla:

Re: [Mesa-dev] [PATCH mesa v2] glx: add GLXdispatchIndex sort check

On Friday, 2017-02-24 16:46:36 +, Emil Velikov wrote: > On 24 February 2017 at 14:58, Eric Engestrom > wrote: > > On Thursday, 2017-02-23 16:07:36 +, Emil Velikov wrote: > >> You're a star Eric, thank you ! > >> > >> On 22 February 2017 at 11:24, Eric Engestrom

Re: [Mesa-dev] [PATCH 4/4] glsl/tests/optimization-test: correctly manage srcdir/pwd and co

On 24 February 2017 at 16:13, Eric Engestrom wrote: > On Thursday, 2017-02-23 16:43:10 +, Emil Velikov wrote: >> From: Emil Velikov >> >> At the moment things are completely bonkers (as can be seen from last >> commit). Regardless if we

Re: [Mesa-dev] [PATCH 1/4] glsl/tests/optimisation-test: make sure that $PYTHON2 is set/available

On 24 February 2017 at 15:34, Eric Engestrom wrote: > On Thursday, 2017-02-23 16:43:07 +, Emil Velikov wrote: >> From: Emil Velikov >> >> Otherwise we'll fail when invoking the script outside of "make check" >> >> Signed-off-by: Emil

Re: [Mesa-dev] [PATCH 3/4] glsl/tests/optimization-test: error out if we fail to generate any tests

On 24 February 2017 at 15:58, Eric Engestrom wrote: > On Thursday, 2017-02-23 16:43:09 +, Emil Velikov wrote: >> From: Emil Velikov >> >> Signed-off-by: Emil Velikov >> --- >>

Re: [Mesa-dev] [PATCH 2/4] glsl/tests/optimisation-test: ensure that compare_ir is available

On 24 February 2017 at 15:42, Eric Engestrom wrote: > On Thursday, 2017-02-23 16:43:08 +, Emil Velikov wrote: >> From: Emil Velikov >> >> Bail out early if the script is not where we expect it to be. >> >> Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH mesa v2] glx: add GLXdispatchIndex sort check

On 24 February 2017 at 14:58, Eric Engestrom wrote: > On Thursday, 2017-02-23 16:07:36 +, Emil Velikov wrote: >> You're a star Eric, thank you ! >> >> On 22 February 2017 at 11:24, Eric Engestrom >> wrote: >> > Signed-off-by: Eric

[Mesa-dev] [PATCH] mesa: Fix performance query id check

In queryid_valid() index is unsigned so checking if it is less than zero is useless. On queryid_to_index() is comment saying 0 is reserved to be invalid thus rule it out. This is a v2 of a fix for an issue identified by Juha-Pekka (thanks) and the commit message is gratuitously stolen. Cc:

Re: [Mesa-dev] [PATCH v2 6/14] anv: convert header generation in anv_entrypoints_gen.py to mako

Quoting Emil Velikov (2017-02-24 05:57:24) > On 24 February 2017 at 10:28, Eric Engestrom > wrote: > > On Thursday, 2017-02-23 10:46:19 -0800, Dylan Baker wrote: > >> This produces an identical file except for whitespace. > >> > >> Signed-off-by: Dylan Baker

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

Ping. On 13 February 2017 at 10:17, tournier.elie wrote: > Whoops I answer 2 times. > > Would the comment bellow be appropriate? > > This limit is chosen fairly arbitrarily. > GLSL IR max iteration is 32 instructions. (Multiply counting nodes and > magic number 5). >

Re: [Mesa-dev] pfn_notify in clCreateContext()

I'd like to point out that when I hooked up this logic in clover (after my triumphant addition of KHR_debug in gallium), I had no idea how OpenCL stuff worked. I still don't. If you think passing this type of information is inappropriate, or that some of the message types should be filtered out,

Re: [Mesa-dev] Mesa: Fix performance query id check

Ah, oops, I think the id types iterated a few times over the lifetime of the original patch. E.g. until pretty much the last moment before landing it pass a signed int id to the backend. I suppose it can be return queryid != 0 && queryid_to_index(queryid) < numQueries I'll also look to update

Re: [Mesa-dev] [PATCH 4/4] glsl/tests/optimization-test: correctly manage srcdir/pwd and co

On Thursday, 2017-02-23 16:43:10 +, Emil Velikov wrote: > From: Emil Velikov > > At the moment things are completely bonkers (as can be seen from last > commit). Regardless if we run the test as part of "make check" or > standalone the most of the paths are wrong.

Re: [Mesa-dev] [PATCH] configure.ac: check require_basic_egl only if egl enabled

On 02/24/2017 10:56 AM, Emil Velikov wrote: On 24 February 2017 at 14:25, Leo Liu wrote: On 02/24/2017 09:07 AM, Emil Velikov wrote: On 23 February 2017 at 18:43, Leo Liu wrote: Otherwise the configuration fails when building independant libs like vdpau,

[Mesa-dev] pfn_notify in clCreateContext()

Hello, I noticed that Clover outputs si_shader_dump_stats() via pfn_notify callback registered clCreateContext() (it's not done directly, but that's the result). According to OpenCL standard documentation [1], pfn_notify should be used only to report errors. One of the programs that gets

Re: [Mesa-dev] [PATCH 3/4] glsl/tests/optimization-test: error out if we fail to generate any tests

On Thursday, 2017-02-23 16:43:09 +, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/compiler/glsl/tests/optimization-test | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH] configure.ac: check require_basic_egl only if egl enabled

On 24 February 2017 at 14:25, Leo Liu wrote: > On 02/24/2017 09:07 AM, Emil Velikov wrote: >> >> On 23 February 2017 at 18:43, Leo Liu wrote: >>> >>> Otherwise the configuration fails when building independant libs >>> like vdpau, vaapi or omx >>> >> I really

Re: [Mesa-dev] [PATCH mesa] egl/dri3: implement query surface hook

Hi, On 20/02/17 07:57, Tapani Pälli wrote: Hi; On 02/17/2017 05:12 PM, Eric Engestrom wrote: From: Brendan King This is a DRI3 version of a change made for DRI2 (4d6d4f939e0af4252e0b, "egl/dri2: implement query surface hook"), that fixed failures in

Re: [Mesa-dev] [PATCH 2/4] glsl/tests/optimisation-test: ensure that compare_ir is available

On Thursday, 2017-02-23 16:43:08 +, Emil Velikov wrote: > From: Emil Velikov > > Bail out early if the script is not where we expect it to be. > > Signed-off-by: Emil Velikov > --- > src/compiler/glsl/tests/optimization-test | 5

Re: [Mesa-dev] [PATCH 1/4] glsl/tests/optimisation-test: make sure that $PYTHON2 is set/available

On Thursday, 2017-02-23 16:43:07 +, Emil Velikov wrote: > From: Emil Velikov > > Otherwise we'll fail when invoking the script outside of "make check" > > Signed-off-by: Emil Velikov > --- > src/compiler/glsl/tests/optimization-test

Re: [Mesa-dev] [PATCH 2/2] anv: do not subtract the base layer to copute depth in 3DSTATE_DEPTH_BUFFER

On Feb 23, 2017 11:40 PM, "Iago Toral Quiroga" wrote: According to the PRM description of the Depth field: "This field specifies the total number of levels for a volume texture or the number of array elements allowed to be accessed starting at the Minimum Array

Re: [Mesa-dev] [PATCH 37/37] bin/get-fixes-pick-list.sh: do not mandate bash

Reviewed-by: Andreas Boll I'll let someone else review the python changes. 2017-02-23 18:14 GMT+01:00 Emil Velikov : > From: Emil Velikov > > Silly thinko on my end, as I was writing the script. There is nothing

Re: [Mesa-dev] [PATCH 36/37] in/shortlog_mesa.sh: remove the final bashism

Typo in commit summary (in/ -> bin/) with that fixed: Reviewed-by: Andreas Boll 2017-02-23 18:14 GMT+01:00 Emil Velikov : > From: Emil Velikov > > Remove the typeset built-in and toggle to /bin/sh > >

Re: [Mesa-dev] [PATCH 35/37] bin/bugzilla_mesa.sh: rework the looping method

2017-02-23 18:14 GMT+01:00 Emil Velikov : > From: Emil Velikov > > We don't use DRYRUN (and no others scripts have one) so just drop it. > > This allows us to rework the loop to the more commonly used "git | > while read foo; do ... done"

Re: [Mesa-dev] [PATCH 34/37] wayland-egl/wayland-egl-symbols-check: do not mandate bash

Reviewed-by: Andreas Boll 2017-02-23 18:14 GMT+01:00 Emil Velikov : > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/egl/wayland/wayland-egl/wayland-egl-symbols-check

Re: [Mesa-dev] [PATCH 33/37] gbm/gbm-symbols-check: do not mandate bash

Reviewed-by: Andreas Boll 2017-02-23 18:14 GMT+01:00 Emil Velikov : > From: Emil Velikov > > Analogous to previous commit. > > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH 32/37] egl/egl-symbols-check: do not mandate bash

Reviewed-by: Andreas Boll 2017-02-23 18:13 GMT+01:00 Emil Velikov : > From: Emil Velikov > > There's nothing bash specific in the script. > > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH 31/37] glsl/tests: remove any bashisms

Reviewed-by: Andreas Boll 2017-02-23 18:13 GMT+01:00 Emil Velikov : > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/compiler/glsl/tests/optimization-test.sh | 4 ++--

Re: [Mesa-dev] [PATCH 30/37] dri: use correct shebang for gen-symbol-redefs.py

Reviewed-by: Andreas Boll 2017-02-23 18:13 GMT+01:00 Emil Velikov : > From: Emil Velikov > > This is a python2 script and the generic "python" may point to python3. > > Cc: Andreas Boll

Re: [Mesa-dev] [PATCH 23/37] gallium/tools: do not hardcode bash location

Reviewed-by: Andreas Boll 2017-02-23 18:13 GMT+01:00 Emil Velikov : > It is not guaranteed to be in /bin > > Signed-off-by: Emil Velikov > --- > src/gallium/tools/addr2line.sh | 2 +- >

Re: [Mesa-dev] [PATCH mesa v2] glx: add GLXdispatchIndex sort check

On Thursday, 2017-02-23 16:07:36 +, Emil Velikov wrote: > You're a star Eric, thank you ! > > On 22 February 2017 at 11:24, Eric Engestrom > wrote: > > Signed-off-by: Eric Engestrom > > --- > > v2: make sure the list is in the order C's

Re: [Mesa-dev] [PATCH 20/37] mapi: do not mandate bash for es*api/ABI-check

Reviewed-by: Andreas Boll 2017-02-23 18:13 GMT+01:00 Emil Velikov : > From: Emil Velikov > > Seemingly there is nothing bash specific in these. The Debian > checkbashisms does not spot neither run in zsh. > >

Re: [Mesa-dev] [PATCH 03/37] mesa: drop the execute bit from gl.xml

Reviewed-by: Andreas Boll 2017-02-23 18:13 GMT+01:00 Emil Velikov : > This is a spec file which is parsed by scripts. > > Signed-off-by: Emil Velikov > --- > src/mapi/glapi/registry/gl.xml | 0 > 1 file changed,

Re: [Mesa-dev] [PATCH 5/8] i965: Add script to gen code for OA counter queries

Hi Robert, There's a few minor comments below. Feel free to address here or as follow-up, if applicable. On 24 February 2017 at 13:58, Robert Bragg wrote: > Avoiding lots of error prone boilerplate and easing our ability to add + > maintain support for multiple OA

[Mesa-dev] Putbits patches

Hi, Christian! Are you OK with the updated Putbits patches? https://lists.freedesktop.org/archives/mesa-dev/2017-February/145269.html https://lists.freedesktop.org/archives/mesa-dev/2017-February/145258.html Thanks, Thomas ___ mesa-dev mailing

Re: [Mesa-dev] Putbits patches

Am 24.02.2017 um 15:40 schrieb Thomas Hellstrom: Hi, Christian! Are you OK with the updated Putbits patches? https://lists.freedesktop.org/archives/mesa-dev/2017-February/145269.html https://lists.freedesktop.org/archives/mesa-dev/2017-February/145258.html Sorry the second patch never made

Re: [Mesa-dev] [PATCH 1/2] st/vdpau: Provide YV12 to NV12 putBits conversion v2

Am 22.02.2017 um 16:25 schrieb Thomas Hellstrom: mplayer likes putting YV12 data, and if there is a buffer format mismatch, the vdpau state tracker would try to reallocate the video surface as an YV12 surface. A virtual driver doesn't like reallocating and doesn't like YV12 surfaces, so if we

Re: [Mesa-dev] [PATCH v2 8/14] anv: generate anv_entrypoints.{h, c} in one command

On 24 February 2017 at 11:10, Eric Engestrom wrote: > On Thursday, 2017-02-23 10:46:21 -0800, Dylan Baker wrote: >> This changes the python generator to write the files itself, rather than >> piping them out. This has a couple of advantages: first, it encapsulates >>

  1   2   >