[Mesa-dev] [PATCH v2 2/5] anv/descriptor_set: Use anv_multialloc for descriptor set layouts

2017-04-06 Thread Jason Ekstrand
--- src/intel/vulkan/anv_descriptor_set.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index 56a08ce..6f2280d 100644 --- a/src/intel/vulkan/anv_descriptor_set.c +++

[Mesa-dev] [PATCH v2 1/5] anv: Add a helper for doing mass allocations

2017-04-06 Thread Jason Ekstrand
We tend to try to reduce the number of allocation calls the Vulkan driver uses by doing a single allocation whenever possible for a data structure. While this has certain downsides (usually code complexity), it does mean error handling and cleanup is much easier. This commit adds a nice little

[Mesa-dev] [PATCH v2 4/5] anv/pass: Record required pipe flushes

2017-04-06 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pass.c| 88 ++ src/intel/vulkan/anv_private.h | 2 + 2 files changed, 90 insertions(+) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 65c349a..9b43b01 100644 --- a/src/intel/vulkan/anv_pass.c +++

[Mesa-dev] [PATCH v2 3/5] anv/pass: Use anv_multialloc for allocating the anv_pass

2017-04-06 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pass.c| 107 + src/intel/vulkan/anv_private.h | 1 - 2 files changed, 45 insertions(+), 63 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 4a1a340..65c349a 100644 ---

[Mesa-dev] [PATCH v2 5/5] anv: Use subpass dependencies for flushes

2017-04-06 Thread Jason Ekstrand
Instead of figuring it all out ourselves, just use the information given to us by the client. --- src/intel/vulkan/anv_blorp.c | 88 -- src/intel/vulkan/genX_cmd_buffer.c | 10 + 2 files changed, 18 insertions(+), 80 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] gbm: Assert modifiers and count are copacetic

2017-04-06 Thread Jason Ekstrand
Seems reasonable Reviewed-by: Jason Ekstrand On Thu, Apr 6, 2017 at 8:56 PM, Ben Widawsky wrote: > The API/entry point in mesa already checks the correct behavior, > however, it's possible to be handled by another implementation and those >

[Mesa-dev] [PATCH] Adding support for EXT_sRGB for Opengl ES

2017-04-06 Thread Harish Krupo
This addes support for the GL_EXT_sRGB extension for OpengGL ES 1.0 and above. With this patch this test passes in dEQP: dEQP-GLES2.capability.extensions.uncompressed_texture_formats.GL_EXT_sRGB Signed-off-by: Harish Krupo --- src/mapi/glapi/gen/es_EXT.xml

[Mesa-dev] [PATCH] gbm: Assert modifiers and count are copacetic

2017-04-06 Thread Ben Widawsky
The API/entry point in mesa already checks the correct behavior, however, it's possible to be handled by another implementation and those implementations should not be able to abuse a weird combination of count and pointer. This fixes CID 1403193 Cc: Mark Janes

[Mesa-dev] [PATCH] anv/query: Use snooping on !LLC platforms

2017-04-06 Thread Jason Ekstrand
Commit b2c97bc789198427043cd902bc76e194e7e81c7d which made us start using a busy-wait for individual query results also messed up cache flushing on !LLC platforms. For one thing, I forgot the mfence after the clflush so memory access wasn't properly getting fenced. More importantly, however, was

[Mesa-dev] [Bug 100303] Adding a single, meaningless if-else to a shader source leads to different image

2017-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100303 --- Comment #7 from Timothy Arceri --- Fix sent to the list: https://patchwork.freedesktop.org/patch/148970/ -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [PATCH] glsl: fix lower jumps for nested non-void returns

2017-04-06 Thread Timothy Arceri
Fixes the case were a loop contains a return and the loop is nested inside an if. https://bugs.freedesktop.org/show_bug.cgi?id=100303 --- src/compiler/glsl/lower_jumps.cpp| 6 ++ src/compiler/glsl/tests/lower_jumps/create_test_cases.py | 5 - 2 files changed, 10

Re: [Mesa-dev] [PATCH 2/2] egl, dri: Propagate context priority hint to driver->CreateContext

2017-04-06 Thread Rob Clark
On Thu, Apr 6, 2017 at 3:12 PM, Chris Wilson wrote: > Jump through the layers of abstraction between egl and dri in order to > feed the context priority attribute through to the backend. This > requires us to read the value from the base _egl_context, convert it to > a

[Mesa-dev] [PATCH] swr: fix unused variable warnings

2017-04-06 Thread Tim Rowley
--- src/gallium/drivers/swr/swr_screen.cpp | 1 - src/gallium/drivers/swr/swr_shader.cpp | 1 - 2 files changed, 2 deletions(-) diff --git a/src/gallium/drivers/swr/swr_screen.cpp b/src/gallium/drivers/swr/swr_screen.cpp index 0a5060b..d737ddf 100644 --- a/src/gallium/drivers/swr/swr_screen.cpp

Re: [Mesa-dev] [PATCH 4/4] anv: Use subpass dependencies for flushes

2017-04-06 Thread Nanley Chery
On Thu, Apr 06, 2017 at 11:48:04AM -0700, Jason Ekstrand wrote: > On Thu, Mar 30, 2017 at 2:06 PM, Nanley Chery wrote: > > > On Tue, Mar 14, 2017 at 07:55:53AM -0700, Jason Ekstrand wrote: > > > Instead of figuring it all out ourselves, just use the information given > > >

Re: [Mesa-dev] [PATCH v2 3/4] anv/pass: Record required pipe flushes

2017-04-06 Thread Nanley Chery
On Thu, Apr 06, 2017 at 11:46:17AM -0700, Jason Ekstrand wrote: > On Thu, Mar 30, 2017 at 1:59 PM, Nanley Chery wrote: > > > On Wed, Mar 15, 2017 at 12:01:16PM -0700, Jason Ekstrand wrote: > > > --- > > > src/intel/vulkan/anv_pass.c| 89 ++

Re: [Mesa-dev] [PATCH 40/53] i965/drm: Rewrite relocation handling.

2017-04-06 Thread Kenneth Graunke
On Thursday, April 6, 2017 3:52:06 AM PDT Chris Wilson wrote: > On Wed, Apr 05, 2017 at 04:56:42PM -0700, Kenneth Graunke wrote: > > On Wednesday, April 5, 2017 4:46:27 AM PDT Chris Wilson wrote: > > > On Tue, Apr 04, 2017 at 05:10:30PM -0700, Kenneth Graunke wrote: [snip] > > > > +

Re: [Mesa-dev] [PATCH] mesa: tidy up renderbuffer RefCount initialisation

2017-04-06 Thread Timothy Arceri
On 07/04/17 05:10, Bartosz Tomczyk wrote: Timothy, I observe huge memory leak after this commit: Hi, Thanks for reporting. This patch should fix the problem: https://patchwork.freedesktop.org/patch/148926/ Direct leak of 648208 byte(s) in 3683 object(s) allocated from: #0

[Mesa-dev] [PATCH] mesa: fix renderbuffer leak

2017-04-06 Thread Timothy Arceri
We don't need to call _mesa_reference_renderbuffer() for the first assignment as refCount starts at 1. For swrast we work around the fact we will indirectly call _mesa_reference_renderbuffer() by resetting refCount to 0. Fixes: 32141e53d1520 (mesa: tidy up renderbuffer RefCount initialisation)

[Mesa-dev] [Bug 99618] AVX Intrinsics Run in GUI thread only

2017-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99618 --- Comment #3 from Bruce Cherniak --- Any chance you've been able to try the suggestion I made (KNOB_MAX_WORKER_THREADS) to resolve this issue? -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 100151] Front buffer drawing mode shows black window with gallium software rasterizers

2017-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100151 --- Comment #7 from Bruce Cherniak --- It was commented that this works for llvmpipe on 17.0 (17.0-branchpoint-1291-gb19caec). I tried it on mesa-master with swr and it appears to work. We haven't had a chance to go

Re: [Mesa-dev] [PATCH 0/4] GLSL passes begone

2017-04-06 Thread Matt Turner
On Thu, Apr 6, 2017 at 12:49 PM, Thomas Helland wrote: > This series has been reciding on my computer for way to long, > so it's about time I get it out there for some feedback. > The rationale is that in the glsl compiler a lot of the overhead > is in cache misses due

Re: [Mesa-dev] [PATCH] egl/wayland: allow building with Wayland 1.10

2017-04-06 Thread Brian Paul
On 04/06/2017 01:51 PM, Daniel Stone wrote: Hi Brian, On 6 April 2017 at 20:17, Daniel Stone wrote: On 6 April 2017 at 19:49, Brian Paul wrote: Fedora 24 only has Wayland 1.10, not 1.11. This change lets us build Mesa/EGL with Wayland 1.10 on that

[Mesa-dev] [PATCH 1/2] intel/aubinator_error_decode: Avoid printing long ascii85 lines

2017-04-06 Thread Jordan Justen
Since '---' can exist within an ascii85 encoded string, we should avoid these strings when looking for header lines in the error state file. One of the things we do inside the 'if (dashes) {' block is to print the entire line. Since these the ascii85 lines are extremely long it makes it difficult

[Mesa-dev] [PATCH 2/2] intel/aubinator_error_decode: Avoid exit when using a pager

2017-04-06 Thread Jordan Justen
I have an error state which includes an ascii85 section that fails to decode. If we exit early when using a pager, it confuses the terminal. Signed-off-by: Jordan Justen --- src/intel/tools/aubinator_error_decode.c | 16 1 file changed, 12

Re: [Mesa-dev] [PATCH 1/2] egl: Support IMG_context_priority

2017-04-06 Thread Ben Widawsky
On 17-04-06 20:12:35, Chris Wilson wrote: IMG_context_priority https://www.khronos.org/registry/egl/extensions/IMG/EGL_IMG_context_priority.txt "This extension allows an EGLContext to be created with a priority hint. It is possible that an implementation will not honour the hint,

Re: [Mesa-dev] [PATCH] egl/wayland: allow building with Wayland 1.10

2017-04-06 Thread Daniel Stone
Hi Brian, On 6 April 2017 at 20:17, Daniel Stone wrote: > On 6 April 2017 at 19:49, Brian Paul wrote: >> Fedora 24 only has Wayland 1.10, not 1.11. This change lets us build >> Mesa/EGL >> with Wayland 1.10 on that distro. >> >> A new wayland-compat.h

[Mesa-dev] [PATCH 1/4] glsl: Merge opt_noop_swizzle, and opt_swizzle_swizzle

2017-04-06 Thread Thomas Helland
The pass to optimize two swizzles in a row can be interpreted as a noop swizzle optimization. Merge the two passes, and avoid having the extra pass that runs a visitor pattern. --- src/compiler/Makefile.sources | 1 - src/compiler/glsl/glsl_parser_extras.cpp | 1 -

[Mesa-dev] [PATCH 0/4] GLSL passes begone

2017-04-06 Thread Thomas Helland
This series has been reciding on my computer for way to long, so it's about time I get it out there for some feedback. The rationale is that in the glsl compiler a lot of the overhead is in cache misses due to the visitor pattern we're running. This is run on my intel machine. Here are some perf

[Mesa-dev] [PATCH 3/4] glsl: Merge if-simplification and conditional discard optimization

2017-04-06 Thread Thomas Helland
The conditional discard pass follows the same pattern, so merge the two, and avoid running the visitor two times. --- src/compiler/Makefile.sources | 1 - src/compiler/glsl/glsl_parser_extras.cpp | 1 - src/compiler/glsl/ir_optimization.h | 1 -

[Mesa-dev] [PATCH 4/4] glsl: Fold constant folding of assignments into constant propagation

2017-04-06 Thread Thomas Helland
We are already calling constant folding functions in our constant propagation pass. So there is no point in also running a separate constant folding pass. Port over the remaining functionality from constant folding, and delete the pass. --- src/compiler/Makefile.sources | 1

[Mesa-dev] [PATCH 2/4] glsl: Merge if_simplification and nested-if-flattening

2017-04-06 Thread Thomas Helland
Flattening of nested if blocks is a form of if-simplification. Also, it shares the same visitor pattern, and we can possibly simplify an if statement further while we are at it. So if we merge them we get multiple benefits. --- src/compiler/Makefile.sources | 1 -

Re: [Mesa-dev] [PATCH] svga: remove pre-SVGA3D_HWVERSION_WS8_B1 code

2017-04-06 Thread Charmaine Lee
Looks good to me. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, April 6, 2017 11:49 AM To: mesa-dev@lists.freedesktop.org Cc: Jose Fonseca; Charmaine Lee; Neha Bhende Subject: [PATCH] svga: remove

Re: [Mesa-dev] [PATCH] egl/wayland: allow building with Wayland 1.10

2017-04-06 Thread Daniel Stone
Hi Brian, On 6 April 2017 at 19:49, Brian Paul wrote: > Fedora 24 only has Wayland 1.10, not 1.11. This change lets us build Mesa/EGL > with Wayland 1.10 on that distro. > > A new wayland-compat.h file has stubs for the wl_proxy_create_wrapper() and >

[Mesa-dev] [PATCH 2/2] egl, dri: Propagate context priority hint to driver->CreateContext

2017-04-06 Thread Chris Wilson
Jump through the layers of abstraction between egl and dri in order to feed the context priority attribute through to the backend. This requires us to read the value from the base _egl_context, convert it to a DRI attribute, parse it again in the generic context creater before passing it to the

[Mesa-dev] [PATCH 1/2] egl: Support IMG_context_priority

2017-04-06 Thread Chris Wilson
IMG_context_priority https://www.khronos.org/registry/egl/extensions/IMG/EGL_IMG_context_priority.txt "This extension allows an EGLContext to be created with a priority hint. It is possible that an implementation will not honour the hint, especially if there are constraints on the

Re: [Mesa-dev] [PATCH] mesa: tidy up renderbuffer RefCount initialisation

2017-04-06 Thread Bartosz Tomczyk
Timothy, I observe huge memory leak after this commit: Direct leak of 648208 byte(s) in 3683 object(s) allocated from: #0 0x7f3d72729800 in calloc (/usr/lib/clang/3.9.1/lib/linux/ libclang_rt.asan-x86_64.so+0xf6800) #1 0x7f3d64a4d114 in st_new_renderbuffer

Re: [Mesa-dev] [PATCH] anv: provide anv_gem_busy() stub for the tests

2017-04-06 Thread Vinson Lee
On Thu, Apr 6, 2017 at 5:07 AM, Emil Velikov wrote: > From: Emil Velikov > > Otherwise linking way fail. > > Cc: Jason Ekstrand > Cc: Vinson Lee > Bugzilla:

Re: [Mesa-dev] [PATCH] anv/blorp: sample input attachments with resolves on BDW

2017-04-06 Thread Jason Ekstrand
On Thu, Apr 6, 2017 at 1:58 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > On Broadwell we still need to do a resolve between the subpass > that writes and the subpass that reads when there is a > self-dependency because HW could not see fast-clears and works > on the render cache

[Mesa-dev] [PATCH 3/3] glx: silence uninitialized var warning

2017-04-06 Thread Brian Paul
--- src/glx/glx_pbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c index 0c15d2a..933b5d9 100644 --- a/src/glx/glx_pbuffer.c +++ b/src/glx/glx_pbuffer.c @@ -901,7 +901,7 @@ glXGetSelectedEvent(Display * dpy, GLXDrawable

[Mesa-dev] [PATCH 1/3] gallivm: init vars to silence gcc warnings

2017-04-06 Thread Brian Paul
Silence warnings about using possibly uninitialized values. --- src/gallium/auxiliary/gallivm/lp_bld_sample.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_sample.c b/src/gallium/auxiliary/gallivm/lp_bld_sample.c index

[Mesa-dev] [PATCH 2/3] st/mesa: silence unused/uninitialized var warnings

2017-04-06 Thread Brian Paul
--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 674ccd0..72fd70b 100644 --- a/src/mesa/state_tracker/st_glsl_to_nir.cpp +++

[Mesa-dev] [PATCH] svga: remove pre-SVGA3D_HWVERSION_WS8_B1 code

2017-04-06 Thread Brian Paul
3D wasn't officially supported before virtual HW version 8 so we can remove this old code. --- src/gallium/drivers/svga/svga_state_constants.c | 76 ++--- 1 file changed, 5 insertions(+), 71 deletions(-) diff --git a/src/gallium/drivers/svga/svga_state_constants.c

[Mesa-dev] [PATCH] egl/wayland: allow building with Wayland 1.10

2017-04-06 Thread Brian Paul
From: Brian Fedora 24 only has Wayland 1.10, not 1.11. This change lets us build Mesa/EGL with Wayland 1.10 on that distro. A new wayland-compat.h file has stubs for the wl_proxy_create_wrapper() and wl_proxy_wrapper_destroy() functions which were added in Wayland

Re: [Mesa-dev] [PATCH 4/4] anv: Use subpass dependencies for flushes

2017-04-06 Thread Jason Ekstrand
On Thu, Mar 30, 2017 at 2:06 PM, Nanley Chery wrote: > On Tue, Mar 14, 2017 at 07:55:53AM -0700, Jason Ekstrand wrote: > > Instead of figuring it all out ourselves, just use the information given > > to us by the client. > > --- > > src/intel/vulkan/anv_blorp.c | 88

Re: [Mesa-dev] [PATCH v2 3/4] anv/pass: Record required pipe flushes

2017-04-06 Thread Jason Ekstrand
On Thu, Mar 30, 2017 at 1:59 PM, Nanley Chery wrote: > On Wed, Mar 15, 2017 at 12:01:16PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_pass.c| 89 ++ > > > src/intel/vulkan/anv_private.h | 2 + > > 2 files

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

2017-04-06 Thread Mauro Rossi
2017-04-04 0:54 GMT+02:00 Mauro Rossi : > Hi Tomasz, > > > 2017-04-03 10:00 GMT+02:00 Tomasz Figa : > >> Hi Mauro, >> >> On Mon, Apr 3, 2017 at 2:48 AM, Mauro Rossi >> wrote: >> > >> > >> > 2017-03-31 13:05 GMT+02:00 Tapani Pälli

Re: [Mesa-dev] [PATCH] mesa/main: simplify _mesa_IsRenderbuffer()

2017-04-06 Thread Anuj Phogat
On Thu, Apr 6, 2017 at 9:05 AM, Samuel Pitoiset wrote: > _mesa_lookup_renderbuffer() already checks if 'id' is non-zero. > > Signed-off-by: Samuel Pitoiset > --- > src/mesa/main/fbobject.c | 13 ++--- > 1 file changed, 6

Re: [Mesa-dev] [PATCH 4/5] radv: implement VK_KHR_descriptor_update_template

2017-04-06 Thread Fredrik Höglund
On Wednesday 05 April 2017, Bas Nieuwenhuizen wrote: > Could you move the declarations you add in radv_descriptor_set.h to > radv_private.h? I'd like to keep it limited to whatever is necessary > for the compiler, which is only the set & pipeline layouts. You could > just put it next to the

Re: [Mesa-dev] [PATCH 1/2] travis: replace Trusty-based LLVM toolchain apt-get with apt addon

2017-04-06 Thread Dylan Baker
Oop, I missed that. Not worth turning it off just to turn it back on. Quoting Andres Gomez (2017-04-05 11:19:50) > On Wed, 2017-04-05 at 11:12 -0700, Dylan Baker wrote: > > I believe you can also remove 'sudo: true' (or set to false) with this > > change. > > You are probably right but 2/2

Re: [Mesa-dev] [PATCH 2/2] travis: add the txc-dxtn library so scons check can pass

2017-04-06 Thread Eric Anholt
Andres Gomez writes: > The packaged libtxc-dxtn-s2tc0 will make scons check fail. Manually > remove this package and install libtxc-dxtn instead. I don't think we should be automatically installing and using this software on other people's machines. The patent is why dxtn

[Mesa-dev] [PATCH] mesa/main: simplify _mesa_IsRenderbuffer()

2017-04-06 Thread Samuel Pitoiset
_mesa_lookup_renderbuffer() already checks if 'id' is non-zero. Signed-off-by: Samuel Pitoiset --- src/mesa/main/fbobject.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index

Re: [Mesa-dev] [PATCH v2] anv: add support for allocating more than 1 block of memory

2017-04-06 Thread Jason Ekstrand
On April 6, 2017 8:29:11 AM "Juan A. Suarez Romero" wrote: On Mon, 2017-04-03 at 07:44 -0700, Jason Ekstrand wrote: On Mon, Apr 3, 2017 at 5:02 AM, Juan A. Suarez Romero wrote: > On Wed, 2017-03-29 at 12:06 -0700, Jason Ekstrand wrote: > > Looking

Re: [Mesa-dev] [PATCH v2] anv: add support for allocating more than 1 block of memory

2017-04-06 Thread Juan A. Suarez Romero
On Mon, 2017-04-03 at 07:44 -0700, Jason Ekstrand wrote: > On Mon, Apr 3, 2017 at 5:02 AM, Juan A. Suarez Romero > wrote: > > On Wed, 2017-03-29 at 12:06 -0700, Jason Ekstrand wrote: > > > Looking over the patch, I think I've convinced myself that it's correct.  > > > (I

Re: [Mesa-dev] [PATCH] gallium/radeon: fix typo in radeon_winsys.h

2017-04-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Apr 6, 2017 at 2:27 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeon/radeon_winsys.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] st/pbo: select the right swizzle for instance IDs

2017-04-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Apr 6, 2017 at 4:50 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The system value only has an X component, and radeonsi started > checking that in debug builds. > > Reported-by:

[Mesa-dev] [Bug 100580] Adding unreachable "return" and "continue" in a GLSL shader leads to different image

2017-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100580 Roland Scheidegger changed: What|Removed |Added Component|Drivers/Gallium/radeonsi|Mesa core

[Mesa-dev] [PATCH] st/pbo: select the right swizzle for instance IDs

2017-04-06 Thread Nicolai Hähnle
From: Nicolai Hähnle The system value only has an X component, and radeonsi started checking that in debug builds. Reported-by: Michel Dänzer Fixes: 4cf29427770f ("radeonsi: support 64-bit system values") --- src/mesa/state_tracker/st_pbo.c | 3

Re: [Mesa-dev] [RFC] etnaviv: native fence fd support

2017-04-06 Thread Rob Clark
On Thu, Apr 6, 2017 at 10:23 AM, Philipp Zabel wrote: > On Wed, 2017-04-05 at 19:46 +0200, Christian Gmeiner wrote: > [...] >> > --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c >> > +++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c >> > @@ -137,6 +137,9 @@

Re: [Mesa-dev] [PATCH] gallium/radeon: fix typo in radeon_winsys.h

2017-04-06 Thread Alex Deucher
On Thu, Apr 6, 2017 at 8:27 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeon/radeon_winsys.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [RFC] etnaviv: native fence fd support

2017-04-06 Thread Philipp Zabel
On Wed, 2017-04-05 at 19:46 +0200, Christian Gmeiner wrote: [...] > > --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c > > +++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c > > @@ -137,6 +137,9 @@ etna_screen_get_param(struct pipe_screen *pscreen, enum > > pipe_cap param) > > case

Re: [Mesa-dev] [RFC] etnaviv: native fence fd support

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 09:54 +0200, Christian Gmeiner wrote: > /2017-04-05 18:14 GMT+02:00 Philipp Zabel : > > This adds native fence fd support to etnaviv, similarly to commit > > 0b98e84e9ba0 ("freedreno: native fence fd"), enabled for kernel > > driver version 1.1 or

Re: [Mesa-dev] [RFC] etnaviv: native fence fd support

2017-04-06 Thread Philipp Zabel
On Wed, 2017-04-05 at 13:12 -0400, Rob Clark wrote: > On Wed, Apr 5, 2017 at 12:14 PM, Philipp Zabel wrote: > > +void > > +etna_fence_server_sync(struct pipe_context *pctx, > > + struct pipe_fence_handle *pfence) > > +{ > > + struct etna_context

[Mesa-dev] [PATCH] gallium/radeon: fix typo in radeon_winsys.h

2017-04-06 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/radeon_winsys.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h index a63485175d..2e287c67ee

[Mesa-dev] [PATCH] anv: provide anv_gem_busy() stub for the tests

2017-04-06 Thread Emil Velikov
From: Emil Velikov Otherwise linking way fail. Cc: Jason Ekstrand Cc: Vinson Lee Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100600 Fixes: f195d40eca4 ("anv/device: Add a helper for querying whether a BO is

Re: [Mesa-dev] [GSOC] DriConf Replacement

2017-04-06 Thread Jean Hertel
Nicolai, Is there any place were I can find all the options with their respectives descriptions? I have readed a little of information about DRI here[1], but i'm not very sure were I can find a doc about all those options. About the language and the choice of full rewrite or incremental,

Re: [Mesa-dev] [PATCH] aubinator_error_decode: print unknown instructions in red

2017-04-06 Thread Chris Wilson
On Thu, Apr 06, 2017 at 12:17:00PM +0100, Lionel Landwerlin wrote: > On 06/04/17 12:12, Chris Wilson wrote: > >On Thu, Apr 06, 2017 at 12:04:40PM +0100, Lionel Landwerlin wrote: > >>This is a pretty good indicator that something's gone horribly wrong. > >Do you run IPEHR through the decoder? That

Re: [Mesa-dev] [PATCH] aubinator_error_decode: print unknown instructions in red

2017-04-06 Thread Lionel Landwerlin
On 06/04/17 12:12, Chris Wilson wrote: On Thu, Apr 06, 2017 at 12:04:40PM +0100, Lionel Landwerlin wrote: This is a pretty good indicator that something's gone horribly wrong. Do you run IPEHR through the decoder? That was somewhere on the todo list for intel_error_decode. -Chris Not yet,

Re: [Mesa-dev] very strange intermittent frame-dropping

2017-04-06 Thread Luke Kenneth Casson Leighton
On Thu, Apr 6, 2017 at 11:36 AM, Eero Tamminen wrote: >> LIBGL_DEBUG=verbose glxgears >> libGL: Using DRI2 for screen 0 >> >> huh. so i _thought_ it was going to be DRI3. that's supposed to be >> the default, isn't it? > > > You need it enabled in Intel DDX build,

Re: [Mesa-dev] [PATCH] aubinator_error_decode: print unknown instructions in red

2017-04-06 Thread Chris Wilson
On Thu, Apr 06, 2017 at 12:04:40PM +0100, Lionel Landwerlin wrote: > This is a pretty good indicator that something's gone horribly wrong. Do you run IPEHR through the decoder? That was somewhere on the todo list for intel_error_decode. -Chris -- Chris Wilson, Intel Open Source Technology

[Mesa-dev] [PATCH] aubinator_error_decode: print unknown instructions in red

2017-04-06 Thread Lionel Landwerlin
This is a pretty good indicator that something's gone horribly wrong. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_error_decode.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator_error_decode.c

Re: [Mesa-dev] [PATCH 40/53] i965/drm: Rewrite relocation handling.

2017-04-06 Thread Chris Wilson
On Wed, Apr 05, 2017 at 04:56:42PM -0700, Kenneth Graunke wrote: > On Wednesday, April 5, 2017 4:46:27 AM PDT Chris Wilson wrote: > > On Tue, Apr 04, 2017 at 05:10:30PM -0700, Kenneth Graunke wrote: > > > The execbuf2 kernel API requires us to construct two kinds of lists. > > > First is a

Re: [Mesa-dev] [PATCH 2/3] glsl: disable cache if MESA_EXTENSION_OVERRIDE is set

2017-04-06 Thread Timothy Arceri
On 05/04/17 19:58, Nicolai Hähnle wrote: On 05.04.2017 05:56, Timothy Arceri wrote: In the following patch we will stop pre-processing shaders before hashing them, so we just disable the cache if MESA_EXTENSION_OVERRIDE is set. Why can't you add the value of MESA_EXTENSION_OVERRIDE to the

Re: [Mesa-dev] very strange intermittent frame-dropping

2017-04-06 Thread Eero Tamminen
Hi, On 06.04.2017 00:36, Luke Kenneth Casson Leighton wrote: eero, apologies, the mesa-dev list's traffic is very high, i'll switch over to digest, so please do cc me each time, to mitigate that. OK. there's a whole stack of people reporting this occurring, running the full range of

Re: [Mesa-dev] [PATCH 2/2] bin/get-{extra, fixes}-pick-list.sh: improve output

2017-04-06 Thread Eric Engestrom
On Wednesday, 2017-04-05 20:25:24 +0200, Juan A. Suarez Romero wrote: > Show the commit hash and the title in a way that it is easier to copy > and paste in the bin/.cherry-ignore-extra file if we want to ignore > those commits for the future. > --- > bin/get-extra-pick-list.sh | 2 +- >

Re: [Mesa-dev] [PATCH v2] gallium/hud: set the dump file streams to line buffered

2017-04-06 Thread Julien Isorce
Reviewed-by: Julien Isorce On 5 April 2017 at 20:03, Edmondo Tommasina wrote: > Flush the HUD value streams to the dump files after every newline. > > v2: check that fopen succeeded (Julien) > > Tested-by: Julien Isorce >

Re: [Mesa-dev] [PATCH v2 1/4] intel/aubinator_error_decode: Fix structure decode data

2017-04-06 Thread Lionel Landwerlin
Thanks! Reviewed-by: Lionel Landwerlin On 06/04/17 06:51, Jordan Justen wrote: The call to gen_print_group should provide a pointer to the beginning of the the structure data, not the start of the batch data. Cc: Lionel Landwerlin

[Mesa-dev] [PATCH] anv/blorp: sample input attachments with resolves on BDW

2017-04-06 Thread Samuel Iglesias Gonsálvez
On Broadwell we still need to do a resolve between the subpass that writes and the subpass that reads when there is a self-dependency because HW could not see fast-clears and works on the render cache as if there was regular non-fast-clear surface. Fixes 16 tests on BDW:

Re: [Mesa-dev] [RFC] etnaviv: native fence fd support

2017-04-06 Thread Christian Gmeiner
/2017-04-05 18:14 GMT+02:00 Philipp Zabel : > This adds native fence fd support to etnaviv, similarly to commit > 0b98e84e9ba0 ("freedreno: native fence fd"), enabled for kernel > driver version 1.1 or later. > > Signed-off-by: Philipp Zabel > --- >

Re: [Mesa-dev] [PATCH] mesa: stop abstracting texture object hashtable locking

2017-04-06 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 04/06/2017 06:43 AM, Timothy Arceri wrote: This doesn't do anything useful so just remove it. --- src/mesa/main/shaderimage.c | 5 +++-- src/mesa/main/texobj.c | 17 ++--- src/mesa/main/texobj.h | 6 -- 3

Re: [Mesa-dev] [PATCH] mesa: stop abstracting buffer object hashtable locking

2017-04-06 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 04/06/2017 03:00 AM, Timothy Arceri wrote: This doesn't do anything useful so just remove it. --- src/mesa/main/bufferobj.c | 33 ++--- src/mesa/main/bufferobj.h | 6 -- src/mesa/main/varray.c| 4

Re: [Mesa-dev] [PATCH] i965/blorp: Bump the batch space estimate

2017-04-06 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Wed, 2017-04-05 at 21:16 -0700, Jason Ekstrand wrote: > Commit f938354362655a378d474c5f79c52cea9852ab91 recently increased > the > alignment on vertex buffer data from 32 to 64.  This caused us to > consume a bit more batch than we were

Re: [Mesa-dev] [PATCH] mesa: stop abstracting texture object hashtable locking

2017-04-06 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2017-04-06 at 14:43 +1000, Timothy Arceri wrote: > This doesn't do anything useful so just remove it. > --- >  src/mesa/main/shaderimage.c |  5 +++-- >  src/mesa/main/texobj.c  | 17 ++--- >  src/mesa/main/texobj.h  |  

[Mesa-dev] [Bug 100600] anv_device.c:1337: undefined reference to `anv_gem_busy'

2017-04-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100600 Bug ID: 100600 Summary: anv_device.c:1337: undefined reference to `anv_gem_busy' Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH] anv/query: Busy-wait for available query entries

2017-04-06 Thread Iago Toral
On Wed, 2017-04-05 at 09:31 -0700, Jason Ekstrand wrote: > On Wed, Apr 5, 2017 at 12:24 AM, Iago Toral > wrote: > > On Tue, 2017-04-04 at 19:21 -0700, Jason Ekstrand wrote: > > > Before, we were just looking at whether or not the user wanted us > > to > > > wait and waiting on

Re: [Mesa-dev] [PATCH v2 1/4] intel/aubinator_error_decode: Fix structure decode data

2017-04-06 Thread Matt Turner
On Wed, Apr 5, 2017 at 10:51 PM, Jordan Justen wrote: > The call to gen_print_group should provide a pointer to the beginning > of the the structure data, not the start of the batch data. > > Cc: Lionel Landwerlin > Signed-off-by: Jordan