Re: [Mesa-dev] [RFC 1/2] drm/i915: Engine discovery uAPI

On Tuesday, April 18, 2017 9:56:14 AM PDT Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Engine discovery uAPI allows userspace to probe for engine > configuration and features without needing to maintain the > internal PCI id based database. I don't understand why I

[Mesa-dev] [Bug 100708] Trine 2 doesn't start on radeonsi on mesa 17

https://bugs.freedesktop.org/show_bug.cgi?id=100708 Michel Dänzer changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop

Re: [Mesa-dev] [PATCH 1/2] isl/format: Update the R16G16B16X16_FLOAT entry

Reviewed-by: Jason Ekstrand On Tue, Apr 18, 2017 at 4:31 PM, Nanley Chery wrote: > The section of the PRM mentioned in the code comment above this table > says that this format supports the render target write message. Internal > documentation says

Re: [Mesa-dev] [PATCH 2/2] intel/isl: Only create a CCS buffer if the surface format supports it

On Tue, Apr 18, 2017 at 4:31 PM, Nanley Chery wrote: > Signed-off-by: Nanley Chery > --- > src/intel/isl/isl.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > index

Re: [Mesa-dev] [PATCH] anv/pass: Delete anv_pass::subpass_attachments

Reviewed-by: Jason Ekstrand wrote: > This field has no users. > > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_private.h | 1 - > 1 file changed, 1 deletion(-) > >

Re: [Mesa-dev] [PATCH] anv/image: Remove incorrect assertion in anv_BindImage

On Tue, Apr 18, 2017 at 4:41 PM, Nanley Chery wrote: > According to the Linux kernel sources, the ioctl in anv_gem_mmap() will > not fail if the size isn't a multiple of 4KB. > I was fairly sure that wasn't the case... I'll have to do some looking. > Signed-off-by:

Re: [Mesa-dev] [PATCH] st/mesa/i965: validate sampler type across the whole program

Hi Tapani, You seem to have been one of the last people to touch this code. Do you think you could take a look at this patch? Thanks, Tim On 13/04/17 12:01, Timothy Arceri wrote: From: Timothy Arceri Currently we were only making sure types were the same

[Mesa-dev] [PATCH 2/2] radv/meta: Fix nir_builder.h include

This fixes the build after: commit 399ebd2a84a133bd2ca3da388a059fd3bafe33f5 Author: Dave Airlie Date: Wed Apr 19 06:18:23 2017 +1000 radv/meta: add common shader vertex generation function Signed-off-by: Mike Lothian ---

[Mesa-dev] [PATCH 1/2] radv/ac: Fix nir.h include

This fixes the build after: commit 224cf2906a8f38ce47411afc93a223ac0e41795f Author: Dave Airlie Date: Mon Apr 17 13:01:52 2017 +1000 radv/ac: add initial pre-pass for shader info gathering Signed-off-by: Mike Lothian ---

Re: [Mesa-dev] [PATCH 01/14] mesa: add env var to force enable the KHR_no_error ctx flag

On 19/04/17 11:39, Michel Dänzer wrote: On 18/04/17 07:35 PM, Nicolai Hähnle wrote: On 18.04.2017 02:09, Timothy Arceri wrote: V2: typo know -> known --- docs/envvars.html | 3 +++ src/mesa/main/context.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/docs/envvars.html

Re: [Mesa-dev] [PATCH 01/14] mesa: add env var to force enable the KHR_no_error ctx flag

On 18/04/17 07:35 PM, Nicolai Hähnle wrote: > On 18.04.2017 02:09, Timothy Arceri wrote: >> V2: typo know -> known >> --- >> docs/envvars.html | 3 +++ >> src/mesa/main/context.c | 3 +++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/docs/envvars.html b/docs/envvars.html >> index

Re: [Mesa-dev] [PATCH 11/12] i965/cnl: Properly handle l3 configuration

Anuj Phogat writes: > From: Ben Widawsky > > V2: Squash the changes in one patch and rebased on master (Anuj). > > Signed-off-by: Ben Widawsky > Signed-off-by: Anuj Phogat > --- >

Re: [Mesa-dev] [PATCH 1/2] mesa: Add GL/GLSL plumbing for ARB_fragment_shader_interlock.

On 19/04/17 11:12, Manolova, Plamena wrote: Thank you for reviewing Timothy! On Mon, Apr 17, 2017 at 7:10 PM, Timothy Arceri > wrote: On 18/04/17 11:25, Plamena Manolova wrote: This extension provides new GLSL built-in

Re: [Mesa-dev] [PATCH 1/2] mesa: Add GL/GLSL plumbing for ARB_fragment_shader_interlock.

Thank you for reviewing Nicolai! On Tue, Apr 18, 2017 at 4:17 AM, Nicolai Hähnle wrote: > On 18.04.2017 03:25, Plamena Manolova wrote: > >> This extension provides new GLSL built-in functions >> beginInvocationInterlockARB() and endInvocationInterlockARB() >> that delimit a

Re: [Mesa-dev] [PATCH 1/2] mesa: Add GL/GLSL plumbing for ARB_fragment_shader_interlock.

Thank you for reviewing Timothy! On Mon, Apr 17, 2017 at 7:10 PM, Timothy Arceri wrote: > > > On 18/04/17 11:25, Plamena Manolova wrote: > >> This extension provides new GLSL built-in functions >> beginInvocationInterlockARB() and endInvocationInterlockARB() >> that

Re: [Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

On 18/04/17 09:52 PM, Ilia Mirkin wrote: > On Tue, Apr 18, 2017 at 2:21 AM, Michel Dänzer wrote: >> On 18/04/17 01:02 PM, Ilia Mirkin wrote: >>> On Tue, Apr 18, 2017 at 12:00 AM, Ilia Mirkin wrote: val_bool and val_int are in a union. val_bool gets

[Mesa-dev] [RFC 2/2] drm/i915: Select engines via class and instance in execbuffer2

From: Tvrtko Ursulin Building on top of the previous patch which exported the concept of engine classes and instances, we can also use this instead of the current awkward engine selection uAPI. This is primarily interesting for the VCS engine selection which is a)

[Mesa-dev] [RFC 1/2] drm/i915: Engine discovery uAPI

From: Tvrtko Ursulin Engine discovery uAPI allows userspace to probe for engine configuration and features without needing to maintain the internal PCI id based database. This enables removal of code duplications across userspace components. Probing is done via the

[Mesa-dev] [RFC 0/2] New engine discovery and execbuffer2 engine selection uAPI

From: Tvrtko Ursulin Inspired by the recent introduction of the engine class and instance concept, and a chat with Chris Wilson about a potential unification of PCI id based device discovery across multiple userspace components, I have cooked up two patches to gather

[Mesa-dev] [PATCH 08/14] mesa/varray: rename update_array_format() -> validate_array_format()

We also move _mesa_update_array_format() into the caller. This gets these functions ready for KHR_no_error support. V2: Updated function comment as suggested by Brian. Reviewed-by: Nicolai Hähnle --- src/mesa/main/varray.c | 71

[Mesa-dev] [PATCH 13/14] mesa/vbo: add KHR_no_error support to DrawElements*() functions

V2: move MESA_VERBOSE checks back into the common code path. Reviewed-by: Nicolai Hähnle --- src/mesa/vbo/vbo_exec_array.c | 96 --- 1 file changed, 73 insertions(+), 23 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c

[Mesa-dev] [PATCH 09/14] mesa/varray: add KHR_no_error support to some callers of validate_array_format()

The only caller we don't update is update_arrays(), we leave that to the following commit. Reviewed-by: Nicolai Hähnle --- src/mesa/main/varray.c | 136 ++--- 1 file changed, 73 insertions(+), 63 deletions(-) diff --git

[Mesa-dev] [PATCH 05/14] mesa: add KHR_no_error support to glUniform*() functions

V2: restore lost comment, add static to validate_uniform(), simplify array offset logic. Reviewed-by: Nicolai Hähnle --- src/mesa/main/uniform_query.cpp | 73 - 1 file changed, 50 insertions(+), 23 deletions(-) diff --git

[Mesa-dev] [PATCH 10/14] mesa/varray: add KHR_no_error support to *Pointer() functions

Reviewed-by: Nicolai Hähnle --- src/mesa/main/varray.c | 352 + 1 file changed, 236 insertions(+), 116 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index be5482d..7c46cb3 100644 ---

[Mesa-dev] [PATCH 14/14] mesa: add KHR_no_error support to glVertexAttribDivisor()

Reviewed-by: Nicolai Hähnle --- src/mesa/main/varray.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index 7c46cb3..6da9d84 100644 --- a/src/mesa/main/varray.c +++

[Mesa-dev] [PATCH 12/14] mesa/vbo: add KHR_no_error support to vbo_exec_DrawArrays*()

V2: add missing FLUSH_CURRENT() to no_error path Reviewed-by: Nicolai Hähnle --- src/mesa/vbo/vbo_exec_array.c | 49 ++- 1 file changed, 39 insertions(+), 10 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c

[Mesa-dev] [PATCH 11/14] mesa/vbo: move some Draw checks out of validation

These checks do not generate any errors. Move them so we can add KHR_no_error support and still make sure we do these checks. Reviewed-by: Nicolai Hähnle --- src/mesa/main/api_validate.c | 43 + src/mesa/vbo/vbo_exec_array.c | 106

[Mesa-dev] [PATCH 02/14] mesa: add env var to force enable the KHR_no_error ctx flag

V2: typo know -> known V3: add security check (Suggested by Nicolai) --- docs/envvars.html | 3 +++ src/mesa/main/context.c | 6 ++ 2 files changed, 9 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 6537365..a064f56 100644 --- a/docs/envvars.html +++

[Mesa-dev] [PATCH 06/14] mesa/varray: split update_array() into validate_array() and update_array()

This will be used for adding KHR_no_error support. Reviewed-by: Nicolai Hähnle --- src/mesa/main/varray.c | 55 +- 1 file changed, 41 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/varray.c

[Mesa-dev] [PATCH 03/14] mesa: add _mesa_is_no_error_enabled() helper

Reviewed-by: Nicolai Hähnle --- src/mesa/main/context.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index 9704a96..ccb5463 100644 --- a/src/mesa/main/context.h +++ b/src/mesa/main/context.h @@ -317,20

[Mesa-dev] [PATCH 07/14] mesa/varray: create get_array_format() helper

This will help us split array validation from array update. V2: add const to ctx param Reviewed-by: Nicolai Hähnle --- src/mesa/main/varray.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/varray.c

[Mesa-dev] [PATCH 04/14] mesa: always return GL_OUT_OF_MEMORY or GL_NO_ERROR when KHR_no_error enabled

Reviewed-by: Nicolai Hähnle --- src/mesa/main/getstring.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index 6e90511..5da405d 100644 --- a/src/mesa/main/getstring.c +++ b/src/mesa/main/getstring.c

[Mesa-dev] V3 Initial KHR_no_error support

V3: - add security check to patch 2 - include patch 1 which didn't get sent out in V2 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 01/14] mesa: expose KHR_no_error

--- src/mesa/main/extensions_table.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index d11cb0f..dc735c5 100644 --- a/src/mesa/main/extensions_table.h +++ b/src/mesa/main/extensions_table.h @@ -296,20 +296,21 @@

Re: [Mesa-dev] [PATCH 2/9] mesa/st: compute+SSBO support for glsl_to_nir

Rob Clark writes: > Signed-off-by: Rob Clark I don't know too much about compute/ssbo, but the logic seems to basically match the VS/FS cases. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH 8/9] radv/ac: add support for indirect access of descriptor sets.

On Mon, Apr 17, 2017 at 11:57 PM, Dave Airlie wrote: > From: Dave Airlie > > We want to expose more descriptor sets to the applications, > but currently we have a 1:1 mapping between shader descriptor > sets and 2 user sgprs, limiting us to 4 per stage.

[Mesa-dev] [PATCH v3] radv: Use host memory pool for non-freeable descriptors.

v2: Handle out of pool memory error. v3: Actually use VK_ERROR_OUT_OF_POOL_MEMORY_KHR for the error condition. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_descriptor_set.c | 69 +++- src/amd/vulkan/radv_private.h| 4 +++ 2

Re: [Mesa-dev] [PATCH 1/9] radv/meta: add support for save/restore meta without vertex data.

Nice cleanup. Reviewed-by: Bas Nieuwenhuizen On Wed, Apr 19, 2017 at 1:27 AM, Dave Airlie wrote: > From: Dave Airlie > > Some of the shaders could just generate the vertex data in the > shader, so add helpers to allow us to move

[Mesa-dev] [PATCH] anv/pass: Delete anv_pass::subpass_attachments

This field has no users. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_private.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 7d079000b0..dbe1e0475e 100644 ---

[Mesa-dev] [PATCH] anv/image: Remove incorrect assertion in anv_BindImage

According to the Linux kernel sources, the ioctl in anv_gem_mmap() will not fail if the size isn't a multiple of 4KB. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] isl/format: Update the R16G16B16X16_FLOAT entry

The section of the PRM mentioned in the code comment above this table says that this format supports the render target write message. Internal documentation says that this format also supports alpha blending. As a side effect, this allows CCS_D buffers to be created for images with this format.

[Mesa-dev] [PATCH 2/2] intel/isl: Only create a CCS buffer if the surface format supports it

Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index f89f351c15..09dafcbab6 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1573,8

[Mesa-dev] [PATCH v2 3/4] radv: Don't try to find gaps for non-freeable descriptors.

With this we don't have any operations on a pool with non-freeable descriptors left that have O(#descriptors) complexity. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_descriptor_set.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v2 1/4] radv: Don't allocate dynamic descriptors separately.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_descriptor_set.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c index 48cb8c2a30a..26f89152d52 100644 ---

[Mesa-dev] [PATCH v2 4/4] radv: Remove binding buffer count.

In cases where it is used it is always 1. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_descriptor_set.c | 21 ++--- src/amd/vulkan/radv_descriptor_set.h | 1 - src/amd/vulkan/radv_private.h| 1 - 3 files changed, 10 insertions(+), 13

[Mesa-dev] [PATCH v2 2/4] radv: Use host memory pool for non-freeable descriptors.

v2: Handle out of pool memory error. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_descriptor_set.c | 69 +++- src/amd/vulkan/radv_private.h| 4 +++ 2 files changed, 57 insertions(+), 16 deletions(-) diff --git

[Mesa-dev] [PATCH 6/9] radv/meta: reduce vertex buffer usage in clear shaders

From: Dave Airlie For depth clears we have to pass the depth in the 2nd component, we can use push constants for some of this later to drop the vertex buffer completely Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta.c | 9 --

[Mesa-dev] [PATCH 7/9] radv/meta: reduce vertex buffer in blit2d.

From: Dave Airlie Generate the position vertices. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit2d.c | 35 +++ 1 file changed, 7 insertions(+), 28 deletions(-) diff --git a/src/amd/vulkan/radv_meta_blit2d.c

[Mesa-dev] [PATCH 9/9] radv/meta: refactor out some common shaders.

From: Dave Airlie The vs vertex generate and fs noop shaders are used in a few places, so refactor them out. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta.c| 35 ++ src/amd/vulkan/radv_meta.h

[Mesa-dev] [PATCH 5/9] radv/meta: avoid using vertex buffer for resolve shader.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_resolve.c | 74 -- 1 file changed, 7 insertions(+), 67 deletions(-) diff --git a/src/amd/vulkan/radv_meta_resolve.c

[Mesa-dev] [PATCH 8/9] radv/meta: generate position for blit shaders.

From: Dave Airlie This generates the position info using the vertex shader. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit.c | 67 ++--- 1 file changed, 16 insertions(+), 51 deletions(-) diff --git

[Mesa-dev] [PATCH 1/9] radv/meta: add support for save/restore meta without vertex data.

From: Dave Airlie Some of the shaders could just generate the vertex data in the shader, so add helpers to allow us to move to doing that. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta.c | 39 +++

[Mesa-dev] [PATCH 2/9] radv/meta: add common shader vertex generation function

From: Dave Airlie Instead of passing in the same 1.0, -1.0 combinations via vertex buffers, we can just use vertex id to have the vertex shader build them. This function introduces the generator code needed, later patches will use this. Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH 4/9] radv/meta: move depth decompress to using inline vertex data

From: Dave Airlie This removes the vertex buffer, and just generates the values in the shader. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_decompress.c | 75 +++ 1 file changed, 6 insertions(+), 69

[Mesa-dev] [PATCH 3/9] radv/meta: move fast clear to generate vertices in shader.

From: Dave Airlie Avoids having to setup vertex buffers. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_fast_clear.c | 74 +++ 1 file changed, 6 insertions(+), 68 deletions(-) diff --git

Re: [Mesa-dev] V2 RFC initial KHR_no_error support

On 18/04/17 20:48, Nicolai Hähnle wrote: On 18.04.2017 02:09, Timothy Arceri wrote: V2: some bug fixes and suggestions addressed as suggested by Brian and Nicolai. This series adds some initial support for the KHR_no_error. For now it can only be enabled with the MESA_NO_ERROR

Re: [Mesa-dev] [PATCH v02 2/3] genxml: Fix python crash when no dwords are found.

Thanks for making the changes I requested. Reviewed-by: Dylan Baker Quoting Rafael Antognolli (2017-04-18 14:50:20) > If the 'dwords' dict is empty, max(dwords.keys()) throws an exception. > This case could happen when we have an instruction that is only an array > of other

Re: [Mesa-dev] [PATCH 6/7] docs/releasing: added relevant people for build/check with Android

2017-04-18 8:56 GMT+02:00 Andres Gomez : > Mauro, is it OK that I mention you as a reference for Android in the > releasing doc? > Looking at my, somehow limited, coding skills, I think that my role would be defined better as an active android-x86 debugging contributor/build

[Mesa-dev] [PATCH 8/9] freedreno: core compute support

Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.h | 14 +++- src/gallium/drivers/freedreno/freedreno_draw.c| 47 src/gallium/drivers/freedreno/freedreno_gmem.c| 7 ++ src/gallium/drivers/freedreno/freedreno_gmem.h| 1 +

[Mesa-dev] [PATCH 7/9] freedreno/ir3: compute shader support

Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/disasm.h | 1 + .../drivers/freedreno/ir3/ir3_compiler_nir.c | 81 +- src/gallium/drivers/freedreno/ir3/ir3_shader.c | 76 +++-

[Mesa-dev] [PATCH 9/9] freedreno/a5xx: basic experimental compute support

Hidden under FD_MESA_DEBUG=compute flag for now. In particular because we completely lie about having image support. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/Makefile.sources | 2 + src/gallium/drivers/freedreno/a5xx/fd5_compute.c | 175

[Mesa-dev] [PATCH 3/9] freedreno/ir3: resync instr-a3xx.h/disasm-a3xx.c

Sync to the same files from freedreno.git to correct decoding of ldgb/ stgb instructions. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c | 2 +- src/gallium/drivers/freedreno/disasm.h | 3 +

[Mesa-dev] [PATCH 5/9] freedreno/ir3: SSBO/atomic support

TODO cwabbott pointed out a write-after-read hazzard, which effects both this and arrays. A write needs to depend on *all* reads since the last write, not just the last read. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/ir3/ir3.c| 74 +++-

[Mesa-dev] [PATCH 6/9] freedreno/a5xx: SSBO support

To simplify things for now, since all the gfx shader stages share a single SSBO state block, only advertise SSBO support for fragment shader (and compute when we have that). We could possibly use a fixed- partitioning of the SSBO index space to support SSBOs on other stages without having to

[Mesa-dev] [PATCH 4/9] freedreno: core SSBO support

The generation-independent support for binding shader buffer objects. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.h | 8 src/gallium/drivers/freedreno/freedreno_draw.c | 6 +++ src/gallium/drivers/freedreno/freedreno_resource.c |

[Mesa-dev] [PATCH 2/9] mesa/st: compute+SSBO support for glsl_to_nir

Signed-off-by: Rob Clark --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 14 ++ src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- src/mesa/state_tracker/st_program.c| 13 + src/mesa/state_tracker/st_program.h| 3 +++ 4 files

[Mesa-dev] [PATCH 1/9] nir: add pass to lower atomic counters to SSBO

This is equivalent to what mesa/st does in glsl_to_tgsi. For most hw there isn't a particularly good reason to treat these differently. Signed-off-by: Rob Clark --- src/compiler/Makefile.sources| 1 + src/compiler/nir/nir.h | 1 +

[Mesa-dev] [PATCH 0/9] freedreno/a5xx: basic compute shader + SSBOs

Here is an early version of basic compute shader for a5xx. I've already pushed a bunch of cleanup/prep work for this series. In the later driver specific parts of this series I am still fixing a couple things. And I completely lie about image support (required for ARB_compute_shader), so it is

Re: [Mesa-dev] [RFC PATCH 03/26] glsl: introduce new base types for bindless samplers/images

On Tue, Apr 18, 2017 at 5:26 PM, Nicolai Hähnle wrote: > On 18.04.2017 21:49, Dave Airlie wrote: >> >> On 19 April 2017 at 05:30, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 04/18/2017 08:14 PM, Nicolai Hähnle wrote: On 11.04.2017

[Mesa-dev] [PATCH v02 1/3] genxml: Remove unused parameter.

'start' parameter from Group.emit_pack_function() is useless. Signed-off-by: Rafael Antognolli --- src/intel/genxml/gen_pack_header.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/genxml/gen_pack_header.py

[Mesa-dev] [PATCH v02 3/3] genxml: Make BLEND_STATE command support variable length array.

We need to emit BLEND_STATE, which size is 1 + 2 * nr_draw_buffers dwords (on gen8+), but the BLEND_STATE struct length is always 17. By marking it size 1, which is actually the size of the struct minus the BLEND_STATE_ENTRY's, we can emit a BLEND_STATE of variable number of entries. For gen6 and

[Mesa-dev] [PATCH v02 2/3] genxml: Fix python crash when no dwords are found.

If the 'dwords' dict is empty, max(dwords.keys()) throws an exception. This case could happen when we have an instruction that is only an array of other structs, with variable length. v2: - Add another clause for empty dwords and make it work with python 3 (Dylan) - Set the length to 0

Re: [Mesa-dev] [RFC PATCH 03/26] glsl: introduce new base types for bindless samplers/images

On 18.04.2017 21:49, Dave Airlie wrote: On 19 April 2017 at 05:30, Samuel Pitoiset wrote: On 04/18/2017 08:14 PM, Nicolai Hähnle wrote: On 11.04.2017 18:48, Samuel Pitoiset wrote: Bindless sampler/image types are really different from the existing sampler/image

Re: [Mesa-dev] [RFC 2/2] drm/i915: Select engines via class and instance in execbuffer2

On Tue, Apr 18, 2017 at 05:56:15PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Building on top of the previous patch which exported the concept > of engine classes and instances, we can also use this instead of > the current awkward engine selection uAPI. >

Re: [Mesa-dev] [RFC 1/2] drm/i915: Engine discovery uAPI

On Tue, Apr 18, 2017 at 05:56:14PM +0100, Tvrtko Ursulin wrote: > +enum drm_i915_gem_engine_class { > + DRM_I915_ENGINE_CLASS_OTHER = 0, > + DRM_I915_ENGINE_CLASS_RENDER = 1, > + DRM_I915_ENGINE_CLASS_COPY = 2, > + DRM_I915_ENGINE_CLASS_VIDEO_DECODE = 3, > +

[Mesa-dev] [PATCH] radv: start conditionalising vertex inputs. (v2)

From: Dave Airlie In practice this will probably just drop draw id in a few places. v2: just do draw_id for now. (Bas) it might be possible to do something more if we need it in the future. (nha) Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [RFC PATCH 03/26] glsl: introduce new base types for bindless samplers/images

On 19 April 2017 at 05:30, Samuel Pitoiset wrote: > > > On 04/18/2017 08:14 PM, Nicolai Hähnle wrote: >> >> On 11.04.2017 18:48, Samuel Pitoiset wrote: >>> >>> Bindless sampler/image types are really different from the existing >>> sampler/image types. They are

Re: [Mesa-dev] [PATCH 4/4] HACK: st/clover: automake: set -fpermissive for clover/llvm

Emil Velikov writes: > Without it the compiler will barf at us with dozens of errors like > the following. > > In file included from llvm/codegen/bitcode.cpp:34:0: > ./llvm/codegen.hpp:52:22: error: ‘<::’ cannot begin a template-argument list > [-fpermissive] >

Re: [Mesa-dev] [RFC PATCH 22/26] glsl: add ARB_bindless_texture conversions

On 04/18/2017 08:10 PM, Nicolai Hähnle wrote: On 11.04.2017 18:48, Samuel Pitoiset wrote: The ARB_bindless_texture spec says: "Modify Section 5.4.1, Conversion and Scalar Constructors, p. 60" (add the following constructors:) // In the following four constructors, the low 32

Re: [Mesa-dev] [RFC PATCH 03/26] glsl: introduce new base types for bindless samplers/images

On 04/18/2017 08:14 PM, Nicolai Hähnle wrote: On 11.04.2017 18:48, Samuel Pitoiset wrote: Bindless sampler/image types are really different from the existing sampler/image types. They are considered 64-bit unsigned integers, they can be declared as temporary, shader inputs/outputs and are

[Mesa-dev] [PATCH 2/4] winsys/sw/dri: don't use GNU void pointer arithmetic

From: Emil Velikov Resolves build issues like the following: src/gallium/winsys/sw/dri/dri_sw_winsys.c:203:31: error: pointer of type ‘void *’ used in arithmetic [-Werror=pointer-arith] data = dri_sw_dt->data + (dri_sw_dt->stride * box->y) + box->x * blsize;

[Mesa-dev] [PATCH 1/4] configure.ac: check require_basic_egl only if egl enabled

Fixes: 1ac40173c2a ("configure.ac: simplify EGL requirements for drivers dependent on EGL") Signed-off-by: Emil Velikov --- configure.ac | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index e1c60d842b5..957d15df8ca

[Mesa-dev] [PATCH 4/4] HACK: st/clover: automake: set -fpermissive for clover/llvm

Without it the compiler will barf at us with dozens of errors like the following. In file included from llvm/codegen/bitcode.cpp:34:0: ./llvm/codegen.hpp:52:22: error: ‘<::’ cannot begin a template-argument list [-fpermissive] ./llvm/codegen.hpp:52:22: note: ‘<:’ is an alternate spelling for

[Mesa-dev] [PATCH 3/4] st/mesa: automake: honour the vdpau header install location

From: Emil Velikov If VDPAU is installed in the non-default location, we'll fail to find the headers and error at build time. ../../src/gallium/include/state_tracker/vdpau_dmabuf.h:37:25: fatal error: vdpau/vdpau.h: No such file or directory #include

[Mesa-dev] [PATCH] intel/aubinator: Correctly read variable length structs.

Before this commit, when a group with count="0" is found, only one field is added to the struct representing the instruction. This causes only one entry to be printed by aubinator, for variable length groups. With this commit we "detect" that there's a variable length group (count="0") and store

Re: [Mesa-dev] [PATCH v3 2/4] vc4: Use a wrapper file to set VC4_BUILD_NEON instead of CFLAGS.

On Fri, Apr 14, 2017 at 12:47 PM, Eric Anholt wrote: > Android.mk was setting the flag across the entire driver, so we didn't > have non-NEON versions getting built. This was going to be a problem with > the next commit, when I start auto-detecting NEON support and use the >

Re: [Mesa-dev] [RFC PATCH 02/26] glsl: add ARB_bindless_texture enable

On 11.04.2017 18:48, Samuel Pitoiset wrote: This also adds the extension to the standalone GLSL compiler. Signed-off-by: Samuel Pitoiset Patches 1 & 2: Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/glsl_parser_extras.cpp | 1 +

Re: [Mesa-dev] Draft ARB_parallel_shader_compile RFC

On 18.04.2017 18:57, Marek Olšák wrote: We also have asynchronous compilation for optimized shaders (linking separate shaders etc.) using the same threaded queue as the initial compilations, and we can't let apps suppress the optimized ones. Good point. I think if the app says it doesn't want

Re: [Mesa-dev] [RFC PATCH 03/26] glsl: introduce new base types for bindless samplers/images

On 11.04.2017 18:48, Samuel Pitoiset wrote: Bindless sampler/image types are really different from the existing sampler/image types. They are considered 64-bit unsigned integers, they can be declared as temporary, shader inputs/outputs and are non-opaque types. For these reasons, it looks more

Re: [Mesa-dev] [RFC PATCH 22/26] glsl: add ARB_bindless_texture conversions

On 11.04.2017 18:48, Samuel Pitoiset wrote: The ARB_bindless_texture spec says: "Modify Section 5.4.1, Conversion and Scalar Constructors, p. 60" (add the following constructors:) // In the following four constructors, the low 32 bits of the sampler // type correspond to

Re: [Mesa-dev] [RFC PATCH 24/26] glsl: link bindless layout qualifiers

On 11.04.2017 18:48, Samuel Pitoiset wrote: The ARB_bindless_texture spec says: "If both bindless_sampler and bound_sampler, or bindless_image and bound_image, are declared at global scope in any compilation unit, a link- time error will be generated." Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] Draft ARB_parallel_shader_compile RFC

We also have asynchronous compilation for optimized shaders (linking separate shaders etc.) using the same threaded queue as the initial compilations, and we can't let apps suppress the optimized ones. Marek On Apr 18, 2017 1:08 PM, "Nicolai Hähnle" wrote: > On 17.04.2017

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 3/4] mesa: move glMultiDrawArrays to vbo and fix error handling

For 1-3: Reviewed-by: Marek Olšák Marek On Apr 18, 2017 3:35 PM, "Nicolai Hähnle" wrote: > From: Nicolai Hähnle > > When any count[i] is negative, we must skip all draws. > > Moving to vbo makes the subsequent change easier.

[Mesa-dev] [Bug 100668] No pixel formats with WGL_SWAP_UNDEFINED_ARB && WGL_DOUBLE_BUFFER_ARB=true

https://bugs.freedesktop.org/show_bug.cgi?id=100668 --- Comment #2 from Brian Paul --- Hi Charles, I compiled your test program and ran it with Mesa in a Windows VM and wglChoosePixelFormatARB failed to find a pixel format. But I found the exact same failure when I ran it

Re: [Mesa-dev] [PATCH 7/7] docs/releasing: added relevant people for build/check with MacOSX

That should be fine. If nothing else, I can help route questions to appropriate folks. =) Reviewed-by: Jeremy Sequoia > On Apr 18, 2017, at 02:34, Andres Gomez wrote: > > Jeremy, is it OK that I mention you as a reference for MacOSX in the > releasing

Re: [Mesa-dev] [PATCH v2 1/2] bin/get-{extra, fixes}-pick-list.sh: add support for ignore list

On 18 April 2017 at 16:16, Andres Gomez wrote: > On Mon, 2017-04-10 at 12:15 +0200, Juan A. Suarez Romero wrote: >> On Fri, 2017-04-07 at 19:38 +0100, Emil Velikov wrote: >> > On 7 April 2017 at 12:30, Juan A. Suarez Romero >> > wrote: >> > > Both scripts

Re: [Mesa-dev] [PATCH v2 1/2] bin/get-{extra, fixes}-pick-list.sh: add support for ignore list

On Mon, 2017-04-10 at 12:15 +0200, Juan A. Suarez Romero wrote: > On Fri, 2017-04-07 at 19:38 +0100, Emil Velikov wrote: > > On 7 April 2017 at 12:30, Juan A. Suarez Romero wrote: > > > Both scripts does not use a file with the commits to ignore. So if we > > > have handled

Re: [Mesa-dev] [PATCH] configure.ac: manually expand PKG_CHECK_VAR

On 04/18/2017 04:43 AM, Emil Velikov wrote: From: Emil Velikov The macro is introduced with pkgconfig v0.28 which isn't universally available. Thus it will error at configure stage. Cc: Brian Paul Reported-by: Brian Paul

Re: [Mesa-dev] [PATCH v4 0/3] asynchronous pbo transfer with glthread

All GL calls that might use libX11 must not be asynchronous within glthread. Marek On Apr 18, 2017 10:43 AM, "Gregory Hainaut" wrote: Hello Michel, As yes, I completely forgot about XInitThreads that must be it. I don't know how Nvidia manage to solve/force it.

[Mesa-dev] [PATCH v3 4/4] vbo: fix gl_DrawID handling in glMultiDrawArrays

From: Nicolai Hähnle Fixes a bug in KHR-GL45.shader_draw_parameters_tests.ShaderMultiDrawArraysParameters. Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Marek Olšák --- src/mesa/vbo/vbo_exec_array.c | 21 +++-- 1 file changed,

  1   2   >