[Mesa-dev] [PATCH 1/4] common: Check for extensions before resolving symbols

2017-05-02 Thread Daniel Stone
eglGetProcAddress is allowed to return any old garbage for symbols it doesn't know about. To avoid any mishaps, check for the appropriate extension presence (split into EGL client extension, EGL display extension, and GL extension, checks) before we look up any symbols through it. The walk

Re: [Mesa-dev] [PATCH 06/17] st/mesa: unify TCS, TES, GS st_*_program structures

2017-05-02 Thread Emil Velikov
Hi Marek, Nice work. Small question - have you considered subclassing st_{vp,fp,cp}_program around st_common_program? It should allow us to remove even more code :-) -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/2] mesa/varray: make use of dispatch KHR_no_error support

2017-05-02 Thread Nicolai Hähnle
I like it! Reviewed-by: Nicolai Hähnle On 27.04.2017 07:33, Timothy Arceri wrote: Make use of dispatch KHR_no_error support for varray functions. --- src/mapi/glapi/gen/ARB_vertex_attrib_64bit.xml | 2 +- src/mapi/glapi/gen/GL3x.xml| 3 +-

Re: [Mesa-dev] [PATCH 1/2] glapi: add KHR_no_error support to dispatch table generation

2017-05-02 Thread Nicolai Hähnle
On 27.04.2017 07:33, Timothy Arceri wrote: This will allows us to create no error versions of functions noted by a _no_error suffix. We also need to set a no_error attribute equal to "true" in the xml. --- src/mapi/glapi/gen/gl_XML.py | 5 + src/mapi/glapi/gen/gl_genexec.py | 19

[Mesa-dev] [PATCH] mesa/vbo: reduce prim array size

2017-05-02 Thread Bartosz Tomczyk
We always use only single element. --- src/mesa/vbo/vbo_exec_array.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index 15382eaaae..cbef610d96 100644 --- a/src/mesa/vbo/vbo_exec_array.c +++

Re: [Mesa-dev] [PATCH] c11/threads: rework Windows thrd_current() comment

2017-05-02 Thread Eric Engestrom
On Saturday, 2017-04-29 14:51:15 +0100, Emil Velikov wrote: > From: Emil Velikov > > Drop the misleading "will not match the one returned by thread_create" > hunk and provide more clarity as to what/why GetCurrentThread() isn't > the solution we're looking for. > >

Re: [Mesa-dev] [PATCH 1/2] glapi: add KHR_no_error support to dispatch table generation

2017-05-02 Thread Timothy Arceri
Ping. Any thoughts/comments on this approach? On 27/04/17 15:33, Timothy Arceri wrote: This will allows us to create no error versions of functions noted by a _no_error suffix. We also need to set a no_error attribute equal to "true" in the xml. --- src/mapi/glapi/gen/gl_XML.py | 5 +

Re: [Mesa-dev] [PATCH 1/3] mapi: replace mapi_table abstraction

2017-05-02 Thread Eric Engestrom
On Friday, 2017-04-28 13:15:19 +0100, Emil Velikov wrote: > From: Emil Velikov > > Replace all instances of mapi_table with the actual struct _glapi_table. > The former may have been needed when the OpenVG was around. But since > that one is long gone, there' no point

Re: [Mesa-dev] [PATCH] radv/wsi: report presentation error per image request

2017-05-02 Thread Daniel Stone
On 2 May 2017 at 04:41, Dave Airlie wrote: > This ports > 0fcb92c17dee681bd39c08ddf0abc358a27337c7 > anv: wsi: report presentation error per image request > > This fixes: > dEQP-VK.wsi.xlib.incremental_present.scale_none.* Reviewed-by: Daniel Stone

Re: [Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

2017-05-02 Thread Emil Velikov
On 2 May 2017 at 09:32, Emil Velikov wrote: > Hi Rafael, > > On 2 May 2017 at 02:43, Rafael Antognolli wrote: >> We need to use some enums inside genX_state_upload.c, but including the >> whole header will cause several conflicts between

Re: [Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

2017-05-02 Thread Emil Velikov
Hi Rafael, On 2 May 2017 at 02:43, Rafael Antognolli wrote: > We need to use some enums inside genX_state_upload.c, but including the > whole header will cause several conflicts between things defined in this > header and the genxml auto-generated headers. > > So

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] i965/vec4: fix register width for DF VGRF and UNIFORM

2017-05-02 Thread Samuel Iglesias Gonsálvez
On Mon, 2017-05-01 at 14:55 +0200, Samuel Iglesias Gonsálvez wrote: > El Viernes, 28 de abril de 2017 16:27:56 Francisco Jerez escribió: > > Samuel Iglesias Gonsálvez writes: > > > On gen7, the swizzles used in DF align16 instructions works for > > > element > > > size of 32

Re: [Mesa-dev] [PATCH] anv/query: handle more cases of 'out of host memory'

2017-05-02 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Wed, 2017-04-26 at 09:03 +0200, Iago Toral Quiroga wrote: > --- >  src/intel/vulkan/genX_query.c | 10 ++ >  1 file changed, 10 insertions(+) > > diff --git a/src/intel/vulkan/genX_query.c > b/src/intel/vulkan/genX_query.c >

Re: [Mesa-dev] [PATCH 3/3] ac: eliminate duplicated VS exports

2017-05-02 Thread Dave Airlie
On 1 May 2017 at 22:43, Marek Olšák wrote: > From: Marek Olšák > > Only very few shaders have them (from 48486 shaders): For the series: Reviewed-by: Dave Airlie (you might want to stop radeonsi running this pass on tess ctrl if you

Re: [Mesa-dev] [PATCH] anv/query: handle more cases of 'out of host memory'

2017-05-02 Thread Iago Toral
Can anyone review this one? On Wed, 2017-04-26 at 09:03 +0200, Iago Toral Quiroga wrote: > --- >  src/intel/vulkan/genX_query.c | 10 ++ >  1 file changed, 10 insertions(+) > > diff --git a/src/intel/vulkan/genX_query.c > b/src/intel/vulkan/genX_query.c > index 126431b..22de3c3 100644 >

<    1   2   3