Re: [Mesa-dev] [PATCH] i965/vec4: Delete the system value infastructure

On Friday, May 5, 2017 3:03:52 PM PDT Jason Ekstrand wrote: > The only thing still using it is INVOCATION_ID for geometry shaders. > That's easily enough inlined into the nir_intrinsic_load_invocation_id > handling code. And good riddance :) Much simpler now. Reviewed-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH] st/dri: Add fence extension to SW path

Hi Gurchetan, On 5 May 2017 at 20:56, Gurchetan Singh wrote: > From: Gurchetan Singh > > Use the same fence implementation for drisw.c as dri2.c by > making dri2FenceExtension an external variable. This is desirable > for synchronization

Re: [Mesa-dev] [PATCH 2/3] i965: Port 3DSTATE_VF to genxml and simplify the implementation.

On Friday, May 5, 2017 4:06:01 AM PDT Emil Velikov wrote: > On 4 May 2017 at 18:51, Kenneth Graunke wrote: > > On Thursday, May 4, 2017 8:51:43 AM PDT Emil Velikov wrote: > >> Hi Ken, > >> > >> On 4 May 2017 at 16:13, Kenneth Graunke wrote: > >> > >>

Re: [Mesa-dev] [PATCH] radeon: automake: remove unneeded elf Cflags/Libs

Reviewed-by: Marek Olšák Marek On Thu, May 4, 2017 at 5:19 PM, Emil Velikov wrote: > From: Emil Velikov > > No longer required as of commit d90bf4ef3e1 ("radeon: remove unused > radeon_elf_util.{c,h}") > > Fixes:

Re: [Mesa-dev] [PATCH 9/9] i965/vec4: Use NIR to do GS input remapping

On Thursday, May 4, 2017 7:11:47 PM PDT Jason Ekstrand wrote: [snip] > diff --git a/src/intel/compiler/brw_vec4.cpp b/src/intel/compiler/brw_vec4.cpp > index b387321..ad92951 100644 > --- a/src/intel/compiler/brw_vec4.cpp > +++ b/src/intel/compiler/brw_vec4.cpp > @@ -1693,50 +1693,6 @@

Re: [Mesa-dev] [PATCH 6/9] i965/vec4: Use NIR remapping for VS attributes

On Friday, May 5, 2017 12:31:40 PM PDT Jason Ekstrand wrote: > On Fri, May 5, 2017 at 12:38 AM, Alejandro Piñeiro > wrote: > > > On 05/05/17 04:11, Jason Ekstrand wrote: > > > We have to pass inputs_read through from prog_data because we may add an > > > edge flag on old

Re: [Mesa-dev] [PATCH 4/9] i965/fs: Lower gl_VertexID and friends to inputs at the NIR level

On Thursday, May 4, 2017 7:11:42 PM PDT Jason Ekstrand wrote: > NIR calls these system values but they come in from the VF unit as > vertex data. It's terribly convenient to just be able to treat them as > such in the back-end. > --- > src/intel/compiler/brw_fs.h | 1 - >

Re: [Mesa-dev] [PATCH] configure.ac: Also match -androideabi tuple

On Fri 05 May 2017, Nicolas Boichat wrote: > From: Nicolas Boichat > > On ARM Android platforms, the host_os tuple should be linux-androideabi, > so let's match both -android and -androideabi (or any other > -android* tuple) to determine if we should do an Android build. >

Re: [Mesa-dev] [PATCH] radv: always free nir shaders from modules on stack

Reviewed-by: Bas Nieuwenhuizen On Tue, May 2, 2017 at 10:05 PM, Grazvydas Ignotas wrote: > valgrind reports them as leaked, and I could not find anything making a > copy of the nir pointer. Also, radv_device_init_meta_blit_color() is > already

Re: [Mesa-dev] [PATCH 7/7] egl: use designated initializers

I was going to write a similar patch series today, until I found yours :) Thanks for cleaning this up. By the way, I have some i965 Android logging fixups I need to send to the list. With the for-loop conditional fixed, the series is Reviewed-by: Chad Versace

[Mesa-dev] [PATCH] i965/vec4: Delete the system value infastructure

The only thing still using it is INVOCATION_ID for geometry shaders. That's easily enough inlined into the nir_intrinsic_load_invocation_id handling code. --- src/intel/compiler/brw_vec4.h | 5 src/intel/compiler/brw_vec4_gs_nir.cpp | 32 -

[Mesa-dev] [PATCH] i965/vec4: Delete the system value infastructure

--- src/intel/compiler/brw_vec4.h | 5 src/intel/compiler/brw_vec4_gs_nir.cpp | 32 - src/intel/compiler/brw_vec4_gs_visitor.cpp | 20 src/intel/compiler/brw_vec4_gs_visitor.h | 2 -- src/intel/compiler/brw_vec4_nir.cpp|

[Mesa-dev] [Bug 100951] vkcube fails with vkMapMemory failed

https://bugs.freedesktop.org/show_bug.cgi?id=100951 Bug ID: 100951 Summary: vkcube fails with vkMapMemory failed Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity:

[Mesa-dev] [Bug 100948] Please add an ssh account, fdo username: rantogno

https://bugs.freedesktop.org/show_bug.cgi?id=100948 --- Comment #2 from Kenneth Graunke --- FWIW, Rafael works at Intel on the i965 team and has 46 Mesa patches upstream. I suggested he apply for a freedesktop account and Mesa commit access. -- You are receiving this

[Mesa-dev] [PATCH] st/dri: Add fence extension to SW path

From: Gurchetan Singh Use the same fence implementation for drisw.c as dri2.c by making dri2FenceExtension an external variable. This is desirable for synchronization in virtual machines. --- src/gallium/state_trackers/dri/dri2.c | 2 +-

[Mesa-dev] [Bug 100708] Trine 2 doesn't start on radeonsi on mesa 17

https://bugs.freedesktop.org/show_bug.cgi?id=100708 --- Comment #8 from Nikita Krupenko --- How about revert that commit? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] anv/allocator: Fix build if valgrind is not found.

There's no >_vg_ptr in that case. Signed-off-by: Rafael Antognolli Cc: Jason Ekstrand --- src/intel/vulkan/anv_allocator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_allocator.c

Re: [Mesa-dev] [PATCH] anv/allocator: Only write to _vg_ptr if we have valgrind

On Fri 05 May 2017, Jason Ekstrand wrote: > This fixes the build when not building against valgrind headers. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100945 > --- > src/intel/vulkan/anv_allocator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Chad

Re: [Mesa-dev] [PATCH] anv: Always set the reloc value to match the presumed_offset

On Fri, May 5, 2017 at 5:09 AM, Chris Wilson wrote: > It is a requirement, not just of using the NO_RELOC mode, that all > relocation values in the execobjects match their reloc.presumed_offset, > as the kernel will skip performing *any* relocation if the

Re: [Mesa-dev] [PATCH 6/9] i965/vec4: Use NIR remapping for VS attributes

On Fri, May 5, 2017 at 12:38 AM, Alejandro Piñeiro wrote: > On 05/05/17 04:11, Jason Ekstrand wrote: > > We have to pass inputs_read through from prog_data because we may add an > > edge flag on old platforms. > > Well, the previous code was using nir->info->inputs_read. So

[Mesa-dev] [PATCH] egl: Fix -Wint-to-pointer-cast

main/egldisplay.c: In function '_eglParseX11DisplayAttribList': main/egldisplay.c:491:38: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] display->Options.Platform = (void *)value; The fix: cast to uinptr_t before void*.

Re: [Mesa-dev] [RFC PATCH 04/17] include/pipe: Store the byte-size of a SPIR-V binary

Pierre Moreau writes: > Besides parsing all the opcodes until reaching the EOF character, there > is no way to compute the size of a SPIR-V binary. Therefore, it is > easier to pass it along the SPIR-V binary in pipe_compute_state. > LLVM IR programs use

Re: [Mesa-dev] [PATCH 00/18] anv: Rework the allocation data structures

Sorry about that. It only fails if you *don't* build against valgrind headers. Since my dev machine and our CI are both set up with valgrind support, I didn't catch it. I've sent a patch to the list to fix this. --Jason On Fri, May 5, 2017 at 5:36 AM, Mike Lothian wrote:

Re: [Mesa-dev] [PATCH 9/9] i965/vec4: Use NIR to do GS input remapping

On Fri, May 5, 2017 at 1:04 AM, Alejandro Piñeiro wrote: > On 05/05/17 04:11, Jason Ekstrand wrote: > > We're already doing this in the FS back-end. This just does the same > > thing in the vec4 back-end. > > --- > > src/intel/compiler/brw_nir.c | 3 -- > >

Re: [Mesa-dev] [PATCH 0/2] anv/i965: drop libdrm dependency completely

On Fri, May 5, 2017 at 8:32 AM, Emil Velikov wrote: > On 4 May 2017 at 21:56, Jason Ekstrand wrote: > > On Thu, May 4, 2017 at 12:21 PM, Kristian Høgsberg > > wrote: > >> > >> On Thu, May 4, 2017 at 11:43 AM, Lionel

[Mesa-dev] [PATCH] anv/allocator: Only write to _vg_ptr if we have valgrind

This fixes the build when not building against valgrind headers. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100945 --- src/intel/vulkan/anv_allocator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_allocator.c

Re: [Mesa-dev] [PATCH 8/9] i965/fs: Move remapping of gl_PointSize to the NIR level

On Fri, May 5, 2017 at 12:49 AM, Alejandro Piñeiro wrote: > On 05/05/17 04:11, Jason Ekstrand wrote: > > --- > > src/intel/compiler/brw_fs_nir.cpp | 26 +++--- > > src/intel/compiler/brw_nir.c | 22 +++--- > > 2 files changed, 22

[Mesa-dev] [PATCH 1/2] i965: Update gen6_depth_stencil_state to use genX macro.

While moving depth stencil state to use genxml, this one was left behind. Signed-off-by: Rafael Antognolli Cc: "Pohjolainen, Topi" --- src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 2/2] i965/genxml: Mostly style fixes for emit_vertices code.

Several issues were caught on review after the original patch landed. This commit fixes them. Signed-off-by: Rafael Antognolli Cc: "Pohjolainen, Topi" --- src/mesa/drivers/dri/i965/genX_state_upload.c | 49 +++ 1

[Mesa-dev] [Bug 100948] Please add an ssh account, fdo username: rantogno

https://bugs.freedesktop.org/show_bug.cgi?id=100948 --- Comment #1 from Rafael Antognolli --- Created attachment 131231 --> https://bugs.freedesktop.org/attachment.cgi?id=131231=edit SSH pub key for rantogno -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 100948] Please add an ssh account, fdo username: rantogno

https://bugs.freedesktop.org/show_bug.cgi?id=100948 Bug ID: 100948 Summary: Please add an ssh account, fdo username: rantogno Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW

Re: [Mesa-dev] [PATCH v2 2/2] anv/i965: drop libdrm_intel dependency completely

On 5 May 2017 at 15:36, Daniel Vetter wrote: > On Thu, May 04, 2017 at 12:19:22PM -0700, Lionel Landwerlin wrote: >> With Ken's work to drop the library dependency on libdrm_intel, we now >> only depend on libdrm_intel for the kernel uapi headers it provides. >> It seems like

Re: [Mesa-dev] [PATCH 1/2] radeonsi: split per-patch from per-vertex indices

Reviewed-by: Marek Olšák Marek On Wed, May 3, 2017 at 3:54 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Make it a bit clearer that the index spaces are logically seperate by > having them defined in different functions.

Re: [Mesa-dev] [PATCH 2/2] radeonsi: get rid of secondary input/output word

Hi Nicolai, This might break Nine, because it uses GENERIC indices greater than 31. The idea is that we support 32, but allow indices up to 60 as long as the number of declared varyings is <= 32. Axel can probably answer which maximum GENERIC index we can normally expect. Marek On Wed, May 3,

Re: [Mesa-dev] [PATCH v3 0/4] Disable glthread if libX11 isn't thread-safe

On Fri, 5 May 2017 18:17:22 +0100 Emil Velikov wrote: > On 5 May 2017 at 17:58, gregory hainaut wrote: > > On Fri, 5 May 2017 17:45:01 +0200 > > Axel Davy wrote: > > > [...] > > > > Hello Axel, > > > > Yes it

Re: [Mesa-dev] [PATCH v3 0/4] Disable glthread if libX11 isn't thread-safe

On 5 May 2017 at 17:58, gregory hainaut wrote: > On Fri, 5 May 2017 17:45:01 +0200 > Axel Davy wrote: > >> Hi, >> >> There should be very few X11 calls while rendering (basically only at >> the beginning or end of a frame). >> >> Why not just

Re: [Mesa-dev] [PATCH 7/8] android: support creating texture from gralloc buffer

On Mon, May 1, 2017 at 9:55 AM, Tomasz Figa wrote: > On Mon, May 1, 2017 at 11:17 PM, Mauro Rossi wrote: >> Hi all, >> >> another try to merge android swrast patches in mesa 17.1 or mesa-dev >> if they are somehow considered useful for android. I would

Re: [Mesa-dev] [PATCH] i965: make emit_dwords non-static and reuse it in blorp

On 5 May 2017 at 17:20, Rafael Antognolli wrote: > On Fri, May 05, 2017 at 11:47:09AM +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Signed-off-by: Emil Velikov >> --- >>

Re: [Mesa-dev] [PATCH 1/3] mesa: Simplify _mesa_primitive_restart_index().

Since the function is so small, perhaps it would make sense to move it into a header file. Marek On Fri, May 5, 2017 at 7:06 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Thu, May 4, 2017 at 5:13 PM, Kenneth Graunke

Re: [Mesa-dev] [PATCH 1/3] mesa: Simplify _mesa_primitive_restart_index().

Reviewed-by: Marek Olšák Marek On Thu, May 4, 2017 at 5:13 PM, Kenneth Graunke wrote: > We can use a simple shift equation rather than a switch statement. > --- > src/mesa/main/varray.c | 12 ++-- > 1 file changed, 2 insertions(+), 10

Re: [Mesa-dev] [PATCH v2 20/27] st/omx: add DRI3 support

On 05/05/2017 07:45 AM, Christian König wrote: Am 04.05.2017 um 18:33 schrieb Emil Velikov: From: Emil Velikov Cc: Christian König Signed-off-by: Emil Velikov --- UNTESTED. Looks sane to me, but what

Re: [Mesa-dev] [PATCH v3 0/4] Disable glthread if libX11 isn't thread-safe

On Fri, 5 May 2017 17:45:01 +0200 Axel Davy wrote: > Hi, > > There should be very few X11 calls while rendering (basically only at > the beginning or end of a frame). > > Why not just always run these calls in the main thread (and wait for > glthread work to finish)

Re: [Mesa-dev] [AppVeyor] mesa master #4271 failed

On 5 May 2017 at 17:51, Daniel Stone wrote: > Hi, > > On 5 May 2017 at 17:38, AppVeyor wrote: >> Build mesa 4271 failed >> >> Commit 8b8af19065 by Daniel Stone on 5/3/2017 8:38 AM: >> i965: Set modifier for imported and duplicated images [...] > > I

Re: [Mesa-dev] [AppVeyor] mesa master #4271 failed

Hi, On 5 May 2017 at 17:38, AppVeyor wrote: > Build mesa 4271 failed > > Commit 8b8af19065 by Daniel Stone on 5/3/2017 8:38 AM: > i965: Set modifier for imported and duplicated images [...] I was worried I'd broken the build, but I'm going to claim this isn't my fault:

[Mesa-dev] [PATCH v2 6/6] egl/wayland: Use per-surface event queues

During display initialisation, we need a separate event queue to handle the registry events, which is correctly handled. But we also need separate per-surface event queues to handle swapchain-related events, such as surface frame events and buffer release events. This avoids two surfaces from the

[Mesa-dev] [PATCH v2 0/6] Wayland proxy wrapper fixes

Hi, This series uses proxy wrappers and separate event queues through the Wayland WSI and EGL implementations. EGL already had a partial fix in that it had a per-display event queue, but this was not enough to protect multiple surfaces on a single display being used simultaneously. WSI had a

[Mesa-dev] [PATCH v2 3/6] vulkan/wsi/wayland: Use per-display event queue

Calling random callbacks on the display's event queue is hostile, as we may call into client code when it least expects it. Create our own event queue, one per wsi_wl_display, and use that for the registry. Signed-off-by: Daniel Stone Cc: mesa-sta...@lists.freedesktop.org

[Mesa-dev] [PATCH v2 5/6] egl/wayland: Don't open-code roundtrip

wl_display_roundtrip_queue() exists and can replace roundtrip(). Signed-off-by: Daniel Stone Cc: mesa-sta...@lists.freedesktop.lrg --- src/egl/drivers/dri2/platform_wayland.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git

[Mesa-dev] [PATCH v2 2/6] vulkan/wsi/wayland: Remove roundtrip when creating image

There's no need to call wl_display_roundtrip() after trying to create a buffer through wl_drm; if it succeeds then everything is fine, and if it fails, then we get a fatal protocol error so can't recover anyway. Additionally, doing a roundtrip on the default / main application queue, is

[Mesa-dev] [PATCH v2 1/6] vulkan: Fix Wayland uninitialised registry

Untangle the exit cleanup paths so we don't try to use the registry variable before it's been initialised. Signed-off-by: Daniel Stone Cc: mesa-sta...@lists.freedesktop.org --- src/vulkan/wsi/wsi_common_wayland.c | 9 + 1 file changed, 5 insertions(+), 4

[Mesa-dev] [PATCH v2 4/6] vulkan/wsi/wayland: Use proxy wrappers for swapchain

Though most swapchain operations used a queue, they were racy in that the object was created with the queue only set later, meaning that its event could potentially be dispatched from the default queue in between these two steps. Use proxy wrappers to avoid this race, also assigning wl_buffers

[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

https://bugs.freedesktop.org/show_bug.cgi?id=100690 Kenneth Graunke changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 4/4] vulkan/wsi/wayland: Use proxy wrappers for swapchain

Hi Emil, On 4 May 2017 at 13:21, Emil Velikov wrote: >> + struct wl_drm * drm_wrapper; >> > Based on a quick skim 3/4 aligns with commit > 36b9976e1f99e8070c67cb8a255793939db77d02. > At the same time we don't seem to have a drm_wrapper in

Re: [Mesa-dev] [PATCH] radeonsi: apply the tess+GS hang workaround to Polaris12 as well

On 05.05.2017 17:14, Marek Olšák wrote: From: Marek Olšák Cc: 17.1 Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_state_draw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Mesa-dev] [AppVeyor] mesa master #4271 failed

Build mesa 4271 failed Commit 8b8af19065 by Daniel Stone on 5/3/2017 8:38 AM: i965: Set modifier for imported and duplicated images\n\nWhen a buffer is being created from FD or GEM flink import, the current\nAPI makes no provision for passing modifier

Re: [Mesa-dev] [PATCH v2 1/2] i965: Use helper function for modifier -> tiling

Hi Emil, On 4 May 2017 at 15:14, Emil Velikov wrote: > On 4 May 2017 at 14:43, Daniel Stone wrote: >> IOW, there is no change as far as I can see, but perhaps for the >> meantime, we could use an unreachable() at the bottom of >>

Re: [Mesa-dev] [PATCH v4 21/31] glsl: allow bindless samplers/images to be l-values

On 05.05.2017 09:34, Samuel Pitoiset wrote: From section 4.1.7 of the ARB_bindless_texture spec: "Samplers can be used as l-values, so can be assigned into and used as "out" and "inout" function parameters." From section 4.1.X of the ARB_bindless_texture spec: "Images can be used as

[Mesa-dev] [PATCH] Revert "mesa: Require mipmap completeness for glCopyImageSubData(), sometimes."

This reverts commit c5bf7cb52942cb7df9f5d73746ffbf3c102d12cc. This broke rendering in "Total War: WARHAMMER", which uses a single level RGBA_UINT32 texture and the default filter modes of GL_LINEAR and GL_NEAREST_MIPMAP_LINEAR. However, the texture max level is 0, so it is actually mipmap

[Mesa-dev] [Bug 100928] exported opengl function in generated dll was mangled when building with msvc 2015 Update 3

https://bugs.freedesktop.org/show_bug.cgi?id=100928 --- Comment #2 from George Kyriazis --- There seems to be multiple issues here. First of all, swr driver is not buildable with machine=x86 (only compile with 64-bit builds). I don't understand how you managed to

Re: [Mesa-dev] [PATCH] i965: make emit_dwords non-static and reuse it in blorp

On Fri, May 05, 2017 at 11:47:09AM +0100, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/mesa/drivers/dri/i965/brw_state.h | 1 + > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 6 + >

Re: [Mesa-dev] [PATCH v03 35/38] i965: Port gen4+ emit vertices code to genxml.

On Fri, May 05, 2017 at 08:38:53AM +0300, Pohjolainen, Topi wrote: > On Thu, May 04, 2017 at 12:16:53PM -0700, Rafael Antognolli wrote: > > On Thu, May 04, 2017 at 11:19:24AM +0300, Pohjolainen, Topi wrote: > > > On Mon, May 01, 2017 at 06:43:23PM -0700, Rafael Antognolli wrote: > > > > Some code

Re: [Mesa-dev] [PATCH 0/2] anv/i965: drop libdrm dependency completely

On 4 May 2017 at 19:43, Lionel Landwerlin wrote: > On 04/05/17 07:52, Emil Velikov wrote: >> >> On 4 May 2017 at 14:46, Daniel Vetter wrote: >>> >>> On Thu, Apr 27, 2017 at 10:58:42AM -0700, Lionel Landwerlin wrote: On 27/04/17 08:20,

Re: [Mesa-dev] [PATCH] radeonsi: fix build with GCC 4.8

Reviewed-by: Marek Olšák Marek On Fri, May 5, 2017 at 2:15 PM, Samuel Pitoiset wrote: > Fixes: 7088b655e8 ("radeonsi: constify a bunch of the perfcounter structs.") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100937 > Signed-off-by:

Re: [Mesa-dev] [PATCH] radeonsi: apply the tess+GS hang workaround to Polaris12 as well

On Fri, May 5, 2017 at 11:14 AM, Marek Olšák wrote: > From: Marek Olšák > > Cc: 17.1 Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_state_draw.c | 3 ++- > 1 file changed,

[Mesa-dev] [PATCH v3 2/4] glx: implement __DRIbackgroundCallableExtension.isThreadSafe

v2: bump version v3: Add code comment s/IsGlThread/IsThread/ (and variation) Signed-off-by: Gregory Hainaut --- src/glx/dri2_glx.c | 15 ++- src/glx/dri3_glx.c | 15 ++- 2 files changed, 28 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v3 3/4] egl: implement __DRIbackgroundCallableExtension.isThreadSafe

v2: bump version v3: Add code comment s/IsGlThread/IsThread/ (and variation) Include X11/Xlibint.h protected by ifdef Signed-off-by: Gregory Hainaut --- src/egl/drivers/dri2/egl_dri2.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH v3 0/4] Disable glthread if libX11 isn't thread-safe

Hello Mesa developers, Following the discussion from https://lists.freedesktop.org/archives/mesa-dev/2017-April/153137.html A check was added to ensure that X11 display can be locked. It should be enough to ensure thread safety between X11 and glthread. I also did the check on DRI3 as I'm not

[Mesa-dev] [PATCH v3 4/4] glthread/gallium: require safe_glthread to start glthread

Print an error message for the user if the requirement isn't met, or we're not thread safe. v2: based on Nicolai feedbacks Check the DRI extension version v3: based on Emil feedbacks improve commit and error messages. use backgroundCallable variable to improve readability Signed-off-by: Gregory

[Mesa-dev] [PATCH v3 1/4] dri: Extend __DRIbackgroundCallableExtensionRec to include a callback that checks for thread safety

DRI-drivers could call Xlib functions, for example to allocate a new back buffer. When glthread is enabled, the driver runs mostly on a separate thread. Therefore we need to guarantee the thread safety between libX11 calls from the applications (not aware of the extra thread) and the ones from

Re: [Mesa-dev] [PATCH 0/2] anv/i965: drop libdrm dependency completely

On 4 May 2017 at 21:56, Jason Ekstrand wrote: > On Thu, May 4, 2017 at 12:21 PM, Kristian Høgsberg > wrote: >> >> On Thu, May 4, 2017 at 11:43 AM, Lionel Landwerlin >> wrote: >> > On 04/05/17 07:52, Emil Velikov wrote: >>

Re: [Mesa-dev] [PATCH 2/2] nir: add pass to lower atomic counters to SSBO

On 05/05/17 12:07, Rob Clark wrote: On Fri, May 5, 2017 at 4:22 AM, Andres Gomez wrote: Rob, I believe this is causing a linking failure in the Windows scons build: https://ci.appveyor.com/project/AndresGomez/mesa/build/321 Creating library

Re: [Mesa-dev] [PATCH 0/2] anv/i965: drop libdrm dependency completely

On 4 May 2017 at 17:27, Kristian Høgsberg wrote: > On Thu, May 4, 2017 at 7:26 AM, Emil Velikov wrote: >> On 27 April 2017 at 16:20, Eric Anholt wrote: >>> Emil Velikov writes: >>> On 25 April 2017

Re: [Mesa-dev] [PATCH] gallivm: Make sure module has the correct data layout when pass manager runs

Same here. Reviewed-by: Jose Fonseca On 05/05/17 16:16, Roland Scheidegger wrote: Makes sense to me. Reviewed-by: Roland Scheidegger Am 05.05.2017 um 03:25 schrieb Tom Stellard: The datalayout for modules was purposely not being set in order to work

Re: [Mesa-dev] [PATCH] gallivm: Make sure module has the correct data layout when pass manager runs

Makes sense to me. Reviewed-by: Roland Scheidegger Am 05.05.2017 um 03:25 schrieb Tom Stellard: > The datalayout for modules was purposely not being set in order to work around > the fact that the ExecutionEngine requires that the module's datalayout > matches the datalayout

[Mesa-dev] [PATCH] radeonsi: apply the tess+GS hang workaround to Polaris12 as well

From: Marek Olšák Cc: 17.1 --- src/gallium/drivers/radeonsi/si_state_draw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c

[Mesa-dev] [PATCH v2 1/2] bin: use tabs for coding style on *.sh files

v2: Instead of changing *.sh, adapt the editorconfig file (Emil). Signed-off-by: Andres Gomez --- bin/.editorconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bin/.editorconfig b/bin/.editorconfig index b9a948f405..ef92655823 100644 ---

Re: [Mesa-dev] [PATCH RFC 3/4] st/dri: Allow gallium drivers to turn off two GLX extensions

On 05/05/2017 04:02 PM, Thomas Hellstrom wrote: > Allow gallium drivers to turn off GLX_EXT_buffer_age and > GLX_OML_sync_control if needed, using driconf. > > Signed-off-by: Thomas Hellstrom > --- > include/GL/internal/dri_interface.h | 4 +++- >

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: make sure resource file for samplers is PROGRAM_SAMPLER

On 05/05/2017 04:35 PM, Ilia Mirkin wrote: On May 5, 2017 9:36 AM, "Samuel Pitoiset" > wrote: Similar to how image resources are handled. That way we are sure that inst->resource.file is PROGRAM_SAMPLER for "bound"

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: make sure resource file for samplers is PROGRAM_SAMPLER

On May 5, 2017 9:36 AM, "Samuel Pitoiset" wrote: Similar to how image resources are handled. That way we are sure that inst->resource.file is PROGRAM_SAMPLER for "bound" samplers. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH 6/7] egl: drop unneeded sentinel from level_strings[]

On 4 May 2017 22:26:28 BST, Bartosz Tomczyk wrote: >It should be: > >i < ARRAY_SIZE(level_strings) > Indeed :) With this, the series is Reviewed-by: Eric Engestrom Cheers, Eric > >On 04.05.2017 20:47, Emil Velikov wrote: >> From: Emil

[Mesa-dev] [PATCH RFC 2/4] dri: Optionally turn off a couple of GLX extensions based on driconf options

With GLX_EXT_buffer_age turned on, gnome-shell will use full-screen damage with GLX, which severely hurts performance with architectures that emulate page-flips with copies. Like vmware. We would like to be able to turn off that extension. Similarly, typically the GLX_OML_sync_control doesn't make

[Mesa-dev] [PATCH RFC 3/4] st/dri: Allow gallium drivers to turn off two GLX extensions

Allow gallium drivers to turn off GLX_EXT_buffer_age and GLX_OML_sync_control if needed, using driconf. Signed-off-by: Thomas Hellstrom --- include/GL/internal/dri_interface.h | 4 +++- src/gallium/state_trackers/dri/dri_screen.c | 2 ++ 2 files changed, 5

[Mesa-dev] [PATCH RFC 4/4] dri: Turn of a couple of glx extensions for gnome-shell on vmwgfx.

Increases performance on vmwgfx since we're avoiding full buffer damage and since we can't sync to vertical retrace anyway. Signed-off-by: Thomas Hellstrom --- src/mesa/drivers/dri/common/drirc | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Mesa-dev] [PATCH RFC 0/4] Don't lose speed with dri3 on virtual drivers

With dri3 and certain levels of dri2, the glx-dri layer automatically turn on some GLX extensions whose functionality is mostly emulated on virtual drivers. This causes a performance loss and increased latency. Two such examples are GLX_EXT_buffer_age and GLX_OML_sync_control. We'd like the

[Mesa-dev] [PATCH RFC 1/4] st/dri: Allow dri users to query also driver options

There will be situations where we want to control, for example, the GLX behaviour based on applications and drivers. So allow DRI users access to the driver options. Signed-off-by: Thomas Hellstrom --- src/gallium/state_trackers/dri/dri2.c | 65

Re: [Mesa-dev] [PATCH 1/2] bin/*sh: honor editorconfig formatting

On 5 May 2017 at 14:09, Andres Gomez wrote: > Signed-off-by: Andres Gomez > --- > bin/bugzilla_mesa.sh | 14 - > bin/get-extra-pick-list.sh | 48 ++-- > bin/get-fixes-pick-list.sh | 78 >

[Mesa-dev] [PATCH] st/glsl_to_tgsi: make sure resource file for samplers is PROGRAM_SAMPLER

Similar to how image resources are handled. That way we are sure that inst->resource.file is PROGRAM_SAMPLER for "bound" samplers. Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 18 +- 1 file changed, 9 insertions(+), 9

[Mesa-dev] [PATCH 2/2] bin/*py: honor editorconfig formatting

Signed-off-by: Andres Gomez --- bin/perf-annotate-jit.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/perf-annotate-jit.py b/bin/perf-annotate-jit.py index 746434008f..4f05585bd4 100755 --- a/bin/perf-annotate-jit.py +++

[Mesa-dev] [PATCH 0/2] bin: honor editorconfig formatting

Just a series to correct the formating under bin/* Andres Gomez (2): bin/*sh: honor editorconfig formatting bin/*py: honor editorconfig formatting bin/bugzilla_mesa.sh | 14 - bin/get-extra-pick-list.sh | 48 ++-- bin/get-fixes-pick-list.sh | 78

[Mesa-dev] [PATCH 1/2] bin/*sh: honor editorconfig formatting

Signed-off-by: Andres Gomez --- bin/bugzilla_mesa.sh | 14 - bin/get-extra-pick-list.sh | 48 ++-- bin/get-fixes-pick-list.sh | 78 +++--- bin/get-pick-list.sh | 32 +--

Re: [Mesa-dev] [PATCH 2/7] egl: fold Android logger into main/

On 4 May 2017 at 20:17, Rob Herring wrote: > On Thu, May 4, 2017 at 1:46 PM, Emil Velikov wrote: >> From: Emil Velikov >> >> Will allow us to greatly simplify a lot of the code in egllog.c > > Okay, because on its own, this

Re: [Mesa-dev] [PATCH 00/18] anv: Rework the allocation data structures

I'm seeing the following failure with GCC 7.1: /var/tmp/portage/media-libs/mesa-/work/mesa-/src/intel/vulkan/anv_allocator.c: In function ‘anv_state_stream_alloc’: /var/tmp/portage/media-libs/mesa-/work/mesa-/src/intel/vulkan/anv_allocator.c:930:28: error: ‘struct

Re: [Mesa-dev] [PATCH v2 12/27] auxiliary/vl: use vl_*_screen_create stubs when building w/o platform

Am 05.05.2017 um 14:11 schrieb Emil Velikov: On 5 May 2017 at 12:37, Christian König wrote: Am 05.05.2017 um 13:23 schrieb Emil Velikov: On 5 May 2017 at 10:30, Christian König wrote: Am 04.05.2017 um 18:33 schrieb Emil Velikov: From:

Re: [Mesa-dev] [PATCH v2 20/27] st/omx: add DRI3 support

Am 04.05.2017 um 18:33 schrieb Emil Velikov: From: Emil Velikov Cc: Christian König Signed-off-by: Emil Velikov --- UNTESTED. Looks sane to me, but what bothers me a bit is that it is untested. Leo do we (or

[Mesa-dev] [PATCH] radeonsi: fix build with GCC 4.8

Fixes: 7088b655e8 ("radeonsi: constify a bunch of the perfcounter structs.") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100937 Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH v2 12/27] auxiliary/vl: use vl_*_screen_create stubs when building w/o platform

Am 05.05.2017 um 13:23 schrieb Emil Velikov: On 5 May 2017 at 10:30, Christian König wrote: Am 04.05.2017 um 18:33 schrieb Emil Velikov: From: Emil Velikov Provide a dummy stub when the user has opted w/o said platform, thus we can build

Re: [Mesa-dev] [PATCH v2 12/27] auxiliary/vl: use vl_*_screen_create stubs when building w/o platform

On 5 May 2017 at 12:37, Christian König wrote: > Am 05.05.2017 um 13:23 schrieb Emil Velikov: >> >> On 5 May 2017 at 10:30, Christian König wrote: >>> >>> Am 04.05.2017 um 18:33 schrieb Emil Velikov: From: Emil Velikov

[Mesa-dev] [PATCH] anv: Always set the reloc value to match the presumed_offset

It is a requirement, not just of using the NO_RELOC mode, that all relocation values in the execobjects match their reloc.presumed_offset, as the kernel will skip performing *any* relocation if the presumed_offset matches the target object. As anv is setting unknown relocations to -1 irrespective

[Mesa-dev] [Bug 99116] Wine program showing only a blackscreen when using mesa

https://bugs.freedesktop.org/show_bug.cgi?id=99116 --- Comment #10 from JL --- I tried to replay attachment in first post with mesa 17.0.5 (archlinux) and R9 285 and it shows only black unless I run it with "apitrace replay --sb wine.trace" which shows animation but in very fast

Re: [Mesa-dev] [PATCH v2 13/27] st/va: move variable declaration to where its used

Am 04.05.2017 um 18:33 schrieb Emil Velikov: From: Emil Velikov ... and make it const, since we shouldn't tinker with it. Signed-off-by: Emil Velikov Reviewed-by: Nayan Deshmukh Patches #13 - #17 are

  1   2   >