Re: [Mesa-dev] [PATCH 09/11] intel/tools: Refactor gen_disasm_disassemble() to use annotations

On Thu, May 04, 2017 at 11:27:57AM -0700, Matt Turner wrote: > On Tue, May 2, 2017 at 6:03 AM, Iago Toral wrote: > > On Mon, 2017-05-01 at 13:54 -0700, Matt Turner wrote: > >> Which will allow us to print validation errors found in shader > >> assembly > >> in GPU hang error

Re: [Mesa-dev] Fix __atomic* builtins detection for Clang

On Sat, May 13, 2017 at 02:22:30AM +0200, Jan Beich wrote: > "int" isn't large enough and lack of builtins only manifests at link time. > This was breaking build on FreeBSD 11.0 i386 with Clang 3.8.0. You should be building with -march=i586 on i386 for CX8. The diff is wrong as it will break

Re: [Mesa-dev] [PATCH 01/11] i965: Mark shader programs for capture in the error state.

On Mon, May 01, 2017 at 01:54:45PM -0700, Matt Turner wrote: > When the GPU hangs, the kernel saves some state for us. Until now it has > not included the shader programs, which are very often the reason the > GPU hang occurred. With the programs saved in the error state, we should > be more

Re: [Mesa-dev] [PATCH 03/11] i965: Allow brw_eu_validate to handle compact instructions

On Mon, May 01, 2017 at 01:54:47PM -0700, Matt Turner wrote: > This will allow the validator to run on shader programs we find in the > GPU hang error state. > --- > src/intel/compiler/brw_eu_validate.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

On Sat, May 13, 2017 at 10:47:17AM +1000, Timothy Arceri wrote: > On 13/05/17 09:55, John Brooks wrote: > >On Sat, May 13, 2017 at 09:04:05AM +1000, Timothy Arceri wrote: > >>On 13/05/17 00:11, John Brooks wrote: > >>>On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: > > >

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

On 13/05/17 09:55, John Brooks wrote: On Sat, May 13, 2017 at 09:04:05AM +1000, Timothy Arceri wrote: On 13/05/17 00:11, John Brooks wrote: On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: On 05/12/2017 03:39 PM, John Brooks wrote: Since release, Dying Light and Dead Island

[Mesa-dev] Fix __atomic* builtins detection for Clang

"int" isn't large enough and lack of builtins only manifests at link time. This was breaking build on FreeBSD 11.0 i386 with Clang 3.8.0. glsl/.libs/libstandalone.a(libmesautil_la-disk_cache.o): In function `disk_cache_remove': disk_cache.c:(.text+0x763): undefined reference to

[Mesa-dev] [PATCH 1/2] bin/get-fixes-pick-list.sh: parse just the commit message

We were parsing the whole diff, although the candidates were identified only by the commit message. Now, we only use the commit message for parsing. Signed-off-by: Andres Gomez --- bin/get-fixes-pick-list.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 2/2] bin/get-fixes-pick-list.sh: better identify multiple "fixes:" tags

We were not considering as multiple fixes lines with: Fixes: $sha_1, Fixes: $sha_2 Now, we split the lines so we will consider them individually, as in: Fixes: $sha_1, Fixes: $sha_2 Additionally, we try to get the SHA from split lines so: Fixes: $sha_1 Will be considered as: Fixes: $sha_1

[Mesa-dev] [PATCH 0/2] Improve get-fixes-pick-list.sh

Some more improvements: - Only parse the commit messages. - Split "fixes:" tags on its own lines. - Join in a single line split lines like "fixes:\n$sha" Andres Gomez (2): bin/get-fixes-pick-list.sh: parse just the commit message bin/get-fixes-pick-list.sh: better identify multiple

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

On Sat, May 13, 2017 at 09:04:05AM +1000, Timothy Arceri wrote: > On 13/05/17 00:11, John Brooks wrote: > >On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: > >> > >> > >>On 05/12/2017 03:39 PM, John Brooks wrote: > >>>Since release, Dying Light and Dead Island Definitive Edition

[Mesa-dev] [PATCH 19/24] i965/cnl: Restore lossless compression for sRGB formats

From: Ben Widawsky This support was removed on gen9 (it worked before then) and was brought back for gen10. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 21/24] i965/cnl: Make URB {VS, GS, HS, DS} sizes non multiple of 3

v1: By Ben Widawsky v2: Add the restriction for GS, HS and DS and make sure the allocated sizes are not multiple of 3. Signed-off-by: Anuj Phogat Cc: Ben Widawsky --- src/mesa/drivers/dri/i965/gen7_urb.c | 12

[Mesa-dev] [PATCH 23/24] i965/cnl: Enable CCS_E and RT support for few formats

Suggested-by: Jason Ekstrand Signed-off-by: Anuj Phogat --- src/intel/isl/isl_format.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c index

[Mesa-dev] [PATCH 12/24] i965/cnl: Add cnl bits in aubinator

Signed-off-by: Anuj Phogat --- src/intel/tools/aubinator.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 53b2a27..d15476d 100644 --- a/src/intel/tools/aubinator.c +++

[Mesa-dev] [PATCH 20/24] i965/cnl: Don't resolve single sampled color rb in case of sRGB formats

As sRGB now supports lossless compression, don't we also need to stop resolving single sampled color render buffers for sRGB formats in Gen 10. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 13/24] i965/cnl: Update few assertions

Signed-off-by: Anuj Phogat --- src/intel/compiler/brw_compiler.h | 2 +- src/mesa/drivers/dri/i965/brw_program.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/compiler/brw_compiler.h b/src/intel/compiler/brw_compiler.h index

[Mesa-dev] [PATCH 15/24] i965/cnl: Start using CNL MOCS defines

They are the duplicates of SKL MOCS defines. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_blorp.c| 7 ++- src/mesa/drivers/dri/i965/brw_state.h| 8 src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 ++

[Mesa-dev] [PATCH 16/24] i965/cnl: Start using gen10 specific functions

gen10 specific functions: isl_gen10*() gen10_blorp_exec() gen10_init_atoms() Signed-off-by: Anuj Phogat --- src/intel/isl/isl.c | 12 +--- src/mesa/drivers/dri/i965/brw_blorp.c| 2 +- src/mesa/drivers/dri/i965/brw_state_upload.c |

[Mesa-dev] [PATCH 04/24] i965/cnl: Define genX(x) and GENX(x) for gen10

Signed-off-by: Anuj Phogat --- src/intel/genxml/gen_macros.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/genxml/gen_macros.h b/src/intel/genxml/gen_macros.h index b4941b9..a85c082 100644 --- a/src/intel/genxml/gen_macros.h +++

[Mesa-dev] [PATCH 22/24] i965/cnl: Reformat surface_format_info table to accomodate gen10+

Signed-off-by: Anuj Phogat --- src/intel/isl/isl_format.c | 498 ++--- 1 file changed, 249 insertions(+), 249 deletions(-) diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c index 165c7e5..a26873b 100644 ---

[Mesa-dev] [PATCH 07/24] i965/cnl: Update the script generating genX_bits.h

Signed-off-by: Anuj Phogat Reviewed-by: Jason Ekstrand --- src/intel/genxml/gen_bits_header.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/genxml/gen_bits_header.py b/src/intel/genxml/gen_bits_header.py index

[Mesa-dev] [PATCH 24/24] i965: Simplify get_l3_way_size() function

Cherryview and Broxton are always gt1. So, remove the redundant checks. Signed-off-by: Anuj Phogat --- src/intel/common/gen_l3_config.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/intel/common/gen_l3_config.c

[Mesa-dev] [PATCH 11/24] i965/cnl: Add pci id for INTEL_DEVID_OVERRIDE

Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 3717728..65a0b5c 100644 ---

[Mesa-dev] [PATCH 09/24] i965/cnl: Wire up Mesa build files for gen10

Signed-off-by: Anuj Phogat --- src/intel/Makefile.isl.am | 4 src/intel/Makefile.sources | 12 ++-- src/intel/Makefile.vulkan.am | 7 ++- src/mesa/drivers/dri/i965/Makefile.am | 6 +-

[Mesa-dev] [PATCH 17/24] i965/cnl: Implement new pipe control workaround

From: Ben Widawsky GEN10 requires flushing all previous pipe controls before issuing a render target cache flush. The docs seem to fairly explicitly say this is gen10 only. V2 (by Anuj): Use flags & PIPE_CONTROL_RENDER_TARGET_FLUSH check. (Ilia) Use

[Mesa-dev] [PATCH 18/24] i965/cnl: Implement depth count workaround

From: Ben Widawsky Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_queryobj.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_queryobj.c b/src/mesa/drivers/dri/i965/brw_queryobj.c

[Mesa-dev] [PATCH 08/24] i965/cnl: Add isl_gen10 header and source files

Signed-off-by: Anuj Phogat --- src/intel/isl/isl_gen10.c | 41 + src/intel/isl/isl_gen10.h | 45 + 2 files changed, 86 insertions(+) create mode 100644 src/intel/isl/isl_gen10.c create

[Mesa-dev] [PATCH 06/24] i965/cnl: Add gen10 specific function declarations

These declarations will help the code start compiling once we wire up the makefiles for gen10. Later patches will start using these functions for gen10. Signed-off-by: Anuj Phogat --- src/intel/isl/isl_priv.h | 12

[Mesa-dev] [PATCH 10/24] i965/cnl: Wire up android Mesa build files for gen10

Note: This patch is untested. Signed-off-by: Anuj Phogat --- src/intel/Android.genxml.mk | 5 + src/intel/Android.isl.mk | 20 src/intel/Android.vulkan.mk | 21 +

[Mesa-dev] [PATCH 05/24] i965/cnl: Include gen10_pack.h

Signed-off-by: Anuj Phogat --- src/intel/genxml/genX_pack.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/genxml/genX_pack.h b/src/intel/genxml/genX_pack.h index 2ec2226..187e75c 100644 --- a/src/intel/genxml/genX_pack.h +++ b/src/intel/genxml/genX_pack.h

[Mesa-dev] [PATCH 01/24] i965: Make feature macros gen8 based

From: Ben Widawsky All the "features" of the hardware are similar starting with GEN8, so remove as much of the GEN9 uniqueness as possible. This makes implementing future gen platforms a bit easier. Signed-off-by: Ben Widawsky

[Mesa-dev] [PATCH 03/24] i965/cnl: Add gen10.xml

From: Jason Ekstrand This patch is truncated due to the size. You can find the full patch in my review branch. V2(Anuj): Add default value for length of 3DPRIMITIVE command Add values for 'Attribute Active Component Format' Rename few fields to

[Mesa-dev] [PATCH 02/24] i965/cnl: Add a preliminary device for Cannonlake

From: Ben Widawsky v2 (Anuj): Rebased on master and updated pci ids Remove redundant initialization of max_wm_threads to 64 * 12. For gen9+ max_wm_threads are initialized in gen_get_device_info(). Signed-off-by: Anuj Phogat Signed-off-by: Ben

[Mesa-dev] [PATCH V2 00/24] Add Cannonlake support

This series adds support for Cannonlake. Changes from V1 to V2: - Incorporated the review comments from V1. - Rebased 8 months old CNL branch on top of master - Wired up Linux and Android build files for gen10 - Replaced the use of few gen9 functions with gen10 specific functions. - Squashed few

[Mesa-dev] [PATCH 14/24] i965/cnl: Handle gen10 in switch cases across the driver

We are still using some gen9 functions for gen10 in this patch. They will be replaced by gen10 functions in later patches. Signed-off-by: Anuj Phogat --- src/intel/common/gen_l3_config.c| 1 + src/intel/compiler/brw_eu.c | 2 ++

[Mesa-dev] [ANNOUNCE] mesa 17.0.6

Mesa 17.0.6 is now available. In this release we have: Mesa Core includes a fix for validating that SSA references use the same number of channels as there are in the SSA value and a minor fix for the YUV color conversion matrix. Gallivm has received a fix when setting bool values in Big Endian

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

On 13/05/17 00:11, John Brooks wrote: On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: On 05/12/2017 03:39 PM, John Brooks wrote: Since release, Dying Light and Dead Island Definitive Edition have been broken on Mesa, producing at best only a black screen after loading. I

Re: [Mesa-dev] [PATCH v2 2/2] i965/formats: Update the three-channel DXT1 mappings

On Fri, May 12, 2017 at 01:33:54PM -0700, Nanley Chery wrote: > The procedure for decompressing an opaque DXT1 OpenGL format is > dependant on the comparison of two colors stored in the first 32 bits of > the compressed block. Here's the specified OpenGL behavior for > reference: > >The RGB

Re: [Mesa-dev] [PATCH 3/4] intel/isl: Refactor gen6_choose_image_alignment_el

On Thu 11 May 2017, Jason Ekstrand wrote: > On Thu, May 11, 2017 at 9:08 PM, Chad Versace > wrote: > > > On Thu 11 May 2017, Jason Ekstrand wrote: > > > On Thu, May 11, 2017 at 7:03 AM, Pohjolainen, Topi < > > > topi.pohjolai...@gmail.com> wrote: > > > > > > > On Wed,

[Mesa-dev] [PATCH] radeonsi: bugfix in performance counters

'if (regs->counters)' expression at line 623 is always true, spotted because of an error when building android-x86. 'if (regs->counters[idx])' is used instead. Fixes the following building error in Android: external/mesa/src/gallium/drivers/radeonsi/si_perfcounter.c:617:14: error: address of

[Mesa-dev] [PATCH] virgl: fix virgl_bo_transfer_{put, get} box struct copy

Commit 3dfe61ed6ec6 ("gallium: decrease the size of pipe_box - 24 -> 16 bytes") changed the size of pipe_box, but the virgl code was relying on pipe_box and drm_virtgpu_3d_box structs having the same size/layout doing a struct copy. Copy the fields one by one instead. Cc: Marek Olšák

Re: [Mesa-dev] [PATCH v2] bin/get-fixes-pick-list.sh: bring back the warning

On Fri, 2017-05-12 at 13:54 +0100, Emil Velikov wrote: > On 12 May 2017 at 09:33, Andres Gomez wrote: > > We warn again if there is more than one line with the "fixes:" tag. > > > > The warning is only silenced when the commit has landed already or we > > output another

Re: [Mesa-dev] [PATCH 2/2] i965/formats: Update the RGB_DXT1 mappings

On Friday, May 12, 2017 1:31:56 PM PDT Nanley Chery wrote: > On Fri, May 12, 2017 at 08:39:40AM -0700, Kenneth Graunke wrote: > > On Thursday, May 11, 2017 4:46:27 PM PDT Nanley Chery wrote: > > > The DXT1_RGB* format does not provide the correct behavior for OpenGL in > > > the case where color_0

[Mesa-dev] [PATCH v2 2/2] i965/formats: Update the three-channel DXT1 mappings

The procedure for decompressing an opaque DXT1 OpenGL format is dependant on the comparison of two colors stored in the first 32 bits of the compressed block. Here's the specified OpenGL behavior for reference: The RGB color for a texel at location (x,y) in the block is given by: RGB0,

[Mesa-dev] [PATCH v2 1/2] anv/formats: Update the three-channel BC1 mappings

The procedure for decompressing an opaque BC1 Vulkan format is dependant on the comparison of two colors stored in the first 32 bits of the compressed block. Here's the specified OpenGL (and Vulkan) behavior for reference: The RGB color for a texel at location (x,y) in the block is given by:

Re: [Mesa-dev] [PATCH 2/2] i965/formats: Update the RGB_DXT1 mappings

On Fri, May 12, 2017 at 08:39:40AM -0700, Kenneth Graunke wrote: > On Thursday, May 11, 2017 4:46:27 PM PDT Nanley Chery wrote: > > The DXT1_RGB* format does not provide the correct behavior for OpenGL in > > the case where color_0 <= color_1. BC1_RGB_UNORM with a alpha set to 1 > > provides the

Re: [Mesa-dev] [PATCH] gallium/u_threaded: drop and ignore all non-async debug callbacks

On 12.05.2017 21:06, Marek Olšák wrote: From: Marek Olšák This is necessary to comply with OpenGL. Reviewed-by: Nicolai Hähnle --- src/gallium/auxiliary/util/u_threaded_context.c | 7 +++ src/gallium/auxiliary/util/u_threaded_context.h |

Re: [Mesa-dev] [PATCH 03/13] gallium/util: add threaded_context as a pipe_context wrapper

On 12.05.2017 21:05, Marek Olšák wrote: From: Marek Olšák v2: - rename num_calls -> num_call_slots (for tc_call) - rename num_calls -> num_total_call_slots (for tc_batch) - rename num_offloaded/direct_calls -> num_offloaded/direct_slots - declare slot[0]

[Mesa-dev] [PATCH] gallium/u_threaded: drop and ignore all non-async debug callbacks

From: Marek Olšák This is necessary to comply with OpenGL. --- src/gallium/auxiliary/util/u_threaded_context.c | 7 +++ src/gallium/auxiliary/util/u_threaded_context.h | 4 +--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 03/13] gallium/util: add threaded_context as a pipe_context wrapper

From: Marek Olšák v2: - rename num_calls -> num_call_slots (for tc_call) - rename num_calls -> num_total_call_slots (for tc_batch) - rename num_offloaded/direct_calls -> num_offloaded/direct_slots - declare slot[0] instead of slot[1] - remove no-op leftover

Re: [Mesa-dev] [PATCH 03/13] gallium/util: add threaded_context as a pipe_context wrapper

[snip] >> +static unsigned >> +tc_improve_map_buffer_flags(struct threaded_context *tc, >> +struct threaded_resource *tres, unsigned >> usage, >> +unsigned offset, unsigned size) >> +{ >> + /* Handle CPU reads trivially. */ >> + if (usage

[Mesa-dev] [PATCH] Android: r600: fix build when LLVM is disabled

There's still an error after my recent clean-up if LLVM is not patched to enable AMDGPU target: external/mesa3d/src/amd/common/ac_llvm_util.c:38:2: error: implicit declaration of function 'LLVMInitializeAMDGPUTargetInfo' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

[Mesa-dev] [PATCH v2 2/2] i965: perf: fix pointer to integer cast

v2: Just use cast to uintptr_t (Chris) Reported-by: Mauro Rossi Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_performance_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] i965/formats: Update the RGB_DXT1 mappings

On Thursday, May 11, 2017 4:46:27 PM PDT Nanley Chery wrote: > The DXT1_RGB* format does not provide the correct behavior for OpenGL in > the case where color_0 <= color_1. BC1_RGB_UNORM with a alpha set to 1 > provides the behavior which matches the spec. > > Bugzilla:

Re: [Mesa-dev] [PATCH 0/6] Various fixes to integer GetUniform*()

On Friday, May 12, 2017 1:40:49 AM PDT Nicolai Hähnle wrote: > On 11.05.2017 13:10, Iago Toral Quiroga wrote: > > This series is an update on a previous patch by Ken that fixed > > a CTS test but never got merged due to the mess with the CTS repositories > > at that time, plus a number of

Re: [Mesa-dev] Requests for Proposal for hosting XDC 2018

On Fri, May 12, 2017 at 12:08 AM, Daniel Vetter wrote: > The X.org board is soliciting proposals to host XDC in 2017 That's meant to read 2018 too of course, I missed one date ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 -

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: > > > On 05/12/2017 03:39 PM, John Brooks wrote: > >Since release, Dying Light and Dead Island Definitive Edition have been > >broken > >on Mesa, producing at best only a black screen after loading. I found that > >the > >root of

Re: [Mesa-dev] [PATCH 2/2] docs: extend until the end of August

On 12 May 2017 at 14:03, Emil Velikov wrote: > On 6 May 2017 at 16:46, Andres Gomez wrote: >> Completed the 17.1 cycle and added the beginning of the 17.2 one. >> >> Cc: Emil Velikov >> Cc: Juan A. Suarez Romero

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

On 05/12/2017 03:39 PM, John Brooks wrote: Since release, Dying Light and Dead Island Definitive Edition have been broken on Mesa, producing at best only a black screen after loading. I found that the root of the problem is that their vertex shaders redeclare the GLSL builtin gl_VertexID,

[Mesa-dev] [PATCH 2/3] glsl: Conditionally allow redeclaration of builtins

Conditional on allow_glsl_builtin_redeclaration driconf option. Signed-off-by: John Brooks --- src/compiler/glsl/ast_to_hir.cpp | 16 src/compiler/glsl/glsl_parser_extras.cpp | 2 ++ src/compiler/glsl/glsl_parser_extras.h | 1 + 3 files changed,

[Mesa-dev] [PATCH 1/3] driconf: Add allow_glsl_builtin_redeclaration option

This option will allow GLSL builtins to be redeclared verbatim (e.g. redeclaring "in int gl_VertexID" in a vertex shader). This is not strictly valid and would normally fail to compile, but some applications (such as newer Techland ports) do it and need more leniency. Signed-off-by: John Brooks

[Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

Since release, Dying Light and Dead Island Definitive Edition have been broken on Mesa, producing at best only a black screen after loading. I found that the root of the problem is that their vertex shaders redeclare the GLSL builtin gl_VertexID, which Mesa's compiler considers to be an error:

[Mesa-dev] [PATCH 3/3] drirc: Add allow_glsl_builtin_redeclaration for Dying Light and Dead Island Definitive Edition

This fixes the long-standing problem with Dying Light where the game would produce a black screen when running under Mesa. This happened because the game's vertex shaders redeclare gl_VertexID, which is a GLSL builtin. Mesa's GLSL compiler is a little more strict than others, and would not compile

Re: [Mesa-dev] [PATCH 3/3] egl/wayland: use the image_driver alongside the image_loader

On 11 May 2017 at 23:22, Emil Velikov wrote: > From: Emil Velikov > > Analogous to previous commit. > > Cc: Derek Foreman > Signed-off-by: Emil Velikov > --- > Derek, afaict we should be

Re: [Mesa-dev] [PATCH 2/2] docs: extend until the end of August

On 6 May 2017 at 16:46, Andres Gomez wrote: > Completed the 17.1 cycle and added the beginning of the 17.2 one. > > Cc: Emil Velikov > Cc: Juan A. Suarez Romero > Signed-off-by: Andres Gomez > --- >

Re: [Mesa-dev] [PATCH 1/2] docs: update "Release manager" column

On 6 May 2017 at 16:46, Andres Gomez wrote: > Cc: Emil Velikov > Cc: Juan A. Suarez Romero > Signed-off-by: Andres Gomez > --- > docs/release-calendar.html | 8 > 1 file changed, 4 insertions(+), 4

Re: [Mesa-dev] [PATCH v2] bin/get-fixes-pick-list.sh: bring back the warning

On 12 May 2017 at 09:33, Andres Gomez wrote: > We warn again if there is more than one line with the "fixes:" tag. > > The warning is only silenced when the commit has landed already or we > output another message for every "fixes:" tag. > Since "only silenced" is no longer

Re: [Mesa-dev] [PATCH 10/13] egl/x11: make use of the dri2_display_destroy() helper

On 12 May 2017 at 09:20, Tapani Pälli wrote: > this patch causes a crash with egl-create-surface Piglit test > Seems like we have a bunch of missing NULL checks throughout. Please ignore the patch dri2_display_destroy patches for the times being. -Emil

Re: [Mesa-dev] [PATCH 2/2] i965: perf: fix pointer to integer cast

On Fri, May 12, 2017 at 12:37:26PM +0100, Lionel Landwerlin wrote: > Reported-by: Mauro Rossi > Signed-off-by: Lionel Landwerlin > --- > src/mesa/drivers/dri/i965/brw_performance_query.c | 2 +- > 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH 2/2] i965: perf: fix pointer to integer cast

Reported-by: Mauro Rossi Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_performance_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_performance_query.c

[Mesa-dev] [PATCH 1/2] intel: gen-decoder: fix xml parser leak

In the unlikely case the parsing of genxml files fails, we were leaking an xml parser object. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] i965: fix cast in OA performance query code

2017-05-12 8:18 GMT+02:00 Tapani Pälli : > > > On 05/11/2017 04:00 PM, Lionel Landwerlin wrote: >> >> On 11/05/17 13:58, Lionel Landwerlin wrote: >>> >>> On 11/05/17 12:27, Tapani Pälli wrote: On 05/11/2017 02:23 PM, Emil Velikov wrote: > > On 1

Re: [Mesa-dev] [RFC] st/dri: implement createImageWithModifiers

Hi Varad, Am Freitag, den 12.05.2017, 15:11 +0530 schrieb Varad Gautam: > gallium doesn't have a way to pass modifiers to the driver when creating > resources. we require this to support > dri2ImageExtension->createImageWithModifiers() to get > gbm_bo_create_with_modifiers() to work. > > this

Re: [Mesa-dev] [PATCH v2 3/6] vulkan/wsi/wayland: Use per-display event queue

On 05/05/17 17:47, Daniel Stone wrote: Calling random callbacks on the display's event queue is hostile, as we may call into client code when it least expects it. Create our own event queue, one per wsi_wl_display, and use that for the registry. Signed-off-by: Daniel Stone

[Mesa-dev] [RFC] st/dri: implement createImageWithModifiers

gallium doesn't have a way to pass modifiers to the driver when creating resources. we require this to support dri2ImageExtension->createImageWithModifiers() to get gbm_bo_create_with_modifiers() to work. this adds a pscreen->resource_create_with_modifier() to pass the modifier flags to the

Re: [Mesa-dev] [PATCH] nv50/ir: Report wrong prog types using proper var

Reviewed-by: Samuel Pitoiset On 05/12/2017 11:01 AM, Pierre Moreau wrote: Coverity caught the use of the uninitialised variable `type`. However, it was `info->type`, which is initialised, which was meant to be used. CID: 1406000 Reported-by: Ilia Mirkin

[Mesa-dev] [PATCH] nv50/ir: Report wrong prog types using proper var

Coverity caught the use of the uninitialised variable `type`. However, it was `info->type`, which is initialised, which was meant to be used. CID: 1406000 Reported-by: Ilia Mirkin Fixes: b490ca9a387d ("nv50/ir: Fail if encountering unknown shader type") Signed-off-by:

Re: [Mesa-dev] [PATCH 00/13] Threaded Gallium for RadeonSI

On 11.05.2017 23:01, Marek Olšák wrote: On Thu, May 11, 2017 at 9:02 PM, Nicolai Hähnle > Some general remarks: Violating the "async" promise on debug callbacks is a problem. This breaks the OpenGL API in a place where it wasn't broken before, and that's not okay. I'm not

Re: [Mesa-dev] [PATCH 09/13] gallium/radeon: subclass threaded_transfer

Reviewed-by: Nicolai Hähnle On 12.05.2017 01:53, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 22 ++--- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +-

Re: [Mesa-dev] [PATCH 3/6] mesa: Clamp GetUniformui64v values to be >= 0

On 11.05.2017 13:10, Iago Toral Quiroga wrote: Like we do for the 32-bit case. --- src/mesa/main/uniform_query.cpp | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp

Re: [Mesa-dev] [PATCH 0/6] Various fixes to integer GetUniform*()

On 11.05.2017 13:10, Iago Toral Quiroga wrote: This series is an update on a previous patch by Ken that fixed a CTS test but never got merged due to the mess with the CTS repositories at that time, plus a number of additional fixes for recently added int64 paths. Patch 1 fixes indentation.

Re: [Mesa-dev] [PATCH 2/6] mesa: Clamp GetUniformuiv values to be >= 0

On 11.05.2017 13:10, Iago Toral Quiroga wrote: From: Kenneth Graunke Section 2.2.2 (Data Conversions For State Query Commands) of the OpenGL 4.5 October 24th 2016 specification says: "If a command returning unsigned integer data is called, such as

Re: [Mesa-dev] [PATCH 5/6] mesa: Add conversion from double to uint64/int64 in GetUniform*i64v()

On 11.05.2017 13:10, Iago Toral Quiroga wrote: --- src/mesa/main/uniform_query.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 42abd18..25acc31 100644 --- a/src/mesa/main/uniform_query.cpp +++

[Mesa-dev] [PATCH v2] bin/get-fixes-pick-list.sh: bring back the warning

We warn again if there is more than one line with the "fixes:" tag. The warning is only silenced when the commit has landed already or we output another message for every "fixes:" tag. Signed-off-by: Andres Gomez --- bin/get-fixes-pick-list.sh | 19 +-- 1

Re: [Mesa-dev] [PATCH 4/6] mesa/main: add IROUNDD64() helper

On 11.05.2017 13:10, Iago Toral Quiroga wrote: --- src/mesa/main/imports.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index ef7c378..416c59b 100644 --- a/src/mesa/main/imports.h +++ b/src/mesa/main/imports.h @@ -165,6 +165,13 @@

Re: [Mesa-dev] [PATCH 1/6] mesa/main: fix indentation in _mesa_get_uniform()

On 11.05.2017 13:10, Iago Toral Quiroga wrote: --- src/mesa/main/uniform_query.cpp | 194 1 file changed, 99 insertions(+), 95 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 0e02a76..bd5b4c4 100644 ---

Re: [Mesa-dev] [PATCH 10/13] egl/x11: make use of the dri2_display_destroy() helper

this patch causes a crash with egl-create-surface Piglit test On 05/11/2017 09:57 PM, Emil Velikov wrote: From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c | 78

Re: [Mesa-dev] [PATCH 0/2] Extended the release calendar

On Sat, 2017-05-06 at 18:46 +0300, Andres Gomez wrote: > Calendar updated and extended until end of August. > Both patches: Reviewed-by: Juan A. Suarez Romero > Andres Gomez (2): > docs: update "Release manager" column > docs: extend until the end of August > >

Re: [Mesa-dev] [PATCH 06/13] egl/android: make use of dri2_display_destroy() helper

On 05/11/2017 09:57 PM, Emil Velikov wrote: From: Emil Velikov Cc: Tomasz Figa Cc: Tapani Pälli Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 27

Re: [Mesa-dev] [PATCH] mesa: fix KHR_no_error SSO support

Reviewed-by: Samuel Pitoiset On 05/12/2017 07:29 AM, Timothy Arceri wrote: Fixes: 00c5119a5e821 ("mesa: add KHR_no_error support for glUseProgramStages()") --- Found with the new no_error piglit profile [1]. Up until now my testing has been adhoc, selecting a

[Mesa-dev] [PATCH v2] egl: fix android logger compilation

1ce5853 broken compilation since LOG_ERROR is not defined and also macro expansion won't work as planned (expands to 'ANDROID_egl2alog[level]') v2: append 'ANDROID' to egl2alog table and use LOG_PRI (suggested by Chih-Wei Huang) Fixes: 1ce5853 ("egl: simplify the Android logger")

Re: [Mesa-dev] [PATCH] egl: fix android logger compilation

On 05/12/2017 09:19 AM, Chih-Wei Huang wrote: 2017-05-12 14:15 GMT+08:00 Tapani Pälli : On 05/12/2017 09:13 AM, Chih-Wei Huang wrote: 2017-05-12 13:37 GMT+08:00 Tapani Pälli : this patch is a partial revert of 1ce5853 that break

Re: [Mesa-dev] [PATCH] egl: fix android logger compilation

2017-05-12 14:15 GMT+08:00 Tapani Pälli : > > > On 05/12/2017 09:13 AM, Chih-Wei Huang wrote: >> >> 2017-05-12 13:37 GMT+08:00 Tapani Pälli : >>> >>> this patch is a partial revert of 1ce5853 that break compilation >>> since LOG_ERROR etc are not

Re: [Mesa-dev] [PATCH] i965: fix cast in OA performance query code

On 05/11/2017 04:00 PM, Lionel Landwerlin wrote: On 11/05/17 13:58, Lionel Landwerlin wrote: On 11/05/17 12:27, Tapani Pälli wrote: On 05/11/2017 02:23 PM, Emil Velikov wrote: On 1 May 2017 at 12:09, Mauro Rossi wrote: Fixes the following building error happening

Re: [Mesa-dev] [PATCH] egl: fix android logger compilation

On 05/12/2017 09:13 AM, Chih-Wei Huang wrote: 2017-05-12 13:37 GMT+08:00 Tapani Pälli : this patch is a partial revert of 1ce5853 that break compilation since LOG_ERROR etc are not defined and also macro expansion won't work as planned (expands to

Re: [Mesa-dev] [PATCH] egl: fix android logger compilation

2017-05-12 13:37 GMT+08:00 Tapani Pälli : > this patch is a partial revert of 1ce5853 that break compilation > since LOG_ERROR etc are not defined and also macro expansion won't > work as planned (expands to 'ANDROID_egl2alog[level]') > > Fixes: 1ce5853 ("egl: simplify the

Re: [Mesa-dev] Requests for Proposal for hosting XDC 2018

On 12/05/17 02:46, Manasi Navare wrote: > Hi Daniel, > > Is Call for Papers opened yet for XDC? When do they usually start accepting > proposals? Hey Manasi, Our call for paper is usually sent around June with a deadline for mid-August. Here is the call for paper from last year, we do expect

Re: [Mesa-dev] [PATCH 2/2] i965/formats: Update the RGB_DXT1 mappings

Yep, this fixes the issue, also other DXT tests what I have are passing fine. Acked-by: Tapani Pälli On 05/12/2017 02:46 AM, Nanley Chery wrote: The DXT1_RGB* format does not provide the correct behavior for OpenGL in the case where color_0 <= color_1. BC1_RGB_UNORM

Re: [Mesa-dev] [PATCH 3/4] intel/isl: Refactor gen6_choose_image_alignment_el

On Thu, May 11, 2017 at 9:08 PM, Chad Versace wrote: > On Thu 11 May 2017, Jason Ekstrand wrote: > > On Thu, May 11, 2017 at 7:03 AM, Pohjolainen, Topi < > > topi.pohjolai...@gmail.com> wrote: > > > > > On Wed, May 10, 2017 at 02:30:31PM -0700, Jason Ekstrand wrote: > >

  1   2   >