[Mesa-dev] [PATCH v2 42/64] st/mesa: add st_create_{texture, image}_handle_from_unit() helper

v2: - remove "texture" parameter from create_texture_handle() Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle (v1) --- src/mesa/state_tracker/st_texture.c | 41 + 1 file changed, 41 insertions(+)

[Mesa-dev] [PATCH v2 33/64] st/glsl_to_tgsi: add support for bindless images

v2: - rebased (is_bindless() -> contains_bindless()) - remove dead inst->bindless assignment - add missing comment Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v1) --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 75

[Mesa-dev] [PATCH v2 53/64] radeonsi: add all resident buffers to the current CS

Resident buffers have to be added to every new command stream. Though, this could be slightly improved when current shaders don't use any bindless textures/images but usually applications tend to use bindless for almost every draw call, and the winsys thread might help when buffers are added

[Mesa-dev] [PATCH v2 64/64] radeonsi: enable ARB_bindless_texture

This has only been tested on RX480. Signed-off-by: Samuel Pitoiset --- docs/features.txt | 2 +- docs/relnotes/17.2.0.html | 1 + src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- 3 files changed, 5 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH v2 43/64] st/mesa: add infrastructure for storing bound texture/image handles

v2: - rename st_bound_handle to st_bound_handles Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle (v1) --- src/mesa/state_tracker/st_context.c | 2 + src/mesa/state_tracker/st_context.h | 11 ++

[Mesa-dev] [PATCH v2 37/64] tgsi/scan: record bindless samplers/images usage

v2: - removed use of the Bindless flags after rebasing - introduce tgsi_is_bindless_image_file() Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle (v1) --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 39

[Mesa-dev] [PATCH v2 60/64] radeonsi: upload new descriptors when resident buffers are invalidated

When texture buffers are invalidated the addr in the resident descriptor has to be updated but we can't create a new descriptor because the resident handle has to be the same. Instead, use the WRITE_DATA packet which allows to update memory directly but graphics/compute have to be idle in case

[Mesa-dev] [PATCH v2 61/64] radeonsi: invalidate buffers which are made resident if needed

When a buffer becomes resident, check if it has been invalidated, if so update the descriptor and the dirty flag. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 34 +++ 1 file changed, 34 insertions(+) diff

[Mesa-dev] [PATCH v2 56/64] radeonsi: decompress resident textures/images before graphics/compute

Similar to the existing decompression code path except that it loops over the list of resident textures/images. v2: - store pipe_sampler_view instead of si_sampler_view Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_blit.c| 77

[Mesa-dev] [PATCH v2 62/64] radeonsi: add support for loading bindless samplers

v2: - removed use of the Bindless flags after rebasing Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v2 50/64] radeonsi: add si_update_check_render_feedback() helper

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index

[Mesa-dev] [PATCH v2 39/64] st/mesa: make update_single_texture() non-static

Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_atom_texture.c | 15 +-- src/mesa/state_tracker/st_texture.h | 5 + 2 files changed,

[Mesa-dev] [PATCH v2 52/64] radeonsi: implement ARB_bindless_texture

This implements the Gallium interface. Decompression of resident textures/images will follow in the next patches. v2: - fix a memleak related to util_copy_image_view() - remove "texture" parameter from create_texture_handle() - store pipe_sampler_view instead of si_sampler_view - make

[Mesa-dev] [PATCH v2 32/64] st/glsl_to_tgsi: add support for bindless samplers

v2: - rebased (is_bindless() -> contains_bindless()) - removed dead inst->bindless assignment Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle (v1) Reviewed-by: Marek Olšák (v1) ---

[Mesa-dev] [PATCH v2 55/64] radeonsi: decompress DCC for resident textures/images

Analogous to bound textures/images. We should also update the resident descriptors and disable COMPRESSION_EN for avoiding useless DCC fetches, but I postpone this optimization for a separate series. v2: - store pipe_sampler_view instead of si_sampler_view Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH v2 40/64] st/mesa: make convert_sampler_from_unit() non-static

Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_atom_sampler.c | 14 -- src/mesa/state_tracker/st_texture.h | 5 + 2 files changed,

[Mesa-dev] [PATCH v2 51/64] radeonsi: add a slab allocator for bindless descriptors

For each texture/image handles, we need to allocate a new buffer for the bindless descriptor. But when the number of buffers added to the current CS becomes high, the overhead in the winsys (and in the kernel) is important. To reduce this bottleneck, the idea is to suballocate the bindless

[Mesa-dev] [PATCH v2 44/64] st/mesa: make bindless samplers/images bound to units resident

v2: - rebased (st_bound_handle -> st_bound_handles) Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle (v1) --- src/mesa/state_tracker/st_atom_constbuf.c | 6 ++ src/mesa/state_tracker/st_texture.c | 94

[Mesa-dev] [PATCH v2 28/64] ddebug: add ARB_bindless_texture support

v2: - remove "texture" parameter from create_texture_handle() Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v1) --- src/gallium/drivers/ddebug/dd_context.c | 60 + 1 file changed, 60 insertions(+) diff

[Mesa-dev] [PATCH v2 58/64] radeonsi: track use of bindless samplers/images from tgsi_shader_info

This adds some new helper functions to know if the current draw call (or dispatch compute) is using bindless samplers/images, based on TGSI analysis. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_compute.c | 2 ++

[Mesa-dev] [PATCH v2 45/64] st/mesa: disable per-context seamless cubemap when using texture handles

The ARB_bindless_texture spec say: "If ARB_seamless_cubemap (or OpenGL 4.0, which includes it) is supported, the per-context seamless cubemap enable is ignored and treated as disabled when using texture handles." "If AMD_seamless_cubemap_per_texture is supported, the seamless

[Mesa-dev] [PATCH v2 47/64] radeonsi: add si_init_descriptor_list() helper

This will be used in order to initialize resident descriptors for bindless textures/images. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

[Mesa-dev] [PATCH v2 17/64] glsl: add ir_variable::contains_bindless()

v2: - rename is_bindless() to contains_bindless() - update the comment Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle (v1) --- src/compiler/glsl/ir.h | 11 +++ 1 file changed, 11 insertions(+) diff --git

[Mesa-dev] [PATCH v2 30/64] tc: add ARB_bindless_texture support

v2: - use tc_add_small_call for delete_{image,texture}_handle() - store the 64-bit handle directly in tc_payload - remove "texture" parameter from create_texture_handle() Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v1) ---

[Mesa-dev] [PATCH v2 36/64] st/glsl_to_tgsi: teach rename_temp_registers() about bindless samplers

Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Mesa-dev] [PATCH v2 54/64] radeonsi: only add descriptors in presence of resident handles

This won't help much except for applications that use a ton of resident handles. Though, this will reduce the winsys overhead a little bit. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 6 ++ 1 file changed, 6 insertions(+)

[Mesa-dev] [PATCH v2 46/64] st/mesa: enable ARB_bindless_texture

Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák Reviewed-by: Nicolai Hähnle --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c

[Mesa-dev] [PATCH v2 35/64] st/glsl_to_tgsi: teach the DCE pass about bindless samplers/images

When a texture (or an image) instruction uses a bindless sampler (respectively a bindless image), make sure the DCE pass won't remove code when the resource is a temporary variable. Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle

[Mesa-dev] [PATCH v2 23/64] mesa: handle bindless uniforms bound to texture/image units

v2: - set changed to true when !sampler->bound Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniform_query.cpp | 122 ++-- 1 file changed, 116 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp

[Mesa-dev] [PATCH v2 31/64] tgsi/ureg: accept TGSI_FILE_{CONSTANT, INPUT} for dst registers

For example, TGSI_OPCODE_STORE for bindless images might use a constant buffer or a shader input. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 2 -- 1 file changed, 2 deletions(-) diff

[Mesa-dev] [PATCH v2 34/64] st/glsl_to_tgsi: add support for bindless pack/unpack operations

Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH v2 07/64] mesa: refuse to update tex parameters when a handle is allocated

The ARB_bindless_texture spec says: "The ARB_bindless_texture spec says: "The error INVALID_OPERATION is generated by TexImage*, CopyTexImage*, CompressedTexImage*, TexBuffer*, TexParameter*, as well as other functions defined in terms of these, if the texture object to be modified

[Mesa-dev] [PATCH v2 26/64] gallium: add ARB_bindless_texture interface

v2: - remove "texture" parameter from create_texture_handle() - better description of new pipe_context functions - add missing Gallium doc bits describing the interface Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v1) ---

[Mesa-dev] [PATCH v2 29/64] trace: add ARB_bindless_texture support

v2: - remove "texture" parameter from create_texture_handle() Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v1) --- src/gallium/drivers/trace/tr_context.c | 112 + 1 file changed, 112 insertions(+) diff

[Mesa-dev] [PATCH v2 08/64] mesa: refuse to change textures when a handle is allocated

The ARB_bindless_texture spec says: "The error INVALID_OPERATION is generated by TexImage*, CopyTexImage*, CompressedTexImage*, TexBuffer*, TexParameter*, as well as other functions defined in terms of these, if the texture object to be modified is referenced by one or more texture

[Mesa-dev] [PATCH v2 09/64] mesa: refuse to change tex buffers when a handle is allocated

The ARB_bindless_texture spec says: "The error INVALID_OPERATION is generated by BufferData if it is called to modify a buffer object bound to a buffer texture while that texture object is referenced by one or more texture handles." Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH v2 10/64] mesa: keep track of the current variable in add_uniform_to_shader

Bindless samplers are considered PROGRAM_UNIFORM but add_uniform_to_shader::visit_field() is based on glsl_type. Because only ir_variable knows if the uniform variable is bindless via ir_variable::bindless, store it instead of adding a new parameter to visit_field(). Signed-off-by: Samuel

[Mesa-dev] [PATCH v2 21/64] mesa: pass gl_program to _mesa_associate_uniform_storage()

Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/mesa/program/ir_to_mesa.cpp| 7 --- src/mesa/program/ir_to_mesa.h | 4 ++-- src/mesa/state_tracker/st_glsl_to_nir.cpp | 3 +--

[Mesa-dev] [PATCH v2 24/64] mesa: fix setting uniform variables for bindless samplers/images

This fixes a 64-bit vs 32-bit mismatch when setting an array of bindless samplers. Also, we need to unconditionally set size_mul to 2 when the underlying uniform is bindless. Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniform_query.cpp | 29

[Mesa-dev] [PATCH v2 18/64] mesa: add update_single_shader_texture_used() helper

This will also be used for looping over bindless samplers bound to texture units. Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/mesa/main/uniforms.c | 67 +++- 1 file changed,

[Mesa-dev] [PATCH v2 13/64] glsl: process uniform samplers declared bindless

Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/link_uniforms.cpp | 83 - src/compiler/glsl/shader_cache.cpp | 23 ++ src/mesa/program/program.c | 4 ++ 3

[Mesa-dev] [PATCH v2 20/64] mesa: update textures for bindless samplers bound to texture units

This is analogous to the existing SamplerUnits and SamplerTargets, but it loops over bindless samplers bound to texture units. Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/mesa/main/texstate.c | 18 +-

[Mesa-dev] [PATCH v2 22/64] mesa: associate uniform storage to bindless samplers/images

When a bindless sampler/image is bound to a texture/image unit, we have to overwrite the constant value by the resident handle directly in the constant buffer before the next draw. One solution is to keep track of a pointer to the data. Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH v2 06/64] mesa: refuse to update sampler parameters when a handle is allocated

The ARB_bindless_texture spec says: "The error INVALID_OPERATION is generated by SamplerParameter* if identifies a sampler object referenced by one or more texture handles." v2: - add new 'get' param to sampler_parameter_error_check() - move the HandleAllocated check to

[Mesa-dev] [PATCH v2 19/64] mesa: add update_single_program_texture_state() helper

This will also be used for looping over bindless samplers bound to texture units. Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/mesa/main/texstate.c | 36 +++- 1 file changed, 23

[Mesa-dev] [PATCH v2 11/64] mesa: store bindless samplers as PROGRAM_UNIFORM

Old-style samplers (ie. bound samplers) are stored as PROGRAM_SAMPLER, while bindless ones are PROGRAM_UNIFORM. Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/mesa/program/ir_to_mesa.cpp | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH v2 15/64] glsl: pass the ir_variable object to set_opaque_binding()

In order to set the explicit binding value for bindless samplers/images. Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/link_uniform_initializers.cpp | 7 --- 1 file changed, 4 insertions(+), 3

[Mesa-dev] [PATCH v2 04/64] mesa: add support for unsigned 64-bit vertex attributes

This adds support in the VBO and array code to handle unsigned 64-bit vertex attributes as specified by ARB_bindless_texture. Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/mapi/glapi/gen/apiexec.py | 3 +++

[Mesa-dev] [PATCH v2 12/64] mesa: add infrastructure for bindless samplers/images bound to units

Yes, ARB_bindless_texture allows to do this. In other words, in a situation like: layout (bindless_sampler) uniform sampler2D tex; The 'tex' sampler uniform can be either set with glUniform1() (old-style bound samplers) or with glUniformHandleui() (resident handles). When glUniform1() is used,

[Mesa-dev] [PATCH v2 16/64] glsl: set the explicit binding value for bindless samplers/images

This handles a situation like: layout (bindless_sampler, binding = 7) uniform sampler2D; Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/link_uniform_initializers.cpp | 35 - 1 file

[Mesa-dev] [PATCH v2 14/64] glsl: process uniform images declared bindless

Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/compiler/glsl/link_uniforms.cpp | 74 - src/compiler/glsl/shader_cache.cpp | 20 ++ src/mesa/program/program.c | 4 ++ 3

[Mesa-dev] [PATCH v2 01/64] mapi: add GL_ARB_bindless_texture entry points

v2: - remove useless offset="assign" tags Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_bindless_texture.xml | 100 src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 4 +-

[Mesa-dev] [PATCH v2 05/64] mesa: add support for glUniformHandleui64*ARB()

Bindless sampler/image handles are represented using 64-bit unsigned integers. The ARB_bindless_texture spec says: "The error INVALID_OPERATION is generated by UniformHandleui64{v}ARB if the sampler or image uniform being updated has the "bound_sampler" or "bound_image" layout

[Mesa-dev] [PATCH v2 03/64] mesa: implement ARB_bindless_texture

v2: - s/GLboolean/bool for HandleAllocated - fix _mesa_has_ARB_shader_image_load_store() checks - use u_vector for texture/image handles - fix use of 64-bit handles on 32-bit systems - some cleanups Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH v2 02/64] mesa/util: add MESA_ARCH_{X86, X86_64} macros

Copied from Gallium util. Will be used by the 64-bit hash table wrapper for bindless handles. Signed-off-by: Samuel Pitoiset --- src/util/macros.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/util/macros.h b/src/util/macros.h index

[Mesa-dev] [PATCH v2 00/64] ARB_bindless_texture for RadeonSI

Hi, This is the v2 of ARB_bindless_texture for RadeonSI. Major changes since v1: - fix use of 64-bit handles on 32-bit systems (ie. void *) - use u_vector instead of hash_table for texture object handles - fix a 64-bit vs 32-bit mismatch when setting bindless sampler uniforms - remove the

Re: [Mesa-dev] [PATCH 14/16] i965: Enable tiled memcpy pixel read path on non-LLC

On Tue, May 30, 2017 at 11:07:55AM -0700, Kenneth Graunke wrote: > On Wednesday, May 24, 2017 1:04:56 PM PDT Matt Turner wrote: > > --- > > src/mesa/drivers/dri/i965/intel_pixel_read.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git

Re: [Mesa-dev] [PATCH 13/16] i965: Explicitly disallow tiled memcpy path on Gen4 with swizzling.

On Wed, May 24, 2017 at 01:04:55PM -0700, Matt Turner wrote: > From: Chris Wilson > > The manual detiling paths are not prepared to handle Gen4-G45 with > swizzling enabled, so explicitly disable them. (They're already > disabled because these platforms don't have LLC

Re: [Mesa-dev] [PATCH 1/2] st/dri: move fence implemention into separate file

Just a heads up to Gallium experts (Emil, Tim, Robs + anyone else who knows this code) -- we'll probably push this soon unless we get more review comments ... ​ ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 00/24] swr: update rasterizer

Reviewed-by: Bruce Cherniak > On May 27, 2017, at 4:24 PM, Tim Rowley wrote: > > Highlights include lots of simd16 progress and code cleanups. > > No regressions on piglit or vtk ctest. > > Tim Rowley (24): > swr/rast: remove extra pixel

Re: [Mesa-dev] [PATCH 12/16] i965: Use write-combine mappings where available

On Thu, May 25, 2017 at 07:47:56AM +0100, Chris Wilson wrote: > On Wed, May 24, 2017 at 01:04:54PM -0700, Matt Turner wrote: > > Write-combine mappings give much better performance on writes than > > uncached access through the GTT. > > --- > > src/mesa/drivers/dri/i965/brw_bufmgr.c | 69 > >

[Mesa-dev] [PATCH 0/2] genxml/anv: Handle multiple registers in MI_LOAD_REGISTER*

Here are a couple of commits I used to debug writing dozen of registers to restore the NOA configs in the kernel. Might be useful to somebody :) Cheers, Lionel Landwerlin (2): intel: gen-decoder: rework how we handle groups genxml/anv: enable MI_LOAD_REGISTER* to load more than 1 register

[Mesa-dev] [PATCH 1/2] intel: gen-decoder: rework how we handle groups

The current way of handling groups doesn't seem to be able to handle MI_LOAD_REGISTER_* with more than one register. This change reworks the way we handle groups by building a traversal list on load the GENXML files. Let's say you have Instruction { Field0 Field1 Field2 Group0 (count=2)

[Mesa-dev] [PATCH 2/2] genxml/anv: enable MI_LOAD_REGISTER* to load more than 1 register

The kernel already uses that feature and it would be nice to have aubinator be able to dump those. Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen4.xml | 10 ++-- src/intel/genxml/gen5.xml | 10 ++-- src/intel/genxml/gen6.xml

Re: [Mesa-dev] [PATCH 11/16] i965: Replace brw_bo_map_unsynchronized with MAP_ASYNC

On Tue, May 30, 2017 at 10:59:19AM -0700, Kenneth Graunke wrote: > On Wednesday, May 24, 2017 1:04:53 PM PDT Matt Turner wrote: > > This way we can let brw_bo_map() choose the best mapping type. > > Sounds good. > > > Part of the patch inlines map_gtt() into brw_bo_map_gtt() (and removes > >

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #31 from Ben Crocker --- (In reply to Roland Scheidegger from comment #30) > (In reply to Rob Clark from comment #26) > > (In reply to Ben Crocker from comment #25) > > > > > > Regarding Ray's specific comment

Re: [Mesa-dev] [PATCH 10/16] i965: Add and use brw_bo_map()

On Fri, May 26, 2017 at 01:55:47AM -0700, Kenneth Graunke wrote: > On Wednesday, May 24, 2017 1:04:52 PM PDT Matt Turner wrote: > > We can encapsulate the logic for choosing the mapping type. This will > > also help when we add WC mappings. > > It might be worth mentioning that this patch changes

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #30 from Roland Scheidegger --- (In reply to Rob Clark from comment #26) > (In reply to Ben Crocker from comment #25) > > > > Regarding Ray's specific comment about getting scalar fetch to work > > with

Re: [Mesa-dev] [PATCH 4/5] radv: Use correct clear words for HTILE.

On Monday 22 May 2017, Bas Nieuwenhuizen wrote: > Did some RE'ing what several HTILE words give when read from a descriptor > with HTILE compression enabled. > > Seems to align with -pro usage for D16 too. > > Signed-off-by: Bas Nieuwenhuizen > --- >

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #29 from Ben Crocker --- Created attachment 131577 --> https://bugs.freedesktop.org/attachment.cgi?id=131577=edit Patch to lp_build_gather_elem_vec THIS is the attachment I meant to attach to Comment 28. --

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #28 from Ben Crocker --- The attached patch to lp_build_gather_elem_vec fixes the regressions in, e.g., the draw-vertices 16-bit tests. I'll spare you the assembly code this time, but suffice it to say the code

Re: [Mesa-dev] [PATCH] mesa/util: fix arithmetic use of 'void *' in u_vector_foreach

On Tuesday, May 30, 2017 8:41:32 AM PDT Samuel Pitoiset wrote: > u_vector_foreach is currently only used by the Intel Vulkan > driver but when this macro is used in mesa core, GCC reports > a compile-time error. Probably because some compiler options > are different. > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 16/16] i965: Enable tiled memcpy tex image path on non-LLC

On Wednesday, May 24, 2017 1:04:58 PM PDT Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c > b/src/mesa/drivers/dri/i965/intel_tex_subimage.c >

Re: [Mesa-dev] [PATCH 12/16] i965: Use write-combine mappings where available

On Wednesday, May 24, 2017 1:04:54 PM PDT Matt Turner wrote: > Write-combine mappings give much better performance on writes than > uncached access through the GTT. > --- > src/mesa/drivers/dri/i965/brw_bufmgr.c | 69 > ++ > 1 file changed, 69 insertions(+) > >

Re: [Mesa-dev] [PATCH 05/24] i965/cnl: Include gen10_pack.h

On Fri, May 12, 2017 at 04:38:09PM -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/genxml/genX_pack.h | 2 ++ > 1 file changed, 2 insertions(+) > Patches 4-5 are Reviewed-by: Nanley Chery > diff --git

Re: [Mesa-dev] [PATCH 14/16] i965: Enable tiled memcpy pixel read path on non-LLC

On Wednesday, May 24, 2017 1:04:56 PM PDT Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/intel_pixel_read.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c > b/src/mesa/drivers/dri/i965/intel_pixel_read.c > index

Re: [Mesa-dev] [PATCH 13/16] i965: Explicitly disallow tiled memcpy path on Gen4 with swizzling.

On Wednesday, May 24, 2017 1:04:55 PM PDT Matt Turner wrote: > From: Chris Wilson > > The manual detiling paths are not prepared to handle Gen4-G45 with > swizzling enabled, so explicitly disable them. (They're already > disabled because these platforms don't have LLC

Re: [Mesa-dev] [PATCH 11/16] i965: Replace brw_bo_map_unsynchronized with MAP_ASYNC

On Wednesday, May 24, 2017 1:04:53 PM PDT Matt Turner wrote: > This way we can let brw_bo_map() choose the best mapping type. Sounds good. > Part of the patch inlines map_gtt() into brw_bo_map_gtt() (and removes > map_gtt()). brw_bo_map_gtt() just wrapped map_gtt() with locking and a > call to

[Mesa-dev] [Bug 54971] __glXInitialize can initialize same display multiple times

https://bugs.freedesktop.org/show_bug.cgi?id=54971 Jordan Justen changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] i965: Rework Sandy Bridge HiZ and stencil layouts

On Tue, May 30, 2017 at 08:50:01AM -0700, Jason Ekstrand wrote: > On Mon, May 29, 2017 at 11:51 PM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Mon, May 29, 2017 at 12:09:01PM -0700, Jason Ekstrand wrote: > > > Sandy Bridge does not technically support mipmapped

Re: [Mesa-dev] [PATCH 14/30] intel/isl: Add an enum for describing auxiliary compression state

On Tue, May 30, 2017 at 07:32:24AM -0700, Jason Ekstrand wrote: > On Tue, May 30, 2017 at 1:43 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote: > > > This enum describes all of the states that a auxiliary compressed

Re: [Mesa-dev] [PATCH 02/30] i965/surface_state: Images can't handle CCS at all

On Tue, May 30, 2017 at 08:41:11AM -0700, Jason Ekstrand wrote: > On Tue, May 30, 2017 at 12:14 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Fri, May 26, 2017 at 04:30:06PM -0700, Jason Ekstrand wrote: > > > --- > > > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12

[Mesa-dev] [PATCH 3/3] radeonsi: remove unused si_pm4_state::compute_pkt

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_pm4.c | 3 +-- src/gallium/drivers/radeonsi/si_pm4.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pm4.c b/src/gallium/drivers/radeonsi/si_pm4.c

[Mesa-dev] [PATCH 2/3] radeonsi: remove chip_class define from si_pm4.h

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_pm4.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pm4.h b/src/gallium/drivers/radeonsi/si_pm4.h index 78aa33be0d..a3df89bd88 100644 ---

[Mesa-dev] [PATCH 1/3] radeonsi: merge si_pm4_free_state_simple() into si_pm4_free_state()

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_pm4.c | 9 ++--- src/gallium/drivers/radeonsi/si_pm4.h | 1 - 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pm4.c

Re: [Mesa-dev] [PATCH] Android: major/minor/makedev live in

On Tue, May 30, 2017 at 11:46 AM, Mauro Rossi wrote: > > > 2017-05-30 14:23 GMT+02:00 Rob Herring : >> >> sysmacros.h was getting implicitly included in types.h until recently in >> AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h.

Re: [Mesa-dev] [PATCH] Android: major/minor/makedev live in

2017-05-30 14:23 GMT+02:00 Rob Herring : > sysmacros.h was getting implicitly included in types.h until recently in > AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h. > > Signed-off-by: Rob Herring > --- > Android.common.mk | 1 + > 1

Re: [Mesa-dev] [PATCH] Android: major/minor/makedev live in

2017-05-30 15:41 GMT+02:00 Rob Herring : > On Tue, May 30, 2017 at 8:03 AM, Emil Velikov > wrote: > > On 30 May 2017 at 13:23, Rob Herring wrote: > >> sysmacros.h was getting implicitly included in types.h until recently in > >> AOSP

Re: [Mesa-dev] [PATCH] i965: Rework Sandy Bridge HiZ and stencil layouts

On Mon, May 29, 2017 at 11:51 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Mon, May 29, 2017 at 12:09:01PM -0700, Jason Ekstrand wrote: > > Sandy Bridge does not technically support mipmapped depth/stencil. In > > order to work around this, we allocate what are effectively

[Mesa-dev] [PATCH] mesa/util: fix arithmetic use of 'void *' in u_vector_foreach

u_vector_foreach is currently only used by the Intel Vulkan driver but when this macro is used in mesa core, GCC reports a compile-time error. Probably because some compiler options are different. Signed-off-by: Samuel Pitoiset --- src/util/u_vector.h | 2 +- 1 file

Re: [Mesa-dev] [PATCH 02/30] i965/surface_state: Images can't handle CCS at all

On Tue, May 30, 2017 at 12:14 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, May 26, 2017 at 04:30:06PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > >

Re: [Mesa-dev] [PATCH 3/6] etnaviv: honor PIPE_TRANSFER_UNSYNCHRONIZED flag

On Fri, 2017-05-19 at 11:41 +0200, Lucas Stach wrote: > This gets rid of quite a bit of CPU/GPU sync on frequent vertex buffer > uploads and I haven't seen any of the issues mentioned in the comment, > so this one seems stale. > > Ignore the flag if there exists a temporary resource, as those

[Mesa-dev] [Bug 101211] Mesa swrast issue with visualization on BE PPC PPC64

https://bugs.freedesktop.org/show_bug.cgi?id=101211 --- Comment #8 from intermedi...@hotmail.com --- Thankyou for the good news! -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH 1/6] etnaviv: always do cpu_fini in transfer_unmap

On Fri, 2017-05-19 at 11:41 +0200, Lucas Stach wrote: > The cpu_fini() call pushes the buffer back into the GPU domain, which needs > to be done for all buffers, not just the ones with CPU written content. The > etnaviv kernel driver currently doesn't validate this, but may start to do > so at a

Re: [Mesa-dev] [PATCH v5 0/4] Disable glthread if libX11 isn't thread-safe

On Mon, 29 May 2017 17:12:05 +0100 Emil Velikov wrote: > On 29 May 2017 at 15:45, Dieter Nützel wrote: > > Hi Gregory, > > > > there isn't currently a copy of this on Mesa-Patchwork. > > Can you please send one over there? > > > > And maybe an

[Mesa-dev] [Bug 101211] Mesa swrast issue with visualization on BE PPC PPC64

https://bugs.freedesktop.org/show_bug.cgi?id=101211 --- Comment #7 from Ben Crocker --- (In reply to Ben Crocker from comment #6) > > *** This bug has been marked as a duplicate of bug 100613 *** This is the same as bug 100613, which resulted from commit

[Mesa-dev] [Bug 101211] Mesa swrast issue with visualization on BE PPC PPC64

https://bugs.freedesktop.org/show_bug.cgi?id=101211 Ben Crocker changed: What|Removed |Added Resolution|--- |DUPLICATE

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 Ben Crocker changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 14/30] intel/isl: Add an enum for describing auxiliary compression state

On Tue, May 30, 2017 at 1:43 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote: > > This enum describes all of the states that a auxiliary compressed > > surface can have. All of the states as well as normative language

Re: [Mesa-dev] [PATCH 01/30] i965: Mark depth surfaces as needing a HiZ resolve after blitting

On Tue, May 30, 2017 at 10:11:26AM +0300, Pohjolainen, Topi wrote: > > These both go to blitter engine which doesn't understand hiz. As the > destination is resolved just before the blit, why do we need this? Right, in terms of patch 14, this is the transition from Resolved to Aux Invalid?

<    1   2   3   >