On Tue, May 30, 2017 at 10:11:26AM +0300, Pohjolainen, Topi wrote:
>
> These both go to blitter engine which doesn't understand hiz. As the
> destination is resolved just before the blit, why do we need this?
Right, in terms of patch 14, this is the transition from Resolved to
Aux Invalid? Wherea
This patch:
Reviewed-by: Marek Olšák
Marek
On Tue, May 30, 2017 at 7:52 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> with some of the fp64 emulation, we are seeing shaders coming in with
>> 32K temps, they go out with 40 or so used, but while doing register
> renumber we need to store a lot
On 22 May 2017 at 15:32, Emil Velikov wrote:
> On 29 April 2017 at 15:37, Bartosz Tomczyk
> wrote:
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100741
>> Fixes: a5e733c6b52 mesa: drop current draw/read buffer when ctx is released
>> CC: Rob Clark
>> v2: add comment in code
>
> Revi
https://bugs.freedesktop.org/show_bug.cgi?id=100741
Emil Velikov changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=101071
--- Comment #9 from Emil Velikov ---
(In reply to warpme from comment #8)
> hmm,
>
> I just revert this commit on current 17.1 and itfails with OP problem.
> how it that?
Sounds like something has gone wrong during bisect. Be that a typo g
On Tue, May 30, 2017 at 8:03 AM, Emil Velikov wrote:
> On 30 May 2017 at 13:23, Rob Herring wrote:
>> sysmacros.h was getting implicitly included in types.h until recently in
>> AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h.
>>
> As long as it doesn't break the non-mast
Can someone please take a look at this one patch at least? I'm fine with
the rest of the series waiting a bit longer, but I would like to push
this bugfix patch in the next few days.
Thanks,
Lucas
Am Freitag, den 19.05.2017, 11:41 +0200 schrieb Lucas Stach:
> The cpu_fini() call pushes the buffer
On 30 May 2017 at 13:23, Rob Herring wrote:
> sysmacros.h was getting implicitly included in types.h until recently in
> AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h.
>
As long as it doesn't break the non-master branches - L, M, ...
Reviewed-by: Emil Velikov
-Emil
___
Since they haven't been altered for the last 9-12 revisions, and in
order to reduce the load of patches to rebase and carry, I just landed
the EGL side (patches 1-7), with my r-b added on the couple patches
I hadn't reviewed.
Cheers,
Eric
On Tuesday, 2017-05-30 17:23:40 +0530, Varad Gautam wrot
On 30 May 2017 at 09:24, Jussi Kukkonen wrote:
> On 29 May 2017 at 18:10, Emil Velikov wrote:
>>
>> On 29 May 2017 at 14:05, Jussi Kukkonen wrote:
>> > On 29 May 2017 at 15:20, Emil Velikov wrote:
>> >>
>> >> On 26 May 2017 at 14:55, Jussi Kukkonen
>> >> wrote:
>> >> > On 26 May 2017 at 14:32,
Reviewed-by: Tapani Pälli
On 05/30/2017 03:23 PM, Rob Herring wrote:
sysmacros.h was getting implicitly included in types.h until recently in
AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h.
Signed-off-by: Rob Herring
---
Android.common.mk | 1 +
1 file changed, 1
Is this a reimplementation of the same algorithm in a more efficient
manner, or an implementation of a different algorithm which happens to
also run faster? The reason I ask is whether I should be seeing any
differences in shader-db with these at all or not.
Cheers,
-ilia
On Tue, May 30, 2017
sysmacros.h was getting implicitly included in types.h until recently in
AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h.
Signed-off-by: Rob Herring
---
Android.common.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/Android.common.mk b/Android.common.mk
index b2bb
Dear all,
like I pointed out yesterday I've got a workaround for shaders that allocate
too many temporaries after the TGSI pass that can actually be discarded in the
sb pass but would fail before that in the tgsi-to-bc stage.
The patch should not interfere with most shaders that worked before, th
Related bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=99349
https://bugs.freedesktop.org/show_bug.cgi?id=50338
1. Allocate ctx.temp_reg and a limited number of registers
(R600_TEMP_REG_RESERVED=10) that are given out via r600_get_temp() before
the temporaries of the TGSI are allocated. That m
From: Ben Widawsky
Upper layers of the code will have the need to specify full or partial
resolves (more on this in the next patch). This code simply adds the new
enums and plumbs it in as minimally as necessary.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
From: Daniel Stone
When importing a dmabuf, verify that the tiling mode matches what was
expected.
Signed-off-by: Daniel Stone
Signed-off-by: Varad Gautam
---
src/mesa/drivers/dri/i965/brw_bufmgr.c | 12 ++--
src/mesa/drivers/dri/i965/brw_bufmgr.h | 3 ++-
src/mesa/drivers/dri/i9
From: Ben Widawsky
v2: Rename modifier to be more smart (Jason)
FINISHME: Use the kernel's final choice for the fb modifier
bwidawsk@norris2:~/intel-gfx/kmscube (modifiers $)
~/scripts/measure_bandwidth.sh ./kmscube none
Read bandwidth: 603.91 MiB/s
Write bandwidth: 615.28 MiB/s
bwidawsk@norri
From: Varad Gautam
v2: Rebase and reuse tiling/modifier map. (Daniel Stone)
v3: bump DRIimageExtension to version 15, fill external_only array.
Signed-off-by: Varad Gautam
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 79 +---
1 file ch
From: Varad Gautam
Add support for createImageFromDmaBufs2, adding a modifier to the
original, and allow importing CCS resources with auxiliary data from
dmabufs.
v2: avoid DRIimageExtension version bump, pass single modifier to
createImageFromDmaBufs2.
Signed-off-by: Varad Gautam
Signed-o
From: Ben Widawsky
Make the code only disable CCS when it has to, unlike before where it
disabled CCS and enabled it when it could. This is much more inline with
how it should work in a few patches, where we have fewer restrictions as
to when we disable CCS.
v2: Change CCS disabling to an assert
From: Ben Widawsky
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++-
src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++-
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++--
3 files changed, 6 inse
From: Ben Widawsky
On Gen9 hardware, the display engine is able to scanout a compressed
framebuffer by providing an offset to auxiliary compression information.
Unfortunately, the hardware is incapable of doing the same thing for the
fast clear color.
To mitigate this, the hardware introduced a
From: Ben Widawsky
v2: move is_aux into if block. (Jason)
Use else block instead of goto (Jason)
v3: Fix up logic for is_aux (Ben)
Fix up size calculations and add FIXME (Ben)
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c
From: Ben Widawsky
We no longer allocate a miptree for the mcs_buf, so this is not a useful
assertion.
Recommended-by: Topi Pohjolainen
Signed-off-by: Ben Widawsky
Reviewed-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8
1 file changed, 8 deletions(-)
di
From: Ben Widawsky
Allows us to continue utilizing common miptree creation using __DRIimage
without creating a new DRIimage (for the intel_process_dri2_buffer()
case).
This is a bit ugly, but I think it's the best one can do.
v2: This patch let's us remove the temporary no_aux variable since mt
From: Ben Widawsky
In the foreseeable future it doesn't seem to make sense to have multiple
resolve flags. What does make sense is to have the caller give an
indication to the lower layers what it things should be done for
resolve. The enum change distinguishes this binary selection.
v2: Make se
From: Ben Widawsky
v2: Try to keep the assert as recommended by Topi. This requires
modifying the num_samples check to be <= 1 because internally created
buffers set num_samples = 0.
v3: Buffers are proactively marked as scanout, often, and so checking
is_scanout in whether or not the buffer sup
From: Ben Widawsky
This code will disable actually creating these buffers for the scanout,
but it puts the allocation in place.
Primarily this patch is split out for review, it can be squashed in
later if preferred.
v2:
assert(mt->offset == 0) in ccs creation (as requested by Topi)
Remove bogus
From: Varad Gautam
adds a pscreen->resource_create_with_modifiers() to create textures
with modifier.
v2:
- stylefixes (Emil Velikov)
- don't return selected modifier from resource_create_with_modifiers. we can
use the winsys_handle to get this.
Signed-off-by: Varad Gautam
Reviewed-by: Lucas
From: Ben Widawsky
There is nothing particularly useful to do currently if the update
fails, but there is no point carrying on either. As a result, this has a
behavior change.
v2: Make the return type a bool (Topi)
v3: Don't leak the bo if update_winsys_renderbuffer fails. (Jason)
Signed-off-b
From: Ben Widawsky
This patch shouldn't actually do anything because the libdrm function
should already do this alignment. However, it preps us for a future
patch where we add in the CCS AUX size, and in the process it serves as
a good place to find bisectable issues if libdrm or kernel does
some
From: Varad Gautam
v2: split this into a separate patch (Jason)
Signed-off-by: Ben Widawsky
Signed-off-by: Daniel Stone
Cc: Jason Ekstrand
---
src/mesa/drivers/dri/i965/brw_context.c | 3 +++
src/mesa/drivers/dri/i965/intel_fbo.h | 7 +++
src/mesa/drivers/dri/i965/intel_mip
From: Ben Widawsky
This patch provides the support (and comments) for allocating the BO
with space for the CCS buffer just underneath it.
This patch was originally titled:
"i965: Create correctly sized mcs for an image"
In order to make things more bisectable, reviewable, and to have the
CCS_MO
From: Varad Gautam
support importing dmabufs into DRIimage while taking format modifiers
in account, as per DRIimage extension version 15.
v2: initialize winsys modifier to DRM_FORMAT_MOD_INVALID (Daniel Stone)
v3: do not bump DRIimageExtension version. split out winsys changes.
Signed-off-by:
From: Varad Gautam
ask the driver for supported dmabuf formats
v2: rebase to master.
v3: return false on failure.
v4: use pscreen->is_format_supported instead of adding a new query.
(Lucas Stach)
v5: stylefix to conform to formatting rules (Brian Paul). add fourcc list
here instead of us
From: Ben Widawsky
Previously our aux buffers (MCS, and HiZ) never had an offset because
they were in their own buffer object. When using the CCS lossless
compression feature, it's desirable to store the data at an offset from
the main framebuffer, ie. share a buffer object. This patch just makes
From: Varad Gautam
format modifiers tokens are driver specific, and hence, need to come
in from the driver. this allows drivers to be queried for supported
format modifiers for EGL_EXT_image_dma_buf_import_modifiers.
v2: rebase to master.
v3: drivers must return false on query failure.
v4: use p
From: Ben Widawsky
This provides a common function or creating miptrees when there is an
existing DRIimage to use. That provides an easy way to add CCS
allocation.
v2: Make the new function assume there are always no layout flags. This
will be adjusted later.
Signed-off-by: Ben Widawsky
Acked-
From: Varad Gautam
we use this to import resources with format modifiers, and to support
per-resource modifier queries.
Signed-off-by: Varad Gautam
Cc: Lucas Stach
---
src/gallium/include/state_tracker/drm_driver.h | 6 ++
src/gallium/state_trackers/dri/dri2.c | 7 +++
2 file
From: Daniel Stone
Intel hardware requires that all planes of an image come from the same
buffer, which is currently implemented by testing that all FDs are
numerically the same.
However, when going through a winsys (e.g.) or anything which transits
FDs individually, the FDs may be different eve
From: Varad Gautam
ask the driver for supported modifiers for a given format.
v2: move to __DRIimageExtension v16.
v3: fail if the supplied format is not supported by driver.
v4: purge PIPE_CAP_QUERY_DMABUF_ATTRIBS.
v5:
- move to __DRIimageExtension v15, pass external_only to the driver.
Signed
From: Daniel Stone
When allocating images, we record a tiling mode and then work backwards
to infer the modifier. Unfortunately this is the wrong way around, since
it is a one:many mapping (e.g. TILING_Y can be plain Y-tiling, or
Y-tiling with CCS).
Invert the mapping, so we record a modifier fi
From: Varad Gautam
query and return supported dmabuf format modifiers for
EGL_EXT_image_dma_buf_import_modifiers.
v2: move format check to the driver instead of making format queries
here and then checking.
v3: Check DRIimageExtension version before query (Daniel Stone)
v4:
- move to DRIimage
From: Varad Gautam
return the modifier selected by the driver when creating this image.
v2: since we can use winsys_handle->modifier to serve these, remove
DRIimage->modifier from v1.
use DRM_API_HANDLE_TYPE_KMS instead of DRM_API_HANDLE_TYPE_FD to avoid
ownership transfer. (Lucas)
From: Pekka Paalanen
The EGL_EXT_dma_buf_import_modifiers extension adds support for a
fourth plane, just like DRM KMS API does.
Bump maximum dma_buf plane count to four.
v2: prevent attribute tokens from being parsed if
EXT_image_dma_buf_import_modifiers is not suported. (Emil Velikov)
Si
Hi all,
Thanks for the reviews on v13, here's a new iteration of the egl modifiers
series.
The notable changes since v13 was sent by Daniel include:
* All dmabuf related functions in DRIimageExtension are now added under the
same version bump.
* Since modifier queries on a DRIimage can be handl
From: Varad Gautam
v2: check for DRIimageExtension version 15 (Jason Ekstrand)
Signed-off-by: Varad Gautam
Reviewed-by: Daniel Stone
Reviewed-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 6 ++
src/egl/main/eglapi.c | 1 +
2 files changed, 7 insertions(+)
diff --git a
these allow dmabuf import with modifiers, and supported format and
modifier queries, which are used to implement
EGL_EXT_image_dma_buf_import_modifiers.
v2:
- squash dmabuf queries into DRIimage version 15 (Jason Ekstrand).
- add external_only param to queryDmaBufModifiers (Emil, Daniel Stone)
- p
From: Pekka Paalanen
Rather than hardcoding 3, use a #define. Makes it easier to bump this
later to 4.
Signed-off-by: Pekka Paalanen
Signed-off-by: Varad Gautam
Reviewed-by: Eric Engestrom
Reviewed-by: Daniel Stone
---
src/egl/drivers/dri2/egl_dri2.c | 8
src/egl/main/eglimage.h
From: Varad Gautam
allow egl clients to query the dmabuf formats supported on this platform.
v2: return EGLBoolean.
v3: Check DRIimageExtension version before querying (Daniel Stone).
v4: move to DRIimageExtension version 15, error checking (Jason Ekstrand).
Signed-off-by: Louis-Francis Ratté-B
From: Varad Gautam
Allow creating EGLImages with dmabuf format modifiers when target is
EGL_LINUX_DMA_BUF_EXT for EGL_EXT_image_dma_buf_import_modifiers.
v2:
- clear modifier assembling and error label name (Eric Engestrom)
v3:
- remove goto jumps within switch-case (Emil Velikov)
- treat zero a
GLSL ES spec includes the following:
"It is an error to undefine or to redefine a built-in
(pre-defined) macro name."
But desktop GLSL doesn't. This has sparked some discussion
in Khronos, and the final conclusion was to update the
GLSL 4.50 spec to include the following:
"By conventio
Before resolving a rendertarget or a depth/stencil resource into a
texture, flush both the color cache and the depth cache together.
It is unclear whether this is necessary for the following stall to
work properly, or whether the depth flush just adds enough time
for the color cache flush to finis
https://bugs.freedesktop.org/show_bug.cgi?id=54971
--- Comment #2 from Emil Velikov ---
Mostly food for thought if anyone wants to pursue this:
- Call XOpenDisplay once, as mentioned already.
- Introduce an X API to compare two Display(s) - unless there's one already.
- Refcount the Display -
On Fri, May 26, 2017 at 04:30:04PM -0700, Jason Ekstrand wrote:
> This patch series does a complete overhaul of the current resolve handling
> framework inside the i916 OpenGL driver. For HiZ and MCS, the current
> resolve code is ok but not optimal. For CCS, however, it's pretty bad.
> I've been
On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote:
> This enum describes all of the states that a auxiliary compressed
> surface can have. All of the states as well as normative language for
> referring to each of the compression operations is provided in the
> truly colossal comment
On 29 May 2017 at 18:10, Emil Velikov wrote:
> On 29 May 2017 at 14:05, Jussi Kukkonen wrote:
> > On 29 May 2017 at 15:20, Emil Velikov wrote:
> >>
> >> On 26 May 2017 at 14:55, Jussi Kukkonen
> wrote:
> >> > On 26 May 2017 at 14:32, Emil Velikov
> wrote:
> >> >>
> >> >> On 26 May 2017 at 08:
On Fri, May 26, 2017 at 04:30:10PM -0700, Jason Ekstrand wrote:
> The new version now takes a range of levels as well as a range of
> layers. It should also be a tiny bit faster because it only walks the
> resolve_map list once instead of once per layer.
> ---
> src/mesa/drivers/dri/i965/brw_blor
On Fri, May 26, 2017 at 04:30:09PM -0700, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 70
> ---
> 1 file changed, 30 insertions(+), 40 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> b/src/mesa/drivers/dri/i
Reviewed-by: Samuel Pitoiset
On 05/30/2017 02:57 AM, Timothy Arceri wrote:
---
src/mesa/program/programopt.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/program/programopt.c b/src/mesa/program/programopt.c
index 501acde..f560bce 100644
--- a/src/mesa/
Reviewed-by: Samuel Pitoiset
On 05/30/2017 02:26 AM, Timothy Arceri wrote:
---
src/mesa/state_tracker/st_mesa_to_tgsi.c | 65
1 file changed, 32 insertions(+), 33 deletions(-)
diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c
b/src/mesa/state_tracker/st
On Fri, May 26, 2017 at 04:30:06PM -0700, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> b/src/mesa/drivers/dri/i965/brw_wm_sur
These both go to blitter engine which doesn't understand hiz. As the
destination is resolved just before the blit, why do we need this?
On Fri, May 26, 2017 at 04:30:05PM -0700, Jason Ekstrand wrote:
> Cc: "17.0 17.1"
> ---
> src/mesa/drivers/dri/i965/intel_blit.c | 2 ++
> 1 file changed, 2 in
https://bugs.freedesktop.org/show_bug.cgi?id=101214
Hans de Goede changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
201 - 265 of 265 matches
Mail list logo
