[Mesa-dev] [PATCH] svga: add some missing SVGA_STATS_* enum values, prefix strings

To fix the build when VMX86_STATS is defined. Also, some minor whitespace changes to match upstream code. --- src/gallium/drivers/svga/svga_winsys.h | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/svga/svga_winsys.h

[Mesa-dev] [Bug 101471] Mesa fails to build: unknown typename bool

https://bugs.freedesktop.org/show_bug.cgi?id=101471 --- Comment #1 from Emil Velikov --- I've tracked it down and have some patches in which I'm double-checking. Mind if I Cc you so you can confirm on your end? -- You are receiving this mail because: You are the

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: add new polaris12 pci id

Reviewed-by: Marek Olšák It won't make it to 17.0 though, because that doesn't receive any fixes anymore. Marek On Fri, Jun 16, 2017 at 6:13 PM, Alex Deucher wrote: > Signed-off-by: Alex Deucher > Cc: 17.0 17.1

[Mesa-dev] [PATCH v3 02/10] tgsi/dump: print _PRECISE modifier on Instructions

Signed-off-by: Karol Herbst Reviewed-by: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c b/src/gallium/auxiliary/tgsi/tgsi_dump.c index

[Mesa-dev] [PATCH v3 07/10] st/glsl_to_tgsi: don't optimize mul+add to mad if expression is precise

Signed-off-by: Karol Herbst --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 6cc5a39510..6ac267be94 100644 ---

[Mesa-dev] [PATCH v3 08/10] nv50/ir: add precise field to Instruction

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.h b/src/gallium/drivers/nouveau/codegen/nv50_ir.h index 5c09fed05c..6835c4fa8c 100644 ---

[Mesa-dev] [PATCH v3 10/10] nv50/ir: disable mul+add to mad for precise instructions

fixes missrendering in TombRaider KHR-GL44.gpu_shader5.precise_qualifier KHR-GL45.gpu_shader5.precise_qualifier Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH v3 09/10] nv50/ir/tgsi: handle precise for most ALU instructions

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp index

[Mesa-dev] [PATCH v3 04/10] tgsi: populate precise

Only implemented for glsl->tgsi. Other converters just set precise to 0. v2: remove precise paramter from ureg_tex_insn and ureg_memory_insn Signed-off-by: Karol Herbst --- src/gallium/auxiliary/tgsi/tgsi_build.c | 3 +++ src/gallium/auxiliary/tgsi/tgsi_ureg.c

[Mesa-dev] [PATCH v3 06/10] gallium/docs: add precise instruction modifier

Signed-off-by: Karol Herbst --- src/gallium/docs/source/tgsi.rst | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index c65d721dec..76c82b3e88 100644 ---

[Mesa-dev] [PATCH v3 05/10] tgsi/text: parse _PRECISE modifier

v2: use str_match_no_case to fix _SAT_PRECISE detection Signed-off-by: Karol Herbst --- src/gallium/auxiliary/tgsi/tgsi_text.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_text.c

[Mesa-dev] [PATCH v3 03/10] st/glsl_to_tgsi: handle precise modifier

all subexpression inside an ir_assignment needs to be tagged as precise. v2: make precise handling more global inside the visitor Signed-off-by: Karol Herbst --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 13 + 1 file changed, 13 insertions(+) diff --git

[Mesa-dev] [PATCH v3 01/10] tgsi: add precise flag to tgsi_instruction

Signed-off-by: Karol Herbst Reviewed-by: Nicolai Hähnle Reviewed-by: Roland Scheidegger --- src/gallium/auxiliary/tgsi/tgsi_build.c| 1 + src/gallium/include/pipe/p_shader_tokens.h | 3 ++- 2 files changed, 3

[Mesa-dev] [PATCH v3 00/10] Add precise/invariant semantics to TGSI

Running Tomb Raider on Nouveau I found some flicker caused by ignoring precise modifiers on variables inside Nouveau. This series add precise/invariant handling to TGSI, which can be then used by drivers to disable certain unsafe optimisations which may otherwise alter calculations, which depend

[Mesa-dev] [Bug 101471] Mesa fails to build: unknown typename bool

https://bugs.freedesktop.org/show_bug.cgi?id=101471 Bug ID: 101471 Summary: Mesa fails to build: unknown typename bool Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 11/15] i965: Add isl based miptree creator

On Fri, Jun 16, 2017 at 11:11 AM, Nanley Chery wrote: > On Tue, Jun 13, 2017 at 05:50:09PM +0300, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 76 >

Re: [Mesa-dev] [PATCH v2] swr: Don't crash when encountering a VBO with stride = 0.

Reviewed-by: Tim Rowley > On Jun 15, 2017, at 11:24 AM, Bruce Cherniak > wrote: The swr driver uses vertex_buffer->stride to determine the number of elements in a VBO. A

Re: [Mesa-dev] [RFC 13/22] RFC: vulkan: Update registry for MESAX dma_buf extensions

On Fri 16 Jun 2017, Emil Velikov wrote: > Hi gents, > > On 8 June 2017 at 19:44, Daniel Stone wrote: > > > - VK_MESAX_external_memory_dma_buf > > - VK_MESAX_external_image_dma_buf > Perhaps not so crazy idea: > > Considering a handful of the people involved

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

On Thu 15 Jun 2017, Rob Herring wrote: > On Tue, Jun 13, 2017 at 1:55 PM, Chad Versace > wrote: > > On Fri 09 Jun 2017, Tapani Pälli wrote: > >> > >> > >> On 06/08/2017 09:27 PM, Chad Versace wrote: > >> > On Thu 08 Jun 2017, Tomasz Figa wrote: > >> > > On Thu, Jun 8,

Re: [Mesa-dev] [PATCH 00/16] swr: rasterizer update

Reviewed-by: Bruce Cherniak > On Jun 15, 2017, at 1:37 PM, Tim Rowley wrote: > > Highlights include: jit cache (disabled currently), work in progress > to shrink the vertex structure used in the frontend, and refactoring > to speed

[Mesa-dev] [PATCH] ac: add missing stdint.h include for uint32_t

From: Emil Velikov Cc: Mark Janes Signed-off-by: Emil Velikov --- src/amd/common/ac_gpu_info.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/common/ac_gpu_info.h b/src/amd/common/ac_gpu_info.h index

Re: [Mesa-dev] [PATCH 11/15] i965: Add isl based miptree creator

On Tue, Jun 13, 2017 at 05:50:09PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 76 > +++ > 1 file changed, 76 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 05/11] gbm: Pull out FourCC <-> DRIimage format table

On Friday, 2017-06-16 18:14:28 +0100, Daniel Stone wrote: > Rather than duplicated (yet asymmetric) open-coded tables, pull them out > to a common structure. > > Signed-off-by: Daniel Stone > --- > src/gbm/Makefile.am| 1 + > src/gbm/backends/dri/gbm_dri.c |

Re: [Mesa-dev] [PATCH 07/11] gbm: Remove is_planar_format dead code

On Friday, 2017-06-16 18:14:30 +0100, Daniel Stone wrote: > This was only used in create_dumb() to blacklist planar formats. > However, the start of the function already whitelists ARGB (cursor) > and XRGB (scanout), and nothing else. So this entire function can be > removed. > >

Re: [Mesa-dev] [PATCH v1 2/3] nir: Add a lowering pass for UYVY textures Similar with support for YUYV but with byte order difference in sampler

Johnson Lin writes: > --- > src/compiler/nir/nir.h | 1 + > src/compiler/nir/nir_lower_tex.c | 16 > 2 files changed, 17 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index ab7ba14303b7..1b4e47058d4d 100644 >

Re: [Mesa-dev] [PATCH 10/15] i965/miptree: Add option to resolve offsets using isl_surf

On Tue, Jun 13, 2017 at 05:50:08PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 16 > 1 file changed, 16 insertions(+) > > diff --git

[Mesa-dev] [PATCH 05/11] gbm: Pull out FourCC <-> DRIimage format table

Rather than duplicated (yet asymmetric) open-coded tables, pull them out to a common structure. Signed-off-by: Daniel Stone --- src/gbm/Makefile.am| 1 + src/gbm/backends/dri/gbm_dri.c | 105 ++--- 2 files changed, 46

[Mesa-dev] [PATCH 06/11] gbm: Check harder for supported formats

Luckily no-one really used the is_format_supported() call, because it only supported three formats. Also, since buffers with alpha can be displayed on planes, stop banning them from use. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 40

[Mesa-dev] [PATCH 03/11] egl/wayland: Use MIN2 for wl_drm version

Use a slightly more explicit version cap for binding wl_drm, so we can add other interfaces with different versioning schemes later. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[Mesa-dev] [PATCH 07/11] gbm: Remove is_planar_format dead code

This was only used in create_dumb() to blacklist planar formats. However, the start of the function already whitelists ARGB (cursor) and XRGB (scanout), and nothing else. So this entire function can be removed. Signed-off-by: Daniel Stone ---

[Mesa-dev] [PATCH 09/11] egl/wayland: Remove more surface specifics from create_wl_buffer

Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 32 ++-- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index

[Mesa-dev] [PATCH 08/11] egl/wayland: Make create_wl_buffer more generic

Remove surface-specific code from create_wl_buffer, so it's now just a generic translation from DRIimage to wl_buffer. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 66 + 1 file changed, 34 insertions(+), 32

[Mesa-dev] [PATCH 11/11] egl/wayland: Use linux-dmabuf interface for buffers

When available, use the zwp_linux_dambuf_v1 interface to create buffers, which allows multiple planes and buffer modifiers to be used. Signed-off-by: Daniel Stone --- configure.ac| 5 +- src/egl/Makefile.am | 22 +++-

[Mesa-dev] [PATCH 04/11] gbm: Axe buffer import format conversion table

Wayland buffers coming from wl_drm use the WL_DRM_FORMAT_* enums, which are identical to GBM_FORMAT_*. Similarly, FD imports do not need to convert between GBM and DRI FourCC, since they are (almost) completely compatible. Signed-off-by: Daniel Stone ---

[Mesa-dev] [PATCH 02/11] egl/wayland: Fix whitespace damage

Convert tabs to spaces, fix misalignments. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 38 + 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c

[Mesa-dev] [PATCH 01/11] util: Remove u_math from u_vector

u_vector.h doesn't actually use anything from u_math, but it does mean everyone has to pull in src/gallium/auxiliary/util includes. Just remove it, adding a include to u_vector.c to cover memcpy. Signed-off-by: Daniel Stone --- src/util/u_vector.c | 2 ++

[Mesa-dev] [PATCH 00/11] EGL/Wayland modifiers, format cleanup

Hi, This series adds support for multi-planar buffers, as well as buffers with modifiers, in the Wayland EGL client platform. Rather than extending wl_drm, we use the generic zwp_linux_dambuf_v1 protocol, which is implemented in Weston. This makes it a bit easier to, amongst other things, write

[Mesa-dev] [PATCH 10/11] egl/wayland: Remove duplicate wl_buffer creation code

Now create_wl_buffer is generic enough, we can use it for the EGL_WL_create_wayland_buffer_from_image extension. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 71 + 1 file changed, 11 insertions(+), 60

Re: [Mesa-dev] [PATCH 09/15] i965: Prepare slice copy for isl based miptrees

On Thu, Jun 15, 2017 at 10:01:53PM +0300, Pohjolainen, Topi wrote: > On Thu, Jun 15, 2017 at 11:39:44AM -0700, Jason Ekstrand wrote: > > On Tue, Jun 13, 2017 at 7:50 AM, Topi Pohjolainen < > > topi.pohjolai...@gmail.com> wrote: > > > > > Signed-off-by: Topi Pohjolainen

[Mesa-dev] [PATCH] radeonsi: fix dumping shader descriptors into ddebug logs

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 76 ++--- 1 file changed, 41 insertions(+), 35 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index 25c3882..35bfec7

Re: [Mesa-dev] [PATCH 9/9] radeonsi: don't do any flushes at the end of IBs

Please ignore this patch. There are some regressions with depth_resolve piglit tests. Marek On Fri, Jun 16, 2017 at 2:58 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_hw_context.c | 3 +++ > 1 file changed, 3

Re: [Mesa-dev] [PATCH 02/15] i965: Add helper for converting isl tiling to bufmgr tiling

On Fri, Jun 16, 2017 at 07:58:02AM +0300, Pohjolainen, Topi wrote: > On Thu, Jun 15, 2017 at 05:18:22PM -0700, Nanley Chery wrote: > > On Tue, Jun 13, 2017 at 05:50:00PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > >

Re: [Mesa-dev] [PATCH 02/15] i965: Add helper for converting isl tiling to bufmgr tiling

On Thu, Jun 15, 2017 at 06:23:24PM -0700, Jason Ekstrand wrote: > On Thu, Jun 15, 2017 at 5:18 PM, Nanley Chery wrote: > > > On Tue, Jun 13, 2017 at 05:50:00PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > >

Re: [Mesa-dev] [PATCH v2 0/3][RFC]mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

Hello Emil, Am Freitag, den 16.06.2017, 15:21 +0100 schrieb Emil Velikov: > > Please don't use STL within core mesa code. May I ask why? I always try to not re-implement already available functionality and since mesa already uses C++ it seems kind of natural to use the STL because it provides

[Mesa-dev] [PATCH] radeonsi: add new polaris12 pci id

Signed-off-by: Alex Deucher Cc: 17.0 17.1 --- include/pci_ids/radeonsi_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index 50f638f..9453c1c

Re: [Mesa-dev] [PATCH 11/11] intel: Enable vulkan build for gen10

On Thu, Jun 15, 2017 at 4:12 PM, Jason Ekstrand wrote: > 7-11 are > > Reviewed-by: Jason Ekstrand > Thanks. > Have you tried reverting my patch and running the CTS? > No, I'll do it soon. > On Tue, Jun 13, 2017 at 11:28 AM, Anuj Phogat

[Mesa-dev] [PATCH v2 04/13] intel: common: express timestamps units in frequency

Rather than storing the period as a double that looses some precision. Also fixes the Gen9LP timestamp frequency which is no 19200123 but 1920 as pointed by Ville : https://lists.freedesktop.org/archives/intel-gfx/2017-April/125126.html Finally add the Cannonlake timestamp frequency.

[Mesa-dev] [PATCH v2 06/13] i965: Add Gen8+ sys_vars for generated OA code

From: Robert Bragg In preparation for adding XML OA metric set descriptions for Gen 8 and 9 which will result in auto generated code that depends on a number of new system variables ($EuSubslicesTotalCount, $EuThreadsCount and $SliceMask) this adds corresponding members to

[Mesa-dev] [PATCH v2 10/13] i965: perf: ensure isolated timer reports while idle don't confuse filtering

From: Robert Bragg From experimentation in IGT, we found that the OA unit might label some report as "idle" (using an invalid context ID), right after a report for a given context. Deltas generated by those reports actually belong to the previous context, even though

[Mesa-dev] [PATCH v2 08/13] i965: Add Gen8+ INTEL_performance_query support

From: Robert Bragg Enables access to OA unit metrics on Gen8+ via INTEL_performance_query. v2: make use of new parameters coming from gen_device_info (Lionel) Signed-off-by: Robert Bragg Signed-off-by: Lionel Landwerlin

[Mesa-dev] [PATCH v2 11/13] i965: perf: use gen_device_info rather then brw_context

Signed-off-by: Lionel Landwerlin Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_performance_query.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH v2 00/13] i965: Add performance query OA support on Gen 8 & 9

Hi, Here is a v2 following some comments by Ken. Some patches already have a rb-by/ack-by. Here is the list that needs looking at : 1, 2, 3, 4, 5 & 8. The list will probably filter some of the big patches, you can find the branch there :

[Mesa-dev] [PATCH v2 01/13] intel: common: add flag to identify platforms by name

The perf infrastructure needs to identify specific platforms, not just generations. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_device_info.c | 26 -- src/intel/common/gen_device_info.h | 4 2 files changed, 24

[Mesa-dev] [PATCH v2 05/13] intel: common: add number of thread per eu

This will be used by to normalize OA counters. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_device_info.c | 24 ++-- src/intel/common/gen_device_info.h | 6 ++ 2 files changed, 28 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v2 02/13] i965: perf: fix codegen with single operand equation

We did support single value operand equations, but not single variable operand ones. In particular we were failing on "$Sampler0Bottleneck". Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_oa.py | 4 +++- 1 file changed, 3 insertions(+), 1

[Mesa-dev] [PATCH v2 09/13] i965: perf: keep on reading reports until delimiting timestamp

Due to an underlying hardware race condition, we have no guarantee that all the reports coming from the OA buffer related to the workload we're trying to measure have landed to memory by the time all the work submitted has completed. That means we need to keep on reading the OA stream until we

[Mesa-dev] [PATCH v2 03/13] i965: convert MI_REPORT_PERF_COUNT to genxml

Also make it available from gen7 only to gen7+. Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_context.h | 11 src/mesa/drivers/dri/i965/brw_performance_query.c | 33 ---

[Mesa-dev] [PATCH 1/2] vc4: Switch back to using a local copy of vc4_drm.h.

Needing to get our uapi header from libdrm has only complicated things. Follow intel's lead and drop our requirement for it. Generated from 056f4f02abb7e9e4a0cf0cda0211586df5e43842 of drm-misc-next --- Sending this patch to the list due to touching configure.ac. configure.ac

[Mesa-dev] [PATCH 2/2] vc4: Set shareable BOs as T tiled if possible.

X11 and GL compositor performance on VC4 has been terrible because of our SHARED-usage buffers all being forced to linear. This swaps SHARED && !LINEAR buffers over to being tiled. This is an expected win for all GL compositors during rendering (a full copy of each shared texture per draw call),

Re: [Mesa-dev] [PATCH 2/2] ac/sid.h: don't use parentheses in PKT3_RELEASE_MEM definition

On Fri, Jun 16, 2017 at 8:30 AM, Marek Olšák wrote: > From: Marek Olšák > > The parses skips the line if it contains parentheses. Series is: Reviewed-by: Alex Deucher > --- > src/amd/common/sid.h | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

On 16 June 2017 at 15:45, Matt Turner wrote: > On Fri, Jun 16, 2017 at 6:18 AM, Emil Velikov > wrote: >> On 15 June 2017 at 21:47, Robert Foss wrote: >>> From: Rob Herring >>> >>> This is required by

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

On Fri, Jun 16, 2017 at 6:18 AM, Emil Velikov wrote: > On 15 June 2017 at 21:47, Robert Foss wrote: >> From: Rob Herring >> >> This is required by freedreno at least for GLES3 support. >> >> See docs/patents.txt for

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

On 16 June 2017 at 15:30, Rob Clark wrote: > On Fri, Jun 16, 2017 at 9:49 AM, Emil Velikov > wrote: >> On 16 June 2017 at 14:25, Rob Clark wrote: >>> On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov

Re: [Mesa-dev] [RFC 13/22] RFC: vulkan: Update registry for MESAX dma_buf extensions

Hi gents, On 8 June 2017 at 19:44, Daniel Stone wrote: > - VK_MESAX_external_memory_dma_buf > - VK_MESAX_external_image_dma_buf Perhaps not so crazy idea: Considering a handful of the people involved (Collabora, Google, Intel) are Khronos members, it should be

[Mesa-dev] [Bug 101467] swr driver leaks memory (texture management)

https://bugs.freedesktop.org/show_bug.cgi?id=101467 Bug ID: 101467 Summary: swr driver leaks memory (texture management) Product: Mesa Version: 17.1 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

On Fri, Jun 16, 2017 at 9:49 AM, Emil Velikov wrote: > On 16 June 2017 at 14:25, Rob Clark wrote: >> On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov >> wrote: >>> On 15 June 2017 at 21:47, Robert Foss

Re: [Mesa-dev] [PATCH v2 0/3][RFC]mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

Hi Gert, Welcome to Mesa, and apologies for chiming in so late. Please don't use STL within core mesa code. While some places do use it, those are quite isolated and have specific role. For example: - st/clover - heavily templated, pure C++ - drivers/swr - as above - drivers/nouveau/codegen -

Re: [Mesa-dev] [PATCH v1 6/7] android: add etnaviv driver build support

On Fri, Jun 16, 2017 at 8:24 AM, Emil Velikov wrote: > Hi Rob, > > There's a handful of small nitpicks, but nothing serious. > > On 15 June 2017 at 21:47, Robert Foss wrote: >> From: Rob Herring >> >> Add etnaviv to Android

Re: [Mesa-dev] [PATCH v1 7/7] android: build imx-drm winsys

Hi Rob, I missed something in the pl111+vc4 case, which is also applicable here. If one selects the DC w/o the GPU the build will fail. To resolve that one option is to simply pull the GPU static libs as dependencies for the DC ones. Some example/specifics below. On 15 June 2017 at 21:47,

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

On 16 June 2017 at 14:25, Rob Clark wrote: > On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov > wrote: >> On 15 June 2017 at 21:47, Robert Foss wrote: >>> From: Rob Herring >>> >>> This is required by

Re: [Mesa-dev] [PATCH v1 4/7] gbm: add XBGR8888 support for dumb buffers

Hi, On 15 June 2017 at 21:47, Robert Foss wrote: > From: Rob Herring > diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c > index 19be440d48..58b62ac361 100644 > --- a/src/gbm/backends/dri/gbm_dri.c > +++

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov wrote: > On 15 June 2017 at 21:47, Robert Foss wrote: >> From: Rob Herring >> >> This is required by freedreno at least for GLES3 support. >> >> See docs/patents.txt for

Re: [Mesa-dev] [PATCH v1 2/7] etnaviv: Add return statement to etna_amode so compiler is happy

2017-06-16 14:54 GMT+02:00 Emil Velikov : > On 15 June 2017 at 21:47, Robert Foss wrote: >> From: Tomeu Vizoso >> >> Signed-off-by: Robert Foss >> --- >>

Re: [Mesa-dev] [PATCH v1 6/7] android: add etnaviv driver build support

Hi Rob, There's a handful of small nitpicks, but nothing serious. On 15 June 2017 at 21:47, Robert Foss wrote: > From: Rob Herring > > Add etnaviv to Android makefiles. > > Signed-off-by: Rob Herring > --- > Android.mk

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

On 15 June 2017 at 21:47, Robert Foss wrote: > From: Rob Herring > > This is required by freedreno at least for GLES3 support. > > See docs/patents.txt for information about turning this on for s/w > renderers. > I'm inclined to agree with Tapani.

Re: [Mesa-dev] [PATCH v1 4/7] gbm: add XBGR8888 support for dumb buffers

On 15 June 2017 at 21:47, Robert Foss wrote: > From: Rob Herring > > Signed-off-by: Rob Herring > --- > src/gbm/backends/dri/gbm_dri.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH v1 3/7] gallium: os_process fixes for Android

On 16 June 2017 at 04:38, Chih-Wei Huang wrote: > 2017-06-16 4:47 GMT+08:00 Robert Foss : >> From: Rob Herring >> >> Signed-off-by: Rob Herring >> --- >> src/gallium/auxiliary/os/os_process.c | 5 +++-- >> 1

[Mesa-dev] [PATCH 1/9] radeonsi: add separate HUD counters for CB and DB cache flushes

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 3 ++- src/gallium/drivers/radeon/r600_query.c | 17 - src/gallium/drivers/radeon/r600_query.h | 3 ++- src/gallium/drivers/radeonsi/si_state_draw.c | 7 --- 4 files

[Mesa-dev] [PATCH 4/9] radeonsi: flush CB after MSAA only when transitioning from CB to textures

From: Marek Olšák The main flush before texturing is done after the FMASK decompress pass. CB after MSAA rendering is not flushed in set_framebuffer_state and also not in memory_barrier if the current color buffer is MSAA. We fully rely on the FMASK decompress pass for the

[Mesa-dev] [PATCH 9/9] radeonsi: don't do any flushes at the end of IBs

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_hw_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_hw_context.c b/src/gallium/drivers/radeonsi/si_hw_context.c index 5d930a6..b420c9f 100644 ---

[Mesa-dev] [PATCH 5/9] radeonsi/gfx9: indirect buffers and all CP packets use TC L2

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c| 5 +++-- src/gallium/drivers/radeonsi/si_pipe.c | 6 -- src/gallium/drivers/radeonsi/si_state.c | 4 +++- src/gallium/drivers/radeonsi/si_state_draw.c | 19 +++ 4 files

[Mesa-dev] [PATCH 6/9] radeonsi/gfx9: enable the constant engine

From: Marek Olšák I think this kernel commit fixes it: drm/amdgpu:use FRAME_CNTL for new GFX ucode --- src/gallium/drivers/radeonsi/si_pipe.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c

[Mesa-dev] [PATCH 8/9] radeonsi: don't emit partial flushes at the end of IBs

From: Marek Olšák The kernel sort of does the same thing with fences. --- src/gallium/drivers/radeonsi/si_hw_context.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_hw_context.c

[Mesa-dev] [PATCH 7/9] radeonsi/gfx9: keep reusing the same buffer/address for the gfx9 flush fence

From: Marek Olšák instead of using a monotonic suballocator --- src/gallium/drivers/radeonsi/si_pipe.c | 6 ++ src/gallium/drivers/radeonsi/si_pipe.h | 2 ++ src/gallium/drivers/radeonsi/si_state_draw.c | 16 3 files changed, 16

[Mesa-dev] [PATCH 0/9] RadeonSI cache flush optimizations

Hi, This series: - reworks CB (MSAA-only) and DB flushes - removes L2 flushes for CP packets and indirect buffers for GFX9 - enables the constant engine for GFX9 (yay!) - removes all flushes and waits from the end of IBs (relying on the kernel fence to do that) The rework of CB and DB flushes

[Mesa-dev] [PATCH 3/9] radeonsi: unify CB_RESOLVE blitter invocation code

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 35 +- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index f0abfdc..0993ebd

[Mesa-dev] [PATCH 2/9] radeonsi: flush DB caches only when transitioning from DB to texturing

From: Marek Olšák Use the mechanism of si_decompress_textures, but instead of doing the actual decompression, just flag the DB cache flush there. This removes a lot of unnecessary DB cache flushes. --- src/gallium/drivers/radeonsi/si_blit.c| 36

Re: [Mesa-dev] [PATCH v1 2/7] etnaviv: Add return statement to etna_amode so compiler is happy

On 15 June 2017 at 21:47, Robert Foss wrote: > From: Tomeu Vizoso > > Signed-off-by: Robert Foss > --- > src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive restart for non-strip prims based on app list

Hi, >From what I'm aware this is the progress on the fixes: TotalWarhammer and HitmanPro should now have a fix in shipping. MadMax, DeusExMD and DirtRally have the fix in a patch making it's way through our internal testing. We would still very much prefer to not have a special case for our

[Mesa-dev] [PATCH 1/2] ac: parse EVENT_WRITE_EOP, RELEASE_MEM, WAIT_REG_MEM, NOWHERE

From: Marek Olšák --- src/amd/common/ac_debug.c | 46 ++ src/amd/common/sid.h | 1 + 2 files changed, 47 insertions(+) diff --git a/src/amd/common/ac_debug.c b/src/amd/common/ac_debug.c index a8f81bf..79473ec 100644 ---

[Mesa-dev] [PATCH 2/2] ac/sid.h: don't use parentheses in PKT3_RELEASE_MEM definition

From: Marek Olšák The parses skips the line if it contains parentheses. --- src/amd/common/sid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/sid.h b/src/amd/common/sid.h index c69f4f6..a8c78c1 100644 --- a/src/amd/common/sid.h +++

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

On Fri, Jun 16, 2017 at 8:15 AM, Emil Velikov wrote: > On 16 June 2017 at 13:11, Ilia Mirkin wrote: >> On Jun 16, 2017 8:09 AM, "Emil Velikov" wrote: >> >> On 16 June 2017 at 13:00, Ilia Mirkin

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

On 16 June 2017 at 13:11, Ilia Mirkin wrote: > On Jun 16, 2017 8:09 AM, "Emil Velikov" wrote: > > On 16 June 2017 at 13:00, Ilia Mirkin wrote: >> On Fri, Jun 16, 2017 at 7:51 AM, Emil Velikov >>

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

On Jun 16, 2017 8:09 AM, "Emil Velikov" wrote: On 16 June 2017 at 13:00, Ilia Mirkin wrote: > On Fri, Jun 16, 2017 at 7:51 AM, Emil Velikov wrote: >> On 25 April 2017 at 15:32, Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

On 16 June 2017 at 13:00, Ilia Mirkin wrote: > On Fri, Jun 16, 2017 at 7:51 AM, Emil Velikov > wrote: >> On 25 April 2017 at 15:32, Emil Velikov wrote: >>> On 25 April 2017 at 15:06, Christian König

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

On Fri, Jun 16, 2017 at 7:51 AM, Emil Velikov wrote: > On 25 April 2017 at 15:32, Emil Velikov wrote: >> On 25 April 2017 at 15:06, Christian König wrote: >>> Am 25.04.2017 um 15:17 schrieb Ilia Mirkin:

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

On 25 April 2017 at 15:32, Emil Velikov wrote: > On 25 April 2017 at 15:06, Christian König wrote: >> Am 25.04.2017 um 15:17 schrieb Ilia Mirkin: >>> >>> [SNIP] >>> Is there a patch I should test? >> >> >> Patch is attached, but only compile

Re: [Mesa-dev] R600/AMDGPU fixes for Clover

On 15 June 2017 at 14:03, Aaron Watry wrote: > Hey all, > > We haven't landed the fixes to break the r600g dependency on AMDGPU yet. > I'm headed out of town for a long weekend and don't feel like risking the > push before being gone for five days. > > I've got a v3 of Emil's

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive restart for non-strip prims based on app list

Hi, Feral's games still enable primitive restart for all draw calls. FYI, I will push this patch on Monday if there is no other feedback. Some other points: - This is not the first occurrence of private app lists in drivers. r300 also has an app list in r300_chipset.c. - The list of Feral's

[Mesa-dev] [Bug 101252] eglGetDisplay() is not thread safe

https://bugs.freedesktop.org/show_bug.cgi?id=101252 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED

<    1   2   3   >