[Mesa-dev] [Bug 101829] read-after-free in st_framebuffer_validate

https://bugs.freedesktop.org/show_bug.cgi?id=101829 --- Comment #7 from charmai...@vmware.com --- Hi Gert, The original patch was indeed accessing the dangling pointers. I'll have a patch tomorrow to fix the problem. Thanks for looking into it. -- You are receiving this mail because: You are

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v3.1)

Hi Zhongmin, Thanks for the patch. Please see my comments inline. On Wed, Jul 19, 2017 at 12:22 PM, Zhongmin Wu wrote: > Before we queued the buffer with a invalid fence (-1), it will > make some benchmarks failed to test such as flatland. > > Now we get the out fence

[Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v3.1)

Before we queued the buffer with a invalid fence (-1), it will make some benchmarks failed to test such as flatland. Now we get the out fence during the flushing buffer and then pass it to SurfaceFlinger in eglSwapbuffer function. v2: a) Also implement the fence in cancelBuffer. b) The last

[Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v3)

Before we queued the buffer with a invalid fence (-1), it will make some benchmarks failed to test such as flatland. Now we get the out fence during the flushing buffer and then pass it to SurfaceFlinger in eglSwapbuffer function. v2: a) Also implement the fence in cancelBuffer. b) The last

[Mesa-dev] [PATCH 2/2] radv: port to new libdrm API.

From: Dave Airlie This bumps the libdrm requirement for amdgpu to the 2.4.82 (not yet released but soon). Signed-off-by: Dave Airlie --- configure.ac | 2 +- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 121

[Mesa-dev] [PATCH 1/2] radv: introduce some wrapper in cs code to make porting off libdrm_amdgpu easier.

From: Dave Airlie This just introduces a central semaphore info struct, and passes it around, and introduces some wrappers that will make porting off libdrm_amdgpu easier. Signed-off-by: Dave Airlie --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 88

[Mesa-dev] [Bug 101829] read-after-free in st_framebuffer_validate

https://bugs.freedesktop.org/show_bug.cgi?id=101829 --- Comment #6 from Gert Wollny --- The patch didn't help on my side. I've added some debug output to see what is going on. In summary, stfb->iface in st_manager.c is not properly updated and points to a destroyed

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #79 from anonymous --- Have the same issue with the tabs. Chromium 59.0.3071.104 Mesa 13.0.6 Kernel amd64 4.11.6-1 All as packaged by Debian (Debian Testing). Here is the output of chrome://gpu

Re: [Mesa-dev] [PATCH] glsl: xfb_stride applies to buffers, not block members

On 10/07/17 17:58, Juan A. Suarez Romero wrote: On Mon, 2017-07-10 at 14:30 +0800, Timothy Arceri wrote: On 8 July 2017 12:19:48 am GMT+08:00, "Juan A. Suarez Romero" wrote: When we have an interface block like: layout (xfb_buffer = 0, xfb_offset = 0) out Block {

Re: [Mesa-dev] [PATCH] nir: Use nir_src_copy instead of direct assignments.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] nir/vars_to_ssa: Handle missing struct members in foreach_deref_node

Reviewed-by: Timothy Arceri On 19/07/17 09:50, Jason Ekstrand wrote: This can happen if, for instance, you have an array of structs and there are both direct and wildcard references to the same struct and some members only have direct or only have indirect. ---

Re: [Mesa-dev] [PATCH v2 3/3] glsl: disable array splitting for AoA

I sent a replacement for patch 1. Patches 2 and 3 are Reviewed-by: Jason Ekstrand We should CC stable on my replacement for 1 and 2 because these affect Vulkan even without the AoA splitting patch. --Jason On Sat, Jul 15, 2017 at 12:48 AM, Timothy Arceri

Re: [Mesa-dev] [PATCH 1/3] nir: NULL check lower_copies_to_load_store()

On Tue, Jul 18, 2017 at 4:26 PM, Timothy Arceri wrote: > On 19/07/17 09:17, Jason Ekstrand wrote: > >> On Thu, Jun 29, 2017 at 7:45 PM, Timothy Arceri > > wrote: >> >> Allows us to disable array spliting for arrays

[Mesa-dev] [PATCH] nir/vars_to_ssa: Handle missing struct members in foreach_deref_node

This can happen if, for instance, you have an array of structs and there are both direct and wildcard references to the same struct and some members only have direct or only have indirect. --- src/compiler/nir/nir_lower_vars_to_ssa.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH] mesa: check API profile for GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION

On 07/18/2017 01:20 PM, Brian Paul wrote: > If we have a compat profile context, it means that GL_QUADS[_STRIP] are > supported so this query makes sense. It's also legal for 3.2 core profile > because of a spec bug. Do you know of any apps that depend on that spec bug? In most similar cases,

Re: [Mesa-dev] [PATCH 1/3] nir: NULL check lower_copies_to_load_store()

On 19/07/17 09:17, Jason Ekstrand wrote: On Thu, Jun 29, 2017 at 7:45 PM, Timothy Arceri > wrote: Allows us to disable array spliting for arrays of arrays without regressing tests such as:

Re: [Mesa-dev] [PATCH 1/3] nir: NULL check lower_copies_to_load_store()

On Thu, Jun 29, 2017 at 7:45 PM, Timothy Arceri wrote: > Allows us to disable array spliting for arrays of arrays without > regressing tests such as: > > ES31-CTS.functional.shaders.arrays_of_arrays.return. > explicit.struct_3x1x3_fragment > --- >

[Mesa-dev] [PATCH] nir: Use nir_src_copy instead of direct assignments.

If the source is an indirect register, there is ralloc'd data. Copying with a direct assignment will copy the pointer, but the data will still belong to the old instruction's memory context. Since we're lowering and throwing away instructions, that could free the data by mistake. Instead, use

Re: [Mesa-dev] [PATCH v3 8/8] egl/wayland: Use linux-dmabuf interface for buffers

Hi I'm currently getting a build failure with this patch in an out of tree build Making all in egl make[3]: Entering directory '/var/tmp/portage/media-libs/mesa-/work/mesa--abi_x86_32.x86/src/egl' /usr/bin/wayland-scanner code <

Re: [Mesa-dev] [PATCH mesa] spirv: add missing include path

On Tuesday, July 18, 2017 11:16:50 AM PDT Emil Velikov wrote: > On 18 July 2017 at 19:03, Eric Engestrom wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101831 > > Signed-off-by: Eric Engestrom > > --- > > > > Note: Android

Re: [Mesa-dev] [PATCH 1/4] ra: Pull the body of a loop out to a helper function.

Eric Anholt writes: > I was going to indent this code another level, and decided it would be > easier to read as a helper. Could some other user of the RA take a look at this series? signature.asc Description: PGP signature ___

[Mesa-dev] [PATCH v2 2/2] configure/swr: add KNL and SKX architecture targets

Not built by default. --- configure.ac | 22 ++-- src/gallium/drivers/swr/Makefile.am| 38 ++ src/gallium/drivers/swr/swr_loader.cpp | 20 ++ 3 files changed, 78 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v2 0/2] swr: add knl and skx architectures

Patch set allows the swr architectures built to be specified at configure time, and adds KNL and SKX as possible targets (not built by default). v2: * fix swr_archs default value, document knl,skx options * change loader lib selection code to make it clearer Tim Rowley (2): configure/swr:

[Mesa-dev] [PATCH v2 1/2] configure/swr: configurable swr architectures

Allow configuration of the SWR architecture depend libraries we build for with --with-swr-archs. Maintains current behavior by defaulting to avx,avx2. Scons changes made to make it still build and work, but without the changes for configuring which architectures. --- configure.ac

Re: [Mesa-dev] [PATCH 2/2] configure/swr: add KNL and SKX architecture targets

On Jul 17, 2017, at 11:51 AM, Emil Velikov > wrote: On 17 July 2017 at 15:08, Tim Rowley > wrote: Not built by default. --- configure.ac | 16

Re: [Mesa-dev] [PATCH 5/6] radeonsi: use slot indexes for bindless handles

On Mon, Jul 17, 2017 at 4:01 PM, Nicolai Hähnle wrote: > Hi Samuel, > > On 07.07.2017 03:45, Samuel Pitoiset wrote: >> >> On 07/05/2017 01:42 PM, Nicolai Hähnle wrote: >>> >>> On 04.07.2017 15:05, Samuel Pitoiset wrote: Using VRAM address as bindless handles is not a

Re: [Mesa-dev] [PATCH 1/2] configure/swr: configurable swr architectures

On Jul 17, 2017, at 11:42 AM, Emil Velikov > wrote: On 17 July 2017 at 15:08, Tim Rowley > wrote: Allow configuration of the SWR architecture depend libraries we build for

Re: [Mesa-dev] i965: Transition depth and stencil surfaces to isl

I've read through the whole thing and given reviews on about 75% of it. I did have some questions though. On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > First four patches are mechanical replacing intel_mipmap_tree native > members with equivalent found

Re: [Mesa-dev] [PATCH 22/22] i965: Represent depth surfaces with isl

On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_clear.c | 5 +- > src/mesa/drivers/dri/i965/gen8_depth_state.c | 3 +- >

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

On Tue, Jul 18, 2017 at 5:11 PM, Michel Dänzer wrote: > On 18/07/17 04:08 PM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> For lower overhead in the CS ioctl. >> Winsys allocators are not used with interprocess-sharable resources. >> >> v2: It

Re: [Mesa-dev] [PATCH 21/22] i965: Drop redundant check for non-tiled depth buffer

Reviewed-by: Jason Ekstrand On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Depth buffers are always Y-tiled. In brw_miptree_choose_tiling() > driver opts to use linear buffers for small and 1D but this does > not apply for depth -

Re: [Mesa-dev] [PATCH 20/22] intel/isl/gen4: Represent cube maps with 3D layout

I was sure I'd written this patch at least twice but I can't find it... :-( On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/intel/isl/isl.c | 40

Re: [Mesa-dev] [PATCH 13/22] i965/fbo: Add support for isl-based miptrees in rb wrapper

On Tuesday, July 18, 2017 1:46:23 AM PDT Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_fbo.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c >

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

On 18/07/17 04:08 PM, Marek Olšák wrote: From: Marek Olšák For lower overhead in the CS ioctl. Winsys allocators are not used with interprocess-sharable resources. v2: It shouldn't crash anymore, but the kernel will reject the new flag. ---

Re: [Mesa-dev] [PATCH 08/22] i965/wm: Prepare image surfaces for isl based

On Tuesday, July 18, 2017 1:46:18 AM PDT Topi Pohjolainen wrote: > There is a functional change: Before update_image_surface() didn't > shift the number of layers for 3D, now it does like > update_texture_image_param() did. > > Signed-off-by: Topi Pohjolainen > --- >

Re: [Mesa-dev] [PATCH 18/22] i965/miptree: Prepare aux state map for isl based

On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 16/22] i965/miptree: Represent w-tiled stencil surfaces with isl

Over-all, this looks fine. However, I'd like to see a reply to my comments on patch 4 before I give it a review. On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- >

Re: [Mesa-dev] [PATCH 15/22] i965/miptree: Prepare compressed offsets for isl based

On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 14/22] i965/miptree: Add support for imported bo offsets for isl based

Reviewed-by: Jason Ekstrand On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 13 + > 1 file changed, 13

Re: [Mesa-dev] [PATCH 13/22] i965/fbo: Add support for isl-based miptrees in rb wrapper

Reviewed-by: Jason Ekstrand On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_fbo.c | 4 > 1 file changed, 4 insertions(+) > >

Re: [Mesa-dev] [PATCH 12/22] i965: Prepare image setup from miptree for isl based

9-12 Reviewed-by: Jason Ekstrand On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_screen.c | 11 +-- > 1 file changed, 9

Re: [Mesa-dev] [PATCH 19/20] nir: Optimize find_lsb/imsb/umsb error checks

Reviewed-by: Connor Abbott On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: > Two of the ARB_shader_ballot piglit tests hit the find_lsb case, > removing some of the noise allowed me to better debug the test when it > was failing. > --- >

[Mesa-dev] [PATCH mesa 4/5] wayland-egl: Make wl_egl_window a versioned struct

We need wl_egl_window to be a versioned struct in order to keep track of ABI changes. This change makes the first member of wl_egl_window the version number. An heuristic in the wayland driver is added so that we don't break backwards compatibility: - If the first field (version) is an actual

[Mesa-dev] [PATCH mesa 5/5] wayland-egl: Update ABI checker

This change updates wayland-egl-abi-check.c with the latest changes to wl_egl_window. Signed-off-by: Miguel A. Vico Reviewed-by: James Jones --- .../wayland/wayland-egl/wayland-egl-abi-check.c| 78 ++ 1 file changed, 65

[Mesa-dev] [PATCH mesa 3/5] egl: Fix _eglPointerIsDereferencable() to ignore page residency

mincore() returns 0 on success, and -1 on failure. The last parameter is a vector of bytes with one entry for each page queried. mincore returns page residency information in the first bit of each byte in the vector. Residency doesn't actually matter when determining whether a pointer is

[Mesa-dev] [PATCH mesa 1/5] wayland-egl: Add wl_egl_window ABI checker

Add a small ABI checker for wl_egl_window so that we can check for backwards incompatible changes at 'make check' time. Signed-off-by: Miguel A. Vico Reviewed-by: James Jones --- src/egl/wayland/wayland-egl/Makefile.am| 10 +-

[Mesa-dev] [PATCH mesa 2/5] egl: Move _eglPointerIsDereferencable() to eglglobals.[ch]

More _eglPointerIsDereferencable() to eglglobals.[ch] and make it a non-static function so it can be used out of egldisplay.c Signed-off-by: Miguel A. Vico Reviewed-by: James Jones --- src/egl/main/egldisplay.c | 33 -

[Mesa-dev] [PATCH mesa 0/5] egl/wayland: Make wl_egl_window a versioned struct

Although we've always made backwards compatible changes to wl_egl_window, we are lacking of a versioning mechanism for EGL drivers that take a native wl_egl_window to check what set of features are exposed/available by the given struct. This series of patches aim to make wl_egl_window a versioned

Re: [Mesa-dev] [PATCH 08/22] i965/wm: Prepare image surfaces for isl based

On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > There is a functional change: Before update_image_surface() didn't > shift the number of layers for 3D, now it does like > update_texture_image_param() did. > I've got a patch in one of my trees to fix this

Re: [Mesa-dev] [PATCH 04/22] i965/miptree: Switch to isl_surf::row_pitch

On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_misc_state.c | 2 +- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- >

Re: [Mesa-dev] [PATCH 1.2/8] spirv: Generate spirv_info.c

Quoting Jason Ekstrand (2017-07-17 10:42:05) > Generally available things tend to be painful in Python because you have to > set > the python path if you ever want to import anything that isn't in your > directory.  That doesn't mean we shouldn't do it, just that the pain may be > too > high. 

Re: [Mesa-dev] [PATCH 10/20] nir: Add pass to scalarize read_invocation/read_first_invocation

AMD will want these to be scalar too. With Ken's fix, Reviewed-by: Connor Abbott On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: > i965 will want these to be scalar operations. > --- > src/compiler/Makefile.sources | 1 + >

Re: [Mesa-dev] [PATCH] dri: Make classic drivers allow __DRI_CTX_FLAG_NO_ERROR.

On 2017-07-18 20:25, Ian Romanick wrote: On 07/14/2017 04:10 PM, Kenneth Graunke wrote: Grigori recently added EGL_KHR_create_context_no_error support, which causes EGL to pass a new __DRI_CTX_FLAG_NO_ERROR flag to drivers when requesting an appropriate context mode. driContextSetFlags() will

Re: [Mesa-dev] [PATCH 08/20] nir: Add intrinsics from ARB_shader_ballot

With Ken's suggestion, Reviewed-by: Connor Abbott On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: > --- > src/compiler/glsl/glsl_to_nir.cpp | 45 > +++ > src/compiler/nir/nir_intrinsics.h | 13 +++ > 2

Re: [Mesa-dev] [PATCH 03/22] i965/miptree: Switch to isl_surf::tiling

On Tue, Jul 18, 2017 at 1:30 PM, Kenneth Graunke wrote: > On Tuesday, July 18, 2017 1:46:13 AM PDT Topi Pohjolainen wrote: > [snip] > > diff --git a/src/mesa/drivers/dri/i965/intel_blit.h > b/src/mesa/drivers/dri/i965/intel_blit.h > > index 5e4d1f5eb4..90514dc893 100644 >

Re: [Mesa-dev] [PATCH 03/22] i965/miptree: Switch to isl_surf::tiling

Hi, On 18 July 2017 at 21:30, Kenneth Graunke wrote: > On Tuesday, July 18, 2017 1:46:13 AM PDT Topi Pohjolainen wrote: > [snip] >> diff --git a/src/mesa/drivers/dri/i965/intel_blit.h >> b/src/mesa/drivers/dri/i965/intel_blit.h >> index 5e4d1f5eb4..90514dc893 100644 >>

Re: [Mesa-dev] [PATCH 03/20] nir: Support lowering vote intrinsics

On Mon, Jul 10, 2017 at 10:18 AM, Matt Turner wrote: > On Thu, Jul 6, 2017 at 8:04 PM, Connor Abbott wrote: >> On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: >>> ... trivially (as allowed by the spec!) by reusing the existing >>>

Re: [Mesa-dev] [PATCH 01/22] i965/miptree: Switch to isl_surf::msaa_layout

Reviewed-by: Jason Ekstrand On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 3 +- >

Re: [Mesa-dev] [PATCH 03/22] i965/miptree: Switch to isl_surf::tiling

On Tuesday, July 18, 2017 1:46:13 AM PDT Topi Pohjolainen wrote: [snip] > diff --git a/src/mesa/drivers/dri/i965/intel_blit.h > b/src/mesa/drivers/dri/i965/intel_blit.h > index 5e4d1f5eb4..90514dc893 100644 > --- a/src/mesa/drivers/dri/i965/intel_blit.h > +++

Re: [Mesa-dev] [PATCH 02/22] i965/miptree: Switch to isl_surf::samples

On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp.c| 16 - > src/mesa/drivers/dri/i965/brw_context.c | 2 +- >

Re: [Mesa-dev] [PATCH v3 1/2] gallium/util: Implement util_format_is_etc

Reviewed-by: Marek Olšák Marek On Tue, Jul 18, 2017 at 6:01 AM, wrote: > From: "Wladimir J. van der Laan" > > This is the equivalent of util_format_is_s3tc, but for > ETC. > > Signed-off-by: Wladimir J. van der Laan

[Mesa-dev] [PATCH] mesa: check API profile for GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION

If we have a compat profile context, it means that GL_QUADS[_STRIP] are supported so this query makes sense. It's also legal for 3.2 core profile because of a spec bug. --- src/mesa/main/get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/get.c

Re: [Mesa-dev] [PATCH] gallium: auxiliary: Fix standalone Android build of u_cpu_detect (v2)

Reviewed-by: Marek Olšák Marek On Tue, Jul 18, 2017 at 3:20 AM, Tomasz Figa wrote: > Commit 463b7d0332c5("gallium: Enable ARM NEON CPU detection.") > introduced CPU feature detection based Android cpufeatures library. > Unfortunately it also added an

Re: [Mesa-dev] [PATCH] mesa: fix GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION_EXT query

On 07/18/2017 12:19 PM, Ian Romanick wrote: Also... I'm not a huge fan of a Reviewed-by from someone new to the mailing list with zero commits in Mesa resulting in an instant commit (no offense to Neha). That's not okay. For the review system to have value, we have to give people time to

Re: [Mesa-dev] [PATCH] mesa: fix GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION_EXT query

On 07/18/2017 12:11 PM, Ian Romanick wrote: On 07/17/2017 11:28 AM, Brian Paul wrote: This query is not allowed in GL core profile 3.3 and later (since GL_QUADS and GL_QUAD_STRIP are disallowed). The query was (mistakenly) supported in GL 3.2. This fixes the glGet error test accordingly. ---

[Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

From: Marek Olšák For lower overhead in the CS ioctl. Winsys allocators are not used with interprocess-sharable resources. v2: It shouldn't crash anymore, but the kernel will reject the new flag. --- src/gallium/drivers/radeon/r600_buffer_common.c | 7 +

Re: [Mesa-dev] [PATCH 01/20] nir: Add intrinsics from ARB_shader_group_vote

With Ken's suggestion, this is Reviewed-by: Connor Abbott On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: > These are intrinsics rather than opcodes, because they operate across > channels. > --- > src/compiler/glsl/glsl_to_nir.cpp | 22

[Mesa-dev] [Bug 101829] read-after-free in st_framebuffer_validate

https://bugs.freedesktop.org/show_bug.cgi?id=101829 --- Comment #5 from charmai...@vmware.com --- Hi Brad, Can you try the attached patch to see if that fixes your crash? Thanks. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 101829] read-after-free in st_framebuffer_validate

https://bugs.freedesktop.org/show_bug.cgi?id=101829 --- Comment #4 from charmai...@vmware.com --- Created attachment 132747 --> https://bugs.freedesktop.org/attachment.cgi?id=132747=edit Assign a unique ID to the framebuffer interface object created in xm_st.c -- You are receiving this mail

[Mesa-dev] [Bug 101829] read-after-free in st_framebuffer_validate

https://bugs.freedesktop.org/show_bug.cgi?id=101829 --- Comment #3 from Gert Wollny --- I can confirm that the trace results in a sigsegv, but with gltrace on r600g I get a different backtrace (9ee67467c9ea + a patchset related to register merging that shouldn't have to do

Re: [Mesa-dev] [PATCH] dri: Make classic drivers allow __DRI_CTX_FLAG_NO_ERROR.

On 07/14/2017 04:10 PM, Kenneth Graunke wrote: > Grigori recently added EGL_KHR_create_context_no_error support, > which causes EGL to pass a new __DRI_CTX_FLAG_NO_ERROR flag to > drivers when requesting an appropriate context mode. > > driContextSetFlags() will already handle it properly for us,

Re: [Mesa-dev] [PATCH] mesa: fix GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION_EXT query

Also... I'm not a huge fan of a Reviewed-by from someone new to the mailing list with zero commits in Mesa resulting in an instant commit (no offense to Neha). That's not okay. For the review system to have value, we have to give people time to respond to patches. This patch hit the list less

Re: [Mesa-dev] [PATCH mesa] spirv: add missing include path

On Tue, Jul 18, 2017 at 11:15 AM, Ian Romanick wrote: > I can believe the fix, but I don't understand why it's necessary. > spirv_info.c includes spriv_info.h in the same manner as before > 2dd4e2ec, and, as far as I can understand, spirv_info.c gets built in > the same way

Re: [Mesa-dev] [PATCH mesa] spirv: add missing include path

On 18 July 2017 at 19:03, Eric Engestrom wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101831 > Signed-off-by: Eric Engestrom > --- > > Note: Android and SCons probably need a similar fix > --- >

Re: [Mesa-dev] [PATCH mesa] spirv: add missing include path

I can believe the fix, but I don't understand why it's necessary. spirv_info.c includes spriv_info.h in the same manner as before 2dd4e2ec, and, as far as I can understand, spirv_info.c gets built in the same way as before. Can someone explain to me why it broke? ...because I don't want to break

[Mesa-dev] [Bug 101831] Build failure in GNOME Continuous

https://bugs.freedesktop.org/show_bug.cgi?id=101831 Kenneth Graunke changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] mesa: fix GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION_EXT query

On 07/17/2017 11:28 AM, Brian Paul wrote: > This query is not allowed in GL core profile 3.3 and later (since > GL_QUADS and GL_QUAD_STRIP are disallowed). The query was (mistakenly) > supported in GL 3.2. This fixes the glGet error test accordingly. > --- > src/mesa/main/get.c |

[Mesa-dev] [PATCH mesa] spirv: add missing include path

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101831 Signed-off-by: Eric Engestrom --- Note: Android and SCons probably need a similar fix --- src/compiler/Makefile.nir.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/Makefile.nir.am

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing

For comments only. There are some assertion failures. Marek On Tue, Jul 18, 2017 at 1:47 PM, Marek Olšák wrote: > From: Marek Olšák > > for lower overhead in the CS ioctl > --- > src/gallium/drivers/radeon/r600_buffer_common.c | 7 +++ >

[Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing

From: Marek Olšák for lower overhead in the CS ioctl --- src/gallium/drivers/radeon/r600_buffer_common.c | 7 +++ src/gallium/drivers/radeon/radeon_winsys.h | 1 + src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 6 ++ 3 files changed, 14 insertions(+) diff

Re: [Mesa-dev] [PATCH v3 08/16] anv: Transition more color buffer layouts

On Mon, Jul 17, 2017 at 02:41:32PM -0700, Jason Ekstrand wrote: > On Fri, Jul 14, 2017 at 2:42 AM, Nanley Chery wrote: > > > On Mon, Jul 10, 2017 at 10:14:21AM -0700, Jason Ekstrand wrote: > > > On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery > >

[Mesa-dev] [Bug 101831] Build failure in GNOME Continuous

https://bugs.freedesktop.org/show_bug.cgi?id=101831 Bug ID: 101831 Summary: Build failure in GNOME Continuous Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] egl/dri2: remove unused buffer_count variable

On 18 July 2017 09:12:50 BST, Gwan-gyeong Mun wrote: > It removes unused buffer_count variable from dri2_egl_surface. > And it polishes the assert of dri2_drm_get_buffers_with_format(). > > Signed-off-by: Mun Gwan-gyeong Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [v2 8/16] i965/wm: Use isl for filling tex image parameters

Both 7.5 and 8 are Reviewed-by: Jason Ekstrand On Tue, Jul 18, 2017 at 12:23 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > This helps to drop dependency to miptree::total_height which is > used in brw_miptree_get_vertical_slice_pitch(). > > CC: Jason

Re: [Mesa-dev] [7.5/16] intel/isl: Take 3D surfaces into account in image params

I looked at Vulkan and I don't *think* this will break anything. On Tue, Jul 18, 2017 at 12:23 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > CC: Jason Ekstrand > Signed-off-by: Topi Pohjolainen > --- >

[Mesa-dev] [Bug 101829] read-after-free in st_framebuffer_validate

https://bugs.freedesktop.org/show_bug.cgi?id=101829 --- Comment #2 from Brad King --- I have a script that updates Mesa every night. After noticing the problem I bisected back to 147d7fb772. I just tried with current master (a522ce9977) and it still happens. For

[Mesa-dev] [Bug 101829] read-after-free in st_framebuffer_validate

https://bugs.freedesktop.org/show_bug.cgi?id=101829 Brian Paul changed: What|Removed |Added CC||charmai...@vmware.com

[Mesa-dev] [Bug 101829] read-after-free in st_framebuffer_validate

https://bugs.freedesktop.org/show_bug.cgi?id=101829 Brian Paul changed: What|Removed |Added CC||bri...@vmware.com --

[Mesa-dev] [Bug 101829] read-after-free in st_framebuffer_validate

https://bugs.freedesktop.org/show_bug.cgi?id=101829 --- Comment #1 from Brian Paul --- Hi Brad, I'm not able to repro the problem so far. Valgrind shows no errors with your trace. I've both tried Mesa @ 147d7fb772 and ToT as of this morning (a522ce997779). I tested with

[Mesa-dev] [Bug 101829] read-after-free in st_framebuffer_validate

https://bugs.freedesktop.org/show_bug.cgi?id=101829 Bug ID: 101829 Summary: read-after-free in st_framebuffer_validate Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] radeonsi: add back the USE_MININUM_PRIORITY flag to the low-prio compiler queue

On 17.07.2017 17:56, Marek Olšák wrote: From: Marek Olšák Accidentally removed in 9f320e0a387a1009c5218daf130b3b754a3c2800. Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH 3/4] docs: avoid overwrite of LD_LIBRARY_PATH during basic testing

On Tue, 2017-07-18 at 10:48 +0100, Emil Velikov wrote: > On 15 July 2017 at 17:01, Andres Gomez wrote: > > On Mon, 2017-07-10 at 12:19 +0100, Emil Velikov wrote: > > > On 8 July 2017 at 20:59, Andres Gomez wrote: > > > > The LD_LIBRARY_PATH environment

Re: [Mesa-dev] [PATCH v3 1/2] gallium/util: Implement util_format_is_etc

Reviewed-by: Ilia Mirkin On Tue, Jul 18, 2017 at 6:01 AM, wrote: > From: "Wladimir J. van der Laan" > > This is the equivalent of util_format_is_s3tc, but for > ETC. > > Signed-off-by: Wladimir J. van der Laan > ---

Re: [Mesa-dev] [PATCH 4/4] dri: Add KHR_no_error toggle to driconf

On 18 July 2017 at 09:26, Grigori Goronzy wrote: > On 2017-07-17 19:21, Emil Velikov wrote: >> >> On 13 July 2017 at 12:09, Grigori Goronzy wrote: >>> >>> On 2017-07-12 15:15, Emil Velikov wrote: As mentioned in earlier commit no_error should

Re: [Mesa-dev] [PATCH mesa] vulkan/util: fix typo in comment

Reviewed-by: Lionel Landwerlin On 18/07/17 11:08, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/vulkan/util/gen_enum_to_str.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1.2/8 v2] spirv: Generate spirv_info.c

On 17 July 2017 at 20:31, Ian Romanick wrote: > From: Ian Romanick > > The old table based spirv_*_to_string functions would return NULL for > any values "inside" the table that didn't have entries. The tables also > needed to be updated by hand

Re: [Mesa-dev] [PATCH 1/2] egl/drm: Fix misused x and y offsets on swrast_put_image2()

On Tuesday, 2017-07-18 03:11:50 +0900, Gwan-gyeong Mun wrote: > It fixes misused x and y offsets on the calculation of the memory copy > regions. > And it adds limits of the height and the width on the copy region. > > Signed-off-by: Mun Gwan-gyeong Fixes:

[Mesa-dev] [PATCH mesa] vulkan/util: fix typo in comment

Signed-off-by: Eric Engestrom --- src/vulkan/util/gen_enum_to_str.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vulkan/util/gen_enum_to_str.py b/src/vulkan/util/gen_enum_to_str.py index fb31addf94..ef37972c20 100644 ---

[Mesa-dev] [PATCH v3 2/2] etnaviv: Add support for ETC2 texture compression

From: "Wladimir J. van der Laan" Add support for ETC2 compressed textures in the etnaviv driver. One step closer towards GL ES 3 support. For now, treat SRGB and RGB formats the same. It looks like these are distinguished using a different bit in sampler state, and not part

[Mesa-dev] [PATCH v3 1/2] gallium/util: Implement util_format_is_etc

From: "Wladimir J. van der Laan" This is the equivalent of util_format_is_s3tc, but for ETC. Signed-off-by: Wladimir J. van der Laan --- src/gallium/auxiliary/util/u_format.h | 13 + 1 file changed, 13 insertions(+) diff --git

  1   2   >