Re: [Mesa-dev] [PATCH] glsl: set old ldexp operand to NULL when lowering

2017-08-17 Thread Gert Wollny
Am Freitag, den 18.08.2017, 09:43 +1000 schrieb Timothy Arceri: > This fixes an assert during IR validation in LLVMpipe. > > Fixes: e2e2c5abd279 (glsl: calculate number of operands in an > expression once) > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102274 > Cc: Brian Paul

Re: [Mesa-dev] [PATCH V2] i965: enable STD430 packing by default on IVB+

2017-08-17 Thread Jason Ekstrand
On August 17, 2017 7:04:20 PM Timothy Arceri wrote: v2: Add full description of the SNB issue to the TODO. --- src/mesa/drivers/dri/i965/brw_context.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c

Re: [Mesa-dev] [PATCH 1/3] isl: Add a null surface fill function.

2017-08-17 Thread Jason Ekstrand
On August 17, 2017 4:36:42 PM Kenneth Graunke wrote: ISL already offers functions to fill out most kinds of SURFACE_STATE, so why not handle null surfaces too? Null surfaces are simple, so we can just take the dimensions, rather than an entirte fill structure. ---

[Mesa-dev] [PATCH V2 0/2] mesa: Modify drirc options

2017-08-17 Thread QuRyu
From: Quentin Liu This serie of patches changes drirc's semanticaclly boolean options, options that are enum type options but which in essence are boolean options e.g. pp_shalde, into actual boolean optioinns. Backwawrd compatbility is maintained by relaxinig

[Mesa-dev] [PATCH V2 1/2] mesa: Fix backward compatibility for XML parser

2017-08-17 Thread QuRyu
From: Quentin Liu If the type of drirc options are changed, the parser will not be able to recognize xml files that had been present before the change. To achieve backward compatibility, the parser is relaxed to recognize boolean type options with enum values. ---

[Mesa-dev] [PATCH V2 2/2] mesa: Modify drirc option types

2017-08-17 Thread QuRyu
From: Quentin Liu The type and default values of certain drirc options are changed, namely, those semantically boolean options such as pp_celshade. --- src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 8 src/util/xmlpool/t_options.h

Re: [Mesa-dev] [PATCH] i965/miptree: Return NONE from texture_aux_usage when fully resolved

2017-08-17 Thread Kenneth Graunke
On Thursday, August 17, 2017 6:07:18 PM PDT Jason Ekstrand wrote: > This little optimization improves the performance of SynMark v7 > TexFilterTri by almost 10% on Sky Lake GT4 among other improvements. > We've been doing it for some time but somehow it got dropped during > the miptree

[Mesa-dev] [Bug 102274] assertion failure in ir_validate.cpp:240

2017-08-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102274 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH] android: fix gallium_dri.so can't be loaded by drm_gralloc

2017-08-17 Thread Qiang Yu
The problem is in gallium/winsys/amdgpu/drm/Android.mk which will have duplacated symbols when linking gallium_dri.so for libLLVMCore and libLLVM. Signed-off-by: Qiang Yu Signed-off-by: Mauro Rossi Signed-off-by: Rob Herring ---

[Mesa-dev] [PATCH V2] i965: enable STD430 packing by default on IVB+

2017-08-17 Thread Timothy Arceri
v2: Add full description of the SNB issue to the TODO. --- src/mesa/drivers/dri/i965/brw_context.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index d97a24fbf8..11cb2f7226 100644 ---

Re: [Mesa-dev] [PATCH 04/11] i965: enable STD430 packing by default on IVB+

2017-08-17 Thread Jason Ekstrand
On Thu, Aug 17, 2017 at 4:45 PM, Timothy Arceri wrote: > > > On 18/08/17 00:33, Jason Ekstrand wrote: > >> On Thu, Aug 17, 2017 at 4:03 AM, Timothy Arceri > > wrote: >> >> --- >>

Re: [Mesa-dev] [PATCH] glsl: set old ldexp operand to NULL when lowering

2017-08-17 Thread Brian Paul
Reviewed-by: Brian Paul Tested-by: Brian Paul Thanks! On 08/17/2017 05:43 PM, Timothy Arceri wrote: This fixes an assert during IR validation in LLVMpipe. Fixes: e2e2c5abd279 (glsl: calculate number of operands in an expression once) Bugzilla:

Re: [Mesa-dev] [PATCH] mesa: count uniform against storage when its bindless

2017-08-17 Thread Timothy Arceri
On 18/08/17 11:00, Kenneth Graunke wrote: On Thursday, August 17, 2017 4:41:52 PM PDT Timothy Arceri wrote: On 18/08/17 08:30, Kenneth Graunke wrote: On Tuesday, August 15, 2017 3:42:29 AM PDT Timothy Arceri wrote: Gallium drivers use this code path so we need to account for bindless after

Re: [Mesa-dev] [PATCH 1/9] ralloc: Allow reparenting to a NULL context

2017-08-17 Thread Jason Ekstrand
On Thu, Aug 17, 2017 at 5:49 PM, Kenneth Graunke wrote: > On Thursday, August 17, 2017 4:54:05 PM PDT Timothy Arceri wrote: > > > > On 18/08/17 09:05, Kenneth Graunke wrote: > > > On Thursday, August 17, 2017 10:22:15 AM PDT Jason Ekstrand wrote: > > >> --- > > >>

[Mesa-dev] [PATCH] i965/miptree: Return NONE from texture_aux_usage when fully resolved

2017-08-17 Thread Jason Ekstrand
This little optimization improves the performance of SynMark v7 TexFilterTri by almost 10% on Sky Lake GT4 among other improvements. We've been doing it for some time but somehow it got dropped during the miptree refactoring. Bugzilla: https://bugs.freedesktop.org/102258 Cc: "17.2"

Re: [Mesa-dev] [PATCH] mesa: count uniform against storage when its bindless

2017-08-17 Thread Kenneth Graunke
On Thursday, August 17, 2017 4:41:52 PM PDT Timothy Arceri wrote: > On 18/08/17 08:30, Kenneth Graunke wrote: > > On Tuesday, August 15, 2017 3:42:29 AM PDT Timothy Arceri wrote: > >> Gallium drivers use this code path so we need to account for > >> bindless after all. > > > > Why do Gallium

[Mesa-dev] [Bug 102274] assertion failure in ir_validate.cpp:240

2017-08-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102274 Michel Dänzer changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 1/9] ralloc: Allow reparenting to a NULL context

2017-08-17 Thread Kenneth Graunke
On Thursday, August 17, 2017 4:54:05 PM PDT Timothy Arceri wrote: > > On 18/08/17 09:05, Kenneth Graunke wrote: > > On Thursday, August 17, 2017 10:22:15 AM PDT Jason Ekstrand wrote: > >> --- > >> src/util/ralloc.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git

Re: [Mesa-dev] [PATCH 1/9] ralloc: Allow reparenting to a NULL context

2017-08-17 Thread Jason Ekstrand
On August 17, 2017 4:54:42 PM Timothy Arceri wrote: On 18/08/17 09:05, Kenneth Graunke wrote: On Thursday, August 17, 2017 10:22:15 AM PDT Jason Ekstrand wrote: --- src/util/ralloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] winsys/svga/drm: Include sys/types.h

2017-08-17 Thread Khem Raj
vmw_screen.h uses dev_t which is defines in sys/types.h this header is required to be included for getting dev_t definition. This issue happens on musl C library, it is hidden on glibc since sys/types.h is included through another system headers Signed-off-by: Khem Raj ---

Re: [Mesa-dev] [PATCH v2 1/1] clover: Wait for requested operation if blocking flag is set

2017-08-17 Thread Francisco Jerez
Jan Vesely writes: > On Tue, 2017-08-15 at 12:00 -0700, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > On Sat, 2017-08-12 at 20:14 -0700, Francisco Jerez wrote: >> > > Jan Vesely writes: >> > > >> > > > On Sat,

Re: [Mesa-dev] [PATCH 1/9] ralloc: Allow reparenting to a NULL context

2017-08-17 Thread Timothy Arceri
On 18/08/17 09:05, Kenneth Graunke wrote: On Thursday, August 17, 2017 10:22:15 AM PDT Jason Ekstrand wrote: --- src/util/ralloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/ralloc.c b/src/util/ralloc.c index bf46439..4015c7e 100644 --- a/src/util/ralloc.c

Re: [Mesa-dev] [PATCH] radv: disable support for VEGA for now.

2017-08-17 Thread Bas Nieuwenhuizen
r-b On Fri, Aug 18, 2017, at 01:39, Dave Airlie wrote: > From: Dave Airlie > > I'm working on this, but I'm not sure I'll make 17.2 at this stage, > maybe 17.2.1. > > Cc: "17.2" > Signed-off-by: Dave Airlie > --- >

Re: [Mesa-dev] [PATCH 04/11] i965: enable STD430 packing by default on IVB+

2017-08-17 Thread Timothy Arceri
On 18/08/17 00:33, Jason Ekstrand wrote: On Thu, Aug 17, 2017 at 4:03 AM, Timothy Arceri > wrote: --- src/mesa/drivers/dri/i965/brw_context.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Mesa-dev] [PATCH] glsl: set old ldexp operand to NULL when lowering

2017-08-17 Thread Timothy Arceri
This fixes an assert during IR validation in LLVMpipe. Fixes: e2e2c5abd279 (glsl: calculate number of operands in an expression once) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102274 Cc: Brian Paul --- src/compiler/glsl/lower_instructions.cpp | 1 + 1 file

Re: [Mesa-dev] [PATCH] mesa: count uniform against storage when its bindless

2017-08-17 Thread Timothy Arceri
On 18/08/17 08:30, Kenneth Graunke wrote: On Tuesday, August 15, 2017 3:42:29 AM PDT Timothy Arceri wrote: Gallium drivers use this code path so we need to account for bindless after all. Why do Gallium drivers use ir_to_mesa? That seems like a misfeature. Because Gallium drivers still use

[Mesa-dev] [PATCH] radv: disable support for VEGA for now.

2017-08-17 Thread Dave Airlie
From: Dave Airlie I'm working on this, but I'm not sure I'll make 17.2 at this stage, maybe 17.2.1. Cc: "17.2" Signed-off-by: Dave Airlie --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 5 + 1 file

[Mesa-dev] [PATCH 1/3] isl: Add a null surface fill function.

2017-08-17 Thread Kenneth Graunke
ISL already offers functions to fill out most kinds of SURFACE_STATE, so why not handle null surfaces too? Null surfaces are simple, so we can just take the dimensions, rather than an entirte fill structure. --- src/intel/isl/isl.c | 7 +++ src/intel/isl/isl.h |

[Mesa-dev] [PATCH 2/3] i965: Use ISL for emitting null surface states.

2017-08-17 Thread Kenneth Graunke
We handle the Sandybridge multisampled 2D surface hack here, rather than in ISL, because it requires allocating a BO, and is kind of messy. --- src/mesa/drivers/dri/i965/Makefile.sources| 2 - src/mesa/drivers/dri/i965/brw_context.c | 4 +-

[Mesa-dev] [PATCH 3/3] anv: Use ISL for emitting null surface states.

2017-08-17 Thread Kenneth Graunke
--- src/intel/vulkan/genX_cmd_buffer.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 280efcc2245..c5735b27e02 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++

[Mesa-dev] [PATCH] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

2017-08-17 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia CC: Nicolai Hähnle CC: Matt Turner CC: Ian Romanick CC: Brian Paul --- src/mesa/main/shaderapi.c | 22 +++--- 1 file changed, 15

Re: [Mesa-dev] [PATCH 1/9] ralloc: Allow reparenting to a NULL context

2017-08-17 Thread Kenneth Graunke
On Thursday, August 17, 2017 10:22:15 AM PDT Jason Ekstrand wrote: > --- > src/util/ralloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/ralloc.c b/src/util/ralloc.c > index bf46439..4015c7e 100644 > --- a/src/util/ralloc.c > +++ b/src/util/ralloc.c > @@

Re: [Mesa-dev] [PATCH] mesa: count uniform against storage when its bindless

2017-08-17 Thread Kenneth Graunke
On Tuesday, August 15, 2017 3:42:29 AM PDT Timothy Arceri wrote: > Gallium drivers use this code path so we need to account for > bindless after all. Why do Gallium drivers use ir_to_mesa? That seems like a misfeature. i965 stopped using it years ago. --Ken signature.asc Description: This is

[Mesa-dev] [PATCH 1/2] i965: Make a BRW_NEW_FAST_CLEAR_COLOR dirty bit.

2017-08-17 Thread Kenneth Graunke
When changing fast clear colors, we need to emit new SURFACE_STATE with the updated color at the next draw call. Most things work today because the atoms that handle SURFACE_STATE for images (mutable images, textures, render targets) also listen to BRW_NEW_BLORP, causing us to re-emit these on

[Mesa-dev] [PATCH 2/2] i965: Drop BRW_NEW_BLORP from SURFACE_STATE setup code.

2017-08-17 Thread Kenneth Graunke
BLORP invalidates the binding tables, but it doesn't destroy any of the existing SURFACE_STATE entries in the statebuffer. We can reuse those. --- src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 4 src/mesa/drivers/dri/i965/brw_tcs_surface_state.c | 4

Re: [Mesa-dev] [PATCH 2/2] intel/isl: Replace switch statements of doom with a macro

2017-08-17 Thread Kenneth Graunke
On Thursday, August 17, 2017 2:57:17 PM PDT Jason Ekstrand wrote: > void > isl_buffer_fill_state_s(const struct isl_device *dev, void *state, > const struct isl_buffer_fill_state_info *restrict > info) > { > - switch (ISL_DEV_GEN(dev)) { > - case 4: > - case 5: >

[Mesa-dev] [PATCH 1/2] intel/isl: Reduce header file duplication

2017-08-17 Thread Jason Ekstrand
--- src/intel/isl/isl_emit_depth_stencil.c | 4 -- src/intel/isl/isl_genX_priv.h | 45 src/intel/isl/isl_priv.h | 126 + src/intel/isl/isl_surface_state.c | 4 -- 4 files changed, 78 insertions(+), 101 deletions(-)

[Mesa-dev] [PATCH 2/2] intel/isl: Replace switch statements of doom with a macro

2017-08-17 Thread Jason Ekstrand
--- src/intel/isl/isl.c | 135 +++- 1 file changed, 39 insertions(+), 96 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 1339867..3788f9c 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1742,6 +1742,42 @@

Re: [Mesa-dev] [Nouveau] [PATCH] nvc0: fix handling of inverted render condition

2017-08-17 Thread Ilia Mirkin
So ... how do you handle the case of a query that hasn't completed yet and one of the no-wait enums is passed in? On Thu, Aug 17, 2017 at 4:43 PM, Tobias Klausmann wrote: > Wether we wait on an inverted rendering condition or not, we should not render > on a

[Mesa-dev] [PATCH] nvc0: fix handling of inverted render condition

2017-08-17 Thread Tobias Klausmann
Wether we wait on an inverted rendering condition or not, we should not render on a passed query. This fixes the CTS test case 'KHR-GL45.conditional_render_inverted.functional'. Signed-off-by: Tobias Klausmann ---

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

2017-08-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #4 from Bruce Cherniak --- I was able to reproduce, but not through the trace. It runs fine. And, only on llvmpipe, the swr driver doesn't fail. Running VTK test "ctest -R TestGL2PSBillboardTextActor3D"

Re: [Mesa-dev] [PATCH 13/45] i965/fs: Handle 16-bit base types in helper functions

2017-08-17 Thread Jason Ekstrand
On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro wrote: > From: Eduardo Lima Mitev > > --- > src/intel/compiler/brw_fs.cpp | 3 +++ > src/intel/compiler/brw_shader.cpp | 6 ++ > 2 files changed, 9 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 11/45] i965/vec4: Handle 16-bit types at type_size_xvec4

2017-08-17 Thread Jason Ekstrand
On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro wrote: > These types have similar vec4 sizes as their 32-bit counterparts. > --- > src/intel/compiler/brw_vec4_visitor.cpp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/intel/compiler/brw_vec4_visitor.cpp

Re: [Mesa-dev] [PATCH 10/45] spirv: Enable FPRoundingMode decorator to nir operations

2017-08-17 Thread Jason Ekstrand
On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro wrote: > From: Jose Maria Casanova Crespo > > SpvOpFConvert now manages the FPRoundingMode decorator for the > returning values enabling the nir_rounding_mode in the conversion > operation to fp16

Re: [Mesa-dev] [PATCH 09/45] spirv/nir: Handle 16-bit types

2017-08-17 Thread Jason Ekstrand
On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro wrote: > From: Eduardo Lima Mitev > > Signed-off-by: Jose Maria Casanova Crespo > Signed-off-by: Eduardo Lima > --- > src/compiler/spirv/spirv_to_nir.c | 30

Re: [Mesa-dev] [PATCH v2 1/1] clover: Wait for requested operation if blocking flag is set

2017-08-17 Thread Jan Vesely
On Tue, 2017-08-15 at 12:00 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Sat, 2017-08-12 at 20:14 -0700, Francisco Jerez wrote: > > > Jan Vesely writes: > > > > > > > On Sat, 2017-08-05 at 12:34 -0700, Francisco Jerez wrote: > > >

Re: [Mesa-dev] [PATCH 08/45] spirv/nir: Add support for SPV_KHR_16bit_storage

2017-08-17 Thread Jason Ekstrand
This should come after 10 On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro wrote: > From: Eduardo Lima Mitev > > --- > src/compiler/spirv/nir_spirv.h| 1 + > src/compiler/spirv/spirv_to_nir.c | 7 +++ > 2 files changed, 8 insertions(+) > >

Re: [Mesa-dev] [PATCH 06/45] nir: Handle fp16 rounding modes at nir_type_conversion_op

2017-08-17 Thread Jason Ekstrand
On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro wrote: > From: Jose Maria Casanova Crespo > > nir_type_conversion enables new operations to handle rounding modes to > convert to fp16 values. Two new opcodes are enabled nir_op_f2f16_rtne > and

Re: [Mesa-dev] [PATCH 1/2] gallium: Add PIPE_CAP_USER_MEMORY_PAGE_SIZE for page size of user pointers

2017-08-17 Thread Alex Deucher
On Thu, Aug 17, 2017 at 2:17 PM, Jan Vesely wrote: > Hi, > > thanks a lot for these answers. > > On Thu, 2017-08-17 at 15:01 +0200, Christian König wrote: >> Am 17.08.2017 um 13:54 schrieb Jan Vesely: >> > On Thu, 2017-08-17 at 11:54 +0200, Christian König wrote: >> > >

Re: [Mesa-dev] [PATCH 07/45] nir: Populate conversion opcodes to/from 16-bit types

2017-08-17 Thread Jason Ekstrand
On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro wrote: > From: Eduardo Lima Mitev > > This will include the following NIR ALU opcodes: > * nir_op_i2i16 > * nir_op_i2f16 > * nir_op_u2u16 > * nir_op_u2f16 > * nir_op_f2i16 > * nir_op_f2u16 > *

[Mesa-dev] [Bug 102038] assertion failure in update_framebuffer_size

2017-08-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102038 --- Comment #3 from Brian Paul --- OK, with a patch from Bruce, swr is working for me, but I can't repro this assertion. Are you still seeing it, Brad? -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [PATCH 17/18] gallium/u_blitter: use UTIL_BLITTER_ATTRIB_NONE (0) instead of 0 directly

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index aef19dc..2d0d782 100644 ---

Re: [Mesa-dev] [PATCH 05/45] nir: Add rounding mode enum

2017-08-17 Thread Jason Ekstrand
On Thu, Aug 17, 2017 at 11:26 AM, Jason Ekstrand wrote: > On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro > wrote: > >> From: Jose Maria Casanova Crespo >> >> --- >> src/compiler/nir/nir.h | 8 >> 1 file changed, 8

[Mesa-dev] [PATCH 18/18] gallium/u_blitter: don't set up VBOs if there are no VS inputs

2017-08-17 Thread Marek Olšák
From: Marek Olšák let's skip these state changes --- src/gallium/auxiliary/util/u_blitter.c| 95 +++ src/gallium/drivers/radeon/r600_pipe_common.c | 79 +++--- 2 files changed, 109 insertions(+), 65 deletions(-) diff --git

[Mesa-dev] [PATCH 12/18] gallium/radeon: use the same vertices in draw_rectangle as u_blitter

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index af4b4e8..5b54906 100644 ---

[Mesa-dev] [PATCH 11/18] gallium/u_simple_shaders: do util_make_layered_clear_vertex_shader differently

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c| 2 +- src/gallium/auxiliary/util/u_simple_shaders.c | 40 --- src/gallium/auxiliary/util/u_simple_shaders.h | 2 +- 3 files changed, 19 insertions(+), 25 deletions(-) diff --git

[Mesa-dev] [PATCH 16/18] gallium/u_blitter: don't use boolean, TRUE, FALSE

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c | 102 - src/gallium/auxiliary/util/u_blitter.h | 22 +++ 2 files changed, 62 insertions(+), 62 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c

[Mesa-dev] [PATCH 15/18] gallium/u_blitter: don't pass GENERIC in VS if it's not needed

2017-08-17 Thread Marek Olšák
From: Marek Olšák Now, depth-only clears and custom passes don't read memory in VS. --- src/gallium/auxiliary/util/u_blitter.c | 64 -- 1 file changed, 46 insertions(+), 18 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c

[Mesa-dev] [PATCH 13/18] gallium/u_simple_shaders: generate POSITION from VERTEXID if not present

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c| 3 +- src/gallium/auxiliary/util/u_simple_shaders.c | 54 +-- src/gallium/auxiliary/util/u_simple_shaders.h | 3 +- src/mesa/state_tracker/st_cb_clear.c | 2 +- 4 files

[Mesa-dev] [PATCH 07/18] gallium/u_blitter: remove get_next_surface_layer callback

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c | 7 +-- src/gallium/auxiliary/util/u_blitter.h | 9 - 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c

[Mesa-dev] [PATCH 09/18] gallium/u_blitter: use draw_rectangle callback for layered clears

2017-08-17 Thread Marek Olšák
From: Marek Olšák They are done with instancing. --- src/gallium/auxiliary/util/u_blitter.c| 52 +-- src/gallium/auxiliary/util/u_blitter.h| 5 +-- src/gallium/drivers/r300/r300_context.h | 2 +-

[Mesa-dev] [PATCH 14/18] gallium/u_blitter: generate VS POSITION output from VERTEXID if possible

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c| 118 +++--- src/gallium/drivers/radeon/r600_pipe_common.c | 37 +++- 2 files changed, 96 insertions(+), 59 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c

[Mesa-dev] [PATCH 02/18] gallium/radeon: use rectangles for 1D and 2D texture blits

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index

[Mesa-dev] [PATCH 08/18] gallium/u_blitter: add new union blitter_attrib to replace pipe_color_union

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c| 93 +-- src/gallium/auxiliary/util/u_blitter.h| 12 +++- src/gallium/drivers/r300/r300_context.h | 2 +- src/gallium/drivers/r300/r300_render.c| 14 ++--

[Mesa-dev] [PATCH 05/18] gallium/u_blitter: use viewport state to set vertex positions

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 5c82677..0fea7fc

[Mesa-dev] [PATCH 10/18] gallium/u_blitter: use draw_rectangle for all blits except cubemaps

2017-08-17 Thread Marek Olšák
From: Marek Olšák Add ZW coordinates to the draw_rectangle callback and use it. --- src/gallium/auxiliary/util/u_blitter.c| 181 ++ src/gallium/auxiliary/util/u_blitter.h| 5 +- src/gallium/drivers/r300/r300_render.c| 7 +-

[Mesa-dev] [PATCH 06/18] gallium/u_blitter: cleanup

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c | 42 ++ src/gallium/auxiliary/util/u_blitter.h | 1 - src/gallium/drivers/freedreno/freedreno_draw.c | 2 +- 3 files changed, 10 insertions(+), 35 deletions(-) diff

[Mesa-dev] [PATCH 03/18] gallium/radeon: add a workaround when viewport state is used to force Z

2017-08-17 Thread Marek Olšák
From: Marek Olšák This will be needed by u_blitter. --- src/gallium/drivers/radeon/r600_viewport.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_viewport.c

[Mesa-dev] [PATCH 01/18] radeonsi: don't prefetch VBO descriptors if vertex elements == NULL

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_cp_dma.c | 3 +++ src/gallium/drivers/radeonsi/si_hw_context.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c

[Mesa-dev] [PATCH 04/18] gallium/radeon: use viewport state to set vertex positions

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 33 +++ 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index

[Mesa-dev] [PATCH 00/18] Gallium blitter optimizations

2017-08-17 Thread Marek Olšák
Hi, Major u_blitter changes: - All draw calls except cubemap blits will now use the draw_rectangle callback. (cubemap blits are not used if the driver supports texture views) - The VS POSITION output always covers the whole 2D clip space, (-1,-1) -> (1,1). The final vertex positions and Z

Re: [Mesa-dev] [PATCH 05/45] nir: Add rounding mode enum

2017-08-17 Thread Jason Ekstrand
On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro wrote: > From: Jose Maria Casanova Crespo > > --- > src/compiler/nir/nir.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index

Re: [Mesa-dev] [PATCH 04/45] nir: Add support for 16-bit types (half float, int16 and uint16)

2017-08-17 Thread Jason Ekstrand
On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro wrote: > From: Eduardo Lima Mitev > > Signed-off-by: Jose Maria Casanova Crespo > Signed-off-by: Eduardo Lima > --- > src/compiler/nir/nir.c |

Re: [Mesa-dev] [PATCH 02/45] glsl: Add 16-bit types

2017-08-17 Thread Jason Ekstrand
On Thu, Aug 17, 2017 at 7:20 AM, Jason Ekstrand wrote: > On Thu, Aug 17, 2017 at 1:35 AM, Eduardo Lima Mitev > wrote: > >> On 08/15/2017 10:56 PM, Jason Ekstrand wrote: >> > >> > On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro < >> apinhe...@igalia.com

Re: [Mesa-dev] [PATCH 1/2] gallium: Add PIPE_CAP_USER_MEMORY_PAGE_SIZE for page size of user pointers

2017-08-17 Thread Jan Vesely
Hi, thanks a lot for these answers. On Thu, 2017-08-17 at 15:01 +0200, Christian König wrote: > Am 17.08.2017 um 13:54 schrieb Jan Vesely: > > On Thu, 2017-08-17 at 11:54 +0200, Christian König wrote: > > > [SNIP] > > > In general ATS works completely different to GPUVM and is rather bound > > >

[Mesa-dev] [PATCH 1/2] radeonsi/gfx9: prevent a GPU hang after a timestamp event

2017-08-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 35 ++- src/gallium/drivers/radeon/r600_pipe_common.h | 4 ++- src/gallium/drivers/radeon/r600_query.c | 7 +++--- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +-

[Mesa-dev] [PATCH 2/2] gallium/radeon: remove old_fence parameter from r600_gfx_write_event_eop

2017-08-17 Thread Marek Olšák
From: Marek Olšák just use the new scratch buffer. --- src/gallium/drivers/radeon/r600_pipe_common.c | 15 +++ src/gallium/drivers/radeon/r600_pipe_common.h | 3 +-- src/gallium/drivers/radeon/r600_query.c | 6 +++---

Re: [Mesa-dev] [PATCH 7/9] spirv: Add vtn_fail and vtn_assert helpers

2017-08-17 Thread Jason Ekstrand
On Thu, Aug 17, 2017 at 10:29 AM, Erik Faye-Lund wrote: > On Thu, Aug 17, 2017 at 7:22 PM, Jason Ekstrand > wrote: > > These helpers are much nicer than just using assert because they don't > > kill your process. Instead, it longjmps back to

[Mesa-dev] [Bug 102274] assertion failure in ir_validate.cpp:240

2017-08-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102274 --- Comment #1 from Brian Paul --- I bisected the regression to this commit: commit e2e2c5abd279df1b3aa99c52b81c9cb48fea35fb Author: Timothy Arceri Date: Wed Aug 9 13:34:02 2017 +1000 glsl:

Re: [Mesa-dev] [PATCH 7/9] spirv: Add vtn_fail and vtn_assert helpers

2017-08-17 Thread Erik Faye-Lund
On Thu, Aug 17, 2017 at 7:22 PM, Jason Ekstrand wrote: > These helpers are much nicer than just using assert because they don't > kill your process. Instead, it longjmps back to spirv_to_nir(), cleans > up all the temporary memory, and nicely returns NULL. While crashing

Re: [Mesa-dev] [PATCH] src/intel/Makefile.vulkan.am: create target directories when required

2017-08-17 Thread Emil Velikov
Hi Ross, Apologies for missing this patch. On 12 July 2017 at 17:17, Ross Burton wrote: > In out-of-tree builds src/intel/vulkan won't exist, so always create it before > writing into it. > There's been a couple of changes on master around this change. Can you please

[Mesa-dev] [PATCH 8/9] spirv: Replace assert with vtn_assert

2017-08-17 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_to_nir.c | 200 +- src/compiler/spirv/vtn_alu.c | 26 ++--- src/compiler/spirv/vtn_cfg.c | 51 - src/compiler/spirv/vtn_glsl450.c | 4 +- src/compiler/spirv/vtn_variables.c | 212

[Mesa-dev] [PATCH 7/9] spirv: Add vtn_fail and vtn_assert helpers

2017-08-17 Thread Jason Ekstrand
These helpers are much nicer than just using assert because they don't kill your process. Instead, it longjmps back to spirv_to_nir(), cleans up all the temporary memory, and nicely returns NULL. While crashing is completely OK in the Vulkan world, it's not considered to be quite so nice in GL.

[Mesa-dev] [PATCH 9/9] spirv: Replace unreachable with vtn_fail

2017-08-17 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_to_nir.c | 136 +++-- src/compiler/spirv/vtn_alu.c | 20 +++--- src/compiler/spirv/vtn_cfg.c | 8 +-- src/compiler/spirv/vtn_glsl450.c | 14 ++-- src/compiler/spirv/vtn_private.h | 3 +-

[Mesa-dev] [PATCH 3/9] spirv: Re-arrange vtn_builder initialization

2017-08-17 Thread Jason Ekstrand
This simply moves allocating the vtn_builder and initializing it to the very beginning before we even parse the header. --- src/compiler/spirv/spirv_to_nir.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c

[Mesa-dev] [PATCH 6/9] util: Add a NORETURN macro

2017-08-17 Thread Jason Ekstrand
--- configure.ac | 1 + src/util/macros.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index e3babd3..9e152b8 100644 --- a/configure.ac +++ b/configure.ac @@ -245,6 +245,7 @@ AX_GCC_FUNC_ATTRIBUTE([visibility])

[Mesa-dev] [PATCH 4/9] spirv: Rework logging

2017-08-17 Thread Jason Ekstrand
This commit reworks the way that logging works in SPIR-V to provide richer and more detailed logging infrastructure. This commit contains several improvements over the old mechanism: 1) Log messages are now more detailed. They contain the SPIR-V byte offset as well as source language

[Mesa-dev] [PATCH 2/9] spirv: Parent the nir_shader to the builder while building

2017-08-17 Thread Jason Ekstrand
--- src/compiler/spirv/spirv_to_nir.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 7b34dad..e0d6c75a 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@

[Mesa-dev] [PATCH 0/9] spirv: Improve logging and error handling

2017-08-17 Thread Jason Ekstrand
This series has two objectives: 1) Improve logging to provide more detail and provide hooks so we can plumb errors and warnings through to debug_report extensions. 2) Improve error handling so that not all errors result in killing the process. This is done by adding new spv_fail and

[Mesa-dev] [PATCH 5/9] spirv: Do something useful with OpSource

2017-08-17 Thread Jason Ekstrand
We may as well log the source language and file name. --- src/compiler/spirv/spirv_to_nir.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 6174ec7..e59f2b2 100644 ---

[Mesa-dev] [PATCH 1/9] ralloc: Allow reparenting to a NULL context

2017-08-17 Thread Jason Ekstrand
--- src/util/ralloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/ralloc.c b/src/util/ralloc.c index bf46439..4015c7e 100644 --- a/src/util/ralloc.c +++ b/src/util/ralloc.c @@ -285,7 +285,7 @@ ralloc_steal(const void *new_ctx, void *ptr) return; info

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] swr: use the correct variable for no undefined symbols

2017-08-17 Thread Emil Velikov
On 17 August 2017 at 01:44, Andres Gomez wrote: > Emil, this patch breaks SWR build in 17.1, although it states that > fixes 9475251145174882b532. > Indeed it does. There's a missing libglapi link which got reworked/dropped with f50aa21456d82c8cb6fbaa565835f1acc1720a5d >

Re: [Mesa-dev] [PATCH 2/6] gallium: Add support for 5551 with the 1-bit field in the low bit.

2017-08-17 Thread Emil Velikov
On 17 August 2017 at 17:10, Eric Anholt wrote: > This is how VC4 stores 5551 textures, which we need to support for > GL_OES_required_internalformat. > > v2: Extend commit message, fix svga driver build, add BE ordering from > Roland. > --- >

Re: [Mesa-dev] [PATCH 0/3] mesa: Modify drirc options

2017-08-17 Thread Nicolai Hähnle
Hi Quentin, Glad you got your email configuration sorted out, and those are some nice changes! There are some changes that should be done before this can go to upstream. The Mesa policy is that your Git name has to be your real name, and AFAIU QuRyu is more of a screen name. After you

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix backward compatbility for XML parser

2017-08-17 Thread Nicolai Hähnle
On 17.08.2017 04:20, QuRyu wrote: After changing the type of drirc values, the parser will be unable to recognize xml files before the change. To achieve backward compatbility, Spelling: compatibility The commit message is good, though I would say "... will be unable to recognize xml files

[Mesa-dev] [PATCH 3/6] vc4: Add support for 5551 textures.

2017-08-17 Thread Eric Anholt
This keeps us from promoting them up to , at the cost of not being color-renderable. --- src/gallium/drivers/vc4/vc4_formats.c | 5 ++--- src/gallium/drivers/vc4/vc4_uniforms.c | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_formats.c

[Mesa-dev] [PATCH 2/6] gallium: Add support for 5551 with the 1-bit field in the low bit.

2017-08-17 Thread Eric Anholt
This is how VC4 stores 5551 textures, which we need to support for GL_OES_required_internalformat. v2: Extend commit message, fix svga driver build, add BE ordering from Roland. --- src/gallium/auxiliary/util/u_format.csv | 2 ++ src/gallium/drivers/svga/svga_format.c | 2 ++

[Mesa-dev] [PATCH 6/6] mesa: Set new renderbuffers to RGBA4 on all GLES contexts.

2017-08-17 Thread Eric Anholt
Before we were doing RGBA4 on GLES3 only, but as of GLES2 2.0.22 it should be RGBA4 as well. Fixes DEQP functional.state_query.rbo.renderbuffer_internal_format. Tested-by: Matt Turner --- src/mesa/main/renderbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 4/6] mesa: Only expose GLES's EXT_texture_type_2_10_10_10_REV if supported in HW.

2017-08-17 Thread Eric Anholt
Previously, we were downconverting to automatically if the hardware didn't suport it. However, with the advent of GL_OES_required_internalformat, we have to actually store the internalformats we advertise support for. And, it seems rather disingenuous to advertise the extension if we don't

[Mesa-dev] [PATCH 1/6] mesa: Add X1B5G5R5 along with A1B5G5R5.

2017-08-17 Thread Eric Anholt
For supporting RGB5 in hardware with A in the low bit (vc4), we need this format as well. --- src/mesa/main/formats.c | 2 ++ src/mesa/main/formats.csv| 1 + src/mesa/main/formats.h | 1 + src/mesa/main/texformat.c| 1 + src/mesa/swrast/s_texfetch.c | 1 + 5 files changed, 6

  1   2   >