[Mesa-dev] [PATCH] anv: fix build errors on android

error: incompatible pointer to integer conversion initializing 'VkFence' (aka 'unsigned long long') with an expression of type 'void *' [-Werror,-Wint-conversion] Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_queue.c | 4 ++-- 1 file changed, 2 insertions(+),

[Mesa-dev] [PATCH] vbo: fix offset in minmax cache key

Instead of saving primitive offset in the minmax cache key, save the actual buffer offset which is used in the cache lookup. Fixes rendering artifact seen with GoogleEarth when run with VMware driver. v2: Per Brian's comment, initialize offset to avoid compiler warning. Cc:

[Mesa-dev] [RFC 4/5] vulkan: Add support for out-fences in vkAcquireNextImage

Signed-off-by: Louis-Francis Ratté-Boulianne --- src/vulkan/wsi/wsi_common.h | 3 + src/vulkan/wsi/wsi_common_x11.c | 143 ++-- 2 files changed, 113 insertions(+), 33 deletions(-) diff --git a/src/vulkan/wsi/wsi_common.h

[Mesa-dev] [RFC 1/5] egl: Support EGL sync objects with OpenGL API

Xorg server uses the OpenGL API by default and we still want to support fencing in that situation. Fences seem to work properly even is not using the OpenGL ES API. Signed-off-by: Louis-Francis Ratté-Boulianne --- src/egl/main/eglapi.c | 5 ++--- 1 file changed, 2

[Mesa-dev] [RFC 3/5] vulkan: Add support for in-fences for vkQueuePresent

Allow drivers to add a list of semaphores to wait on when queuing a image to present. Signed-off-by: Louis-Francis Ratté-Boulianne --- src/amd/vulkan/radv_wsi.c | 2 +- src/intel/vulkan/anv_wsi.c | 2 ++ src/vulkan/wsi/wsi_common.h | 6 ++

[Mesa-dev] [RFC 0/5] DRI3 v1.1, ANV X11 explicit fences

Hi, This patchset makes use of Jason Ekstrand's recent work on SYNC_FD semaphores and DRI3 v1.1 support for DMA fences: https://lists.freedesktop.org/archives/mesa-dev/2017-August/168154.html It allows Vulkan WSI clients (X11 only for now) to use explicit fencing. That means vkQueuePresent can

[Mesa-dev] [RFC 5/5] anv: Implement wsi get_semaphores_fd and import_semaphore

Signed-off-by: Louis-Francis Ratté-Boulianne --- src/intel/vulkan/anv_wsi.c | 121 - 1 file changed, 119 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c index

[Mesa-dev] [RFC 2/5] vulkan: Check whether X server supports DMA fences

Signed-off-by: Louis-Francis Ratté-Boulianne --- src/vulkan/wsi/wsi_common_x11.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c index ecdaf91434..d132541156 100644 ---

Re: [Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

2017-08-31 2:20 GMT+02:00 Timothy Arceri : > > > On 31/08/17 06:19, Thomas Helland wrote: >> >> Length of the token was already calculated by flex and stored in yyleng, >> no need to implicitly call strlen() via linear_strdup(). >> >> V2: Also convert this pattern in

[Mesa-dev] [RFC v2 13/22] RFC: vulkan: Update registry for MESAX dma_buf extensions

From: Chad Versace Update vulkan.h and vk.xml from [1]: git://github.com/chadversary/vulkan-spec refs/tags/chadv/test/2017-03-06-VK_MESAX_external This pulls in the following extensions: - VK_EXT_get_image_properties - VK_MESAX_external_memory_dma_buf -

[Mesa-dev] [RFC v2 21/22] RFC: vulkan/wsi: Add modifiers to WSI image creation

From: Daniel Stone Allow the WSI to provide a set of modifiers to be used along with the format. For now, no winsys provides any modifier support. Add a fallback to the previous default (X-tiling) inside ANV. RADV remains somewhat broken in the presence of a winsys which

[Mesa-dev] [RFC v2 18/23] RFC: anv: Drop vkCreateDmaBufImageINTEL()

From: Chad Versace This "extension" function predates Vulkan 1.0 and Vulkan WSI. We created it during the early days of bringing up the Vulkan driver. We used it for testing the early driver because, in those early days, there was no other way to import/export a tiled

[Mesa-dev] [RFC v2 19/22] RFC: anv: Drop unused anv_image_create()

From: Chad Versace --- src/intel/vulkan/anv_image.c | 26 ++ src/intel/vulkan/anv_private.h | 5 - 2 files changed, 6 insertions(+), 25 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index

[Mesa-dev] [RFC v2 19/23] RFC: anv/wsi: Use VK_MESAX_external_image_dma_buf

From: Chad Versace When creating a VkSurface for X11, we created the underlying VkImage by calling anv_image_create() and passing driver-private info to it. We can now accomplish the same thing without driver-private info, using VK_MESAX_external_image_dma_buf. In

[Mesa-dev] [RFC v2 18/22] RFC: anv/wsi: Use VK_MESAX_external_image_dma_buf

From: Chad Versace When creating a VkSurface for X11, we created the underlying VkImage by calling anv_image_create() and passing driver-private info to it. We can now accomplish the same thing without driver-private info, using VK_MESAX_external_image_dma_buf. In

[Mesa-dev] [RFC v2 23/23] RFC: vulkan/wsi: Add support for DRI3 v1.1

From: Daniel Stone Adds support for multiple planes and buffer modifiers. --- src/intel/vulkan/anv_wsi.c | 7 ++- src/vulkan/wsi/wsi_common_x11.c | 118 2 files changed, 112 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [RFC v2 07/22] anv/image: Better var names in vkCreateImage

From: Chad Versace - Rename the anv_image_create_info vars from 'create_info' to 'anv_info'. - Rename the VkImageCreateInfo vars from 'pCreateInfo' and 'vk_info' to 'base_info'. This reduces the diff and eliminates ambiguity in follow-up patches for upcoming

[Mesa-dev] [RFC v2 20/23] RFC: anv: Drop unused anv_image_create()

From: Chad Versace --- src/intel/vulkan/anv_image.c | 26 ++ src/intel/vulkan/anv_private.h | 5 - 2 files changed, 6 insertions(+), 25 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index

[Mesa-dev] [RFC v2 03/22] intel/isl: Add ISL <-> GEM tiling conversion

From: Daniel Stone Add a simple conversion from ISL tiling to GEM BO tiling flags, and use that instead of hardcoding I915_TILING_X in the ANV WSI. Signed-off-by: Daniel Stone --- src/intel/isl/isl.c| 28

[Mesa-dev] [RFC v2 17/23] RFC: anv: Implement VK_MESAX_external_image_dma_buf

From: Chad Versace For now, we support dma_buf images for only a single format, VK_FORMAT_R8G8B8A8_UNORM. And the image must be a "simple" image: 2D, single-sample, non-mipmappped, non-array, non-cube. --- src/intel/vulkan/anv_extensions.py | 1 +

[Mesa-dev] [RFC v2 17/22] RFC: anv: Drop vkCreateDmaBufImageINTEL()

From: Chad Versace This "extension" function predates Vulkan 1.0 and Vulkan WSI. We created it during the early days of bringing up the Vulkan driver. We used it for testing the early driver because, in those early days, there was no other way to import/export a tiled

[Mesa-dev] [RFC v2 06/23] anv: Add func anv_get_raw_format()

From: Chad Versace Like anv_get_format(), but the returned format is not adjusted, not even for the aspect. Add anv_get_raw_isl_format() too, to match anv_get_isl_format(). --- src/intel/vulkan/anv_formats.c | 7 +++ src/intel/vulkan/anv_private.h | 8 2

[Mesa-dev] [RFC v2 22/22] RFC: vulkan/wsi: Add support for DRI3 v1.1

From: Daniel Stone Adds support for multiple planes and buffer modifiers. --- src/intel/vulkan/anv_wsi.c | 7 ++- src/vulkan/wsi/wsi_common_x11.c | 118 2 files changed, 112 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [RFC v2 21/23] RFC: anv: Drop unneeded struct anv_image_create_info

From: Chad Versace Now that anv_image_create() is gone, there is no need for struct anv_image_create_info. The struct just adds an unused layer of indirection. --- src/intel/vulkan/anv_image.c | 38 +++---

[Mesa-dev] [RFC v2 22/23] RFC: vulkan/wsi: Add modifiers to WSI image creation

From: Daniel Stone Allow the WSI to provide a set of modifiers to be used along with the format. For now, no winsys provides any modifier support. Add a fallback to the previous default (X-tiling) inside ANV. RADV remains somewhat broken in the presence of a winsys which

[Mesa-dev] [RFC v2 07/23] anv: Annotate anv_get_*format() as pure

From: Chad Versace --- src/intel/vulkan/anv_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 7b4e9dfbe0..55840d5325 100644 --- a/src/intel/vulkan/anv_private.h +++

[Mesa-dev] [RFC v2 09/22] anv/image: Fix return type of make_surface()

From: Chad Versace make_surface() always returns VK_SUCCESS, so change its return type to 'void'. This simplifies the return-code handling in anv_image_create_info() and removes a goto. --- src/intel/vulkan/anv_image.c | 15 ++- 1 file changed, 2

[Mesa-dev] [RFC v2 12/23] anv: Handle failure in make_hiz_surface_maybe()

From: Chad Versace make_ccs_surface_maybe() correctly handles failure isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still valid, just without a ccs surface. Same of make_mcs_surface_maybe() and isl_surf_get_mcs_surf(). Fix make_hiz_surface_maybe()

[Mesa-dev] [RFC v2 16/23] RFC: anv: Implement VK_MESAX_external_memory_dma_buf

From: Chad Versace For now, we support dma_bufs only for VkBuffers. The VK_MESAX_external_memory_dma_buf spec allows us to support dma_buf VkImages, but we choose to defer that support until VK_MESAX_external_image_dma_buf. --- src/intel/vulkan/anv_device.c | 25

[Mesa-dev] [RFC v2 20/22] RFC: anv: Drop unneeded struct anv_image_create_info

From: Chad Versace Now that anv_image_create() is gone, there is no need for struct anv_image_create_info. The struct just adds an unused layer of indirection. --- src/intel/vulkan/anv_image.c | 38 +++---

[Mesa-dev] [RFC v2 15/23] RFC: anv: Implement VK_EXT_get_image_properties

From: Chad Versace --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_image.c | 13 + 2 files changed, 14 insertions(+) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index

[Mesa-dev] [RFC v2 15/22] RFC: anv: Implement VK_MESAX_external_memory_dma_buf

From: Chad Versace For now, we support dma_bufs only for VkBuffers. The VK_MESAX_external_memory_dma_buf spec allows us to support dma_buf VkImages, but we choose to defer that support until VK_MESAX_external_image_dma_buf. --- src/intel/vulkan/anv_device.c | 25

[Mesa-dev] [RFC v2 11/23] anv/image: Refactor creation of aux surfaces

From: Chad Versace Creation of hiz, ccs, and mcs surfaces was encoded by a giant 'if' tree at the tail of make_surface(). This patch extracts that 'if' tree into the new functions: make_hiz_surface_maybe() make_ccs_surface_maybe() make_mcs_surface_maybe()

[Mesa-dev] [RFC v2 14/22] RFC: anv: Implement VK_EXT_get_image_properties

From: Chad Versace --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_image.c | 13 + 2 files changed, 14 insertions(+) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index

[Mesa-dev] [RFC v2 13/23] anv: Set anv_surface::offset earlier

From: Chad Versace Set anv_surface::offset *before* calling add_surface(). No intended change in behavior. This patch prepares for supporting user-provided surface offsets, a feature required for VK_MESAX_external_image_dma_buf. --- src/intel/vulkan/anv_image.c | 15

[Mesa-dev] [RFC v2 08/22] anv/image: Refactor how tiling is chosen

From: Chad Versace The code that chooses the image's tiling flags, extract it into a new function, choose_isl_tiling_flags(). This reduces the diff in future patches for the upcoming dma_buf-import extension, in which the the tiling code will become more complex. ---

[Mesa-dev] [RFC v2 11/22] anv: Handle failure in make_hiz_surface_maybe()

From: Chad Versace make_ccs_surface_maybe() correctly handles failure isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still valid, just without a ccs surface. Same of make_mcs_surface_maybe() and isl_surf_get_mcs_surf(). Fix make_hiz_surface_maybe()

[Mesa-dev] [RFC v2 05/23] isl: Add isl_surf_get_drm_format_mod()

From: Chad Versace --- src/intel/isl/isl.c | 35 +++ src/intel/isl/isl.h | 15 +++ 2 files changed, 50 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 8ebe8538fa..5e911e4f4d 100644 ---

[Mesa-dev] [RFC v2 12/22] anv: Set anv_surface::offset earlier

From: Chad Versace Set anv_surface::offset *before* calling add_surface(). No intended change in behavior. This patch prepares for supporting user-provided surface offsets, a feature required for VK_MESAX_external_image_dma_buf. --- src/intel/vulkan/anv_image.c | 15

[Mesa-dev] [RFC v2 10/23] anv/image: Fix return type of make_surface()

From: Chad Versace make_surface() always returns VK_SUCCESS, so change its return type to 'void'. This simplifies the return-code handling in anv_image_create_info() and removes a goto. --- src/intel/vulkan/anv_image.c | 15 ++- 1 file changed, 2

[Mesa-dev] [RFC v2 16/22] RFC: anv: Implement VK_MESAX_external_image_dma_buf

From: Chad Versace For now, we support dma_buf images for only a single format, VK_FORMAT_R8G8B8A8_UNORM. And the image must be a "simple" image: 2D, single-sample, non-mipmappped, non-array, non-cube. --- src/intel/vulkan/anv_extensions.py | 1 +

[Mesa-dev] [RFC v2 06/22] anv: Annotate anv_get_*format() as pure

From: Chad Versace --- src/intel/vulkan/anv_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 7b4e9dfbe0..55840d5325 100644 --- a/src/intel/vulkan/anv_private.h +++

[Mesa-dev] [RFC v2 09/23] anv/image: Refactor how tiling is chosen

From: Chad Versace The code that chooses the image's tiling flags, extract it into a new function, choose_isl_tiling_flags(). This reduces the diff in future patches for the upcoming dma_buf-import extension, in which the the tiling code will become more complex. ---

[Mesa-dev] [RFC v2 14/23] RFC: vulkan: Update registry for MESAX dma_buf extensions

From: Chad Versace Update vulkan.h and vk.xml from [1]: git://github.com/chadversary/vulkan-spec refs/tags/chadv/test/2017-03-06-VK_MESAX_external This pulls in the following extensions: - VK_EXT_get_image_properties - VK_MESAX_external_memory_dma_buf -

[Mesa-dev] [RFC v2 05/22] anv: Add func anv_get_raw_format()

From: Chad Versace Like anv_get_format(), but the returned format is not adjusted, not even for the aspect. Add anv_get_raw_isl_format() too, to match anv_get_isl_format(). --- src/intel/vulkan/anv_formats.c | 7 +++ src/intel/vulkan/anv_private.h | 8 2

[Mesa-dev] [RFC v2 10/22] anv/image: Refactor creation of aux surfaces

From: Chad Versace Creation of hiz, ccs, and mcs surfaces was encoded by a giant 'if' tree at the tail of make_surface(). This patch extracts that 'if' tree into the new functions: make_hiz_surface_maybe() make_ccs_surface_maybe() make_mcs_surface_maybe()

[Mesa-dev] [RFC v2 02/23] RFC: egl/x11: Support DRI3 v1.1

Add support for DRI3 v1.1, which allows pixmaps to be backed by multi-planar buffers, or those with format modifiers. This is both for allocating render buffers, as well as EGLImage imports from a native pixmap (EGL_NATIVE_PIXMAP_KHR). Signed-off-by: Louis-Francis Ratté-Boulianne

[Mesa-dev] [RFC v2 04/23] intel/isl: Add ISL <-> GEM tiling conversion

From: Daniel Stone Add a simple conversion from ISL tiling to GEM BO tiling flags, and use that instead of hardcoding I915_TILING_X in the ANV WSI. Signed-off-by: Daniel Stone --- src/intel/isl/isl.c| 28

[Mesa-dev] [RFC v2 03/23] intel/isl: Add ISL <-> DRM modifier conversion

From: Chad Versace It converts a DRM format modifier to and from enum isl_tiling and aux_usage. That's all. --- src/intel/Makefile.isl.am | 1 + src/intel/isl/isl.c | 59 +++ src/intel/isl/isl.h | 16

[Mesa-dev] [RFC v2 01/23] i965: Fix duplication of DRI images

Some DRI image properties weren't properly duplicated in the new image. Some properties are still missing, but I'm not certain if there was a good reason to let them out in the first place. Signed-off-by: Louis-Francis Ratté-Boulianne ---

[Mesa-dev] [RFC v2 08/23] anv/image: Better var names in vkCreateImage

From: Chad Versace - Rename the anv_image_create_info vars from 'create_info' to 'anv_info'. - Rename the VkImageCreateInfo vars from 'pCreateInfo' and 'vk_info' to 'base_info'. This reduces the diff and eliminates ambiguity in follow-up patches for upcoming

[Mesa-dev] [RFC v2 00/23] DRI3 v1.1, ANV dmabuf

Hi, With full support for modifiers in DRIimage, this patch series adds support for fully plumbing them through X11. This is the second revision, more context can be found here: https://lists.freedesktop.org/archives/mesa-dev/2017-June/158457.html Not much has changed since last time apart from

[Mesa-dev] [RFC v2 04/22] isl: Add isl_surf_get_drm_format_mod()

From: Chad Versace --- src/intel/isl/isl.c | 35 +++ src/intel/isl/isl.h | 15 +++ 2 files changed, 50 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 8ebe8538fa..5e911e4f4d 100644 ---

[Mesa-dev] [RFC v2 02/22] intel/isl: Add ISL <-> DRM modifier conversion

From: Chad Versace It converts a DRM format modifier to and from enum isl_tiling and aux_usage. That's all. --- src/intel/Makefile.isl.am | 1 + src/intel/isl/isl.c | 59 +++ src/intel/isl/isl.h | 16

[Mesa-dev] [RFC v2 01/22] RFC: egl/x11: Support DRI3 v1.1

Add support for DRI3 v1.1, which allows pixmaps to be backed by multi-planar buffers, or those with format modifiers. This is both for allocating render buffers, as well as EGLImage imports from a native pixmap (EGL_NATIVE_PIXMAP_KHR). Signed-off-by: Louis-Francis Ratté-Boulianne

Re: [Mesa-dev] [PATCH 2/2] i965: Fix state flagging of Gen6 SOL programs.

On 2017-08-22 19:09:23, Kenneth Graunke wrote: > It doesn't seem like the old code could possibly work. > > 1. brw_gs_state_dirty made us bail unless one of these flags were set: >_NEW_TEXTURE, BRW_NEW_GEOMETRY_PROGRAM, BRW_NEW_TRANSFORM_FEEDBACK > 2. If there was no geometry program, we

Re: [Mesa-dev] [PATCH] vbo: fix offset in minmax cache key

On 08/30/2017 03:49 PM, Charmaine Lee wrote: Instead of saving primitive offset in the minmax cache key, save the actual buffer offset which is used in the cache lookup. Fixes rendering artifact seen with GoogleEarth when run with VMware driver. Wow, nice working finding that! Looks good to

Re: [Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

On 31/08/17 06:19, Thomas Helland wrote: Length of the token was already calculated by flex and stored in yyleng, no need to implicitly call strlen() via linear_strdup(). V2: Also convert this pattern in glsl_lexer.ll This has a surprising result of reducing executed cyles from 1.06

[Mesa-dev] [Bug 101832] [regression][bisect] Xorg fails to start after f50aa21456d82c8cb6fbaa565835f1acc1720a5d

https://bugs.freedesktop.org/show_bug.cgi?id=101832 Bernhard Rosenkraenzer changed: What|Removed |Added Hardware|x86-64 (AMD64) |All

[Mesa-dev] [Bug 101832] [regression][bisect] Xorg fails to start after f50aa21456d82c8cb6fbaa565835f1acc1720a5d

https://bugs.freedesktop.org/show_bug.cgi?id=101832 --- Comment #13 from Bernhard Rosenkraenzer --- Created attachment 133894 --> https://bugs.freedesktop.org/attachment.cgi?id=133894=edit Fix Here's a fix... Probably should (in addition to this) catch the cache directory

[Mesa-dev] [Bug 101832] [regression][bisect] Xorg fails to start after f50aa21456d82c8cb6fbaa565835f1acc1720a5d

https://bugs.freedesktop.org/show_bug.cgi?id=101832 --- Comment #12 from Bernhard Rosenkraenzer --- The debug output was more useful than I initially thought ;) The crash happens when getenv() in GetEnv() returns NULL, leading to the std::string constructor getting a NULL

[Mesa-dev] [PATCH] vbo: fix offset in minmax cache key

Instead of saving primitive offset in the minmax cache key, save the actual buffer offset which is used in the cache lookup. Fixes rendering artifact seen with GoogleEarth when run with VMware driver. --- src/mesa/vbo/vbo_minmax_index.c | 8 +--- 1 file changed, 5 insertions(+), 3

[Mesa-dev] [Bug 101832] [regression][bisect] Xorg fails to start after f50aa21456d82c8cb6fbaa565835f1acc1720a5d

https://bugs.freedesktop.org/show_bug.cgi?id=101832 --- Comment #11 from Bernhard Rosenkraenzer --- The output of the patch doesn't look too helpful to me: (II) glamor: OpenGL accelerated X.org driver based. SWR_DEBUG env /tmp/Rast/DebugOutput SWR_DEBUG env ${HOME}/.swr/jitcache

Re: [Mesa-dev] [PATCH 1/2] util: add stringbuf library

2017-08-29 7:25 GMT+02:00 Thomas Helland : > 2017-08-28 11:47 GMT+02:00 Nicolai Hähnle : >> On 28.08.2017 11:13, Nicolai Hähnle wrote: >>> >>> On 28.08.2017 03:51, Timothy Arceri wrote: On 27/08/17 05:18, Thomas Helland wrote: > >

[Mesa-dev] [PATCH] glcpp: Avoid unnecessary call to strlen

Length of the token was already calculated by flex and stored in yyleng, no need to implicitly call strlen() via linear_strdup(). V2: Also convert this pattern in glsl_lexer.ll This has a surprising result of reducing executed cyles from 1.06 trillion to 1.03 trillion, a significant

Re: [Mesa-dev] [PATCH] llvmpipe: initialize llvmpipe->dirty with LP_NEW_SCISSOR

Am 30.08.2017 um 16:46 schrieb Brian Paul: > On 08/30/2017 02:43 AM, Roland Scheidegger wrote: >> Am 30.08.2017 um 04:49 schrieb Brian Paul: >>> On 08/29/2017 06:17 PM, Roland Scheidegger wrote: Looks good to me, thanks. Reviewed-by: Roland Scheidegger

Re: [Mesa-dev] [PATCH] svga: include sample count in surface_size() computation

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, August 30, 2017 10:16:05 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: include sample count in

Re: [Mesa-dev] [PATCH] radv/ac: workaround regression in llvm 4.0 release

On 30 August 2017 at 17:59, Marek Olšák wrote: > On Wed, Aug 30, 2017 at 6:36 PM, Emil Velikov > wrote: >> Hi all, >> >> On 14 March 2017 at 23:51, Samuel Pitoiset wrote: >>> On 03/14/2017 10:21 PM, Dave Airlie wrote:

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Emil Velikov > Sent: Wednesday, August 30, 2017 9:44 PM > To: Marathe, Yogesh > Cc: Gao, Shuo ; Liu, Zhiquan ; >

[Mesa-dev] [PATCH] svga: include sample count in surface_size() computation

Use MAX2() because sampleCount will be zero for non-MSAA surfaces. No Piglit regressions. --- src/gallium/drivers/svga/svga_screen_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_screen_cache.c

Re: [Mesa-dev] [PATCH] radv/ac: workaround regression in llvm 4.0 release

On Wed, Aug 30, 2017 at 6:36 PM, Emil Velikov wrote: > Hi all, > > On 14 March 2017 at 23:51, Samuel Pitoiset wrote: >> On 03/14/2017 10:21 PM, Dave Airlie wrote: >>> >>> On 15 March 2017 at 07:17, Dave Airlie wrote:

Re: [Mesa-dev] [PATCH] .gitignore: list *.orig and *.rej

On Wednesday, 2017-08-30 15:37:31 +, Emil Velikov wrote: > From: Emil Velikov > > Should prevent accidental check-in of patch artefacts. > > Cc: Mike Lothian > Suggested-by: Mike Lothian > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH] radv/ac: workaround regression in llvm 4.0 release

Hi all, On 14 March 2017 at 23:51, Samuel Pitoiset wrote: > On 03/14/2017 10:21 PM, Dave Airlie wrote: >> >> On 15 March 2017 at 07:17, Dave Airlie wrote: >>> >>> From: Dave Airlie >>> >>> LLVM 4.0 released with a pretty messy

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

On 30 August 2017 at 15:39, Marathe, Yogesh wrote: > > Thank you, Tomasz and all involved for the help and guidance. > Our excitement was short lived - see commit 8c9df0daf20206fafb7df77b1edcbc41b8e91372. Seems the patch was not run through the Intel CI, though I'm

Re: [Mesa-dev] [PATCH 01/12] egl/x11/dri3: adding missing __DRI_BACKGROUND_CALLABLE extension

Reviewed-by: Marek Olšák Marek On Wed, Aug 30, 2017 at 1:05 PM, Emil Velikov wrote: > On 18 August 2017 at 17:37, Emil Velikov wrote: >> On 3 August 2017 at 19:29, Emil Velikov wrote: >>> From:

Re: [Mesa-dev] V2 radeonsi use STD430 packing of UBOs by default

On Wed, Aug 30, 2017 at 2:22 PM, Timothy Arceri wrote: > On 30/08/17 20:07, Marek Olšák wrote: >> >> If LLVM was fixed to do the correct thing, we could enable CONSTBUF >> LOAD for LLVM 6.0 and later. > > > You seem to think that the compiler *should* be placing them near

[Mesa-dev] [PATCH] .gitignore: list *.orig and *.rej

From: Emil Velikov Should prevent accidental check-in of patch artefacts. Cc: Mike Lothian Suggested-by: Mike Lothian Signed-off-by: Emil Velikov --- Thanks for the idea Mike! --- .gitignore |

Re: [Mesa-dev] [PATCH mesa] mesa/st: remove unwanted backup file

LOL didn't even spot this sorry It might be a good idea to pop *.orig and *.rej into the gitignore file On Wed, 30 Aug 2017 at 14:17 Emil Velikov wrote: > On 30 August 2017 at 14:11, Eric Engestrom wrote: > > Fixes: 0ac78dc92582a59d4319 "util: move

Re: [Mesa-dev] [PATCH] i965: add 2xMSAA 16xMSAA modes to DRI configs.

On Wednesday, August 30, 2017 3:57:48 AM PDT kevin.rogo...@intel.com wrote: > From: Kevin Rogovin > > For Gen8, add 2xMSAA. For Gen9, add 2xMSAA and 16xMSAA. > Special thanks to Eero Tamminen for reporting rasterizer > numbers being twice what it should be for 2xMSAA

Re: [Mesa-dev] [PATCH] llvmpipe: initialize llvmpipe->dirty with LP_NEW_SCISSOR

On 08/30/2017 02:43 AM, Roland Scheidegger wrote: Am 30.08.2017 um 04:49 schrieb Brian Paul: On 08/29/2017 06:17 PM, Roland Scheidegger wrote: Looks good to me, thanks. Reviewed-by: Roland Scheidegger Albeit I'm not quite sure why it is never set here? This particular

Re: [Mesa-dev] Question about implementing viewport transfer and const load in nir

On Wed, Aug 30, 2017 at 10:18 AM, Qiang Yu wrote: > On Wed, Aug 30, 2017 at 9:03 PM, Rob Clark wrote: >> On Wed, Aug 30, 2017 at 3:26 AM, Qiang Yu wrote: btw, does lima have some way to write to memory from cmdstream (ie.

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Wednesday, August 30, 2017 4:39 PM > To: Marathe, Yogesh > Cc: mesa-dev@lists.freedesktop.org; tf...@chromium.org; Gao, Shuo > ; Liu, Zhiquan

Re: [Mesa-dev] Question about implementing viewport transfer and const load in nir

On Wed, Aug 30, 2017 at 9:03 PM, Rob Clark wrote: > On Wed, Aug 30, 2017 at 3:26 AM, Qiang Yu wrote: >>> btw, does lima have some way to write to memory from cmdstream (ie. >>> without setting up a full blown draw)? If so perhaps you could get >>> away

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: sort DBG shader flags according to pipe_shader_type

On Wed, Aug 30, 2017 at 12:50 PM, Emil Velikov wrote: > On 30 August 2017 at 10:38, Marek Olšák wrote: >> On Wed, Aug 30, 2017 at 11:19 AM, Emil Velikov >> wrote: >>> Hi Marek, >>> >>> There's a couple of subtle changes in

Re: [Mesa-dev] [PATCH mesa] mesa/st: remove unwanted backup file

On 30 August 2017 at 14:11, Eric Engestrom wrote: > Fixes: 0ac78dc92582a59d4319 "util: move string_to_uint_map to glsl" > Cc: Emil Velikov > Signed-off-by: Eric Engestrom Reviewed-by: Emil Velikov

[Mesa-dev] [PATCH mesa] mesa/st: remove unwanted backup file

Fixes: 0ac78dc92582a59d4319 "util: move string_to_uint_map to glsl" Cc: Emil Velikov Signed-off-by: Eric Engestrom --- src/mesa/state_tracker/st_glsl_to_nir.cpp.orig | 479 - 1 file changed, 479 deletions(-) delete mode

[Mesa-dev] [PATCH 2/2] radv: disassemble SPIR-V binaries with RADV_DEBUG=spirv

This introduces a new separate option because the output can be quite verbose. If spirv-dis is not found in the path, this debug option is useless. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c| 30 ++

[Mesa-dev] [PATCH] radv: compute correct maximum wave count per SIMD

Ported from RadeonSI (original patch by Marek). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index

[Mesa-dev] [PATCH 1/2] radv: move RADV_TRACE_FILE functions to radv_debug.c

At the moment, debugging radv is not really easy because the driver doesn't report enough information when it hangs. This new file will be the main location for all debug tools. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/Makefile.sources | 1 +

Re: [Mesa-dev] [PATCH] egl/dri2: only destroy created objects

On 29 August 2017 at 10:51, Michael Olbrich wrote: > dri2_display_destroy may be called by dri2_initialize_wayland_drm() if > initialization fails. In this case, these objects may not be initialized. > Only if the wayland API had some basic NULL checks ... ;-) Thanks

Re: [Mesa-dev] Question about implementing viewport transfer and const load in nir

On Wed, Aug 30, 2017 at 3:26 AM, Qiang Yu wrote: >> btw, does lima have some way to write to memory from cmdstream (ie. >> without setting up a full blown draw)? If so perhaps you could get >> away with leaving some extra space at the end of your uniform buffer >> that you copy

Re: [Mesa-dev] [PATCH 2/2] i965: Implement ARB_indirect_parameters

On Wed, Aug 30, 2017 at 3:17 AM, Bas Nieuwenhuizen wrote: > So as a random drive-by review, I think the risk in this implementation > is that apps just set maxdrawcount to some high value . If I'm reading > the spec correctly there is no real bound on the value except

Re: [Mesa-dev] V2 radeonsi use STD430 packing of UBOs by default

On 30/08/17 20:07, Marek Olšák wrote: If LLVM was fixed to do the correct thing, we could enable CONSTBUF LOAD for LLVM 6.0 and later. You seem to think that the compiler *should* be placing them near where they are used? What part of LLVM were you expecting to do this? I'm happy to do some

Re: [Mesa-dev] [PATCH 3/6] vl/compositor: make vl_compositor_set_yuv_layer() static

Hi Emil, Thanks Leo, for the split. There's a vl_compositor_set_yuv_layer reference loose in the header. Yeah, thanks for catching that. It's very appreciated. Leo Please remove that one with the patch, but don't bother resending. -Emil ___

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

On 28 August 2017 at 11:27, Marathe, Yogesh wrote: > This still doesn't seem to be merged. Can someone please look at it? It does > have Rbs. > Done. Thanks for the work and patience on getting this sorted. -Emil ___ mesa-dev

Re: [Mesa-dev] [PATCH 01/12] egl/x11/dri3: adding missing __DRI_BACKGROUND_CALLABLE extension

On 18 August 2017 at 17:37, Emil Velikov wrote: > On 3 August 2017 at 19:29, Emil Velikov wrote: >> From: Emil Velikov >> >> Fixes: 3b7b6adf3ac ("egl: Implement __DRI_BACKGROUND_CALLABLE") >> Cc: Timothy Arceri

[Mesa-dev] [PATCH] i965: add 2xMSAA 16xMSAA modes to DRI configs.

From: Kevin Rogovin For Gen8, add 2xMSAA. For Gen9, add 2xMSAA and 16xMSAA. Special thanks to Eero Tamminen for reporting rasterizer numbers being twice what it should be for 2xMSAA under a benchmark. V2: Make pointer name less ugly + add 2xMSAA for Gen8 ---

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: sort DBG shader flags according to pipe_shader_type

On 30 August 2017 at 10:38, Marek Olšák wrote: > On Wed, Aug 30, 2017 at 11:19 AM, Emil Velikov > wrote: >> Hi Marek, >> >> There's a couple of subtle changes in the patch. If intentional, could >> you mention that in the commit message? >> >> On 29

Re: [Mesa-dev] [PATCH] i965: add 2xMSAA and 16xMSAA to DRI configs for Gen9.

Hi, Please do not push yet. I will post a V2 that makes the pointer thing not so offensively ugly. Also, I missed the opportunity to also fix the DRI conf for Gen8, as it does have 2xMSAA. -Kevin -Original Message- From: Ben Widawsky [mailto:b...@bwidawsk.net] Sent: Thursday,

Re: [Mesa-dev] [PATCH 00/16] anv/i965: Cleanup copies of devinfo fields in brw_context

On 30/08/17 11:30, Samuel Iglesias Gonsálvez wrote: On Wed, 2017-08-30 at 11:10 +0100, Lionel Landwerlin wrote: You can find this series on github : https://github.com/djdeath/mesa/tree/wip/djdeath/drop-is-has-brw (One paches got caught by the mailing list's size limit) Assuming there is no

  1   2   >