Re: [Mesa-dev] [PATCH mesa 5/6] egl: move alloc & init out of _eglBuiltInDriver{DRI2, Haiku}

On 26 September 2017 at 23:47, Eric Engestrom wrote: > + drv = calloc(1, sizeof(*drv)); > + if (!drv) { >return EGL_FALSE; > + } > + Nit: please drop the unneeded parentheses. Thanks Emil ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] gallium: build ddebug, noop, rbug, trace as part of auxiliary

On 27 September 2017 at 09:43, Marek Olšák wrote: > On Wed, Sep 6, 2017 at 12:38 PM, Emil Velikov > wrote: >> On 4 September 2017 at 21:36, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> Building gallium is

Re: [Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

Am 27.09.2017 um 09:13 schrieb Olivier Lauffenburger: > Software rasterizer and LLVM contain code to enable clipping as soon as > a vertex shader writes to gl_ClipDistance, even if the corresponding > clip planes are disabled. > GLSL specification states that "Values written into gl_ClipDistance

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

On Wed, 27 Sep 2017 14:50:10 +0100 Chris Wilson wrote: > Quoting Boris Brezillon (2017-09-27 14:45:17) > > static struct vc4_bo * > > vc4_bo_from_cache(struct vc4_screen *screen, uint32_t size, const char > > *name) > > { > > @@ -111,6 +121,11 @@

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

On 25 September 2017 at 08:25, Tomasz Figa wrote: > Gentle ping. :) > I forgot that you don't have commit access. Can you please apply for one? Thanks Emil [1] https://www.freedesktop.org/wiki/AccountRequests/ [2] https://bugs.freedesktop.org/show_bug.cgi?id=99601

Re: [Mesa-dev] [PATCH 4/3] glsl: tidy up IR after loop unrolling

For the series: Tested-by: Dieter Nützel Dieter Am 22.09.2017 01:49, schrieb Timothy Arceri: c7affbf6875622a enabled GLSLOptimizeConservatively on some drivers. The idea was to speed up compile times by running the GLSL IR passes only once each time

Re: [Mesa-dev] [PATCH] egl/wayland: Make wayland_drm_init declaration match the implementation

On 26 September 2017 at 21:51, Daniel Stone wrote: > Hi, > > On 20 September 2017 at 19:02, Emil Velikov wrote: >> Krzysztof Sobiecki (sobkas) provided a more elaborate fix on IRC, >> which I've applied ~15 minutes before this patch went out. >> >>

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

Quoting Boris Brezillon (2017-09-27 14:45:17) > static struct vc4_bo * > vc4_bo_from_cache(struct vc4_screen *screen, uint32_t size, const char *name) > { > @@ -111,6 +121,11 @@ vc4_bo_from_cache(struct vc4_screen *screen, uint32_t > size, const char *name) > return

Re: [Mesa-dev] [Mesa-announce] Mesa 17.1.10 release candidate

On 27.09.2017 15:44, Emil Velikov wrote: On 26 September 2017 at 05:25, Timothy Arceri wrote: On 22/09/17 19:41, Juan A. Suarez Romero wrote: On Fri, 2017-09-22 at 16:38 +1000, Timothy Arceri wrote: On 22/09/17 05:10, Juan A. Suarez Romero wrote: Hello list, The

Re: [Mesa-dev] [PATCH 2/5] util: Add tests for the string buffer

On 11 September 2017 at 21:21, Thomas Helland wrote: > More tests could probably be added, but this should cover > concatenation, resizing, clearing, formatted printing, > and checking the length, so it should be quite complete. > > V2: Address review feedback from

[Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

This patch makes use of the DRM_IOCTL_VC4_GEM_MADVISE ioctl to mark all BOs placed in the mesa BO cache as purgeable so that the system can reclaim this memory under memory pressure. Signed-off-by: Boris Brezillon --- Hello, Note that this series depends on

Re: [Mesa-dev] [Mesa-announce] Mesa 17.1.10 release candidate

On 26 September 2017 at 05:25, Timothy Arceri wrote: > On 22/09/17 19:41, Juan A. Suarez Romero wrote: >> >> On Fri, 2017-09-22 at 16:38 +1000, Timothy Arceri wrote: >>> >>> On 22/09/17 05:10, Juan A. Suarez Romero wrote: Hello list, The candidate for

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/va: use pipe transfer_map to upload mapped buffer

On 2017-09-27 04:30 AM, Marek Olšák wrote: Reviewed-by: Marek Olšák Thanks for the review. If a 3D or array texture can't occur here, it would be better to set box.depth = 1. The case here is to map a derived image, which is a RGB surface with format

Re: [Mesa-dev] [PATCH] gallium: build ddebug, noop, rbug, trace as part of auxiliary

On 27.09.2017 10:45, Marek Olšák wrote: On Wed, Sep 6, 2017 at 12:35 PM, Nicolai Hähnle wrote: https://travis-ci.org/nhaehnle/mesa-1/jobs/272422053 I suspect the se of $(top_srcdir) is the problem. Are you testing out-of-tree builds? No, I'm not testing out-of-tree

[Mesa-dev] [PATCH] i965/fs: force pull model for 64-bit GS inputs

Triggering the push model when 64-bit inputs are involved is not easy due to the constrains on the maximum number of registers that we allow for this mode, however, for GS with 'points' primitive type and just a couple of double varyings we can trigger this and it just doesn't work because the

Re: [Mesa-dev] [PATCH 06/22] i965: Enable BatchbufferLogger in i965 driver

Quoting kevin.rogo...@intel.com (2017-09-25 11:34:06) > +static > +uint32_t > +intel_batchbuffer_state(const struct i965_logged_batchbuffer *st) > +{ > + struct intel_batchbuffer *batch > + = (struct intel_batchbuffer*) st->driver_data; > + > + assert(batch->bo->gem_handle == st->gem_bo);

Re: [Mesa-dev] [PATCH 00/22] RFC: Batchbuffer Logger for Intel GPU

Hi, If we just want to send to the kernel the data from the trace, I can do that very easily; just make such a GEM BO, comprising of dword-pairs of (TraceCallID, BatchbufferOffset). That will be a small buffer and together with the apitrace file, will give complete data. I could probably

Re: [Mesa-dev] [PATCH v4 2/4] util/ralloc: Don't define assert with magic member without DEBUG

On Tuesday, 2017-09-26 23:38:11 +, Dylan Baker wrote: > It is possible to have DEBUG disabled but asserts on (NDEBUG(, which parentheses typo other than that: Reviewed-by: Eric Engestrom and I think you should've pushed these first two patches instead of carrying

Re: [Mesa-dev] [PATCH 00/22] RFC: Batchbuffer Logger for Intel GPU

Quoting Rogovin, Kevin (2017-09-27 07:53:29) > Hi, > > Right now the way the thing works is that it walks the batchbuffer just > after the kernel returns from the ioctl and updates its internal view of the > GPU state as it walks and emits to the log file the data. The log on a single >

Re: [Mesa-dev] [PATCH 00/22] RFC: Batchbuffer Logger for Intel GPU

HI, In spirit, stuffing data into MI_NOOP is nicer since then one can just rely on aubinator to read that data and go to town. The main issues I see are the following. 1. One needs to now insert MI_NOOP's into the command buffer in order to insert strings. This changes what is sent to the

Re: [Mesa-dev] [PATCH 3/3] radeonsi: move descriptor logs to after corresponding draw/compute packet

For the series: Reviewed-by: Marek Olšák Marek On Tue, Sep 26, 2017 at 4:39 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > It has to happen after descriptor uploads since otherwise we'll print out > the wrong GPU list /

Re: [Mesa-dev] [PATCH 3/3] radeonsi: fix border color translation for integer textures

For the series: Reviewed-by: Marek Olšák Marek On Tue, Sep 26, 2017 at 4:46 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This fixes the extremely unlikely case that an application uses > 0x8000 or 0x3f80 as

Re: [Mesa-dev] [PATCH 00/22] RFC: Batchbuffer Logger for Intel GPU

Hi, Sighs, I forget one -critical- issue on decoding the batchbuffer: it needs to reloc data from the kernel to have any chance of correctly decoding things referred to by the batch buffer (which is oodles of stuff), thus decode can only happen after kernel succeeds. However, I can make it

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

On Wed, 2017-09-27 at 09:09 +0900, Tomasz Figa wrote: > On Wed, Sep 27, 2017 at 2:32 AM, Juan A. Suarez Romero > wrote: > > On Mon, 2017-09-25 at 16:25 +0900, Tomasz Figa wrote: > > > On Fri, Aug 11, 2017 at 1:31 PM, Tomasz Figa wrote: > > > > On Fri, Aug

Re: [Mesa-dev] [PATCH 00/22] RFC: Batchbuffer Logger for Intel GPU

A few months ago I implemented debug messages in the command stream by stuffing the unused bits of MI_NOOP : https://patchwork.freedesktop.org/series/26079/ Aubinator would then read the bits and print the messages. We might be able to reuse similar idea to get away with any external

Re: [Mesa-dev] [Mesa-stable] [PATCH 5/5] radeonsi/gfx9: fix geometry shaders without output vertices

For the series: Reviewed-by: Marek Olšák Marek On Tue, Sep 26, 2017 at 4:43 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Not that those are super common or useful, but hey! Fun corner cases > of the API... > > Fixes

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

On Wed, 2017-09-27 at 09:09 +0900, Tomasz Figa wrote: > On Wed, Sep 27, 2017 at 2:32 AM, Juan A. Suarez Romero > wrote: > > On Mon, 2017-09-25 at 16:25 +0900, Tomasz Figa wrote: > > > On Fri, Aug 11, 2017 at 1:31 PM, Tomasz Figa wrote: > > > > On Fri, Aug

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

On Tue, 2017-09-26 at 11:39 -0700, Ian Romanick wrote: > On 09/26/2017 10:27 AM, Juan A. Suarez Romero wrote: > > On Thu, 2017-09-21 at 10:39 -0500, Ian Romanick wrote: > > > On 09/20/2017 03:12 AM, Juan A. Suarez Romero wrote: > > > > On Sat, 2017-07-08 at 02:03 +0300, Andres Gomez wrote: > > > >

Re: [Mesa-dev] [PATCH 4/4] vulkan/wsi/wayland: Return better error messages

Good stuff; thanks for cleaning that up. Modulo my comments on 2 and 3, the series is: Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/4] vulkan/wsi/wayland: Copy wl_proxy objects from oldSwapchain if available

Hi, On 26 September 2017 at 23:55, Jason Ekstrand wrote: > static void > -wsi_wl_display_destroy(struct wsi_wl_display *display) > +wsi_wl_display_ref(struct wsi_wl_display *display) > +{ > + display->refcount++; > +} Better: static struct wsi_wl_display *

Re: [Mesa-dev] [PATCH 2/4] vulkan/wsi/wayland: Stop caching Wayland displays

Hi, On 26 September 2017 at 23:55, Jason Ekstrand wrote: > @@ -833,24 +816,19 @@ wsi_wl_surface_create_swapchain(VkIcdSurfaceBase > *icd_surface, > chain->vk_format = pCreateInfo->imageFormat; > chain->drm_format = wl_drm_format_for_vk_format(chain->vk_format,

Re: [Mesa-dev] [PATCH] gallium: build ddebug, noop, rbug, trace as part of auxiliary

On Wed, Sep 6, 2017 at 12:35 PM, Nicolai Hähnle wrote: > https://travis-ci.org/nhaehnle/mesa-1/jobs/272422053 > > I suspect the se of $(top_srcdir) is the problem. Are you testing > out-of-tree builds? No, I'm not testing out-of-tree builds. I don't know how to test them.

Re: [Mesa-dev] [PATCH] gallium: build ddebug, noop, rbug, trace as part of auxiliary

On Wed, Sep 6, 2017 at 12:38 PM, Emil Velikov wrote: > On 4 September 2017 at 21:36, Marek Olšák wrote: >> From: Marek Olšák >> >> Building gallium is faster by 7.5 seconds on a 4core/8thread 3GHz CPU. >> (gallium build time is

Re: [Mesa-dev] MESA and KOTOR

On Wed, Sep 27, 2017 at 10:31 AM, Federico Dossena wrote: > Yes his work was on radeonsi, but the patch that he says fixes the crash > with framebuffer effects and soft shadows was in the state tracker. Link: > https://patchwork.freedesktop.org/patch/68298/ > > The patch

Re: [Mesa-dev] [PATCH] glsl: do not set the 'smooth' qualifier by default on ES shaders

Reviewed-by: Marek Olšák Marek On Tue, Sep 26, 2017 at 5:11 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > It leads to surprising states with integer inputs and outputs on > vertex processing stages (e.g. geometry

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/va: use pipe transfer_map to upload mapped buffer

Reviewed-by: Marek Olšák If a 3D or array texture can't occur here, it would be better to set box.depth = 1. If a 3D texture can't occur here but an array texture can, it needs to be box.depth = resource->array_size. Marek On Tue, Sep 26, 2017 at 5:04 PM, Leo Liu

Re: [Mesa-dev] MESA and KOTOR

Pbuffers are problematic because it's an ancient feature that nobody cares about anymore. I think Miklos made KOTOR work on radeonsi or r600. Marek On Mon, Sep 25, 2017 at 6:50 PM, Federico Dossena wrote: > Hello everyone, > you may remember that a few months ago I was

Re: [Mesa-dev] [PATCH 11/11] radeonsi: emit DLDEXP and DFRACEXP TGSI opcodes

For patches 2-11: Reviewed-by: Marek Olšák Patch 1: Acked-by: Marek Olšák Marek On Sat, Sep 16, 2017 at 1:23 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Note: this causes spurious regressions

Re: [Mesa-dev] [PATCH 3/3] radeonsi: move descriptor logs to after corresponding draw/compute packet

For the series: Reviewed-by: Samuel Pitoiset On 09/26/2017 04:39 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle It has to happen after descriptor uploads since otherwise we'll print out the wrong GPU list / incorrectly claim descriptor

[Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

Software rasterizer and LLVM contain code to enable clipping as soon as a vertex shader writes to gl_ClipDistance, even if the corresponding clip planes are disabled. GLSL specification states that "Values written into gl_ClipDistance for planes that are not enabled have no effect." The actual

Re: [Mesa-dev] [PATCH 00/22] RFC: Batchbuffer Logger for Intel GPU

Hi, Right now the way the thing works is that it walks the batchbuffer just after the kernel returns from the ioctl and updates its internal view of the GPU state as it walks and emits to the log file the data. The log on a single batchbuffer is (essentially) just a list of call ID's from the

Re: [Mesa-dev] [PATCH] i965: skip reading clip distances from the URB for the FS if possible

Sure, I can do that. Iago On Tue, 2017-09-26 at 06:32 -0400, Ilia Mirkin wrote: > Perhaps a debug message would be warranted in such a situation? I > suspect it would be difficult to debug, esp if it came up in a > regular application. > On Sep 26, 2017 3:50 AM, "Iago Toral Quiroga"

<    1   2