Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Fri, 2017-10-20 at 13:18 +1100, Timothy Arceri wrote: > > On 20/10/17 03:31, Iago Toral Quiroga wrote: > > The existing code was checking the whole interface variable rather > > than its members, which is not what we want: we want to check > > aliasing for each member in the interface

Re: [Mesa-dev] [PATCH] radv: ensure correct outinfo is picked.

On 20/10/17 15:12, Dave Airlie wrote: From: Dave Airlie This struct used to rely on being in a union, it isn't anymore, so we have to pick the correct outinfo struct now. This should fix a regression since the union became a struct.

Re: [Mesa-dev] [PATCH v2] i965 : optimized bucket index calculation

On 09/13/2017 11:43 PM, aravindan.muthuku...@intel.com wrote: > From: Aravindan Muthukumar > > Avoiding the loop which was running with O(n) complexity. > Now the complexity has been reduced to O(1) > > Algorithm calculates the index using matrix method. > Matrix

[Mesa-dev] [PATCH] radv: ensure correct outinfo is picked.

From: Dave Airlie This struct used to rely on being in a union, it isn't anymore, so we have to pick the correct outinfo struct now. This should fix a regression since the union became a struct. dEQP-VK.tessellation.geometry_interaction.point_size.vertex_set_geometry_set

Re: [Mesa-dev] [PATCH 4/4] glsl/linker: outputs in the same location must share auxiliary storage

I only really skimmed over them but these look fine to me 3-4: Reviewed-by: Timothy Arceri Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 13:36, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 10:18 PM, Timothy Arceri wrote: On 20/10/17 03:31, Iago Toral Quiroga wrote: The existing code was checking the whole interface variable rather than its members, which is not what we want: we want to

Re: [Mesa-dev] [PATCH] glsl: Allow precision mismatch on dead uniform with GLSL ES 1.00 (v3)

Hi Ian, Kenneth, On Wed, Sep 27, 2017 at 2:57 AM, Tomasz Figa wrote: > Commit 259fc505454ea6a67aeacf6cdebf1398d9947759 added linker error for > mismatching uniform precision, as required by GLES 3.0 specification and > conformance test-suite. > > Several Android applications,

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Thu, Oct 19, 2017 at 10:18 PM, Timothy Arceri wrote: > > > On 20/10/17 03:31, Iago Toral Quiroga wrote: >> >> The existing code was checking the whole interface variable rather >> than its members, which is not what we want: we want to check >> aliasing for each member

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 03:31, Iago Toral Quiroga wrote: The existing code was checking the whole interface variable rather than its members, which is not what we want: we want to check aliasing for each member in the interface variable. Surprisingly, there are piglit tests that verify this and were

Re: [Mesa-dev] [PATCH v2 25/32] i965: add cache fallback support using serialized nir

On 20/10/17 09:13, Timothy Arceri wrote: IMO you should just do this in brw_link() when its cheap. You will be doing the deserialization at draw time here which is not what we want. Can also drop the serialized_nir params if you follow my suggestions in patch 14. I still think you might want

Re: [Mesa-dev] [PATCH v2 14/32] glsl/shader_cache: Save and restore serialized nir in gl_program

On 20/10/17 09:03, Timothy Arceri wrote: This and the previous patch feels wrong. The glsl shader cache shouldn't be handling writing nir to disk. IMO you should add this functionality to nir_serialize.c (maybe rename is nir_cache.c ??). That way we have continue with the nir is a toolkit

Re: [Mesa-dev] [PATCH v2 09/32] glsl_to_nir: Zero nir_variable struct for valgrind & nir_serialize

On Wednesday, October 18, 2017 10:31:57 PM PDT Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/compiler/glsl/glsl_to_nir.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/glsl/glsl_to_nir.cpp >

Re: [Mesa-dev] [PATCH v2 08/32] nir: Zero nir_load_const_instr::value for valgrind & nir_serialize

On Wednesday, October 18, 2017 10:31:56 PM PDT Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/compiler/nir/nir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c > index fe48451694..cbba9c8749

Re: [Mesa-dev] [PATCH v2 07/32] intel/nir: Zero local index const struct for valgrind & nir_serialize

On Wednesday, October 18, 2017 10:31:55 PM PDT Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/intel/compiler/brw_nir_lower_cs_intrinsics.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/intel/compiler/brw_nir_lower_cs_intrinsics.c >

Re: [Mesa-dev] [PATCH v2 06/32] nir: Zero local_size const struct for valgrind & nir_serialize

On Wednesday, October 18, 2017 10:31:54 PM PDT Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/compiler/nir/nir_lower_system_values.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/compiler/nir/nir_lower_system_values.c >

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/compiler/glsl/builtin_variables.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/compiler/glsl/builtin_variables.cpp >

Re: [Mesa-dev] [PATCH v2 03/32] nir/intrinsics: Set the correct num_indices for load_output

On Wednesday, October 18, 2017 10:31:51 PM PDT Jordan Justen wrote: > From: Jason Ekstrand > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/compiler/nir/nir_intrinsics.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH v2 02/32] nir: Get rid of nir_shader::stage

On Wednesday, October 18, 2017 10:31:50 PM PDT Jordan Justen wrote: > From: Jason Ekstrand > > It's redundant with nir_shader::info::stage. I hate the extra wordiness here, but removing the redundancy is certainly a reasonable thing to do. So, as much as I dislike

Re: [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

On Thu, Oct 19, 2017 at 4:18 PM, Kenneth Graunke wrote: > The kernel doesn't initialize the value of the INSTPM or CS_DEBUG_MODE2 > registers at context initialization time. Instead, they're inherited > from whatever happened to be running on the GPU prior to first run of

[Mesa-dev] [PATCH] i965/fs: Use align1 mode on ternary instructions on Gen10+

Align1 mode offers some nice features over align16, like access to more data types and the ability to use a 16-bit immediate. This patch does not start using any new features. It just emits ternary instructions in align1 mode. --- src/intel/compiler/brw_fs_generator.cpp | 12 1 file

Re: [Mesa-dev] [PATCH 10/13] i965: Add align1 ternary instruction disassembler support

On Fri, Sep 29, 2017 at 5:11 PM, Scott D Phillips wrote: > Matt Turner writes: > >> --- >> src/intel/compiler/brw_disasm.c | 399 >> +--- >> src/intel/compiler/brw_eu_defines.h | 11 - >> 2 files changed, 322

[Mesa-dev] [PATCH] i965: Add align1 ternary instruction emission support

--- src/intel/compiler/brw_eu_emit.c | 219 +-- 1 file changed, 166 insertions(+), 53 deletions(-) diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c index 7495a19fd8..4f98860044 100644 --- a/src/intel/compiler/brw_eu_emit.c +++

[Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

The kernel doesn't initialize the value of the INSTPM or CS_DEBUG_MODE2 registers at context initialization time. Instead, they're inherited from whatever happened to be running on the GPU prior to first run of a new context. So, when we started setting these, other contexts in the system

[Mesa-dev] [PATCH] i965: Add align1 ternary instruction-word support

Reviewed-by: Scott D Phillips --- src/intel/compiler/brw_inst.h | 108 ++ 1 file changed, 108 insertions(+) diff --git a/src/intel/compiler/brw_inst.h b/src/intel/compiler/brw_inst.h index 1ddee77164..40723f9012 100644 ---

Re: [Mesa-dev] [PATCH 09/13] i965: Add align1 ternary instruction-word support

On Fri, Sep 29, 2017 at 5:08 PM, Scott D Phillips wrote: > Matt Turner writes: > >> --- >> src/intel/compiler/brw_inst.h | 114 >> ++ >> 1 file changed, 114 insertions(+) >> >> diff --git

[Mesa-dev] [PATCH] i965: Add align1 ternary instruction support to conversion functions

--- src/intel/compiler/brw_disasm.c | 16 ++- src/intel/compiler/brw_inst.h | 4 +- src/intel/compiler/brw_reg_type.c | 99 --- src/intel/compiler/brw_reg_type.h | 16 +-- 4 files changed, 101 insertions(+), 34 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 12/13] i965/fs: Use align1 mode on ternary instructions on Gen10+

On Fri, Sep 29, 2017 at 5:20 PM, Scott D Phillips wrote: > Matt Turner writes: > >> Align1 mode offers some nice features over align16, like access to more >> data types and the ability to use a 16-bit immediate. This patch does >> not start using

Re: [Mesa-dev] [PATCH 08/13] i965: Add align1 ternary instruction support to conversion functions

On Fri, Sep 29, 2017 at 5:07 PM, Scott D Phillips wrote: > Matt Turner writes: > >> --- >> src/intel/compiler/brw_disasm.c | 12 --- >> src/intel/compiler/brw_inst.h | 4 +-- >> src/intel/compiler/brw_reg_type.c | 76 >>

Re: [Mesa-dev] [PATCH v2 16/32] i965: Don't rely on nir for uses_texture_gather

On 20/10/17 09:38, Jordan Justen wrote: On 2017-10-19 15:07:45, Timothy Arceri wrote: Maybe you should just do: prog->nir->info = prog->info; After you restore nir from the cache? We only deserialize from nir if the gen program restore fails. So, hopefully prog->nir will be NULL. IMO we

Re: [Mesa-dev] [PATCH v2 16/32] i965: Don't rely on nir for uses_texture_gather

On 2017-10-19 15:07:45, Timothy Arceri wrote: > Maybe you should just do: > > prog->nir->info = prog->info; > > After you restore nir from the cache? We only deserialize from nir if the gen program restore fails. So, hopefully prog->nir will be NULL. -Jordan > > On 19/10/17 16:32, Jordan

Re: [Mesa-dev] [PATCH] swr: Rework scratch space allocation

Reviewed-by: Bruce Cherniak > On Oct 19, 2017, at 4:40 PM, George Kyriazis > wrote: > > Remove allocation of > 2kbyte buffers into context memory in > swr_copy_to_scatch_space() (which is used to copy small vertex/index buffers > and

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 08:45, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 5:35 PM, Timothy Arceri wrote: On 20/10/17 08:27, Timothy Arceri wrote: On 20/10/17 08:19, Timothy Arceri wrote: On 20/10/17 04:21, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin

Re: [Mesa-dev] [PATCH v2 32/32] disk_cache: Add support for MESA_GLSL_CACHE_TIMESTAMP in debug builds

Maybe add to docs? On 19/10/17 16:32, Jordan Justen wrote: The MESA_GLSL_CACHE_TIMESTAMP environment variable can be set to override the driver timestamp. Usually the driver will specify a hash of their driver build so the cache items become invalid with each driver build. We don't guarantee a

Re: [Mesa-dev] [PATCH v2 29/32] disk_cache: Fix issue reading GLSL metadata

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 28/32] glsl/shader_cache: Save fs (BlendSupport) metadata

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 27/32] i965: Initialize sha1 hash of dri config options

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 25/32] i965: add cache fallback support using serialized nir

IMO you should just do this in brw_link() when its cheap. You will be doing the deserialization at draw time here which is not what we want. Can also drop the serialized_nir params if you follow my suggestions in patch 14. On 19/10/17 16:32, Jordan Justen wrote: If the i965 gen program

Re: [Mesa-dev] [PATCH v2 22/32] i965: Add shader cache support for compute

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 16/32] i965: Don't rely on nir for uses_texture_gather

Maybe you should just do: prog->nir->info = prog->info; After you restore nir from the cache? On 19/10/17 16:32, Jordan Justen wrote: When a program is restored from the shader cache, prog->nir will be NULL, but prog->info will be restored. Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH v2 14/32] glsl/shader_cache: Save and restore serialized nir in gl_program

This and the previous patch feels wrong. The glsl shader cache shouldn't be handling writing nir to disk. IMO you should add this functionality to nir_serialize.c (maybe rename is nir_cache.c ??). That way we have continue with the nir is a toolkit theme and we can easily reused the util to

Re: [Mesa-dev] [PATCH v2 12/32] nir: Add hooks for testing serialization

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 11/32] nir: add serialization and deserialization

Acked-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] radv: Enable tessellation shaders for GFX9.

It mostly works now. --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 7f306db5c48..125498809ec 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@

[Mesa-dev] [PATCH 1/2] ac/nir: init full exec mask for merged shaders.

From: Dave Airlie Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_llvm_build.c | 8 src/amd/common/ac_llvm_build.h | 1 + src/amd/common/ac_nir_to_llvm.c | 3 +++ 3 files changed, 12 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v2 10/32] glsl_to_nir: Zero nir_constant in constant_copy for valgrind & nir_serialize

5-10: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 04/32] compiler/types: Support [de]serializing void types

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Thu, Oct 19, 2017 at 5:35 PM, Timothy Arceri wrote: > > > On 20/10/17 08:27, Timothy Arceri wrote: >> >> >> >> On 20/10/17 08:19, Timothy Arceri wrote: >>> >>> On 20/10/17 04:21, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin

Re: [Mesa-dev] [PATCH v2 03/32] nir/intrinsics: Set the correct num_indices for load_output

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 02/32] nir: Get rid of nir_shader::stage

Acked-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 01/32] glsl: move shader_cache type handling to glsl_types

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] swr: Rework scratch space allocation

Remove allocation of > 2kbyte buffers into context memory in swr_copy_to_scatch_space() (which is used to copy small vertex/index buffers and shader constants to a scratch space to be used by the upcoming draw.) Large shader constant allocations need to be done in the circular scratch buffer

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 08:27, Timothy Arceri wrote: On 20/10/17 08:19, Timothy Arceri wrote: On 20/10/17 04:21, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: On Thu, 2017-10-19

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 08:19, Timothy Arceri wrote: On 20/10/17 04:21, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: On Thu, 2017-10-19 at 12:37 -0400, Ilia Mirkin wrote: Will this

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Thu, Oct 19, 2017 at 5:19 PM, Timothy Arceri wrote: > On 20/10/17 04:21, Ilia Mirkin wrote: >> >> On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin >> wrote: >>> >>> On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: On

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On 20/10/17 04:21, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin wrote: On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: On Thu, 2017-10-19 at 12:37 -0400, Ilia Mirkin wrote: Will this work with SSO shaders? Presumably the

Re: [Mesa-dev] [PATCH v2 1/8] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper (v2)

De-duplicating and then trimming down works for me. On Thu, Oct 19, 2017 at 3:31 AM, Emil Velikov wrote: > On 18 October 2017 at 23:36, Gurchetan Singh > wrote: > >> Then again, I'd suggest keeping that as separate series. These patches >

[Mesa-dev] [PATCH v2 5/5] etnaviv: fix implicit conversion warning

Galliums query_type used in APIs is unsigned. Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_query.h| 2 +- src/gallium/drivers/etnaviv/etnaviv_query_sw.c | 2 +- 2 files changed,

[Mesa-dev] [PATCH v2 3/5] etnaviv: add support for occlusion queries

Passes most occlusion query piglits. The following piglits are broken: - spec@arb_occlusion_query@occlusion_query_meta_fragments - spec@arb_occlusion_query@occlusion_query_meta_save - spec@arb_occlusion_query2@render v1 -> v2: - use one sample provider for all occlusion queries tyes - add

[Mesa-dev] [PATCH v2 4/5] etnaviv: enable occlusion query if GPU supports it

Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c

[Mesa-dev] [PATCH v2 1/5] etnaviv: update headers from rnndb

Update to etna_viv commit 6c9c706. Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/hw/cmdstream.xml.h | 36 ++- src/gallium/drivers/etnaviv/hw/common.xml.h| 117

[Mesa-dev] [PATCH v2 2/5] etnaviv: add basic infrastructure for hw queries

No hardware query is supported yet. v1 -> v2 - removed query_type from strcut etna_hw_sample_provider Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/Makefile.sources | 2 + src/gallium/drivers/etnaviv/etnaviv_context.c | 11 ++

Re: [Mesa-dev] [PATCH 4/4] meson: Add support for EGL glvnd

Works just fine for me, and patch looks good. Reviewed-by: Lyude Paul On Wed, 2017-10-18 at 16:55 -0700, Dylan Baker wrote: > Signed-off-by: Dylan Baker > --- > src/egl/meson.build | 46 -- > 1 file

Re: [Mesa-dev] [PATCH 3/5] etnaviv: add support for occlusion queries

> There is one difference - how the sum is interpreted - uint64_t vs. bool > value. In general the code Ok in that case it's ok like this, just looked like unnecessary/accidental duplication. Regards, Wladimir ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] radv: don't flush the VS when srcStageMask == TOP_OF_PIPE_BIT

Reviewed-by: Bas Nieuwenhuizen On Thu, Oct 19, 2017 at 8:54 PM, Fredrik Höglund wrote: > The Vulkan specification says: > >"... an execution dependency with only VK_PIPELINE_STAGE_TOP_OF_- > PIPE_BIT in the source stage mask will effectively

Re: [Mesa-dev] [PATCH 1/2] radv: be smarter with descriptors when emitting secondary buffers

On Wed, Oct 11, 2017 at 5:18 PM, Samuel Pitoiset wrote: > If the secondary buffers don't use any descriptors we don't > have to re-emit the ones from the primary command buffer. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 8/9] radv: add radv_emit_shaders_prefetch()

On Tue, Oct 17, 2017 at 11:03 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 38 ++ > 1 file changed, 26 insertions(+), 12 deletions(-) > > diff

[Mesa-dev] [PATCH] radv: don't flush the VS when srcStageMask == TOP_OF_PIPE_BIT

The Vulkan specification says: "... an execution dependency with only VK_PIPELINE_STAGE_TOP_OF_- PIPE_BIT in the source stage mask will effectively not wait for any prior commands to complete." Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_cmd_buffer.c | 3

Re: [Mesa-dev] [PATCH 2/2] radv: copy indirect lowering settings from radeonsi

Reviewed-by: Bas Nieuwenhuizen as well. On Thu, Oct 19, 2017 at 12:27 AM, Timothy Arceri wrote: > It looks the original indirect mask was probably copied from > ANV. > > Sascha Willems demo results: > > tessellation ~4000 -> ~4200 fps > > V2:

Re: [Mesa-dev] Upstream support for FreeSync / Adaptive Sync

On Wed, Oct 18, 2017 at 09:28:01PM +0200, Daniel Vetter wrote: > On Wed, Oct 18, 2017 at 6:59 PM, Michel Dänzer wrote: > > On 18/10/17 12:15 PM, Nicolai Hähnle wrote: > >> On 18.10.2017 10:10, Daniel Vetter wrote: > >>> On Tue, Oct 17, 2017 at 09:01:52PM +0200, Nicolai Hähnle

Re: [Mesa-dev] [PATCH 3/3] radv: re-emit VGT_INDEX_TYPE because non-indexed draws overwrite it

r-b for the series. MAybe add a fixes tag? On Thu, Oct 19, 2017 at 12:35 PM, Samuel Pitoiset wrote: > Only on CIK and later. We should only update VGT_INDEX_TYPE but > it seems easier to re-emit all the index buffer packets. > > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH] radv: move DB_COUNT_CONTROL initialization to si_emit_config()

r-b On Thu, Oct 19, 2017 at 4:25 PM, Samuel Pitoiset wrote: > CLEAR_STATE will initialize DB_COUNT_CONTROL to 0 for CIK+. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 1 - > src/amd/vulkan/si_cmd_buffer.c

Re: [Mesa-dev] [PATCH] meson: don't build gallium dri target if gallium is disabled

On Thu, Oct 19, 2017 at 10:32:46AM -0700, Dylan Baker wrote: > Otherwise -Dgallium-drivers= will cause libmesa_gallium to be built and > the megadriver install script to attempt to install drivers without any > actual drivers being built. Tested-by: Rafael Antognolli

[Mesa-dev] [PATCH 12/12] anv: Add support for the variablePointers feature

Not to be confused with variablePointersStorageBuffer which is the subset of VK_KHR_variable_pointers required to enable the extension. This means we now have "full" support for variable pointers. --- src/intel/vulkan/anv_device.c | 2 +- src/intel/vulkan/anv_pipeline.c | 5 ++--- 2 files

[Mesa-dev] [PATCH 05/12] spirv: Refactor the base case of offset_pointer_dereference

This makes us key off of !offset instead of !block_index. It also puts the guts inside a switch statement so that we can handle more than just UBOs and SSBOs. --- src/compiler/spirv/vtn_variables.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-)

[Mesa-dev] [PATCH 10/12] spirv: Rename get_shared_nir_atomic_op to get_var_nir_atomic_op

--- src/compiler/spirv/spirv_to_nir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index a2dcbcf..96ecff6 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@

[Mesa-dev] [PATCH 08/12] spirv: Use offset_pointer_dereference to instead of get_vulkan_resource_index

There is no good reason why we should have the same logic repeated in get_vulkan_resource_index and vtn_ssa_offset_pointer_dereference. If we're a bit more careful about how we do things, we can just use the one function and get rid of the other entirely. This also makes the push constant

[Mesa-dev] [PATCH 09/12] spirv: Add theoretical support for single component pointers

Up until now, all pointers have been ivec2s. We're about to add support for pointers to workgroup storage and those are going to be uints. --- src/compiler/spirv/vtn_variables.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 07/12] spirv: Refactor a couple of pointer query helpers

This commit moves them both into vtn_variables.c towards the top, makes them take a vtn_builder, and replaces a hand-rolled instance of is_external_block with a function call. --- src/compiler/spirv/vtn_private.h | 7 --- src/compiler/spirv/vtn_variables.c | 35

[Mesa-dev] [PATCH 11/12] spirv: Add support for lowering workgroup access to offsets

Before, we always left workgroup variables as shared nir_variables and let the driver call nir_lower_io. This adds an option to do the lowering directly in spirv_to_nir. To do this, we implicitly assign the variables a std430 layout and then treat them like a UBO or SSBO and immediately lower

[Mesa-dev] [PATCH 04/12] spirv: Add a switch statement for the block store opcode

This parallels what we do for vtn_block_load except that we don't yet support anything except SSBO loads through this path. --- src/compiler/spirv/vtn_variables.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c

[Mesa-dev] [PATCH 03/12] spirv: Use a dereference instead of vtn_variable_resource_index

This is equivalent and means we don't have resource index code scattered about. --- src/compiler/spirv/vtn_variables.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index

[Mesa-dev] [PATCH 02/12] spirv: Only emit functions which are actually used

Instead of emitting absolutely everything, just emit the few functions that are actually referenced in some way by the entrypoint. This should save us quite a bit of time when handed large shader modules containing many entrypoints. --- src/compiler/spirv/spirv_to_nir.c | 29

[Mesa-dev] [PATCH 06/12] spirv: Convert the supported_extensions struct to spirv_options

This is a bit more general and lets us pass additional options into the spirv_to_nir pass beyond what capabilities we support. --- src/amd/vulkan/radv_shader.c | 23 +-- src/compiler/spirv/nir_spirv.h| 26 ++ src/compiler/spirv/spirv_to_nir.c |

[Mesa-dev] [PATCH 01/12] spirv: Drop the impl field from vtn_builder

We have a nir_builder and it has an impl field. --- src/compiler/spirv/spirv_to_nir.c | 9 - src/compiler/spirv/vtn_cfg.c | 2 +- src/compiler/spirv/vtn_private.h | 1 - src/compiler/spirv/vtn_variables.c | 2 +- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

Not to be confused with variablePointersStorageBuffer which is the subset of VK_KHR_variable_pointers required to enable the extension. This gives us "full" support for variable pointers. The approach chosen here was to do the lowering to _shared intrinsics directly in spirv_to_nir instead of

Re: [Mesa-dev] [PATCH 5/5] etnaviv: fix implicit conversion warning

On Tue, Oct 17, 2017 at 10:38:17PM +0200, Christian Gmeiner wrote: > Galliums query_type used in APIs is unsigned. Reviewed-by: Wladimir J. van der Laan > Signed-off-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_query.h| 2

Re: [Mesa-dev] [PATCH 3/5] etnaviv: add support for occlusion queries

On Tue, Oct 17, 2017 at 10:38:15PM +0200, Christian Gmeiner wrote: > Passes most occlusion query piglits. The following piglits are broken: > - spec@arb_occlusion_query@occlusion_query_meta_fragments > - spec@arb_occlusion_query@occlusion_query_meta_save > - spec@arb_occlusion_query2@render > >

Re: [Mesa-dev] [PATCH 4/5] etnaviv: enable occlusion query if GPU supports it

On Tue, Oct 17, 2017 at 10:38:16PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH 2/5] etnaviv: add basic infrastructure for hw queries

On Tue, Oct 17, 2017 at 10:38:14PM +0200, Christian Gmeiner wrote: > No hardware query is supported yet. > > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH] gallium: add more exceptions to tgsi_util_get_inst_usage_mask

Reviewed-by: Marek Olšák Marek On Thu, Oct 19, 2017 at 6:40 PM, Tim Rowley wrote: > A number of double/int64 operations don't have matching > read and write usage masks, which the fallthrough case of > tgsi_util_get_inst_usage_mask assumes for

[Mesa-dev] [PATCH] meson: don't build gallium dri target if gallium is disabled

Otherwise -Dgallium-drivers= will cause libmesa_gallium to be built and the megadriver install script to attempt to install drivers without any actual drivers being built. fixes: 66f97f6640f5316b36177fd1053f0027eb6ec6cc ("meson: build radeonsi") Reported-by: Rafael Antognolli

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

Quoting Emil Velikov (2017-10-19 09:44:37) > On 18 October 2017 at 18:27, Dylan Baker wrote: > > >> > +Note that in meson this defaults to "debug", and not setting it to > >> > +"release" will yield non-optimal performance and binary size > >> Ouch, can we change that? > >

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin wrote: > On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: >> On Thu, 2017-10-19 at 12:37 -0400, Ilia Mirkin wrote: >>> Will this work with SSO shaders? Presumably the validation still has >>> to happen, but

Re: [Mesa-dev] [PATCH 3/4] meson: build libEGL

Quoting Daniel Stone (2017-10-19 07:34:28) > Hi Dylan, > > On 19 October 2017 at 01:55, Dylan Baker wrote: > > This is based heavily on Daniel Stone's work for the same, rebased on > > master and with a number of TODO's fixed. > > > > This does not implement glvnd (which is

Re: [Mesa-dev] [PATCH 1/5] etnaviv: update headers from rnndb

On Tue, Oct 17, 2017 at 10:38:13PM +0200, Christian Gmeiner wrote: > Update to etna_viv commit 6c9c706. > > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/hw/cmdstream.xml.h | 36 ++- >

Re: [Mesa-dev] [PATCH] gallium: add more exceptions to tgsi_util_get_inst_usage_mask

Reviewed-by: Roland Scheidegger Albeit the way those masks are derived looks quite error-prone in general (especially for new opcodes). Am 19.10.2017 um 18:40 schrieb Tim Rowley: > A number of double/int64 operations don't have matching > read and write usage masks, which

Re: [Mesa-dev] [PATCH 2/4] glsl/linker: fix location aliasing checks for interface variables

On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral wrote: > On Thu, 2017-10-19 at 12:37 -0400, Ilia Mirkin wrote: >> Will this work with SSO shaders? Presumably the validation still has >> to happen, but I don't think cross_validate_outputs_to_inputs() will >> end up getting called.

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

On 18 October 2017 at 18:27, Dylan Baker wrote: >> > +Note that in meson this defaults to "debug", and not setting it to >> > +"release" will yield non-optimal performance and binary size >> Ouch, can we change that? > > When I did an informal poll in the Intel cube the

[Mesa-dev] [PATCH] gallium: add more exceptions to tgsi_util_get_inst_usage_mask

A number of double/int64 operations don't have matching read and write usage masks, which the fallthrough case of tgsi_util_get_inst_usage_mask assumes for componentwise tagged instructions. No regressions in llvmpipe piglit; fixes a large number of swr regressions. ---

Re: [Mesa-dev] [PATCH 0/7] swr: rasterizer update

Reviewed-by: Bruce Cherniak > On Oct 19, 2017, at 8:12 AM, Tim Rowley wrote: > > Highlights are code cleanups, some more simd16 work (disabled by default), > and tuning for the Intel Xeon Phi architecture. > > Tim Rowley (7): >

  1   2   >