Re: [Mesa-dev] [PATCH v3 00/10] glsl_to_tgsi: Further improvement of lifetime tracking for register merge

Hi, I'd like to send out a ping for this series, many thanks, Gert Am Mittwoch, den 25.10.2017, 11:51 +0200 schrieb Gert Wollny: > Dear all,  > > this is a minor update to the patch set that adds enhanced tracking > of IF/ELSE branches and tracking of reladdr* registers for the >

Re: [Mesa-dev] [PATCH 08/23] gallium/aux/util/u_format_latc.c: Fix various -Wunused-param warnings,

Hello Brian, thanks for the review, one thing though ... Am Montag, den 13.11.2017, 09:31 -0700 schrieb Brian Paul: > Also, can you please wrap long lines at 78 columns? I'm kind of in doubt whether the hard limit of 78 makes sense here, i.e. when I do this then I will have to put every

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #3 from Tapani Pälli --- (In reply to Tapani Pälli from comment #1) > This very likely bisects to commit 688d6958682f96aaeb88aa8cc23cc5c9886a6be4 > so I'm taking this bug. Or maybe not since this was seen also

[Mesa-dev] [PATCH] spirv: fix typo on DO NOT EDIT header

Introduced on commit 157c9a13414b524ce98ea0ea07fce819efc1ba65 --- src/compiler/spirv/spirv_info_c.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_info_c.py b/src/compiler/spirv/spirv_info_c.py index 11235cfa3e4..d898bf0131b 100644 ---

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #2 from Tapani Pälli --- BTW how did you install plasma 5.11.3? Kubuntu artful has 5.10.5 by default. -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED

Re: [Mesa-dev] [PATCH] i965/fs: Fix extract_i8/u8 to a 64-bit destination

On November 13, 2017 22:54:02 Matt Turner wrote: On Mon, Nov 13, 2017 at 10:06 PM, Jason Ekstrand wrote: On Mon, Nov 13, 2017 at 3:23 PM, Matt Turner wrote: The MOV instruction can extract bytes to words/double words, and

Re: [Mesa-dev] [PATCH] i965/fs: Fix extract_i8/u8 to a 64-bit destination

On Mon, Nov 13, 2017 at 10:06 PM, Jason Ekstrand wrote: > On Mon, Nov 13, 2017 at 3:23 PM, Matt Turner wrote: >> >> The MOV instruction can extract bytes to words/double words, and >> words/double words to quadwords, but not byte to quadwords. >> >> For

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

On 14/11/17 13:30, Ian Romanick wrote: On 11/10/2017 02:35 AM, Timothy Arceri wrote: diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 6b5c5bbb36..7c357b07ee 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -2352,58 +2376,29 @@ struct

[Mesa-dev] [AppVeyor] mesa master #6145 completed

Build mesa 6145 completed Commit fb0e9b5197 by Jason Ekstrand on 11/3/2017 11:11 PM: i965: Track the depth and render caches separately\n\nPreviously, we just had one hash set for tracking depth and render\ncaches called brw_context::render_cache. This is

Re: [Mesa-dev] [PATCH] i965/fs: Fix extract_i8/u8 to a 64-bit destination

On Mon, Nov 13, 2017 at 3:23 PM, Matt Turner wrote: > The MOV instruction can extract bytes to words/double words, and > words/double words to quadwords, but not byte to quadwords. > > For unsigned byte to quadword, we can read them as words and AND off the > high byte and

Re: [Mesa-dev] [PATCH 11/18] intel/tools/disasm: make sure that entire range is disassembled

Your theory makes sense to me too; I suspect that something in the annotation code is the ultimate cause. -Original Message- From: Matt Turner [mailto:matts...@gmail.com] Sent: Monday, November 13, 2017 9:15 PM To: Rogovin, Kevin Cc:

Re: [Mesa-dev] [PATCH 10/18] intel/tools/disasm: add gen_disasm_assembly_length function

I need this function in order for the logger to save shader binary to disk. -Kevin -Original Message- From: Matt Turner [mailto:matts...@gmail.com] Sent: Monday, November 13, 2017 9:43 PM To: Rogovin, Kevin Cc: mesa-dev@lists.freedesktop.org Subject: Re:

[Mesa-dev] [AppVeyor] mesa master #6144 failed

Build mesa 6144 failed Commit 4b1e70cc57 by Jason Ekstrand on 11/14/2017 4:13 AM: i965: Switch over to fully external-or-not MOCS scheme\n\nReviewed-by: Kenneth Graunke Configure your notification preferences

[Mesa-dev] [PATCH 1/2] nir: fill outputs_read field and add patch outputs read

From: Dave Airlie This is to be used for TCS optimisations on radv. --- src/compiler/nir/nir_gather_info.c | 29 ++--- src/compiler/shader_info.h | 2 ++ 2 files changed, 24 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] ac/nir: don't write tcs outputs to LDS that aren't read back.

From: Dave Airlie If the TCS doesn't read back the outputs, no need to store them to LDS in the first place. (except for tess factors). This seems to give about 50fps (3290->3330) with tessellation demo. I haven't tested if it impacts DoW3 at all. Signed-off-by: Dave

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 Tapani Pälli changed: What|Removed |Added CC||lem...@gmail.com --

Re: [Mesa-dev] [PATCH 2/4] i965: Add more precise cache tracking helpers

On Mon, Nov 13, 2017 at 4:33 PM, Kenneth Graunke wrote: > On Monday, November 6, 2017 1:38:55 PM PST Jason Ekstrand wrote: > > In theory, this will let us track the depth and render caches > > separately. Right now, they're just wrappers around > > brw_render_cache_set_*

Re: [Mesa-dev] [PATCH 1/2] radv: Free syncobj with multiple imports.

Reviewed-by: Dave Airlie On 14 November 2017 at 09:45, Bas Nieuwenhuizen wrote: > Otherwise we can leak the old syncobj. > > Fixes: eaa56eab6da "radv: initial support for shared semaphores (v2)" > --- > src/amd/vulkan/radv_device.c | 10 --

[Mesa-dev] [PATCH] radv: it isn't an error to not support a format or driver

From: Dave Airlie This reverts two of the vk_error changes: reporting unsupported format is common, and testing non-amdgpu drivers and ignoring them is also common. Fixes: cd64a4f70 (radv: use vk_error() everywhere an error is returned) Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

On 11/10/2017 02:35 AM, Timothy Arceri wrote: > diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h > index 6b5c5bbb36..7c357b07ee 100644 > --- a/src/mesa/main/mtypes.h > +++ b/src/mesa/main/mtypes.h > @@ -2352,58 +2376,29 @@ struct gl_fragment_program_state > */ > struct

Re: [Mesa-dev] [PATCH 5/5] r600: set the number type correctly for float rts in cb setup

Ping (for the series)? Roland Am 09.11.2017 um 20:00 schrieb srol...@vmware.com: > From: Roland Scheidegger > > Float rts were always set as unorm instead of float. > Not sure of the consequences, but at least it looks like the blend clamp > would have been enabled, which

[Mesa-dev] [PATCH] swr/rast: Use gather instruction for i32gather_ps on simd16/avx512

Speed up avx512 platforms; fixes performance regression caused by swithc to simdlib. Cc: mesa-sta...@lists.freedesktop.org --- .../drivers/swr/rasterizer/common/simdlib_512_avx512.inl | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH] swr/rast: Faster emulated simd16 permute

Speed up simd16 frontend (default) on avx/avx2 platforms; fixes performance regression caused by switch to simdlib. Cc: mesa-sta...@lists.freedesktop.org --- .../swr/rasterizer/common/simdlib_512_emu.inl | 34 +++--- 1 file changed, 11 insertions(+), 23 deletions(-) diff

Re: [Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

Miklós Máté writes: > On 12/11/17 00:06, Timothy Arceri wrote: >> On 12/11/17 04:10, Miklós Máté wrote: >>> Hi, >>> >>> this breaks a few things. The patch below gets rid of the assertion >>> failures, but the reference counting needs a proper fix, and swrast >>> draws

[Mesa-dev] [PATCH v3 09/15] meson: extend install_megadrivers script to handle symmlinking

which is required for the gallium media state trackers. --- bin/install_megadrivers.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py index a98d7dd177b..581ff9791e5 100755 --- a/bin/install_megadrivers.py +++

Re: [Mesa-dev] [PATCH 04/11] intel/tools/error: Only decode a few sections of error states.

On Sunday, November 12, 2017 1:41:29 AM PST Chris Wilson wrote: > Quoting Kenneth Graunke (2017-11-12 08:35:05) > > These three are the only we can reasonably decode with genxml. > > Makes sense, I would recommend putting those into an array for ease of > future expansion. Maybe also strcasecmp?

[Mesa-dev] [PATCH v3 10/15] meson: drop gallium-media argument

This argument is the wrong approach for handling gallium media state trackers, since it doesn't allow for an auto option. Instead we'll use tristates, which do allow for auto. This option has never been wired to anything anyway. Signed-off-by: Dylan Baker ---

[Mesa-dev] [PATCH v3 14/15] meson: build gallium va state tracker

v2: - set with_gallium_va when -Dgallium-va=true - Fix megadrivers install - only use cflags from pkg-config, don't add linker flags. - Don't get version from pkg-config, it's not tracking the same version information. --- meson.build | 41

[Mesa-dev] [PATCH v3 08/15] autotools: change version TINY -> PATCH

Because patch is more common than tiny for talking about the 3rd element of a version. Signed-off-by: Dylan Baker --- configure.ac | 6 +++--- src/gallium/state_trackers/xa/xa_tracker.h.in | 2 +-

[Mesa-dev] [PATCH v3 12/15] meson: build gallium xvmc state tracker

v2: - set with_gallium_xvmc when -Dgallium-xvmc=true - Install megadrivers properly - only use cflags from pkg-config, don't add linker flags. --- meson.build | 40 ++- meson_options.txt | 13 +

[Mesa-dev] [PATCH v3 03/15] meson: build r300 driver

This is build tested only Signed-off-by: Dylan Baker --- meson.build | 6 +- src/gallium/drivers/r300/meson.build | 156 +++ src/gallium/meson.build | 9 +- src/gallium/targets/dri/meson.build |

[Mesa-dev] [PATCH v3 06/15] meson: build virgl driver

Build tested only. Signed-off-by: Dylan Baker --- meson.build| 16 src/gallium/drivers/virgl/meson.build | 39 ++ src/gallium/meson.build| 7 +-

[Mesa-dev] [PATCH v3 15/15] meson: build gallium xa state tracker

v2: - set with_gallium_xa when -Dgallium-xa=true - install pkg config file --- meson.build | 22 meson_options.txt | 7 +++ src/gallium/meson.build | 7 ++- src/gallium/state_trackers/xa/meson.build | 45

[Mesa-dev] [PATCH v3 07/15] autotools: set XA versions in configure.ac and configure header file

Currently the versions are set in the header, and then sed is used to extract them, so that autotools can use them elsewhere. This is odd. Autotools is perfectly capable of configuring the header with the versions, and then they don't need to be extracted from the the header. This is cleaner and

[Mesa-dev] [PATCH v3 00/15] Remaining gallium drivers + media

This gets most of the remaining gallium drivers building with meson (a feature needed for SWR and clover is slated to land soon in upstream meson). For the most part this should be straight forward stuff Changes since v1: - do not link media state trackers with their frontends - fix

[Mesa-dev] [PATCH v3 04/15] meson: build r600 driver

Signed-off-by: Dylan Baker Tested-by: Aaron Watry --- meson.build | 22 -- src/gallium/drivers/r600/meson.build | 128 +++ src/gallium/meson.build | 6 +-

[Mesa-dev] [PATCH v3 02/15] meson: build i915g driver

Build tested only. Signed-off-by: Dylan Baker --- meson.build | 7 +++- src/gallium/drivers/i915/meson.build| 70 + src/gallium/meson.build | 7 ++-- src/gallium/targets/dri/meson.build

[Mesa-dev] [PATCH v3 13/15] meson: build gallium omx state tracker

v2: - set with_gallium_omx when -Dgallium-omx=true - Fix detection of omx plugins dir - only use cflags from pkg-config, don't add linker flags. --- meson.build| 60 - meson_options.txt | 13

[Mesa-dev] [PATCH v3 11/15] meson: build gallium vdpau state tracker

v2: - set with_gallium_vdpau when -Dgallium-vdpau=true - Install megadriver hard links and symlinks - only use cflags from pkg-config, don't add linker flags. --- meson.build | 46 - meson_options.txt| 13

[Mesa-dev] [PATCH v3 05/15] meson: build svga driver on linux

Build tested only. Signed-off-by: Dylan Baker --- meson.build | 6 ++- src/gallium/drivers/svga/meson.build| 88 + src/gallium/meson.build | 5 +- src/gallium/targets/dri/meson.build

[Mesa-dev] [PATCH v3 01/15] meson: add proper LLVM modules to check for RadeonSI as well

Signed-off-by: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index e8467590df2..8ea2b3e106c 100644 --- a/meson.build +++ b/meson.build @@ -702,7 +702,7 @@ if with_gallium_freedreno endif

Re: [Mesa-dev] [PATCH 4/4] i965: Use prepare_external instead of make_shareable in setTexBuffer2

On Wednesday, November 8, 2017 3:20:47 PM PST Jason Ekstrand wrote: > The setTexBuffer2 hook from GLX is used to implement glxBindTexImageEXT > which has tighter restrictions than just "it's shared". In particular, > it says that any rendering to the image while it is bound causes the > contents

Re: [Mesa-dev] [PATCH 10/10] spirv: Generate SPIR-V builder infrastructure

Quoting Ian Romanick (2017-11-13 16:00:08) > > That's what I had first, and it did not work in some cases. I believe > that list==list is only True if the elements have the same order. This > function only requires that both lists have the same contents without > regard for order. I will add a

Re: [Mesa-dev] [PATCH 2/4] i965: Add more precise cache tracking helpers

On Monday, November 6, 2017 1:38:55 PM PST Jason Ekstrand wrote: > In theory, this will let us track the depth and render caches > separately. Right now, they're just wrappers around > brw_render_cache_set_* > --- > src/mesa/drivers/dri/i965/brw_draw.c | 12 +-- >

Re: [Mesa-dev] [PATCH 10/10] spirv: Generate SPIR-V builder infrastructure

On 11/13/2017 02:01 PM, Dylan Baker wrote: > Quoting Ian Romanick (2017-11-10 14:32:50) > [snip] >> + >> +def can_have_extra_operands(name, enums): >> +"""Determine whether an enum can have extra operands. >> + >> +Some enums, like SpvDecoration, can have extra operands with some >>

Re: [Mesa-dev] [PATCH 11/11] intel/tools/error: Decode compute shaders.

On 13/11/17 21:40, Kenneth Graunke wrote: On Sunday, November 12, 2017 4:06:06 AM PST Lionel Landwerlin wrote: On 12/11/17 08:35, Kenneth Graunke wrote: This is a bit more annoying than your average shader - we need to look at MEDIA_INTERFACE_DESCRIPTOR_LOAD in the batch buffer, then hop over

Re: [Mesa-dev] [PATCH 09/11] intel/tools/error: Decode shaders while decoding batch commands.

On 13/11/17 22:59, Kenneth Graunke wrote: On Sunday, November 12, 2017 3:57:56 AM PST Lionel Landwerlin wrote: On 12/11/17 08:35, Kenneth Graunke wrote: This makes aubinator_error_decode's shader dumping work like aubinator. Instead of printing them after the fact, it prints them right inside

[Mesa-dev] [PATCH 2/2] radv: Free temporary syncobj after waiting on it.

Otherwise we leak it. Fixes: eaa56eab6da "radv: initial support for shared semaphores (v2)" --- src/amd/vulkan/radv_device.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index

[Mesa-dev] [PATCH 1/2] radv: Free syncobj with multiple imports.

Otherwise we can leak the old syncobj. Fixes: eaa56eab6da "radv: initial support for shared semaphores (v2)" --- src/amd/vulkan/radv_device.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index

Re: [Mesa-dev] [PATCH 4/4] i965: Use PTE MOCS for all external buffers

On Friday, November 3, 2017 4:17:34 PM PST Jason Ekstrand wrote: > We were already using PTE for all render targets in case one happened to > get scanned out. However, this still wasn't 100% correct because there > are still possibly cases where we may want to texture from an external > buffer

Re: [Mesa-dev] [PATCH v3 13/48] intel/fs: Use the original destination region for int MUL lowering

On Wed, Oct 25, 2017 at 4:25 PM, Jason Ekstrand wrote: > Some hardware (CHV, BXT) have special restrictions on register regions > when doing integer multiplication. We want to respect those when we > lower to DxW multiplication. This is not a good commit message. I am very

Re: [Mesa-dev] [PATCH 3/4] intel/blorp: Make the MOCS setting part of blorp_address

On Friday, November 3, 2017 4:17:33 PM PST Jason Ekstrand wrote: > This makes our MOCS settings significantly more flexible. > --- > src/intel/blorp/blorp.h | 7 +-- > src/intel/blorp/blorp_genX_exec.h | 16 +++ > src/intel/vulkan/anv_blorp.c

[Mesa-dev] [PATCH] i965/fs: Fix extract_i8/u8 to a 64-bit destination

The MOV instruction can extract bytes to words/double words, and words/double words to quadwords, but not byte to quadwords. For unsigned byte to quadword, we can read them as words and AND off the high byte and extract to quadword in one instruction. For signed bytes, we need to first sign

Re: [Mesa-dev] [RFC v5 12/19] intel/isl: Add ISL tiling -> modifier conversion

On Mon, Nov 6, 2017 at 2:02 PM, Louis-Francis Ratté-Boulianne < l...@collabora.com> wrote: > From: Daniel Stone > > Given a tiling mode and an aux usage, return the DRM modifier. > > Signed-off-by: Daniel Stone > --- > src/intel/isl/isl.h | 6

Re: [Mesa-dev] [PATCH] spirv: add DO NOT EDIT warning on generated spirv_info.c

On Monday, November 13, 2017 1:30:10 PM PST Alejandro Piñeiro wrote: > > On 13/11/17 20:04, Kenneth Graunke wrote: > > On Monday, November 13, 2017 2:16:59 AM PST Alejandro Piñeiro wrote: > >> --- > >> src/compiler/spirv/spirv_info_c.py | 5 - > >> 1 file changed, 4 insertions(+), 1

Re: [Mesa-dev] [PATCH 09/11] intel/tools/error: Decode shaders while decoding batch commands.

On Sunday, November 12, 2017 3:57:56 AM PST Lionel Landwerlin wrote: > On 12/11/17 08:35, Kenneth Graunke wrote: > > This makes aubinator_error_decode's shader dumping work like aubinator. > > Instead of printing them after the fact, it prints them right inside the > > 3DSTATE_VS/HS/DS/GS/PS

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

On Fri, Nov 10, 2017 at 12:39 PM, Jon Turney wrote: > On 10/11/2017 15:42, Nicolai Hähnle wrote: >> >> On 10.11.2017 14:00, Jon Turney wrote: >>> >>> On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. >>> >>> >>> I'm going to suggest that the

Re: [Mesa-dev] [PATCH 1/2] egl/haiku: Correct invalid void* conversion in calloc

On 2017-11-13 09:41, Brian Paul wrote: On 11/12/2017 02:53 PM, Alexander von Gluck IV wrote: --- src/egl/drivers/haiku/egl_haiku.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/haiku/egl_haiku.cpp b/src/egl/drivers/haiku/egl_haiku.cpp index

Re: [Mesa-dev] [RFC v5 11/19] vulkan/wsi: Add multiple planes to wsi_image_base

On Mon, Nov 6, 2017 at 2:02 PM, Louis-Francis Ratté-Boulianne < l...@collabora.com> wrote: > From: Daniel Stone > > Not currently used. > > Signed-off-by: Daniel Stone > --- > src/amd/vulkan/radv_wsi.c | 13 +++-- >

Re: [Mesa-dev] [RFC v5 10/19] vulkan/wsi: Rename needs_linear_copy to should_export

On Mon, Nov 6, 2017 at 2:02 PM, Louis-Francis Ratté-Boulianne < l...@collabora.com> wrote: > From: Daniel Stone > > The only use for this boolean was to decide whether or not it should > export a dmabuf FD. Simplify things a bit by giving that directly. > I'm not sure how

Re: [Mesa-dev] [PATCH 01/14] anv/cmd_buffer: Advance the address when initializing clear colors

On Mon, Nov 13, 2017 at 1:30 PM, Nanley Chery wrote: > On Mon, Nov 13, 2017 at 08:12:41AM -0800, Jason Ekstrand wrote: > > Found by inspection > > > > Good catch. > > > Cc: mesa-sta...@lists.freedesktop.org > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 9 ++--- > >

Re: [Mesa-dev] [PATCH 10/10] spirv: Generate SPIR-V builder infrastructure

Quoting Ian Romanick (2017-11-10 14:32:50) [snip] > + > +def can_have_extra_operands(name, enums): > +"""Determine whether an enum can have extra operands. > + > +Some enums, like SpvDecoration, can have extra operands with some values. > +Other enums, like SpvMemorySemantics, cannot.

Re: [Mesa-dev] [PATCH 09/10] spirv: Generate code to track SPIR-V capability dependencies

Quoting Ian Romanick (2017-11-13 13:34:15) > On 11/13/2017 10:49 AM, Dylan Baker wrote: > > Quoting Ian Romanick (2017-11-10 14:32:49) > > [snip] > > > >> + > >> +def collect_data(spirv): > >> +for x in spirv["operand_kinds"]: > >> +if x["kind"] == "Capability": > >> +

Re: [Mesa-dev] [PATCH 11/11] intel/tools/error: Decode compute shaders.

On Sunday, November 12, 2017 4:06:06 AM PST Lionel Landwerlin wrote: > On 12/11/17 08:35, Kenneth Graunke wrote: > > This is a bit more annoying than your average shader - we need to look > > at MEDIA_INTERFACE_DESCRIPTOR_LOAD in the batch buffer, then hop over > > to the dynamic state buffer to

Re: [Mesa-dev] [PATCH 03/10] spirv: Import the latest 1.0.12 header and JSON from Khronos

On 11/12/2017 02:53 PM, Eric Engestrom wrote: > On Friday, 2017-11-10 14:32:43 -0800, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> src/compiler/spirv/spirv.core.grammar.json | 417 >>

Re: [Mesa-dev] [PATCH 1/3] meson: don't use build_by_default for specific gallium drivers

Quoting Eric Anholt (2017-11-13 13:07:31) > Dylan Baker writes: > > > Using build_by_default : false is convenient for dependencies that can > > be pulled in by various diverse components of the build system, the > > gallium hardware/software drivers and state trackers do

Re: [Mesa-dev] [PATCH 09/10] spirv: Generate code to track SPIR-V capability dependencies

On 11/13/2017 10:49 AM, Dylan Baker wrote: > Quoting Ian Romanick (2017-11-10 14:32:49) > [snip] > >> + >> +def collect_data(spirv): >> +for x in spirv["operand_kinds"]: >> +if x["kind"] == "Capability": >> +operands = x > > This makes me nervous. dict iteration order is

Re: [Mesa-dev] [PATCH 01/14] anv/cmd_buffer: Advance the address when initializing clear colors

On Mon, Nov 13, 2017 at 08:12:41AM -0800, Jason Ekstrand wrote: > Found by inspection > Good catch. > Cc: mesa-sta...@lists.freedesktop.org > --- > src/intel/vulkan/genX_cmd_buffer.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] spirv: add DO NOT EDIT warning on generated spirv_info.c

On 13/11/17 20:04, Kenneth Graunke wrote: > On Monday, November 13, 2017 2:16:59 AM PST Alejandro Piñeiro wrote: >> --- >> src/compiler/spirv/spirv_info_c.py | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/src/compiler/spirv/spirv_info_c.py >>

Re: [Mesa-dev] [PATCH 2/2] i965: Only emit 3DSTATE_DRAWING_RECTANGLE once on gen9+

On Friday, November 3, 2017 3:31:42 PM PST Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_misc_state.c| 9 + > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 2 ++ > src/mesa/drivers/dri/i965/genX_state_upload.c | 4 ++-- > 3 files changed, 13 insertions(+), 2

Re: [Mesa-dev] [PATCH 07/18] intel/compiler: fix for memmove argument on annotating error

On Mon, Nov 13, 2017 at 1:12 PM, Rogovin, Kevin wrote: > Hi, > > > I confess I am not 100% on this code and I did educated guessing what it is > trying to do; I figured it was trying to insert contents at the current index > i; and that ann_count is the size -after-

Re: [Mesa-dev] [PATCH] spirv: add DO NOT EDIT warning on generated spirv_info.c

Hrm... I should probably add this to the generated files that I'm adding. On 11/13/2017 02:16 AM, Alejandro Piñeiro wrote: > --- > src/compiler/spirv/spirv_info_c.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/spirv/spirv_info_c.py >

Re: [Mesa-dev] [PATCH] mesa: replace GLenum with GLenum16 in common structures

On 11/08/2017 07:16 PM, Marek Olšák wrote: > From: Marek Olšák > > For lower CPU cache usage. All enums fit within 2 bytes. Have you benchmarked this on anything? My recollection is that for many things loads and stores of 16-bit values is more expensive than 8- or 32-bit

Re: [Mesa-dev] [PATCH v3 17/43] i965/fs: Enable rounding mode on f2f16 ops

On Mon, Nov 13, 2017 at 12:41 PM, Chema Casanova wrote: > On 30/10/17 23:40, Jason Ekstrand wrote: > > On Thu, Oct 12, 2017 at 11:38 AM, Jose Maria Casanova Crespo > > > wrote: > > > > From: Alejandro Piñeiro

Re: [Mesa-dev] [PATCH 08/18] intel/compiler:add function to give option to print offsets into assembly

I am fine with that suggestion of changing the function signature and to not add a new one; I wanted the changes I made to be as uninvasive as possible which is why I added the function instead of changing an existing one. -Kevin -Original Message- From: Matt Turner

Re: [Mesa-dev] [PATCH 07/18] intel/compiler: fix for memmove argument on annotating error

Hi, I confess I am not 100% on this code and I did educated guessing what it is trying to do; I figured it was trying to insert contents at the current index i; and that ann_count is the size -after- the insert. thus I figured the memmove is to move the half open interval [i, ann_count-1)

[Mesa-dev] [Bug 103658] addrlib/gfx9/gfx9addrlib.cpp:727:50: error: expected expression

https://bugs.freedesktop.org/show_bug.cgi?id=103658 Vinson Lee changed: What|Removed |Added CC||mar...@gmail.com,

Re: [Mesa-dev] [PATCH 1/3] meson: don't use build_by_default for specific gallium drivers

Dylan Baker writes: > Using build_by_default : false is convenient for dependencies that can > be pulled in by various diverse components of the build system, the > gallium hardware/software drivers and state trackers do not fit that > description. Instead, these should be

[Mesa-dev] [PATCH] virgl: also remove dimension on indirect.

From: Dave Airlie This fixes some dEQP tests that generated bad shaders. Fixes: b6f6ead19 (virgl: drop const dimensions on first block.) Signed-off-by: Dave Airlie --- src/gallium/drivers/virgl/virgl_tgsi.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [Mesa-dev] [PATCH v3 17/43] i965/fs: Enable rounding mode on f2f16 ops

On 30/10/17 23:40, Jason Ekstrand wrote: > On Thu, Oct 12, 2017 at 11:38 AM, Jose Maria Casanova Crespo > > wrote: > > From: Alejandro Piñeiro > > > By default we don't set the

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #13 from Vedran Miletić --- (In reply to Dave Gilbert from comment #6) > (In reply to Jan Vesely from comment #5) > > (In reply to Dave Gilbert from comment #4) > > > Created attachment 135313 [details] > > >

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #12 from Dave Gilbert --- (In reply to Jan Vesely from comment #11) > (In reply to Dave Gilbert from comment #10) > > I believe I'm still seeing this: > > > > dg@hath:~/ocl2$ clinfo > > Number of platforms

Re: [Mesa-dev] [PATCH 09/18] intel/tools/disasm: gen_disasm_disassemble to take const void* instead of void*

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 10/18] intel/tools/disasm: add gen_disasm_assembly_length function

Pending the questions about 07/18, I don't think this should be necessary. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 08/18] intel/compiler:add function to give option to print offsets into assembly

On Mon, Nov 13, 2017 at 5:17 AM, wrote: > From: Kevin Rogovin > > Signed-off-by: Kevin Rogovin > --- > src/intel/compiler/brw_eu.c | 11 ++- > src/intel/compiler/brw_eu.h | 3 +++ > 2 files changed, 13

Re: [Mesa-dev] [PATCH] r600: don't emit atomic save if we have no atomic counters.

Obviously, you can now disregard my other email about the performance regression, this fixes it.  Tested-By: Gert Wollny Best wishes, Am Freitag, den 10.11.2017, 13:47 +1000 schrieb Dave Airlie: > From: Dave Airlie > > Otherwise we end up emitting

[Mesa-dev] Performance regression, was [PATCH 09/10] r600: add support for hw atomic counters.

Hi Dave, since I'm currently experimenting with improving the performance of the tesselation shaders on r600, I notes that this series has a negative impact on performance, i.e. with the Unigine_Heaven benchmark I get a 10% lower frame rate that can be attributed to the newly added fence that is

[Mesa-dev] [PATCH 1/3] meson: don't use build_by_default for specific gallium drivers

Using build_by_default : false is convenient for dependencies that can be pulled in by various diverse components of the build system, the gallium hardware/software drivers and state trackers do not fit that description. Instead, these should be guarded using the variable that tracks whether that

[Mesa-dev] [PATCH 2/3] meson: Don't build intel shared components by default

It's a neat idea, and still useful in some cases, but the intel common code is used by i965 and anvil only, this is a little clearer. Signed-off-by: Dylan Baker --- src/intel/blorp/meson.build | 1 - src/intel/common/meson.build | 1 - src/intel/isl/meson.build| 3

[Mesa-dev] [PATCH 3/3] meson: Remove build_by_default from amd code

This is the same logic as the previous two patches. Signed-off-by: Dylan Baker --- src/amd/addrlib/meson.build | 1 - src/amd/common/meson.build | 1 - src/meson.build | 4 +++- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 11/18] intel/tools/disasm: make sure that entire range is disassembled

On Mon, Nov 13, 2017 at 5:17 AM, wrote: > From: Kevin Rogovin > > Without this patch, if a shader has errors, the disassembly of the > shader often stops after the first opcode that has errors. I can't see anything wrong with the current code.

Re: [Mesa-dev] [PATCH] spirv: add DO NOT EDIT warning on generated spirv_info.c

On Monday, November 13, 2017 2:16:59 AM PST Alejandro Piñeiro wrote: > --- > src/compiler/spirv/spirv_info_c.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/spirv/spirv_info_c.py > b/src/compiler/spirv/spirv_info_c.py > index c5e11dfc837..11235cfa3e4

Re: [Mesa-dev] [PATCH 07/18] intel/compiler: fix for memmove argument on annotating error

On Mon, Nov 13, 2017 at 5:17 AM, wrote: > From: Kevin Rogovin > > Without this fix, disassembling of GEN shaders with GPU commands > that the disassembler does not know would result in errors being > added to the annotator which would crash when

Re: [Mesa-dev] [PATCH 09/10] spirv: Generate code to track SPIR-V capability dependencies

Quoting Ian Romanick (2017-11-10 14:32:49) [snip] > + > +def collect_data(spirv): > +for x in spirv["operand_kinds"]: > +if x["kind"] == "Capability": > +operands = x This makes me nervous. dict iteration order is not guaranteed to be repeatable in python. I think you

Re: [Mesa-dev] [PATCH 1/2] meson: Stop requiring platforms for Vulkan

On 13 November 2017 at 17:37, Dylan Baker wrote: > I believe I copied this from autotools, does it have the same restriction? > It doesn't. Some ~1 ago I was under the assumption you need one (hence I sent a patch) but it got dropped. Likely you saw that one fly-by, pardon

Re: [Mesa-dev] [PATCH 1/2] meson: Stop requiring platforms for Vulkan

I can't either, so: Reviewed-by: Dylan Baker Quoting Jason Ekstrand (2017-11-13 09:43:11) > My quick attempt at grepping configure.ac didn't turn anything up. > > On Mon, Nov 13, 2017 at 9:37 AM, Dylan Baker wrote: > > I believe I copied this from

Re: [Mesa-dev] [PATCH 18/18] intel/tools: add command line GEN shader disassembler tool

On Monday, 2017-11-13 15:18:06 +0200, kevin.rogo...@intel.com wrote: > From: Kevin Rogovin > > Signed-off-by: Kevin Rogovin > --- > src/intel/Makefile.tools.am | 21 ++- > src/intel/tools/.gitignore| 1 + >

Re: [Mesa-dev] [PATCH 0/8] i965: add performance query support for Coffeelake

On Monday, November 13, 2017 6:58:28 AM PST Lionel Landwerlin wrote: > Hi, > > Although the main point of this series is to add performance queries > for Coffeelake. This series also brings the following : > > 1. Fix a number of Media/VME counters > 2. Rename some counter descriptions > 3.

Re: [Mesa-dev] [PATCH 1/5] egl: Provide meaningfull error when built w/o requested platform

On Monday, 2017-11-13 14:06:10 +, Emil Velikov wrote: > From: Emil Velikov > > The current "No EGL platform enabled." is misleading and wrong. > We reach said code when $platform is missing. > > To make this more obvious and clear provide wrappers in the header >

  1   2   3   >