[Mesa-dev] [PATCH 2/2] i965/tcs: support gl_PatchVerticesIn as a system value from SPIR-V

2017-11-15 Thread Iago Toral Quiroga
We currently handle this by lowering it to a uniform for gen8+ but the SPIR-V path generates this as a system value, so handle that case as well. --- src/mesa/drivers/dri/i965/brw_tcs.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_tcs.c

[Mesa-dev] [PATCH 1/2] nir/gather_info: recognize load_patch_vertices_in as a system value

2017-11-15 Thread Iago Toral Quiroga
This intrinsic is produced to load SYSTEM_VALUE_VERTICES_IN, which is generated to load gl_PatchVerticesIn in the SPIR-V path for both Vulkan and OpenGL. --- src/compiler/nir/nir_gather_info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_gather_info.c

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #11 from Tapani Pälli --- Created attachment 135512 --> https://bugs.freedesktop.org/attachment.cgi?id=135512=edit test case Could you please compile and run this test application and attach what is prints? Does

[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103757 --- Comment #10 from Pekka Paalanen --- (In reply to Michael Olbrich from comment #9) > (In reply to Pekka Paalanen from comment #1) > > Any reason you cannot use EGL_KHR_platform_wayland? > > It's not my code. It's

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #14 from Jan Vesely --- (In reply to Dave Gilbert from comment #12) > > It doesn't seem to help, if I add: > --- a/ocl.cpp > +++ b/ocl.cpp > @@ -74,6 +74,7 @@ static int got_dev(cl::Platform , > std::vector

Re: [Mesa-dev] [PATCH 1/4] meson: Enable SSE4.1 optimizations

2017-11-15 Thread Matt Turner
On Wed, Nov 15, 2017 at 5:10 PM, Dylan Baker wrote: > This patch checks for an and then enables sse4.1 optimizations if the > host machine will be x86/x86_64. There's some stack realignment stuff that probably needs to stay, but depending on what gcc version we require we

[Mesa-dev] [Bug 103128] [softpipe] piglit fs-ldexp regression

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103128 Nicolai Hähnle changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [Bug 103674] u_queue.c:173:7: error: implicit declaration of function 'timespec_get' is invalid in C99

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103674 Nicolai Hähnle changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 4/4] meson: Remove completed or irrelevant TODO comments

2017-11-15 Thread Dylan Baker
These are all either done already, or are autotools specific. The misspelled gallium G3DVL is the autotools specific bit, meson is handling that via build_by_default. Signed-off-by: Dylan Baker --- meson.build | 15 --- 1 file changed, 15 deletions(-) diff

[Mesa-dev] [PATCH 3/4] meson: Fix TODO for missing dl_iterate_phdr function

2017-11-15 Thread Dylan Baker
This function is required for both the Intel "Anvil" vulkan driver and the i965 GL driver. Error out if either of those is enabled but this function isn't found. Signed-off-by: Dylan Baker --- meson.build | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH 2/4] meson: disable x86 asm in fewer cases.

2017-11-15 Thread Dylan Baker
This patch allows building asm for x86 on x86_64 platforms, when the operating system is the same. Previously cross compile always turned off assembly. This allows using a cross file to cross compile x86 binaries on x86_64 with asm. This could probably be relaxed further thanks to meson's

[Mesa-dev] [PATCH 1/4] meson: Enable SSE4.1 optimizations

2017-11-15 Thread Dylan Baker
This patch checks for an and then enables sse4.1 optimizations if the host machine will be x86/x86_64. Signed-off-by: Dylan Baker --- meson.build | 27 ++- src/mesa/meson.build | 14 +++--- 2 files changed, 37 insertions(+), 4

Re: [Mesa-dev] [PATCH] st/glsl_to_nir: don't generate nir twice for gs

2017-11-15 Thread Dylan Baker
Quoting Timothy Arceri (2017-11-15 16:16:10) > This was left out of c980a3aa3133 > --- > src/mesa/state_tracker/st_program.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/state_tracker/st_program.c > b/src/mesa/state_tracker/st_program.c > index

[Mesa-dev] [PATCH] st/glsl_to_nir: don't generate nir twice for gs

2017-11-15 Thread Timothy Arceri
This was left out of c980a3aa3133 --- src/mesa/state_tracker/st_program.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index 97b2e1234b..dc81a17289 100644 ---

[Mesa-dev] [PATCH] util: add new ASSERT_BITFIELD_SIZE() macro (v2)

2017-11-15 Thread Brian Paul
For checking that bitfields are large enough to hold the largest expected value. v2: move into existing util/macros.h header where STATIC_ASSERT() lives. --- src/util/macros.h | 16 1 file changed, 16 insertions(+) diff --git a/src/util/macros.h b/src/util/macros.h index

Re: [Mesa-dev] Driver testing system for Steam games

2017-11-15 Thread Karen Ghavam
Folks, If you have feedback or questions, you can mail them to i...@lunarg.com Karen Ghavam CEO and Engineering Director LunarG, Inc. - 3D Graphics Software Innovations ka...@lunarg.com 970-988-9043 On Wed, Nov 15, 2017 at 1:32 PM, Pierre-Loup A. Griffais < pgriff...@valvesoftware.com> wrote:

Re: [Mesa-dev] [PATCH 02/24] mesa: add gl_shader::SpirVBinary and getter

2017-11-15 Thread Timothy Arceri
On 16/11/17 00:22, Eduardo Lima Mitev wrote: From: Nicolai Hähnle --- src/mesa/main/mtypes.h| 1 + src/mesa/main/shaderapi.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 1c953b83155..cfc763f043e

[Mesa-dev] [Bug 103412] gallium/wgl: Another fix to context creation without prior SetPixelFormat()

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103412 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH 2/2] util: fix compatibility of timespec_get() across OSes

2017-11-15 Thread George Kyriazis
while timespec_get() is supposed to hide OS differences, compatibility doesn't cover old OSes (like CentOS 6) where timespec_get() does not exist. Fall back to using os_get_time_nano(), but separate out the functionality that populates struct timespec, so it can also be called from

Re: [Mesa-dev] [PATCH 17/24] mesa/main: Add a 'spirv' flag to gl_shader_program_data

2017-11-15 Thread Timothy Arceri
On 16/11/17 00:22, Eduardo Lima Mitev wrote: This will be used by the linker code to dfferentiate between programs made out of SPIR-V or GLSL shaders. So far everywhere this is used it seems you could just do something like: if (shProg->_LinkedShaders[stage]->spirv_data) ... spriv stuff

Re: [Mesa-dev] [PATCH v2] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-15 Thread kallisti5
On 2017-11-15 08:35, Nicolai Hähnle wrote: From: Nicolai Hähnle v2: add HAVE_TIMESPEC_GET for non-Windows Scons builds Cc: Jon Turney Cc: Rob Herring Cc: Alexander von Gluck IV Bugzilla:

[Mesa-dev] [PATCH] radv: get rid of another api bypass in the wsi code.

2017-11-15 Thread Dave Airlie
From: Dave Airlie This just uses the vulkan api to get the fd from the memory. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_wsi.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_wsi.c

Re: [Mesa-dev] [PATCH v2] mesa/teximage: add TEXTURE_CUBE_MAP_ARRAY target for CompressedTexImage3D

2017-11-15 Thread Ilia Mirkin
On Wed, Nov 15, 2017 at 5:49 PM, Nanley Chery wrote: > On Wed, Nov 15, 2017 at 12:08:58PM -0500, Ilia Mirkin wrote: >> On Wed, Nov 15, 2017 at 11:54 AM, Juan A. Suarez Romero >> wrote: >> > From section 8.7, page 179 of OpenGL ES 3.2 spec: >> > >> >

[Mesa-dev] [PATCH] radv/wsi: don't use a helper for blit, just call copy image.

2017-11-15 Thread Dave Airlie
From: Dave Airlie We ignore layout currently, not sure what would be correct to pass. (this is based on Jason's last wsi rfc) Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta.h | 4 src/amd/vulkan/radv_meta_copy.c | 20

Re: [Mesa-dev] [PATCH v2] mesa/teximage: add TEXTURE_CUBE_MAP_ARRAY target for CompressedTexImage3D

2017-11-15 Thread Nanley Chery
On Wed, Nov 15, 2017 at 12:08:58PM -0500, Ilia Mirkin wrote: > On Wed, Nov 15, 2017 at 11:54 AM, Juan A. Suarez Romero > wrote: > > From section 8.7, page 179 of OpenGL ES 3.2 spec: > > > > An INVALID_OPERATION error is generated by CompressedTexImage3D > > if

[Mesa-dev] [PATCH] vulkan/wsi: use function ptr definitions from the spec.

2017-11-15 Thread Dave Airlie
From: Dave Airlie This just seems cleaner, and we may expand this in future. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_wsi.c | 3 ++- src/intel/vulkan/anv_wsi.c | 3 ++- src/vulkan/wsi/wsi_common.h | 4 +---

Re: [Mesa-dev] [PATCH 3/3] RFC: vulkan/wsi: Rework the way prime support works

2017-11-15 Thread Dave Airlie
On 15 November 2017 at 04:40, Jason Ekstrand wrote: > This commit significantly reworks the way prime support works and lets > us pull it even further into radv. The old mechanism required the > specific WSI layer to be aware of the linear shadow copy that has to be > done

Re: [Mesa-dev] [PATCH v2 4/5] etnaviv: Flush TS cache before changing TS configuration

2017-11-15 Thread Christian Gmeiner
2017-11-14 10:21 GMT+01:00 Wladimir J. van der Laan : > This is to make sure that the TS is properly flushed to memory before > rendering to a new surface starts. > > Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner

Re: [Mesa-dev] [PATCH v2 3/5] etnaviv: Add TS_SAMPLER formats to etnaviv_format

2017-11-15 Thread Christian Gmeiner
2017-11-14 10:21 GMT+01:00 Wladimir J. van der Laan : > Sampler TS introduces yet another format enumeration for > renderable+textureable formats. Introduce it into the etnaviv_format > table as another column. > > Signed-off-by: Wladimir J. van der Laan

Re: [Mesa-dev] [PATCH v2 2/5] etnaviv: Check that resource has a valid TS in etna_resource_needs_flush

2017-11-15 Thread Christian Gmeiner
2017-11-14 10:21 GMT+01:00 Wladimir J. van der Laan : > Resources only need a resolve-to-itself if their TS is valid for any > level, not just if it happens to be allocated. > > Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner

[Mesa-dev] [Bug 100151] Front buffer drawing mode shows black window with gallium software rasterizers

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100151 --- Comment #12 from Pradeep Yadav --- As I mentioned while filing this defect that Mesa's classic software rasterizer has no such black window issue. So we have potential temporary solution for our customers who are

Re: [Mesa-dev] [PATCH v3] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-15 Thread Eric Engestrom
On Wednesday, 2017-11-15 20:59:18 +, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Tested with Travis and Appveyor. > > v2: add HAVE_TIMESPEC_GET for non-Windows Scons builds > v3: use check_functions in Scons (Eric) > > Cc: Rob Herring > Cc:

[Mesa-dev] [PATCH] i965: Listen to BRW_NEW_*_PROGRAM in L3 state atom.

2017-11-15 Thread Kenneth Graunke
This looks at prog->*. You don't get to do that unless you listen to BRW_NEW_*_PROGRAM, which is a superset of the cases where BRW_NEW_*_PROG_DATA is flagged. --- src/mesa/drivers/dri/i965/gen7_l3_state.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v3] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-15 Thread Dylan Baker
This should make scons work correctly on every platform, so: Reviewed-by: Dylan Baker Quoting Nicolai Hähnle (2017-11-15 12:58:12) > From: Nicolai Hähnle > > Tested with Travis and Appveyor. > > v2: add HAVE_TIMESPEC_GET for non-Windows Scons

Re: [Mesa-dev] [PATCH mesa 2/2] egl: drop EGL driver `name`

2017-11-15 Thread Eric Engestrom
On Wednesday, 2017-11-15 16:51:29 +, Kai Wasserbäch wrote: > I'm still good with this, thanks for reapplying! To be clear, is that an ack, or an r-b? :P > > Eric Engestrom wrote on 14.11.2017 18:26: > > This is a revert of Marek's 2cb9ab53dd3ae6850a26 revert. > > It was needed to revert the

[Mesa-dev] [PATCH v3] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-15 Thread Nicolai Hähnle
From: Nicolai Hähnle Tested with Travis and Appveyor. v2: add HAVE_TIMESPEC_GET for non-Windows Scons builds v3: use check_functions in Scons (Eric) Cc: Rob Herring Cc: Alexander von Gluck IV Bugzilla:

[Mesa-dev] Driver testing system for Steam games

2017-11-15 Thread Pierre-Loup A. Griffais
Hi Mesa-Devel, Today we're happy to announce that we're making the LunarG driver testing system available to the Mesa development community. We've been using this system internally for quite some time, but we've recently done some more work so the results could also be publicly available for the

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Dylan Baker
Quoting Ilia Mirkin (2017-11-15 09:52:06) > On Wed, Nov 15, 2017 at 12:47 PM, Dylan Baker wrote: > > Nope. meson builds all C++ code as C++11 because so much of mesa's C++ code > > cannot be built without it (Because of LLVM). As far as I can tell the GLSL > > compiler and

Re: [Mesa-dev] [PATCH] tgsi/exec: fix LDEXP in softpipe

2017-11-15 Thread Brian Paul
Reviewed-by: Brian Paul On 11/15/2017 11:35 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle Bugzilla:

Re: [Mesa-dev] [PATCH 02/13] i965: remove ARB_compute_shader extension override

2017-11-15 Thread Emil Velikov
On 15 November 2017 at 19:30, Jordan Justen wrote: > On 2017-11-14 07:37:27, Emil Velikov wrote: >> On 10 November 2017 at 23:39, Jordan Justen >> wrote: >> > On 2017-11-10 08:19:38, Emil Velikov wrote: >> >> On 7 November 2017 at 11:54,

Re: [Mesa-dev] [PATCH 02/13] i965: remove ARB_compute_shader extension override

2017-11-15 Thread Jordan Justen
On 2017-11-14 07:37:27, Emil Velikov wrote: > On 10 November 2017 at 23:39, Jordan Justen wrote: > > On 2017-11-10 08:19:38, Emil Velikov wrote: > >> On 7 November 2017 at 11:54, Emil Velikov wrote: > >> > From: Emil Velikov

Re: [Mesa-dev] [ANNOUNCE] mesa 17.3.0-rc4

2017-11-15 Thread Andres Gomez
On Tue, 2017-11-14 at 11:28 -0800, Matt Turner wrote: > On Tue, Nov 14, 2017 at 6:37 AM, Emil Velikov > wrote: > > The fourth release candidate for Mesa 17.3.0 is now available. > > > > As per the issue tracker [1] we still have a number of outstanding bugs > >

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

2017-11-15 Thread Wladimir J. van der Laan
> Sorry for noticing before, but this breaks glmark2 texture. I didn't > yet dig into the issue but it's definitely caused by this commit. > > To reproduce, simply run > glmark2-es2-drm -b texture:texture-filter=mipmap That's weird, as that neither uses point sprites nor flat shading. I'll have

Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

2017-11-15 Thread Eric Anholt
"Mun, Gwan-gyeong" writes: > Hi all, > > I am sorry that I didn't have enough discussion about why new window > system code is needed for Tizen on mesa. > > This is a brief architecture of Tizen Window System. > > >

Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

2017-11-15 Thread Lucas Stach
Hi Wladimir, Am Mittwoch, den 15.11.2017, 18:03 +0100 schrieb Wladimir J. van der Laan: > A recent commit (see below) fixed flat shading but at the same time > broke the use of point sprites with multiple varyings. This resulted in > particle systems rendering wrongly. > > The reason for this is

[Mesa-dev] [Bug 103128] [softpipe] piglit fs-ldexp regression

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103128 --- Comment #2 from Nicolai Hähnle --- https://patchwork.freedesktop.org/patch/188544/ fixes this for me. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] tgsi/exec: fix LDEXP in softpipe

2017-11-15 Thread Nicolai Hähnle
From: Nicolai Hähnle Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103128 Fixes: cad959d90145 ("gallium: add LDEXP TGSI instruction and corresponding cap") --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH v2] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-15 Thread Jon Turney
On 15/11/2017 14:35, Nicolai Hähnle wrote: From: Nicolai Hähnle v2: add HAVE_TIMESPEC_GET for non-Windows Scons builds Cc: Jon Turney Cc: Rob Herring Cc: Alexander von Gluck IV Bugzilla:

Re: [Mesa-dev] [PATCH v2] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-15 Thread Dylan Baker
Quoting Nicolai Hähnle (2017-11-15 06:35:49) > From: Nicolai Hähnle > > v2: add HAVE_TIMESPEC_GET for non-Windows Scons builds > > Cc: Jon Turney > Cc: Rob Herring > Cc: Alexander von Gluck IV >

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Ilia Mirkin
On Wed, Nov 15, 2017 at 12:47 PM, Dylan Baker wrote: > Nope. meson builds all C++ code as C++11 because so much of mesa's C++ code > cannot be built without it (Because of LLVM). As far as I can tell the GLSL > compiler and the Intel Compiler are the only C++ code in mesa not

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Nicolai Hähnle
On 15.11.2017 17:45, Kai Wasserbäch wrote: Doesn't the meson.build file need the same change? I don't really know Meson, but the master build file looks to me like Meson always builds with C++11. Cheers, Nicolai Nicolai Hähnle wrote on 15.11.2017 12:55: From: Nicolai Hähnle

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Dylan Baker
Nope. meson builds all C++ code as C++11 because so much of mesa's C++ code cannot be built without it (Because of LLVM). As far as I can tell the GLSL compiler and the Intel Compiler are the only C++ code in mesa not using C++11. Quoting Kai Wasserbäch (2017-11-15 08:45:30) > Doesn't the

Re: [Mesa-dev] [PATCH] meson: Don't define HAVE_PTHREAD only on linux

2017-11-15 Thread Dylan Baker
Quoting Jon Turney (2017-11-15 02:52:29) > I'm not sure of the reason for this. I don't see anything like this in > configure.ac I hadn't had a chance to test other platforms, and I wasn't sure about Windows and Haiku. Some of the BSD's also stiil use pthread-stubs, and I don't think those get

Re: [Mesa-dev] [PATCH] meson: Add dridriverdir variable to dri.pc.

2017-11-15 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Rafael Antognolli (2017-11-15 09:32:47) > Xorg (and possibly other things) depend on this variable to find the > path to DRI drivers. > > Signed-off-by: Rafael Antognolli > Cc: Dylan Baker

[Mesa-dev] [PATCH] meson: Add dridriverdir variable to dri.pc.

2017-11-15 Thread Rafael Antognolli
Xorg (and possibly other things) depend on this variable to find the path to DRI drivers. Signed-off-by: Rafael Antognolli Cc: Dylan Baker --- src/mesa/drivers/dri/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH] meson: Don't define HAVE_PTHREAD only on linux

2017-11-15 Thread Eric Engestrom
On Wednesday, 2017-11-15 10:52:29 +, Jon Turney wrote: > I'm not sure of the reason for this. I don't see anything like this in > configure.ac > > In include/c11/threads.h the cases are: > > 1) building for Windows -> threads_win32.h > 2) HAVE_PTHREAD -> threads_posix.h > 3) Not supported on

Re: [Mesa-dev] [PATCH v2] mesa/teximage: add TEXTURE_CUBE_MAP_ARRAY target for CompressedTexImage3D

2017-11-15 Thread Ilia Mirkin
On Wed, Nov 15, 2017 at 11:54 AM, Juan A. Suarez Romero wrote: > From section 8.7, page 179 of OpenGL ES 3.2 spec: > > An INVALID_OPERATION error is generated by CompressedTexImage3D > if internalformat is one of the the formats in table 8.17 and target > is not

[Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

2017-11-15 Thread Wladimir J. van der Laan
A recent commit (see below) fixed flat shading but at the same time broke the use of point sprites with multiple varyings. This resulted in particle systems rendering wrongly. The reason for this is that it set VARYING_COMPONENT_USE_POINTCOORD_[XY] for all non-color varyings, causing them to be

[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103757 --- Comment #9 from Michael Olbrich --- (In reply to Pekka Paalanen from comment #1) > Any reason you cannot use EGL_KHR_platform_wayland? It's not my code. It's somewhere in gstreamer-vaapi. I was just debugging why

[Mesa-dev] [PATCH v2] mesa/teximage: add TEXTURE_CUBE_MAP_ARRAY target for CompressedTexImage3D

2017-11-15 Thread Juan A. Suarez Romero
From section 8.7, page 179 of OpenGL ES 3.2 spec: An INVALID_OPERATION error is generated by CompressedTexImage3D if internalformat is one of the the formats in table 8.17 and target is not TEXTURE_2D_ARRAY, TEXTURE_CUBE_MAP_ARRAY or TEXTURE_3D. An INVALID_OPERATION error is generated by

[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103757 --- Comment #8 from Michael Olbrich --- (In reply to Daniel Stone from comment #7) > Good point - I guess it'd have to be if > (_eglPointerIsDereferencable(child_pointer) && > _eglPointerIsDereferencable(((char *)

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Kai Wasserbäch
Doesn't the meson.build file need the same change? Nicolai Hähnle wrote on 15.11.2017 12:55: > From: Nicolai Hähnle > > It is required for LLVM anyway. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103658 > Fixes: 7f33e94e43a6 ("amd/addrlib: update to

Re: [Mesa-dev] [PATCH mesa 2/2] egl: drop EGL driver `name`

2017-11-15 Thread Kai Wasserbäch
I'm still good with this, thanks for reapplying! Eric Engestrom wrote on 14.11.2017 18:26: > This is a revert of Marek's 2cb9ab53dd3ae6850a26 revert. > It was needed to revert the previous commit, and didn't have any issue > itself. > -- > > The "DRI2" name was reported as confusing when

Re: [Mesa-dev] [PATCH] mesa/teximage: add more targets for CompressedTexImage3D

2017-11-15 Thread Juan A. Suarez Romero
On Tue, 2017-11-14 at 16:57 -0800, Nanley Chery wrote: > On Wed, Nov 08, 2017 at 04:52:02PM +0100, Juan A. Suarez Romero wrote: > > From section 8.7, page 179 of OpenGL ES 3.2 spec: > > > > An INVALID_OPERATION error is generated by CompressedTexImage3D > > if internalformat is one of the the

Re: [Mesa-dev] Has anyone stressed radeonsi memory?

2017-11-15 Thread Kai Wasserbäch
Hey Matias, Matias N. Goldberg wrote on 15.11.2017 16:51: >> Why, doesn't your distro have LLVM development packages? > They aren't as up to date. Keeping up-to-date with everything mesa needs is > exhausting. > I started compiling LLVM from source when I needed to test an LLVM patch to > fix a

[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103757 --- Comment #7 from Daniel Stone --- (In reply to Michael Olbrich from comment #6) > (In reply to Daniel Stone from comment #2) > > > Michael, I'll attach a compiled but untested patch; can you please let me > > know if

[Mesa-dev] [PATCH] etnaviv: enable full overwrite when no color buffer is present

2017-11-15 Thread Lucas Stach
The OVERWRITE bit disables destination fetches, which is exactly what we want when there is no valid color buffer bound. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_blend.c | 4 ++-- src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +- 2 files

[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103757 --- Comment #6 from Michael Olbrich --- (In reply to Daniel Stone from comment #2) > Michael, I'll attach a compiled but untested patch; can you please let me > know if it helps? Looks good. It does the right thing

[Mesa-dev] Fwd: [Mesa-users] Thank you! Keep up the good work for older AMD Cards!

2017-11-15 Thread Brian Paul
FYI: Original Message Subject:[Mesa-users] Thank you! Keep up the good work for older AMD Cards! Date: Wed, 15 Nov 2017 13:56:22 +0100 From: Thomas Zoller To: mesa-us...@lists.freedesktop.org Hello, i only want to say THANK YOU to

Re: [Mesa-dev] [PATCH v2 3/5] etnaviv: Add TS_SAMPLER formats to etnaviv_format

2017-11-15 Thread Lucas Stach
Am Dienstag, den 14.11.2017, 10:21 +0100 schrieb Wladimir J. van der Laan: > Sampler TS introduces yet another format enumeration for > renderable+textureable formats. Introduce it into the etnaviv_format > table as another column. > > Signed-off-by: Wladimir J. van der Laan

Re: [Mesa-dev] Has anyone stressed radeonsi memory?

2017-11-15 Thread Matias N. Goldberg
Hi! > Are you using the amdgpu kernel driver from an amdgpu-pro release or > from the upstream Linux kernel? (If you're not sure, provide the dmesg > output and Xorg log file) > If the latter, can you try a 4.13 or 4.14 kernel and see if that works > better? I'm using upstream Linux kernel

Re: [Mesa-dev] [PATCH v2 2/5] etnaviv: Check that resource has a valid TS in etna_resource_needs_flush

2017-11-15 Thread Lucas Stach
Am Dienstag, den 14.11.2017, 10:21 +0100 schrieb Wladimir J. van der Laan: > Resources only need a resolve-to-itself if their TS is valid for any > level, not just if it happens to be allocated. > > Signed-off-by: Wladimir J. van der Laan Reviewed-by: Lucas Stach

Re: [Mesa-dev] [PATCH v2 4/5] etnaviv: Flush TS cache before changing TS configuration

2017-11-15 Thread Lucas Stach
Am Dienstag, den 14.11.2017, 10:21 +0100 schrieb Wladimir J. van der Laan: > This is to make sure that the TS is properly flushed to memory before > rendering to a new surface starts. > > Signed-off-by: Wladimir J. van der Laan This seems to work as intended, at least I wasn't

[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103757 --- Comment #5 from Daniel Stone --- (In reply to Emil Velikov from comment #4) > > I do recall mentioning that exposing the same symbol(s) will lead to bad > experiences. Followed by some ideas... > Yep, as per the

[Mesa-dev] [PATCH] egl/wayland: add dri2_wl_free_buffers() helper (v3)

2017-11-15 Thread Gwan-gyeong Mun
This deduplicates free routines of color_buffers array. v2: - Add clear_all argument to check clearing all of color_buffers or not. - Fixes from Eric's review: a) polish check routine of check_lock and color_buffers[i].locked b) move 'native_buffer = NULL' to avoid leaking locked buffers

[Mesa-dev] [PATCH] egl: add dri2_surface_free_image() helper (v4)

2017-11-15 Thread Gwan-gyeong Mun
To share common free DRIimage code. In preparation to adding of new platform which uses this helper. v2: - Fixes from Eric's review: a) Split out series of refactor for helpers to a separate series. b) Add the new helper function and use them to replace the old code in the same

[Mesa-dev] [PATCH] egl: refactor color_buffers structure for deduplicating (v2)

2017-11-15 Thread Gwan-gyeong Mun
This is added for preventing adding of new color buffers structure and back* when new platform backend is added. This refactoring separates out the common and platform specific bits. This makes odd casting in the platform_foo.c but it prevents adding of new ifdef magic. Because of color_buffers

[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103757 --- Comment #4 from Emil Velikov --- I do recall mentioning that exposing the same symbol(s) will lead to bad experiences. Followed by some ideas... WRT eglGetDisplay - I'd recommend moving towards the

Re: [Mesa-dev] [PATCH v2] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-15 Thread Eric Engestrom
On Wednesday, 2017-11-15 15:35:49 +0100, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > v2: add HAVE_TIMESPEC_GET for non-Windows Scons builds > > Cc: Jon Turney > Cc: Rob Herring > Cc: Alexander von Gluck IV

[Mesa-dev] [PATCH 3/4] radv: do not add the image BO in radv_set_depth_clear_regs()

2017-11-15 Thread Samuel Pitoiset
For the fast path, radv_fill_buffer() ensures that the BO is already in the list. For the slow path, the depth surface is part of the framebuffer which means the BO is added to the list when the framebuffer is emitted. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH 4/4] radv: only load needed depth clear regs for fast depth clears

2017-11-15 Thread Samuel Pitoiset
Similar to how the driver sets the depth clear regs after a fast depth clear. Most of the time, this will copy a 32-bit reg instead of a 64-bit reg. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 14 -- 1 file changed, 12

[Mesa-dev] [PATCH 2/4] radv: remove useless assertion in emit_depthstencil_clear()

2017-11-15 Thread Samuel Pitoiset
Already checked in emit_clear(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_clear.c | 4 1 file changed, 4 deletions(-) diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index 7b6ab4a9b7..b42ecedfc9 100644 ---

[Mesa-dev] [PATCH 1/4] radv: remove useless check in radv_set_depth_clear_regs()

2017-11-15 Thread Samuel Pitoiset
aspects can't be zero and there is an assertion that ensures it's not in emit_clear(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH] radv: inline radv_upload_{compute, graphics}_shader_descriptors()

2017-11-15 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 18503cd513..146dcf439f 100644 ---

[Mesa-dev] [PATCH v2] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-15 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: add HAVE_TIMESPEC_GET for non-Windows Scons builds Cc: Jon Turney Cc: Rob Herring Cc: Alexander von Gluck IV Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103674

[Mesa-dev] [Bug 103732] swr often gets stuck in piglit's glx-multi-context-single-window test

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103732 --- Comment #5 from Michel Dänzer --- (In reply to Andrés Gómez García from comment #4) > FWIW, with similar conditions, I've not been able to reproduce with > llvmpipe, softpipe nor i965. Hmm, then maybe it is related to

[Mesa-dev] [Bug 103762] [swr] piglit ext_transform_feedback-immediate-reuse-uniform-buffer has a ~5% pass rate

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103762 Andrés Gómez García changed: What|Removed |Added See Also|

[Mesa-dev] [Bug 90081] [llvmpipe] piglit ext_transform_feedback-immediate-reuse-uniform-buffer regression

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90081 Andrés Gómez García changed: What|Removed |Added See Also|

[Mesa-dev] [Bug 103762] [swr] piglit ext_transform_feedback-immediate-reuse-uniform-buffer has a ~5% pass rate

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103762 Bug ID: 103762 Summary: [swr] piglit ext_transform_feedback-immediate-reuse-uniform-buffer has a ~5% pass rate Product: Mesa Version: 17.2 Hardware:

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #10 from Tapani Pälli --- (In reply to sergio.callegari from comment #9) > Tried right now. Incidentally, I have always been working with SNA, since it > is fine on haswell and snappier than glamor. > > I still

Re: [Mesa-dev] [PATCH 11/24] spirv_extensions: add list of extensions and to_string method

2017-11-15 Thread Eric Engestrom
On Wednesday, 2017-11-15 14:22:14 +0100, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > Ideally this should be generated somehow. One option would be gather > all the extension dependencies listed on the core grammar, but there > would be the possibility of not

Re: [Mesa-dev] [PATCH 10/24] spirv_extensions: add GL_ARB_spirv_extensions boilerplate

2017-11-15 Thread Eric Engestrom
On Wednesday, 2017-11-15 14:22:13 +0100, Eduardo Lima Mitev wrote: > From: Alejandro Piñeiro > > --- > src/mapi/glapi/gen/ARB_spirv_extensions.xml | 13 > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API.xml | 2 ++ >

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #9 from sergio.calleg...@gmail.com --- Tried right now. Incidentally, I have always been working with SNA, since it is fine on haswell and snappier than glamor. I still see the issue with mesa as of 17.4 git snapshot taken on

Re: [Mesa-dev] Difference between Meson and autotools release builds

2017-11-15 Thread Eric Engestrom
On Wednesday, 2017-11-15 13:17:25 +, Rogovin, Kevin wrote: > Thanks, I missed that; sorry for the mailing list chatter caused by > missing the original e-mail on the material. No worries, there's a lot of traffic, I'm pretty sure nobody read every single emails of these lists :P > -Kevin >

Re: [Mesa-dev] [PATCH 01/24] mesa: add GL_ARB_gl_spirv boilerplate

2017-11-15 Thread Eric Engestrom
On Wednesday, 2017-11-15 14:22:04 +0100, Eduardo Lima Mitev wrote: > From: Nicolai Hähnle > > --- > src/mapi/glapi/gen/ARB_gl_spirv.xml | 21 ++ > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API.xml | 4 +++ >

[Mesa-dev] [Bug 103732] swr often gets stuck in piglit's glx-multi-context-single-window test

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103732 --- Comment #4 from Andrés Gómez García --- FWIW, with similar conditions, I've not been able to reproduce with llvmpipe, softpipe nor i965. -- You are receiving this mail because: You are the assignee for the bug. You are

[Mesa-dev] [Bug 103128] [softpipe] piglit fs-ldexp regression

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103128 --- Comment #1 from Nicolai Hähnle --- I can reproduce this, will take a look now. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 102122] [softpipe] piglit fdo10370 regression

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102122 --- Comment #1 from Nicolai Hähnle --- I cannot reproduce this on Mesa master by running: $ GALLIUM_DRIVER=softpipe LIBGL_ALWAYS_SOFTWARE=true ./bin/fdo10370 -auto What am I missing? -- You are receiving this mail

[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103757 --- Comment #3 from Daniel Stone --- Created attachment 135490 --> https://bugs.freedesktop.org/attachment.cgi?id=135490=edit egldisplay-try-interface-name-for-wl-display.patch -- You are receiving this mail because:

[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103757 --- Comment #2 from Daniel Stone --- (In reply to Pekka Paalanen from comment #1) > eglGetDisplay() is by definition broken on multi-platform implementations, > yes. Ugh. It is broken by definition, but Mesa does go to

  1   2   >