[Mesa-dev] [PATCH 23/24] i965: Call spirv_to_nir() instead of glsl_to_nir() for SPIR-V shaders

2017-11-15 Thread Eduardo Lima Mitev
This is the main fork of the shader compilation code-path, where a NIR shader is obtained by calling spirv_to_nir() or glsl_to_nir(), depending on its nature.. --- src/mesa/drivers/dri/i965/brw_program.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 24/24] i965: Don't call process_glsl_ir() for SPIR-V shaders

2017-11-15 Thread Eduardo Lima Mitev
--- src/mesa/drivers/dri/i965/brw_link.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/dri/i965/brw_link.cpp index 24545d52ecb..ca75180f5b0 100644 --- a/src/mesa/drivers/dri/i965/brw_link.cpp +++

[Mesa-dev] [PATCH 15/24] nir/spirv: add gl_spirv_validation method

2017-11-15 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 "Shader Specialization", error table: INVALID_VALUE is generated if does not name a valid entry point for .

[Mesa-dev] [PATCH 20/24] mesa: Add a reference to gl_shader_spirv_data to gl_linked_shader

2017-11-15 Thread Eduardo Lima Mitev
This is a reference to the spirv_data object stored in gl_shader, which stores shader SPIR-V data that is needed during linking too. --- src/mesa/main/mtypes.h| 8 src/mesa/main/shaderobj.c | 1 + 2 files changed, 9 insertions(+) diff --git a/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 16/24] mesa: Implement glSpecializeShaderARB

2017-11-15 Thread Eduardo Lima Mitev
From: Nicolai Hähnle v2: use gl_spirv_validation instead of spirv_to_nir. This method just validates the shader. The conversion to NIR will happen later, during linking. (Alejandro Piñeiro) v3: Use gl_shader_spirv_data struct to store the SPIR-V data. (Eduardo

[Mesa-dev] [PATCH 18/24] mesa/glspirv: Add a _mesa_spirv_link_shaders() placeholder

2017-11-15 Thread Eduardo Lima Mitev
This will be the equivalent to link_shaders() from src/compiler/glsl/linker.cpp, but for SPIR-V programs. --- src/mesa/main/glspirv.c | 10 ++ src/mesa/main/glspirv.h | 4 2 files changed, 14 insertions(+) diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c index

[Mesa-dev] [PATCH 17/24] mesa/main: Add a 'spirv' flag to gl_shader_program_data

2017-11-15 Thread Eduardo Lima Mitev
This will be used by the linker code to dfferentiate between programs made out of SPIR-V or GLSL shaders. --- src/mesa/main/mtypes.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index d624f2cbd19..db9c2e1deaa 100644 ---

[Mesa-dev] [PATCH 21/24] mesa/glspirv: Create gl_linked_shader objects for a SPIR-V program

2017-11-15 Thread Eduardo Lima Mitev
--- src/mesa/main/glspirv.c | 51 ++--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c index 86f1d221cc9..9332764f152 100644 --- a/src/mesa/main/glspirv.c +++ b/src/mesa/main/glspirv.c @@

[Mesa-dev] [PATCH 19/24] mesa/program: Link SPIR-V shaders using the SPIR-V code-path

2017-11-15 Thread Eduardo Lima Mitev
--- src/mesa/program/ir_to_mesa.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index ddc1705097d..5bbb55e1407 100644 --- a/src/mesa/program/ir_to_mesa.cpp +++ b/src/mesa/program/ir_to_mesa.cpp @@

[Mesa-dev] [PATCH 22/24] mesa/glspirv: Add a _mesa_spirv_to_nir() function

2017-11-15 Thread Eduardo Lima Mitev
This is basically a wrapper around spirv_to_nir() that includes arguments setup and post-conversion validation. --- src/mesa/main/glspirv.c | 60 + src/mesa/main/glspirv.h | 7 ++ 2 files changed, 67 insertions(+) diff --git

[Mesa-dev] [PATCH 08/24] mesa: add gl_constants::SpirVCapabilities

2017-11-15 Thread Eduardo Lima Mitev
From: Nicolai Hähnle For drivers to declare which SPIR-V features they support. --- src/mesa/main/mtypes.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index f19477eb027..bf7c4ddc051 100644 ---

[Mesa-dev] [PATCH 14/24] spirv_extensions: i965: initialize SPIR-V extensions

2017-11-15 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro --- src/mesa/drivers/dri/i965/brw_context.c | 6 ++ src/mesa/main/context.c | 1 + 2 files changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index

[Mesa-dev] [PATCH 11/24] spirv_extensions: add list of extensions and to_string method

2017-11-15 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro Ideally this should be generated somehow. One option would be gather all the extension dependencies listed on the core grammar, but there would be the possibility of not including some of the extensions. Note that spirv-tools is doing it just

[Mesa-dev] [PATCH 10/24] spirv_extensions: add GL_ARB_spirv_extensions boilerplate

2017-11-15 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro --- src/mapi/glapi/gen/ARB_spirv_extensions.xml | 13 src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 2 ++ src/mesa/Makefile.sources | 2 ++

[Mesa-dev] [PATCH 09/24] i965: initialize SPIR-V capabilities

2017-11-15 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro Needed for ARB_gl_spirv. Right now those are the same that the intel vulkan driver, but those are not shared. From the ARB_spirv_extensions spec: "3. If a new GL extension is added that includes SPIR-V support via a new SPIR-V extension does

[Mesa-dev] [PATCH 13/24] spirv_extensions: add spirv_supported_extensions on gl_constants

2017-11-15 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro We can use it to get real values for ARB_spirv_extensions methods. --- src/mesa/main/mtypes.h | 3 +++ src/mesa/main/spirvextensions.c | 20 +++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 12/24] spirv_extensions: define spirv_extensions_supported

2017-11-15 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro Add a struct to maintain which SPIR-V extensions are supported, and an utility method to initialize it based on nir_spirv_supported_capabilities. --- src/compiler/spirv/spirv_extensions.c | 29 +

[Mesa-dev] [PATCH 07/24] spirv_extensions: rename nir_spirv_supported_extensions

2017-11-15 Thread Eduardo Lima Mitev
From: Alejandro Piñeiro Renamed to nir_spirv_supported_capabilities. The original name seemed to suggest that it was directly related to the SPIR-V extensions supported, but that is not the case. For example, float64 was supported on SPIR-V 1.0 core, without the need of

[Mesa-dev] [PATCH 06/24] mesa: implement SPIR-V loading in glShaderBinary

2017-11-15 Thread Eduardo Lima Mitev
From: Nicolai Hähnle v2: Add a gl_shader_spirv_data member to gl_shader, which already encapsulates a gl_spirv_module where the binary will be saved. (Eduardo Lima) --- src/mesa/main/glspirv.c | 52 +++

[Mesa-dev] [PATCH 05/24] mesa/glspirv: Add struct gl_shader_spirv_data

2017-11-15 Thread Eduardo Lima Mitev
This is a per-shader structure holding the SPIR-V data associated with the shader (binary module, specialization constants and entry-point). This is needed because both gl_shader and gl_linked_shader need to share this data. Instead of copying the data, we pass a reference to it upon program

[Mesa-dev] [PATCH 04/24] mesa/glspirv: Add struct gl_spirv_module

2017-11-15 Thread Eduardo Lima Mitev
From: Nicolai Hähnle v2: Make the SPIR-V module struct part of a larger gl_shader_spirv_data struct that will be introduced later, and don't reference it directly in gl_shader. (Eduardo Lima) --- src/mesa/main/glspirv.c | 19 +++

[Mesa-dev] [PATCH 03/24] mesa: refuse to compile SPIR-V shaders or link mixed shaders

2017-11-15 Thread Eduardo Lima Mitev
From: Nicolai Hähnle Note that gl_shader::CompileStatus will also indicate whether a shader has been successfully specialized. --- src/mesa/main/shaderapi.c | 12 src/mesa/program/ir_to_mesa.cpp | 17 - 2 files changed, 28

[Mesa-dev] [PATCH 02/24] mesa: add gl_shader::SpirVBinary and getter

2017-11-15 Thread Eduardo Lima Mitev
From: Nicolai Hähnle --- src/mesa/main/mtypes.h| 1 + src/mesa/main/shaderapi.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 1c953b83155..cfc763f043e 100644 --- a/src/mesa/main/mtypes.h +++

[Mesa-dev] [PATCH 00/24] Initial gl_spirv and spirv_extensions support in Mesa and i965

2017-11-15 Thread Eduardo Lima Mitev
Hello, This series is the first chunk of our on-going work to support GL_ARB_gl_spirv [1] and GL_ARB_spirv_extensions [2] in Mesa and i965. It adds API entry-points, API error checking, most of driver-agnostic setup and housekeeping, and a few basic i965 bits. It is based off initial work that

[Mesa-dev] [PATCH 01/24] mesa: add GL_ARB_gl_spirv boilerplate

2017-11-15 Thread Eduardo Lima Mitev
From: Nicolai Hähnle --- src/mapi/glapi/gen/ARB_gl_spirv.xml | 21 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 4 +++ src/mapi/glapi/gen/gl_genexec.py| 1 + src/mesa/Makefile.sources

Re: [Mesa-dev] Difference between Meson and autotools release builds

2017-11-15 Thread Rogovin, Kevin
Thanks, I missed that; sorry for the mailing list chatter caused by missing the original e-mail on the material. -Kevin -Original Message- From: Eric Engestrom [mailto:eric.engest...@imgtec.com] Sent: Wednesday, November 15, 2017 1:39 PM To: Rogovin, Kevin Cc:

Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

2017-11-15 Thread Mun, Gwan-gyeong
2017-11-15 19:32 GMT+09:00 Nicolai Hähnle : > Not sure if it's just my client, but all the nice ASCII art got messed up > unfortunately :/ > > On 14.11.2017 21:21, Mun, Gwan-gyeong wrote: >> >> >>

[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103757 --- Comment #1 from Pekka Paalanen --- eglGetDisplay() is by definition broken on multi-platform implementations, yes. Any reason you cannot use EGL_KHR_platform_wayland? -- You are receiving this mail because: You are

Re: [Mesa-dev] Difference between Meson and autotools release builds

2017-11-15 Thread Rogovin, Kevin
Just to clarify, I do not mean just the defaults, but doing -buildtype release also leaves assert()'s active (atleast on my system setup). -Kevin From: Rogovin, Kevin Sent: Wednesday, November 15, 2017 11:44 AM To: mesa-dev@lists.freedesktop.org Subject: Difference between Meson and autotools

Re: [Mesa-dev] [AppVeyor] mesa master #6163 failed

2017-11-15 Thread Eric Engestrom
On Wednesday, 2017-11-15 10:35:04 +, Jose Fonseca wrote: > I could post a remark on AppVeyor's forums, but it sounds from the > logs the issue could be on our (freedesktop.org's) side. > > > I've reconfigured AppVeyor to use > https://anongit.freedesktop.org/git/mesa/mesa.git/ instead of >

Re: [Mesa-dev] [PATCH] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-15 Thread Nicolai Hähnle
Well, looks like the Scons build *also* needs to be adjusted... I'll try my luck with a v2 later. On 15.11.2017 12:54, Nicolai Hähnle wrote: From: Nicolai Hähnle Cc: Jon Turney Cc: Rob Herring Cc: Alexander von Gluck IV

[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103757 Bug ID: 103757 Summary: eglGetDisplay() is broken for Wayland Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Nicolai Hähnle
From: Nicolai Hähnle It is required for LLVM anyway. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103658 Fixes: 7f33e94e43a6 ("amd/addrlib: update to latest version") --- src/amd/Makefile.addrlib.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-15 Thread Nicolai Hähnle
From: Nicolai Hähnle Cc: Jon Turney Cc: Rob Herring Cc: Alexander von Gluck IV Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103674 Fixes: f1a364878431 ("threads: update for late C11

[Mesa-dev] [Bug 103658] addrlib/gfx9/gfx9addrlib.cpp:727:50: error: expected expression

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103658 --- Comment #3 from Nicolai Hähnle --- Created attachment 135484 --> https://bugs.freedesktop.org/attachment.cgi?id=135484=edit build addrlib with C++11 Does the attached patch help? -- You are receiving this mail

[Mesa-dev] [PATCH v2 1/3] radeonsi: add nir support for ls epilogue

2017-11-15 Thread Timothy Arceri
v2: make use of existing si_tgsi_emit_epilogue() --- src/gallium/drivers/radeonsi/si_shader.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index

[Mesa-dev] [PATCH v2 3/3] radeonsi: add nir support for gs epilogue

2017-11-15 Thread Timothy Arceri
v2: add emit_gs_epilogue() helper function to reduce duplication. --- src/gallium/drivers/radeonsi/si_shader.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index

[Mesa-dev] [PATCH v2 2/3] radeonsi: add nir support for es epilogue

2017-11-15 Thread Timothy Arceri
v2: make use of existing si_tgsi_emit_epilogue() --- src/gallium/drivers/radeonsi/si_shader.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index

Re: [Mesa-dev] Difference between Meson and autotools release builds

2017-11-15 Thread Eric Engestrom
On Wednesday, 2017-11-15 09:43:59 +, Rogovin, Kevin wrote: > Hi, > > I do not know if anyone has noticed or if it is deliberate, but the meson > builds have that assert()'s are active but the autotools release builds have > that assert() is inactive. Hi, Yep, this is by design, meson

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-15 Thread Nicolai Hähnle
On 15.11.2017 12:30, Jon Turney wrote: On 15/11/2017 11:21, Nicolai Hähnle wrote: On 13.11.2017 23:55, Rob Herring wrote: On Fri, Nov 10, 2017 at 12:39 PM, Jon Turney wrote: On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-15 Thread Jon Turney
On 15/11/2017 11:21, Nicolai Hähnle wrote: On 13.11.2017 23:55, Rob Herring wrote: On Fri, Nov 10, 2017 at 12:39 PM, Jon Turney wrote: On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote:

Re: [Mesa-dev] [PATCH 17/20] ac: add si_nir_load_input_gs() to the abi

2017-11-15 Thread Timothy Arceri
On 15/11/17 22:17, Nicolai Hähnle wrote: On 15.11.2017 12:09, Timothy Arceri wrote: On 15/11/17 21:56, Nicolai Hähnle wrote: On 10.11.2017 04:13, Timothy Arceri wrote: ---   src/amd/common/ac_nir_to_llvm.c   | 24 -   src/amd/common/ac_shader_abi.h   

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-15 Thread Nicolai Hähnle
On 13.11.2017 23:55, Rob Herring wrote: On Fri, Nov 10, 2017 at 12:39 PM, Jon Turney wrote: On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm going to

Re: [Mesa-dev] [PATCH 17/20] ac: add si_nir_load_input_gs() to the abi

2017-11-15 Thread Nicolai Hähnle
On 15.11.2017 12:09, Timothy Arceri wrote: On 15/11/17 21:56, Nicolai Hähnle wrote: On 10.11.2017 04:13, Timothy Arceri wrote: ---   src/amd/common/ac_nir_to_llvm.c   | 24 -   src/amd/common/ac_shader_abi.h    |  7 ++  

Re: [Mesa-dev] [PATCH 2/2] ac/nir: don't write tcs outputs to LDS that aren't read back.

2017-11-15 Thread Nicolai Hähnle
On 14.11.2017 06:18, Dave Airlie wrote: From: Dave Airlie If the TCS doesn't read back the outputs, no need to store them to LDS in the first place. (except for tess factors). This seems to give about 50fps (3290->3330) with tessellation demo. I haven't tested if it

Re: [Mesa-dev] Initial GS NIR support for radeonsi

2017-11-15 Thread Timothy Arceri
On 15/11/17 22:06, Nicolai Hähnle wrote: On 10.11.2017 04:13, Timothy Arceri wrote: The support is still WIP but the patches as starting to pile up so thought I'd see if I could land these before continuing. Thanks for working on this! Whats missing? Vega support for gs_vtx_offset

Re: [Mesa-dev] [PATCH 1/2] nir: fill outputs_read field and add patch outputs read

2017-11-15 Thread Nicolai Hähnle
On 14.11.2017 06:18, Dave Airlie wrote: From: Dave Airlie This is to be used for TCS optimisations on radv. --- src/compiler/nir/nir_gather_info.c | 29 ++--- src/compiler/shader_info.h | 2 ++ 2 files changed, 24 insertions(+), 7

Re: [Mesa-dev] [PATCH 17/20] ac: add si_nir_load_input_gs() to the abi

2017-11-15 Thread Timothy Arceri
On 15/11/17 21:56, Nicolai Hähnle wrote: On 10.11.2017 04:13, Timothy Arceri wrote: ---   src/amd/common/ac_nir_to_llvm.c   | 24 -   src/amd/common/ac_shader_abi.h    |  7 ++   src/gallium/drivers/radeonsi/si_shader.c  |  1 +  

[Mesa-dev] [PATCH] radv: use a 16 bytes array for the sampled/storage image descriptors

2017-11-15 Thread Samuel Pitoiset
This allows to update them with only one memcpy(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_descriptor_set.c | 9 + src/amd/vulkan/radv_image.c | 5 + src/amd/vulkan/radv_private.h| 6 ++ 3 files changed, 8 insertions(+),

Re: [Mesa-dev] Initial GS NIR support for radeonsi

2017-11-15 Thread Nicolai Hähnle
On 10.11.2017 04:13, Timothy Arceri wrote: The support is still WIP but the patches as starting to pile up so thought I'd see if I could land these before continuing. Thanks for working on this! Whats missing? Vega support for gs_vtx_offset handling (see patch 3), I don't have one yet for

Re: [Mesa-dev] [PATCH 01/20] st/glsl_to_nir: disable io type lowering for stages other than vs and fs

2017-11-15 Thread Timothy Arceri
On 15/11/17 21:39, Nicolai Hähnle wrote: On 10.11.2017 04:13, Timothy Arceri wrote: This is too simple and breaks gs and I'm not sure its required there anyway. Can you add an example for what breaks? It breaks because it removes the outer array on gs inputs. I have an updated series which

[Mesa-dev] [PATCH] meson: Don't define HAVE_PTHREAD only on linux

2017-11-15 Thread Jon Turney
I'm not sure of the reason for this. I don't see anything like this in configure.ac In include/c11/threads.h the cases are: 1) building for Windows -> threads_win32.h 2) HAVE_PTHREAD -> threads_posix.h 3) Not supported on this platform So not defining HAVE_PTHREAD for anything not Windows just

Re: [Mesa-dev] [PATCH 17/20] ac: add si_nir_load_input_gs() to the abi

2017-11-15 Thread Nicolai Hähnle
On 10.11.2017 04:13, Timothy Arceri wrote: --- src/amd/common/ac_nir_to_llvm.c | 24 - src/amd/common/ac_shader_abi.h| 7 ++ src/gallium/drivers/radeonsi/si_shader.c | 1 +

Re: [Mesa-dev] r600 evergreen+ shader image support

2017-11-15 Thread Gert Wollny
Am Mittwoch, den 15.11.2017, 10:11 +1000 schrieb Dave Airlie: > > It's not 100% on piglits, but it's quite close, and better than fglrx > does, so I'd probably prefer to land it before doing too much more > destructive hacking on it! I ran the piglits shader set on barts - no regressions, and

Re: [Mesa-dev] [PATCH 01/20] st/glsl_to_nir: disable io type lowering for stages other than vs and fs

2017-11-15 Thread Nicolai Hähnle
On 10.11.2017 04:13, Timothy Arceri wrote: This is too simple and breaks gs and I'm not sure its required there anyway. Can you add an example for what breaks? Thanks, Nicolai --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [AppVeyor] mesa master #6163 failed

2017-11-15 Thread Jose Fonseca
I could post a remark on AppVeyor's forums, but it sounds from the logs the issue could be on our (freedesktop.org's) side. I've reconfigured AppVeyor to use https://anongit.freedesktop.org/git/mesa/mesa.git/ instead of git://anongit.freedesktop.org/mesa/mesa . Perhaps fewer things can go

Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

2017-11-15 Thread Nicolai Hähnle
Not sure if it's just my client, but all the nice ASCII art got messed up unfortunately :/ On 14.11.2017 21:21, Mun, Gwan-gyeong wrote: +--+ | [Tizen Window

Re: [Mesa-dev] [PATCH 03/14] intel/blorp/blit: Rename blorp_nir_txf_ms_mcs

2017-11-15 Thread Lionel Landwerlin
I thought I sent a Rb on this one... Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radeonsi/gfx9: fix VM fault with fetched instance divisors

2017-11-15 Thread Nicolai Hähnle
From: Nicolai Hähnle We need to account for SGPR locations in merged shaders. This case is exercised by KHR-GL45.enhanced_layouts.vertex_attrib_locations Fixes: 79c2e7388c7f ("radeonsi/gfx9: use SPI_SHADER_USER_DATA_COMMON") ---

Re: [Mesa-dev] [PATCH] mapi: Use correct shared library name on macOS.

2017-11-15 Thread Eric Engestrom
On Tuesday, 2017-11-14 17:57:38 -0800, Dylan Baker wrote: > I think "suffix" would be better for the title "name". Also, library -> > libraries. > > With that changed: > Reviewed-by: Dylan Baker Reviewed-by: Eric Engestrom > > Quoting Vinson

[Mesa-dev] [PATCH] radv: do not add the query pool BO to the list in vkCmdEndQuery()

2017-11-15 Thread Samuel Pitoiset
As per the spec, the query identified by queryPool and query must currently be active. Applications have to call vkCmdBeginQuery() before, and thus the query pool BO will already be in the list. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_query.c | 4 +++-

[Mesa-dev] Difference between Meson and autotools release builds

2017-11-15 Thread Rogovin, Kevin
Hi, I do not know if anyone has noticed or if it is deliberate, but the meson builds have that assert()'s are active but the autotools release builds have that assert() is inactive. -Kevin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [RFC PATCH 1/6] r600:shader: Fix all warnings issed with "-Wall -Wextra"

2017-11-15 Thread Gert Wollny
- fix a number of -Wsign-compare warnings - fix two warnings for -Woverride-init because TGSI_OPCODE_CEIL == 83, and the according field was defined two times. Signed-off-by: Gert Wollny --- src/gallium/drivers/r600/r600_shader.c | 67 ++

[Mesa-dev] [RFC PATCH 5/6] r600_shader.c: Pre-caclculate some offsets for LDS access

2017-11-15 Thread Gert Wollny
Some offsets used for the LDS access are recalculated quite regularly. Since tesselation shaders are not optimized by the SB manually pre-evaluate some offsets to speed up this type of shader. Signed-off-by: Gert Wollny --- src/gallium/drivers/r600/r600_shader.c | 253

[Mesa-dev] [RFC PATCH 2/6] r600_shader: only load from LDS what is really used

2017-11-15 Thread Gert Wollny
Use the destination write mask to determine which values are really to be read from LDS and load only these. Signed-off-by: Gert Wollny --- src/gallium/drivers/r600/r600_shader.c | 33 ++--- 1 file changed, 26 insertions(+), 7 deletions(-) diff

[Mesa-dev] [RFC PATCH 4/6] r600_shader: Move calculation of offset to do_lds_fetch_values

2017-11-15 Thread Gert Wollny
Instead of calculating creating the code for calculating a base offset and then to caclucate the component offfsets, calculate this offset for all components directly. This saves one instruction group. Signed-off-by: Gert Wollny --- src/gallium/drivers/r600/r600_shader.c |

[Mesa-dev] [RFC PATCH 0/6] r600: speed up tesselation shaders

2017-11-15 Thread Gert Wollny
Dear all, since on r600 the tesselation shaders don't go through the sb-optimizer I though it might help to improve performance by applying some optimizations to the created assembly. The patches are experimental but to a point where I think some input from you could be helpful. This patch

[Mesa-dev] [RFC PATCH 6/6] r600_shader.c: Preload some LDS values.

2017-11-15 Thread Gert Wollny
Pre-load all the LDS values who's range is accessed more than once. Signed-off-by: Gert Wollny --- src/gallium/drivers/r600/r600_shader.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/gallium/drivers/r600/r600_shader.c

[Mesa-dev] [RFC PATCH 3/6] r600_shader.c: Add a caching structure for load tesselation data

2017-11-15 Thread Gert Wollny
Cache values that are loaded more then once, or where various components are loaded at separate places. This saves repeated calculation of the offsets. Signed-off-by: Gert Wollny --- src/gallium/drivers/r600/r600_shader.c | 211 + 1 file

[Mesa-dev] [Bug 103128] [softpipe] piglit fs-ldexp regression

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103128 Vinson Lee changed: What|Removed |Added Blocks||103491 Referenced

[Mesa-dev] [Bug 102122] [softpipe] piglit fdo10370 regression

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102122 Vinson Lee changed: What|Removed |Added Blocks||103491 Referenced

Re: [Mesa-dev] [PATCH] r600: fix cubemap arrays

2017-11-15 Thread Marc Dietrich
Hi Dave, Am Dienstag, 14. November 2017, 23:28:38 CET schrieb Dave Airlie: > From: Dave Airlie > > A lot of cubemap array piglits fail, port the texture type > picking code from radeonsi which seems to fix most of them. > > For images I will port the rest of the code. > >

Re: [Mesa-dev] [PATCH] r600: shader CF_OP_VTX also doesn't use the EOP bit.

2017-11-15 Thread Gert Wollny
Am Mittwoch, den 15.11.2017, 11:28 +1000 schrieb Dave Airlie: > > I'll likely apply this as well at some point, that test however hangs > my cayman with or without my patch (and your patch doesn't do > anything on cayman). BTW: valgrind showed that there was some problem in sb in the parser

[Mesa-dev] [AppVeyor] mesa master #6164 completed

2017-11-15 Thread AppVeyor
Build mesa 6164 completed Commit 059d25a06d by Samuel Pitoiset on 11/14/2017 4:27 PM: radv: add the vertex buffers BO to the list at bind time\n\nThis should reduce the overhead of adding a BO to the current\nlist, especially when the list is huge. Also, when

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

2017-11-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103699 --- Comment #8 from Tapani Pälli --- (also please try again with latest mesa) -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 07/18] intel/compiler: fix for memmove argument on annotating error

2017-11-15 Thread Rogovin, Kevin
I have just seen that I have had an epic brain lapse on this. The code is pretty clear, the correct value of count should be ann_count - i. This is because: a. The value of ann_count is the value of the array size BEFORE the insert; this is clear from the code within the if (offset + ..)

<    1   2