Re: [Mesa-dev] [PATCH 1/2] vulkan: move anv VK_EXT_debug_report implementation to common code.

This LGTM. You are taking away the instance constructor/destructor callback but it wasn't used anyway so that's fine. If someone needs it, it can be added later. Reviewed-by: Tapani Pälli On 01/09/2018 04:04 PM, Bas Nieuwenhuizen wrote: For also using it in radv. I

[Mesa-dev] [PATCH] anv: Import mako templates only during execution of anv_extensions

anv_extensions usage from anv_icd was bringing the unwanted dependency of mako templates for the latter. We don't want that since it will force the dependency even for distributable tarballs which was not needed until now. Jason suggested this approach. Bugzilla:

Re: [Mesa-dev] [PATCH] glsl/linker: link-error using the same name in unnamed block and outside

On 01/08/2018 03:19 PM, Juan A. Suarez Romero wrote: Please, could someone take a look at this patch? Thanks in advance. This looks correct to me. Is there some dEQP/Piglit test for this situation? J.A. On Mon, 2017-12-04 at 17:35 +0100, Juan A. Suarez Romero wrote: According

[Mesa-dev] [PATCH 1/2] amd/common: import get_{load, store}_intr_attribs() from RadeonSI

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c| 12 ++- src/amd/common/ac_llvm_util.c | 18 src/amd/common/ac_llvm_util.h | 6 ++

[Mesa-dev] [PATCH 2/2] amd/common: use ac_build_buffer_load() for emitting UBO loads

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 932d648082..5885c70ef8 100644 ---

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #30 from Evangelos Foutras --- (In reply to Thomas Hellström from comment #29) > Created attachment 136647 [details] [review] > Updated patch to avoid freeing renderbuffers currently in use Seems to fix my

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO

https://bugs.freedesktop.org/show_bug.cgi?id=104553 --- Comment #6 from Ilia Mirkin --- (In reply to florian.will from comment #5) > I now have a patch that works for all the 270 random UBO test cases > generated using Ian Romanick's useful script (and also my own simple

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO

https://bugs.freedesktop.org/show_bug.cgi?id=104553 --- Comment #5 from florian.w...@googlemail.com --- Created attachment 136648 --> https://bugs.freedesktop.org/attachment.cgi?id=136648=edit Proposed patch, needs more testing I now have a patch that works for all the 270 random UBO test

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

On 01/10/2018 11:45 AM, Bas Nieuwenhuizen wrote: On Wed, Jan 10, 2018 at 11:16 AM, Samuel Pitoiset wrote: On 01/10/2018 03:34 AM, Bas Nieuwenhuizen wrote: Tested with a modified deferred demo and no regressions in a 1.0.2 mustpass run. ---

Re: [Mesa-dev] [PATCH v2 2/3] android, configure, meson: define HAVE_ZLIB

On Wednesday, 2018-01-10 00:58:33 +0200, Grazvydas Ignotas wrote: > The next change wants to use some optional zlib functionality, however > not all platforms currently use it. Based on earlier Jordan Justen's > patches and their review feedback. > > Signed-off-by: Grazvydas Ignotas

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

On Wed, Jan 10, 2018 at 11:16 AM, Samuel Pitoiset wrote: > > > On 01/10/2018 03:34 AM, Bas Nieuwenhuizen wrote: >> >> Tested with a modified deferred demo and no regressions in a 1.0.2 >> mustpass run. >> --- >> src/amd/vulkan/radv_cmd_buffer.c | 51 >>

Re: [Mesa-dev] [PATCH] util: fix NORETURN for msvc, add HAVE_FUNC_ATTRIBUTE_NORETURN to c99_compat.h

On 10/01/18 02:15, srol...@vmware.com wrote: From: Roland Scheidegger We've seen some problems internally due to macro redefinition. Fix this by adding HAVE_FUNC_ATTRIBUTE_NORETURN to c99_compat.h, and defining it for msvc. And avoid redefinition just in case. ---

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 Thomas Hellström changed: What|Removed |Added Attachment #136645|0 |1 is

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #28 from Thomas Hellström --- (In reply to Evangelos Foutras from comment #27) > I'm totally unfamiliar with gpu driver code but I'm wondering why the > "buf->pixmap == ie->pixmap" check isn't used anymore;

Re: [Mesa-dev] [PATCH] amd/common: bump the number of available user SGPRS to 32 on GFX9

Reviewed-by: Bas Nieuwenhuizen On Mon, Jan 8, 2018 at 3:21 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [Mesa-dev] r600 sb tessellation support

Am Mittwoch, den 10.01.2018, 16:48 +1000 schrieb Dave Airlie: > This is an attempt to add tessellation support to the SB backend. > > The main things needed are GDS access which is used for tess > factor storage (also used for atomic counters), and LDS access > which is needed to pass all the

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #27 from Evangelos Foutras --- (In reply to Thomas Hellström from comment #25) > Created attachment 136645 [details] [review] > Patch to fix a potential problem with renderbuffer freeing Doesn't fix it for

Re: [Mesa-dev] [PATCH] r600: Allow egd_tables.py to run with python3 too

On středa 10. ledna 2018 3:49:43 CET Dave Airlie wrote: > On 5 January 2018 at 01:14, Michal Srb wrote: > > From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Chv=C3=A1tal?= > > > > Makes the egd_tables.py compatible with both python 2 and 3. > > This appears to break the

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_EXT_discard_rectangles.

On 01/10/2018 03:34 AM, Bas Nieuwenhuizen wrote: Tested with a modified deferred demo and no regressions in a 1.0.2 mustpass run. --- src/amd/vulkan/radv_cmd_buffer.c | 51 +++ src/amd/vulkan/radv_device.c | 6 +

[Mesa-dev] [PATCH] r600/sb: Add a NOP/EOP if the shader is optimized away completely

sb might optimize away a shader completely which results in a segfault, since in this case last_cf is NULL. Signed-off-by: Gert Wollny --- src/gallium/drivers/r600/sb/sb_bc_finalize.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] ac: add load_patch_vertices_in() to the abi

Reviewed-by: Samuel Pitoiset On 01/10/2018 07:28 AM, Timothy Arceri wrote: Fixes the follow test for radeonsi nir: tests/spec/arb_tessellation_shader/execution/quads.shader_test Also stops 8 other tests from crashing, they now just fail e.g.

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #26 from Evangelos Foutras --- Any Mesa devs trying to repro this, please test with display compositing disabled. I posted some possibly useful printf output in [1]. I'm not sure if

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #25 from Thomas Hellström --- Created attachment 136645 --> https://bugs.freedesktop.org/attachment.cgi?id=136645=edit Patch to fix a potential problem with renderbuffer freeing There is a potential problem

[Mesa-dev] [PATCH] anv: fix maxDescriptorSet* limits

"The maxDescriptorSet* limit is n times the corresponding maxPerStageDescriptor* limit, where n is the number of shader stages supported by the VkPhysicalDevice. If all shader stages are supported, n = 6 (vertex, tessellation control, tessellation evaluation, geometry, fragment, compute)." Fixes:

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

Hi Christian, >> Otherwise I'm going to give it a few more days on the list and push it if nobody objects. Gentle ping ? So far the series are: Acked-by: Leo Liu Reviewed-by: Julien Isorce Thx Julien On 30 November 2017 at 14:05,

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO

https://bugs.freedesktop.org/show_bug.cgi?id=104553 --- Comment #4 from florian.w...@googlemail.com --- I used the generated_tests/random_ubo-arb_uniform_buffer_object.py script and it generated 270 tests, and initially they all passed. That's because the tests only verify matrix values using the

Re: [Mesa-dev] [PATCH] i915g: fix crashes with wined3d

Am 10.01.2018 01:03 schrieb "Ilia Mirkin" : On Tue, Jan 9, 2018 at 5:40 PM, Christopher Egert wrote: > I'm not too familiar with gallium3d, but this fixes > crashes with 3DMark2001 and GTA3 in wine-staging. > > This should be fixed properly in the future.

Re: [Mesa-dev] [RFC 04/10] glsl: add function to create unique string from shader program

On 01/09/2018 04:30 PM, Eric Engestrom wrote: On Tuesday, 2018-01-09 09:48:16 +0200, Tapani Pälli wrote: Patch moves existing functionality from shader_cache_read_program_metadata to a helper function. Signed-off-by: Tapani Pälli --- src/compiler/Makefile.sources

<    1   2