Re: [Mesa-dev] [PATCH 2/2] Replace deperacated include header "cutils/log.h" to "log/log.h" from Android 8

2018-04-26 Thread Tapani Pälli
LGTM Reviewed-by: Tapani Pälli On 04/27/2018 05:11 AM, jenny.q.cao wrote: There is a compile warning from Android 8 (API version 26) from "include cutils/log.h" warning: "Deprecated: don't include cutils/log.h, use either android/log.h or log/log.h"-W#warnings, Change to include "log/log.h"

[Mesa-dev] [PATCH] mesa: add TBO support for GL_EXT_texture_norm16

2018-04-26 Thread Tapani Pälli
Earlier plumbing missed interaction with texture buffer objects. Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" Signed-off-by: Tapani Pälli --- src/mesa/main/teximage.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/me

Re: [Mesa-dev] [PATCH] ac/nir: set lod to 0 when it's unused

2018-04-26 Thread Marek Olšák
Ignore that. Nicolai's point is correct. Marek On Fri, Apr 27, 2018 at 1:51 AM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Thu, Apr 26, 2018 at 6:17 AM, Samuel Pitoiset < > samuel.pitoi...@gmail.com> wrote: > >> Otherwise we hit an assertion in ac_build_image_opcode() >> fo

Re: [Mesa-dev] [PATCH] ac/nir: set lod to 0 when it's unused

2018-04-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Apr 26, 2018 at 6:17 AM, Samuel Pitoiset wrote: > Otherwise we hit an assertion in ac_build_image_opcode() > for ac_image_load_mip. > > Fixes: 24fb3e6aa16 ("ac/nir: use ac_build_image_opcode for image > intrinsics") > Cc: 18.1 > Signed-off-by: Samuel Pit

[Mesa-dev] [Bug 104928] libglvnd_1.0.0 disables amdgpu direct rendering

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104928 --- Comment #5 from Jose P. --- Just in case someone comes from Google looking for "(EE) AMDGPU(0): eglGetDisplay() failed, followed by (EE) AMDGPU(0): glamor detected, failed to initialize EGL.", "AMDGPU(0): 2D and 3D acceleration disabled" or

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Tomasz Figa
Hi Rob, On Fri, Apr 27, 2018 at 12:43 PM Chih-Wei Huang wrote: > 2018-04-27 2:19 GMT+08:00 Robert Foss : > > > > I've spent some time today preparing a #ifdef version of what robher > > submitted. > > > > It's fine, but there is no way automatically enable the HAVE_DRM_GRALLOC > > #define through

Re: [Mesa-dev] [PATCH 1/1] main: return 0 length when the queried program object's not linked

2018-04-26 Thread Timothy Arceri
Reviewed-by: Timothy Arceri It would also be nice to have a piglit test for this case. I assume mesa probably crashes without this patch? On 27/04/18 11:39, James Xiong wrote: From: "Xiong, James" Signed-off-by: Xiong, James --- src/mesa/main/shaderapi.c | 2 +- 1 file changed, 1 inser

[Mesa-dev] [PATCH 2/2] Replace deperacated include header "cutils/log.h" to "log/log.h" from Android 8

2018-04-26 Thread jenny.q.cao
There is a compile warning from Android 8 (API version 26) from "include cutils/log.h" warning: "Deprecated: don't include cutils/log.h, use either android/log.h or log/log.h"-W#warnings, Change to include "log/log.h" on Android 8 or later major version to avoid this warning Tests: compilation

[Mesa-dev] [PATCH 1/2] Update for fix or ignore the compile warning on android

2018-04-26 Thread jenny.q.cao
force cast the I to GLint to avoid the compile warning when type is GLenum16, in vendor/intel/external/mesa3d-intel/src/mesa/main/get.c:3005:19: warning: comparison of constant -32768 with expression of type 'GLenum16' (aka 'unsigned short') is always false -Wtautologicalia-constant-out-of-range-

Re: [Mesa-dev] [PATCH 1/7] ac/surface: handle DCC subresource fast clear restriction on VI

2018-04-26 Thread Marek Olšák
Ping. Thanks. On Tue, Apr 24, 2018 at 3:56 PM, Marek Olšák wrote: > From: Marek Olšák > > v2: require the previous level to be clearable for determining whether > the last unaligned level is clearable > --- > src/amd/common/ac_surface.c | 18 +- > 1 file changed, 17 inserti

Re: [Mesa-dev] [PATCH 00/10] DRI interface, gallium: User-specified transfer stride

2018-04-26 Thread Marek Olšák
Please ignore this series. Marek On Wed, Apr 25, 2018 at 5:16 PM, Marek Olšák wrote: > Hi, > > This feature is for gralloc, which requires drivers to be able to map > an image with a stride of its own choosing, which is usually the same > as the image stride. This is a very silly feature that p

[Mesa-dev] [PATCH 1/1] main: return 0 length when the queried program object's not linked

2018-04-26 Thread James Xiong
From: "Xiong, James" Signed-off-by: Xiong, James --- src/mesa/main/shaderapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 44b18af..caa4254 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-26 Thread Timothy Arceri
On 26/04/18 23:41, Ian Romanick wrote: On 04/24/2018 07:00 PM, Timothy Arceri wrote: On 25/04/18 07:34, Ian Romanick wrote: On 04/24/2018 09:28 AM, Ian Romanick wrote: On 04/23/2018 08:23 PM, Timothy Arceri wrote: On 24/04/18 10:13, Dieter Nützel wrote: Hello Timo, what about 2 and 3, #1

Re: [Mesa-dev] [PATCH 02/10] dri_interface: add __DRI_IMAGE_TRANSFER_USER_STRIDE

2018-04-26 Thread Gurchetan Singh
On Thu, Apr 26, 2018 at 3:08 PM, Marek Olšák wrote: > On Thu, Apr 26, 2018 at 2:40 PM, Gurchetan Singh > wrote: >> >> On Thu, Apr 26, 2018 at 10:23 AM, Marek Olšák wrote: >> > Gurchetan, can you confirm that the stride returned at alloc() is only >> > used >> > for CPU access and not for display

[Mesa-dev] [PATCH] egl/x11: Send invalidate to driver on copy_region path in swap_buffer

2018-04-26 Thread Deepak Rawat
Similar to swap_available path send invalidate to the driver because egl/X11 is not watching for for server's invalidate events. The dri2_copy_region path is trigered when server supports DRI2 version minor 1. Tested with piglit egl tests for regression. V2: Move invalidate from dri2_copy_region

Re: [Mesa-dev] [PATCH 1/5] mesa: Silence an unused parameter warning

2018-04-26 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 26/04/18 22:28, Ian Romanick wrote: From: Ian Romanick main/framebuffer.c: In function ‘update_color_draw_buffers’: main/framebuffer.c:629:46: warning: unused parameter ‘ctx’ [-Wunused-parameter] update_color_draw_buffers(struct gl_context *ctx, struct gl_f

[Mesa-dev] [PATCH v5 1/4] mesa: add support for nvidia conservative rasterization extensions

2018-04-26 Thread Rhys Perry
For Brian Paul: Since you seemed to have looked over v3 of this patch, you were Cc'd. Compared to v3, it fixes the style problems (including the CLAMP() thing) and adds ALWAYS_INLINE to conservative_raster_parameter(). ___ mesa-dev mailing list mesa

Re: [Mesa-dev] [PATCH 02/10] dri_interface: add __DRI_IMAGE_TRANSFER_USER_STRIDE

2018-04-26 Thread Marek Olšák
On Thu, Apr 26, 2018 at 2:40 PM, Gurchetan Singh < gurchetansi...@chromium.org> wrote: > On Thu, Apr 26, 2018 at 10:23 AM, Marek Olšák wrote: > > Gurchetan, can you confirm that the stride returned at alloc() is only > used > > for CPU access and not for display programming? > > It really depends

[Mesa-dev] [PATCH 5/5] r200: Enable NV_fog_distance

2018-04-26 Thread Ian Romanick
From: Ian Romanick With the previous fixes in place, it appears to just work. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/r200/r200_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/r200/r200_context.c b/src/mesa/drivers/dri/r200/r200_context.c index

[Mesa-dev] [PATCH 3/5] ffvertex: Don't try to read output registers in fog calculation

2018-04-26 Thread Ian Romanick
From: Ian Romanick This code was clearly never tested. It's a good thing that no driver ever tried to enable this path. Signed-off-by: Ian Romanick --- src/mesa/main/ffvertex_prog.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/ffvertex_prog.c b/

[Mesa-dev] [PATCH 1/5] mesa: Silence an unused parameter warning

2018-04-26 Thread Ian Romanick
From: Ian Romanick main/framebuffer.c: In function ‘update_color_draw_buffers’: main/framebuffer.c:629:46: warning: unused parameter ‘ctx’ [-Wunused-parameter] update_color_draw_buffers(struct gl_context *ctx, struct gl_framebuffer *fb) ^~~ Signed-o

[Mesa-dev] [PATCH 2/5] mesa: Add missing support for glFogiv(GL_FOG_DISTANCE_MODE_NV)

2018-04-26 Thread Ian Romanick
From: Ian Romanick Found by inspection, so I made a piglit test too. Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/fog.c b/src/mesa/main/fog.c index c051aaddedc..0decf762a99 100644 ---

[Mesa-dev] [PATCH 4/5] i965: Enable NV_fog_distance

2018-04-26 Thread Ian Romanick
From: Ian Romanick With the previous fixes in place, it appears to just work. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensi

[Mesa-dev] (no subject)

2018-04-26 Thread Ian Romanick
I had some discussions with Timothy Arceri earlier in the week about some old r100 patches that I had written. That led me to re-discover this series that enables NV_fog_distance on platforms that have vertex shader hardware. Tests will be out on the piglit list momentarily.

Re: [Mesa-dev] [PATCH] meson: fix race condition revealed by using 0.44

2018-04-26 Thread Scott D Phillips
Dylan Baker writes: > It turns out that the blocking target we had was hiding some race > conditions in the anv driver with anv_extensions.h generation, we should > fix those. > > CC: Scott D Phillips > CC: Mark Janes > Fixes: 92550d9b16d2b295bdac087f31b1fd6d0f808e02 >("meson: remove wo

Re: [Mesa-dev] [PATCH v2] anv: enable VK_EXT_shader_viewport_index_layer

2018-04-26 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Thu, Apr 26, 2018 at 12:11 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Reviewed-by: Iago Toral Quiroga > --- > src/intel/vulkan/anv_extensions.py | 1 + > src/intel/vulkan/anv_pipeline.c| 1 + > 2 files changed, 2 insertions(+) > >

[Mesa-dev] [PATCH v2] anv: enable VK_EXT_shader_viewport_index_layer

2018-04-26 Thread Caio Marcelo de Oliveira Filho
Reviewed-by: Iago Toral Quiroga --- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_pipeline.c| 1 + 2 files changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index d0b70a0405..b5bee0881c 100644 --- a/src/intel/vulka

Re: [Mesa-dev] [PATCH v2 4/5] i965/clear: Simplify updating the indirect depth value

2018-04-26 Thread Nanley Chery
On Thu, Apr 26, 2018 at 11:27:00AM -0700, Jason Ekstrand wrote: > On Thu, Apr 26, 2018 at 11:19 AM, Rafael Antognolli < > rafael.antogno...@intel.com> wrote: > > > On Thu, Apr 26, 2018 at 10:41:37AM -0700, Nanley Chery wrote: > > > On Wed, Apr 25, 2018 at 08:53:36PM -0400, Jason Ekstrand wrote: >

Re: [Mesa-dev] [PATCH 02/10] dri_interface: add __DRI_IMAGE_TRANSFER_USER_STRIDE

2018-04-26 Thread Gurchetan Singh
On Thu, Apr 26, 2018 at 10:23 AM, Marek Olšák wrote: > Gurchetan, can you confirm that the stride returned at alloc() is only used > for CPU access and not for display programming? It really depends on how you couple your HWComposer and gralloc HALs together. For example, drm_hwcomposer calls dr

Re: [Mesa-dev] [PATCH v2 4/5] i965/clear: Simplify updating the indirect depth value

2018-04-26 Thread Jason Ekstrand
On Thu, Apr 26, 2018 at 11:19 AM, Rafael Antognolli < rafael.antogno...@intel.com> wrote: > On Thu, Apr 26, 2018 at 10:41:37AM -0700, Nanley Chery wrote: > > On Wed, Apr 25, 2018 at 08:53:36PM -0400, Jason Ekstrand wrote: > > > > > > > > > On April 25, 2018 20:25:16 Nanley Chery wrote: > > > > >

Re: [Mesa-dev] [PATCH 02/10] glsl: add missing include to ir_optimization.h

2018-04-26 Thread Matt Turner
On Mon, Apr 9, 2018 at 9:34 PM, Timothy Arceri wrote: > --- > src/compiler/glsl/ir_optimization.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/compiler/glsl/ir_optimization.h > b/src/compiler/glsl/ir_optimization.h > index 81049a479e8..f5d2bea0cd5 100644 > --- a/src/compiler/gl

Re: [Mesa-dev] [PATCH 01/10] glsl: replace some asserts with unreachable when processing the ast

2018-04-26 Thread Matt Turner
On Mon, Apr 9, 2018 at 9:34 PM, Timothy Arceri wrote: > --- > src/compiler/glsl/ast_to_hir.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/compiler/glsl/ast_to_hir.cpp > b/src/compiler/glsl/ast_to_hir.cpp > index 168ab7eec2f..4d7383c580f 100644 > --- a/src/

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Robert Foss
On 04/26/2018 07:43 PM, Emil Velikov wrote: On 26 April 2018 at 18:34, Rob Herring wrote: On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov wrote: On 26 April 2018 at 03:30, Chih-Wei Huang wrote: 2018-04-25 19:55 GMT+08:00 Robert Foss : Hey Emil & Chih-Wei, On 04/24/2018 01:59 PM, Emil Vel

Re: [Mesa-dev] [PATCH v2 4/5] i965/clear: Simplify updating the indirect depth value

2018-04-26 Thread Rafael Antognolli
On Thu, Apr 26, 2018 at 10:41:37AM -0700, Nanley Chery wrote: > On Wed, Apr 25, 2018 at 08:53:36PM -0400, Jason Ekstrand wrote: > > > > > > On April 25, 2018 20:25:16 Nanley Chery wrote: > > > > On Wed, Apr 25, 2018 at 04:50:11PM -0700, Jason Ekstrand wrote: > > On Tue, Apr 24, 2018 at 5:48 PM,

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

2018-04-26 Thread Dylan Baker
Quoting Emil Velikov (2018-04-26 11:04:01) > On 26 April 2018 at 18:45, Dylan Baker wrote: > > I have pretty default to short, which breaks this script. > > > Out of curiosity: why would you do this to yourself ;-) Because I use tig, so all I have to do is press enter to see the entire commit, lo

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

2018-04-26 Thread Emil Velikov
On 26 April 2018 at 18:45, Dylan Baker wrote: > I have pretty default to short, which breaks this script. > Out of curiosity: why would you do this to yourself ;-) > cc: Emil Velikov > cc: Andres Gomez > cc: Juan A. Suarez > Signed-off-by: Dylan Baker > --- > bin/get-fixes-pick-list.sh | 2 +

Re: [Mesa-dev] [PATCH] meson: fix race condition revealed by using 0.44

2018-04-26 Thread Dylan Baker
Quoting Emil Velikov (2018-04-26 10:35:50) > On 26 April 2018 at 18:24, Dylan Baker wrote: > > It turns out that the blocking target we had was hiding some race > > conditions in the anv driver with anv_extensions.h generation, we should > > fix those. > > > anv_entrypoints[0] is the first output

[Mesa-dev] [PATCH] bin: force git show to use default pretty setting

2018-04-26 Thread Dylan Baker
I have pretty default to short, which breaks this script. cc: Emil Velikov cc: Andres Gomez cc: Juan A. Suarez Signed-off-by: Dylan Baker --- bin/get-fixes-pick-list.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/get-fixes-pick-list.sh b/bin/get-fixes-pick-list.sh

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Emil Velikov
On 26 April 2018 at 18:34, Rob Herring wrote: > On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov > wrote: >> On 26 April 2018 at 03:30, Chih-Wei Huang wrote: >>> 2018-04-25 19:55 GMT+08:00 Robert Foss : Hey Emil & Chih-Wei, On 04/24/2018 01:59 PM, Emil Velikov wrote: > > On

Re: [Mesa-dev] [PATCH v2 4/5] i965/clear: Simplify updating the indirect depth value

2018-04-26 Thread Nanley Chery
+ Rafael On Thu, Apr 26, 2018 at 10:41:37AM -0700, Nanley Chery wrote: > On Wed, Apr 25, 2018 at 08:53:36PM -0400, Jason Ekstrand wrote: > > > > > > On April 25, 2018 20:25:16 Nanley Chery wrote: > > > > On Wed, Apr 25, 2018 at 04:50:11PM -0700, Jason Ekstrand wrote: > > On Tue, Apr 24, 2018 a

Re: [Mesa-dev] [PATCH v2 4/5] i965/clear: Simplify updating the indirect depth value

2018-04-26 Thread Nanley Chery
On Wed, Apr 25, 2018 at 08:53:36PM -0400, Jason Ekstrand wrote: > > > On April 25, 2018 20:25:16 Nanley Chery wrote: > > On Wed, Apr 25, 2018 at 04:50:11PM -0700, Jason Ekstrand wrote: > On Tue, Apr 24, 2018 at 5:48 PM, Nanley Chery wrote: > Your email client dropped the quotes :/ Thankfully

Re: [Mesa-dev] [PATCH] meson: fix race condition revealed by using 0.44

2018-04-26 Thread Emil Velikov
On 26 April 2018 at 18:24, Dylan Baker wrote: > It turns out that the blocking target we had was hiding some race > conditions in the anv driver with anv_extensions.h generation, we should > fix those. > anv_entrypoints[0] is the first output of the anv_entrypoints custom_target. Aka it's effectiv

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Rob Herring
On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov wrote: > On 26 April 2018 at 03:30, Chih-Wei Huang wrote: >> 2018-04-25 19:55 GMT+08:00 Robert Foss : >>> Hey Emil & Chih-Wei, >>> >>> On 04/24/2018 01:59 PM, Emil Velikov wrote: On 24 April 2018 at 12:28, Emil Velikov wrote: > On

[Mesa-dev] [PATCH] meson: fix race condition revealed by using 0.44

2018-04-26 Thread Dylan Baker
It turns out that the blocking target we had was hiding some race conditions in the anv driver with anv_extensions.h generation, we should fix those. CC: Scott D Phillips CC: Mark Janes Fixes: 92550d9b16d2b295bdac087f31b1fd6d0f808e02 ("meson: remove workaround for custom target creating .

Re: [Mesa-dev] [PATCH 02/10] dri_interface: add __DRI_IMAGE_TRANSFER_USER_STRIDE

2018-04-26 Thread Marek Olšák
Gurchetan, can you confirm that the stride returned at alloc() is only used for CPU access and not for display programming? Thanks, Marek On Wed, Apr 25, 2018 at 11:23 PM, Marek Olšák wrote: > Why would you want to modify it? It's exactly what you get when you map > it, but that stride can't be

[Mesa-dev] [Bug 106157] [Tracker] Mesa 18.1 release tracker

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106157 Mark Janes changed: What|Removed |Added Depends on||105906 Referenced Bugs: https://bugs.fre

Re: [Mesa-dev] [PATCH 09/10] gallium: add PIPE_CAP_TRANSFER_USER_STRIDE_ALIGNMENT

2018-04-26 Thread Marek Olšák
On Thu, Apr 26, 2018 at 6:27 AM, Nicolai Hähnle wrote: > On 25.04.2018 23:29, Roland Scheidegger wrote: > >> Am 25.04.2018 um 23:16 schrieb Marek Olšák: >> >>> From: Marek Olšák >>> >>> --- >>> src/gallium/docs/source/screen.rst | 3 +++ >>> src/gallium/drivers/etnaviv/etnaviv_s

Re: [Mesa-dev] [PATCH] st/mesa: fix missing setting of _ElementSize in new_draw_rasterpos_stage

2018-04-26 Thread Brian Paul
Reviewed-by: Brian Paul On 04/26/2018 10:29 AM, Charmaine Lee wrote: With this patch, _ElementSize is initialized along with the rest of the vertex array attributes in new_draw_rasterpos_stage(). This fixes a crash in st_pipe_vertex_format() when running topogun-1.06-orc-84k-resize trace file w

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] travis: update libva required version

2018-04-26 Thread Emil Velikov
On 25 April 2018 at 14:44, Juan A. Suarez Romero wrote: > On Wed, 2018-04-25 at 13:54 +0100, Emil Velikov wrote: >> On 24 April 2018 at 08:49, Juan A. Suarez Romero wrote: >> > On Fri, 2018-04-20 at 16:42 +0200, Juan A. Suarez Romero wrote: >> > > Commit fa328456e8f29 added VP9 config support, bu

[Mesa-dev] [PATCH] st/mesa: fix missing setting of _ElementSize in new_draw_rasterpos_stage

2018-04-26 Thread Charmaine Lee
With this patch, _ElementSize is initialized along with the rest of the vertex array attributes in new_draw_rasterpos_stage(). This fixes a crash in st_pipe_vertex_format() when running topogun-1.06-orc-84k-resize trace file with VMware svga driver. --- src/mesa/state_tracker/st_cb_rasterpos.c | 5

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Emil Velikov
On 26 April 2018 at 03:30, Chih-Wei Huang wrote: > 2018-04-25 19:55 GMT+08:00 Robert Foss : >> Hey Emil & Chih-Wei, >> >> On 04/24/2018 01:59 PM, Emil Velikov wrote: >>> >>> On 24 April 2018 at 12:28, Emil Velikov wrote: >>> On the topic of keeping the old code behind a #define or just remov

Re: [Mesa-dev] [PATCH v2] dri3: Prevent multiple freeing of buffers.

2018-04-26 Thread Michel Dänzer
On 2018-04-10 09:44 AM, Sergii Romantsov wrote: > Commit 3160cb86aa92 adds optimization with flag 'reallocate'. > Processing of flag causes buffers freeing while pointer > is still hold in caller stack and than again used to be freed. > > Fixes: 3160cb86aa92 "egl/x11: Re-allocate buffers if format

[Mesa-dev] [Bug 99987] Mesa 13+ breaks Xvnc (and similar X servers)

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99987 Emil Velikov changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Mesa-dev] [ANNOUNCE] Mesa 18.0.2 release candidate

2018-04-26 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.0.2 is now available. Currently we have: - 18 queued - 1 nominated (outstanding) - and 0 rejected patches The current queue consists of: A couple of fixes for Meson that solves some problems regarding building tests and installation. A couple of fix

Re: [Mesa-dev] [PATCH 2/2] spirv: convert the offset and count operands for bitfield ops to uint32

2018-04-26 Thread Jason Ekstrand
On Thu, Apr 26, 2018 at 2:24 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > SPIR-V allows to define the shift operand for shift opcodes with > a bit-size different than 32 bits, but in NIR the opcodes have > that limitation. As agreed in the mailing list, this patch adds > a conver

[Mesa-dev] [Bug 106232] LLVM unit tests have error in random number handling

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106232 --- Comment #4 from Roland Scheidegger --- Created attachment 139140 --> https://bugs.freedesktop.org/attachment.cgi?id=139140&action=edit patch to fix bogus random numbers Ok this patch should fix it. Non-normalized signed ints had completel

Re: [Mesa-dev] [PATCH] st/va: Fix typos

2018-04-26 Thread Leo Liu
Hi Drew, This patch along with your other patch are pushed. Thanks for the help. Leo On 04/25/2018 11:55 AM, Leo Liu wrote: Reviewed-by: Leo Liu On 2018-04-25 11:32 AM, Drew Davenport wrote: s/attibute/attribute/ s/suface/surface/ ---   src/gallium/state_trackers/va/surface.c | 48 ++

[Mesa-dev] [Bug 106232] LLVM unit tests have error in random number handling

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106232 --- Comment #3 from Roland Scheidegger --- (In reply to Jose Fonseca from comment #2) > It's been a long time, but I think Tom's right. This was a thinko, and my > intent was the opposite. Ok that makes sense. With this code only reversing sign

[Mesa-dev] [Bug 99987] Mesa 13+ breaks Xvnc (and similar X servers)

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99987 --- Comment #22 from Pierre Ossman --- Is there a symlink in place by default now? If so then I'd say the issue is resolved. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

[Mesa-dev] [Bug 106232] LLVM unit tests have error in random number handling

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106232 --- Comment #2 from Jose Fonseca --- It's been a long time, but I think Tom's right. This was a thinko, and my intent was the opposite. > And float range is only from 0 to 2.0f? That's correct. That's sufficient to exercise the clamping. R

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-26 Thread Ian Romanick
On 04/24/2018 07:00 PM, Timothy Arceri wrote: > > > On 25/04/18 07:34, Ian Romanick wrote: >> On 04/24/2018 09:28 AM, Ian Romanick wrote: >>> On 04/23/2018 08:23 PM, Timothy Arceri wrote: On 24/04/18 10:13, Dieter Nützel wrote: > Hello Timo, > > what about 2 and 3, #1 landed. >>>

Re: [Mesa-dev] [RFC 3/3] clover+gallium+freedreno: caps to reduce kernel recompiles

2018-04-26 Thread Rob Clark
On Thu, Apr 26, 2018 at 5:40 AM, Pierre Moreau wrote: > The cap would need to be added to the documentation as well, in > “src/gallium/docs/source/screen.rst”. > > I might be wrong, but I think you are going to break all existing drivers in > clover, that do not yet support the new cap: for unsupp

Re: [Mesa-dev] [PATCH 08/11] intel/compiler: fix brw_negate_immediate for 16-bit types

2018-04-26 Thread Chema Casanova
El 24/04/18 a las 23:55, Jason Ekstrand escribió: > On Wed, Apr 11, 2018 at 12:20 AM, Iago Toral Quiroga > wrote: > > From: Jose Maria Casanova Crespo > > > 16-bit immediates are replicated in each word of a 32-bit value >

Re: [Mesa-dev] [PATCH 14/22] nir/linker: add some cross stage uniform validation

2018-04-26 Thread Alejandro Piñeiro
We found some issues with this patch, so we are dropping it. No need to review it. We will send a new patch when we finish that, but it is not needed to stop the review of the rest of the patches of the series for that. This patch was already independent enough. If someone is interested on the det

Re: [Mesa-dev] [PATCH v2] ac/nir: set lod to 0 for ac_image_load_mip

2018-04-26 Thread Nicolai Hähnle
Is there any reason why we can't just use ac_image_load in such cases? On 26.04.2018 13:18, Samuel Pitoiset wrote: Otherwise we hit an assertion in ac_build_image_opcode() for ac_image_load_mip. v2: - set only for ac_image_load_mip Fixes: 24fb3e6aa16 ("ac/nir: use ac_build_image_opcode for ima

[Mesa-dev] [PATCH v2] ac/nir: set lod to 0 for ac_image_load_mip

2018-04-26 Thread Samuel Pitoiset
Otherwise we hit an assertion in ac_build_image_opcode() for ac_image_load_mip. v2: - set only for ac_image_load_mip Fixes: 24fb3e6aa16 ("ac/nir: use ac_build_image_opcode for image intrinsics") Cc: 18.1 Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 2 ++ 1 file changed,

[Mesa-dev] [Bug 106251] [PATCH] SWR driver doesn't compile with LLVM 7.0 snapshots

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106251 Bug ID: 106251 Summary: [PATCH] SWR driver doesn't compile with LLVM 7.0 snapshots Product: Mesa Version: git Hardware: All OS: All Status: NEW

Re: [Mesa-dev] [PATCH 09/10] gallium: add PIPE_CAP_TRANSFER_USER_STRIDE_ALIGNMENT

2018-04-26 Thread Nicolai Hähnle
On 25.04.2018 23:29, Roland Scheidegger wrote: Am 25.04.2018 um 23:16 schrieb Marek Olšák: From: Marek Olšák --- src/gallium/docs/source/screen.rst | 3 +++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/ga

[Mesa-dev] [PATCH] ac/nir: set lod to 0 when it's unused

2018-04-26 Thread Samuel Pitoiset
Otherwise we hit an assertion in ac_build_image_opcode() for ac_image_load_mip. Fixes: 24fb3e6aa16 ("ac/nir: use ac_build_image_opcode for image intrinsics") Cc: 18.1 Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd

Re: [Mesa-dev] [PATCH] radv: fix multisample image copies

2018-04-26 Thread Samuel Pitoiset
On 04/25/2018 11:25 AM, Alex Smith wrote: Any more thoughts on this? Any objections to it going to stable as well (it fixes bugs, but is quite a large change)? I will take care of this after running CTS on Polaris/Vega. Thanks, Alex On 19 April 2018 at 09:27, Matthew Nicholls mailto:mnic

Re: [Mesa-dev] [PATCH] egl/x11: Send invalidate to the driver on dri2_copy_region

2018-04-26 Thread Thomas Hellstrom
On 04/26/2018 11:56 AM, Michel Dänzer wrote: On 2018-04-26 11:33 AM, Thomas Hellstrom wrote: On 04/26/2018 10:30 AM, Michel Dänzer wrote: On 2018-04-25 07:49 PM, Deepak Rawat wrote: Similar to what is done in dri2_x11_swap_buffers_msc send invalidate to the driver because egl/X11 is not watchi

Re: [Mesa-dev] [PATCH] egl/x11: Send invalidate to the driver on dri2_copy_region

2018-04-26 Thread Michel Dänzer
On 2018-04-26 11:33 AM, Thomas Hellstrom wrote: > On 04/26/2018 10:30 AM, Michel Dänzer wrote: >> On 2018-04-25 07:49 PM, Deepak Rawat wrote: >>> Similar to what is done in dri2_x11_swap_buffers_msc send invalidate >>> to the driver because egl/X11 is not watching for for server's >>> invalidate ev

Re: [Mesa-dev] [RFC 3/3] clover+gallium+freedreno: caps to reduce kernel recompiles

2018-04-26 Thread Pierre Moreau
The cap would need to be added to the documentation as well, in “src/gallium/docs/source/screen.rst”. I might be wrong, but I think you are going to break all existing drivers in clover, that do not yet support the new cap: for unsupported caps, drivers return a value of 0, which means they would

Re: [Mesa-dev] [PATCH] egl/x11: Send invalidate to the driver on dri2_copy_region

2018-04-26 Thread Thomas Hellstrom
On 04/26/2018 10:30 AM, Michel Dänzer wrote: On 2018-04-25 07:49 PM, Deepak Rawat wrote: Similar to what is done in dri2_x11_swap_buffers_msc send invalidate to the driver because egl/X11 is not watching for for server's invalidate events. The dri2_copy_region path is trigerred when server suppo

[Mesa-dev] [Bug 106246] radv: VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT and bringing down initial pipeline compile times

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106246 Timothy Arceri changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |t_arc...@yahoo.com.au

[Mesa-dev] [PATCH 2/2] spirv: convert the offset and count operands for bitfield ops to uint32

2018-04-26 Thread Samuel Iglesias Gonsálvez
SPIR-V allows to define the shift operand for shift opcodes with a bit-size different than 32 bits, but in NIR the opcodes have that limitation. As agreed in the mailing list, this patch adds a conversion to 32 bits to fix this. For more info, see: https://lists.freedesktop.org/archives/mesa-dev/

[Mesa-dev] [PATCH 1/2] spirv: convert the shift operand for bitwise shift ops to uint32

2018-04-26 Thread Samuel Iglesias Gonsálvez
SPIR-V allows to define the shift operand for shift opcodes with a bit-size different than 32 bits, but in NIR the opcodes have that limitation. As agreed in the mailing list, this patch adds a conversion to 32 bits to fix this. For more info, see: https://lists.freedesktop.org/archives/mesa-dev/

Re: [Mesa-dev] [PATCH] spirv: convert the shift operand for bitwise shift ops to uint32

2018-04-26 Thread Samuel Iglesias Gonsálvez
Please ignore this patch, I'm about to send a patch series that includes this patch and another one for bitfield ops. Sam On 25/04/18 14:07, Samuel Iglesias Gonsálvez wrote: > SPIR-V allows to define the shift operand for shift opcodes with > a bit-size different than 32 bits, but in NIR the opc

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #10 from Samuel Pitoiset --- I have been able to reproduce the hang one or two times. Unfortunately it's really hard to reproduce, so really hard to fix but we are working on! -- You are receiving this mail because: You are the ass

[Mesa-dev] [Bug 106246] radv: VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT and bringing down initial pipeline compile times

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106246 --- Comment #1 from Samuel Pitoiset --- Hi Phillip, It's doable but it would require a non-trivial amount of work. And I'm not sure if the gain will be significant, especially if most of the time is spent in LLVM. Also, disabling optimizations

[Mesa-dev] [Bug 106246] radv: VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT and bringing down initial pipeline compile times

2018-04-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106246 Bug ID: 106246 Summary: radv: VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT and bringing down initial pipeline compile times Product: Mesa Version: git Hardware: Other

Re: [Mesa-dev] [PATCH] egl/x11: Send invalidate to the driver on dri2_copy_region

2018-04-26 Thread Michel Dänzer
On 2018-04-25 07:49 PM, Deepak Rawat wrote: > Similar to what is done in dri2_x11_swap_buffers_msc send invalidate > to the driver because egl/X11 is not watching for for server's > invalidate events. The dri2_copy_region path is trigerred when > server supports DRI2 version minor 1. > > Tested wi

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Chih-Wei Huang
2018-04-25 19:55 GMT+08:00 Robert Foss : > Hey Emil & Chih-Wei, > > On 04/24/2018 01:59 PM, Emil Velikov wrote: >> >> On 24 April 2018 at 12:28, Emil Velikov wrote: >> >>> On the topic of keeping the old code behind a #define or just removing >>> it, it'll be great if interested parties can reach

[Mesa-dev] DriConf replacement

2018-04-26 Thread Aruna Maurya
Hey! I wish to contribute to this project. I have substantial experience in C and C++. It would be great if someone could help me in building the environment. Thankyou for your time! -- Regards, Aruna Maurya, CSE,B.tech, Github | Medium