Re: [Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

Hi, Tomasz On 4/27/2018 5:01 PM, Tomasz Figa wrote: Hi Min, On Fri, Apr 27, 2018 at 11:36 AM Min He wrote: To avoid blocking other EGL calls, release the display mutex before calling update_buffers(), which will call droid_window_dequeue_buffer(). The lock appears like

Re: [Mesa-dev] [PATCH] st/va: Support YUV formats in vaCreateSurfaces

Looks good - I was going to say the C++ comment should be /* */ but I see there's already a // in the file so... ¯\_(ツ)_/¯ Reviewed-by: Kristian H. Kristensen On Fri, Apr 27, 2018 at 8:35 AM Drew Davenport wrote: > diff --git

Re: [Mesa-dev] [PATCH 00/10] DRI interface, gallium: User-specified transfer stride

FYI, this series is open for reviews again and planned to be pushed soon. Marek On Thu, Apr 26, 2018 at 10:13 PM, Marek Olšák wrote: > Please ignore this series. > > Marek > > On Wed, Apr 25, 2018 at 5:16 PM, Marek Olšák wrote: > >> Hi, >> >> This feature

Re: [Mesa-dev] [PATCH 02/10] dri_interface: add __DRI_IMAGE_TRANSFER_USER_STRIDE

So this series is back in the review process. Only the last 4 patches need an Rb and it's good to go. Marek On Fri, Apr 27, 2018 at 4:29 PM, Nicolai Hähnle wrote: > On 27.04.2018 19:21, Gurchetan Singh wrote: > >> On Fri, Apr 27, 2018 at 2:00 AM, Nicolai Hähnle

[Mesa-dev] [ANNOUNCE] mesa 18.1.0-rc2

Hi List, Mesa 18.1.0-rc2 is now available. There are 20 nominated patches, and no queued or rejected patches. All patches applied cleanly, so no conflicts at all. Yay. git tag: mesa-18.1.0-rc2 Nominated (20) == Bas Nieuwenhuizen (1): • nir: Do not use progress for unreachable

Re: [Mesa-dev] [PATCH 1/7] ac/surface: handle DCC subresource fast clear restriction on VI

On 27.04.2018 19:23, Marek Olšák wrote: On Fri, Apr 27, 2018 at 4:14 AM, Nicolai Hähnle > wrote: Sorry, but I still don't understand the logic of this :/ What we want to check for is that all the DCC bytes of a mip-level are

Re: [Mesa-dev] [PATCH] nir: Transform discard_if(true) into discard

On Fri, Apr 27, 2018 at 12:17 PM, Matt Turner wrote: > Noticed while reviewing Tim Arceri's NIR inlining series. > > Without his series: > > instructions in affected programs: 16 -> 14 (-12.50%) > helped: 2 > > With his series: > > instructions in affected programs: 196 ->

Re: [Mesa-dev] [PATCH] i965: Support __DRI_IMAGE_FORMAT_XBGR2101010

Looks like your patch is against a fairly old tree. In the current one, the following dri image formats exist: #define __DRI_IMAGE_FORMAT_XBGR2101010 0x1010 #define __DRI_IMAGE_FORMAT_ABGR2101010 0x1011 #define __DRI_IMAGE_FORMAT_SABGR8 0x1012 I piped the XB30/AB30 stuff through to

Re: [Mesa-dev] [PATCH 02/10] dri_interface: add __DRI_IMAGE_TRANSFER_USER_STRIDE

On 27.04.2018 19:21, Gurchetan Singh wrote: On Fri, Apr 27, 2018 at 2:00 AM, Nicolai Hähnle wrote: That was the whole point of the USER_STRIDE business. There are two alternatives I can see: 1. Change minigbm so that it always maps the entire texture regardless of what the

[Mesa-dev] [PATCH] i965: Support __DRI_IMAGE_FORMAT_XBGR2101010

This patch adds support for XBGR2101010 (a.k.a. XB30) to i965. ToT supports XR30/AR30; XB30 is needed to support GL_RGB10_* texture internal formats with the correct channel order. BUG=https://crbug.com/776093 TEST=Compile and deploy mesa+this patch, then playback a VP9 Profile 2 video with sw

Re: [Mesa-dev] [PATCH 02/10] dri_interface: add __DRI_IMAGE_TRANSFER_USER_STRIDE

On 27.04.2018 17:55, Marek Olšák wrote: Even if ChromeOS doesn't map the whole texture, we still need the stride change, because the hw can't use the display stride for mappings (it's an unsupported user stride). You're right. They're two separate issues, but both need fixing (or not, but it

Re: [Mesa-dev] [PATCH 00/21] OpenSWR batch change

Reviewed-by: Bruce Cherniak > On Apr 25, 2018, at 2:21 PM, George Kyriazis > wrote: > > Misc changes. Include: > - fix KNL behavior with LLVm 6.0.0 > - fix byte offset for non-indexed draws > - fix 64-bit float handling with code

[Mesa-dev] [PATCH] nir: Transform discard_if(true) into discard

Noticed while reviewing Tim Arceri's NIR inlining series. Without his series: instructions in affected programs: 16 -> 14 (-12.50%) helped: 2 With his series: instructions in affected programs: 196 -> 174 (-11.22%) helped: 22 --- src/compiler/nir/nir_opt_constant_folding.c | 17

Re: [Mesa-dev] [PATCH v2] i965/meta-util: Convert the clear color through the surf format

On Thu, Jan 11, 2018 at 02:19:40PM +0100, Neil Roberts wrote: > When programming the fast clear color there was previously a chunk of > code to try to make the color match the constraints of the surface > format such as by filling in missing components and handling luminance > formats. These cases

[Mesa-dev] [PATCH v7 0/4] Implement Various Conservative Rasterization Extensions

This patch-set adds support for GL_NV_conservative_raster and GL_NV_conservative_raster_dilate on GM2xx and newer. It also adds support for GL_NV_conservative_raster_pre_snap_triangles on GP1xx. In doing so, it implements various functions in mesa core, extends the Gallium API, connects the new

[Mesa-dev] [PATCH v7 1/4] mesa: add support for nvidia conservative rasterization extensions

Although the specs are written against compatibility GL 4.3 and allows core profile and GLES2+, it is exposed for GL 1.0+ and GLES1 and GLES2+. Signed-off-by: Rhys Perry --- src/mapi/glapi/gen/gl_API.xml | 47 src/mapi/glapi/gen/gl_genexec.py

[Mesa-dev] [PATCH] bin: add --pretty=medium to get-pick-list

Signed-off-by: Dylan Baker --- bin/get-pick-list.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh index 1bd0b367d8b..9e9a39e494b 100755 --- a/bin/get-pick-list.sh +++ b/bin/get-pick-list.sh @@ -12,7 +12,7

Re: [Mesa-dev] [PATCH 1/7] ac/surface: handle DCC subresource fast clear restriction on VI

On Fri, Apr 27, 2018 at 4:14 AM, Nicolai Hähnle wrote: > Sorry, but I still don't understand the logic of this :/ > > What we want to check for is that all the DCC bytes of a mip-level are > contiguous, right? > > Why does it matter for that whether a level is the last level?

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

Quoting Emil Velikov (2018-04-27 06:12:41) > On 26 April 2018 at 19:06, Dylan Baker wrote: > > Quoting Emil Velikov (2018-04-26 11:04:01) > >> On 26 April 2018 at 18:45, Dylan Baker wrote: > >> > I have pretty default to short, which breaks this script.

Re: [Mesa-dev] [PATCH 02/10] dri_interface: add __DRI_IMAGE_TRANSFER_USER_STRIDE

On Fri, Apr 27, 2018 at 2:00 AM, Nicolai Hähnle wrote: > On 26.04.2018 04:30, Marek Olšák wrote: >> >> On Wed, Apr 25, 2018 at 6:56 PM, Gurchetan Singh >> > wrote: >> >> On Wed, Apr 25, 2018 at 2:16 PM, Marek

Re: [Mesa-dev] [PATCH v3] radv: fix multisample image copies

On 04/27/2018 06:34 PM, Samuel Pitoiset wrote: From: Matthew Nicholls Previously before fb077b0728, the LOD parameter was being used in place of the sample index, which would only copy the first sample to all samples in the destination image. After that

[Mesa-dev] [PATCH v3] radv: fix multisample image copies

From: Matthew Nicholls Previously before fb077b0728, the LOD parameter was being used in place of the sample index, which would only copy the first sample to all samples in the destination image. After that multisample image copies wouldn't copy anything from my

Re: [Mesa-dev] [PATCH v2] radv: fix multisample image copies

On 04/27/2018 02:30 PM, Matthew Nicholls wrote: I've verified the V2 of my patch does still fix the original issue I was seeing. You checked on Polaris, right? Vega still has an issue, working on it. Won't be ready for rc2. Thanks a bunch. Matthew. On 27/04/18 12:26, Samuel Pitoiset

[Mesa-dev] [PATCH v3 3/3] i965: enable INTEL_blackhole_render

v2: condition the extension on context isolation support from the kernel (Chris) v3: (Lionel) The initial version of this change used a feature of the Gen7+ command parser to turn the primitive instructions into no-ops. Unfortunately this doesn't play well with how we're using

[Mesa-dev] [PATCH v3 0/3] mesa/i965: Add support for INTEL_blackhole_render

Hi all, Another update with the implementation in i965 back to using command streamer flags to have the hardware turn primitive/media instructions into noop. Haswell showed some interesting issues so I've disabled the extension there, Gen8+ seems fine. Cheers, Lionel Landwerlin (3): include:

[Mesa-dev] [PATCH v3 2/3] mesa: add INTEL_blackhole_render

v2: Implement missing Enable/Disable (Emil) v3: Drop unused NewIntelBlackholeRender (Ken) v4: Bring back NewIntelBlackholeRender as i965 implementation uses it again (Lionel) Signed-off-by: Lionel Landwerlin Reviewed-by: Kenneth Graunke

[Mesa-dev] [PATCH] mesa/main/readpix: Correct handling of packed floating point values

From: Gert Wollny Make sure that clamping in the pixel transfer operations is enabled/disabled for packed floating point values just like it is done for single normal and half precision floating point values. This fixes a series of CTS tests with virgl that use

[Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

From: Michel Dänzer And only free no longer needed back buffers there as well. We want to stick to the same back buffer throughout a frame, otherwise we can run into various issues. Bugzilla: https://bugs.freedesktop.org/105906 Fixes: 3160cb86aa92 "egl/x11: Re-allocate

Re: [Mesa-dev] [PATCH 02/10] dri_interface: add __DRI_IMAGE_TRANSFER_USER_STRIDE

On Fri, Apr 27, 2018 at 5:00 AM, Nicolai Hähnle wrote: > On 26.04.2018 04:30, Marek Olšák wrote: > >> On Wed, Apr 25, 2018 at 6:56 PM, Gurchetan Singh < >> gurchetansi...@chromium.org > wrote: >> >> On Wed, Apr 25, 2018 at 2:16 PM,

[Mesa-dev] [PATCH 1/1] main: fail texture_storage() call if the size is not okay

From: "Xiong, James" Signed-off-by: Xiong, James --- src/mesa/main/texstorage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c index 44edba3..9cb8b90 100644 ---

[Mesa-dev] [PATCH] st/va: Support YUV formats in vaCreateSurfaces

diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_trackers/va/surface.c index 0824f1b74a..003f88f1f9 100644 --- a/src/gallium/state_trackers/va/surface.c +++ b/src/gallium/state_trackers/va/surface.c @@ -531,10 +531,12 @@ surface_from_external_memory(VADriverContextP ctx,

Re: [Mesa-dev] [PATCH v6 0/4] Implement Various Conservative Rasterization Extensions

On 04/27/2018 08:43 AM, Rhys Perry wrote: This patch-set adds support for GL_NV_conservative_raster and GL_NV_conservative_raster_dilate on GM2xx and newer. It also adds support for GL_NV_conservative_raster_pre_snap_triangles on GP1xx. In doing so, it implements various functions in mesa core,

Re: [Mesa-dev] [PATCH 1/1] main: return 0 length when the queried program object's not linked

On Fri, 27 Apr 2018 12:32:09 +1000 Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > > It would also be nice to have a piglit test for this case. I assume > mesa probably crashes without this patch? Thanks for the review. Yes there was a

[Mesa-dev] [Bug 106246] radv: VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT and bringing down initial pipeline compile times

https://bugs.freedesktop.org/show_bug.cgi?id=106246 --- Comment #5 from Roland Scheidegger --- FWIW with llvmpipe (gallivm) we found that LICM can have very high cost (in particular the lcssa pass that comes with it). I think though it was mostly related to the main shader

[Mesa-dev] [PATCH v6 1/4] mesa: add support for nvidia conservative rasterization extensions

Although the specs are written against compatibility GL 4.3 and allows core profile and GLES2+, it is exposed for GL 1.0+ and GLES1 and GLES2+. Signed-off-by: Rhys Perry --- src/mapi/glapi/gen/gl_API.xml | 47 src/mapi/glapi/gen/gl_genexec.py

[Mesa-dev] [PATCH v6 3/4] st/mesa: add support for nvidia conservative rasterization extensions

Signed-off-by: Rhys Perry --- src/mesa/state_tracker/st_atom_rasterizer.c | 15 + src/mesa/state_tracker/st_context.c | 2 ++ src/mesa/state_tracker/st_extensions.c | 34 + 3 files changed, 51 insertions(+) diff

[Mesa-dev] [PATCH v6 0/4] Implement Various Conservative Rasterization Extensions

This patch-set adds support for GL_NV_conservative_raster and GL_NV_conservative_raster_dilate on GM2xx and newer. It also adds support for GL_NV_conservative_raster_pre_snap_triangles on GP1xx. In doing so, it implements various functions in mesa core, extends the Gallium API, connects the new

Re: [Mesa-dev] [Mesa-stable] [PATCH] autotools, meson: bump up required VA version

On 27 April 2018 at 10:02, Juan A. Suarez Romero wrote: > Due using a new VP9 config we use, required VA API 0.39 > > Fixes: 413c5ca3727 ("travis: update libva required version") > CC: 18.1 Reviewed-by: Emil Velikov

Re: [Mesa-dev] [PATCH v5 1/4] mesa: add support for nvidia conservative rasterization extensions

On 04/26/2018 04:33 PM, Rhys Perry wrote: For Brian Paul: Since you seemed to have looked over v3 of this patch, you were Cc'd. Compared to v3, it fixes the style problems (including the CLAMP() thing) and adds ALWAYS_INLINE to conservative_raster_parameter(). A few more nit-picks

[Mesa-dev] [Bug 106283] Shader replacements works only for limited use cases

https://bugs.freedesktop.org/show_bug.cgi?id=106283 Bug ID: 106283 Summary: Shader replacements works only for limited use cases Product: Mesa Version: unspecified Hardware: All OS: All Status: NEW

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

On 26 April 2018 at 19:06, Dylan Baker wrote: > Quoting Emil Velikov (2018-04-26 11:04:01) >> On 26 April 2018 at 18:45, Dylan Baker wrote: >> > I have pretty default to short, which breaks this script. >> > >> Out of curiosity: why would you do this to

Re: [Mesa-dev] [PATCH v2] radv: fix multisample image copies

On 04/27/2018 02:30 PM, Matthew Nicholls wrote: I've verified the V2 of my patch does still fix the original issue I was seeing. Thanks a bunch. Cool! Thanks for confirming, I will push the patch. Matthew. On 27/04/18 12:26, Samuel Pitoiset wrote: Matthew, can you double-check if v2

[Mesa-dev] [PATCH] st/omx/enc: fix blit setup for YUV LoadImage

The blit here involves scaling since it's copying from I8 format to R8G8 format. Half of source will be filtered out with PIPE_TEX_FILTER_NEAREST instruction, it looks that GPU always uses the second half as source. Currently we use "1" as the start point of x for R, then causing 1 source pixel of

Re: [Mesa-dev] [PATCH v2] radv: fix multisample image copies

I've verified the V2 of my patch does still fix the original issue I was seeing. Thanks a bunch. Matthew. On 27/04/18 12:26, Samuel Pitoiset wrote: Matthew, can you double-check if v2 still fixes the issue for you? Thanks! On 04/27/2018 01:23 PM, Samuel Pitoiset wrote: From: Matthew

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

https://bugs.freedesktop.org/show_bug.cgi?id=100430 Aaron Paden changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] meson: fix race condition revealed by using 0.44

On 26 April 2018 at 18:57, Dylan Baker wrote: > Quoting Emil Velikov (2018-04-26 10:35:50) >> On 26 April 2018 at 18:24, Dylan Baker wrote: >> > It turns out that the blocking target we had was hiding some race >> > conditions in the anv driver with

[Mesa-dev] [PATCH v1 2/2] egl/android: Add DRM node probing and filtering

This patch both adds support for probing & filtering DRM nodes and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD gralloc call. Currently the filtering is based just on the driver name, and the desired name is supplied using the "drm.gpu.vendor_name" Android property. The

[Mesa-dev] [PATCH v1 1/2] egl/android: #ifdef out flink name support

From: Rob Herring Maintaining both flink names and prime fd support which are provided by 2 different gralloc implementations is problematic because we have a dependency on a specific gralloc implementation header. This mostly disables the dependency on the gralloc

[Mesa-dev] [PATCH v1 0/2] egl/android: Remove dependencies on specific grallocs

v1 of this series is based on the previous RFC[1]. This series is intended to remove the dependency on any one specific gralloc implementation, as well as introduce device probing. The probing support is built ontop of [2], which supplies a drmHandleMatch() function which allows is to test

Re: [Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

On 27.04.2018 12:01, Tomasz Figa wrote: Hi Min, On Fri, Apr 27, 2018 at 11:36 AM Min He wrote: To avoid blocking other EGL calls, release the display mutex before calling update_buffers(), which will call droid_window_dequeue_buffer(). The lock appears like below: 1.

Re: [Mesa-dev] [PATCH v2] ac/nir: set lod to 0 for ac_image_load_mip

On 04/27/2018 10:50 AM, Nicolai Hähnle wrote: On 27.04.2018 10:05, Samuel Pitoiset wrote: On 04/26/2018 01:51 PM, Nicolai Hähnle wrote: Is there any reason why we can't just use ac_image_load in such cases? For nit_texop_txf_ms we need one more coordinate for the sample index, if we use

Re: [Mesa-dev] [PATCH v2] radv: fix multisample image copies

Matthew, can you double-check if v2 still fixes the issue for you? Thanks! On 04/27/2018 01:23 PM, Samuel Pitoiset wrote: From: Matthew Nicholls Previously before fb077b0728, the LOD parameter was being used in place of the sample index, which would only copy

[Mesa-dev] [PATCH v2] radv: fix multisample image copies

From: Matthew Nicholls Previously before fb077b0728, the LOD parameter was being used in place of the sample index, which would only copy the first sample to all samples in the destination image. After that multisample image copies wouldn't copy anything from my

[Mesa-dev] [PATCH] Don't set swap interval for PBuffer surface. This fixes crash due to NULL window.

Test: CtsDisplayTestCases pass Signed-off-by: samiuddi --- src/egl/drivers/dri2/platform_android.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 976dd10..5048830

Re: [Mesa-dev] [PATCH v2] ac: fix texture query LOD for 1D textures on GFX9

Reviewed-by: Nicolai Hähnle On 25.04.2018 18:15, Samuel Pitoiset wrote: 1D textures are allocated as 2D which means we only need one coordinate for texture query LOD. v2: - move the fixup into ac_nir_to_llvm Fixes: 625dcbbc456 ("amd/common: pass address components

Re: [Mesa-dev] [PATCH] egl/x11: Send invalidate to driver on copy_region path in swap_buffer

On 2018-04-27 01:09 AM, Deepak Rawat wrote: > Similar to swap_available path send invalidate to the driver because > egl/X11 is not watching for for server's invalidate events. The > dri2_copy_region path is trigered when server supports DRI2 version > minor 1. > > Tested with piglit egl tests

[Mesa-dev] [Bug 106246] radv: VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT and bringing down initial pipeline compile times

https://bugs.freedesktop.org/show_bug.cgi?id=106246 --- Comment #4 from Timothy Arceri --- (In reply to Nicolai Hähnle from comment #3) > As long as scratch buffer support is robust, removing LLVM IR optimization > passes is probably not a problem, though you really do

[Mesa-dev] [PATCH] autotools, meson: bump up required VA version

Due using a new VP9 config we use, required VA API 0.39 Fixes: 413c5ca3727 ("travis: update libva required version") CC: 18.1 --- configure.ac | 2 +- meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac

Re: [Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

Hi Min, On Fri, Apr 27, 2018 at 11:36 AM Min He wrote: > To avoid blocking other EGL calls, release the display mutex before > calling update_buffers(), which will call droid_window_dequeue_buffer(). > The lock appears like below: > 1. Consumer thread: updateTexImage() ->

Re: [Mesa-dev] [PATCH 02/10] dri_interface: add __DRI_IMAGE_TRANSFER_USER_STRIDE

On 26.04.2018 04:30, Marek Olšák wrote: On Wed, Apr 25, 2018 at 6:56 PM, Gurchetan Singh > wrote: On Wed, Apr 25, 2018 at 2:16 PM, Marek Olšák > wrote: > From: Nicolai Hähnle

Re: [Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

As discussed offline, this is similar to commit 1ea233c. LGTM; Reviewed-by: Tapani Pälli On 04/27/2018 05:17 AM, Min He wrote: To avoid blocking other EGL calls, release the display mutex before calling update_buffers(), which will call droid_window_dequeue_buffer().

[Mesa-dev] [PATCH] radv: compute the number of subpass attachments correctly

Only count color attachments twice if resolves are used, also account for the depth stencil attachment if present. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2] ac/nir: set lod to 0 for ac_image_load_mip

On 27.04.2018 10:05, Samuel Pitoiset wrote: On 04/26/2018 01:51 PM, Nicolai Hähnle wrote: Is there any reason why we can't just use ac_image_load in such cases? For nit_texop_txf_ms we need one more coordinate for the sample index, if we use ac_image_load we only loads 2 coordinates instead

[Mesa-dev] [Bug 106246] radv: VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT and bringing down initial pipeline compile times

https://bugs.freedesktop.org/show_bug.cgi?id=106246 --- Comment #3 from Nicolai Hähnle --- As long as scratch buffer support is robust, removing LLVM IR optimization passes is probably not a problem, though you really do want mem2reg and I don't think we spend much time in

Re: [Mesa-dev] [PATCH] util/u_queue: fix a deadlock in util_queue_finish

Nice catch! Reviewed-by: Nicolai Hähnle On 24.04.2018 23:06, Marek Olšák wrote: From: Marek Olšák Cc: 18.0 18.1 --- src/util/u_queue.c | 9 + src/util/u_queue.h | 1 + 2 files changed, 10

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] travis: update libva required version

On Thu, 2018-04-26 at 18:07 +0100, Emil Velikov wrote: > On 25 April 2018 at 14:44, Juan A. Suarez Romero wrote: > > On Wed, 2018-04-25 at 13:54 +0100, Emil Velikov wrote: > > > On 24 April 2018 at 08:49, Juan A. Suarez Romero > > > wrote: > > > > On

Re: [Mesa-dev] [PATCH 1/7] ac/surface: handle DCC subresource fast clear restriction on VI

Sorry, but I still don't understand the logic of this :/ What we want to check for is that all the DCC bytes of a mip-level are contiguous, right? Why does it matter for that whether a level is the last level? Here's the thought experiment that I can't make sense of: Let's say that you have

Re: [Mesa-dev] [PATCH v2] ac/nir: set lod to 0 for ac_image_load_mip

On 04/26/2018 01:51 PM, Nicolai Hähnle wrote: Is there any reason why we can't just use ac_image_load in such cases? For nit_texop_txf_ms we need one more coordinate for the sample index, if we use ac_image_load we only loads 2 coordinates instead of 4 with ac_image_load_mip. Though, I

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

As said by Emil, this may be the case in some others scripts. In any case, this is: Reviewed-by: Andres Gomez On Thu, 2018-04-26 at 10:45 -0700, Dylan Baker wrote: > I have pretty default to short, which breaks this script. > > cc: Emil Velikov

Re: [Mesa-dev] [PATCH] bin: force git show to use default pretty setting

On Thu, 2018-04-26 at 11:06 -0700, Dylan Baker wrote: > Quoting Emil Velikov (2018-04-26 11:04:01) > > On 26 April 2018 at 18:45, Dylan Baker wrote: > > > I have pretty default to short, which breaks this script. > > > > > > > Out of curiosity: why would you do this to

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-27 1:34 GMT+08:00 Rob Herring : > On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov > wrote: >> On 26 April 2018 at 03:30, Chih-Wei Huang wrote: >>> 2018-04-25 19:55 GMT+08:00 Robert Foss : Hey

[Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

To avoid blocking other EGL calls, release the display mutex before calling update_buffers(), which will call droid_window_dequeue_buffer(). The lock appears like below: 1. Consumer thread: updateTexImage() -> updateAndReleaseLocked() -> syncForReleaseLocked() -> eglDupNativeFenceFDANDROID() ->

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-27 2:19 GMT+08:00 Robert Foss : > > I've spent some time today preparing a #ifdef version of what robher > submitted. > > It's fine, but there is no way automatically enable the HAVE_DRM_GRALLOC > #define through the build tools. So a small simple patch adding

Re: [Mesa-dev] [PATCH v2] ac: fix texture query LOD for 1D textures on GFX9

Nicolai, how about this v2? I would like to have this fix in -rc2. On 04/25/2018 06:15 PM, Samuel Pitoiset wrote: 1D textures are allocated as 2D which means we only need one coordinate for texture query LOD. v2: - move the fixup into ac_nir_to_llvm Fixes: 625dcbbc456 ("amd/common: pass

Re: [Mesa-dev] [PATCH v2] dri3: Prevent multiple freeing of buffers.

Hello, Michel On 2018-04-10 09:44 AM, Sergii Romantsov wrote: > Commit 3160cb86aa92 adds optimization with flag 'reallocate'. > Processing of flag causes buffers freeing while pointer > is still hold in caller stack and than again used to be freed. > > Fixes: 3160cb86aa92 "egl/x11: Re-allocate

Re: [Mesa-dev] [PATCH] mesa: add TBO support for GL_EXT_texture_norm16

On Thursday, April 26, 2018 11:52:33 PM PDT Tapani Pälli wrote: > Earlier plumbing missed interaction with texture buffer objects. > > Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" > Signed-off-by: Tapani Pälli > --- > src/mesa/main/teximage.c | 6

[Mesa-dev] [PATCH v3] dri3: Prevent multiple freeing of buffers.

Commit 3160cb86aa92 adds optimization with flag 'reallocate'. Processing of flag causes buffers freeing while pointer is still hold in caller stack and than again used to be freed. Fixes: 3160cb86aa92 "egl/x11: Re-allocate buffers if format is suboptimal" v2: used flag 'busy' instead of

Re: [Mesa-dev] [PATCH 2/2] Replace deperacated include header "cutils/log.h" to "log/log.h" from Android 8

LGTM Reviewed-by: Tapani Pälli On 04/27/2018 05:11 AM, jenny.q.cao wrote: There is a compile warning from Android 8 (API version 26) from "include cutils/log.h" warning: "Deprecated: don't include cutils/log.h, use either android/log.h or log/log.h"-W#warnings,

[Mesa-dev] [PATCH] mesa: add TBO support for GL_EXT_texture_norm16

Earlier plumbing missed interaction with texture buffer objects. Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" Signed-off-by: Tapani Pälli --- src/mesa/main/teximage.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git