Re: [Mesa-dev] [PATCH 1/2] anv/android: Fix Autotools build for VK_ANDROID_native_buffer

series is Reviewed-by: Tapani Pälli On 06/28/2018 06:40 AM, Chad Versace wrote: Changes to vk.xml and anv_entrypoints_gen.py broke the Autotools build on Android. The changes undef'd the VK_ANDROID_native_buffer entrypoints in anv_entrypoints.h. Fix it with CPPFLAGS +=

Re: [Mesa-dev] [PATCH 03/10] glsl: don't let an 'if' then-branch kill copy propagation for else-branch

On 06/27/2018 06:18 PM, Caio Marcelo de Oliveira Filho wrote: > When handling 'if' in copy propagation, if a certain variable was > killed when processing the first branch of the 'if', then the second > would get any propagation from previous nodes. > > x = y; > if (...) { > z =

[Mesa-dev] [PATCH 06/12] nir/opt_peephole_select: Don't try to remove flow control around indirect loads

From: Ian Romanick That flow control may be trying to avoid invalid loads. On at least some platforms, those loads can also be expensive. No shader-db changes on any Intel platform (even with the later patch "intel/compiler: More peephole select"). NOTE: I've tried to CC everyone whose drive

[Mesa-dev] [PATCH 12/12] intel/compiler: Use partial redundancy elimination for compares

From: Ian Romanick Almost all of the hurt shaders are repeated instances of the same shader in synmark's compilation speed tests. shader-db results: All Gen7+ platforms had similar results. (Haswell shown) total instructions in shared programs: 12944679 -> 12943956 (<.01%) instructions in

[Mesa-dev] [PATCH 09/12] nir: Add nir_const_value_negative_equal

From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/nir/meson.build| 12 + src/compiler/nir/nir.h | 6 + src/compiler/nir/nir_instr_set.c| 98 + src/compiler/nir/tests/negative_equal_tests.cpp | 278

[Mesa-dev] [PATCH 04/12] i965/vec4: Clamp indirect tes input array reads with 0x0fffffff

From: Ian Romanick Page 190 of "Volume 7: 3D Media GPGPU Engine (Haswell)" says the valid range of the offset is [0, 0FFFh]. Signed-off-by: Ian Romanick Cc: mesa-stab...@lists.freedesktop.org --- src/intel/compiler/brw_vec4_tes.cpp | 12 +++- 1 file changed, 11 insertions(+), 1

[Mesa-dev] [PATCH 00/12] Fixes and partial redundancy elimination for compares

This is mostly a resend of an earlier series. After I sent out the original series I noticed that it uncovered a couple pre-existing bugs. Patches 2, 3, and 4 are new, and they address these bugs. Patches 5 and 6 are also new. These patches prevent nir_opt_peephole_select from removing flow

[Mesa-dev] [PATCH 10/12] nir: Add nir_alu_srcs_negative_equal

From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/nir/nir.h | 4 + src/compiler/nir/nir_instr_set.c| 103 src/compiler/nir/tests/negative_equal_tests.cpp | 84 +++ 3 files changed, 191

[Mesa-dev] [PATCH 05/12] nir: Make deref_has_indirect public

From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_io_arrays_to_elements.c | 11 ++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h

[Mesa-dev] [PATCH 08/12] nir: Add helper functions to get the instruction that generated a nir_src

From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/nir/nir.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index f05c51197ac..3065fff263c 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h

[Mesa-dev] [PATCH 07/12] intel/compiler: More peephole select

From: Ian Romanick Shader-db results: The one shader hurt for instructions is a compute shader that had both spills and fills hurt. The other shader that had spill hurt also had fills helped by more. Skylake, Broadwell, and Haswell had similar results. (Skylake shown) total instructions in

[Mesa-dev] [PATCH 02/12] i965/vec4: Don't cmod propagate from CMP to ADD if the writemask isn't compatible

From: Ian Romanick Otherwise we can incorrectly cmod propagate in situations like add(8) g10<1>.xD g2<0>.xD-16D ... cmp.ge.f0(8)null<1>Dg2<0>.xD16D ... (+f0) sel(8)g21<1>.xyUD g14<4>.xyyyUD g18<4>.xyyyUD Sadly, this

[Mesa-dev] [PATCH 11/12] nir: Add partial redundancy elimination for compares

From: Ian Romanick This pass attempts to dectect code sequences like if (x < y) { z = y - z; ... } and replace them with sequences like t = x - y; if (t < 0) { z = t; ... } On architectures where the subtract can generate the flags used by

[Mesa-dev] [PATCH 01/12] intel/compiler: Silence unused parameter warnings brw_nir.c

From: Ian Romanick src/intel/compiler/brw_nir.c: In function ‘brw_nir_lower_vue_outputs’: src/intel/compiler/brw_nir.c:464:32: warning: unused parameter ‘is_scalar’ [-Wunused-parameter] bool is_scalar) ^

[Mesa-dev] [PATCH 03/12] i965/vec4: Correctly handle uniform sources in generate_tes_add_indirect_urb_offset

From: Ian Romanick Fixes failure in the new piglit test tes-patch-input-array-vec2-index-invalid-rd.shader_test. Signed-off-by: Ian Romanick Cc: mesa-stab...@lists.freedesktop.org --- src/intel/compiler/brw_vec4_generator.cpp | 15 ++- 1 file changed, 14 insertions(+), 1

[Mesa-dev] [PATCH 2/2] anv/android: Fix type error in call to vk_errorf()

In a single call to vk_errorf() in the Android code, the arguments were swapped. The bug has existed since day one. Chrome OS used to forgive the warning, but it is now a compilation error. Fixes: 053d4c32 "anv: Implement VK_ANDROID_native_buffer (v9)" Cc: Tapani Pälli Cc: Tomasz Figa ---

[Mesa-dev] [PATCH 1/2] anv/android: Fix Autotools build for VK_ANDROID_native_buffer

Changes to vk.xml and anv_entrypoints_gen.py broke the Autotools build on Android. The changes undef'd the VK_ANDROID_native_buffer entrypoints in anv_entrypoints.h. Fix it with CPPFLAGS += -DVK_USE_PLATFORM_ANDROID_KHR. See-Also: 63525ba7 "android: enable VK_ANDROID_native_buffer" Cc: Tapani

Re: [Mesa-dev] [PATCH v2 2/2] i965: Implement ARB_compute_variable_group_size.

Hi, if the changes inside "src/compiler/nir/nir_lower_system_values.c" are extracted into a seperate patch, this patch with the equal changes would be Reviewed-by: Karol Herbst I would need that for a nir to codegen pass for Nouveau and maybe it will help other drivers implementing this

[Mesa-dev] [Bug 106996] Compute shader compiling fails for invalid input layout qualifier used

https://bugs.freedesktop.org/show_bug.cgi?id=106996 Yunchao He changed: What|Removed |Added CC||yunchao...@intel.com -- You are

[Mesa-dev] [PATCH] anv: Restrict the nuber of color regions to those actually written

The back-end compiler emits the number of color writes specified by wm_prog_key::nr_color_regions regardless of what nir_store_outputs we have. Once we've gone through and figured out which render targets actually exist and are written by the shader, we should restrict the key to avoid extra RT

Re: [Mesa-dev] [PATCH] gallium: Fix automake for Android

On Thu, Jun 28, 2018 at 4:50 AM Chad Versace wrote: > > > Chromium OS uses Autotools and pkg-config when building Mesa for > Android. The gallium drivers were failing to find the headers and > libraries for zlib and Android's libbacktrace. > > v2: > - Don't add a check for zlib.pc. configure.ac

[Mesa-dev] [PATCH] spirv: Implicitly set missing NonWriteable decoration

This works around rendering issues in Skyrim caused by DXVK missing a decoration. --- src/compiler/spirv/vtn_variables.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index

[Mesa-dev] [PATCH 02/10] glsl: do second pass of const propagation in loops

When handling loops in constant propagation, implement the "FINISHME" comment like copy propagation: perform a first pass to find values that can't be propagated, then perform a second pass with the ACP containing still valid values. Certain values are killed because the loop may run more than

[Mesa-dev] [RFC 10/10] glsl: use only copy_propagation_elements

Now that the elements version handles both cases, remove the non-elements version. --- src/compiler/Makefile.sources | 1 - src/compiler/glsl/glsl_parser_extras.cpp | 1 - src/compiler/glsl/ir_optimization.h| 1 - src/compiler/glsl/meson.build | 1 -

[Mesa-dev] [RFC 09/10] glsl: teach copy_propagation_elements to deal with whole variables

Keep information in acp_entry whether the entry is full or not, and use the ACP in more nodes when visiting the instructions: - add_copy: write whole variables to the ACP state (regardless the type). - visit(ir_dereference_variable *): perform the propagation here if we have a full

[Mesa-dev] [PATCH 06/10] util/set: helper to remove entry by key

--- src/util/set.c | 9 + src/util/set.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/src/util/set.c b/src/util/set.c index b2aa5ba13d5..feef96d16ea 100644 --- a/src/util/set.c +++ b/src/util/set.c @@ -383,6 +383,15 @@ _mesa_set_remove(struct set *ht, struct set_entry *entry)

[Mesa-dev] [PATCH 07/10] glsl: change opt_copy_propagation_elements data structures

Instead of keeping multiple acp_entries in lists, have a single acp_entry per variable. With this, the implementation of clone is more convenient and now fully implemented. In the previous code, clone was only partial. Before this patch, each acp_entry struct represented a write to a variable

[Mesa-dev] [PATCH 00/10] GLSL Copy Propagation

This series contains improvements to GLSL copy (and constant) propagation. In most cases the numbers do not change (at least in the Intel configurations I've tested) because the NIR passes pick up the slack. It all started with the patches "don't let an 'if' ...", which are about cases like

[Mesa-dev] [PATCH 04/10] glsl: separate copy propagation state

Separate higher level logic of visiting instructions and chosing when to store and use new copy data from the datastructure holding the copy propagation information. This will also make easier later patches that change the structure. --- .../glsl/opt_copy_propagation_elements.cpp| 269

[Mesa-dev] [PATCH 03/10] glsl: don't let an 'if' then-branch kill copy propagation for else-branch

When handling 'if' in copy propagation, if a certain variable was killed when processing the first branch of the 'if', then the second would get any propagation from previous nodes. x = y; if (...) { z = x; // This would turn into z = y. x = 22; // x gets killed. }

[Mesa-dev] [PATCH 08/10] glsl: don't let an 'if' then-branch kill copy propagation (elements) for else-branch

When handling 'if' in copy propagation elements, if a certain variable was killed when processing the first branch of the 'if', then the second would get any propagation from previous nodes. x = y; if (...) { z = x; // This would turn into z = y. x = 22; // x gets killed.

[Mesa-dev] [PATCH 01/10] glsl: don't let an 'if' then-branch kill const propagation for else-branch

When handling 'if' in constant propagation, if a certain variable was killed when processing the first branch of the 'if', then the second would get any propagation from previous nodes. This is similar to the change done for copy propagation code. x = 1; if (...) { z = x; // This

[Mesa-dev] [PATCH 05/10] util/set: add a clone function

--- src/util/set.c | 23 +++ src/util/set.h | 3 +++ 2 files changed, 26 insertions(+) diff --git a/src/util/set.c b/src/util/set.c index 2c9b09319ff..b2aa5ba13d5 100644 --- a/src/util/set.c +++ b/src/util/set.c @@ -34,6 +34,7 @@ #include #include +#include

Re: [Mesa-dev] [PATCH 2/2] intel/blorp: Take an explicit filter parameter in blorp_blit

On Tue 26 Jun 2018, Jason Ekstrand wrote: > This lets us move the glBlitFramebuffer nonsense into the GL driver and > make the usage of BLORP mutch more explicit and obvious as to what it's > doing. > --- > src/intel/blorp/blorp.h | 3 +- > src/intel/blorp/blorp_blit.c |

Re: [Mesa-dev] [PATCH 1/2] intel/blorp: Add a blorp_filter enum for use in blorp_blit

On Tue 26 Jun 2018, Jason Ekstrand wrote: > At the moment, this is entirely internal but we'll expose it to clients > of the BLORP API in the next commit. > --- > src/intel/blorp/blorp.h | 8 ++ > src/intel/blorp/blorp_blit.c | 212 +++ >

[Mesa-dev] [PATCH v2 11/11] mesa: add missing display list support for ARB_compute_shader

The extension is enabled for compat profile but there is currently no display list support. I filed a spec bug and it has been agreed that glDispatchComputeIndirect should generate an INVALID_OPERATION error when called during display list compilation. --- v2: Generate an error for

Re: [Mesa-dev] [PATCH] glsl: skip comparison opt when adding vars of different size

The funny thing is that I just encountered a somewhat similar bug in the i965 vec4 backend. :) The ability to mix sizes like that in the IR was a mistake. We should have added swizzles to code like this so that the types would match. Alas. This patch is Reviewed-by: Ian Romanick On

Re: [Mesa-dev] [PATCH] glsl: skip comparison opt when adding vars of different size

On 28/06/18 09:23, Timothy Arceri wrote: The spec allows adding scalars a vector or matrix. In this case the opt was losing any swizzle or size information. This fixes a bug with Doom (2016) shaders. Forgot to add: Fixes: 34ec1a24d61f ("glsl: Optimize (x + y cmp 0) into (x cmp -y).") ---

Re: [Mesa-dev] [PATCH 11/11] ac/radv: using tls to store llvm related info and speed up compiles (v3)

On Wed, Jun 27, 2018 at 5:58 AM, Dave Airlie wrote: > From: Dave Airlie > > I'd like to encourage people to test this to see if it helps (like > does it make app startup better or less hitching in dxvk). > > The basic idea is to store a bunch of LLVM related data structs > in thread local

[Mesa-dev] [PATCH] glsl: skip comparison opt when adding vars of different size

The spec allows adding scalars a vector or matrix. In this case the opt was losing any swizzle or size information. This fixes a bug with Doom (2016) shaders. --- src/compiler/glsl/opt_algebraic.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compiler/glsl/opt_algebraic.cpp

[Mesa-dev] [Bug 106915] [GLSL] Unused arrays declared without a size should be handled like arrays of size 1.

https://bugs.freedesktop.org/show_bug.cgi?id=106915 --- Comment #11 from Ian Romanick --- (In reply to Jason Ekstrand from comment #3) > I really hate it, but I fear they may be allowed. From the GLSL 4.60 spec > in the section on UBO and SSBO layouts: > > > The shared qualifier overrides only

[Mesa-dev] [Bug 105139] Assertion in Dying Light

https://bugs.freedesktop.org/show_bug.cgi?id=105139 Mike Lothian changed: What|Removed |Added CC||m...@fireburn.co.uk --- Comment #6 from

Re: [Mesa-dev] [PATCH 1/2] mesa : MESA_framebuffer_flip_y extension

On Wed 27 Jun 2018, Chad Versace wrote: > On Fri 15 Jun 2018, Fritz Koenig wrote: > > On Tue, Jun 12, 2018 at 12:28 PM Chad Versace > > wrote: > > > > > > On Thu 07 Jun 2018, Fritz Koenig wrote: > > > > > --- a/src/mesa/main/extensions_table.h > > > > +++ b/src/mesa/main/extensions_table.h > >

Re: [Mesa-dev] [virglrenderer-devel] [PATCH] virgl/vtest: add support to vtest for new cap getting.

On 28 June 2018 at 03:25, Jakob Bornecrantz wrote: > On 2018-06-08 07:22, Dave Airlie wrote: >> >> From: Dave Airlie >> >> The vtest protocol is pretty simple but also pretty dumb, and >> the v1 caps query was fixed size, with no nice way to expand it, >> however the server also ignores any

Re: [Mesa-dev] [PATCH 1/2] mesa : MESA_framebuffer_flip_y extension

On Fri 15 Jun 2018, Fritz Koenig wrote: > On Tue, Jun 12, 2018 at 12:28 PM Chad Versace > wrote: > > > > On Thu 07 Jun 2018, Fritz Koenig wrote: > > > --- a/src/mesa/main/extensions_table.h > > > +++ b/src/mesa/main/extensions_table.h > > > @@ -322,6 +322,7 @@

[Mesa-dev] [Bug 105139] Assertion in Dying Light

https://bugs.freedesktop.org/show_bug.cgi?id=105139 Grazvydas Ignotas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #5 from Grazvydas

Re: [Mesa-dev] [PATCH v3 1/2] wayland/egl: initialize window surface size to window size

On Wednesday, 2018-06-06 10:41:31 +, Juan A. Suarez Romero wrote: > When creating a windows surface with eglCreateWindowSurface(), the > width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is > invalid until buffers are updated (like calling glClear()). > > But according to EGL

Re: [Mesa-dev] [PATCH] gallium/util: remove dummy function util_format_is_supported

On Wednesday, 2018-06-27 20:12:03 +, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/auxiliary/util/u_format.c | 13 - > src/gallium/auxiliary/util/u_format.h | 7 --- > src/gallium/drivers/freedreno/a2xx/fd2_screen.c | 3 +-- >

Re: [Mesa-dev] [PATCH] radv: add padding for the UMR disassembler

Reviewed-by: Bas Nieuwenhuizen On Wed, Jun 27, 2018 at 10:39 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_shader.c | 20 ++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_shader.c

[Mesa-dev] [PATCH] gallium/util: remove dummy function util_format_is_supported

From: Marek Olšák --- src/gallium/auxiliary/util/u_format.c | 13 - src/gallium/auxiliary/util/u_format.h | 7 --- src/gallium/drivers/freedreno/a2xx/fd2_screen.c | 3 +-- src/gallium/drivers/freedreno/a3xx/fd3_screen.c | 3 +--

[Mesa-dev] [PATCH 3/3] winsys/amdgpu: remove RADEON_SURF_FMASK leftover

From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_surface.c b/src/gallium/winsys/amdgpu/drm/amdgpu_surface.c index d5fa37bb6d9..eaf10349355 100644 ---

[Mesa-dev] [PATCH 2/3] radeonsi: enable vertex color clamping for tess and GS

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 10 +- src/gallium/drivers/radeonsi/si_shader.c | 97 +-- src/gallium/drivers/radeonsi/si_shader.h | 2 +- src/gallium/drivers/radeonsi/si_state_draw.c | 11 +++ 4 files changed, 87 insertions(+),

[Mesa-dev] [PATCH 1/3] radeonsi: move VS_STATE_SGPR before draw SGPRs

From: Marek Olšák for vertex color clamping. --- src/gallium/drivers/radeonsi/si_shader.c | 14 +++--- src/gallium/drivers/radeonsi/si_shader.h | 9 ++--- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [ANNOUNCE] mesa 18.1.3

Hi list, Mesa 18.1.3 is planned for Friday June 29th, at 10AM PDT. Statistics for this release: - 37 queued - 0 nominated - 2 rejected All rejected patches have already had author follow-ups. In the mesa repo, the branch "staging/18.1" in the mesa gitlab will (unless bugs are found) be

[Mesa-dev] [PATCH 0/3] vulkan: Define new VK_MESA_query_timestamp extension [v3]

Jason Ekstrand writes: > I haven't thought through this comment all that hard but would it make > sense to have three timestamps, CPU, GPU, CPU so that you have error bars > on the GPU timestamp? At the very least, two timestamps would be better > than one so that, when we pull it into the

[Mesa-dev] [PATCH mesa 1/3] vulkan: Define new VK_MESA_query_timestamp extension [v3]

This extension adds a single function to query the current GPU timestamp, just like glGetInteger64v(GL_TIMESTAMP, ). This function is needed to complete the implementation of GOOGLE_display_timing, which needs to be able to correlate GPU and CPU timestamps. v2: Adopt Jason Ekstrand's coding

[Mesa-dev] [PATCH mesa 2/3] anv: Add new VK_MESA_query_timestamp extension to anv driver [v3]

This extension adds a single function to query the current GPU timestamp, just like glGetInteger64v(GL_TIMESTAMP, ). This function is needed to complete the implementation of GOOGLE_display_timing, which needs to be able to correlate GPU and CPU timestamps. v2: Adopt Jason Ekstrand's coding

[Mesa-dev] [PATCH mesa 3/3] radv: Add new VK_MESA_query_timestamp extension to radv driver [v2]

This extension adds a single function to query the current GPU timestamp, just like glGetInteger64v(GL_TIMESTAMP, ). This function is needed to complete the implementation of GOOGLE_display_timing, which needs to be able to correlate GPU and CPU timestamps. Signed-off-by: Keith Packard v2:

[Mesa-dev] [PATCH] gallium: Fix automake for Android

Chromium OS uses Autotools and pkg-config when building Mesa for Android. The gallium drivers were failing to find the headers and libraries for zlib and Android's libbacktrace. v2: - Don't add a check for zlib.pc. configure.ac already checks for zlib.pc elsewhere. [for tfiga] - Check

[Mesa-dev] [PATCH 2/2] egl: set EGL_BAD_NATIVE_PIXMAP in the copy_buffers fallback

From: Emil Velikov As the spec says: EGL_BAD_NATIVE_PIXMAP is generated if the implementation does not support native pixmaps. Signed-off-by: Emil Velikov --- Strictly speaking all the other fallback functions should also set an _eglError, although that's outside of the current scope :-)

[Mesa-dev] [PATCH 1/2] egl/x11: use the no-op dri2_fallback_copy_buffers for swrast

From: Emil Velikov Currently dri2_copy_buffers is used for swrast, which depends on the DRI2_FLUSH extension. Since that's not a thing on software based drivers we crash out. Do the slightly more graceful, thing of returning EGL_FALSE. Signed-off-by: Emil Velikov ---

Re: [Mesa-dev] [PATCH 5/5] anv/image: Support CCS_E for images which may be used for storage

On Tue, Feb 20, 2018 at 05:33:23PM -0800, Jason Ekstrand wrote: > Nanley, > > At your request, I did a little fact-finding. I ran all the Sascha demos, > and only one of them ever hits this resolve: computeshader. The demo only > hits it once for the entire run probably because it does >

Re: [Mesa-dev] RFC about anv change that should be applicable to radv

Hi, Il giorno mer 27 giu 2018 alle ore 10:41 Tapani Pälli < tapani.pa...@intel.com> ha scritto: > Hi; > > On 06/13/2018 09:32 AM, Mauro Rossi wrote: > > +Samuel Pitoiset > > > > > > 2018-06-11 22:31 GMT+02:00 Mauro Rossi > >: > > > > Hi Bas, > > > > commit

Re: [Mesa-dev] [virglrenderer-devel] [PATCH] virgl/vtest: add support to vtest for new cap getting.

On 2018-06-08 07:22, Dave Airlie wrote: From: Dave Airlie The vtest protocol is pretty simple but also pretty dumb, and the v1 caps query was fixed size, with no nice way to expand it, however the server also ignores any command it doesn't understand. So we can query v2 caps by sending a v2

[Mesa-dev] [Bug 102522] [radeonsi, bisected] commit 147d7fb772 causes full-window map to flash green in Crea

https://bugs.freedesktop.org/show_bug.cgi?id=102522 --- Comment #5 from Kaelyn T --- Created attachment 140368 --> https://bugs.freedesktop.org/attachment.cgi?id=140368=edit Crea screenshot showing visual corruption -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 102522] [radeonsi, bisected] commit 147d7fb772 causes full-window map to flash green in Crea

https://bugs.freedesktop.org/show_bug.cgi?id=102522 --- Comment #4 from Kaelyn T --- I just replayed the trace I had created while running the 4.17.1 kernel, xorg-server 1.20, LLVM git 78d083b, and Mesa git a6b64d6dde, and I still see the same green flashing/cross-hatching. I've attached a

Re: [Mesa-dev] [PATCH mesa] vulkan/wsi_common_display: Return SURFACE_LOST for fatal DRM errors

Sounds fine to me. I just wanted to confirm that they are unrecoverable. Reviewed-by: Jason Ekstrand On Wed, Jun 27, 2018 at 9:13 AM, Keith Packard wrote: > Jason Ekstrand writes: > > > Is this the same thing that happens on VT switch? If so, we may want to > > return SURFACE_LOST for

Re: [Mesa-dev] [PATCH mesa] vulkan/wsi_common_display: Return SURFACE_LOST for fatal DRM errors

Jason Ekstrand writes: > Is this the same thing that happens on VT switch? If so, we may want to > return SURFACE_LOST for leases and OUT_OF_DATE for things running directly > on the display. No, on VT switch, my code currently sits in the driver and waits for the VT to return. The errors here

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: emit binding tables always if push constants are dirty

On Wed, Jun 27, 2018 at 2:25 AM, Iago Toral wrote: > On Tue, 2018-06-26 at 10:59 -0700, Jason Ekstrand wrote: > > On Tue, Jun 26, 2018 at 4:08 AM, Iago Toral Quiroga > wrote: > > Storage images require to patch push constant stateto work, which happens > during > binding table emision. In the

Re: [Mesa-dev] [PATCH mesa] vulkan/wsi_common_display: Return SURFACE_LOST for fatal DRM errors

Is this the same thing that happens on VT switch? If so, we may want to return SURFACE_LOST for leases and OUT_OF_DATE for things running directly on the display. --Jason On Tue, Jun 26, 2018 at 4:23 PM, Keith Packard wrote: > Instead of encouraging the client to re-create the swapchain and

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

Quoting Emil Velikov (2018-06-27 01:39:05) > On 26 June 2018 at 16:34, Dylan Baker wrote: > > > I just remembered that you can set two push remotes for a single branch, so > > I > > think I'll add a staging/18.1 branch to master as a second remote and push > > to > > that as well. Do you like

[Mesa-dev] [PATCH] i965: Fix allow_higher_compat_version workaround limited by OpenGL 3.0

The workaround was designed to allow setting of 3.1+ compatibility profiles but checks if current api is not API_OPENGL_COMPAT were introduced later in order to enable certain extensions that were enabled unconditionally before. These extensions are required for profiles higher than 3.0 which

Re: [Mesa-dev] [PATCH] travis: use https for all the links

On 25 June 2018 at 20:53, Eric Engestrom wrote: > On Monday, 2018-06-25 11:03:04 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Signed-off-by: Emil Velikov > > Good idea :) > > Reviewed-by: Eric Engestrom > One small step toward https everywhere ;-) Thanks Emil

[Mesa-dev] [PATCH 3/3] intel/compiler: Relax mixed type restriction for saturating immediates

From: Ian Romanick At the time of commit 7bc6e455e23 (i965: Add support for saturating immediates.) we thought mixed type saturates would be impossible. We were only thinking about type converting moves from D to F, for example. However, type converting moves w/saturate from F to DF are

[Mesa-dev] [PATCH 1/3] i965/fs: Properly handle sign(-abs(x))

From: Ian Romanick Fixes new piglit tests: - glsl-1.10/execution/fs-sign-neg-abs.shader_test - glsl-1.10/execution/fs-sign-sat-neg-abs.shader_test - glsl-1.10/execution/vs-sign-neg-abs.shader_test - glsl-1.10/execution/vs-sign-sat-neg-abs.shader_test Signed-off-by: Ian Romanick Cc:

[Mesa-dev] [PATCH 2/3] i965/vec4: Properly handle sign(-abs(x))

From: Ian Romanick This is achived by copying the sign(abs(x)) optimization from the FS backend. On Gen7 an earlier platforms, this fixes new piglit tests: - glsl-1.10/execution/vs-sign-neg-abs.shader_test - glsl-1.10/execution/vs-sign-sat-neg-abs.shader_test Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

On Tue, Jun 26, 2018 at 7:00 PM, Drew Davenport wrote: > This change lets the following test pass on virgl: > dEQP-GLES31.functional.state_query.framebuffer_default.framebuffer_default_samples_get_framebuffer_parameteriv > --- > src/gallium/drivers/virgl/virgl_screen.c | 4 > 1 file

Re: [Mesa-dev] [PATCH 3/4] glsl/glcpp/tests: reinstate srcdir/abs_builddir blurb

On 26 June 2018 at 16:31, Dylan Baker wrote: > Quoting Emil Velikov (2018-06-26 06:19:08) >> On 21 June 2018 at 16:15, Dylan Baker wrote: >> > Quoting Emil Velikov (2018-04-24 10:49:21) >> >> From: Emil Velikov >> >> >> >> Bring back the "detection" of the said variables, to allow >> >>

[Mesa-dev] [PATCH] radv: optimize radv_CmdWaitEvents()

This introduces radv_barrier() (same as the draw/dispatch codepath). This helper is used for merging the code from CmdWaitEvents() and CmdPipelineBarrier because it's quite similar. We do ignore the source stage mask for CmdWaitEvents because it's irrelevant when event objects are used.

[Mesa-dev] Make the output of the Python build scripts more reproducible

I ported the Mesa build system to Python 3. The result of this work can be seen on my fork: https://gitlab.freedesktop.org/bochecha/mesa/tree/python3 When porting, I tried to ensure that the generated files are identical to the ones generated by a build on master. This was made difficult by

[Mesa-dev] [PATCH 2/2] build: Specify the JSON separators

On Python 2, the default JSON separators are ', ' for items and ': ' for dicts. On Python 3, the default is the same when no indent is specified, but if one is (and we do specify one) then the default items separator becomes ',' (the dict separator remains unchanged). This change explicitly

[Mesa-dev] [PATCH 1/2] build: Stabilize some script outputs

In Python, dictionaries and sets are unordered, and as a result their is no guarantee that running this script twice will produce the same output. Using ordered dicts and explicitly sorting items makes the build more reproducible, and will make it possible to verify that we're not breaking

[Mesa-dev] [Bug 105139] Assertion in Dying Light

https://bugs.freedesktop.org/show_bug.cgi?id=105139 Denis changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #4 from Denis --- hi. Is

Re: [Mesa-dev] [PATCH 4/8] radv: add all dependencies from external to the first subpass

On Wed, Jun 27, 2018 at 9:46 AM, Samuel Pitoiset wrote: > > > On 06/27/2018 02:12 AM, Bas Nieuwenhuizen wrote: >> >> Reviewed-by: Bas Nieuwenhuizen >> >> for patch 3-4. Not sure they should go to stable though, since they >> are optimizations? > > > Isn't the whole series for optimization

[Mesa-dev] [Bug 106986] glGetQueryiv error when querying number of result bits for GL_ANY_SAMPLES_PASSED_CONSERVATIVE

https://bugs.freedesktop.org/show_bug.cgi?id=106986 Tapani Pälli changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: emit binding tables always if push constants are dirty

On Tue, 2018-06-26 at 10:59 -0700, Jason Ekstrand wrote: > On Tue, Jun 26, 2018 at 4:08 AM, Iago Toral Quiroga m> wrote: > > Storage images require to patch push constant stateto work, which > > happens during > > > > binding table emision. In the scenario where our pipeline and > > descriptors

Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

On 27 June 2018 at 09:55, Emil Velikov wrote: > Hi Drew, > > Just some food for thought. The patch in itself looks correct albeit partial. > > On 27 June 2018 at 00:00, Drew Davenport wrote: >> This change lets the following test pass on virgl: >>

Re: [Mesa-dev] [PATCH] virgl: Support ARB_framebuffer_no_attachments

Hi Drew, Just some food for thought. The patch in itself looks correct albeit partial. On 27 June 2018 at 00:00, Drew Davenport wrote: > This change lets the following test pass on virgl: >

Re: [Mesa-dev] RFC about anv change that should be applicable to radv

Hi; On 06/13/2018 09:32 AM, Mauro Rossi wrote: +Samuel Pitoiset 2018-06-11 22:31 GMT+02:00 Mauro Rossi >: Hi Bas, commit [1] removed a check on 'supported' attribute in src/intel/vulkan/anv_entrypoints_gen.py Should the check on 'supported'

[Mesa-dev] [PATCH] radv: add padding for the UMR disassembler

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index c7ffd47c0b8..9470c4907c2 100644 --- a/src/amd/vulkan/radv_shader.c +++

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

On 26 June 2018 at 16:34, Dylan Baker wrote: > I just remembered that you can set two push remotes for a single branch, so I > think I'll add a staging/18.1 branch to master as a second remote and push to > that as well. Do you like that name, or would you prefer something different? > My

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO

https://bugs.freedesktop.org/show_bug.cgi?id=104553 --- Comment #11 from florian.w...@googlemail.com --- > And now totally off-topic, but probably it is worth to mention here to not > forget: VK-GL-CTS doesn't catch this problem either. And they have tons of > row_major tests, for example: >

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO & SSBO

https://bugs.freedesktop.org/show_bug.cgi?id=104553 florian.w...@googlemail.com changed: What|Removed |Added Summary|mat4: m[i][j] incorrect |mat4: m[i][j] incorrect

Re: [Mesa-dev] [PATCH v2] mesa: enable EXT_render_snorm extension

ping On 06/15/2018 08:11 AM, Tapani Pälli wrote: Patch sets additional formats renderable and enables the extension when OpenGL ES 3.1 is supported. v2: instead of dummy_true, have a separate toggle for extension (Eric Anholt) Signed-off-by: Tapani Pälli ---

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 5.0

On 2018-06-26 10:49 PM, Marek Olšák wrote: > On Tue, Jun 26, 2018 at 12:47 PM, Michel Dänzer wrote: >> On 2018-06-26 06:37 PM, Marek Olšák wrote: >>> On Tue, Jun 26, 2018, 4:26 AM Michel Dänzer wrote: >>> On 2018-06-26 03:49 AM, Marek Olšák wrote: > Good timing. I have a patch that

Re: [Mesa-dev] [PATCH 4/8] radv: add all dependencies from external to the first subpass

On 06/27/2018 02:12 AM, Bas Nieuwenhuizen wrote: Reviewed-by: Bas Nieuwenhuizen for patch 3-4. Not sure they should go to stable though, since they are optimizations? Isn't the whole series for optimization purposes? On Tue, Jun 26, 2018 at 11:49 PM, Fredrik Höglund wrote: This is to

Re: [Mesa-dev] [PATCH] anv: Print the actual enum for ignored structure types

Reviewed-by: Tapani Pälli On 06/26/2018 11:33 PM, Jason Ekstrand wrote: --- src/intel/vulkan/anv_private.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 33ae9fb82f2..3967f8de265 100644 ---

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

On Tue, 2018-06-26 at 08:34 -0700, Dylan Baker wrote: > Quoting Juan A. Suarez Romero (2018-06-19 00:08:27) > > On Fri, 2018-06-15 at 09:36 -0700, Dylan Baker wrote: > > > Quoting Juan A. Suarez Romero (2018-06-15 07:26:18) > > > > On Thu, 2018-06-14 at 10:16 -0700, Dylan Baker wrote: > > > > >

Re: [Mesa-dev] [PATCH] i965/bufmgr: Use the correct argument order for bo_alloc_internal

On Tuesday, June 26, 2018 6:33:40 PM PDT Jason Ekstrand wrote: > The memzone and flags parameters were accidentally flipped in the call > from brw_bo_alloc_tiled_2d. > --- > src/mesa/drivers/dri/i965/brw_bufmgr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2.5/23] intel/eu: Define SET_BITS helper more easily reusable than SET_FIELD.

On Tuesday, June 26, 2018 6:22:08 PM PDT Francisco Jerez wrote: > Allows to specify a bitfield based on its upper and lower bounds > instead of a symbolic field definition, kind of what the current > GET_BITS macro is to GET_FIELD. > --- > src/intel/compiler/brw_eu_defines.h | 7 +++ > 1 file

  1   2   >