[Mesa-dev] [PATCH] From List: Check if the window is non-NULL before setting swap interval.

2018-07-01 Thread samiuddi
This fixes crash due to NULL window when swap interval is set for pbuffer surface. Jira: 61995 Test: CtsDisplayTestCases pass Signed-off-by: samiuddi --- src/egl/drivers/dri2/platform_android.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] radv: winsys/amdgpu: include missing pthread.h header

2018-07-01 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Jul 2, 2018 at 1:25 AM, Mauro Rossi wrote: > pthread types are used in some files without explicitely including pthread.h. > This leads to compile errors on Android 7.x nougat-x86 > e.g. in src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h > > In file

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 5.0

2018-07-01 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 02/07/18 05:50, Marek Olšák wrote: From: Marek Olšák Users are encouraged to switch to LLVM 6.0 released in March 2018. --- .travis.yml | 24 ++-- configure.ac | 4 +- meson.build

Re: [Mesa-dev] [PATCH 3/4] anv/cmd_buffer: make descriptors dirty when emitting base state address

2018-07-01 Thread Jason Ekstrand
1-3 are R-b me. Should we cc stable? On June 29, 2018 03:11:00 Iago Toral Quiroga wrote: Every time we emit a new state base address we will need to re-emit our binding tables, since they might have been emitted with a different base state adress. --- src/intel/vulkan/genX_cmd_buffer.c | 5

Re: [Mesa-dev] [PATCH 4/4] anv/cmd_buffer: only emit state base address if the address changes

2018-07-01 Thread Jason Ekstrand
On June 29, 2018 03:11:00 Iago Toral Quiroga wrote: --- src/intel/vulkan/anv_private.h | 5 + src/intel/vulkan/genX_cmd_buffer.c | 12 +++- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index

[Mesa-dev] [PATCH] radv: winsys/amdgpu: include missing pthread.h header

2018-07-01 Thread Mauro Rossi
pthread types are used in some files without explicitely including pthread.h. This leads to compile errors on Android 7.x nougat-x86 e.g. in src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h In file included from external/mesa/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c:31: In file included

Re: [Mesa-dev] [PATCH v3 4/4] gallium/llvmpipe: Enable support bptc format.

2018-07-01 Thread Denis Pauk
Thank you. Best regards, Denis. On Sun, Jul 1, 2018, 10:44 PM Marek Olšák wrote: > Pushed, thanks for the patches. > > Marek > > On Sun, Jul 1, 2018 at 2:25 AM, Denis Pauk wrote: > > HI Marek, > > > > Thank you, could you merge commits? > > > > I don't have commit rights.

[Mesa-dev] [PATCH] amd: remove support for LLVM 5.0

2018-07-01 Thread Marek Olšák
From: Marek Olšák Users are encouraged to switch to LLVM 6.0 released in March 2018. --- .travis.yml | 24 ++-- configure.ac | 4 +- meson.build | 4 +-

Re: [Mesa-dev] [PATCH v3 4/4] gallium/llvmpipe: Enable support bptc format.

2018-07-01 Thread Marek Olšák
Pushed, thanks for the patches. Marek On Sun, Jul 1, 2018 at 2:25 AM, Denis Pauk wrote: > HI Marek, > > Thank you, could you merge commits? > > I don't have commit rights. > > On Sat, Jun 30, 2018 at 12:29 AM Marek Olšák wrote: >> >> For the series: >> >> Reviewed-by: Marek Olšák >> >> Marek

[Mesa-dev] [PATCH 2/3] r600: Add R4G4B4A4 and A1B5G5R5 to supported vertex formats

2018-07-01 Thread Gert Wollny
Below tests would fail with an error message "Vertex format (R4G4B4A4|R5G5B5A1) not supported." Add the formate to the translation routine to enable these formats. Fixes: dEQP-GLES3.functional.texture.specification.teximage2d_pbo.rgba4_2d

[Mesa-dev] [PATCH 1/3] r600: force LOD range to be only one value when mip.min filter is NONE

2018-07-01 Thread Gert Wollny
For a texture that has only one LOD defined, but for which GL_TEXTURE_MAX_LEVEL is the default (1000) and GL_TEXTURE_MIN_LOD != GL_TEXTURE_MAX_LOD the reading from the texture does not properly resolve the LOD level and texture lookup might fail. Hence, when no mipmap filter is given (indicating

[Mesa-dev] [PATCH 0/3] r600: Fix another bunch of textureing failures

2018-07-01 Thread Gert Wollny
This series fixes another bunch of tests from deqp gles3 and gles31. I didn't see any regressions with piglit gpu -t texture -t gather thanks for reviewing, Gert Gert Wollny (3): r600: force LOD range to be only one value when mip.min filter is NONE r600: Add R4G4B4A4 and A1B5G5R5 to

[Mesa-dev] [PATCH 3/3] r600: Scale interger valued texture border colors to float

2018-07-01 Thread Gert Wollny
It seems the hardware always expects floating point border color values [0,1] for unsigned, and [-1,1] for signed texture component, regardless of pixel type, but the border colors are passed according to texture component type. Hence, before submitting the border color, convert and scale it these

Re: [Mesa-dev] [PATCH 1/4] anv/cmd_buffer: never shrink the push constant buffer size

2018-07-01 Thread Lionel Landwerlin
I reread the discussion you had with Jason in order to figure out why this change is required. Maybe adding a comment at the top of the function would be a good bit of documentation for future developers ;) Regardless this series is : Reviewed-by: Lionel Landwerlin Thanks! On 29/06/18

[Mesa-dev] [PATCH] r600: compare structure elements instead of doing a memcmp

2018-07-01 Thread Gert Wollny
From: Gert Wollny Structures might be padded by the compiler and these padding bytes remain un-initialized which in turn makes memcmp return a difference where from the logical point of view there is none. Fixes valgrind: Conditional jump or move depends on uninitialised value(s)

[Mesa-dev] [PATCH 1/1] mesa/st: draw_vbo: initialize restart_index too

2018-07-01 Thread Gert Wollny
From: Gert Wollny restart_index is later always used in a comparison, so it should be initialized properly. Fixes valgrind warning: Conditional jump or move depends on uninitialised value(s) at 0xB8D682F: r600_draw_vbo (r600_state_common.c:2153) by 0xB71F743: u_vbuf_draw_vbo

Re: [Mesa-dev] [PATCH] gallium: Disable Altivec on PPC SPE variants

2018-07-01 Thread Stuart Young
Further info on this: The original patch in Debian is at https://sources.debian.org/src/mesa/18.1.2-1/debian/patches/07_gallium-fix-build-failure-on-powerpcspe.diff/ (URL will change based on version of Mesa in Debian - URL is current when I sent this email). PowerPCSPE port page in Debian which

[Mesa-dev] [PATCH] gallium: Disable Altivec on PPC SPE variants

2018-07-01 Thread Stuart Young
PowerPC variants with the Signal Processing Engine do not support Altivec instructions, as the SPE instruction set uses the same instruction codes as the Altivec set available in most PowerPC cores. Note that this is not related to the "Synergistic Processing Element" units on IBM Cell

Re: [Mesa-dev] [PATCH v3 4/4] gallium/llvmpipe: Enable support bptc format.

2018-07-01 Thread Denis Pauk
HI Marek, Thank you, could you merge commits? I don't have commit rights. On Sat, Jun 30, 2018 at 12:29 AM Marek Olšák wrote: > For the series: > > Reviewed-by: Marek Olšák > > Marek > > On Tue, Jun 26, 2018 at 4:30 PM, Denis Pauk wrote: > > v2: none > > v3: none > > > > Signed-off-by: