Re: [Mesa-dev] ANDROID: eglCreateImageKHR missing modifiers

2018-07-30 Thread Tomasz Figa
On Tue, Jul 24, 2018 at 10:25 PM Martin Fuzzey wrote: > > Hi Thomasz, > > thanks for your reply > > On 21/07/18 04:27, Tomasz Figa wrote: > > > > As you noticed, this adds back the dependency on gralloc handle > > structure. Moreover, it actually adds a dependency on the handle > > having a

[Mesa-dev] [PATCH 7/7] i965: Implement EGL_KHR_mutable_render_buffer

2018-07-30 Thread Chad Versace
Tested with a low-latency handwriting application on Android Nougat on the Chrome OS Pixelbook (codename Eve) with Kabylake. --- src/mesa/drivers/dri/i965/brw_context.c | 86 +++- src/mesa/drivers/dri/i965/brw_context.h | 12 src/mesa/drivers/dri/i965/intel_screen.c |

[Mesa-dev] [PATCH] drisw: Fix build on Android Nougat, which lacks shm (v2)

2018-07-30 Thread Chad Versace
In commit cf54bd5e8, dri_sw_winsys.c began using to support the new functions putImageShm, getImageShm in DRI_SWRastLoader. But Android began supporting System V shared memory only in Oreo. Nougat has no shm headers. Fix the build by ifdef'ing out the shm code on Nougat. Fixes: cf54bd5e8

[Mesa-dev] [PATCH 3/7] dri: Define DRI_MutableRenderBuffer extensions

2018-07-30 Thread Chad Versace
Define extensions DRI_MutableRenderBufferDriver and DRI_MutableRenderBufferLoader. These are the two halves for EGL_KHR_mutable_render_buffer. Outside the DRI code there is one additional change. Add gl_config::mutableRenderBuffer to match __DRI_ATTRIB_MUTABLE_RENDER_BUFFER. Neither are used

[Mesa-dev] [PATCH 0/7] egl, i965: Implement EGL_KHR_mutable_render_buffer

2018-07-30 Thread Chad Versace
Despite the KHR, Android is the only OS that uses this extension, as far as I know. Essentially, it allows the app to toggle front-buffer/back-buffer rendering using EGL. Android requires this extension if the device advertises support for virtual reality. No Chrome OS device yet supports

[Mesa-dev] [PATCH 1/7] egl: Simplify queries for EGL_RENDER_BUFFER

2018-07-30 Thread Chad Versace
There exist *two* queryable EGL_RENDER_BUFFER states in EGL: eglQuerySurface(EGL_RENDER_BUFFER) and eglQueryContext(EGL_RENDER_BUFFER). These changes eliminate potentially very fragile code in the upcoming EGL_KHR_mutable_render_buffer implementation. * eglQuerySurface(EGL_RENDER_BUFFER) The

[Mesa-dev] [PATCH 2/7] egl/dri2: In dri2_make_current, return early on failure

2018-07-30 Thread Chad Versace
This pulls an 'else' block into the function's main body, making the code easier to follow. Without this change, the upcoming EGL_KHR_mutable_render_buffer patch transforms dri2_make_current() into spaghetti. --- src/egl/drivers/dri2/egl_dri2.c | 29 +++-- 1 file changed,

[Mesa-dev] [PATCH 5/7] egl/main: Add bits for EGL_KHR_mutable_render_buffer

2018-07-30 Thread Chad Versace
A follow-up patch enables EGL_KHR_mutable_render_buffer for Android. This patch is separate from the Android patch because I think it's easier to review the platform-independent bits separately. --- src/egl/main/eglapi.c | 1 + src/egl/main/eglconfig.c | 3 ++ src/egl/main/egldisplay.h |

Re: [Mesa-dev] [PATCH mesa] anv: don't crash on vkDestroyDevice(NULL)

2018-07-30 Thread Chad Versace
On Thu 26 Jul 2018, Eric Engestrom wrote: > On Thursday, 2018-07-26 02:03:58 -0700, Jason Ekstrand wrote: > > On Thu, Jul 26, 2018 at 1:50 AM Eric Engestrom > > wrote: > > > > > On Wednesday, 2018-07-25 14:00:29 -0700, Dylan Baker wrote: > > > > Quoting Eric Engestrom (2018-07-25 11:45:56) > > >

Re: [Mesa-dev] [PATCH] anv: add more swapchain formats

2018-07-30 Thread Chad Versace
On Wed 25 Jul 2018, Tapani Pälli wrote: > This change helps with some of the dEQP-VK.wsi.android.* tests that > try to create swapchain with using such formats. > > Signed-off-by: Tapani Pälli > --- > src/intel/vulkan/anv_android.c | 16 +++- > 1 file changed, 11 insertions(+), 5

Re: [Mesa-dev] [PATCH] xlib: fix build break from _swrast_map_soft_renderbuffer() call

2018-07-30 Thread Chad Versace
On Fri 27 Jul 2018, Brian Paul wrote: > We need to pass the new flip_y argument. > --- > src/mesa/drivers/x11/xm_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks Brian. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] ac: fix get_image_coords() for radeonsi

2018-07-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jul 27, 2018 at 1:32 AM, Timothy Arceri wrote: > Because this was setting image to true we would end up calling > si_load_image_desc() when we sould be calling > si_load_sampler_desc(). > > This fixes an assert() in Deus Ex: MD > --- >

[Mesa-dev] [RFC] add a config file for dri loader to choose a different dri driver

2018-07-30 Thread Yu, Qiang
Hi guys, As previously talked in: https://lists.freedesktop.org/archives/mesa-dev/2017-April/152055.html amdgpu-pro driver has interest to adopt the DRI interface to be compatable with the mesa libgbm. But using MESA_LOADER_DRIVER_OVERRIDE is not a good way to config OS GFX stack globally, so

Re: [Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Rafael Antognolli
On Mon, Jul 30, 2018 at 04:28:37PM +0100, Lionel Landwerlin wrote: > Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end > of the context image. Cool, I see you are also adding a couple missing commands and noops into the gen10+ contexts. Reviewed-by: Rafael Antognolli > We

Re: [Mesa-dev] [PATCH] Make glXChooseFBConfig handle unspecified sRGB correctly

2018-07-30 Thread Eric Anholt
Jon Turney writes: > Make glXChooseFBConfig properly handle the case where the only matching > configs have the sRGB flag set, but no sRGB attribute is specified. > > Since 6e06e281, the sRGBcapable flag is now actually compared, using > MATCH_DONT_CARE. > > 7b0f912e added defaulting of

Re: [Mesa-dev] [PATCH 07/12] nir: Add an array splitting pass

2018-07-30 Thread Caio Marcelo de Oliveira Filho
> > > +static int > > > +num_arrays_in_type(const struct glsl_type *type) > > > +{ > > > + int num_arrays = 0; > > > + while (true) { > > > + if (glsl_type_is_array(type) || glsl_type_is_matrix(type)) { > > > + num_arrays++; > > > + type = glsl_get_array_element(type); > >

[Mesa-dev] [PATCH 1/3] virgl: add initial images support (v2)

2018-07-30 Thread Dave Airlie
From: Dave Airlie v2: add max image samples support --- src/gallium/drivers/virgl/virgl_context.c | 44 ++ src/gallium/drivers/virgl/virgl_context.h | 1 + src/gallium/drivers/virgl/virgl_encode.c | 29

[Mesa-dev] [PATCH 2/3] virgl: add TXQS support

2018-07-30 Thread Dave Airlie
From: Dave Airlie --- src/gallium/drivers/virgl/virgl_hw.h | 1 + src/gallium/drivers/virgl/virgl_screen.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_hw.h b/src/gallium/drivers/virgl/virgl_hw.h index aa6d8f8fe4b..01baf05e6d4

[Mesa-dev] [PATCH 3/3] virgl: add memory barrier support

2018-07-30 Thread Dave Airlie
From: Dave Airlie use a cap to expose this --- src/gallium/drivers/virgl/virgl_context.c | 13 + src/gallium/drivers/virgl/virgl_encode.c | 8 src/gallium/drivers/virgl/virgl_encode.h | 3 +++ src/gallium/drivers/virgl/virgl_hw.h | 1 +

Re: [Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

2018-07-30 Thread Eric Anholt
Tapani Pälli writes: > Hi; > > > On 07/25/2018 08:36 AM, Tapani Pälli wrote: >> >> >> On 07/24/2018 10:31 PM, Eric Anholt wrote: >>> Tapani Pälli writes: >>> These bits were missing, found when extending the Piglit test. Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension

Re: [Mesa-dev] [2/5] gbm: Add support for 10bpp BGR formats

2018-07-30 Thread Eric Engestrom
On Wednesday, 2018-06-13 06:04:12 +0200, Mario Kleiner wrote: > From: Daniel Stone > > Add support for XBGR2101010 and ABGR2101010 formats. > > Signed-off-by: Daniel Stone > Reviewed-by: Mario Kleiner > Tested-by: Mario Kleiner > Tested-by: Ilia Mirkin Reviewed-by: Eric Engestrom Any

Re: [Mesa-dev] [PATCH] intel/isl: Avoid tiling on 16K-wide render targets

2018-07-30 Thread Andres Gomez
That was quick! ☺ On Fri, 2018-07-27 at 16:02 -0700, Nanley Chery wrote: > Fix rendering issues on BDW and SKL. > > Fixes 0288fe8d0417730bdd5b3477130dd1dc32bdbcd3 > ("i965/miptree: Use the correct BLT pitch") I'd add here some lines listing the tests fixed by this patch. > > Bugzilla:

[Mesa-dev] [PATCH v2.1 6/11] nir: Add an array splitting pass

2018-07-30 Thread Jason Ekstrand
This pass looks for array variables where at least one level of the array is never indirected and splits it into multiple smaller variables. This pass doesn't really do much now because nir_lower_vars_to_ssa can already see through arrays of arrays and can detect indirects on just one level or

Re: [Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Lionel Landwerlin
On 30/07/18 17:13, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-07-30 17:08:47) On 30/07/18 16:45, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-07-30 16:28:37) Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end of the context image. Hmm, do you think we

Re: [Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-07-30 17:08:47) > On 30/07/18 16:45, Chris Wilson wrote: > > Quoting Lionel Landwerlin (2018-07-30 16:28:37) > >> Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end > >> of the context image. > > Hmm, do you think we should perhaps include the BBE

Re: [Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Lionel Landwerlin
On 30/07/18 16:45, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-07-30 16:28:37) Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end of the context image. Hmm, do you think we should perhaps include the BBE in the protocontext we create in the kernel? -Chris I can't

Re: [Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-07-30 16:28:37) > Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end > of the context image. Hmm, do you think we should perhaps include the BBE in the protocontext we create in the kernel? -Chris ___

Re: [Mesa-dev] [PATCH 2/2] intel/compiler: implement 8-bit constant load

2018-07-30 Thread Jason Ekstrand
Both are Reviewed-by: Jason Ekstrand Please add the appropriate Fixes: tag prior to pushing. On Fri, Jul 27, 2018 at 4:39 AM Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > From: Iago Toral Quiroga > > --- > src/intel/compiler/brw_fs_nir.cpp | 5 + > 1 file changed, 5

[Mesa-dev] [PATCH] intel: tools: aubwrite: split gen[89] from gen10+

2018-07-30 Thread Lionel Landwerlin
Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end of the context image. We select the largest size for the context image regardless of the generation. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aub_write.c | 216 +---

[Mesa-dev] [PATCH] nouveau: limit reported compute max memory and allocation size

2018-07-30 Thread Karol Herbst
Otherwise applications (like the OpenCL CTS) will try to allocate more memory than what the GPU is actually able to provide. Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 5 +++-- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 5 +++-- 2 files changed, 6

Re: [Mesa-dev] [PATCH] etnaviv: fix typo in query names

2018-07-30 Thread Chris Healy
Reviewed-by: Chris Healy On Mon, Jul 30, 2018 at 12:44 AM, Christian Gmeiner wrote: > Fixes: d0bed0b4944d ("etnaviv: support HI performance counters") > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 4 ++-- >

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106151 Jaap Buurman changed: What|Removed |Added CC||jaapbuur...@gmail.com -- You are

[Mesa-dev] [Bug 106151] [amdgpu][vulkan] GPU hang (Vega 56) while running game (Rise of the Tomb Raider)

2018-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106151 --- Comment #29 from Jaap Buurman --- I am seeing the same issue in multiple games on my Vega 64: -Assassin's creed 2 played through Wine with the Gallium Nine patches -Assassin's creed brotherhood played through Wine with the Gallium Nine

Re: [Mesa-dev] [PATCH] xf86drm: Fix error path in drmGetDevice2

2018-07-30 Thread Emil Velikov
On 30 July 2018 at 11:23, Michel Dänzer wrote: > On 2018-07-30 12:13 PM, Mariusz Ceier wrote: >> On 30 July 2018 at 11:31, Michel Dänzer wrote: >>> On 2018-07-29 10:20 AM, Mariusz Ceier wrote: In drmGetDevice2 when no local device is found or when drm_device_has_rdev filters out all

Re: [Mesa-dev] [PATCH] xf86drm: Fix error path in drmGetDevice2

2018-07-30 Thread Michel Dänzer
On 2018-07-30 12:13 PM, Mariusz Ceier wrote: > On 30 July 2018 at 11:31, Michel Dänzer wrote: >> On 2018-07-29 10:20 AM, Mariusz Ceier wrote: >>> In drmGetDevice2 when no local device is found or when >>> drm_device_has_rdev filters out all devices, *device might be left >>> uninitialized causing

Re: [Mesa-dev] [PATCH] xf86drm: Fix error path in drmGetDevice2

2018-07-30 Thread Mariusz Ceier
On 30 July 2018 at 11:31, Michel Dänzer wrote: > On 2018-07-29 10:20 AM, Mariusz Ceier wrote: >> In drmGetDevice2 when no local device is found or when >> drm_device_has_rdev filters out all devices, *device might be left >> uninitialized causing drmGetDevice2 to not return error - since >> it's

Re: [Mesa-dev] [PATCH] xf86drm: Fix error path in drmGetDevice2

2018-07-30 Thread Michel Dänzer
On 2018-07-29 10:20 AM, Mariusz Ceier wrote: > In drmGetDevice2 when no local device is found or when > drm_device_has_rdev filters out all devices, *device might be left > uninitialized causing drmGetDevice2 to not return error - since > it's only returned when *device == NULL. > > Above leads

Re: [Mesa-dev] [PATCH 04/15] mesa/glspirv: Set last_vert_prog

2018-07-30 Thread Neil Roberts
Timothy Arceri writes: >> + >> + int last_vert_stage = >> + util_last_bit(prog->data->linked_stages & >> +(((1 << (MESA_SHADER_GEOMETRY + 1)) - 1) ^ >> + ((1 << MESA_SHADER_VERTEX) - 1))); > > Isn't this the same as: > > int last_vert_stage = >

[Mesa-dev] [PATCH] etnaviv: fix typo in query names

2018-07-30 Thread Christian Gmeiner
Fixes: d0bed0b4944d ("etnaviv: support HI performance counters") Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] intel_do_flush_locked failed: No space left on device

2018-07-30 Thread Mathieu MB
Hi there, I've always had some Gnome Shell crashes on my setup, but they were quite rare. Now in the past few months, they've become very frequent, my Gnome Shell sessions hardly last more than 10 minutes before crashing... I get: org.gnome.Shell.desktop[2601]: intel_do_flush_locked failed: No