[Mesa-dev] [PATCH 08/11] glsl: add arithmetic builtin functions for EXT_gpu_shader4

2018-08-07 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/builtin_functions.cpp | 48 ++--- 1 file changed, 35 insertions(+), 13 deletions(-) diff --git a/src/compiler/glsl/builtin_functions.cpp b/src/compiler/glsl/builtin_functions.cpp index 7119903795f..1370245ff91 100644 ---

[Mesa-dev] [PATCH 11/11] st/mesa: expose EXT_gpu_shader4 if GLSL 1.30 is supported

2018-08-07 Thread Marek Olšák
From: Marek Olšák --- docs/relnotes/18.3.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/18.3.0.html b/docs/relnotes/18.3.0.html index 6274c9147a1..905104a27af 100644 --- a/docs/relnotes/18.3.0.html +++

[Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-07 Thread Marek Olšák
From: Marek Olšák This is needed for exposing the samplerBuffer functions under EXT_gpu_shader4. glTexBufferEXT is defined in glapi, but "make check" fails. What am I doing wrong? --- docs/relnotes/18.3.0.html | 1 + src/mesa/main/extensions_table.h| 1 +

[Mesa-dev] [PATCH 05/11] glsl: enable types for EXT_gpu_shader4

2018-08-07 Thread Marek Olšák
From: Chris Forbes --- src/compiler/glsl/builtin_types.cpp | 32 ++ src/compiler/glsl/glsl_lexer.ll | 50 ++--- 2 files changed, 57 insertions(+), 25 deletions(-) diff --git a/src/compiler/glsl/builtin_types.cpp b/src/compiler/glsl/builtin_types.cpp

[Mesa-dev] [PATCH 09/11] glsl: add texture builtin functions for EXT_gpu_shader4

2018-08-07 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/builtin_functions.cpp | 642 +++- 1 file changed, 638 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/builtin_functions.cpp b/src/compiler/glsl/builtin_functions.cpp index 1370245ff91..6ac9f377a03 100644 ---

[Mesa-dev] [PATCH 01/11] mesa: fix glGet for EXT_gpu_shader4

2018-08-07 Thread Marek Olšák
From: Marek Olšák --- src/mapi/glapi/gen/EXT_gpu_shader4.xml | 4 src/mesa/main/get.c| 3 ++- src/mesa/main/get_hash_params.py | 4 ++-- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/mapi/glapi/gen/EXT_gpu_shader4.xml

[Mesa-dev] [PATCH 00/11] GL_EXT_gpu_shader4

2018-08-07 Thread Marek Olšák
Hi, This adds EXT_gpu_shader4 with its subset EXT_texture_buffer_object. Some applications that previously required force_glsl_version=130 now work without it, because EXT_gpu_shader4 enables a subset of GLSL 1.30. There are also applications that need the old-style texture functions from

[Mesa-dev] [PATCH 02/11] glsl: add scaffolding for EXT_gpu_shader4

2018-08-07 Thread Marek Olšák
From: Chris Forbes --- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++ src/compiler/glsl/standalone_scaffolding.cpp | 1 + 3 files changed, 4 insertions(+) diff --git a/src/compiler/glsl/glsl_parser_extras.cpp

[Mesa-dev] [PATCH 04/11] glsl: add `unsigned int` type for EXT_GPU_shader4

2018-08-07 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/glsl_lexer.ll | 2 +- src/compiler/glsl/glsl_parser.yy | 11 ++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/glsl_lexer.ll b/src/compiler/glsl/glsl_lexer.ll index e24bb133bc2..65c5b414a2d 100644 ---

[Mesa-dev] [PATCH 07/11] glsl: add builtin variables for EXT_gpu_shader4

2018-08-07 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/builtin_variables.cpp | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/builtin_variables.cpp b/src/compiler/glsl/builtin_variables.cpp index 78fccc4e195..17ee80cd419 100644 ---

[Mesa-dev] [PATCH 03/11] glsl: enable noperspective|flat|centroid for EXT_gpu_shader4

2018-08-07 Thread Marek Olšák
From: Chris Forbes --- src/compiler/glsl/glsl_lexer.ll | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/glsl_lexer.ll b/src/compiler/glsl/glsl_lexer.ll index 87b64e09c16..e24bb133bc2 100644 --- a/src/compiler/glsl/glsl_lexer.ll +++

[Mesa-dev] [PATCH 06/11] glsl: apply some 1.30 rules to EXT_gpu_shader4 as well

2018-08-07 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/ast_to_hir.cpp | 14 +- src/compiler/glsl/glsl_parser_extras.h | 3 ++- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 74160ec142b..d6f1c765790

Re: [Mesa-dev] [PATCH 00/18] RadeonSI: Cleanups for future work

2018-08-07 Thread Dieter Nützel
For the series Tested-by: Dieter Nützel with glmark2, glxgears, UH, UV, Blender 2.79, FreeCAD 0.17 and Krita 4.1.1 on RX 580 all with NIR. Dieter Am 04.08.2018 09:54, schrieb Marek Olšák: Hi, There are cleanups in TGSI->LLVM translation, which will be useful in better understanding the

Re: [Mesa-dev] [PATCH v3 1/8] nir: evaluate if condition uses inside the if branches

2018-08-07 Thread Dieter Nützel
Am 01.08.2018 05:09, schrieb Dieter Nützel: Am 31.07.2018 13:34, schrieb Timothy Arceri: On 31/07/18 13:50, Dieter Nützel wrote: Am 30.07.2018 05:24, schrieb Dieter Nützel: For the series Tested-by: Dieter Nützel with glmark2, glxgears, UH, UV, Blender 2.79 and FreeCAD 0.17 on RX 580.

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-07 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) >

Re: [Mesa-dev] [PATCH v2 02/11] util: rb_tree: add safe iterators

2018-08-07 Thread Rafael Antognolli
On Tue, Aug 07, 2018 at 06:35:13PM +0100, Lionel Landwerlin wrote: > v2: Add helper to make iterators more readable (Rafael) > Fix rev iterator bug (Rafael) > > Signed-off-by: Lionel Landwerlin Reviewed-by: Rafael Antognolli > --- > src/util/rb_tree.h | 58

Re: [Mesa-dev] [PATCH v2 09/11] intel: tools: add aubinator viewer

2018-08-07 Thread Rafael Antognolli
On Tue, Aug 07, 2018 at 06:35:20PM +0100, Lionel Landwerlin wrote: > A graphical user interface version of aubinator. > Allows you to : > >- simultaneously look at multiple points in the aub file (using all > the goodness of the existing decoding in aubinator) > >- edit an aub file

[Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-07 Thread Bas Nieuwenhuizen
This became kind of messy as python imports cannot really look up parent/sibling directories. I saw some scripts use sys.path but that became even more messy due to import locations. I also move the selections of the dispatch table out of the generation script because it is not easily shared, and

[Mesa-dev] [PATCH 2/4] vulkan/util: Add support to not generate the trampolines.

2018-08-07 Thread Bas Nieuwenhuizen
radv does not need them and the trampolines need a dispatch table in the instance and device. --- src/vulkan/util/vk_entrypoints_gen.py | 47 +++ 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/src/vulkan/util/vk_entrypoints_gen.py

[Mesa-dev] [PATCH 0/4] Merge vulkan API generators.

2018-08-07 Thread Bas Nieuwenhuizen
radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this repetition makes even less sense, so lets merge them. I took the anv generators as the template and made radv use them. This includes some

[Mesa-dev] [PATCH 1/4] vulkan: Add central copy of entrypoints/extensions code.

2018-08-07 Thread Bas Nieuwenhuizen
--- src/vulkan/Makefile.am| 3 + src/vulkan/util/meson.build | 2 + src/vulkan/util/vk_entrypoints_gen.py | 515 ++ src/vulkan/util/vk_extensions.py | 92 + src/vulkan/util/vk_extensions_gen.py | 205 ++ 5 files changed, 817

[Mesa-dev] [PATCH 4/4] radv: Integrate with common generators.

2018-08-07 Thread Bas Nieuwenhuizen
Replace some functions to use the anv idioms. However, I did not introduce dispatch tables in the instance/device since that seemed like overkill. --- src/amd/vulkan/Android.mk | 16 +- src/amd/vulkan/Makefile.am | 29 +- src/amd/vulkan/meson.build | 91

[Mesa-dev] [Bug 107474] RADV does not support a dedicated transfer queue

2018-08-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107474 --- Comment #1 from Dave Airlie --- FYI I've had a branch and posted patches for starting this on gfx8 and gfx9. https://github.com/airlied/mesa/tree/radv-wip-transfer-queue-4 There are lots of corner cases and I hadn't resolved all the CTS

Re: [Mesa-dev] [PATCH 12/26] python: Fix unequality comparisons

2018-08-07 Thread Dylan Baker
Quoting Mathieu Bridon (2018-07-06 02:25:53) > On Thu, 2018-07-05 at 09:10 -0700, Dylan Baker wrote: > > Quoting Mathieu Bridon (2018-07-05 06:17:43) > > > +def __ne__(self, other): > > > +return not self.__eq__(other) > > > > This can be written as "not (self == other)", right? > >

Re: [Mesa-dev] [PATCH 15/26] python: Specify the template output encoding

2018-08-07 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-05 06:17:46) > We're trying to write a unicode string (i.e decoded) to a file opened > in binary (i.e encoded) mode. > > In Python 2 this works, because of the automatic conversion between > byte and unicode strings. > > In Python 3 this

Re: [Mesa-dev] [PATCH 15/26] python: Specify the template output encoding

2018-08-07 Thread Dylan Baker
Quoting Mathieu Bridon (2018-07-06 02:34:56) > On Thu, 2018-07-05 at 09:14 -0700, Dylan Baker wrote: > > Does it make more sense to encode, or to use io.open and open the > > file in text mode? I've gone back and forth on this myself several > > times. > > Same here, both seem equally valid and I

Re: [Mesa-dev] [PATCH 16/26] python: Explicitly use lists

2018-08-07 Thread Dylan Baker
Quoting Mathieu Bridon (2018-07-06 02:43:46) > On Thu, 2018-07-05 at 09:31 -0700, Dylan Baker wrote: > > Quoting Mathieu Bridon (2018-07-05 06:17:47) > > > On Python 2, the builtin functions filter() and zip() would return > > > lists. > > > > > > On Python 3, they return iterators. > > > > > >

Re: [Mesa-dev] [PATCH v3 05/48] gallium: fix ddebug on windows

2018-08-07 Thread Dylan Baker
Yeah, this is git+me screwing up the rebase. The actual useful part of this patch (that defines mkdir and getpid) is already in master. I'll drop this patch entirely. Dylan Quoting Marek Olšák (2018-08-07 10:45:42) > Reviewed-by: Marek Olšák > > The commit message doesn't match the content of

[Mesa-dev] [PATCH] virgl: ARB_texture_barrier support

2018-08-07 Thread Dave Airlie
From: Dave Airlie --- src/gallium/drivers/virgl/virgl_context.c | 9 +++-- src/gallium/drivers/virgl/virgl_encode.c | 8 src/gallium/drivers/virgl/virgl_encode.h | 2 ++ src/gallium/drivers/virgl/virgl_hw.h | 1 + src/gallium/drivers/virgl/virgl_protocol.h | 5 +

Re: [Mesa-dev] [PATCH] r600/eg: rework atomic counter emission with flushes

2018-08-07 Thread Gert Wollny
I have not yet read the patch, just applied it and run, at one point it locked up again, blancking the screen, and these piglits running: arb_compute_shader-local-id -auto -fbo arb_shader_image_load_store-bitcast -auto -fbo arb_shader_image_load_store-max-images -auto -fbo

[Mesa-dev] [PATCH] glx: Demand success from CreateContext requests (v2)

2018-08-07 Thread Adam Jackson
GLXCreate{,New}Context, like most X resource creation requests, does not emit a reply and therefore is emitted into the X stream asynchronously. However, unlike most resource creation requests, the GLXContext we return is a handle to library state instead of an XID. So if context creation fails

Re: [Mesa-dev] [PATCH v4 00/15] TGSI: improved live range tracking, also including arrays

2018-08-07 Thread Gert Wollny
Dear all, I'd like to get this series in the 18.3 release cycle applied. I've been using it for quite some time without issues, and it seems to fix a number of problems on r600. For instance, a number of dEQP-GLES31 tests fail because of issued with spilling, but with these patches the need for

Re: [Mesa-dev] [PATCH v2 11/26] python: Fix rich comparisons

2018-08-07 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-17 13:57:39) > Python 3 doesn't call objects __cmp__() methods any more to compare > them. Instead, it requires implementing the rich comparison methods > explicitly: __eq__(), __ne(), __lt__(), __le__(), __gt__() and __ge__(). > >

Re: [Mesa-dev] [PATCH] egl/wayland: Set width/height of EGLSurface at creation

2018-08-07 Thread Chad Versace
Ignore this in favor of jasuarez's patch. On Tue 07 Aug 2018, Chad Versace wrote: > Fixes dEQP-EGL.functional.color_clears.single_context.gles2.rgb565_window. > > After initializing _EGLSurface::Width and ::Height to 0, Mesa did not > update the width and height again until the DRI driver

Re: [Mesa-dev] [PATCH v3 10/26] python: Use explicit integer divisions

2018-08-07 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-07-25 02:53:54) > In Python 2, divisions of integers return an integer: > > >>> 32 / 4 > 8 > > In Python 3 though, they return floats: > > >>> 32 / 4 > 8.0 > > However, Python 3 has an explicit integer division operator: >

Re: [Mesa-dev] [PATCH 1/3] meson: use dependency()+find_program() for wayland-scanner

2018-08-07 Thread Dylan Baker
Quoting Emil Velikov (2018-08-07 08:41:36) > On 6 August 2018 at 17:39, Dylan Baker wrote: > > Quoting Emil Velikov (2018-06-28 07:35:44) > >> From: Emil Velikov > >> > >> Helps when the native wayland-scanner is located outside of PATH. > >> Inspired by the xserver code ;-) > >> > >> Cc: Dylan

[Mesa-dev] [Bug 107457] [Tracker] Mesa 18.2 release tracker

2018-08-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107457 Mark Janes changed: What|Removed |Added Depends on||107510 Referenced Bugs:

[Mesa-dev] [PATCH] egl: Fix leak of X11 pixmaps backing pbuffers in DRI3.

2018-08-07 Thread Eric Anholt
This is basically copied from the DRI2 destroy path. Without this, Raspberry Pi would quickly run out of CMA during the EGL tests in the CTS due to all the pixmaps laying around. Fixes: f35198badeb9 ("egl/x11: Implement dri3 support with loader's dri3 helper") ---

[Mesa-dev] [PATCH v2] i965: do not emit empty surface state

2018-08-07 Thread Erik Faye-Lund
If called with an empty size, brw_emit_buffer_surface_state asserts. We already have a dedicated helper for uploading nothing, so let's use that instead. Signed-off-by: Erik Faye-Lund --- Here's an updated patch. v2: call emit_null_surface_state to ensure out_offset is initialized

Re: [Mesa-dev] [PATCH v2 09/11] intel: tools: add aubinator viewer

2018-08-07 Thread Lionel Landwerlin
On 07/08/18 18:35, Lionel Landwerlin wrote: A graphical user interface version of aubinator. Allows you to : - simultaneously look at multiple points in the aub file (using all the goodness of the existing decoding in aubinator) - edit an aub file Signed-off-by: Lionel

Re: [Mesa-dev] [PATCH v3 13/48] meson: add windows compiler checks and libraries

2018-08-07 Thread Eric Anholt
Dylan Baker writes: > --- > meson.build | 129 > 1 file changed, 79 insertions(+), 50 deletions(-) > > diff --git a/meson.build b/meson.build > index 25de31bfabd..4350e1af810 100644 > --- a/meson.build > +++ b/meson.build > @@ -775,69 +775,96

Re: [Mesa-dev] [PATCH 3/7] dri: Define DRI_MutableRenderBuffer extensions

2018-08-07 Thread Chad Versace
On Mon 06 Aug 2018, Chad Versace wrote: > On Fri 03 Aug 2018, Tapani Pälli wrote: > > One tiny nit below but for patches 3,4 and 5: > > > > Reviewed-by: Tapani Pälli > > > > Special thanks for the documentation. I want to go through rest of changes > > within Android but I'm currently

Re: [Mesa-dev] [PATCH v3 20/48] meson: build graw-gdi target

2018-08-07 Thread Eric Anholt
Dylan Baker writes: > --- > src/gallium/meson.build | 4 ++- > src/gallium/targets/graw-gdi/meson.build | 36 > 2 files changed, 39 insertions(+), 1 deletion(-) > create mode 100644 src/gallium/targets/graw-gdi/meson.build > > diff --git

Re: [Mesa-dev] [PATCH v3 19/48] meson: build libgl-gdi target

2018-08-07 Thread Eric Anholt
Dylan Baker writes: > --- > src/gallium/meson.build | 1 + > src/gallium/targets/libgl-gdi/meson.build | 44 +++ > 2 files changed, 45 insertions(+) > create mode 100644 src/gallium/targets/libgl-gdi/meson.build > > diff --git a/src/gallium/meson.build

Re: [Mesa-dev] [PATCH v3 18/48] meson: build wgl state tracker

2018-08-07 Thread Eric Anholt
Dylan Baker writes: > --- > src/gallium/meson.build| 3 ++ > src/gallium/state_trackers/wgl/meson.build | 50 ++ > 2 files changed, 53 insertions(+) > create mode 100644 src/gallium/state_trackers/wgl/meson.build > > diff --git a/src/gallium/meson.build

Re: [Mesa-dev] [PATCH v4 1/2] wayland/egl: initialize window surface size to window size

2018-08-07 Thread Chad Versace
On Tue 07 Aug 2018, Juan A. Suarez Romero wrote: > When creating a windows surface with eglCreateWindowSurface(), the > width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is > invalid until buffers are updated (like calling glClear()). > > But according to EGL 1.5 spec, section

[Mesa-dev] [PATCH] egl/wayland: Set width/height of EGLSurface at creation

2018-08-07 Thread Chad Versace
Fixes dEQP-EGL.functional.color_clears.single_context.gles2.rgb565_window. After initializing _EGLSurface::Width and ::Height to 0, Mesa did not update the width and height again until the DRI driver fetched its buffers. This produced weird behavior: * Immediately after surface creation,

Re: [Mesa-dev] [PATCH v3 16/48] meson: Add necessary defines for mesa_gallium on windows

2018-08-07 Thread Eric Anholt
Dylan Baker writes: > --- > src/mesa/meson.build | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/meson.build b/src/mesa/meson.build > index 29633691ee7..fa086466443 100644 > --- a/src/mesa/meson.build > +++ b/src/mesa/meson.build > @@ -728,11

Re: [Mesa-dev] [PATCH v3 14/48] meson: Make shader-cache a trillean instead of boolean

2018-08-07 Thread Eric Anholt
Dylan Baker writes: > So that it can be implicitly disabled on windows, where it doesn't > compile. I don't see how this option successfully controls the shader cache being built. Also the "elif with_dri_i965 and get_option('shader-cache')" looks like it needs to get updated for the trillian,

Re: [Mesa-dev] [PATCH] main/tests: Add AMD_framebuffer_multisample_advanced

2018-08-07 Thread Marek Olšák
On Mon, Aug 6, 2018 at 6:57 PM, Ian Romanick wrote: > On 08/06/2018 10:02 AM, Dylan Baker wrote: >> Add dispatch_sanity tests >> >> Fixes: 3d6900d76efaef1ff6e84b7b8785bbe3d8f5b29b >>("glapi: define AMD_framebuffer_multisample_advanced and add its >> functions") >> Cc: Marek Olšák >> Cc:

Re: [Mesa-dev] [PATCH v3 12/48] meson: don't allow glvnd on windows

2018-08-07 Thread Eric Anholt
Dylan Baker writes: > --- 6-12 have my r-b. signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: plumb image writable through to driver

2018-08-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Aug 6, 2018 at 2:48 PM, Erik Faye-Lund wrote: > The virgl driver cares about the writable-flag on image definitions, > because it re-emits GLSL from the TGSI. However, so far it was hardcoded > to true in glsl_to_tgsi, which cause problems when

Re: [Mesa-dev] [PATCH v3 05/48] gallium: fix ddebug on windows

2018-08-07 Thread Eric Anholt
Dylan Baker writes: > By including the proper headers for getpid and for mkdir. This comment doesn't seem to match what the patch is doing, and I see these files as already being in the meson.build. Rebase fail? Patches 1-4 have my r-b. signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH v3 05/48] gallium: fix ddebug on windows

2018-08-07 Thread Marek Olšák
Reviewed-by: Marek Olšák The commit message doesn't match the content of the patch. Marek On Mon, Aug 6, 2018 at 8:50 PM, Dylan Baker wrote: > By including the proper headers for getpid and for mkdir. > > Signed-off-by: Dylan Baker > Reviewed-by: Marek Olšák > --- >

[Mesa-dev] [PATCH v2 10/11] intel: aubinator_viewer: store urb state during decoding

2018-08-07 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_viewer.h | 26 src/intel/tools/aubinator_viewer_decoder.cpp | 150 --- 2 files changed, 153 insertions(+), 23 deletions(-) diff --git a/src/intel/tools/aubinator_viewer.h

[Mesa-dev] [PATCH v2 09/11] intel: tools: add aubinator viewer

2018-08-07 Thread Lionel Landwerlin
A graphical user interface version of aubinator. Allows you to : - simultaneously look at multiple points in the aub file (using all the goodness of the existing decoding in aubinator) - edit an aub file Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_viewer.cpp

[Mesa-dev] [PATCH v2 11/11] intel: aubinator_viewer: add urb view

2018-08-07 Thread Lionel Landwerlin
This is available through a "Show URB" button on the 3DPRIMITIVE instructions. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator_viewer.cpp | 75 src/intel/tools/aubinator_viewer_urb.h | 96 ++ 2 files changed, 171 insertions(+)

[Mesa-dev] [PATCH v2 05/11] intel: tools: create libaub

2018-08-07 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/meson.build | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/meson.build b/src/intel/tools/meson.build index d749a80afed..258bf7011b3 100644 --- a/src/intel/tools/meson.build +++

[Mesa-dev] [PATCH v2 07/11] intel: tools: aub_mem: reuse already mapped ppgtt buffers

2018-08-07 Thread Lionel Landwerlin
When we map a PPGTT buffer into a continous address space of aubinator to be able to inspect it, we currently add it to the list of BOs to unmap once we're finished. An optimization we can apply it to look up that list before trying to remap PPGTT buffers again (we already do this for GGTT

[Mesa-dev] [PATCH v2 02/11] util: rb_tree: add safe iterators

2018-08-07 Thread Lionel Landwerlin
v2: Add helper to make iterators more readable (Rafael) Fix rev iterator bug (Rafael) Signed-off-by: Lionel Landwerlin --- src/util/rb_tree.h | 58 ++ 1 file changed, 58 insertions(+) diff --git a/src/util/rb_tree.h b/src/util/rb_tree.h index

[Mesa-dev] [PATCH v2 06/11] intel: tools: aubmem: map gtt data to aub file

2018-08-07 Thread Lionel Landwerlin
This will allow the aubinator viewer tool to modify the aub data that was loaded at a particular gtt address. Signed-off-by: Lionel Landwerlin Reviewed-by: Rafael Antognolli --- src/intel/tools/aub_mem.c | 29 + src/intel/tools/aub_mem.h | 6 ++ 2 files

[Mesa-dev] [PATCH v2 03/11] intel: tools: split memory management out of aubinator

2018-08-07 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Reviewed-by: Rafael Antognolli --- src/intel/tools/aub_mem.c | 391 src/intel/tools/aub_mem.h | 72 +++ src/intel/tools/aubinator.c | 379 +++--- src/intel/tools/meson.build | 2 +- 4

[Mesa-dev] [PATCH v2 04/11] intel: tools: aubwrite: wrap function declarations for c++

2018-08-07 Thread Lionel Landwerlin
Reviewed-by: Rafael Antognolli --- src/intel/tools/aub_write.h | 8 1 file changed, 8 insertions(+) diff --git a/src/intel/tools/aub_write.h b/src/intel/tools/aub_write.h index b421679b9eb..6a09c1747b9 100644 --- a/src/intel/tools/aub_write.h +++ b/src/intel/tools/aub_write.h @@ -31,6

[Mesa-dev] [PATCH v2 01/11] intel: tools: split aub parsing from aubinator

2018-08-07 Thread Lionel Landwerlin
v2: add parsing error callback (Lionel) Signed-off-by: Lionel Landwerlin Reviewed-by: Rafael Antognolli (v1) --- src/intel/tools/aub_read.c | 333 src/intel/tools/aub_read.h | 77 + src/intel/tools/aubinator.c | 325

[Mesa-dev] [PATCH v2 00/11] intel: tools: Add a UI aub editor/viewer

2018-08-07 Thread Lionel Landwerlin
Hi all, This is a quick update with some of the patches already marked as reviewed/acked by Rafael. The main change here is to move away from GLFW (which doesn't scale on retina displays with a wayland session, sorry I live in the future) to Gtk+. I also added a URB view. This is available at

Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Emil Velikov
On 7 August 2018 at 18:06, Juan A. Suarez Romero wrote: > On Tue, 2018-08-07 at 12:57 -0400, Jan Vesely wrote: >> >> >> On Tue, Aug 7, 2018 at 12:28 PM, Juan A. Suarez Romero >> wrote: >> > On Tue, 2018-08-07 at 16:12 +0100, Emil Velikov wrote: >> > > On 6 August 2018 at 11:17, Juan A. Suarez

[Mesa-dev] [PATCH v2] vulkan: simplify VK_USE_PLATFORM_*_KHR handling

2018-08-07 Thread Emil Velikov
From: Emil Velikov Instead of having multiple guards littered through the code, simply introduce static inline no-op functions when the respective macros are not set. Inspired by the same convention from the kernel. v2: Also handle PLATFORM_DISPLAY Signed-off-by: Emil Velikov Reviewed-by:

Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Juan A. Suarez Romero
On Tue, 2018-08-07 at 12:57 -0400, Jan Vesely wrote: > > > On Tue, Aug 7, 2018 at 12:28 PM, Juan A. Suarez Romero > wrote: > > On Tue, 2018-08-07 at 16:12 +0100, Emil Velikov wrote: > > > On 6 August 2018 at 11:17, Juan A. Suarez Romero > > > wrote: > > > > LLVM 6.0 requires GCC 4.9, which

Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Andres Gomez
With a bit more clarifying commit log, this is: Reviewed-by: Andres Gomez On Mon, 2018-08-06 at 12:17 +0200, Juan A. Suarez Romero wrote: > LLVM 6.0 requires GCC 4.9, which is not available in main Travis > repository. > > Fixes: fd1121e8399 ("amd: remove support for LLVM 5.0") > CC: Marek

Re: [Mesa-dev] [PATCH 2/2] travis: meson/Vulkan requires LLVM 6.0

2018-08-07 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Mon, 2018-08-06 at 12:17 +0200, Juan A. Suarez Romero wrote: > RADV now requires LLVM 6.0. > > Fixes: fd1121e8399 ("amd: remove support for LLVM 5.0") > CC: Marek Olšák > --- > .travis.yml | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) >

Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Jan Vesely
On Tue, Aug 7, 2018 at 12:28 PM, Juan A. Suarez Romero wrote: > On Tue, 2018-08-07 at 16:12 +0100, Emil Velikov wrote: > > On 6 August 2018 at 11:17, Juan A. Suarez Romero > wrote: > > > LLVM 6.0 requires GCC 4.9, which is not available in main Travis > > > repository. > > > > > > > We're not

Re: [Mesa-dev] [PATCH 2/2] travis: meson/Vulkan requires LLVM 6.0

2018-08-07 Thread Juan A. Suarez Romero
On Tue, 2018-08-07 at 16:20 +0100, Emil Velikov wrote: > On 6 August 2018 at 11:17, Juan A. Suarez Romero wrote: > > RADV now requires LLVM 6.0. > > > > Fixes: fd1121e8399 ("amd: remove support for LLVM 5.0") > > CC: Marek Olšák > > It seem that something went wrong splitting this from 1/2 -

Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Juan A. Suarez Romero
On Tue, 2018-08-07 at 16:12 +0100, Emil Velikov wrote: > On 6 August 2018 at 11:17, Juan A. Suarez Romero wrote: > > LLVM 6.0 requires GCC 4.9, which is not available in main Travis > > repository. > > > > We're not building LLVM 6.0 here, hence the commit message is a bit confusing. > Please

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2018-08-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #5 from mirh --- (In reply to mirh from comment #1) > Can confirm it fixes shader 2 and 5 of GraphicsFuzz demo > http://www.graphicsfuzz.com/benchmark/android-v1.html > > Should I wait for this (or, I dunno, some day sw fp64) to

[Mesa-dev] [PATCH v4 2/2] wayland/egl: update surface size on window resize

2018-08-07 Thread Juan A. Suarez Romero
According to EGL 1.5 spec, section 3.10.1.1 ("Native Window Resizing"): "If the native window corresponding to _surface_ has been resized prior to the swap, _surface_ must be resized to match. _surface_ will normally be resized by the EGL implementation at the time the native window is

[Mesa-dev] [PATCH v4 1/2] wayland/egl: initialize window surface size to window size

2018-08-07 Thread Juan A. Suarez Romero
When creating a windows surface with eglCreateWindowSurface(), the width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is invalid until buffers are updated (like calling glClear()). But according to EGL 1.5 spec, section 3.5.6 ("Surface Attributes"): "Querying EGL_WIDTH and

Re: [Mesa-dev] [PATCH 1/3] meson: use dependency()+find_program() for wayland-scanner

2018-08-07 Thread Emil Velikov
On 6 August 2018 at 17:39, Dylan Baker wrote: > Quoting Emil Velikov (2018-06-28 07:35:44) >> From: Emil Velikov >> >> Helps when the native wayland-scanner is located outside of PATH. >> Inspired by the xserver code ;-) >> >> Cc: Dylan Baker >> Cc: Eric Engestrom >> Signed-off-by: Emil

Re: [Mesa-dev] [PATCH 04/10] radeon/vcn: implement jpeg decode functions

2018-08-07 Thread Leo Liu
On 08/02/2018 03:44 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_jpeg.c | 286 ++- 1 file changed, 281 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 03/10] radeon/vcn: add jpeg decoder creation

2018-08-07 Thread Leo Liu
On 08/02/2018 03:44 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/Makefile.sources | 1 + src/gallium/drivers/radeon/meson.build | 1 + src/gallium/drivers/radeon/radeon_vcn_jpeg.c | 212

[Mesa-dev] [PATCH] gl.h: define GLeglImageOES depending on GL_EXT_EGL_image_storage

2018-08-07 Thread Brian Paul
To avoid duplicate typedef with the definition in glext.h V2: test for both GL_OES_EGL_image and GL_EXT_EGL_image_storage in case both the GL and GLES headers are included. Per Emil. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107488 Tested-by: Vinson Lee --- include/GL/gl.h | 2 +-

Re: [Mesa-dev] [PATCH 1/2] scons: require scons 2.4 or greater

2018-08-07 Thread Emil Velikov
On 1 August 2018 at 18:48, Juan A. Suarez Romero wrote: > There is a bug with scons 2.3, used in Travis, where it fails to detect > some C functions. Obviously this has landed, but for the future please provide examples instead of just "some". Thanks Emil

Re: [Mesa-dev] [PATCH 2/2] travis: meson/Vulkan requires LLVM 6.0

2018-08-07 Thread Emil Velikov
On 6 August 2018 at 11:17, Juan A. Suarez Romero wrote: > RADV now requires LLVM 6.0. > > Fixes: fd1121e8399 ("amd: remove support for LLVM 5.0") > CC: Marek Olšák It seem that something went wrong splitting this from 1/2 - not too sure. Regardless, Reviewed-by: Emil Velikov Aside: > @@

Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Emil Velikov
On 6 August 2018 at 11:17, Juan A. Suarez Romero wrote: > LLVM 6.0 requires GCC 4.9, which is not available in main Travis > repository. > We're not building LLVM 6.0 here, hence the commit message is a bit confusing. Please add more information on the topic - even a bug report if there is one.

Re: [Mesa-dev] [PATCH] gl.h: define GLeglImageOES depending on GL_EXT_EGL_image_storage

2018-08-07 Thread Emil Velikov
On 7 August 2018 at 15:23, Brian Paul wrote: > To avoid duplicate typedef with the definition in glext.h > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107488 > Tested-by: Vinson Lee > --- > include/GL/gl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH] xlib: remove unused Fake_glXGetAGPOffsetMESA() function

2018-08-07 Thread Emil Velikov
On 7 August 2018 at 15:24, Brian Paul wrote: > To silence compiler warning. > --- > src/mesa/drivers/x11/fakeglx.c | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fakeglx.c > index 233b6e2..b946521 100644 > ---

Re: [Mesa-dev] [PATCH mesa] meson: install KHR/khrplatform.h when needed

2018-08-07 Thread Emil Velikov
On 7 August 2018 at 15:40, Eric Engestrom wrote: > Fixes: f7d42ee7d319256608ad "include: update GL & GLES headers (v2)" > Signed-off-by: Eric Engestrom > --- > For some reason I didn't think to fix meson when I fixed autotools... I've assumed it was handling this in a completely different

[Mesa-dev] [PATCH mesa] meson: install KHR/khrplatform.h when needed

2018-08-07 Thread Eric Engestrom
Fixes: f7d42ee7d319256608ad "include: update GL & GLES headers (v2)" Signed-off-by: Eric Engestrom --- For some reason I didn't think to fix meson when I fixed autotools... --- include/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/meson.build

[Mesa-dev] [PATCH 1/3] svga: add TGSI_SEMANTIC_FACE switch case in svga_swtnl_update_vdecl()

2018-08-07 Thread Brian Paul
Fixes failed assertion running Piglit polygon-mode-face test. Though, the test still does not pass. Reviewed-by: Neha Bhende Reviewed-by: Charmaine Lee --- src/gallium/drivers/svga/svga_swtnl_state.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH] xlib: remove unused Fake_glXGetAGPOffsetMESA() function

2018-08-07 Thread Brian Paul
To silence compiler warning. --- src/mesa/drivers/x11/fakeglx.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fakeglx.c index 233b6e2..b946521 100644 --- a/src/mesa/drivers/x11/fakeglx.c +++ b/src/mesa/drivers/x11/fakeglx.c @@

[Mesa-dev] [PATCH] gl.h: define GLeglImageOES depending on GL_EXT_EGL_image_storage

2018-08-07 Thread Brian Paul
To avoid duplicate typedef with the definition in glext.h Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107488 Tested-by: Vinson Lee --- include/GL/gl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/GL/gl.h b/include/GL/gl.h index f5bac36..0f7ae70 100644

[Mesa-dev] [Bug 107511] KHR/khrplatform.h not always installed when needed

2018-08-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107511 Eric Engestrom changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] libdrm: Fix amdgpu build failure

2018-08-07 Thread Christian König
Hi Mike, it is not the right mailing list, but thanks for the info. I'm going to push that patch ASAP. Christian. Am 07.08.2018 um 14:38 schrieb Mike Lothian: Hi I'm not sure if this is the right mailing list or not but the following patch gets things building with meson again

Re: [Mesa-dev] libdrm: Fix amdgpu build failure

2018-08-07 Thread Emil Velikov
On 7 August 2018 at 13:38, Mike Lothian wrote: > Hi > > I'm not sure if this is the right mailing list or not but the > following patch gets things building with meson again > > Signed-of-by: Mike Lothian > I'll add the following and push in a moment. Fixes: d6cb0ee408e ("amdgpu: remove the

[Mesa-dev] libdrm: Fix amdgpu build failure

2018-08-07 Thread Mike Lothian
Hi I'm not sure if this is the right mailing list or not but the following patch gets things building with meson again Signed-of-by: Mike Lothian diff --git a/amdgpu/meson.build b/amdgpu/meson.build index f39d7bf6..d9d7de2d 100644 --- a/amdgpu/meson.build +++ b/amdgpu/meson.build @@ -26,8

Re: [Mesa-dev] [PATCH mesa] configure: install KHR/khrplatform.h when needed

2018-08-07 Thread Emil Velikov
On 7 August 2018 at 12:58, Eric Engestrom wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107511 > Fixes: f7d42ee7d319256608ad "include: update GL & GLES headers (v2)" > Signed-off-by: Eric Engestrom Thanks Eric. Reviewed-by: Emil Velikov -Emil

Re: [Mesa-dev] [PATCH mesa] configure: install KHR/khrplatform.h when needed

2018-08-07 Thread Brad King
On 08/07/2018 07:58 AM, Eric Engestrom wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107511 > Fixes: f7d42ee7d319256608ad "include: update GL & GLES headers (v2)" [snip] > AM_CONDITIONAL(NEED_KHRPLATFORM, test "x$enable_egl" = xyes -o \ > +

[Mesa-dev] [PATCH mesa] configure: install KHR/khrplatform.h when needed

2018-08-07 Thread Eric Engestrom
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107511 Fixes: f7d42ee7d319256608ad "include: update GL & GLES headers (v2)" Signed-off-by: Eric Engestrom --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index

[Mesa-dev] [Bug 107508] Crash in st_renderbuffer_delete()

2018-08-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107508 Olivier Fourdan changed: What|Removed |Added Attachment #140994|0 |1 is obsolete|

[Mesa-dev] [Bug 107511] KHR/khrplatform.h not always installed when needed

2018-08-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107511 Bug ID: 107511 Summary: KHR/khrplatform.h not always installed when needed Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity:

[Mesa-dev] [PATCH mesa v2] i965: searching the cache doesn't need to modify it

2018-08-07 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- v2: forgot the hunk that was the point of this :facepalm: --- src/mesa/drivers/dri/i965/brw_program_cache.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c

  1   2   >