Re: [Mesa-dev] [PATCH v3 4/4] nv50/ir: further optimize multiplication by immediates

2018-08-11 Thread Karol Herbst
yeah, I was mainly commenting on the questionble performance gains. We can't just assume less instructions == more perf as we don't really know what changing instructions really means. And right, I wasn't really taking LoadPropagation into account, but it seems like that at least nvidia prefers XM

[Mesa-dev] [Bug 107547] shader crashing glsl_compiler (uniform block assigned to vec2, then component substraced by 1)

2018-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107547 --- Comment #2 from Karol Herbst --- crashes only with "-Dbuildtype=release" -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesk

[Mesa-dev] [Bug 107547] shader crashing glsl_compiler (uniform block assigned to vec2, then component substraced by 1)

2018-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107547 --- Comment #1 from Karol Herbst --- seems to only happen with a certain build config (doesn't happen on my debug build). Will investigate. -- You are receiving this mail because: You are the assignee for the bug.__

[Mesa-dev] [Bug 107547] shader crashing glsl_compiler (uniform block assigned to vec2, then component substraced by 1)

2018-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107547 Bug ID: 107547 Summary: shader crashing glsl_compiler (uniform block assigned to vec2, then component substraced by 1) Product: Mesa Version: git Hardware: Other

[Mesa-dev] [PATCH] glx: fill out GLX_DONT_CARE values

2018-08-11 Thread Lionel Landwerlin
When associating a template GLX config to a DRI one (filled out by the driver), we need to update the GLX_DONT_CARE fields (like yInverted for example). Otherwise those fields will report GLX_DONT_CARE to the application which is not what the driver is actually doing. Signed-off-by: Lionel Landwer

Re: [Mesa-dev] [PATCH] intel: Switch the order of the 2x MSAA sample positions

2018-08-11 Thread Jason Ekstrand
On Thu, Aug 9, 2018 at 3:03 PM Anuj Phogat wrote: > On Wed, Aug 8, 2018 at 11:31 AM Jason Ekstrand > wrote: > > > > The Vulkan 1.1.82 spec flipped the order to better match D3D. > > > > Cc: mesa-sta...@lists.freedesktop.org > > --- > > src/intel/blorp/blorp_blit.c | 11 +++

Re: [Mesa-dev] [PATCH v3 4/4] nv50/ir: further optimize multiplication by immediates

2018-08-11 Thread Rhys Perry
It seems multiplication by negative powers of two are nonexistent in the shader-db, so an specialized optimization for them would probably not be worth it. It seems my approach gives better instruction counts in shader-db than your approach, since it can generate shorter (for things like a * 7) an

Re: [Mesa-dev] [PATCH 1/2 v2] blorp: Don't try to use R32_UNORM for R24_UNORM_X8_TYPELESS rendering.

2018-08-11 Thread Jason Ekstrand
This needs a fixes tag. With that added, rb. I really have no idea how this worked before. I was sure I had it working and that it was being tested but it's definitely bogus. :-( On August 10, 2018 23:57:11 Kenneth Graunke wrote: The hardware doesn't support rendering to R24_UNORM_X8_TYPELE

Re: [Mesa-dev] [PATCH] nir/lower_samplers: don't assume a deref for both texture and sampler srcs

2018-08-11 Thread Jason Ekstrand
On August 11, 2018 06:13:17 Alejandro Piñeiro wrote: After commit "nir: Use derefs in nir_lower_samplers" (75286c2d083cdbdfb202a93349e567df0441d5f7) assumes one deref for both the texture and the sampler. However there are cases (on OpenGL, using ARB_gl_spirv) where SPIR-V is not providing a sa

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2018-08-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #6 from Gert Wollny --- I've pushed the series, so this might be fixed (although I've seen new piglits that fail with the same error also with this array split patch series applied. -- You are receiving this mail because: You are t

[Mesa-dev] [PATCH] nir/lower_samplers: don't assume a deref for both texture and sampler srcs

2018-08-11 Thread Alejandro Piñeiro
After commit "nir: Use derefs in nir_lower_samplers" (75286c2d083cdbdfb202a93349e567df0441d5f7) assumes one deref for both the texture and the sampler. However there are cases (on OpenGL, using ARB_gl_spirv) where SPIR-V is not providing a sampler, like for texture query levels ops. Although we cou

Re: [Mesa-dev] [PATCH] intel/decoder: fix the possible out of bounds group_iter

2018-08-11 Thread asimiklit
Hi all, Andrey also opened a bug about this issue : https://bugs.freedesktop.org/show_bug.cgi?id=107544 It feels like it should be fixed on master though. get_length() shouldn't return -1 for structs anymore. We should probably return 1 at end of get_length() so that the decoder prints out "unk

Re: [Mesa-dev] [PATCH v3 4/4] nv50/ir: further optimize multiplication by immediates

2018-08-11 Thread Karol Herbst
I think we could do something else (which may even cover more cases): 1. try to use a shl (we already do that) 2 use shladd for all negative imms with for all power of two negative immediates (are we already doing it? I think we miss a lot of opts where "worse" instructions could include modifier