u_cpu_detect should detect what's really available, not what is used
(though indeed we actually disable u_cpu bits explicitly in gallivm for
some sse features, but this is a hack).
So I think it would be better if u_cpu_detect sets the has_vsx bit
regardless what the env var is and then enable it
Quoting Jason Ekstrand (2018-08-08 01:12:49)
> Because lower_ycbcr gets called before apply_pipeline_layout, the
> indices are all logical and the binding layout HW size is actually too
> big for the bounds check. We should just use the regular logical array
> size instead.
>
> Fixes:
Previously gallivm would attempt to use VSX instructions on all systems
where it detected that Altivec is supported; however, VSX was added to
POWER long after Altivec, causing lots of crashes on older POWER/PPC
hardware, e.g. PPC Macs. By detecting VSX separately from Altivec we can
automatically
On Mon, 2018-08-20 at 12:06 +0200, Juan A. Suarez Romero wrote:
> On Tue, 2018-08-14 at 11:00 +0100, Emil Velikov wrote:
> > On 8 August 2018 at 15:36, Juan A. Suarez Romero
> > wrote:
> > > Like in the autotools target, make the list of drivers to be built in
> > > each of the Meson targets
From: Andrii Simiklit
If we restore the 'new batch' using 'intel_batchbuffer_reset_to_saved'
function we must restore the default state of the batch using
'brw_new_batch' function because the 'intel_batchbuffer_flush'
function will not do it for the 'new batch' again.
At least the following
From: Andrii Simiklit
If we restore the 'new batch' using 'intel_batchbuffer_reset_to_saved'
function we must restore the default state of the batch using
'brw_new_batch' function because the 'intel_batchbuffer_flush'
function will not do it for the 'new batch' again.
At least the following
On Thu, 2018-08-09 at 09:03 -0700, Dylan Baker wrote:
> Quoting Juan A. Suarez Romero (2018-08-07 08:49:36)
> > When creating a windows surface with eglCreateWindowSurface(), the
> > width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is
> > invalid until buffers are updated (like
This fixes `make distcheck`.
Fixes: 471f708ed6 ("git_sha1: simplify logic")
CC: Eric Engestrom
---
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 396865cbe55..412510f435b 100644
--- a/src/Makefile.am
+++
https://bugs.freedesktop.org/show_bug.cgi?id=107224
--- Comment #10 from Alex Smith ---
We've just released a game data update that should fix this issue for both AMD
and Intel, as well as a shader compilation failure on 18.2. It should be
applied next time you launch the game (it's handled
Hi Plamena,
Thankyou for the fast review. Can you push it or have someone push it? (I
do not have push rights)
-Keviv
On Mon, Aug 20, 2018, 2:50 PM Manolova, Plamena
wrote:
> Hi Kevin,
> This looks good to me :)
>
> Reviewed-by: Plamena Manolova
>
> On Wed, Aug 15, 2018 at 2:29 PM, wrote:
On Fri, Aug 10, 2018 at 01:13:31PM +0200, Mathias Fröhlich wrote:
> Hi Ville,
>
> > Looks like
> > "vid_gl20" "0"
> > is needed to reproduce the issue.
>
> Thanks! Now I can observe the problem!
> And the attached patch seems to fix what I can observe here.
> Does the attached patch also fix the
On 13 August 2018 at 17:18, Tomasz Figa wrote:
> On Tue, Aug 14, 2018 at 1:09 AM Emil Velikov wrote:
>>
>> On 13 August 2018 at 16:43, Tomasz Figa wrote:
>> > On Tue, Aug 14, 2018 at 12:35 AM Emil Velikov
>> > wrote:
>> >>
>> >> On 13 August 2018 at 16:16, Tomasz Figa wrote:
>> >> > Hi Emil,
From Section 4.3.4 (Inputs) of the GLSL 1.50 spec:
"Only the input variables that are actually read need to be written
by the previous stage; it is allowed to have superfluous
declarations of input variables."
Fixes:
* interstage-multiple-shader-objects.shader_test
Bugzilla:
On 8/20/18 4:28 PM, Lionel Landwerlin wrote:
Reviewed-by: Lionel Landwerlin
Thanks!
Do you need me to push it?
Yes
Thanks,
-
Lionel
On 08/08/18 16:03, Danylo Piliaiev wrote:
Hi,
Since the exact value is not important for users, Roland offered
compelling explanation
and the value
Reviewed-by: Lionel Landwerlin
Do you need me to push it?
Thanks,
-
Lionel
On 08/08/18 16:03, Danylo Piliaiev wrote:
Hi,
Since the exact value is not important for users, Roland offered
compelling explanation
and the value is also 8 on Windows - could the patch be reviewed/pushed?
-
https://bugs.freedesktop.org/show_bug.cgi?id=106630
Samuel Pitoiset changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
El 29/07/18 a las 19:47, Chema Casanova escribió:
> El 28/07/18 a las 01:45, Francisco Jerez escribió:
>> Chema Casanova writes:
[...]
> If we have a partial write/read:
>
> I understood that you my initial patter proposal would only be ok for
> the first GRF of src[i]/dst
This is quite useful for debugging shader-transpiling issues in
virglrenderer.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_encode.c | 3 +++
src/gallium/drivers/virgl/virgl_screen.c | 1 +
src/gallium/drivers/virgl/virgl_screen.h | 1 +
3 files changed, 5 insertions(+)
This adds an environment-varaible that can be used for driver-specific
flags, as well as a flag for it to enable verbose output.
While we're at it, quiet some overly chatty debug-output by default.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_context.c | 6 --
This is the only direct call-site for fprintf in virgl; all other
call-sites call debug_printf instead. So let's follow in style here.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_encode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Here's some patches that cleans up debug-printing in virgl a bit, by
using the existing debug environment-variable infrastructure so things
can be turned on and off explicitly.
This version introduce two flags:
- verbose: enables verbose output. This is useful to get information on
some
This is just debug-cruft left over. Let's just get rid of it.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_encode.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/drivers/virgl/virgl_encode.h
b/src/gallium/drivers/virgl/virgl_encode.h
index
Sorry, made a mistake when sending this series out. I'll resend
properly soon.
On Mon, Aug 20, 2018 at 2:03 PM, Erik Faye-Lund
wrote:
This adds an environment-varaible that can be used for driver-specific
flags, as well as a flag for it to enable verbose output.
While we're at it, quiet
This is just debug-cruft left over. Let's just get rid of it.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_encode.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/drivers/virgl/virgl_encode.h
b/src/gallium/drivers/virgl/virgl_encode.h
index
This is the only direct call-site for fprintf in virgl; all other
call-sites call debug_printf instead. So let's follow in style here.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_encode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This adds an environment-varaible that can be used for driver-specific
flags, as well as a flag for it to enable verbose output.
While we're at it, quiet some overly chatty debug-output by default.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_context.c | 6 --
Installing of Vulkan on Ubuntu 16.04 fails during relinking.
Seems caught libtool-issue.
Library-dependicies GL_LIB_DEPS moved upper.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107624
Signed-off-by: Sergii Romantsov
---
src/glx/Makefile.am | 4 ++--
1 file changed, 2 insertions(+),
Hi Kevin,
This looks good to me :)
Reviewed-by: Plamena Manolova
On Wed, Aug 15, 2018 at 2:29 PM, wrote:
> From: Kevin Rogovin
>
> The main purpose for having NV_fragment_shader_interlock
> extension is because that extension is also for GLES31 while
> the ARB extension is for GL only.
> ---
https://bugs.freedesktop.org/show_bug.cgi?id=106590
--- Comment #6 from Kenneth Graunke ---
(In reply to Mark Janes from comment #5)
> This seems like a duplicate of
>
> https://bugs.freedesktop.org/show_bug.cgi?id=106807
>
> My faint recollection is that the specification of the __LINE__
The git core.autocrlf setting defaults to true (ie, all text files get
checked out as CRLF on Windows), except on Appveyor where's set to
"input" (ie, all text files get checked out with the upstream
repository's line endings, which for us typically means LF.)
And this was masking on Appveyor a
On 17/08/18 17:57, Yunchao He wrote:
This extension can be supported on SKL+. With this patch,
all corresponding tests (6K+) in CTS can pass. No test fails.
I verified CTS with the command below:
deqp-vk --deqp-case=dEQP-VK.pipeline.sampler.view_type.*reduce*
v2: 1) support all depth formats,
On 08/17/2018 12:15 PM, Tapani Pälli wrote:
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index dc398306a70..f1506b8acbe
https://bugs.freedesktop.org/show_bug.cgi?id=103122
Timothy Arceri changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Friday, August 17, 2018 1:06:12 PM PDT Jason Ekstrand wrote:
> ---
> src/compiler/nir/nir_format_convert.h | 35 +--
> 1 file changed, 27 insertions(+), 8 deletions(-)
>
> diff --git a/src/compiler/nir/nir_format_convert.h
> b/src/compiler/nir/nir_format_convert.h
>
v2:
- moved TCL dri config options to old radeon drivers instead
of replacing with env var.
- some reviewed patches from previous series pushed
This series removes some unused options, replaces some legacy
debug options with env vars instead and moves a bunch of old
radeon dri driver options
---
src/mesa/drivers/dri/radeon/radeon_screen.c | 10 +
src/mesa/drivers/dri/radeon/radeon_screen.h | 5 +
src/util/xmlpool/ca.po | 23 -
src/util/xmlpool/de.po | 23 -
src/util/xmlpool/es.po
https://bugs.freedesktop.org/show_bug.cgi?id=107563
--- Comment #9 from Samuel Pitoiset ---
The rendering issue is fixed with
https://cgit.freedesktop.org/mesa/mesa/commit/?id=0aacb5eab6120aa1410966d23101e16eea3fbcd7
--
You are receiving this mail because:
You are the assignee for the bug.
You
This seems to have only been used by DRI1 drivers which were
removed with e4344161bde2.
---
src/util/xmlpool/ca.po | 4
src/util/xmlpool/de.po | 4
src/util/xmlpool/es.po | 4
src/util/xmlpool/fr.po | 4
src/util/xmlpool/nl.po | 4
Hey Linoel,
Lionel Landwerlin wrote on 20.08.2018 11:19:
> On 20/08/18 09:16, Kai Wasserbäch wrote:
>> Lionel Landwerlin wrote on 19.08.2018 11:05:
>>> Patches 6, 7, 10 & 11 are :
>>>
>>> Reviewed-by: Lionel Landwerlin
>> thanks! Feel free to push, I don't have commit access (see cover letter).
>
On Friday, August 17, 2018 1:06:17 PM PDT Jason Ekstrand wrote:
> Instead of requiring 4 components, this allows them to potentially use
> fewer. Both the SPIR-V and GLSL paths still generate vec4 intrinsics so
> drivers which assume 4 components should be safe. However, we want to
> be able to
---
src/mesa/drivers/dri/radeon/radeon_screen.h | 10 ++
src/util/xmlpool/ca.po | 12
src/util/xmlpool/de.po | 12
src/util/xmlpool/es.po | 12
src/util/xmlpool/fr.po
On 20/08/18 09:16, Kai Wasserbäch wrote:
Hey Lionel,
Lionel Landwerlin wrote on 19.08.2018 11:05:
Patches 6, 7, 10 & 11 are :
Reviewed-by: Lionel Landwerlin
thanks! Feel free to push, I don't have commit access (see cover letter).
Will do.
There are 2 existing series touching the same
On Friday, August 17, 2018 1:06:14 PM PDT Jason Ekstrand wrote:
> ---
> src/compiler/nir/nir_format_convert.h | 56 +++
> 1 file changed, 56 insertions(+)
>
> diff --git a/src/compiler/nir/nir_format_convert.h
> b/src/compiler/nir/nir_format_convert.h
> index
On Tue, 2018-08-14 at 11:00 +0100, Emil Velikov wrote:
> On 8 August 2018 at 15:36, Juan A. Suarez Romero wrote:
> > Like in the autotools target, make the list of drivers to be built in
> > each of the Meson targets explicit.
> >
> > This will help to identify missing dependencies and other
On 15/08/18 10:45, andrey simiklit wrote:
Hi all,
Thanks for your reply.
We shouldn't even get to use the iterator if it's an unknown
instruction.
The decoder should just advance dword by dword until it finds
something that
makes sense again.
Got it)
So this is an
On Friday, August 17, 2018 5:13:25 PM PDT Anuj Phogat wrote:
> It fixes simulator warnings in piglit tests complaining about missing
> support for headerless sampler messages for pre-emptable contexts.
> Bit 5 in SAMPLER MODE register is newly introduced for ICLLP.
>
> Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/radeon/radeon_screen.h | 13 +
src/util/xmlpool/ca.po | 20
src/util/xmlpool/de.po | 20
src/util/xmlpool/es.po | 20
On Wednesday, August 15, 2018 3:13:09 AM PDT Timothy Arceri wrote:
> This series removes some unused options, replaces some legacy
> debug options with env vars instead and moves a bunch of old
> radeon dri driver options directly into the drivers.
>
> I haven't bothered copying all the radeon
For user can use dri_driver drirc option even on
environment without libdrm.
Tested on build with and without libdrm.
Signed-off-by: Qiang Yu
---
src/loader/loader.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/loader/loader.c b/src/loader/loader.c
index
On Friday, August 17, 2018 1:06:16 PM PDT Jason Ekstrand wrote:
> Fixes: 4e337b42f9a2 "nir/format_convert: Add pack/unpack for R11F_G11F_B10F"
> ---
> src/compiler/nir/nir_format_convert.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
https://bugs.freedesktop.org/show_bug.cgi?id=107610
--- Comment #1 from Samuel Pitoiset ---
Can you record a renderdoc trace instead please?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=91889
Timothy Arceri changed:
What|Removed |Added
Resolution|--- |NOTOURBUG
Status|NEW
---
src/mesa/drivers/dri/radeon/radeon_screen.h | 10 ++
src/util/xmlpool/ca.po | 12
src/util/xmlpool/de.po | 12
src/util/xmlpool/es.po | 12
src/util/xmlpool/fr.po
https://bugs.freedesktop.org/show_bug.cgi?id=107169
Timothy Arceri changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop
This driver is in maintenance mode so lets remove this hidden
unsafe option.
---
src/mesa/drivers/dri/i915/i915_vtbl.c | 8
src/mesa/drivers/dri/i915/intel_context.c | 2 --
src/mesa/drivers/dri/i915/intel_context.h | 2 --
src/mesa/drivers/dri/i915/intel_screen.c | 4
4 files
Hey Lionel,
Lionel Landwerlin wrote on 19.08.2018 11:05:
> Patches 6, 7, 10 & 11 are :
>
> Reviewed-by: Lionel Landwerlin
thanks! Feel free to push, I don't have commit access (see cover letter).
> There are 2 existing series touching the same code, in patches 8, 9 & 12, I
> think should land
---
src/mesa/drivers/dri/radeon/radeon_screen.h | 12
src/util/xmlpool/ca.po | 16
src/util/xmlpool/de.po | 16
src/util/xmlpool/es.po | 16
src/util/xmlpool/fr.po
---
src/mesa/drivers/dri/radeon/radeon_screen.c | 5 +
src/util/xmlpool/ca.po | 4
src/util/xmlpool/de.po | 4
src/util/xmlpool/es.po | 4
src/util/xmlpool/fr.po | 4
src/util/xmlpool/nl.po
---
src/mesa/drivers/dri/radeon/radeon_screen.c | 5 +
src/util/xmlpool/ca.po | 4
src/util/xmlpool/de.po | 4
src/util/xmlpool/es.po | 4
src/util/xmlpool/fr.po | 4
src/util/xmlpool/nl.po
Forcing software fallbacks for i965 hasn't been an option since
5e3c093ff866.
---
src/mesa/drivers/dri/i965/brw_context.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_context.h
b/src/mesa/drivers/dri/i965/brw_context.h
index 72be8f2a4d0..c32def7c3d7 100644
---
---
src/mesa/drivers/dri/radeon/radeon_screen.h | 12
src/util/xmlpool/ca.po | 17 -
src/util/xmlpool/de.po | 17 -
src/util/xmlpool/es.po | 17 -
src/util/xmlpool/fr.po
In order to be sure loop_terminator_list is an accurate
representation of all the jumps in the loop we need to be sure we
didn't encounter any other complex behaviour such as continues,
nested breaks, etc during analysis.
This will be used in the following patch.
Reviewed-by: Jason Ekstrand
---
In GLSL IR we cheat with switch statements and simply convert them
into loops with a single iteration. This allowed us to make use of
the existing jump instruction handling provided by the loop handing
code, it also allows dead code to be cleaned up once we have
wrapped the code in a loop.
This will help later patches with unrolling loops that end with a
break i.e. loops the always exit on their first interation.
Reviewed-by: Jason Ekstrand
---
src/compiler/nir/nir_loop_analyze.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
On Friday, August 17, 2018 5:14:52 PM PDT Anuj Phogat wrote:
> Gen 11 workarounds table #2056 WABTPPrefetchDisable suggests to
> disable prefetching of binding tables for ICLLP A0 and B0
> steppings. We have a similar patch for i965 driver in Mesa
> commit a5889d70.
>
> Signed-off-by: Anuj
shader-db IVB results:
total instructions in shared programs: 9993483 -> 9993472 (-0.00%)
instructions in affected programs: 1300 -> 1289 (-0.85%)
helped: 11
HURT: 0
total cycles in shared programs: 219476091 -> 219476059 (-0.00%)
cycles in affected programs: 7675 -> 7643 (-0.42%)
helped: 10
On 08/13/2018 03:52 PM, Ian Romanick wrote:
> On 08/09/2018 01:09 PM, Marek Olšák wrote:
>> On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge wrote:
>>> enable _mesa_PushAttrib() and _mesa_PopAttrib()
>>> to handle GL_DEPTH_CLAMP_NEAR_AMD and
>>> GL_DEPTH_CLAMP_FAR_AMD tokens.
>>>
>>> Signed-off-by:
---
src/mesa/drivers/dri/radeon/radeon_screen.c | 5 +
src/util/xmlpool/ca.po | 6 --
src/util/xmlpool/de.po | 4
src/util/xmlpool/es.po | 4
src/util/xmlpool/fr.po | 4
This was added as a workaround for Heaven 3.0 but was later removed
by 5ead448719f3 to allow Heaven 4.0 to work correctly.
---
src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 1 -
src/gallium/include/state_tracker/st_api.h | 1 -
src/gallium/state_trackers/dri/dri_screen.c
https://bugs.freedesktop.org/show_bug.cgi?id=100708
Timothy Arceri changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=106590
--- Comment #5 from Mark Janes ---
This seems like a duplicate of
https://bugs.freedesktop.org/show_bug.cgi?id=106807
My faint recollection is that the specification of the __LINE__ macro is
inconsistent. If, as Ken says, this has been
https://bugs.freedesktop.org/show_bug.cgi?id=105859
Timothy Arceri changed:
What|Removed |Added
Resolution|--- |WORKSFORME
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=99388
Timothy Arceri changed:
What|Removed |Added
Component|Mesa core |Drivers/OSMesa
Status|NEW
Since we know what side of the branch we ended up on we can just
replace the use with a constant.
All the spill changes in shader-db are from Dolphin uber shaders,
despite some small regressions the change is clearly positive.
V2: insert new constant after any phis in the
Add enviroment var overrides to legacy drivers instead.
---
src/mesa/drivers/dri/i915/intel_context.c| 2 +-
src/mesa/drivers/dri/i915/intel_screen.c | 1 -
src/mesa/drivers/dri/i965/intel_screen.c | 1 -
src/mesa/drivers/dri/r200/r200_context.c | 2 +-
Now that SSA values can be derefs and they have special rules, we have
to be a bit more careful about our LCSSA phis. In particular, we need
to clean up in case LCSSA ended up creating a phi node for a deref.
This avoids validation issues with some CTS tests with the following
patch, but its
This adds support for unrolling the classic
do {
// ...
} while (false)
that is used to wrap multi-line macros. GLSL IR also wraps switch
statements in a loop like this.
shader-db results IVB:
total loops in shared programs: 2515 -> 2512 (-0.12%)
loops in affected programs: 33
https://bugs.freedesktop.org/show_bug.cgi?id=107224
Timothy Arceri changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Hello,
Does any of the mesa driver's Vulkan implementations support
specialization constants as array sizes ? In particular, the constants
clspv generates for local variable array size.
Thanks,
-- mb
___
mesa-dev mailing list
Hi Kai,
Patches 6, 7, 10 & 11 are :
Reviewed-by: Lionel Landwerlin
There are 2 existing series touching the same code, in patches 8, 9 &
12, I think should land before the warnings are fixed.
Thanks,
-
Lionel
On 18/08/18 12:16, Kai Wasserbäch wrote:
Hey,
thanks to Bas and Timothy for
101 - 180 of 180 matches
Mail list logo
