Re: [Mesa-dev] [PATCH] radv-report: Show biggest improvements

Reviewed-by: Samuel Pitoiset On 11/22/18 1:52 AM, Timothy Arceri wrote: Being able to see improvements as well as regressions is useful during the development of shader opts. Ported from commit 8f0c7aca8683 in shader-db --- radv-report.py | 30 ++ 1 file

[Mesa-dev] [PATCH] anv: allow exporting an imported SYNC_FD semaphore type

Fixes issues with following SkQP tests: unitTest_VulkanHardwareBuffer_Vulkan_EGL_Syncs unitTest_VulkanHardwareBuffer_Vulkan_Vulkan_Syncs Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_queue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] anv: Put robust buffer access in the pipeline hash

For both patches: Reviewed-by: Iago Toral Quiroga On Wed, 2018-11-21 at 17:20 -0600, Jason Ekstrand wrote: > It affects apply_pipeline_layout. Shaders compiled with the wrong > value > will work but they may not be robust as requested by the app. > > Cc: mesa-sta...@lists.freedesktop.org >

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush

Hi Brian, Keith, +Some more Chromium folks for visibility. On Wed, Aug 22, 2018 at 4:21 PM Tomasz Figa wrote: > > Hi Michel, > > On Thu, Aug 16, 2018 at 6:43 PM Michel Dänzer wrote: > > > > On 2018-08-16 11:34 AM, Tomasz Figa wrote: > > > If there is no last fence, due to no rendering

[Mesa-dev] [PATCH 2/2] virgl: don't mark buffers as unclean after a write

We can mark the buffer unclean if it's ever bound as a TBO, SSBO, ABO, or image. This improves dEQP-GLES3.performance.buffer.data_upload.function_call.map_buffer_range.new_specified_buffer.flag_write_full.stream_draw from 9.58 MB/s to 451.17 MB/s. v2: Using buffer bindings to track cleanliness

[Mesa-dev] [PATCH 1/2] virgl: avoid large inline transfers

We flush everytime the command buffer (16 kB) is full, which is quite costly. This improves dEQP-GLES3.performance.buffer.data_upload.function_call.buffer_data.new_buffer.usage_stream_draw from 111.16 MB/s to 1930.36 MB/s. In addition, I made the benchmark produce buffers from 0 -->

Re: [Mesa-dev] [PATCH] radv-report: Show biggest improvements

Sorry the subject should probably have been something like: vkpipline-db: Show biggest improvements in radv-report On 22/11/18 11:52 am, Timothy Arceri wrote: Being able to see improvements as well as regressions is useful during the development of shader opts. Ported from commit

[Mesa-dev] [PATCH] radv-report: Show biggest improvements

Being able to see improvements as well as regressions is useful during the development of shader opts. Ported from commit 8f0c7aca8683 in shader-db --- radv-report.py | 30 ++ 1 file changed, 30 insertions(+) diff --git a/radv-report.py b/radv-report.py index

Re: [Mesa-dev] [PATCH 14/22] nir: add legal bit_sizes to intrinsics

On Wed, Nov 21, 2018 at 10:58 PM Jason Ekstrand wrote: > > > > On Tue, Nov 13, 2018 at 9:49 AM Karol Herbst wrote: >> >> With OpenCL some system values match the address bits, but in GLSL we also >> have some system values being 64 bit. >> >> With this it is possible to adjust the builder

Re: [Mesa-dev] [PATCH 3/3] glsl: fix typos in comments "transfor" -> "transform"

On 21/11/18 20:07, Ilia Mirkin wrote: > Oh, yay, you fixed the typos here. I just had to keep reading. > > This patch is obviously > > Reviewed-by: Ilia Mirkin Thanks. > > For the others ... have you run these through intel's CI? > I'm interested in verifying that dEQP, CTS, and piglit all

[Mesa-dev] [Bug 32211] [GLSL] lower_jumps with continue-statements in for-loops prevents loop unrolling

https://bugs.freedesktop.org/show_bug.cgi?id=32211 --- Comment #13 from Timothy Arceri --- (In reply to Danylo from comment #12) > (In reply to Timothy Arceri from comment #11) > > > > So all we need to do is move everything after the if into the else block and > > remove the continue. Removing

Re: [Mesa-dev] [PATCH 1/3] glsl: XFB TSC per-vertex output varyings match as not declared as arrays

On 21/11/18 20:04, Ilia Mirkin wrote: > On Wed, Nov 21, 2018 at 1:45 PM Jose Maria Casanova Crespo > wrote: >> >> Recent change on OpenGL CTS ("Use non-arrayed varying name for TCS blocks") >> on KHR-GL*.tessellation_shader.single.xfb_captures_data_from_correct_stage >> tests changed how to

[Mesa-dev] [PATCH] virgl: quadruple command buffer size

Tested running WebGL aquarium on Nvidia host (10,000 fishes) This moves us from 7 fps to 9 fps. After quadrupling, performance gains diminish. Change-Id: Iba3a9929ba2d17cf5a38233b92391dd413b79bc2 --- src/gallium/drivers/virgl/virgl_winsys.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 2/2] anv/nir: Rework arguments to apply_pipeline_layout

Instead of taking a whole pipeline (which could be anything!), just take a physical device and robust_buffer_access boolean. This makes it easier to verify that only the things in the hash actually affect pipeline compilation. --- src/intel/vulkan/anv_nir.h | 3 ++-

[Mesa-dev] [PATCH 1/2] anv: Put robust buffer access in the pipeline hash

It affects apply_pipeline_layout. Shaders compiled with the wrong value will work but they may not be robust as requested by the app. Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_pipeline.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] intel/compiler: Always print flag subregister number

On Thu, Nov 15, 2018 at 2:16 PM Sagar Ghuge wrote: > > While disassembling the predicate always print flag subregister number > to keep grammar same across the generation for assembler tool. That's reasonable. > Signed-off-by: Sagar Ghuge > --- > src/intel/compiler/brw_disasm.c | 3 +-- > 1

[Mesa-dev] [Bug 99553] Tracker bug for runnning OpenCL applications on Clover

https://bugs.freedesktop.org/show_bug.cgi?id=99553 Bug 99553 depends on bug 108087, which changed state. Bug 108087 Summary: Memory leak in clover::kernel::argument::create<>() (i.e. clEnqueueNDRangeKernel()) https://bugs.freedesktop.org/show_bug.cgi?id=108087 What|Removed

[Mesa-dev] [Bug 108087] Memory leak in clover::kernel::argument::create<>() (i.e. clEnqueueNDRangeKernel())

https://bugs.freedesktop.org/show_bug.cgi?id=108087 Dylan Baker changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 14/22] nir: add legal bit_sizes to intrinsics

On Tue, Nov 13, 2018 at 9:49 AM Karol Herbst wrote: > With OpenCL some system values match the address bits, but in GLSL we also > have some system values being 64 bit. > > With this it is possible to adjust the builder functions so that depending > on the bit_sizes the correct bit_size is used

Re: [Mesa-dev] [PATCH 12/22] nir: add type alignment support to lower_io

On Tue, Nov 13, 2018 at 9:48 AM Karol Herbst wrote: > From: Rob Clark > > For cl we can have structs with 8/16/32/64 bit scalar types (as well as, > ofc, arrays/structs/etc), which are padded according to 'C' rules. So > for lowering struct deref's we need to not just consider a field's size,

Re: [Mesa-dev] [PATCH 10/22] nir/vtn: add caps for some cl related capabilities

patches 6 and 10 are Reviewed-by: Jason Ekstrand On Tue, Nov 13, 2018 at 9:49 AM Karol Herbst wrote: > From: Rob Clark > > vtn supports these, so don't squalk if user is happy with enabling > these. > > Signed-off-by: Karol Herbst > --- > src/compiler/shader_info.h | 3 +++ >

Re: [Mesa-dev] [PATCH 04/22] nir/spirv: add OpIsFinite and OpIsNormal

On Tue, Nov 13, 2018 at 9:48 AM Karol Herbst wrote: > From: Rob Clark > > changes by Karol: > v2: make compatible with 64 bit floats > fix isfinite > v3: use snake_case. > > Signed-off-by: Karol Herbst > --- > src/compiler/spirv/vtn_alu.c | 32 > 1 file

Re: [Mesa-dev] [PATCH 3/7] util/slab: Add function to flush allocations from a child pool

On 21.11.18 22:23, Ian Romanick wrote: > On 11/21/2018 12:23 PM, Haehnle, Nicolai wrote: >> On 21.11.18 19:19, Ian Romanick wrote: >>> On 11/21/2018 03:08 AM, Haehnle, Nicolai wrote: On 21.11.18 01:39, Ian Romanick wrote: > From: Ian Romanick > > Ralloc has a feature that all

Re: [Mesa-dev] [PATCH 3/7] util/slab: Add function to flush allocations from a child pool

On 11/21/2018 12:23 PM, Haehnle, Nicolai wrote: > On 21.11.18 19:19, Ian Romanick wrote: >> On 11/21/2018 03:08 AM, Haehnle, Nicolai wrote: >>> On 21.11.18 01:39, Ian Romanick wrote: From: Ian Romanick Ralloc has a feature that all allocations from a temporary memory context

Re: [Mesa-dev] [PATCH mesa 00/13] Make standard function available on non-standard platforms

On 11/21/2018 12:16 PM, Jose Fonseca wrote: >>   util: use standard name for strncat() > >>   util: use standard name for strncmp() >>   util: use standard name for strcmp() >>   util: use standard name for strchr() >>   util: use standard name for sprintf() >>   util: use standard name for

Re: [Mesa-dev] [PATCH 2/7] nir/phi_builder: Use hash table to store [value, block] -> def mapping

On IRC, Jason had asked about performance overhead of using the hash table. A full run of shader-db on a release build (with -march=native) on my Skylake laptop is a barely measurable amount slower: x before + after ++ |

Re: [Mesa-dev] [PATCH mesa 1/2] egl: add missing includes

On Fri, Nov 16, 2018 at 9:34 AM Emil Velikov wrote: > > On Fri, 16 Nov 2018 at 10:07, Eric Engestrom wrote: I find that I also need diff --git a/src/egl/main/egldevice.h b/src/egl/main/egldevice.h index ddcdcd17f5a..03988913ecd 100644 --- a/src/egl/main/egldevice.h +++

Re: [Mesa-dev] [PATCH 1.5/2] ac/surface/gfx9: let addrlib choose the preferred swizzle kind

On Wed, Nov 21, 2018 at 9:33 PM Marek Olšák wrote: > > See what Gustaw said. Other than that: > > Reviewed-by: Marek Olšák With that change: Reviewed-by: Bas Nieuwenhuizen Tested-by: Bas Nieuwenhuizen > > Marek > > On Wed, Nov 21, 2018 at 10:21 AM Nicolai Hähnle wrote: >> >> From: Nicolai

Re: [Mesa-dev] [PATCH 1.5/2] ac/surface/gfx9: let addrlib choose the preferred swizzle kind

See what Gustaw said. Other than that: Reviewed-by: Marek Olšák Marek On Wed, Nov 21, 2018 at 10:21 AM Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Our choices here are simply redundant as long as sin.flags is set > correctly. > -- > This is the change I was talking about. > --- >

Re: [Mesa-dev] [PATCH mesa 00/13] Make standard function available on non-standard platforms

> vasprintf have different return codes on different systems. Forget this. I was mixing up with the other function that calculates how many chars a xxxprintf function would write, which we use to implement vasprintf. Jose From: Jose Fonseca Sent: Wednesday,

Re: [Mesa-dev] [PATCH 2/2] winsys/amdgpu: explicitly declare whether buffer_map is permanent or not

On Wed, Nov 21, 2018 at 12:57 PM Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Introduce a new driver-private transfer flag RADEON_TRANSFER_TEMPORARY > that specifies whether the caller will use buffer_unmap or not. The > default behavior is set to permanent maps, because that's what drivers

Re: [Mesa-dev] [PATCH 3/7] util/slab: Add function to flush allocations from a child pool

On 21.11.18 19:19, Ian Romanick wrote: > On 11/21/2018 03:08 AM, Haehnle, Nicolai wrote: >> On 21.11.18 01:39, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Ralloc has a feature that all allocations from a temporary memory >>> context can be whisked away in a single call without fear of

Re: [Mesa-dev] [PATCH mesa 00/13] Make standard function available on non-standard platforms

> util: use standard name for strncat() > util: use standard name for strncmp() > util: use standard name for strcmp() > util: use standard name for strchr() > util: use standard name for sprintf() > util: use standard name for vasprintf() > util: use standard name for vsprintf() >

Re: [Mesa-dev] [PATCH 2/7] nir/phi_builder: Use hash table to store [value, block] -> def mapping

On Wed, Nov 21, 2018 at 1:35 PM Ian Romanick wrote: > On 11/21/2018 11:01 AM, Jason Ekstrand wrote: > > On Tue, Nov 20, 2018 at 6:40 PM Ian Romanick > > wrote: > > > > From: Ian Romanick > > > > > > Changes in peak

Re: [Mesa-dev] [PATCH 4/7] nir/phi_builder: Use slab allocator for temporary data structures

The linear_alloc stuff that marek added to ralloc also does slab allocation and can be parented off a ralloc context. Did you consider that? On Tue, Nov 20, 2018 at 6:40 PM Ian Romanick wrote: > From: Ian Romanick > > This pass allocates a large number of two different data structures. > This

Re: [Mesa-dev] [PATCH 2/7] nir/phi_builder: Use hash table to store [value, block] -> def mapping

On 11/21/2018 11:01 AM, Jason Ekstrand wrote: > On Tue, Nov 20, 2018 at 6:40 PM Ian Romanick > wrote: > > From: Ian Romanick > > > Changes in peak memory usage according to Valgrind massif: > > mean soft fp64 using

Re: [Mesa-dev] [PATCH 7/7] intel/compiler: Release memory used by NIR metadata before generating machine code

On 11/21/2018 11:08 AM, Jason Ekstrand wrote: > On Tue, Nov 20, 2018 at 6:40 PM Ian Romanick > wrote: > > From: Ian Romanick > > > Changes in peak memory usage according to Valgrind massif: > > mean soft fp64 using

Re: [Mesa-dev] [PATCH] vulkan: Allow storage images in the WSI.

We don't support storage on any WSI image formats but that shouldn't be an actual problem. Reviewed-by: Jason Ekstrand On Tue, Nov 20, 2018 at 3:30 PM Bas Nieuwenhuizen wrote: > Since apps also have to follow the ImageFormatProperties query, > we can disallow formats that don't allow image

Re: [Mesa-dev] [PATCH 7/7] intel/compiler: Release memory used by NIR metadata before generating machine code

On Tue, Nov 20, 2018 at 6:40 PM Ian Romanick wrote: > From: Ian Romanick > > Changes in peak memory usage according to Valgrind massif: > > mean soft fp64 using uint64: 1,342,766,051 => 1,010,677,195 > gfxbench5 aztec ruins high 11:62,369,974 =>62,369,974 > deus ex mankind divided

[Mesa-dev] [Bug 108087] Memory leak in clover::kernel::argument::create<>() (i.e. clEnqueueNDRangeKernel())

https://bugs.freedesktop.org/show_bug.cgi?id=108087 Jan Vesely changed: What|Removed |Added CC||baker.dyla...@gmail.com --- Comment #2

Re: [Mesa-dev] [PATCH 3/3] glsl: fix typos in comments "transfor" -> "transform"

Oh, yay, you fixed the typos here. I just had to keep reading. This patch is obviously Reviewed-by: Ilia Mirkin For the others ... have you run these through intel's CI? I'm interested in verifying that dEQP, CTS, and piglit all remain happy with the changes. The program resource stuff took a

Re: [Mesa-dev] [PATCH 1/3] glsl: XFB TSC per-vertex output varyings match as not declared as arrays

On Wed, Nov 21, 2018 at 1:45 PM Jose Maria Casanova Crespo wrote: > > Recent change on OpenGL CTS ("Use non-arrayed varying name for TCS blocks") > on KHR-GL*.tessellation_shader.single.xfb_captures_data_from_correct_stage > tests changed how to name per-vertex Tessellation Control Shader output

Re: [Mesa-dev] [PATCH 2/7] nir/phi_builder: Use hash table to store [value, block] -> def mapping

On Tue, Nov 20, 2018 at 6:40 PM Ian Romanick wrote: > From: Ian Romanick > > Changes in peak memory usage according to Valgrind massif: > > mean soft fp64 using uint64: 5,499,881,802 => 1,343,998,123 > gfxbench5 aztec ruins high 11:62,415,414 =>62,415,414 > deus ex mankind divided

[Mesa-dev] [Bug 108457] [OpenGL CTS] KHR-GL46.tessellation_shader.single.xfb_captures_data_from_correct_stage fails

https://bugs.freedesktop.org/show_bug.cgi?id=108457 --- Comment #1 from Chema Casanova --- I've just send a fix for review: https://patchwork.freedesktop.org/series/52841/ -- You are receiving this mail because: You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH] meson: Bump version to 0.46 for python module

Thanks Arfrever and Dylan. Acked-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa 00/13] Make standard function available on non-standard platforms

On 11/20/2018 05:11 AM, Eric Engestrom wrote: > ... instead of making standard platforms use non-standard functions. I haven't looked at the specific patches, so this comment may not apply. When we first headed down the path of adding a billion wrapper functions, I campaigned pretty strongly to

[Mesa-dev] [PATCH 3/3] glsl: fix typos in comments "transfor" -> "transform"

--- src/compiler/glsl/ir.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h index e09f053b77c..c3f5f1f7b05 100644 --- a/src/compiler/glsl/ir.h +++ b/src/compiler/glsl/ir.h @@ -773,17 +773,17 @@ public: unsigned

[Mesa-dev] [PATCH 2/3] glsl: TCS outputs can not be transform feedback candidates on GLES

Fixes: KHR-GLES*.core.tessellation_shader.single.xfb_captures_data_from_correct_stage Cc: mesa-sta...@lists.freedesktop.org --- I think this patch and the previous one should be squashed or interchange the order before landing. I'm sending splitted because it allows exposing the incorrect

[Mesa-dev] [PATCH 1/3] glsl: XFB TSC per-vertex output varyings match as not declared as arrays

Recent change on OpenGL CTS ("Use non-arrayed varying name for TCS blocks") on KHR-GL*.tessellation_shader.single.xfb_captures_data_from_correct_stage tests changed how to name per-vertex Tessellation Control Shader output varyings in transform feedback using interface block as "BLOCK_INOUT.value"

Re: [Mesa-dev] [PATCH 1/7] nir/phi_builder: Internal users should use nir_phi_builder_value_set_block_def too

Reviewed-by: Jason Ekstrand On Tue, Nov 20, 2018 at 6:40 PM Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/compiler/nir/nir_phi_builder.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/compiler/nir/nir_phi_builder.c >

Re: [Mesa-dev] [PATCH 03/22] nir/spirv: initial handling of OpenCL.std extension opcodes

On Wed, Nov 21, 2018 at 2:54 AM Jason Ekstrand wrote: > > On Tue, Nov 13, 2018 at 9:48 AM Karol Herbst wrote: >> >> Not complete, mostly just adding things as I encounter them in CTS. But >> not getting far enough yet to hit most of the OpenCL.std instructions. >> >> Anyway, this is better than

Re: [Mesa-dev] [PATCH 3/7] util/slab: Add function to flush allocations from a child pool

On 11/21/2018 03:08 AM, Haehnle, Nicolai wrote: > On 21.11.18 01:39, Ian Romanick wrote: >> From: Ian Romanick >> >> Ralloc has a feature that all allocations from a temporary memory >> context can be whisked away in a single call without fear of leaks. As >> the slab allocator is designed for

[Mesa-dev] [PATCH] meson: Bump version to 0.46 for python module

From: Arfrever Frehtes Taifersar Arahesis Meson has two modules for finding python, the python3 module and the python module. Python3 is older, and has some corner cases, python is newer, has no known corner cases and can detect python2. Things have generally seemed to work okay for us using

Re: [Mesa-dev] [PATCH 01/21] intel/defines: Explicitly cast to uint32_t in SET_FIELD and SET_BITS

On 17/11/2018 02:47, Jason Ekstrand wrote: If you pass a bool in as the value to set, the C standard says that it gets converted to an int prior to shifting. If you try to set a bool to bit 31, this lands you in undefined behavior. It's better just to add the explicit cast and let the compiler

[Mesa-dev] [PATCH] st/xvmc: Add X11 include path.

This patch fixes this build error. CC tests/xvmc_bench.o In file included from tests/xvmc_bench.c:35: tests/testlib.h:38:10: fatal error: 'X11/Xlib.h' file not found ^~~~ Signed-off-by: Vinson Lee --- src/gallium/state_trackers/xvmc/Makefile.am | 1 + 1 file changed, 1

Re: [Mesa-dev] [PATCH] build: enable -Werror=incompatible-pointer-types

Am Mittwoch, den 21.11.2018, 13:14 + schrieb Emil Velikov: > From: Emil Velikov > > More or less any issue pointed out by the compiler is an error. Make > sure we flag and bail loudly. > > Cc: Eric Engestrom > Signed-off-by: Emil Velikov > --- > Eric, feel free to squash this with your

[Mesa-dev] [PATCH 1/2] winsys/amdgpu: add amdgpu_winsys_bo::lock

From: Nicolai Hähnle We'll use it in the upcoming mapping change. Sparse buffers have always had one. --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 19 +-- src/gallium/winsys/amdgpu/drm/amdgpu_bo.h | 4 ++-- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 10 +- 3 files

[Mesa-dev] [PATCH 2/2] winsys/amdgpu: explicitly declare whether buffer_map is permanent or not

From: Nicolai Hähnle Introduce a new driver-private transfer flag RADEON_TRANSFER_TEMPORARY that specifies whether the caller will use buffer_unmap or not. The default behavior is set to permanent maps, because that's what drivers do for Gallium buffer maps. This should eliminate the need for

[Mesa-dev] [Bug 108530] [Tracker] Mesa 18.3 Release Tracker

https://bugs.freedesktop.org/show_bug.cgi?id=108530 Clayton Craft changed: What|Removed |Added Depends on||108456 Referenced Bugs:

Re: [Mesa-dev] [PATCH 12/18] meson: wire the new generator for es1 and es2

Quoting Emil Velikov (2018-11-21 04:04:09) > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/mapi/es1api/meson.build| 6 +++--- > src/mapi/es2api/meson.build| 6 +++--- > src/mapi/glapi/gen/meson.build | 7 +++ > src/mapi/meson.build | 1 + > 4 files

Re: [Mesa-dev] [PATCH 08/18] mapi/new: don't print info we don't need for ES1/ES2

Quoting Emil Velikov (2018-11-21 04:04:05) > There is no need for the noop function, the public_stubs table or table > size defines. Remove those. > > Might what to look and merge this back to GLVND - from a quick look > they don't need them either. > > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH 06/18] mapi/new: use the static_data offsets in the new generator

Quoting Emil Velikov (2018-11-21 04:04:03) > From: Emil Velikov > > Otherwise the incorrect ones will be used, effecitvely breaking the ABI. > > Note: some entries in static_data.py list a suffixed API, while (for ES* > at least) we expect the one w/o suffix. > > Signed-off-by: Emil Velikov >

Re: [Mesa-dev] [PATCH 1.5/2] ac/surface/gfx9: let addrlib choose the preferred swizzle kind

śr., 21 lis 2018 o 16:21 Nicolai Hähnle napisał(a): > > From: Nicolai Hähnle > > Our choices here are simply redundant as long as sin.flags is set > correctly. > -- > This is the change I was talking about. > --- > src/amd/common/ac_surface.c | 10 -- > 1 file changed, 10 deletions(-) >

Re: [Mesa-dev] [PATCH 04/18] mapi/new: import mapi scripts from glvnd

On 2018/11/21, Kyle Brenneman wrote: > On 11/21/2018 05:04 AM, Emil Velikov wrote: > > From: Emil Velikov > > > > Currently we have over 20 scripts that generate the libGL* dispatch and > > various other functionality. More importantly we're using local XML > > files instead of the Khronos

[Mesa-dev] [PATCH 1.5/2] ac/surface/gfx9: let addrlib choose the preferred swizzle kind

From: Nicolai Hähnle Our choices here are simply redundant as long as sin.flags is set correctly. -- This is the change I was talking about. --- src/amd/common/ac_surface.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c

Re: [Mesa-dev] [PATCH 2/2] amd/addrlib: update Mesa's copy of addrlib

On 20.11.18 07:46, Marek Olšák wrote: On Tue, Nov 20, 2018 at 12:08 AM Dave Airlie > wrote: On Tue, 20 Nov 2018 at 14:42, Marek Olšák mailto:mar...@gmail.com>> wrote: > > On Mon, Nov 19, 2018 at 7:15 PM Bas Nieuwenhuizen

Re: [Mesa-dev] [PATCH 04/18] mapi/new: import mapi scripts from glvnd

On 11/21/2018 05:04 AM, Emil Velikov wrote: From: Emil Velikov Currently we have over 20 scripts that generate the libGL* dispatch and various other functionality. More importantly we're using local XML files instead of the Khronos provides one(s). Resulting in an increasing complexity of

Re: [Mesa-dev] [PATCH mesa 00/13] Make standard function available on non-standard platforms

On 2018/11/20, Eric Engestrom wrote: > ... instead of making standard platforms use non-standard functions. > > This also reduces the likelihood of someone forgetting to use the > non-standard function, and reduces the fix to a simple #include. > Yes, please. One could take thing a step

[Mesa-dev] [Bug 108823] [Bisected]. Autotools. Installing mesa fails with error "error: relink 'libEGL.la' with the above command before installing it"

https://bugs.freedesktop.org/show_bug.cgi?id=108823 Denis changed: What|Removed |Added Summary|[Bisected]. Installing mesa |[Bisected]. Autotools.

[Mesa-dev] [Bug 108823] [Bisected]. Installing mesa fails with error "error: relink 'libEGL.la' with the above command before installing it"

https://bugs.freedesktop.org/show_bug.cgi?id=108823 Bug ID: 108823 Summary: [Bisected]. Installing mesa fails with error "error: relink 'libEGL.la' with the above command before installing it" Product: Mesa

Re: [Mesa-dev] [PATCH mesa 13/13] util: use standard name for vsnprintf()

On 2018/11/20, Eric Engestrom wrote: > @@ -65,6 +65,7 @@ util_strchrnul(const char *s, char c) > > #ifdef _WIN32 > > +#define vsnprintf util_vsnprintf > static inline int > util_vsnprintf(char *str, size_t size, const char *format, va_list ap) Analogous to previous patch, MSVC seems to be

Re: [Mesa-dev] [PATCH mesa 12/13] util: use standard name for snprintf()

On 2018/11/20, Eric Engestrom wrote: > +#define snprintf util_snprintf > static inline int > PRINTFLIKE(3, 4) > util_snprintf(char *str, size_t size, const char *format, ...) From the docs[1]: "Beginning with the UCRT in Visual Studio 2015 and Windows 10, snprintf is no longer

Re: [Mesa-dev] [PATCH mesa 09/13] util: use standard name for sprintf()

On 2018/11/20, Eric Engestrom wrote: > static inline void > PRINTFLIKE(2, 3) > util_sprintf(char *str, const char *format, ...) The docs [1] seem pretty clear that: a) overlap results in undefined behaviour, and b) the function returns the correct value HTH Emil [1]

Re: [Mesa-dev] [PATCH mesa 08/13] util: use standard name for strchr()

On 2018/11/20, Eric Engestrom wrote: > +++ b/src/util/u_string.h > @@ -131,6 +131,7 @@ util_vasprintf(char **ret, const char *format, va_list ap) > return util_vsnprintf(*ret, r + 1, format, ap); > } > > +#define strchr util_strchr > static inline char * > util_strchr(const char *s, char

Re: [Mesa-dev] [PATCH mesa 07/13] util: use standard name for strcmp()

On 2018/11/20, Eric Engestrom wrote: > --- a/src/util/u_string.h > +++ b/src/util/u_string.h > @@ -154,6 +154,7 @@ util_strncat(char *dst, const char *src, size_t n) > return dst; > } > > +#define strcmp util_strcmp > static inline int > util_strcmp(const char *s1, const char *s2) > {

Re: [Mesa-dev] [PATCH mesa 06/13] util: use standard name for strncmp()

On 2018/11/20, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/gallium/auxiliary/hud/hud_context.c | 2 +- > src/util/u_string.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/auxiliary/hud/hud_context.c >

Re: [Mesa-dev] [PATCH mesa 05/13] util: use standard name for strncat()

On 2018/11/20, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/gallium/auxiliary/gallivm/lp_bld_printf.c | 6 +++--- > src/util/u_debug.c| 8 > src/util/u_string.h | 2 +- > 3 files changed, 8 insertions(+), 8

Re: [Mesa-dev] [PATCH mesa 04/13] util: use standard name for strstr()

On 2018/11/20, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/util/u_string.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/util/u_string.h b/src/util/u_string.h > index d74ce1db8537bda54e48..94080e540d66b9fd8381 100644 > ---

Re: [Mesa-dev] [PATCH mesa 02/13] util: use standard name for strcasecmp()

On 2018/11/20, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/util/u_string.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/util/u_string.h b/src/util/u_string.h > index cb0895a71a3f50867327..5687fa8aed1ff98287e6 100644 > ---

Re: [Mesa-dev] [PATCH mesa 2/2] meson: make passing an invalid pointer a hard error

On Tue, 20 Nov 2018 at 12:36, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom Reviewed-by: Emil Velikov Just sent out a patch for autotools, scons and android. Since people are likely to use them as well. Feel free to squash if you'd like. -Emil

[Mesa-dev] [PATCH] build: enable -Werror=incompatible-pointer-types

From: Emil Velikov More or less any issue pointed out by the compiler is an error. Make sure we flag and bail loudly. Cc: Eric Engestrom Signed-off-by: Emil Velikov --- Eric, feel free to squash this with your patch. --- Android.common.mk | 1 + configure.ac | 2 ++ scons/gallium.py |

Re: [Mesa-dev] [PATCH v1] virgl: add assert and missing function parameter

On Tue, 20 Nov 2018 at 16:24, Robert Foss wrote: > > Verify the pipe_fd_type to be of PIPE_FD_TYPE_NATIVE_SYNC. > > Suggested-by: Eric Engestrom > Signed-off-by: Robert Foss Fixes: d1a1c21e7621b5177feb "virgl: native fence fd support" Reviewed-by: Emil Velikov -Emil

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] travis: drop unneeded x11proto-xf86vidmode-dev

On Wed, 21 Nov 2018 at 10:28, Juan A. Suarez Romero wrote: >m > On Fri, 2018-11-16 at 13:59 +, Emil Velikov wrote: > > From: Emil Velikov > > > > The only place where the package is needed is for building the DRI > > based libGL library. > > > > > This caused a conflict when applied to 18.2

[Mesa-dev] [PATCH 14/18] mapi/es*api: remove GL_OES_EGL_image entrypoints

From: Emil Velikov As some point in the past we fixed the scripts so, these are no longer exported. Drop them from the list. Signed-off-by: Emil Velikov --- src/mapi/es1api/ABI-check | 3 --- src/mapi/es2api/ABI-check | 3 --- 2 files changed, 6 deletions(-) diff --git

[Mesa-dev] [PATCH 16/18] mapi/es2api: remove no longer present entrypoints

From: Emil Velikov With the previous scripts API from the following was incorrectly exported. Drop them from the list, since they're no longer around. GL_EXT_blend_func_extended GL_EXT_texture_integer Signed-off-by: Emil Velikov --- src/mapi/es2api/ABI-check | 5 - 1 file changed, 5

[Mesa-dev] [PATCH 13/18] scons: wire the new generator for es1 and es2

From: Emil Velikov Signed-off-by: Emil Velikov --- src/mapi/shared-glapi/SConscript | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/mapi/shared-glapi/SConscript b/src/mapi/shared-glapi/SConscript index 060c61dadce..81aea74873d 100644 ---

[Mesa-dev] [PATCH 06/18] mapi/new: use the static_data offsets in the new generator

From: Emil Velikov Otherwise the incorrect ones will be used, effecitvely breaking the ABI. Note: some entries in static_data.py list a suffixed API, while (for ES* at least) we expect the one w/o suffix. Signed-off-by: Emil Velikov --- src/mapi/new/genCommon.py | 30

[Mesa-dev] [PATCH 11/18] autotools: wire the new generator for es1 and es2

The output produced functionally identical, with the following changes: - A cosmetic: swapped ABI compatible types [ GLclampf -> GLfloat, etc ] - B cosmetic: renamed parameters [ zNear -> n, etc ] - C dropped gl_dispatch_stub declarations - unneeded - D dropped extension entrypoints -

[Mesa-dev] [PATCH 00/18] En route towards Khronos gl.xml

Hi all, Recently Erik enabled NV_conditional_render for GLES, which highlighted an existing issue in our generator scripts. Namely: today we have a single static_data list for all of GL/ES1/ES2. Thus as we expose an extention (as above) we en up statically exporting the functions, if they're

[Mesa-dev] [PATCH 18/18] mapi: remove machinery handling CSV files

From: Emil Velikov We haven't have one in years, so just drop the code. Signed-off-by: Emil Velikov --- src/mapi/mapi_abi.py | 80 1 file changed, 6 insertions(+), 74 deletions(-) diff --git a/src/mapi/mapi_abi.py b/src/mapi/mapi_abi.py index

[Mesa-dev] [PATCH 17/18] mapi: remove old, unused ES* generator code

From: Emil Velikov As of earlier commit, everyone has switched to the new script for the ES dispatch. Signed-off-by: Emil Velikov --- src/mapi/glapi/gen/gl_XML.py | 56 +- src/mapi/mapi_abi.py | 58 2 files changed,

[Mesa-dev] [PATCH 10/18] mapi/new: remove duplicate GLvoid/void substitution

From: Emil Velikov We already do it a few lines above - drop the duplicate. Note that for consistency sake, we keep the substitution since the GL API is a mixed bad - some use GLvoid while others a normal void. We might want to merge this back in GLVND. Signed-off-by: Emil Velikov ---

[Mesa-dev] [PATCH 04/18] mapi/new: import mapi scripts from glvnd

From: Emil Velikov Currently we have over 20 scripts that generate the libGL* dispatch and various other functionality. More importantly we're using local XML files instead of the Khronos provides one(s). Resulting in an increasing complexity of writing, maintaining and bugfixing. One fairly

[Mesa-dev] [PATCH 02/18] HACK: glapi: print _glapi_table offsets to a file

From: Emil Velikov We'll need those in static_data.py --- src/mapi/glapi/gen/gl_table.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mapi/glapi/gen/gl_table.py b/src/mapi/glapi/gen/gl_table.py index 4b89ef8a856..72ad9426f95 100644 ---

[Mesa-dev] [PATCH 15/18] mapi/es*api: remove GL_EXT_multi_draw_arrays entrypoints

From: Emil Velikov Now we use the upstream XML file and a cleaner generator. Thus the symbols are no longer exported and we can drop them from this list. Signed-off-by: Emil Velikov --- src/mapi/es1api/ABI-check | 7 +-- src/mapi/es2api/ABI-check | 6 +- 2 files changed, 2

[Mesa-dev] [PATCH 12/18] meson: wire the new generator for es1 and es2

From: Emil Velikov Signed-off-by: Emil Velikov --- src/mapi/es1api/meson.build| 6 +++--- src/mapi/es2api/meson.build| 6 +++--- src/mapi/glapi/gen/meson.build | 7 +++ src/mapi/meson.build | 1 + 4 files changed, 14 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 03/18] mapi: add all _glapi_table entrypoints to static_data.py

From: Emil Velikov Currently various parts of mesa use the glapi_table differently. Some use _glapi_get_proc_offset() to get the offset, while others directly reference the specific offset via _gloffset_Function. Add all static entries, to ensure things don't break as we flip to the upstream

[Mesa-dev] [PATCH 08/18] mapi/new: don't print info we don't need for ES1/ES2

There is no need for the noop function, the public_stubs table or table size defines. Remove those. Might what to look and merge this back to GLVND - from a quick look they don't need them either. Signed-off-by: Emil Velikov --- src/mapi/new/gen_gldispatch_mapi.py | 7 --- 1 file changed,

[Mesa-dev] [PATCH 09/18] mapi/new: fixup the GLDEBUGPROCKHR typedef to the non KHR one

From: Emil Velikov This way we can reuse the latter, which is already present in the headers that we use. Thus we can drop the manual typedef we generate. We might want to merge this back in GLVND. Signed-off-by: Emil Velikov --- src/mapi/new/genCommon.py | 1 +

[Mesa-dev] [PATCH 01/18] mapi: sort static entrypoints numerically

From: Emil Velikov A few of the entrypoints were incorrectly placed. Sort those to align with the rest of the list. Signed-off-by: Emil Velikov --- src/mapi/glapi/gen/static_data.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

  1   2   >