[Mesa-dev] [Bug 109140] [KBL-G][GL] KHR-GL43.compute_shader.max test failed

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109140 --- Comment #2 from Hai --- Is there any additional information needed for this bug? Thanks. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 108878] OpenGL CTS KHR-GL31.transform_feedback.api_errors_test failed

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108878 Hai changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|NEW

[Mesa-dev] [Bug 108878] OpenGL CTS KHR-GL31.transform_feedback.api_errors_test failed

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108878 --- Comment #4 from Hai --- Since ARB_geometry_shader4 is from OpenGL 3.2, this issue is a test case bug rather than mesa bug. Will close it. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-08 Thread Kenneth Graunke
On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > the naming is a bit confusing no matter how you look at it. Within SPIR-V > "global" memory is memory accessible from all threads. glsl "global" memory > normally refers to shader thread private memory declared at global scope. As

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Marek Olšák
On Tue, Jan 8, 2019, 7:55 PM Ilia Mirkin On Tue, Jan 8, 2019 at 7:26 PM Marek Olšák wrote: > > > > On Tue, Jan 8, 2019 at 7:18 PM Ilia Mirkin wrote: > >> > >> On Tue, Jan 8, 2019 at 6:21 PM Marek Olšák wrote: > >> > > >> > On Tue, Jan 8, 2019 at 5:25 PM Ilia Mirkin > wrote: > >> >> > >> >>

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #9 from Roman Elshin --- It looks like i have a same issue with rx560. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #8 from Roman Elshin --- Created attachment 143025 --> https://bugs.freedesktop.org/attachment.cgi?id=143025=edit game save -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #7 from Roman Elshin --- Created attachment 143024 --> https://bugs.freedesktop.org/attachment.cgi?id=143024=edit dmesg via ssh -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

2019-01-08 Thread Roland Scheidegger
Am 07.01.19 um 09:54 schrieb Tomasz Figa: > On Sun, Dec 23, 2018 at 12:55 AM Roland Scheidegger > wrote: >> >> Alright, I guess it should work... >> >> Reviewed-by: Roland Scheidegger >> > > Thanks! > > Would we have anyone who could help to commit it? Pushed (albeit I forgot the R-b on it,

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Ilia Mirkin
On Tue, Jan 8, 2019 at 7:26 PM Marek Olšák wrote: > > On Tue, Jan 8, 2019 at 7:18 PM Ilia Mirkin wrote: >> >> On Tue, Jan 8, 2019 at 6:21 PM Marek Olšák wrote: >> > >> > On Tue, Jan 8, 2019 at 5:25 PM Ilia Mirkin wrote: >> >> >> >> Why does this need to be in p_state? And who is responsible

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Marek Olšák
On Tue, Jan 8, 2019 at 7:18 PM Ilia Mirkin wrote: > On Tue, Jan 8, 2019 at 6:21 PM Marek Olšák wrote: > > > > On Tue, Jan 8, 2019 at 5:25 PM Ilia Mirkin wrote: > >> > >> Why does this need to be in p_state? And who is responsible for > >> setting it (and how will it be set)? > > > > > > Oh

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Ilia Mirkin
On Tue, Jan 8, 2019 at 6:21 PM Marek Olšák wrote: > > On Tue, Jan 8, 2019 at 5:25 PM Ilia Mirkin wrote: >> >> Why does this need to be in p_state? And who is responsible for >> setting it (and how will it be set)? > > > Oh right, there is a way to get it out of p_state.h if needed. > > It should

Re: [Mesa-dev] [PATCH 0/2] Restore optional xf86vidmode

2019-01-08 Thread Jon Turney
On 08/01/2019 23:54, Rhys Kidd wrote: On Tue, 11 Dec 2018 at 10:22, Jon Turney wrote: Restore optional xf86vidmode, and fix the meson build to actually use it. Jon Turney (2): Revert "glx: make xf86vidmode mandatory for direct rendering" Fix typo preventing xxf86vm being used in meson

Re: [Mesa-dev] [PATCH 0/2] Restore optional xf86vidmode

2019-01-08 Thread Rhys Kidd
On Tue, 11 Dec 2018 at 10:22, Jon Turney wrote: > Restore optional xf86vidmode, and fix the meson build to actually use it. > > Jon Turney (2): > Revert "glx: make xf86vidmode mandatory for direct rendering" > Fix typo preventing xxf86vm being used in meson build > Jon I don't believe these

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Marek Olšák
On Tue, Jan 8, 2019 at 5:25 PM Ilia Mirkin wrote: > Why does this need to be in p_state? And who is responsible for > setting it (and how will it be set)? > Oh right, there is a way to get it out of p_state.h if needed. It should be set to 0 by default. If your thread block is 8x8x1, but you

Re: [Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2019-01-08 Thread Dylan Baker
Quoting Pierre Moreau (2019-01-08 13:11:01) > Reviewed-by: Dylan Baker > > Changes since: > * v7: > - Properly align LLVMSPIRVLib comment (Dylan Baker) > - Only define CLOVER_ALLOW_SPIRV when **both** dependencies are found: > autotools was only requiring one or the other. > * v6:

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Ilia Mirkin
Why does this need to be in p_state? And who is responsible for setting it (and how will it be set)? On Tue, Jan 8, 2019 at 2:47 PM Jiang, Sonny wrote: > > and add radeonsi support. This will be used by radeonsi internally. > > Signed-off-by: Sonny Jiang > --- >

[Mesa-dev] [Bug 109201] Deep Rock Galactic: GPU Hang (Steam Play) (DXVK)

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109201 --- Comment #6 from Alexander --- Note 2: Does not happen if i set the texture quality to low. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

2019-01-08 Thread Bas Nieuwenhuizen
On Tue, Jan 8, 2019 at 5:17 PM Marek Olšák wrote: > > From: Marek Olšák > > We have found some pipe_surface leaks internally. > > This is the same code as surface_destroy in radeonsi. > Ideally, surface_destroy would be in pipe_screen. > No, pipe_surfaces are not context objects. > > Cc: 18.3

[Mesa-dev] [PATCH v10 20/20] clover: Implement clCreateProgramWithIL from OpenCL 2.1

2019-01-08 Thread Pierre Moreau
Reviewed-by: Karol Herbst Change since: * v2: Remove the const from the length argument of clCreateProgramWithIL Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/dispatch.cpp | 2 +- src/gallium/state_trackers/clover/api/program.cpp | 8 2 files changed, 9

[Mesa-dev] [PATCH v10 19/20] clover: Advertise cl_khr_il_program

2019-01-08 Thread Pierre Moreau
Reviewed-by: Karol Herbst Changes since: * v3: do not advertise SPIR-V support if CLOVER_ALLOW_SPIRV is not defined * v2: advertise cl_khr_il_program if if the device support NATIVE as IR Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/platform.cpp | 2 ++

[Mesa-dev] [PATCH v10 16/20] clover: Implement clCreateProgramWithILKHR

2019-01-08 Thread Pierre Moreau
Changes since: * v4: - Use is_binary_spirv and is_valid_spirv from the SPIR-V backend; - Drop the SPIRV-Tools and llvm-spirv dependencies on clover. * v3: guard parts of the code behind SPIR-V support * v2: - Remove the const on the length argument to CreateProgramWithILKHR (Francisco

[Mesa-dev] [PATCH v10 17/20] clover: Handle CL_PROGRAM_IL in clGetProgramInfo

2019-01-08 Thread Pierre Moreau
Reviewed-by: Karol Herbst Changes since: * v3: Use the core define instead of the extension one (Karol Herbst) * v2: Switch from using a pointer attribute to a vector (Francisco Jerez) Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/program.cpp | 7 +++ 1 file

[Mesa-dev] [PATCH v10 18/20] clover/api: Implement CL_DEVICE_IL_VERSION

2019-01-08 Thread Pierre Moreau
Reviewed-by: Karol Herbst Changes since: * v3: Use the core define instead of the extension one (Karol Herbst) * v2: Throw an exception if the cl_khr_il_program extension is not supported (Francisco Jerez) Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp

[Mesa-dev] [PATCH v10 15/20] clover/spirv: Add functions for validating SPIR-V binaries

2019-01-08 Thread Pierre Moreau
Changes since: * v9: Add `clover_cpp_std` to the overrides of the `libclspirv` target in Meson. * v7: Add DEFINES to libclspirv and libclover, in autotools, as they would otherwise never know whether CLOVER_ALLOW_SPIRV has been defined (Dave Airlie) * v6: Update the dependency

[Mesa-dev] [PATCH v10 13/20] clover/llvm: Allow translating from SPIR-V to LLVM IR

2019-01-08 Thread Pierre Moreau
Changes since: * v6: Update the LLVM API call due to the replacement of llvm-spirv to the new official SPIRV-LLVM-Translator. * v5: Update Makefile.am to add to libclllvm its new llvm-spirv dependency. (Karol Herbst) * v3: - guard the SPIR-V code; - use an istringstream instead of

[Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2019-01-08 Thread Pierre Moreau
Reviewed-by: Dylan Baker Changes since: * v7: - Properly align LLVMSPIRVLib comment (Dylan Baker) - Only define CLOVER_ALLOW_SPIRV when **both** dependencies are found: autotools was only requiring one or the other. * v6: Replace the llvm-spirv repository by the new official

[Mesa-dev] [PATCH v10 14/20] include/CL: Add cl_khr_il_program

2019-01-08 Thread Pierre Moreau
Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- include/CL/cl_ext.h | 37 + 1 file changed, 37 insertions(+) diff --git a/include/CL/cl_ext.h b/include/CL/cl_ext.h index 5078e8f45f0..5ea49680423 100644 --- a/include/CL/cl_ext.h +++

[Mesa-dev] [PATCH v10 11/20] clover: Move platform extensions definitions to clover/platform.cpp

2019-01-08 Thread Pierre Moreau
Reviewed-by: Francisco Jerez Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/platform.cpp | 4 ++-- src/gallium/state_trackers/clover/core/platform.cpp | 5 + src/gallium/state_trackers/clover/core/platform.hpp | 2 ++ 3 files changed, 9

[Mesa-dev] [PATCH v10 06/20] clover/api: Rework the validation of devices for building

2019-01-08 Thread Pierre Moreau
Reviewed-by: Francisco Jerez Changes since: * v5: - Drop the `valid_devs` argument to `validate_build_common()` (Francisco Jerez) - Change `clLinkProgram()` to initialise `prog`’s devices prior to calling `validate_build_common()`. * v2: - validate_build_common no longer returns a

[Mesa-dev] [PATCH v10 09/20] clover: Track flags per module section

2019-01-08 Thread Pierre Moreau
One flag that needs to be tracked is whether a library is allowed to received mathematics optimisations or not, as the authorisation is given when creating the library while the optimisations are specified when creating the executable. Reviewed-by: Aaron Watry Changes since: * v3: drop the

[Mesa-dev] [PATCH v10 10/20] clover: Move device extensions definitions to core/device.cpp

2019-01-08 Thread Pierre Moreau
Reviewed-by: Francisco Jerez Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/api/device.cpp | 11 +-- src/gallium/state_trackers/clover/core/device.cpp | 14 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files

[Mesa-dev] [PATCH v10 04/20] clover: Add an helper for checking if an IR is supported

2019-01-08 Thread Pierre Moreau
Reviewed-by: Aaron Watry Reviewed-by: Karol Herbst Changes since: * v2: - Dropped supported_irs() (Francisco Jerez) - Changed supports_ir() argument type to `enum pipe_shader_ir` (Francisco Jerez) Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/core/device.cpp | 6

[Mesa-dev] [PATCH v10 07/20] clover/api: Fail if trying to build a non-executable binary

2019-01-08 Thread Pierre Moreau
From the OpenCL 1.2 Specification, Section 5.6.2 (about clBuildProgram): > If program is created with clCreateProgramWithBinary, then the > program binary must be an executable binary (not a compiled binary or > library). Reviewed-by: Aaron Watry Signed-off-by: Pierre Moreau ---

[Mesa-dev] [PATCH v10 03/20] clover: Remove the TGSI backend as unused

2019-01-08 Thread Pierre Moreau
Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/Makefile.am | 11 +- .../state_trackers/clover/Makefile.sources| 4 - .../state_trackers/clover/core/program.cpp| 13 +- src/gallium/state_trackers/clover/meson.build | 10 +-

[Mesa-dev] [PATCH v10 05/20] clover/device: Replace usage of "1 << PIPE_SHADER_IR_*" with supports_ir

2019-01-08 Thread Pierre Moreau
Reviewed-by: Aaron Watry Reviewed-by: Karol Herbst Signed-off-by: Pierre Moreau --- src/gallium/state_trackers/clover/core/device.cpp | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/device.cpp

[Mesa-dev] [PATCH v10 08/20] clover: Disallow creating libraries from other libraries

2019-01-08 Thread Pierre Moreau
If creating a library, do not allow non-compiled object in it, as executables are not allowed, and libraries would make it really hard to enforce the "-enable-link-options" flag. Reviewed-by: Francisco Jerez Reviewed-by: Aaron Watry Changes since: * v5: changed to accommodate the update of

[Mesa-dev] [PATCH v10 02/20] clover: update ICD table to support everything up to 2.2

2019-01-08 Thread Pierre Moreau
From: Karol Herbst v6: Fix return type of clCreateCommandQueueWithProperties v2: add more prototypes Reviewed-by: Pierre Moreau Signed-off-by: Karol Herbst Signed-off-by: Pierre Moreau --- .../state_trackers/clover/api/dispatch.cpp| 29 ++- .../state_trackers/clover/api/dispatch.hpp

[Mesa-dev] [PATCH v10 00/20] Introducing SPIR-V support to clover

2019-01-08 Thread Pierre Moreau
Hello everyone, The series is largely unchanged compared to the previous version, but it was also rebased on the latest master. It would be nice to have the series merged in for 19.0 (only three patches out of 20 are missing a review), if the series is ready enough. For recap since this series

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Chris Wilson
Quoting Kenneth Graunke (2019-01-08 20:17:01) > On Tuesday, January 8, 2019 3:11:37 AM PST Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-01-08 11:03:26) > > > Hi Andrii, > > > > > > Although I think what these patches do makes sense, I think it's missing > > > the bigger picture. > > >

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Kenneth Graunke
On Tuesday, January 8, 2019 3:11:37 AM PST Chris Wilson wrote: > Quoting Lionel Landwerlin (2019-01-08 11:03:26) > > Hi Andrii, > > > > Although I think what these patches do makes sense, I think it's missing > > the bigger picture. > > There is a lot more state that gets lost if we have to

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

2019-01-08 Thread Marek Olšák
On Tue, Jan 8, 2019 at 12:54 PM Roland Scheidegger wrote: > Am 08.01.19 um 17:17 schrieb Marek Olšák: > > From: Marek Olšák > > > > We have found some pipe_surface leaks internally. > > > > This is the same code as surface_destroy in radeonsi. > > Ideally, surface_destroy would be in

Re: [Mesa-dev] [PATCH v2] nir: fix warning in nir_lower_io.c

2019-01-08 Thread Jason Ekstrand
ACK On Tue, Jan 8, 2019 at 12:27 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Initialize the variable with NULL. Fixes the following > > In file included from ../src/compiler/nir/nir_lower_io.c:34: > ../src/compiler/nir/nir_lower_io.c: In function >

[Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Jiang, Sonny
and add radeonsi support. This will be used by radeonsi internally. Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_compute.c | 33 +++ src/gallium/include/pipe/p_state.h| 7 + 2 files changed, 35 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 09/12] nir: add legal bit_sizes to intrinsics

2019-01-08 Thread Jason Ekstrand
On Tue, Jan 8, 2019 at 1:03 PM Karol Herbst wrote: > On Mon, Jan 7, 2019 at 6:16 PM Jason Ekstrand > wrote: > > > > On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > >> > >> With OpenCL some system values match the address bits, but in GLSL we > also > >> have some system values being 64

Re: [Mesa-dev] Chromium - Application-level nouveau blacklist

2019-01-08 Thread Stéphane Marchesin
On Tue, Jan 8, 2019 at 1:11 AM Eero Tamminen wrote: > > Hi, > > On 8.1.2019 8.56, Stéphane Marchesin wrote: > > Yes I think the Chrome-side is very simple here: because there isn't > > time or means for in-depth investigation, if a driver crashes too > > much, it gets blacklisted. The situation

Re: [Mesa-dev] [PATCH 11/12] nir: add support for address bit sized system values

2019-01-08 Thread Karol Herbst
On Mon, Jan 7, 2019 at 6:29 PM Jason Ekstrand wrote: > > > On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: >> >> Signed-off-by: Karol Herbst >> --- >> src/amd/vulkan/radv_meta_buffer.c | 8 ++-- >> src/amd/vulkan/radv_meta_bufimage.c| 28 +++--- >>

Re: [Mesa-dev] [PATCH 09/12] nir: add legal bit_sizes to intrinsics

2019-01-08 Thread Karol Herbst
On Mon, Jan 7, 2019 at 6:16 PM Jason Ekstrand wrote: > > On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: >> >> With OpenCL some system values match the address bits, but in GLSL we also >> have some system values being 64 bit like subgroup masks. >> >> With this it is possible to adjust the

Re: [Mesa-dev] [PATCH] radv: get rid of bunch of KHR suffixes

2019-01-08 Thread Eric Engestrom
On Tuesday, 2019-01-08 14:30:32 +0100, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset Acked-by: Eric Engestrom You've inspired me, I'll send the same for anv in a bit ;) > --- > src/amd/vulkan/radv_android.c| 18 +-- > src/amd/vulkan/radv_cmd_buffer.c | 4 +- >

[Mesa-dev] [PATCH v2] nir: fix warning in nir_lower_io.c

2019-01-08 Thread Caio Marcelo de Oliveira Filho
Initialize the variable with NULL. Fixes the following In file included from ../src/compiler/nir/nir_lower_io.c:34: ../src/compiler/nir/nir_lower_io.c: In function ‘nir_lower_explicit_io’: ../src/compiler/nir/nir.h:668:11: warning: ‘addr’ may be used uninitialized in this function

Re: [Mesa-dev] [ANNOUNCE] 19.0 branchpoint on 2019/01/29

2019-01-08 Thread Jason Ekstrand
There are two things I'd like to land prior to the branch point (as an FYI): - Rafiel's code to stop using userptr for ANV state pools (!11) - VK_EXT_transform_feedback (!2) Both are pretty close at this point so I think it's feasible. --Jason On Tue, Jan 8, 2019 at 11:52 AM Dylan Baker

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #6 from Dmitry --- Saving the game is not important, I started the game first and realized that hangs in any battles. Problem new. 4.20.0-arch1-1 LLVM 7.0.1-1 I understand this is a problem with the RX460. On bug tracker has

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

2019-01-08 Thread Roland Scheidegger
Am 08.01.19 um 17:17 schrieb Marek Olšák: > From: Marek Olšák > > We have found some pipe_surface leaks internally. > > This is the same code as surface_destroy in radeonsi. > Ideally, surface_destroy would be in pipe_screen. > No, pipe_surfaces are not context objects. Well they are supposed

[Mesa-dev] [ANNOUNCE] 19.0 branchpoint on 2019/01/29

2019-01-08 Thread Dylan Baker
Just a reminder that the branchpoint for the 19.0 release and the first RC will happen on January 29th. I just wanted to give an extra long heads up since many of us are still recovering from a long holiday season ☺ Dylan signature.asc Description: signature

Re: [Mesa-dev] [PATCH] autotools: Remove tegra vdpau driver

2019-01-08 Thread Dylan Baker
Quoting Ilia Mirkin (2019-01-08 09:12:46) > Reviewed-by: Ilia Mirkin > > Thanks! > > On Tue, Dec 18, 2018 at 5:41 PM Dylan Baker wrote: > > > > This has never functioned and probably wont ever function, due to the > > way gallium media state trackers are architected and the tegra video > >

[Mesa-dev] [MR] intel: Add support for split SEND instructions

2019-01-08 Thread Jason Ekstrand
We've had split send instructions in the hardware since Sky Lake but haven't bothered to wire them up yet. In order to get there, this MR adds a new SHADER_OPCODE_SEND opcode which does a generic send without all the special-casing in fs_generator. At the end, it switches us to sends for surface

Re: [Mesa-dev] [PATCH] nir: fix warning in nir_lower_io.c

2019-01-08 Thread Lionel Landwerlin
On 08/01/2019 17:33, Caio Marcelo de Oliveira Filho wrote: Add unreachable case for invalid deref type. Fixes the warning below In file included from ../src/compiler/nir/nir_lower_io.c:34: ../src/compiler/nir/nir_lower_io.c: In function ‘nir_lower_explicit_io’:

[Mesa-dev] [PATCH] nir: fix warning in nir_lower_io.c

2019-01-08 Thread Caio Marcelo de Oliveira Filho
Add unreachable case for invalid deref type. Fixes the warning below In file included from ../src/compiler/nir/nir_lower_io.c:34: ../src/compiler/nir/nir_lower_io.c: In function ‘nir_lower_explicit_io’: ../src/compiler/nir/nir.h:668:11: warning: ‘addr’ may be used uninitialized in

Re: [Mesa-dev] [PATCH 1/2] st/mesa: unify window-system renderbuffer initialization

2019-01-08 Thread Brian Paul
For both, Reviewed-by: Brian Paul On 01/08/2019 08:57 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_cb_eglimage.c | 11 + > src/mesa/state_tracker/st_manager.c | 32 - > src/mesa/state_tracker/st_manager.h | 6 +

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

2019-01-08 Thread Brian Paul
LGTM. Reviewed-by: Brian Paul On 01/08/2019 09:17 AM, Marek Olšák wrote: > From: Marek Olšák > > We have found some pipe_surface leaks internally. > > This is the same code as surface_destroy in radeonsi. > Ideally, surface_destroy would be in pipe_screen. > No, pipe_surfaces are not context

[Mesa-dev] [Bug 109249] vkd3d test failures related to ordered/unordered comparisons in test_shader_instructions()

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109249 Jason Ekstrand changed: What|Removed |Added CC||i...@freedesktop.org --- Comment #2

[Mesa-dev] [Bug 109249] vkd3d test failures related to ordered/unordered comparisons in test_shader_instructions()

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109249 Samuel Pitoiset changed: What|Removed |Added CC||samuel.pitoi...@gmail.com ---

Re: [Mesa-dev] [PATCH] autotools: Remove tegra vdpau driver

2019-01-08 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Thanks! On Tue, Dec 18, 2018 at 5:41 PM Dylan Baker wrote: > > This has never functioned and probably wont ever function, due to the > way gallium media state trackers are architected and the tegra video > decoder is architected. > > Cc: Thierry Reding > Fixes:

[Mesa-dev] [Bug 109249] vkd3d test failures related to ordered/unordered comparisons in test_shader_instructions()

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109249 Bug ID: 109249 Summary: vkd3d test failures related to ordered/unordered comparisons in test_shader_instructions() Product: Mesa Version: git Hardware: All

Re: [Mesa-dev] st/va: Return correct status from vlVaQuerySurfaceStatus

2019-01-08 Thread Das, Indrajit-kumar
From: Indrajit Das Date: Thu, 3 Jan 2019 14:36:33 +0530 Subject: [PATCH] st/va: Return correct status from vlVaQuerySurfaceStatus This ensures that during encoding, applications can get the correct status of the surface before submitting more operations on the same. Reviewed-by: Leo Liu

Re: [Mesa-dev] [PATCH 0/3] anv: Implement VK_KHR_draw_indirect_count and VK_EXT_conditional_rendering

2019-01-08 Thread Erik Faye-Lund
Awesome, thanks for the update :) On Tue, 2019-01-08 at 11:47 +0200, Danylo Piliaiev wrote: > Hi, Thanks! > > I finally got CI results with ALL relevant tests and my > implementation works on everything but Haswell. > So I'll fix whatever is wrong there (hope that's just something > small) and

Re: [Mesa-dev] [PATCH] autotools: Remove tegra vdpau driver

2019-01-08 Thread Dylan Baker
Quoting Dylan Baker (2018-12-18 14:39:59) > This has never functioned and probably wont ever function, due to the > way gallium media state trackers are architected and the tegra video > decoder is architected. > > Cc: Thierry Reding > Fixes: 1755f608f5201e0a23f00cc3ea1b01edd07eb6ef >

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #5 from Samuel Pitoiset --- Where is the savegame? Also what kernel and llvm versions are you using? The ones provided by Arch Linux? I have just tried to reproduce GPU hangs on my side by playing around few minutes, no success.

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread andrey simiklit
On Tue, Jan 8, 2019 at 6:16 PM Chris Wilson wrote: > Quoting andrey simiklit (2019-01-08 16:00:45) > > On Tue, Jan 8, 2019 at 1:11 PM Chris Wilson > wrote: > > > > Quoting Lionel Landwerlin (2019-01-08 11:03:26) > > > Hi Andrii, > > > > > > Although I think what these patches do

[Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

2019-01-08 Thread Marek Olšák
From: Marek Olšák We have found some pipe_surface leaks internally. This is the same code as surface_destroy in radeonsi. Ideally, surface_destroy would be in pipe_screen. No, pipe_surfaces are not context objects. Cc: 18.3 19.0 --- src/gallium/auxiliary/util/u_inlines.h | 19

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Chris Wilson
Quoting andrey simiklit (2019-01-08 16:00:45) > On Tue, Jan 8, 2019 at 1:11 PM Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-01-08 11:03:26) > > Hi Andrii, > > > > Although I think what these patches do makes sense, I think it's missing > > the bigger picture. >

Re: [Mesa-dev] [PATCH v2 3/3] radv: add support for VK_EXT_memory_budget

2019-01-08 Thread Alex Smith
Thanks! I've played around with this a bit and it looks like it's behaving how I'd expect. One comment inline below... On Tue, 8 Jan 2019 at 15:17, Samuel Pitoiset wrote: > A simple Vulkan extension that allows apps to query size and > usage of all exposed memory heaps. > > The different usage

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread andrey simiklit
On Tue, Jan 8, 2019 at 1:11 PM Chris Wilson wrote: > Quoting Lionel Landwerlin (2019-01-08 11:03:26) > > Hi Andrii, > > > > Although I think what these patches do makes sense, I think it's missing > > the bigger picture. > > There is a lot more state that gets lost if we have to revert all of

[Mesa-dev] [PATCH 2/2] st/mesa: don't reference pipe_surface locally in PBO code

2019-01-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_texture.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index 45918e425ac..ff4694da9e0 100644 --- a/src/mesa/state_tracker/st_cb_texture.c

[Mesa-dev] [PATCH 1/2] st/mesa: unify window-system renderbuffer initialization

2019-01-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_eglimage.c | 11 + src/mesa/state_tracker/st_manager.c | 32 - src/mesa/state_tracker/st_manager.h | 6 + 3 files changed, 28 insertions(+), 21 deletions(-) diff --git

[Mesa-dev] [Bug 109153] [KBL-G][VK] Vulkan CTS spirv_assembly cases failed Segmentation fault (core dumped)

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109153 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH v2 3/3] radv: add support for VK_EXT_memory_budget

2019-01-08 Thread Samuel Pitoiset
A simple Vulkan extension that allows apps to query size and usage of all exposed memory heaps. The different usage values are not really accurate because they are per drm-fd, but they should be close enough. v2: - add software counters for the different heaps in the winsys - improve

[Mesa-dev] [PATCH] radv: enable variable pointers

2019-01-08 Thread Samuel Pitoiset
The Vulkan spec 1.1.97 says: "variablePointers specifies whether the implementation supports the SPIR-V VariablePointers capability. When this feature is not enabled, shader modules must not declare the VariablePointers capability." As the SPIR-V feature is enabled, we should turn

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #4 from Dmitry --- Any heavy scene, for example fight with the first Griffin on a plot. https://www.youtube.com/watch?v=0J9qnKeID0s Yes I can. It hangs in the fight. dmesg is not done because I do a physical reboot. -- You are

[Mesa-dev] [PATCH] radv: get rid of bunch of KHR suffixes

2019-01-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_android.c| 18 +-- src/amd/vulkan/radv_cmd_buffer.c | 4 +- src/amd/vulkan/radv_descriptor_set.c | 22 ++-- src/amd/vulkan/radv_device.c | 176 +-- src/amd/vulkan/radv_formats.c| 82

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Lionel Landwerlin
On 08/01/2019 11:11, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-01-08 11:03:26) Hi Andrii, Although I think what these patches do makes sense, I think it's missing the bigger picture. There is a lot more state that gets lost if we have to revert all of the emitted commands. A quick

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-01-08 11:03:26) > Hi Andrii, > > Although I think what these patches do makes sense, I think it's missing > the bigger picture. > There is a lot more state that gets lost if we have to revert all of the > emitted commands. > A quick look at

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Lionel Landwerlin
Hi Andrii, Although I think what these patches do makes sense, I think it's missing the bigger picture. There is a lot more state that gets lost if we have to revert all of the emitted commands. A quick look at brw_upload_pipeline_state() shows all of the programs could be invalid as well, or

Re: [Mesa-dev] [PATCH] glsl/linker: specify proper direction in location aliasing error

2019-01-08 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2019-01-07 at 16:11 +0200, Andres Gomez wrote: > The check for location aliasing was always asuming output variables > but this validation is also called for input variables. > > Fixes: e2abb75b0e4 ("glsl/linker: validate explicit locations for SSO >

Re: [Mesa-dev] [PATCH v2 3/3] egl: add config debug printout (v2)

2019-01-08 Thread Eric Engestrom
On Thursday, 2018-12-20 10:02:35 +, Silvestrs Timofejevs wrote: > Feature to print out EGL returned configs for debug purposes. > > 'eglChooseConfig' and 'eglGetConfigs' debug information printout is > enabled when the log level equals '_EGL_DEBUG'. The configs are > printed, and if any of

Re: [Mesa-dev] [PATCH] editorconfig: Add max_line_length property

2019-01-08 Thread Eric Engestrom
On Monday, 2019-01-07 12:43:54 -0800, Dylan Baker wrote: > Quoting Andres Gomez (2019-01-07 05:49:00) > > The property is supported by the most of the editors, but not all: > > https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length > > > > Cc: Eric Engestrom >

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread andrey simiklit
Hi all, Could somebody take a look at this patch? Regards, Andrii. On Mon, Nov 19, 2018 at 11:19 PM wrote: > From: Andrii Simiklit > > This patch is needed to avoid missing 3DSTATE_URB_* commands in a batch > after > rollback operation. > > To be able to test easily this issue > the

Re: [Mesa-dev] [PATCH 2/2] i965: add missing rollback of a xfb zero_offsets flag

2019-01-08 Thread andrey simiklit
Hi all, Could somebody take a look at this patch? Regards, Andrii. On Mon, Nov 19, 2018 at 11:19 PM wrote: > From: Andrii Simiklit > > This patch is needed to avoid incorrect value of StreamOffset flag > in 3DSTATE_SO_BUFFER command after rollback operation. > > To be able to test easily

Re: [Mesa-dev] [PATCH 0/3] anv: Implement VK_KHR_draw_indirect_count and VK_EXT_conditional_rendering

2019-01-08 Thread Danylo Piliaiev
Hi, Thanks! I finally got CI results with ALL relevant tests and my implementation works on everything but Haswell. So I'll fix whatever is wrong there (hope that's just something small) and send the final version. There are still some tests for VK-GL-CTS which are not merged in master e.g.

Re: [Mesa-dev] [PATCH] docs: complete the calendar and release schedule documentation

2019-01-08 Thread Eric Engestrom
On January 7, 2019 5:07:34 PM UTC, Andres Gomez wrote: > As suggested by Emil Velikov. > > Cc: Dylan Baker > Cc: Juan A. Suarez > Cc: Emil Velikov > Signed-off-by: Andres Gomez Reviewed-by: Eric Engestrom > --- > docs/release-calendar.html | 10 ++ > docs/releasing.html

Re: [Mesa-dev] [PATCH 3/3] radv: add support for VK_EXT_memory_budget

2019-01-08 Thread Alex Smith
On Mon, 7 Jan 2019 at 17:20, Samuel Pitoiset wrote: > > On 1/7/19 6:06 PM, Alex Smith wrote: > > Hi Samuel, > > Thanks for implementing this - I've been wanting this extension for a > while so it's good it's finally available. > > This is just reporting the total heap sizes as the budget, which

Re: [Mesa-dev] [PATCH 0/3] anv: Implement VK_KHR_draw_indirect_count and VK_EXT_conditional_rendering

2019-01-08 Thread Erik Faye-Lund
On Wed, 2018-10-17 at 14:58 +0300, Danylo Piliaiev wrote: > This series implement VK_KHR_draw_indirect_count and > VK_EXT_conditional_rendering extensions. > They are implemented together because they are highly interweaved. > > There are already tests in VK_CTS for VK_KHR_draw_indirect_count and

Re: [Mesa-dev] Chromium - Application-level nouveau blacklist

2019-01-08 Thread Eero Tamminen
Hi, On 8.1.2019 8.56, Stéphane Marchesin wrote: Yes I think the Chrome-side is very simple here: because there isn't time or means for in-depth investigation, if a driver crashes too much, it gets blacklisted. The situation is not unique, the GPU blacklist file is 1700 lines:

[Mesa-dev] [Bug 109153] [KBL-G][VK] Vulkan CTS spirv_assembly cases failed Segmentation fault (core dumped)

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109153 --- Comment #6 from Samuel Pitoiset --- The following commit fixes the crash for me commit 2f4f5a5055c74a35916645ed6eb2f8bd8ca7d221 Author: Dave Airlie Date: Wed Jul 4 16:21:49 2018 +1000 spirv/vtn: handle variable pointers without

Re: [Mesa-dev] [PATCH 1/6] vulkan: Update the XML and headers to 1.1.97

2019-01-08 Thread Jason Ekstrand
Thanks! Pushed. On Mon, Jan 7, 2019 at 9:46 AM Samuel Pitoiset wrote: > Acked-by: Samuel Pitoiset > > On 1/7/19 4:39 PM, Jason Ekstrand wrote: > > --- > > include/vulkan/vulkan.h | 2 +- > > include/vulkan/vulkan_android.h | 2 +- > > include/vulkan/vulkan_core.h

Re: [Mesa-dev] [PATCH] docs: complete the calendar and release schedule documentation

2019-01-08 Thread Dylan Baker
Quoting Andres Gomez (2019-01-07 09:04:34) > As suggested by Emil Velikov. > > Cc: Dylan Baker > Cc: Juan A. Suarez > Cc: Emil Velikov > Signed-off-by: Andres Gomez > --- > docs/release-calendar.html | 10 ++ > docs/releasing.html| 14 -- > 2 files changed, 22

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

2019-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #3 from Samuel Pitoiset --- Can you explain how to reproduce? Can you upload a savegame? Is there anything in dmesg when it hangs? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact