[Mesa-dev] [PATCH] draw/gs: fix point size outputs from geometry shader.

2019-03-24 Thread Dave Airlie
From: Dave Airlie If the geom shader emits a point size we failed to find it here, use the correct API to look it up. Fixes: tests/spec/glsl-1.50/execution/geometry/point-size-out.shader_test --- src/gallium/auxiliary/draw/draw_pipe_wide_point.c | 9 + 1 file changed, 1 insertion(+), 8

[Mesa-dev] [PATCH 2/3] panfrost/midgard: Cleanup midgard_nir_algebraic.py

2019-03-24 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_nir_algebraic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_nir_algebraic.py b/src/gallium/drivers/panfrost/midgard/midgard_nir_algebraic.py

[Mesa-dev] [PATCH 1/3] panfrost/midgard: Lower source modifiers for ints

2019-03-24 Thread Alyssa Rosenzweig
On Midgard, float ops support standard source modifiers (abs/neg) and destination modifiers (sat/pos/round). Integer ops do not support these, however. To cope, we use native NIR source modifiers for floats, but lower them away to iabs/ineg for integers, implementing those ops simultaneously to

[Mesa-dev] [PATCH 3/3] panfrost: Stub out ES3 caps/callbacks

2019-03-24 Thread Alyssa Rosenzweig
Although this is not functional (and the command stream side is not aiming for ES3 right now), this is enough to run dEQP-GLES3 shader tests with the version override directive; this is useful, as some ES3 shader feature can occur in ES2 class shaders due to lowering. Signed-off-by: Alyssa

[Mesa-dev] [PATCH] draw: bail instead of assert on instance count (v2)

2019-03-24 Thread Dave Airlie
From: Dave Airlie With indirect rendering it's fine to set the instance count parameter to 0, and expect the rendering to be ignored. Fixes assert in KHR-GLES31.core.compute_shader.pipeline-gen-draw-commands on softpipe v2: return earlier before changing fpstate ---

[Mesa-dev] [PATCH] draw: bail instead of assert on instance count

2019-03-24 Thread Dave Airlie
From: Dave Airlie With indirect rendering it's fine to set the instance count parameter to 0, and expect the rendering to be ignored. Fixes assert in KHR-GLES31.core.compute_shader.pipeline-gen-draw-commands on softpipe --- src/gallium/auxiliary/draw/draw_pt.c | 4 +++- 1 file changed, 3

[Mesa-dev] [PATCH 07/12] panfrost/midgard: Add more ball/bany, iabs ops

2019-03-24 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/midgard.h| 29 +++ 1 file changed, 29 insertions(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard.h b/src/gallium/drivers/panfrost/midgard/midgard.h index f3cabff8c2f..c40c94bc378 100644 ---

[Mesa-dev] [PATCH 12/12] panfrost/midgard: Implement b2i; improve b2f/f2b

2019-03-24 Thread Alyssa Rosenzweig
Fixes dEQP-GLES2.functional.shaders.conversions.scalar_to_scalar.bool_to_int_fragment Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 48 --- 1 file changed, 30 insertions(+), 18 deletions(-) diff --git

[Mesa-dev] [PATCH 09/12] panfrost/midgard: Lower bool_to_int32

2019-03-24 Thread Alyssa Rosenzweig
Fixes dEQP-GLES2.functional.shaders.linkage.varying_type_vec2 (among many others). Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 43 ++- 1 file changed, 23 insertions(+), 20 deletions(-) diff --git

[Mesa-dev] [PATCH 11/12] panfrost/midgard: Lower i2b32

2019-03-24 Thread Alyssa Rosenzweig
Fixes dEQP-GLES2.functional.shader.conversions.scalar_to_scalar.int_to_bool_vertex Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c

[Mesa-dev] [PATCH 10/12] panfrost/midgard: Lower f2b32 to fne

2019-03-24 Thread Alyssa Rosenzweig
Fixes dEQP-GLES2.functional.shaders.swizzles.vector_swizzles.mediump_bvec2_x_vertex Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c

[Mesa-dev] [PATCH 08/12] panfrost/midgard: Map more bany/ball opcodes

2019-03-24 Thread Alyssa Rosenzweig
Some of these are not yet fully functional due to related bugs, but this the correct op mapping. The native ball/bany opcodes act on vec4's unconditionally. That said, both ball and bany have the nice property that duplicating an argument does not affect their output, so the default "hanging

[Mesa-dev] [PATCH 03/12] panfrost: Fix viewports

2019-03-24 Thread Alyssa Rosenzweig
Our viewport code hardcoded a number of wrong assumptions, which sort of sometimes worked but was definitely wrong (and broke most of dEQP). This corrects the logic, accounting for flipped-Y framebuffers, which fixes... most of dEQP. Signed-off-by: Alyssa Rosenzweig ---

[Mesa-dev] [PATCH 04/12] panfrost: Implement scissor test

2019-03-24 Thread Alyssa Rosenzweig
This preliminary implementation should handle some basic cases. Future work should scissor the FRAGMENT job as well for efficiency. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff

[Mesa-dev] [PATCH 06/12] panfrost/midgard: Schedule ball/bany to vectors

2019-03-24 Thread Alyssa Rosenzweig
Though they output scalars, they need a vector unit to make sense. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/helpers.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/helpers.h

[Mesa-dev] [PATCH 01/12] panfrost: Fix vertex/index buffer corruption

2019-03-24 Thread Alyssa Rosenzweig
Fixes a bunch of crashes in dEQP-GLES2.functional.buffer.* Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c

[Mesa-dev] [PATCH 02/12] panfrost/midgard: Fix b2f32 swizzle for vectors

2019-03-24 Thread Alyssa Rosenzweig
Fixes issues in most of dEQP-GLES2.functional.shaders.* Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/midgard_compile.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c

[Mesa-dev] [PATCH 05/12] panfrost/midgard: Add fcsel_i opcode

2019-03-24 Thread Alyssa Rosenzweig
Whereas a normal fcsel acts on a boolean input in r31.w, the fcsel_i variant acts on an integer input in r31.w, which can be preloaded with an instruction like imov (with the appropriate negate flag on the source). Signed-off-by: Alyssa Rosenzweig ---

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 --- Comment #15 from Hal Gentz --- https://lists.freedesktop.org/archives/mesa-dev/2019-March/217153.html -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH] Fixes assertion fail on startup in `glXCreateContextAttribsARB`.

2019-03-24 Thread zegentzy
From 7a701d9839ff788a79519d6ff310b489d4c1376e Mon Sep 17 00:00:00 2001 From: Hal Gentz Date: Sun, 24 Mar 2019 16:52:39 -0600 Subject: [PATCH] Fixes assertion fail on startup in `glXCreateContextAttribsARB`. To quote Uli Schlacher, who understands this stuff more than I do: > The function

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 --- Comment #14 from Hal Gentz --- Created attachment 143767 --> https://bugs.freedesktop.org/attachment.cgi?id=143767=edit Patch that fixes bug. Hey, This patch fixes this bug. I had to also patch `__glXSendErrorForXcb` because

Re: [Mesa-dev] [PATCH] intel/compiler: Print quad value in hex format

2019-03-24 Thread Sagar Ghuge
Please ignore this patch. Somehow my emails are getting delayed. This is just a duplicate of the other patch which is on mailing list. On 3/24/19 10:19 AM, Sagar Ghuge wrote: > From: Sagar Ghuge > > Print quad value same as unsigned quad so that we can distinguish in > between quater control

[Mesa-dev] [Bug 110230] error while generating the source code documentation

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110230 --- Comment #3 from Laurent --- But the link is not correct, this gives me an url not found error : https://www.mesa3d.org/doxygen/main/index.html -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 110230] error while generating the source code documentation

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110230 Bug ID: 110230 Summary: error while generating the source code documentation Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [Bug 110230] error while generating the source code documentation

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110230 --- Comment #2 from Laurent --- Ah this is something I have to install apart. Ok I've installed doxygen and now it worked. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 --- Comment #13 from Uli Schlachter --- Created attachment 143766 --> https://bugs.freedesktop.org/attachment.cgi?id=143766=edit A single-threaded reproducer I think I came up with a single-threaded program reproducing the bug. More details

[Mesa-dev] [Bug 110230] error while generating the source code documentation

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110230 --- Comment #4 from Andre Klapper --- If some incorrect link is given somewhere please explain where that incorrect link is given. Nobody can fix something without clear steps to reproduce... -- You are receiving this mail because: You are

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 Hal Gentz changed: What|Removed |Added Attachment #143763|0 |1 is obsolete|

[Mesa-dev] [PATCH] intel/compiler: Print quad value in hex format

2019-03-24 Thread Sagar Ghuge
Print quad value same as unsigned quad so that we can distinguish in between quater control disassembled values for e.g 1/2/3[Q] and immediate quad value for e.g 1Q. This allows round-tripping through the assembler/disassembler. Signed-off-by: Sagar Ghuge --- src/intel/compiler/brw_disasm.c | 2

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 Uli Schlachter changed: What|Removed |Added CC||psyc...@znc.in -- You are receiving

[Mesa-dev] [Bug 110230] "Read the documentation here" link on https://www.mesa3d.org/sourcedocs.html is a 404 error

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110230 Andre Klapper changed: What|Removed |Added Summary|error while generating the |"Read the documentation

[Mesa-dev] [Bug 110230] error while generating the source code documentation

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110230 Andre Klapper changed: What|Removed |Added CC||a9016...@gmx.de Status|NEW

[Mesa-dev] [Bug 110230] error while generating the source code documentation

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110230 --- Comment #5 from Laurent --- Here : https://www.mesa3d.org/sourcedocs.html -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 --- Comment #12 from Uli Schlachter --- I took a look at this and I would guess that the bug is in mesa. However, I do not want to built mesa myself and thus I will not test my theory. The function __glXSendError() in mesa's src/glx/glx_error.c

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 Hal Gentz changed: What|Removed |Added CC||zegen...@protonmail.com --- Comment #8 from

[Mesa-dev] [PATCH] panfrost: Preliminary work for mipmaps

2019-03-24 Thread Alyssa Rosenzweig
This patch refactors a substantial amount of code in preparation for mipmaps. In particular, we know have a correct slice abstraction based on offsets; cpu/gpu are no longer arbitrary pointers. We additionally shuffle around other code to accompany these changes and cleanup how tiled textures are

[Mesa-dev] [PATCH] panfrost: Cache index buffer bounds

2019-03-24 Thread Alyssa Rosenzweig
This code is probably a wholesale duplication of the corresponding code in mesa/src/vbo/vbo_minmax_indices.c; we should investigate reusing that. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 108 ++--

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2019-03-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99781 --- Comment #11 from Hal Gentz --- Created attachment 143765 --> https://bugs.freedesktop.org/attachment.cgi?id=143765=edit Patch for printing out backtraces for possibly relevant functions. -- You are receiving this mail because: You are

[Mesa-dev] [Bug 99781] Some Unity games fail assertion on startup in glXCreateContextAttribsARB

2019-03-24 Thread bugzilla-daemon

Re: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues (v2)

2019-03-24 Thread Neha Bhende
Looks good to me. Reviewed-by: Neha Bhende Regards, Neha From: mesa-dev on behalf of Brian Paul Sent: Friday, March 22, 2019 12:51 PM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende Subject: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context

Re: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context mix-up issues (v2)

2019-03-24 Thread Jose Fonseca
Looks good to me. Reviewed-by: Jose Fonseca Though I wonder if this could happen also when not destroying the current context. (Ie, if we need zoombie textures too?) Jose From: Brian Paul Sent: Friday, March 22, 2019 19:51 To: mesa-dev@lists.freedesktop.org