Re: [Mesa-dev] Getting write permissions on the mesa repo to push panfrost stuff

2019-07-05 Thread Boris Brezillon
On Fri, 05 Jul 2019 13:43:20 -0700 Kenneth Graunke wrote: > On Thursday, July 4, 2019 10:42:49 PM PDT Boris Brezillon wrote: > > On Thu, 04 Jul 2019 20:49:32 -0700 > > Kenneth Graunke wrote: > > > > > On Thursday, July 4, 2019 5:23:44 AM PDT Boris Brezillon wrote: > > > > Hello, > > > > >

[Mesa-dev] [Bug 111036] 5.2-rc7 19.1.1-1 repetitive error loop

2019-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111036 --- Comment #7 from Adam Honse --- I'm seeing the same errors. I built kernel 5.2-rc7 on my Rock Pi 4B (RK3399) and am running the official Debian build but upgraded to Buster (armhf). I built Mesa 19.1.1 and git master as Debian packages

Re: [Mesa-dev] [PATCH] egl/drm: ensure the backing gbm is set before using it

2019-07-05 Thread Eric Engestrom
On Friday, 2019-07-05 11:21:41 +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently, if we error out before gbm_dri is set (say due to a different > name of the backing GBM implementation, or otherwise) the tear down will > trigger a NULL ptr deref and crash out. > > Move the gbm_dri

[Mesa-dev] [Bug 110735] Meson can't find 32-bit libXvMCW in non-standard path

2019-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110735 --- Comment #5 from charlie --- In a crossfile, setting like: c_link_args = ['-L', '/home/a/lib'] terminates meson configuring earlier and results in a new error: meson.build:1114:2: ERROR: C library 'dl' not found Thanks for your time. --

Re: [Mesa-dev] Getting write permissions on the mesa repo to push panfrost stuff

2019-07-05 Thread Kenneth Graunke
On Thursday, July 4, 2019 10:42:49 PM PDT Boris Brezillon wrote: > On Thu, 04 Jul 2019 20:49:32 -0700 > Kenneth Graunke wrote: > > > On Thursday, July 4, 2019 5:23:44 AM PDT Boris Brezillon wrote: > > > Hello, > > > > > > Alyssa recently proposed that I push my own panfrost-related > > >

[Mesa-dev] [ANNOUNCE] Mesa 19.1.2 release candidate

2019-07-05 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 19.1.2 is now available. Currently we have: - 35 queued - 0? nominated (outstanding) - and 0 rejected patch The current queue consists on different fixes for the Intel and AMD Vulkan drivers, Freedreno, the Meson build system, and some other fixes for

[Mesa-dev] [PATCH] panfrost: Use standard ALIGN_POT/INFINITY macros

2019-07-05 Thread Alyssa Rosenzweig
We had vendored duplicates from pre-Mesa days; clean that up. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_afbc.c | 6 +++--- src/gallium/drivers/panfrost/pan_allocate.c | 4 ++-- src/gallium/drivers/panfrost/pan_allocate.h | 6 --

[Mesa-dev] [PATCH 0/5] gallium: kill PIPE_CAP_SM3

2019-07-05 Thread Erik Faye-Lund
Every time I stumble over PIPE_CAP_SM3, I get a bit depressed. This cap is different than most caps in Gallium, as it's much broader, and I need to read up a lot to try to figure out anything specific about what it does. Shader Model 3.0 is a *big* feature-set. It seems I'm not the only one who

Re: [Mesa-dev] [PATCH 2/3] panfrost: Allocate scanout BOs in panfrost device

2019-07-05 Thread Alyssa Rosenzweig
Ah, sure. Thank you for clarifying! signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] panfrost: Add support for modifiers

2019-07-05 Thread Daniel Stone
Hi, On Fri, 5 Jul 2019 at 14:51, Alyssa Rosenzweig wrote: > > + switch(whandle->modifier) { > > + case DRM_FORMAT_MOD_ARM_AFBC(AFBC_FORMAT_MOD_ROCKCHIP): > > + rsc->layout = PAN_AFBC; > > + break; > > Why ROCKCHIP in particular? AFBC fourcc codes are based on

[Mesa-dev] [Bug 110735] Meson can't find 32-bit libXvMCW in non-standard path

2019-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110735 --- Comment #4 from Dylan Baker --- Ah, sorry. The -D version is for the command line, in the cross file it would be : c_link_args = ['-L', '/path'] I'm on mobile, please excuse autocorrect fail. On Thu, Jul 4, 2019, 17:56 wrote: > *Comment

Re: [Mesa-dev] [PATCH 2/3] panfrost: Allocate scanout BOs in panfrost device

2019-07-05 Thread Daniel Stone
On Fri, 5 Jul 2019 at 14:38, Alyssa Rosenzweig wrote: > > +bool should_tile = !is_streaming && is_texture && is_2d && > > !is_scanout; > > I'm not opposed, but why can't we tile PIPE_BIND_SHARED textures? lima > does exactly that. If we can't tile them, we certainly can't AFBC them. We

Re: [Mesa-dev] [PATCH] radeonsi: Expose support for 10-bit VP9 decode

2019-07-05 Thread Koenig, Christian
Please ping Leo Liu since I'm currently on vacation. Christian. Am 05.07.2019 10:55 schrieb "Vishwakarma, Pratik" : On 6/28/2019 12:32 PM, Christian König wrote: > Am 28.06.19 um 07:09 schrieb Vishwakarma, Pratik: >> Fix si_vid_is_format_supported to expose support >> for 10-bit VP9 decode

Re: [Mesa-dev] [PATCH 3/3] panfrost: Add support for modifiers

2019-07-05 Thread Alyssa Rosenzweig
> Again, the winsys just pulls the list of acceptable format/modifier > pairs from the EGL format query. If Panfrost declares 1555+AFBC to be > a supported combination, then the winsys will pass that on for clients > to use. If it isn't working, my suggestion is to just never advertise > it in the

Re: [Mesa-dev] [PATCH 3/3] panfrost: Add support for modifiers

2019-07-05 Thread Alyssa Rosenzweig
> + switch(whandle->modifier) { > + case DRM_FORMAT_MOD_ARM_AFBC(AFBC_FORMAT_MOD_ROCKCHIP): > + rsc->layout = PAN_AFBC; > + break; Why ROCKCHIP in particular? AFBC fourcc codes are based on modifiers, and there are a *lot* of them. We need to figure out which

Re: [Mesa-dev] [PATCH 2/3] panfrost: Allocate scanout BOs in panfrost device

2019-07-05 Thread Alyssa Rosenzweig
> +bool should_tile = !is_streaming && is_texture && is_2d && > !is_scanout; I'm not opposed, but why can't we tile PIPE_BIND_SHARED textures? lima does exactly that. If we can't tile them, we certainly can't AFBC them. signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH 1/3] panfrost: Cache BO imports

2019-07-05 Thread Alyssa Rosenzweig
> struct panfrost_bo { > -struct pipe_reference reference; > +int refcnt; > > /* Mapping for the entire object (all levels) */ Why are we open-coding this instead of using pipe_reference? > +pthread_mutex_lock(>handle_table_lock); > +

Re: [Mesa-dev] [PATCH] mesa: Set minimum possible GLSL version

2019-07-05 Thread Emil Velikov
On Fri, 5 Jul 2019 at 05:59, Ian Romanick wrote: > > From: Ian Romanick > > Set the absolute minimum possible GLSL version. API_OPENGL_CORE can > mean an OpenGL 3.0 forward-compatible context, so that implies a minimum > possible version of 1.30. Otherwise, the minimum possible version 1.20. >

[Mesa-dev] [PATCH] egl/drm: ensure the backing gbm is set before using it

2019-07-05 Thread Emil Velikov
From: Emil Velikov Currently, if we error out before gbm_dri is set (say due to a different name of the backing GBM implementation, or otherwise) the tear down will trigger a NULL ptr deref and crash out. Move the gbm_dri initialization as early as possible. To be on the extra safe side add a

Re: [Mesa-dev] [PATCH] android: vulkan/util: fix generating vk_enum_to_str.*

2019-07-05 Thread Lionel Landwerlin
Thanks this looks good to me : Reviewed-by: Lionel Landwerlin On 05/07/2019 11:52, Chih-Wei Huang wrote: The gen_enum_to_str.py generates vk_enum_to_str.c and its header at once. However, the makefiles incorrectly list both files parallel with the same recipes. That means both two files may

Re: [Mesa-dev] [PATCH] radeonsi: Expose support for 10-bit VP9 decode

2019-07-05 Thread Vishwakarma, Pratik
On 6/28/2019 12:32 PM, Christian König wrote: > Am 28.06.19 um 07:09 schrieb Vishwakarma, Pratik: >> Fix si_vid_is_format_supported to expose support >> for 10-bit VP9 decode using P016 format. Without >> this change, 10-bit decode will be exposed only >> for HEVC even though newer hardware

[Mesa-dev] [PATCH] android: vulkan/util: fix generating vk_enum_to_str.*

2019-07-05 Thread Chih-Wei Huang
The gen_enum_to_str.py generates vk_enum_to_str.c and its header at once. However, the makefiles incorrectly list both files parallel with the same recipes. That means both two files may be generated simultaneously by two processes. The generating files may be truncated by another process, as

[Mesa-dev] [PATCH kmscube v2] Fix EGL surface creation on AMDGPU

2019-07-05 Thread Drew DeVault
We have to search for a suitable config, rather than assuming that the first is correct. --- I was originally just throwing shit from the wlroots EGL setup code at this to see if I could fix the problem, which is why there were some unrelated changes in v1. Thanks to Daniel and Emil for helping me