[Mesa-dev] [Bug 111169] libmesa_util.a(u_queue.c.o): undefined reference to symbol 'pthread_setname_np@@GLIBC_2.12'

2019-07-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69 Vinson Lee changed: What|Removed |Added CC||e...@anholt.net Keywords|

[Mesa-dev] [Bug 111169] libmesa_util.a(u_queue.c.o): undefined reference to symbol 'pthread_setname_np@@GLIBC_2.12'

2019-07-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69 Bug ID: 69 Summary: libmesa_util.a(u_queue.c.o): undefined reference to symbol 'pthread_setname_np@@GLIBC_2.12' Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [AppVeyor] mesa master #11902 failed

2019-07-18 Thread Rob Clark
On Thu, Jul 18, 2019 at 4:34 PM Roland Scheidegger wrote: > > Am 16.07.19 um 20:55 schrieb AppVeyor: > > > > Build mesa 11902 failed > > Commit 856e84083e by Rob Clark on > > 7/15/2019 4:05 PM: > > mesa/st: add sampler uniforms\n\nAdd sampler uniforms for the UV

Re: [Mesa-dev] [AppVeyor] mesa master #11902 failed

2019-07-18 Thread Roland Scheidegger
Am 16.07.19 um 20:55 schrieb AppVeyor: > > Build mesa 11902 failed > Commit 856e84083e by Rob Clark on > 7/15/2019 4:05 PM: > mesa/st: add sampler uniforms\n\nAdd sampler uniforms for the UV > plane(s), so driver can count the\nuniforms and get the correct

[Mesa-dev] [AppVeyor] mesa master #11947 failed

2019-07-18 Thread AppVeyor
Build mesa 11947 failed Commit 0395b58c92 by Alyssa Rosenzweig on 7/18/2019 7:43 PM: panfrost: Set rt_count\n\nThis doesn't quite work yet, but it illustrates how MRT is implemented\nin the MFBD: rt_count is set appropriately based on the number of

[Mesa-dev] [Bug 111150] [BRW] WRC 5 asserts with gallium nine and iris.

2019-07-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50 --- Comment #6 from Matías Zúñiga --- (In reply to Nanley Chery from comment #3) > *** Bug 62 has been marked as a duplicate of this bug. *** Sorry, i didn't find this bug before posting. The merge request also fixes the problem for me

Re: [Mesa-dev] [PATCH 2/2] meson: make "auto" only choose buildable drivers

2019-07-18 Thread Dylan Baker
Quoting Alyssa Ross (2019-07-18 10:29:45) > > For virgl/svga: I'd be inclined not to build them automatically. They're not > > useful outside of a VM, so most developers either will be exclusively > > building > > one (not both) of those, or not be interested in them at all. And Distros > >

Re: [Mesa-dev] [PATCH 2/2] meson: make "auto" only choose buildable drivers

2019-07-18 Thread Alyssa Ross
> For virgl/svga: I'd be inclined not to build them automatically. They're not > useful outside of a VM, so most developers either will be exclusively building > one (not both) of those, or not be interested in them at all. And Distros > don't > use auto options so we don't need to worry about

[Mesa-dev] R: [PATCH 1/2] meson: require libdrm for gallium svga or virgl

2019-07-18 Thread Francesco Ansanelli
Dear Alyssa, Sorry the bothering.. Your patch also added the check for freedreno, but it is not mentioned in the commit message. Is it actually what you wanted? Cheers, Francesco ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v4] anv: fix alphaToCoverage when there is no color attachment

2019-07-18 Thread Juan A. Suarez Romero
On Mon, 2019-05-06 at 16:01 +0200, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsálvez > > There are tests in CTS for alpha to coverage without a color attachment > that are failing. This happens because we remove the shader color > outputs when we don't have a valid color attachment for

Re: [Mesa-dev] [PATCH 1/2] meson: require libdrm for gallium svga or virgl

2019-07-18 Thread Dylan Baker
Quoting Alyssa Ross (2019-07-18 07:15:13) > A build with svga or virgl, but without DRI or Vulkan, still requires > libdrm, but this wasn't caught by meson. > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index

Re: [Mesa-dev] [PATCH 2/2] meson: make "auto" only choose buildable drivers

2019-07-18 Thread Dylan Baker
Quoting Alyssa Ross (2019-07-18 07:15:14) > "auto" pays attention to the OS and architecture of the target system, > but not the available libraries. If, say, libdrm isn't available, "auto" > won't work, and a manual list of drivers will be required anyway. It > would also try building the virgl

[Mesa-dev] [PATCH 2/2] meson: make "auto" only choose buildable drivers

2019-07-18 Thread Alyssa Ross
"auto" pays attention to the OS and architecture of the target system, but not the available libraries. If, say, libdrm isn't available, "auto" won't work, and a manual list of drivers will be required anyway. It would also try building the virgl and svga gallium drivers, even when unsupported due

[Mesa-dev] [PATCH 1/2] meson: require libdrm for gallium svga or virgl

2019-07-18 Thread Alyssa Ross
A build with svga or virgl, but without DRI or Vulkan, still requires libdrm, but this wasn't caught by meson. --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 13b561f99de..52dd5be25e7 100644 --- a/meson.build +++ b/meson.build @@

[Mesa-dev] [PATCH 0/2] meson: improve configuration experience

2019-07-18 Thread Alyssa Ross
Two patches here to make configuring mesa with meson a bit nicer. The first addresses some missing dependencies that weren't caught by meson, and so would result in a compiler error due to missing headers. The second makes the "auto" value for drivers quite a bit smarter in an attempt to avoid

[Mesa-dev] [PATCH 4/7] radv/gfx10: do not set ELEMENT_SIZE for buffer descriptors

2019-07-18 Thread Samuel Pitoiset
This field doesn't exist. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 6e313aa9aa1..3c553cb93e7 100644 ---

[Mesa-dev] [PATCH 6/7] radv/gfx10: emit the GS NGG prologue before the nested barrier

2019-07-18 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index 7e623414adc..6feb55e3916 100644 --- a/src/amd/vulkan/radv_nir_to_llvm.c +++

[Mesa-dev] [PATCH 5/7] radv/gfx10: do not allocate space for the ZPASS_DONE bug

2019-07-18 Thread Samuel Pitoiset
GFX10 isn't affected. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index b6ac14f63a9..84d627340e9 100644 ---

[Mesa-dev] [PATCH 2/7] radv: change a bunch of >= GFX9 to == GFX9

2019-07-18 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 6 +++--- src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_image.c | 10 +- src/amd/vulkan/si_cmd_buffer.c | 12 ++-- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git

[Mesa-dev] [PATCH 3/7] radv: clean up fill_geom_tess_rings()

2019-07-18 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 34 +- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 15bda6822e8..6e313aa9aa1 100644 ---

[Mesa-dev] [PATCH 7/7] radv/gfx10: update descriptors for inline uniform blocks

2019-07-18 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index 6feb55e3916..19dcae3a476 100644 ---

[Mesa-dev] [PATCH 1/7] ac/nir: do not clamp shadow reference on GFX10

2019-07-18 Thread Samuel Pitoiset
RadeonSI only uses Z32_FLOAT_CLAMP for upgraded depth textures on GFX10 and RADV doesn't promotes Z16 or Z24. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [AppVeyor] mesa master #11940 failed

2019-07-18 Thread AppVeyor
Build mesa 11940 failed Commit b178fdf486 by Connor Abbott on 5/11/2019 4:43 PM: lima/gp: Fix problem with complex moves\n\nWhen writing the scheduler, we forgot that you can't read the complex\nunit in certain sources because it gets overwritten to 0 or 1.

Re: [Mesa-dev] [PATCH] panfrost: Take into account a index_bias for glDrawElementsBaseVertex calls

2019-07-18 Thread Alyssa Rosenzweig
Thank you for the patch! Could you add a comment to include/panfrost_job.h explaining why this works? Thanks, Alyssa On Thu, Jul 18, 2019 at 01:11:21PM +0200, Rohan Garg wrote: > Make sure we adjust draw_start and vertex_count in order to > take into account a index_bias as required by a

[Mesa-dev] [PATCH] panfrost: Take into account a index_bias for glDrawElementsBaseVertex calls

2019-07-18 Thread Rohan Garg
Make sure we adjust draw_start and vertex_count in order to take into account a index_bias as required by a glDrawElementsBaseVertex call Signed-off-by: Rohan Garg --- src/gallium/drivers/panfrost/pan_context.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-07-18 Thread Chih-Wei Huang
Mauro Rossi 於 2019年7月14日 週日 下午5:17寫道: > > This patch partially reverts 20294dc ("mesa: Enable asm unconditionally, ...") > > Android makefile build logic needs to disable assembler optimization > in 32bit builds to avoid text relocations for libglapi.so shared > > Fixes the following build error

[Mesa-dev] [Bug 111150] [BRW] WRC 5 asserts with gallium nine and iris.

2019-07-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50 --- Comment #5 from Illia Iorin --- > I created a merge request for this issue here: > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1371 > > Please let me know if it fixes the issue. This mr fixes the issue. I tried to put the

[Mesa-dev] [Bug 111141] [REGRESSION] [BISECTED] [DXVK] 1-bit booleans and Elite Dangerous shader mis-optimization

2019-07-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41 --- Comment #8 from Steven Newbury --- So presumably it's the optimization for AMD? I had a good look through the code but I'm not sufficiently clear as to how it all works to really know where the bug might be. My current understanding,

[Mesa-dev] [AppVeyor] mesa staging/19.1 #11939 completed

2019-07-18 Thread AppVeyor
Build mesa 11939 completed Commit 0b1ee72bbc by Lionel Landwerlin on 7/17/2019 10:00 PM: anv: fix format mapping for depth/stencil formats\n\nanv_format is supposed to have a pointer back to the associated\nVkFormat, we were missed this for depth/stencil

Re: [Mesa-dev] [PATCH v2 2/3] radv/gfx10: do not emit VGT_GS_MODE

2019-07-18 Thread Bas Nieuwenhuizen
We might want to merge this into patch 1, as we now emit the R_028A84_VGT_PRIMITIVEID_EN twice after only patch 1. Either way r-b for the series On Thu, Jul 18, 2019 at 10:14 AM Samuel Pitoiset wrote: > > Unnecessary. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pipeline.c |

Re: [Mesa-dev] [PATCH 4/4] radv/gfx10: do not always execute a barrier before the second shader

2019-07-18 Thread Bas Nieuwenhuizen
r-b On Thu, Jul 18, 2019 at 10:04 AM Samuel Pitoiset wrote: > > > On 7/18/19 2:29 AM, Bas Nieuwenhuizen wrote: > > On Wed, Jul 17, 2019 at 3:44 PM Samuel Pitoiset > > wrote: > >> With NGG, empty waves may still be required to export data. > >> > >> This fixes

[Mesa-dev] [PATCH v2 1/3] radv/gfx10: move emitting VGT_PRIMITIVEID_EN into the NGG path

2019-07-18 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 9338fcd550a..bcb7ccc803d 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

[Mesa-dev] [PATCH v2 3/3] radv/gfx10: set BREAK_WAVE_AT_EOI if TES or GS enable the primitive ID

2019-07-18 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 8 1 file changed, 8 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index b11d79f4811..a7ff0e2d139 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

[Mesa-dev] [PATCH v2 2/3] radv/gfx10: do not emit VGT_GS_MODE

2019-07-18 Thread Samuel Pitoiset
Unnecessary. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index bcb7ccc803d..b11d79f4811 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

Re: [Mesa-dev] [PATCH 4/4] radv/gfx10: do not always execute a barrier before the second shader

2019-07-18 Thread Samuel Pitoiset
On 7/18/19 2:29 AM, Bas Nieuwenhuizen wrote: On Wed, Jul 17, 2019 at 3:44 PM Samuel Pitoiset wrote: With NGG, empty waves may still be required to export data. This fixes dEQP-VK.ycbcr.format.*_unorm.geometry_*. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 31

Re: [Mesa-dev] [PATCH 1/4] radv: move emitting VGT_GS_MODE into the HW VS path

2019-07-18 Thread Samuel Pitoiset
On 7/18/19 2:10 AM, Bas Nieuwenhuizen wrote: On Thu, Jul 18, 2019 at 2:05 AM Bas Nieuwenhuizen wrote: On Wed, Jul 17, 2019 at 3:44 PM Samuel Pitoiset wrote: It's useless for NGG anyways. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 43

Re: [Mesa-dev] [PATCH] radv: fix crash in shader tracing.

2019-07-18 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 7/18/19 2:51 AM, Dave Airlie wrote: From: Dave Airlie Enabling tracing, and then having a vmfault, can leads to a segfault before we print out the traces, as if a meta shader is executing and we don't have the NIR for it. Just pass the stage and give back a

Re: [Mesa-dev] [PATCH] radv: reset the window scissor with no clear state.

2019-07-18 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 7/18/19 3:20 AM, Dave Airlie wrote: From: Dave Airlie IF we don't have clear state (which gfx10 doesn't currently) we will fix to reset the scissor. AMDVLK will leave it set to something else. Marek also has this fix for radeonsi pending. ---

Re: [Mesa-dev] [PATCH] radv: put back VGT_FLUSH at ring init on gfx10

2019-07-18 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 7/18/19 8:14 AM, Dave Airlie wrote: From: Dave Airlie I can find no evidence that removing this is a good idea. Fixes: 9b116173b6a ("radv: do not emit VGT_FLUSH on GFX10") --- src/amd/vulkan/radv_device.c | 6 ++ 1 file changed, 2 insertions(+), 4

[Mesa-dev] [PATCH] radv: put back VGT_FLUSH at ring init on gfx10

2019-07-18 Thread Dave Airlie
From: Dave Airlie I can find no evidence that removing this is a good idea. Fixes: 9b116173b6a ("radv: do not emit VGT_FLUSH on GFX10") --- src/amd/vulkan/radv_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_device.c