Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Rob Clark
hmm, initially the UCP lowering did work post var lowering (since it had work after tgsi_to_nir).. the same might not be true of the drawpix/wpos_ytransform/etc lowering that is used internally in mesa/st for variants. I assume something like this is the issue? BR, -R On Fri, Oct 18, 2019 at

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Marek Olšák
Oh BTW, drivers that want to implement pipe_screen::finalize_nir to improve cached shader compilation can't use any of those lowering passes, because then things blow up. The only _optional_ lowering you can do in st/mesa is clamp_color and force_persample_in_shader, which covers iris at least

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Marek Olšák
Note that none of the lowering passes work if I enable them on radeonsi. So if you think about enabling them for your driver, I guess you have some work to do in the driver as well. On the other hand, having multiple shader variants in st/mesa is a performance disadvantage. The lowering should be

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Marek Olšák
On Fri, Oct 18, 2019 at 9:07 AM Ilia Mirkin wrote: > On Fri, Oct 18, 2019 at 9:04 AM Erik Faye-Lund > wrote: > > > > On Fri, 2019-10-18 at 08:57 -0400, Ilia Mirkin wrote: > > > On Fri, Oct 18, 2019 at 8:51 AM Erik Faye-Lund > > > wrote: > > > > On Thu, 2019-10-17 at 22:24 -0400, Ilia Mirkin

[Mesa-dev] [ANNOUNCE] Mesa 19.1.8 release candidate

2019-10-18 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 19.1.8 is now available. Currently we have: - 58 queued - 0 nominated (outstanding) - and 4 rejected patch NOTE: It is anticipated that 19.1.8 will be the final release in the 19.1 series. Users of 19.1 are encouraged to migrate to the 19.2 series in

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Ilia Mirkin
On Fri, Oct 18, 2019 at 9:07 AM Ilia Mirkin wrote: > > On Fri, Oct 18, 2019 at 9:04 AM Erik Faye-Lund > wrote: > > > > On Fri, 2019-10-18 at 08:57 -0400, Ilia Mirkin wrote: > > > On Fri, Oct 18, 2019 at 8:51 AM Erik Faye-Lund > > > wrote: > > > > On Thu, 2019-10-17 at 22:24 -0400, Ilia Mirkin

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Ilia Mirkin
On Fri, Oct 18, 2019 at 9:04 AM Erik Faye-Lund wrote: > > On Fri, 2019-10-18 at 08:57 -0400, Ilia Mirkin wrote: > > On Fri, Oct 18, 2019 at 8:51 AM Erik Faye-Lund > > wrote: > > > On Thu, 2019-10-17 at 22:24 -0400, Ilia Mirkin wrote: > > > > In the meanwhile (unless you plan on taking up Jason's

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Erik Faye-Lund
On Fri, 2019-10-18 at 08:57 -0400, Ilia Mirkin wrote: > On Fri, Oct 18, 2019 at 8:51 AM Erik Faye-Lund > wrote: > > On Thu, 2019-10-17 at 22:24 -0400, Ilia Mirkin wrote: > > > In the meanwhile (unless you plan on taking up Jason's > > > suggestion), > > > might I recommend some assert's for the

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Erik Faye-Lund
On Thu, 2019-10-17 at 20:55 -0500, Jason Ekstrand wrote: > On Thu, Oct 17, 2019 at 10:39 AM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > This is discussed in the merge request thread. Zink currently only > > support vertex and fragment shaders, so it's the only place this > > can

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Ilia Mirkin
On Fri, Oct 18, 2019 at 8:51 AM Erik Faye-Lund wrote: > > On Thu, 2019-10-17 at 22:24 -0400, Ilia Mirkin wrote: > > In the meanwhile (unless you plan on taking up Jason's suggestion), > > might I recommend some assert's for the unhandled cases so that there > > are no surprises? > > Good idea. I

Re: [Mesa-dev] mesa/st: support lowering user-clip-planes automatically

2019-10-18 Thread Erik Faye-Lund
On Thu, 2019-10-17 at 22:24 -0400, Ilia Mirkin wrote: > In the meanwhile (unless you plan on taking up Jason's suggestion), > might I recommend some assert's for the unhandled cases so that there > are no surprises? Good idea. I sent a MR for it here: