If you haven't pushed this yet, could you add:
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2003
To the commit message?
Dylan
Quoting Roland Scheidegger (2019-10-25 15:40:02)
> Looks alright to me.
> Reviewed-by: Roland Scheidegger
>
> Am 25.10.19 um 23:12 schrieb Jose Fonseca:
> >
Looks alright to me.
Reviewed-by: Roland Scheidegger
Am 25.10.19 um 23:12 schrieb Jose Fonseca:
> - Use parsed options instead of using ARGUMENTS directly.
> - Handle case mingw cross compilation.
> ---
> SConstruct | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git
- Use parsed options instead of using ARGUMENTS directly.
- Handle case mingw cross compilation.
---
SConstruct | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/SConstruct b/SConstruct
index 61a915f7deb..f905189dd9e 100644
--- a/SConstruct
+++ b/SConstruct
@@ -71,9 +71,8
On Friday, 2019-10-25 13:09:30 +0200, Timur Kristóf wrote:
> I think it depends on how much time it adds to the CI.
> If the overhead is negligible, then it makes a lot of sense to have CI
> make a release build in addition to the debug ones.
Exactly; see MR !2469 for that, I won't have time to
I don't have time to look into this more right now, but I've posted
a WIP MR for it:
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2469
On Friday, 2019-10-25 11:48:47 +0100, Eric Engestrom wrote:
> (for the record, the MR has been reviewed and will be merged when the
> pipeline comes
I think it depends on how much time it adds to the CI.
If the overhead is negligible, then it makes a lot of sense to have CI
make a release build in addition to the debug ones.
While we are at it:
Would it be possible to add some CI tests to ensure that Nine doesn't
break (even if it builds),
(for the record, the MR has been reviewed and will be merged when the
pipeline comes back all green)
The problem is that the CI does debug builds, while this was
a release-build-only issue.
We could perform multiple types of builds each time, but that would
multiply the CI time/cost; I'll take a
Hi guys,
How is it possible that the CI didn't detect this problem?
Isn't there at least one build in the CI system which builds Nine?
I've created a MR to deal with it:
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2465
Best regards,
Tim
On Thu, 2019-10-24 at 23:31 +0200, Axel Davy
Hi Dieter,
Maybe the best fix would be to change the definition of WARN and DBG
when DEBUG is disabled.
The definitions are in nine_debug.h
I haven't tried by maybe using "(void)" instead of nothing would work ?
Yours,
Axel
On 24/10/2019 16:34, Dieter Nützel wrote:
Hello Eric,
your
