Re: [Mesa-dev] [PATCH] nir: no-op C99 _Pragma() with MSVC

2019-11-22 Thread Giuseppe Bilotta
On Sat, Nov 23, 2019 at 3:49 AM Brian Paul wrote: > + > +/* MSVC doesn't have C99's _Pragma() */ > +#ifdef _MSC_VER > +#define _Pragma(x) > +#endif FWIW, MSVC has its own __pragma() extension instead of _Pragma(), but IIRC the syntax is slightly different (the contents are tokens, not a string

Re: [Mesa-dev] [PATCH] nir: no-op C99 _Pragma() with MSVC

2019-11-22 Thread Ian Romanick
On 11/22/19 6:49 PM, Brian Paul wrote: > This fixes a build failure on MSVC. > > BTW, it looks like clang supports _Pragma() but I don't know if it > understands the "gcc unroll N" directive. It probably doesn't, but that should be okay. This just exists to speed up the debug builds in the

[Mesa-dev] [PATCH] nir: no-op C99 _Pragma() with MSVC

2019-11-22 Thread Brian Paul
This fixes a build failure on MSVC. BTW, it looks like clang supports _Pragma() but I don't know if it understands the "gcc unroll N" directive. Signed-off-by: Brian Paul --- src/compiler/nir/nir_range_analysis.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] Revert "draw: revert using correct order for prim decomposition."

2019-11-22 Thread Zebediah Figura
Thanks! On 11/22/19 1:39 PM, Roland Scheidegger wrote: Sorry for the delay, I've now pushed this. Roland Am 21.11.19 um 06:31 schrieb Zebediah Figura: Ping? On 11/5/19 10:21 AM, Zebediah Figura wrote: This reverts commit f97b731c82afb06cfd6ffebc90a3e098a9a1b308. Closes:

Re: [Mesa-dev] [PATCH] Revert "draw: revert using correct order for prim decomposition."

2019-11-22 Thread Roland Scheidegger
Sorry for the delay, I've now pushed this. Roland Am 21.11.19 um 06:31 schrieb Zebediah Figura: > Ping? > > On 11/5/19 10:21 AM, Zebediah Figura wrote: >> This reverts commit f97b731c82afb06cfd6ffebc90a3e098a9a1b308. >> >> Closes: >>