On Wed, Oct 6, 2021 at 12:28 PM Jordan Justen wrote:
>
> Mike Blumenkrantz writes:
>
> > On Wed, Oct 6, 2021 at 1:27 PM Bas Nieuwenhuizen
> > wrote:
> >
> >> On Wed, Oct 6, 2021 at 7:07 PM Jason Ekstrand
> >> wrote:
> >> >
> >> > My primary grip with approvals or the button is that it's the
On Wed, Oct 6, 2021 at 10:07 AM Jason Ekstrand wrote:
>
> On Wed, Oct 6, 2021 at 11:24 AM Emma Anholt wrote:
> >
> > On Wed, Oct 6, 2021 at 9:20 AM Mike Blumenkrantz
> > wrote:
> > >
> > > Hi,
> > >
> > > It's recently come to my attention that gitlab has Approvals. Was anyone
> > > else aware
Bas Nieuwenhuizen writes:
> On Wed, Oct 6, 2021 at 8:49 PM Jordan Justen
> wrote:
>>
>> I guess I missed where it was suggested that Marge should remove
>> Reviewed-by tags. I don't think Marge should ever remove something from
>> the commit message.
>
> AFAIU this is upstream Marge behavior.
On Wed, Oct 6, 2021 at 2:46 PM Jason Ekstrand wrote:
> On Wed, Oct 6, 2021 at 12:37 PM Mike Blumenkrantz
> wrote:
> >
> > On Wed, Oct 6, 2021 at 1:27 PM Bas Nieuwenhuizen <
> b...@basnieuwenhuizen.nl> wrote:
> >>
> >> On Wed, Oct 6, 2021 at 7:07 PM Jason Ekstrand
> wrote:
> >> >
> >> > On Wed,
On Wed, Oct 6, 2021 at 8:49 PM Jordan Justen wrote:
>
> Mike Blumenkrantz writes:
>
> > On Wed, Oct 6, 2021 at 1:27 PM Bas Nieuwenhuizen
> > wrote:
> >
> >> On Wed, Oct 6, 2021 at 7:07 PM Jason Ekstrand
> >> wrote:
> >> >
> >> > My primary grip with approvals or the button is that it's the
Mike Blumenkrantz writes:
> On Wed, Oct 6, 2021 at 1:27 PM Bas Nieuwenhuizen
> wrote:
>
>> On Wed, Oct 6, 2021 at 7:07 PM Jason Ekstrand
>> wrote:
>> >
>> > My primary grip with approvals or the button is that it's the wrong
>> > granularity. It's per-MR instead of per-patch. When people
On Wed, Oct 6, 2021 at 12:37 PM Mike Blumenkrantz
wrote:
>
> On Wed, Oct 6, 2021 at 1:27 PM Bas Nieuwenhuizen
> wrote:
>>
>> On Wed, Oct 6, 2021 at 7:07 PM Jason Ekstrand wrote:
>> >
>> > On Wed, Oct 6, 2021 at 11:24 AM Emma Anholt wrote:
>> > >
>> > > On Wed, Oct 6, 2021 at 9:20 AM Mike
On Wed, Oct 6, 2021 at 1:27 PM Bas Nieuwenhuizen
wrote:
> On Wed, Oct 6, 2021 at 7:07 PM Jason Ekstrand
> wrote:
> >
> > On Wed, Oct 6, 2021 at 11:24 AM Emma Anholt wrote:
> > >
> > > On Wed, Oct 6, 2021 at 9:20 AM Mike Blumenkrantz
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > > > It's
On Wed, Oct 6, 2021 at 7:07 PM Jason Ekstrand wrote:
>
> On Wed, Oct 6, 2021 at 11:24 AM Emma Anholt wrote:
> >
> > On Wed, Oct 6, 2021 at 9:20 AM Mike Blumenkrantz
> > wrote:
> > >
> > > Hi,
> > >
> > > It's recently come to my attention that gitlab has Approvals. Was anyone
> > > else aware
On Wed, Oct 6, 2021 at 11:24 AM Emma Anholt wrote:
>
> On Wed, Oct 6, 2021 at 9:20 AM Mike Blumenkrantz
> wrote:
> >
> > Hi,
> >
> > It's recently come to my attention that gitlab has Approvals. Was anyone
> > else aware of this feature? You can just click a button and have your name
> >
On Wed, Oct 6, 2021 at 9:20 AM Mike Blumenkrantz
wrote:
>
> Hi,
>
> It's recently come to my attention that gitlab has Approvals. Was anyone else
> aware of this feature? You can just click a button and have your name
> recorded in the system as having signed off on landing a patch? Blew my
Hi,
It's recently come to my attention that gitlab has Approvals. Was anyone
else aware of this feature? You can just click a button and have your name
recorded in the system as having signed off on landing a patch? Blew my
mind.
So with that being said, we also have this thing in the Mesa repo
12 matches
Mail list logo
