Re: [Mesa-dev] loader: Add amdgpu code to loader.c

2016-11-24 Thread Albert Freeman
A different patch to that code has been applied that does the same thing in a different (better) way. On 24 November 2016 at 05:25, Albert Freeman wrote: > I wrote this code in response to a issue someone on mesa-users had > (https://lists.freedesktop.org/archives/mesa-users/2016-October/

[Mesa-dev] loader: Add amdgpu code to loader.c

2016-11-24 Thread Albert Freeman
I wrote this code in response to a issue someone on mesa-users had (https://lists.freedesktop.org/archives/mesa-users/2016-October/001231.html). They didn't reply so I don't know if the patch resolved the issue. Can someone please determine its usefulness. Also please check if drmCommandWrite() is

Re: [Mesa-dev] radv initial submission

2016-10-04 Thread Albert Freeman
It might be a good idea to consider moving the nir -> llvm code out of the amd folder for reuse by a Vulkan software rasterizer or something. I have heard another developers recent interest in developing a Vulkan software rasterizer. I at one stage was interested in developing a Vulkan software ras

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-10-03 Thread Albert Freeman
remember which years are quaterly. Though I am just trying to help, I personally don't care what release system is chosen, so you need not take my opinion into consideration. On 3 October 2016 at 09:40, Jason Ekstrand wrote: > > On Oct 3, 2016 12:19 AM, "Albert Freem

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-10-03 Thread Albert Freeman
year.month or year.dayoutofdaysthatyear dayoutoofdaysthatyear skips lots of integers quickly: reducing confusion of where is release x.(y - something) and better handles quick fix releases but makes it harder to determine how far into the year the release is although with some effort can be conver

Re: [Mesa-dev] [PATCH] gallium: build virgl by default.

2015-11-22 Thread Albert Freeman
On 23 November 2015 at 03:17, Ilia Mirkin wrote: > On Sun, Nov 22, 2015 at 9:28 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> No reason not to build this, it has no external >> requirements at the moment. > > Not that I object, but what's the policy around these defaults? Should > we also ad

Re: [Mesa-dev] List of unsupported extensions per driver

2015-09-29 Thread Albert Freeman
On 29 September 2015 at 14:48, Romain Failliot wrote: > What I don't understand is that all the lines starting with a "-" seems to > be part of the GL_ARB_gpu_shader5 extension. See the line here: > http://cgit.freedesktop.org/mesa/mesa/tree/docs/GL3.txt#n99 > > If I'm right, it means that, consid

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

2015-09-29 Thread Albert Freeman
On 29 September 2015 at 15:01, Marek Olšák wrote: > On Tue, Sep 29, 2015 at 4:54 PM, Albert Freeman > wrote: >> On 29 September 2015 at 07:28, Albert Freeman >> wrote: >>> On 29 September 2015 at 07:25, Albert Freeman >>> wrote: >>>> O

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

2015-09-29 Thread Albert Freeman
On 29 September 2015 at 07:28, Albert Freeman wrote: > On 29 September 2015 at 07:25, Albert Freeman > wrote: >> On 28 September 2015 at 08:10, Marek Olšák wrote: >>> On Mon, Sep 28, 2015 at 7:20 AM, Albert Freeman >>> wrote: >>>> On 28 September

Re: [Mesa-dev] Pending issues of lollipop-x86

2015-09-29 Thread Albert Freeman
On 28 September 2015 at 20:25, Marek Olšák wrote: > On Mon, Sep 28, 2015 at 10:19 PM, Chad Versace wrote: >> On Fri 25 Sep 2015, Chih-Wei Huang wrote: >>> CC to mesa-dev for help. >>> >>> 2015-09-25 22:12 GMT+08:00 Chih-Wei Huang : >>> > 2015-09-25 16:21 GMT+08:00 Chih-Wei Huang : >>> >> Actually

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

2015-09-29 Thread Albert Freeman
On 29 September 2015 at 07:25, Albert Freeman wrote: > On 28 September 2015 at 08:10, Marek Olšák wrote: >> On Mon, Sep 28, 2015 at 7:20 AM, Albert Freeman >> wrote: >>> On 28 September 2015 at 14:38, Albert Freeman >>> wrote: >>>> On 28 Septe

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

2015-09-29 Thread Albert Freeman
On 28 September 2015 at 08:10, Marek Olšák wrote: > On Mon, Sep 28, 2015 at 7:20 AM, Albert Freeman > wrote: >> On 28 September 2015 at 14:38, Albert Freeman >> wrote: >>> On 28 September 2015 at 04:12, Emil Velikov >>> wrote: >>>> O

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

2015-09-27 Thread Albert Freeman
On 28 September 2015 at 15:20, Albert Freeman wrote: > On 28 September 2015 at 14:38, Albert Freeman > wrote: >> On 28 September 2015 at 04:12, Emil Velikov wrote: >>> On 26 September 2015 at 00:49, Marek Olšák wrote: >>>> From: Marek Olšák >>>> &

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

2015-09-27 Thread Albert Freeman
On 28 September 2015 at 14:38, Albert Freeman wrote: > On 28 September 2015 at 04:12, Emil Velikov wrote: >> On 26 September 2015 at 00:49, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> The spec doesn't require it. This fixes a crash on Android. &g

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

2015-09-27 Thread Albert Freeman
On 28 September 2015 at 04:12, Emil Velikov wrote: > On 26 September 2015 at 00:49, Marek Olšák wrote: >> From: Marek Olšák >> >> The spec doesn't require it. This fixes a crash on Android. >> > Nicely spotted Marek. > > A couple of related (not supposed to be part of this patch) notes: > - Thi

Re: [Mesa-dev] [PATCH] docs/GL3.txt: fix typo

2015-09-27 Thread Albert Freeman
> parts of GL_ARB_gpu_shader5, which is done for some drivers) >GL_OES_primitive_bounding boxnot started > -- > 2.5.3 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedeskto

Re: [Mesa-dev] Pending issues of lollipop-x86

2015-09-27 Thread Albert Freeman
On 27 September 2015 at 03:21, Mauro Rossi wrote: > Hi, > > Marek's patches solved Camera and Youtube crashes on nouveau and radeonsi. > I'm available to test on i965, if needed > > I think at this point the remaining major problem for lollipop-x86 is the > font artifacts/invisible chars on i965GM

Re: [Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

2015-09-27 Thread Albert Freeman
: > NULL, > dri2_sync->fence, wait_flags, > timeout)) >dri2_sync->base.SyncStatus = EGL_SIGNALED_KHR; > -- > 2.1.4 > > ___ > mesa-dev mailing list &

Re: [Mesa-dev] [PATCH 1/2] st/dri: don't use _ctx in client_wait_sync

2015-09-26 Thread Albert Freeman
top of your patch against mesa git): diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index ab940e4..712203b 100644 --- a/src/gallium/state_trackers/dri/dri2.c +++ b/src/gallium/state_trackers/dri/dri2.c @@ -1338,6 +1338,7 @@ dri2_get_fence_from_cl_ev

Re: [Mesa-dev] [PATCH] gallium/util: avoid unreferencing random memory on buffer alloc failure

2015-09-26 Thread Albert Freeman
Reviewed-by: Albert Freeman On 27 September 2015 at 09:41, Albert Freeman wrote: > On 27 September 2015 at 09:35, Ilia Mirkin wrote: >> On Sat, Sep 26, 2015 at 7:29 PM, Albert Freeman >> wrote: >>> On 27 September 2015 at 03:46, Ilia Mirkin wrote: >>>> Fo

Re: [Mesa-dev] [PATCH] gallium/util: avoid unreferencing random memory on buffer alloc failure

2015-09-26 Thread Albert Freeman
On 27 September 2015 at 09:35, Ilia Mirkin wrote: > On Sat, Sep 26, 2015 at 7:29 PM, Albert Freeman > wrote: >> On 27 September 2015 at 03:46, Ilia Mirkin wrote: >>> Found by Coverity >>> >>> Signed-off-by: Ilia Mirkin >>> --- >>>

Re: [Mesa-dev] [PATCH] gallium/util: avoid unreferencing random memory on buffer alloc failure

2015-09-26 Thread Albert Freeman
On 27 September 2015 at 03:46, Ilia Mirkin wrote: > Found by Coverity > > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/util/u_blitter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/util/u_blitter.c > b/src/gallium/auxiliary/util/u_bl

Re: [Mesa-dev] memoryBarrier + SSBO

2015-09-26 Thread Albert Freeman
On 27 September 2015 at 08:32, Albert Freeman wrote: > On 27 September 2015 at 08:30, Ilia Mirkin wrote: >> On Sat, Sep 26, 2015 at 6:12 PM, Albert Freeman >> wrote: >>> On 26 September 2015 at 03:32, Ilia Mirkin wrote: >>>> Hi Ian (and other spec experts),

Re: [Mesa-dev] memoryBarrier + SSBO

2015-09-26 Thread Albert Freeman
On 27 September 2015 at 08:30, Ilia Mirkin wrote: > On Sat, Sep 26, 2015 at 6:12 PM, Albert Freeman > wrote: >> On 26 September 2015 at 03:32, Ilia Mirkin wrote: >>> Hi Ian (and other spec experts), >>> >>> The ARB_ssbo spec mentions the following:

Re: [Mesa-dev] memoryBarrier + SSBO

2015-09-26 Thread Albert Freeman
On 26 September 2015 at 03:32, Ilia Mirkin wrote: > Hi Ian (and other spec experts), > > The ARB_ssbo spec mentions the following: > > OpenGL 4.0 (either core or compatibility profile) is required. > > ... > > Additionally, the shading language provides the memoryBarrier() function > t

Re: [Mesa-dev] [PATCH] Fix commit f9caabe8f1bff86d19b53d9ecba5c72b238d9e23

2015-09-12 Thread Albert Freeman
FFER) > #define LLVM_R600_BUFFER_INFO_CONST_BUFFER \ > (CONSTANT_BUFFER_0_ADDR_SPACE + R600_BUFFER_INFO_CONST_BUFFER) > > -- > 2.5.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.fre

Re: [Mesa-dev] [PATCH 1/4] winsys/svga: remove useless assertion

2015-09-10 Thread Albert Freeman
Reviewed-by: Albert Freeman On 10 September 2015 at 15:03, Brian Paul wrote: > An unsigned int is always >= 0. Found with Coverity. > --- > src/gallium/winsys/svga/drm/vmw_context.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/gallium/winsys/svga/drm/v

[Mesa-dev] [PATCH] clover: Avoid using typename to allow compilation of clover by clang

2015-09-07 Thread Albert Freeman
"enum type". Replaced "typename" with "enum" to force clang to declare the variable marg_type with type "enum type" of module::argument. CC: "11.0" Reviewed-by: Francisco Jerez Signed-off-by: Albert Freeman --- src/gallium/state_trackers/clover/l

Re: [Mesa-dev] Adaptive Vsync

2015-09-07 Thread Albert Freeman
On 8 September 2015 at 01:16, Albert Freeman wrote: > On 7 September 2015 at 08:22, Emil Velikov wrote: >> On 7 September 2015 at 05:59, Albert Freeman >> wrote: >>> Correction, we just need someone to mark all the comitted patches in >>> patchwork... >

Re: [Mesa-dev] Adaptive Vsync

2015-09-07 Thread Albert Freeman
On 7 September 2015 at 08:22, Emil Velikov wrote: > On 7 September 2015 at 05:59, Albert Freeman > wrote: >> Correction, we just need someone to mark all the comitted patches in >> patchwork... > This is already done automatically. > > Sigh top posting :'(. >

Re: [Mesa-dev] Adaptive Vsync

2015-09-06 Thread Albert Freeman
Correction, we just need someone to mark all the comitted patches in patchwork so that we can easily pick out the ones with issues. On 7 September 2015 at 04:56, Albert Freeman wrote: > Oops, my "plan" focuses on patches that have nothing wrong with them, > instead of patches tha

Re: [Mesa-dev] Adaptive Vsync

2015-09-06 Thread Albert Freeman
er 2015 at 11:42, Albert Freeman wrote: > Ah, okay. I see what you mean now (i.e. you had to wait three months > for those suggestions I mentioned). I still haven't recieved a > response at all for my first patch from almost a year ago (although it > was insanely tri

Re: [Mesa-dev] Adaptive Vsync

2015-09-06 Thread Albert Freeman
knowledge. 2. We can't just automatically commit patches for security reasons (best not to mention). 3. Whether committers would even like to make any changes. On 6 September 2015 at 08:28, Lauri Kasanen wrote: > On Sat, 5 Sep 2015 23:29:05 + > Albert Freeman wrote: > >> Th

Re: [Mesa-dev] [PATCH] configure.ac: Add support to enable read-only text segment on x86.

2015-09-05 Thread Albert Freeman
Maybe we should add some kind of prefix to this to indicate a performance vs security trade off and a more powerful general overide option to enable/disable all such future flags? On 4 September 2015 at 09:39, Jeremy Huddleston Sequoia wrote: > Wow, that's a blast from the past ;) > >> On Sep 3,

Re: [Mesa-dev] Adaptive Vsync

2015-09-05 Thread Albert Freeman
The reply from Eric Anholt made two suggestions that should not be difficult to implement for someone who made the patch in the first place. Why would code be committed when improvements could be easily made? From what I have seen, this kind of thing happens even to experienced mesa developers who

[Mesa-dev] [RFC] Fix for clang compiler issue as reported in Bug 91826

2015-09-01 Thread Albert Freeman
Clang tryed to declare the non type member of struct module (enum type type) (in clover/core/module.hpp) instead of a variable of type enum (enum type). Signed-off-by: Albert Freeman --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Mesa-dev] [PATCH] mesa: removed reference to unused header

2014-12-01 Thread Albert Freeman
Removed reference to unused header file to reduce src/mesa/main dependency on src/mesa/drivers. Signed-off-by: Albert Freeman --- I do not have commit access! No regressions with piglit (tests/quick.py). src/mesa/main/enable.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa