[Mesa-dev] [PATCH 1/4] mesa: Use separate line for function return type

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/mesa/main/framebuffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/framebuffer.c b/src/mesa/main/framebuffer.c index 46a6f64..e1505fa 100644 --- a/src/mesa/main/framebuffer.c +++ b/src/mes

[Mesa-dev] [PATCH] i965: Fix GPU hang related to multiple render targets and alpha testing

ected 0xc" This patch fixes the GPU hang as well as the simulator warning with new piglit test fbo-mrt-alphatest-no-buffer-zero-write: https://patchwork.freedesktop.org/patch/118212 No regressions in Jenkins CI system. Cc: "12.0 13.0" <mesa-sta...@lists.freedesktop.org>

Re: [Mesa-dev] [PATCH 2/2] radv: Replace "abi_versions" with correct "api_version".

; @@ -2,6 +2,6 @@ > "file_format_version": "1.0.0", > "ICD": { > "library_path": "libvulkan_radeon.so", > -"abi_versions": "1.0.3" > +"api_version": "1.0.3" > } > } >

[Mesa-dev] [PATCH 3/3] i965/gen8: Don't enable alpha test and alpha to coverage if draw bufer zero is integer type

We follow this rule at multiple places in i965 driver. This patch doesn't fix any testcase. Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/mesa/drivers/dri/i965/gen8_blend_state.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/mesa/drive

[Mesa-dev] [PATCH 1/3] i965/gen8: Use DrawBuffer->_IntegerBuffers in gen8_upload_blend_state()

No functional changes in this patch. Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/mesa/drivers/dri/i965/gen8_blend_state.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_blend_state.c b/src/mesa/drivers/dr

[Mesa-dev] [PATCH 2/3] i965/gen8: Use DrawBuffer->_IntegerBuffers in gen8_upload_ps_blend()

No functional changes in this patch. Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/mesa/drivers/dri/i965/gen8_blend_state.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_blend_state.c b/src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH] egl/surfaceless: Fix segfault in eglSwapBuffers

ers_with_damage = dri2_fallback_swap_buffers_with_damage, > .swap_buffers_region = dri2_fallback_swap_buffers_region, > .post_sub_buffer = dri2_fallback_post_sub_buffer, > -- > 2.10.0 > > _______ > mesa-dev mailing list > mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 1/6] anv/cmd_buffer: Move state base address re-emit into ExecuteCommands

he primary after > +* all of the secondaries are done. > +* > +* TODO: Maybe we want to make this a dirty bit to avoid extra state base > +* address calls? > +*/ > + anv_cmd_buffer_emit_state_base_address(primary); > } > > VkResult anv_CreateCommandPo

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix gl_InvocationID in dual object GS where invocations == 1.

____ > mesa-stable mailing list > mesa-sta...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-stable LGTM. Verified the recommendation in PRM: Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: Return correct result in EnumeratePhysicalDevices

(*pPhysicalDeviceCount < instance->physicalDeviceCount) { > + return VK_INCOMPLETE; > } else { >*pPhysicalDeviceCount = 0; > } > -- > 2.10.0 > > ___ > mesa-dev mailing list > mesa-dev@lists

[Mesa-dev] [PATCH] docs: Mark GL_OES_viewport_array done on i965

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- docs/features.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index 85ad1a1..4c744c6 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -319,7 +319,7 @@ Khrono

Re: [Mesa-dev] [PATCH] i965/l3: Remove redundant is_cherryview check

turn 2; > > - else if (devinfo->is_cherryview || devinfo->gt == 1) > + /* XXX: Cherryview and Broxton are always gt1 */ > + else if (devinfo->gt == 1) >return 4; > > else > -- > 2.10.0 > > ___ > mesa-

Re: [Mesa-dev] [PATCH] aubinator: use the correct format specifier for printing ptrdiff_t.

file->cursor = file->end; > -- > 2.10.0 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com>

[Mesa-dev] [PATCH] anv/gen7_pipeline: Fix typo in semicolon

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen7_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index bafee28..c9d1f64 100644 --- a/src/intel/vulkan/gen7_pipe

Re: [Mesa-dev] [PATCH 8/9] anv/gen7_pipeline: Set few missing fields in 3DSTATE_PS

On Fri, Sep 30, 2016 at 5:02 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Sep 30, 2016 3:34 PM, "Anuj Phogat" <anuj.pho...@gmail.com> wrote: >> >> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> >> --- >> src/intel/vulkan/ge

Re: [Mesa-dev] [PATCH 9/9] anv/gen7_pipeline: Check for ksp0 when setting BarycentricInterpolationMode in 3DSTATE_WM

On Fri, Sep 30, 2016 at 5:03 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Sep 30, 2016 3:34 PM, "Anuj Phogat" <anuj.pho...@gmail.com> wrote: >> >> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> >> --- >> src/intel/vulkan/gen7_pi

[Mesa-dev] [PATCH V2 8/9] anv/gen7_pipeline: Set sample mask field in 3DSTATE_PS

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen7_pipeline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index 9411631..bafee28 100644 --- a/src/intel/vulkan/gen7_pipeline.c +++ b/src

Re: [Mesa-dev] [PATCH 4/9] anv/gen8_pipeline: Use Alternate floating point mode when use_alt_mode is set in prog_data

On Sun, Oct 2, 2016 at 1:59 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > On Friday, September 30, 2016 3:33:12 PM PDT Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> >> --- >> src/intel/vulkan/gen8_pipeline.c | 3 ++- >> 1 fi

Re: [Mesa-dev] [PATCH 3/3] mesa: make _mesa_texture_buffer_range() static

struct gl_buffer_object *bufObj, > - GLintptr offset, GLsizeiptr size, > - const char *caller); > - > bool > _mesa_is_cube_map_texture(GLenum target); > > -- > 1.9.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Series is: Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 4/9] anv/gen8_pipeline: Use Alternate floating point mode when use_alt_mode is set in prog_data

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen8_pipeline.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/gen8_pipeline.c b/src/intel/vulkan/gen8_pipeline.c index 1abb97c..7a9a3cf 100644 --- a/src/intel/vulkan/gen8_pipe

[Mesa-dev] [PATCH 8/9] anv/gen7_pipeline: Set few missing fields in 3DSTATE_PS

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen7_pipeline.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index 9411631..4bab0bc 100644 --- a/src/intel/vulkan/gen7_pipeline.c +++ b/src

[Mesa-dev] [PATCH 9/9] anv/gen7_pipeline: Check for ksp0 when setting BarycentricInterpolationMode in 3DSTATE_WM

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen7_pipeline.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index 4bab0bc..e804002 100644 --- a/src/intel/vulkan/gen7_pipe

[Mesa-dev] [PATCH 7/9] anv/gen7_pipeline: Move ksp{1, 2} state setting next to ksp0

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen7_pipeline.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index f98aef5..9411631 100644 --- a/src/intel/vulkan/gen7_pipe

[Mesa-dev] [PATCH 1/9] intel/genxml: Fix typo in gen75.xml

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/genxml/gen75.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/genxml/gen75.xml b/src/intel/genxml/gen75.xml index 1debc3a..8e18007 100644 --- a/src/intel/genxml/gen75.xml +++ b/src/intel/genxml

[Mesa-dev] [PATCH 6/9] anv/gen7_pipeline: Set few missing fields in 3DSTATE_VS

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen7_pipeline.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index 8d133b6..f98aef5 100644 --- a/src/intel/vulkan/gen7_pipeline.c +++

[Mesa-dev] [PATCH 5/9] anv/gen7: Make use of local variable prog_data

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/mesa/drivers/dri/i965/gen7_vs_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_vs_state.c b/src/mesa/drivers/dri/i965/gen7_vs_state.c index 57e0419..d3bd9fd 100644 ---

[Mesa-dev] [PATCH 3/9] anv/gen8_pipeline: Fix typo in semicolon

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen8_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/gen8_pipeline.c b/src/intel/vulkan/gen8_pipeline.c index 030f71e..1abb97c 100644 --- a/src/intel/vulkan/gen8_pipe

[Mesa-dev] [PATCH 2/9] intel/genxml: Keep the value name 'Alternate' uniform across gen75.xml

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/genxml/gen75.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/genxml/gen75.xml b/src/intel/genxml/gen75.xml index 8e18007..b8f5a14 100644 --- a/src/intel/genxml/gen75.xml +++ b/src/intel/

Re: [Mesa-dev] [PATCH] mesa: move _mesa_valid_to_render() to api_validate.c

_Shader->ActiveProgram, > -errMsg, 100)) { > - _mesa_error(ctx, GL_INVALID_OPERATION, "%s", errMsg); > - return GL_FALSE; > - } > - } > - > - if (ctx->DrawBuffer->_Status != GL_FRAMEBUFFER_COMPLETE_EXT) { > -

Re: [Mesa-dev] [PATCH 1/3] mesa: Enable enums for OES_viewport_array

On Thu, Sep 29, 2016 at 11:45 AM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > 2016-09-29 14:42 GMT-04:00 Anuj Phogat <anuj.pho...@gmail.com>: >> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> >> Cc: Ilia Mirkin <imir...@alum.mit.edu> >>

[Mesa-dev] [PATCH 1/3] mesa: Enable enums for OES_viewport_array

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> Cc: Ilia Mirkin <imir...@alum.mit.edu> --- src/mesa/main/get.c | 6 ++ src/mesa/main/get_hash_params.py | 8 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main

[Mesa-dev] [PATCH 2/3] mesa: Add a check for OES_viewport_array

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> Cc: Ilia Mirkin <imir...@alum.mit.edu> --- src/mesa/main/viewport.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c index f59723f..bd58044 100644 --- a/s

[Mesa-dev] [PATCH 3/3] i965/gen8+: Enable GL_OES_viewport_array

[min, max] tuple may be determined by calling GetFloatv with the symbolic constant VIEWPORT_BOUNDS_RANGE_OES" I will open a khronos CTS bug to get the test fixed. V2: Initialize the relevant variables for GL_OES_viewport_array on hsw+ Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com>

Re: [Mesa-dev] [PATCH] i965/gen8+: Enable GL_OES_viewport_array

On Thu, Sep 22, 2016 at 5:59 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Wed, Sep 21, 2016 at 2:15 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: >> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> >> >> --- >> This patch requires below series

Re: [Mesa-dev] [PATCH] anv/gen7_pipeline: Use MSDISPMODE_PERSAMPLE for non-multisampled fbo

On Wed, Sep 21, 2016 at 12:49 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: > On Wed, Sep 21, 2016 at 11:49 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: >> This seems odd... When can it even happen that we have persample_dispatch >> set in wm_surface_state and

Re: [Mesa-dev] [PATCH] i965: Remove useless (harmful) assertion

___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Only emit 1 viewport when possible.

rc/mesa/drivers/dri/i965/gen8_viewport_state.c > index acaee1a..84000e3 100644 > --- a/src/mesa/drivers/dri/i965/gen8_viewport_state.c > +++ b/src/mesa/drivers/dri/i965/gen8_viewport_state.c > @@ -37,8 +37,11 @@ gen8_upload_sf_clip_viewport(struct brw_context *brw) > const float fb_height = (

[Mesa-dev] [PATCH V2] anv/blorp: Handle zero width/height blits in blorp_copy()

V2: Move the check from copy_buffer_to_image() to blorp_copy(). (Nanley) Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> Cc: Nanley Chery <nanley.g.ch...@intel.com> --- src/intel/blorp/blorp_blit.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src

Re: [Mesa-dev] [PATCH] anv/blorp: Handle zero width/height copying in copy_buffer_to_image

bugging time sometime later. > > On Wed, Sep 21, 2016 at 11:17:08AM -0700, Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> >> --- >> src/intel/vulkan/anv_blorp.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a

Re: [Mesa-dev] [PATCH] anv/gen7_pipeline: Use MSDISPMODE_PERSAMPLE for non-multisampled fbo

. It's recommended in graphics spec for gen7. Also look at gen7_wm_state.c. > > On Sep 21, 2016 9:14 PM, "Anuj Phogat" <anuj.pho...@gmail.com> wrote: >> >> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> >> --- >> src/intel/vulkan/gen7_pipeline.c

[Mesa-dev] [PATCH] anv/blorp: Handle zero width/height copying in copy_buffer_to_image

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/anv_blorp.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index cb61070..de33dce 100644 --- a/src/intel/vulkan/anv_blorp.c +++ b/src/intel/

[Mesa-dev] [PATCH] intel/isl: Add an assert to check zero width/height surface

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/isl/isl_surface_state.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index 1a1a819..b20f767 100644 --- a/src/intel/isl/isl_surface_state.c +++

[Mesa-dev] [PATCH] i965/gen8+: Enable GL_OES_viewport_array

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- This patch requires below series: https://patchwork.freedesktop.org/series/12594/ --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/sr

[Mesa-dev] [PATCH] anv/gen7_pipeline: Use MSDISPMODE_PERSAMPLE for non-multisampled fbo

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen7_pipeline.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index 878308b..5150ef9 100644 --- a/src/intel/vulkan/gen7_pipe

Re: [Mesa-dev] [PATCH v3] aubinator: Fix the decoding of values that span two Dwords

TYPE_STRUCT: > snprintf(iter->value, sizeof(iter->value), > @@ -529,7 +553,7 @@ gen_field_iterator_next(struct gen_field_iterator *iter) >break; > case GEN_TYPE_UFIXED: >snprintf(iter->value, sizeof(iter->value), > - "%f", (float) field(v.dw, f->start, f->end) / (1 << > f->type.f)); > + "%f", (float) field(v.qw, f->start, f->end) / (1 << > f->type.f)); >break; > case GEN_TYPE_SFIXED: >/* FIXME: Sign extend extracted field. */ > -- > 2.7.4 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] aubinator: Fix the decoding of values that span two Dwords

On Tue, Sep 20, 2016 at 3:31 PM, Sirisha Gandikota wrote: > From: Sirisha Gandikota > > Fixed the way the values that span two Dwords are decoded. > Based on the start and end indices of the field, the Dwords > are fetched and decoded

Re: [Mesa-dev] [PATCH] aubinator: Fix the decoding of values that span two Dwords

if ((f->end - f->start) > 32) > + v.dw = ((uint64_t) iter->p[index+1] << 32 ) | iter->p[index]; Omit the white space after 32. > + else > + v.dw = iter->p[index]; > + > switch (f->type.kind) { > case GEN_TYPE_UNKNOWN: >

Re: [Mesa-dev] [PATCH 1/2] i965: Rename __DRIScreen pointers to "dri_screen".

een = screen->driverPrivate; > + struct intel_screen *intelScreen = dri_screen->driverPrivate; > > assert(attachment == __DRI_BUFFER_FRONT_LEFT || >attachment == __DRI_BUFFER_BACK_LEFT); > @@ -1736,7 +1740,7 @@ intelAllocateBuffer(__DRIscreen *screen, > } > > static void > -intelReleaseBuffer(__DRIscreen *screen, __DRIbuffer *buffer) > +intelReleaseBuffer(__DRIscreen *dri_screen, __DRIbuffer *buffer) > { > struct intel_buffer *intelBuffer = (struct intel_buffer *) buffer; > > diff --git a/src/mesa/drivers/dri/i965/intel_syncobj.c > b/src/mesa/drivers/dri/i965/intel_syncobj.c > index aaf0094d..dfda448 100644 > --- a/src/mesa/drivers/dri/i965/intel_syncobj.c > +++ b/src/mesa/drivers/dri/i965/intel_syncobj.c > @@ -248,7 +248,7 @@ intel_dri_create_fence(__DRIcontext *ctx) > } > > static void > -intel_dri_destroy_fence(__DRIscreen *screen, void *driver_fence) > +intel_dri_destroy_fence(__DRIscreen *dri_screen, void *driver_fence) > { > struct brw_fence *fence = driver_fence; > > diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c > b/src/mesa/drivers/dri/i965/intel_tex_image.c > index f204db3..a7c321b 100644 > --- a/src/mesa/drivers/dri/i965/intel_tex_image.c > +++ b/src/mesa/drivers/dri/i965/intel_tex_image.c > @@ -384,12 +384,11 @@ intel_image_target_texture_2d(struct gl_context *ctx, > GLenum target, > { > struct brw_context *brw = brw_context(ctx); > struct intel_mipmap_tree *mt; > - __DRIscreen *screen; > + __DRIscreen *dri_screen = brw->intelScreen->driScrnPriv; > __DRIimage *image; > > - screen = brw->intelScreen->driScrnPriv; > - image = screen->dri2.image->lookupEGLImage(screen, image_handle, > - screen->loaderPrivate); > + image = dri_screen->dri2.image->lookupEGLImage(dri_screen, image_handle, > + dri_screen->loaderPrivate); > if (image == NULL) >return; > > -- > 2.10.0 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Both patches are: Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/6] mesa: add new entrypoints for GL_OES_viewport_array

iewport.h b/src/mesa/main/viewport.h > index b0675db..3951319 100644 > --- a/src/mesa/main/viewport.h > +++ b/src/mesa/main/viewport.h > @@ -58,8 +58,14 @@ extern void GLAPIENTRY > _mesa_DepthRangeArrayv(GLuint first, GLsizei count, const GLclampd * v); > > extern void GLAPIENTRY > +_mesa_DepthRangeArrayfvOE

Re: [Mesa-dev] [PATCH 1/4] i965/fs: Use sample interpolation for interpolateAtCentroid in persample mode

On Wed, Sep 14, 2016 at 1:31 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > > > On Wed, Sep 14, 2016 at 1:29 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: >> >> On Wed, Sep 14, 2016 at 10:45 AM, Jason Ekstrand <ja...@jlekstrand.net> >&

Re: [Mesa-dev] [PATCH 1/4] i965/fs: Use sample interpolation for interpolateAtCentroid in persample mode

On Wed, Sep 14, 2016 at 10:45 AM, Jason Ekstrand wrote: > From the ARB_gpu_shader5 spec: > >The built-in functions interpolateAtCentroid() and interpolateAtSample() >will sample variables as though they were declared with the "centroid" >or "sample" qualifiers,

Re: [Mesa-dev] [PATCH 3/3] intel/blorp: Stop setting 3DSTATE_DRAWING_RECTANGLE

; + rect.ClippedDrawingRectangleXMax = MAX2(params->x1, params->x0) - 1; > + rect.ClippedDrawingRectangleYMax = MAX2(params->y1, params->y0) - 1; > + } > + > blorp_exec(batch, params); > > /* Make sure we didn't wrap the batch

Re: [Mesa-dev] [PATCH 1/3] intel: Move Vulkan sample positions to common code

t;genxml/genX_pack.h" > > @@ -77,12 +77,12 @@ genX(init_device_state)(struct anv_device *device) > * VkPhysicalDeviceFeatures::standardSampleLocations. > */ > anv_batch_emit(, GENX(3DSTATE_SAMPLE_PATTERN), sp) { > - SAMPLE_POS_1X(sp._1xSample); > - SAMP

Re: [Mesa-dev] [PATCH v4] i965: Fix calculation of the image height at start level

intelImage->base.Base.Level; > + break; > + default: > + unreachable("Unexpected target"); > } > > /* Guess a reasonable value for lastLevel. This is probably going > -- > 2.7.4 > > ___

Re: [Mesa-dev] [PATCH 30/33] anv: Use blorp for CopyBuffer and UpdateBuffer

On Sat, Sep 3, 2016 at 8:53 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > > > On Fri, Sep 2, 2016 at 12:05 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: >> >> On Wed, Aug 31, 2016 at 2:22 PM, Jason Ekstrand <ja...@jlekstrand.net> >> wrote: >

Re: [Mesa-dev] [PATCH 33/33] anv: Use blorp for doing MSAA resolves

.layers = 1 > -}, > -_buffer->pool->alloc, > -_h); > - > - ANV_CALL(CmdBeginRenderPass)(cmd_buffer_h, > -&(VkRenderPassBeginInfo) { > - .sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO, > - .renderPass = device->meta_state.resolve.pass

Re: [Mesa-dev] [PATCH 30/33] anv: Use blorp for CopyBuffer and UpdateBuffer

On Wed, Aug 31, 2016 at 2:22 PM, Jason Ekstrand wrote: > --- > src/intel/vulkan/Makefile.sources | 1 - > src/intel/vulkan/anv_blorp.c | 184 > ++ > src/intel/vulkan/anv_meta_copy.c | 180 - >

Re: [Mesa-dev] [PATCH 26/33] anv: Use blorp to implement VkBlitImage

cStates = (VkDynamicState[]) { > -VK_DYNAMIC_STATE_VIEWPORT, > -VK_DYNAMIC_STATE_SCISSOR, > -VK_DYNAMIC_STATE_LINE_WIDTH, > -VK_DYNAMIC_STATE_DEPTH_BIAS, > -VK_DYNAMIC_STATE_BLEND_CONSTANTS, > -

Re: [Mesa-dev] [PATCH mesa 3/3] anv/meta: fix unreachable() typo

On Tue, Aug 30, 2016 at 12:18 PM, Eric Engestrom <e...@engestrom.ch> wrote: > On Tue, Aug 30, 2016 at 10:10:41AM -0700, Anuj Phogat wrote: >> On Tue, Aug 30, 2016 at 3:36 AM, Eric Engestrom >> <eric.engest...@imgtec.com> wrote: >> > Signed-off-by: Eric

Re: [Mesa-dev] [PATCH mesa] anv/wayland: fix assert typo

ling list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa 3/3] anv/meta: fix unreachable() typo

eers, > Eric > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Series is: Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: fix format conversion bug in get_tex_rgba_uncompressed()

_______ > mesa-stable mailing list > mesa-sta...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-stable Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] anv: pipeline: gen7: fix assert in debug mode

It was holding the jenkins system to run cts on HSW. So I pushed [PATCH 1/2] upstream. On Fri, Aug 12, 2016 at 5:02 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: > On Thu, Aug 11, 2016 at 10:25 AM, Lionel Landwerlin > <llandwer...@gmail.com> wrote: >> SampleMask is

Re: [Mesa-dev] [PATCH 1/2] anv: pipeline: gen7: fix assert in debug mode

+#endif > > if (info) { >samples = info->rasterizationSamples; > -- > 2.8.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Thanks for fixing this. Rev

Re: [Mesa-dev] [PATCH V2 2/2] i965: Change 8X MSAA sample mapping

> other one because there's technically a regression between the two. Both > are > > Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> > > On Thu, Aug 11, 2016 at 12:28 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: >> >> This is required following the

Re: [Mesa-dev] [PATCH] anv: Use macro to avoid code duplication for sample positions

On Thu, Aug 11, 2016 at 4:06 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > Thanks! > > Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> > > On Thu, Aug 11, 2016 at 10:39 AM, Anuj Phogat <anuj.pho...@gmail.com> wrote: >> >> Suggested-by: Jason

[Mesa-dev] [PATCH V2 1/2] i965: Change 8x multisample positions

have a higher standard deviation but I think after some discussion it was decided that it would be better to pick the same pattern as the other graphics API in case there are games that rely on this pattern." Observed no regressions in jenkins testing. Signed-off-by: Anuj Phogat <anuj.pho...@

[Mesa-dev] [PATCH V2 2/2] i965: Change 8X MSAA sample mapping

This is required following the change in 8X sample positions. Fixes the recently modified multisample-scaled-blit piglit tests. Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 10 +- src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH] i965: Change 8x multisample positions

On Thu, Aug 11, 2016 at 10:53 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > > > On Thu, Aug 11, 2016 at 10:41 AM, Anuj Phogat <anuj.pho...@gmail.com> wrote: >> >> There are no standard sample positions defined in OpenGL and OpenGL >> ES specs. I

Re: [Mesa-dev] [PATCH] anv/device: Add limits for InterpolationOffset

On Fri, Jul 29, 2016 at 2:30 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: > > > On Fri, Jul 29, 2016 at 12:32 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: >> >> >> >> On Thu, Jul 28, 2016 at 6:31 PM, Jason Ekstrand <ja...@jlekstrand.net> >

[Mesa-dev] [PATCH] i965: Change 8x multisample positions

have a higher standard deviation but I think after some discussion it was decided that it would be better to pick the same pattern as the other graphics API in case there are games that rely on this pattern." Observed no regressions in jenkins testing. Signed-off-by: Anuj Phogat <anuj.pho...@

[Mesa-dev] [PATCH] anv: Use macro to avoid code duplication for sample positions

Suggested-by: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/genX_multisample.h | 95 +++ src/intel/vulkan/genX_pipeline_util.h | 35 ++--- src/intel/vulkan/genX_state.c

[Mesa-dev] [PATCH V2 2/3] anv/pipeline: Add sample locations for gen7-7.5

V1: Add multisample positions (Nanley) V2: Fix 8x sample positions to match OpenGL (Anuj) V3: Vulkan has standard sample locations. They need not be same as in OpenGL. (Anuj) Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> --

Re: [Mesa-dev] [PATCH 3/3] anv/gen7_pipeline: Set multisample state using shared function

Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> > > On Mon, Aug 8, 2016 at 2:57 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: >> >> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> >> --- >> src/intel/vulkan/gen7_pipeline.c | 16 +--- &g

[Mesa-dev] [PATCH] anv/device: Enable sample shading on gen7+

Passes all 30 min_sample_shading tests in vulkan cts. Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index c2c5153..b

[Mesa-dev] [PATCH 3/3] anv/gen7_pipeline: Set multisample state using shared function

Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen7_pipeline.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index 5395e79..17d7ccc 100644 --- a/src/intel/

[Mesa-dev] [PATCH 2/3] anv/pipeline: Add sample locations for gen7-7.5

V1: Add multisample positions (Nanley) V2: Fix 8x sample positions (Anuj) Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/genX_pipeline_util.h | 47 +++ 1 file changed, 47 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline_uti

[Mesa-dev] [PATCH 1/3] anv/pipeline: Move emit_ms_state() to genX_pipeline_util.h

This will help sharing multisample state setting code. Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen8_pipeline.c | 40 --- src/intel/vulkan/genX_pipeline_util.h | 40 +++ 2 files chang

Re: [Mesa-dev] [PATCH 2/2] anv: gen7/75: Set multisample modes

e, > isl_format_get_depth_format(isl_format, false); >} > } > + > + sf.MultisampleRasterizationMode = (ms_info && > ms_info->rasterizationSamples > 1) ? > + MSRASTMODE_ON_PATTERN : > MSRASTMODE

Re: [Mesa-dev] [PATCH] anv: gen7/75: enable multisampling (v2)

On Fri, Aug 5, 2016 at 4:38 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > > > On Fri, Aug 5, 2016 at 4:29 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: > >> >> >> On Fri, Aug 5, 2016 at 3:57 PM, Lionel Landwerlin <llandwer...@gmail.com&g

Re: [Mesa-dev] [PATCH] anv: gen7/75: enable multisampling (v2)

.git ​I'm using commit ​ ​f13b15d ​.​ You should remove them from commit message if they are no longer part of CTS. > Tested on IVB/HSW > > v2: Check pMultisampleState is not NULL > > Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> > Cc: Anuj Phogat <anuj.pho.

Re: [Mesa-dev] [PATCH] anv: gen7/75: enable multisampling (v2)

On Fri, Aug 5, 2016 at 1:23 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: > > On Fri, Aug 5, 2016 at 10:05 AM, Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > >> Fixes 6 failures from dEQP-VK.api.copy_and_blit.resolve_image.* >> >

Re: [Mesa-dev] [PATCH] anv: gen7/75: enable multisampling (v2)

On Fri, Aug 5, 2016 at 10:05 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Fixes 6 failures from dEQP-VK.api.copy_and_blit.resolve_image.* > ​No tests are run with --deqp-case=dEQP-VK.api.copy_and_blit.resolve_image.* This is what i'm seeing on hsw without this patch: ./deqp-vk

Re: [Mesa-dev] [PATCH] anv/device: Add limits for InterpolationOffset

On Fri, Jul 29, 2016 at 12:32 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: > > > On Thu, Jul 28, 2016 at 6:31 PM, Jason Ekstrand <ja...@jlekstrand.net> > wrote: > >> On Jul 28, 2016 7:37 PM, "Anuj Phogat" <anuj.pho...@gmail.com> wrote: >>

Re: [Mesa-dev] [PATCH] anv/device: Add limits for InterpolationOffset

On Thu, Jul 28, 2016 at 6:31 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Jul 28, 2016 7:37 PM, "Anuj Phogat" <anuj.pho...@gmail.com> wrote: > > > > Fixes the vulkan cts regression in test > dEQP-VK.api.info.device.properties > > > > C

[Mesa-dev] [PATCH] anv/device: Add limits for InterpolationOffset

Fixes the vulkan cts regression in test dEQP-VK.api.info.device.properties Cc: Mark Janes <mark.a.ja...@intel.com> Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/anv_device.c | 6 +++--- 1 file changed,

Re: [Mesa-dev] [PATCH 1/2] anv/pipeline: Fix setting per sample shading in pixel shader

rking on fixing gen7 multisampling. I'll add sample shading bits after that. > Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> > > On Jul 28, 2016 1:31 PM, "Anuj Phogat" <anuj.pho...@gmail.com> wrote: > >> We should use the persample_dispatch variable in p

[Mesa-dev] [PATCH 1/2] anv/pipeline: Fix setting per sample shading in pixel shader

ed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen8_pipeline.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/intel/vulkan/gen8_pipeline.c b/src/intel/vulkan/gen8_pipeline.c index cc10d3a..67ffca6 100644 --- a/src/intel/vulkan/gen8_pipeline.c +++

[Mesa-dev] [PATCH 2/2] anv: Enable per sample shading on gen8+

ed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/anv_device.c| 2 +- src/intel/vulkan/gen8_pipeline.c | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 2e91980..c2c5153 100644 ---

Re: [Mesa-dev] [PATCH] anv/pipeline: Enable only one dispatch width in case of per sample shading

On Tue, Jul 26, 2016 at 7:27 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Jul 26, 2016 12:54 PM, "Anuj Phogat" <anuj.pho...@gmail.com> wrote: > > > > Fixes ~45 DEQP sample shading tests: > > ./deqp-vk --deqp-case=dEQP-VK.pipeline.multisample.mi

[Mesa-dev] [PATCH] anv/pipeline: Enable only one dispatch width in case of per sample shading

Fixes ~45 DEQP sample shading tests: ./deqp-vk --deqp-case=dEQP-VK.pipeline.multisample.min_sample_shading* Many tests exited with VK_ERROR_OUT_OF_DEVICE_MEMORY without this patch. Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- A

Re: [Mesa-dev] [PATCH 01/21] i965/fs: Get rid of fs_visitor::do_dual_src.

E); > + It'll be nice to add this assert here: assert(!prog_data->dual_src_blend || key->nr_color_regions == 1); > if (inst == NULL) { >/* Even if there's no color buffers enabled, we still need to send > * alpha out the pipeline to our null renderbuffer to support

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/9] anv/clear: Handle ClearImage on 3-D images

On Thu, Jul 21, 2016 at 9:21 PM, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > Cc: "12.0" > Cc: Nanley Chery > --- > src/intel/vulkan/anv_meta_clear.c | 6 -- > 1 file changed,

Re: [Mesa-dev] [PATCH 1/3] i965/blorp/gen8: Stop multiplying depth by 6 for cubes

_______ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev LGTM. Series is: Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] nir: Lower interp_var_at_* like a normal load_var for flat inputs.

ic_interp_var_at_centroid: > -- > 2.9.0 > > _______ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Don't call GenerateMipmap if Width or Height == 0.

____ > mesa-stable mailing list > mesa-sta...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-stable Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] nir: Fix uninitialized use of 'replacement'.

_for_ssa(>dest.ssa)); > } else { > nir_dest_copy(>dest, >dest, state->mem_ctx); > } >} > >nir_instr_insert_before(>instr, >instr); >nir_instr_remove(>instr); > } > > return true; >

Re: [Mesa-dev] [PATCH 4/4] mesa: handle numLevels, numSamples in _mesa_test_proxy_teximage()

On Fri, Jul 15, 2016 at 12:34 PM, Brian Paul <bri...@vmware.com> wrote: > On 07/15/2016 01:19 PM, Anuj Phogat wrote: >> >> On Fri, Jul 15, 2016 at 10:14 AM, Brian Paul <bri...@vmware.com> wrote: >>> >>> If numSamples > 0, we can compute the siz

Re: [Mesa-dev] [PATCH 4/4] mesa: handle numLevels, numSamples in _mesa_test_proxy_teximage()

On Fri, Jul 15, 2016 at 10:14 AM, Brian Paul wrote: > If numSamples > 0, we can compute the size of the whole mipmapped texture. > That's the case for glTexStorage(GL_PROXY_TEXTURE_x). > > Also, multiply the texture size by numSamples for MSAA textures. > --- >

Re: [Mesa-dev] [PATCH V2 1/3] mesa: Add the infrastructure for KHR_texture_compression_astc_sliced_3d

On Thu, Jul 14, 2016 at 11:30 AM, Nanley Chery <nanleych...@gmail.com> wrote: > On Thu, Jul 14, 2016 at 11:12:45AM -0700, Anuj Phogat wrote: >> V2: Drop the changes to gl.xml. >> >> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> >> --- >> src/me

<    1   2   3   4   5   6   7   8   9   10   >