Re: [Mesa-dev] [PATCH] gbm: add gbm_{bo, surface}_create_with_modifiers2

ent or cache configuration. > > Cheers, > Daniel Yeah... leaving an optional usage would have been ideal, however, I think the way I peddled it, it was required - so we were all wrong :-) -- Ben Widawsky, Intel Open Source Technology Center ___

Re: [Mesa-dev] [PATCH] RFC: Externd IMG_context_priority with NV_context_priority_realtime

On 18-03-31 12:00:16, Chris Wilson wrote: Quoting Kenneth Graunke (2018-03-30 19:20:57) On Friday, March 30, 2018 7:40:13 AM PDT Chris Wilson wrote: > For i915, we are proposing to use a quality-of-service parameter in > addition to that of just a priority that usurps everyone. Due to our HW, >

Re: [Mesa-dev] [PATCH] intel/gen9+: Enable object level preemption.

On 18-02-20 09:15:01, Antognolli, Rafael wrote: On Tue, Feb 20, 2018 at 08:11:14AM -0800, Rafael Antognolli wrote: On Fri, Feb 16, 2018 at 06:37:55PM -0800, Ben Widawsky wrote: > On 18-02-16 13:44:00, Antognolli, Rafael wrote: > > "This field controls the granularity of the re

Re: [Mesa-dev] [PATCH] intel/gen9+: Enable object level preemption.

e of finer granularity when preemption is available. Does the kernel actually disable it? I thought the kernel just doesn't touch it (I don't think it's whitelisted by the kernel either, it's just writable). Signed-off-by: Rafael Antognolli <rafael.antogno...@intel.com> Cc: Ben Widawsky &l

Re: [Mesa-dev] [PATCH] intel/compiler/gen10: Disable push constants.

com> Cc: Ben Widawsky <b...@bwidawsk.net> Cc: Kenneth Graunke <kenn...@whitecape.org> Since this improves the current situation by enabling more workloads to be run by folks with these platforms, and we don't regress any of the conformance suites, this is: Reviewed-by: Ben Widawsky

Re: [Mesa-dev] [PATCH] i965: add 2xMSAA and 16xMSAA to DRI configs for Gen9.

On 17-08-24 14:16:39, kevin.rogo...@intel.com wrote: From: Kevin Rogovin Special thanks to Eero Tamminen for reporting rasterizer numbers being twice what it should be for 2xMSAA under a benchmark. Signed-off-by: Kevin Rogovin ---

Re: [Mesa-dev] [PATCH mesa] i965: add missing `const` in function signature

On 17-08-24 11:01:34, Matt Turner wrote: Reviewed-by: Matt Turner <matts...@gmail.com> I'm blaming this one on someone else's rebase ;-) Reviewed-by: Ben Widawsky <b...@bwidawsk.net> ___ mesa-dev mailing list mesa-dev@lists.freedeskt

Re: [Mesa-dev] [PATCH v2 4/5] intel/screen: Report the correct number of image planes

al IMO.. Reviewed-by: Ben Widawsky <b...@bwidawsk.net> --- src/mesa/drivers/dri/i965/intel_screen.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 9e65273..d454eeb 100644 --- a/src/

Re: [Mesa-dev] [PATCH 2/2] i965/screen: Stop redefining DRM_FORMAT_MOD_(INVALID|LINEAR)

_LINEAR 0 -#endif - static const __DRIconfigOptionsExtension brw_config_options = { .base = { __DRI_CONFIG_OPTIONS, 1 }, .xml = Both are: Reviewed-by: Ben Widawsky <b...@bwidawsk.net> -- Ben Widawsky, Intel Open Source Technology Center __

Re: [Mesa-dev] [Intel-gfx] [PATCH 3/3] intel: Make driver aware of MOCS table version

On 17-07-07 09:28:08, Jason Ekstrand wrote: On Thu, Jul 6, 2017 at 4:27 PM, Ben Widawsky <b...@bwidawsk.net> wrote: We don't yet have optimal MOCS settings, but we have enough to know how to at least determine when we might have non-optimal settings within our driver. Signed-off-b

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/1] drm/i915: Version the MOCS settings

On 17-07-07 09:23:26, Jason Ekstrand wrote: On Fri, Jul 7, 2017 at 3:34 AM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: Quoting Ben Widawsky (2017-07-07 00:27:01) > drivers/gpu/drm/i915/i915_drv.c | 3 +++ > drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i91

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/1] drm/i915: Version the MOCS settings

On 17-07-07 11:34:48, Chris Wilson wrote: Quoting Ben Widawsky (2017-07-07 00:27:01) drivers/gpu/drm/i915/i915_drv.c | 3 +++ drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_pci.c | 13 + include/uapi/drm/i915_drm.h | 8 4 files changed, 22

[Mesa-dev] [PATCH 0/3] MOCS versioning

b5bc24e988 Author: Ben Widawsky <benjamin.widaw...@intel.com> Date: Fri Apr 8 10:21:16 2016 -0700 i965: Use PTE mocs Signed-off-by: Ben Widawsky <benjamin.widaw...@intel.com> diff --git a/src/mesa/drivers/dri/i965/brw_mocs.c b/src/mesa/drivers/dri/i965/brw_mocs.c index

[Mesa-dev] [PATCH 3/3] intel: Make driver aware of MOCS table version

We don't yet have optimal MOCS settings, but we have enough to know how to at least determine when we might have non-optimal settings within our driver. Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/intel/vulkan/anv_device.c | 12 src/intel/vulkan/anv_pri

[Mesa-dev] [PATCH 2/3] intel: Merge latest i915 uapi

Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/intel/drm/i915_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/src/intel/drm/i915_drm.h b/src/intel/drm/i915_drm.h index c26bf7c125..69e38ce89f 100644 --- a/src/intel/drm/i915_drm.h +++ b/src/intel/drm/i915_drm.h @@

[Mesa-dev] [PATCH 1/1] drm/i915: Version the MOCS settings

From: Ben Widawsky <benjamin.widaw...@intel.com> Starting with GEN9, Memory Object Control State (MOCS) becomes an index into a table as opposed to the direct programming within the command. The table has 62 usable entries (ie 6 bits can represent all settings), and each buffer type may u

Re: [Mesa-dev] [PATCH] i965: Naive implementation of gbm_bo_map

Tomasz. On 21 April 2017 at 18:17, Ben Widawsky <b...@bwidawsk.net> wrote: Could do smarter stuff with the mappings. I decided not to. Tested with kmscube. No current clients seem to use non-zero x0, y0, so that's untested. Cc: Tapani Pälli <tapani.pa...@intel.com> (AndroidIA?

Re: [Mesa-dev] [PATCH v3 02/15] dri: Add an image creation with modifiers

On 17-05-10 23:15:29, Varad Gautam wrote: From: Ben Widawsky <b...@bwidawsk.net> Modifiers will be obtained or guessed by the client and passed in during image creation/import. As of this patch, the modifiers aren't plumbed all the way down, this patch simply makes sure the interface

Re: [Mesa-dev] [PATCH 11/12] i965/cnl: Properly handle l3 configuration

On 17-05-02 11:51:28, Francisco Jerez wrote: Anuj Phogat <anuj.pho...@gmail.com> writes: On Mon, Apr 24, 2017 at 9:15 PM, Ben Widawsky <b...@bwidawsk.net> wrote: On 17-04-18 18:18:39, Francisco Jerez wrote: Most, if not all of the unrelated changes that snuck in were due to

Re: [Mesa-dev] [PATCH kmscube 1/2] common: use %llx to print modifier

Fix kmscube -A on i915 :P On 17-04-28 14:17:34, Rob Clark wrote: I guess this applies on top of one of Ben's in-flight patches? Perhaps it can be squashed into that? (Otherwise remind me about this when the modifiers patchset is merged) BR, -R On Fri, Apr 28, 2017 at 12:18 PM, Lucas Stach

Re: [Mesa-dev] [PATCH 07/12] i965/cnl: Restore lossless compression for sRGB formats

On 17-04-25 14:53:46, Anuj Phogat wrote: On Mon, Apr 24, 2017 at 10:57 PM, Ben Widawsky <b...@bwidawsk.net> wrote: On 17-04-15 18:27:33, Jason Ekstrand wrote: On April 14, 2017 5:37:55 PM Anuj Phogat <anuj.pho...@gmail.com> wrote: From: Ben Widawsky <b...@bwidawsk.net&

Re: [Mesa-dev] [PATCH 07/12] i965/cnl: Restore lossless compression for sRGB formats

On 17-04-15 18:27:33, Jason Ekstrand wrote: On April 14, 2017 5:37:55 PM Anuj Phogat <anuj.pho...@gmail.com> wrote: From: Ben Widawsky <b...@bwidawsk.net> This support was removed on gen9 (it worked before then) and was brought back for gen10. Signed-off-by: Ben Widawsky <

Re: [Mesa-dev] [PATCH 11/12] i965/cnl: Properly handle l3 configuration

pho...@gmail.com> writes: From: Ben Widawsky <benjamin.widaw...@intel.com> V2: Squash the changes in one patch and rebased on master (Anuj). Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/com

Re: [Mesa-dev] [PATCH] autogen.sh: set default sendemail.to

"Otherwise" is certainly not okay, but I like this. Feel free to nak of course. Acked-by: Ben Widawsky <b...@bwidawsk.net> On April 24, 2017 6:16:14 PM Emil Velikov <emil.l.veli...@gmail.com> wrote: From: Emil Velikov <emil.veli...@collabora.com> To ease patch submission

[Mesa-dev] [PATCH] i965: Naive implementation of gbm_bo_map

Could do smarter stuff with the mappings. I decided not to. Tested with kmscube. No current clients seem to use non-zero x0, y0, so that's untested. Cc: Tapani Pälli <tapani.pa...@intel.com> (AndroidIA?) Cc: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Ben Widawsky <b.

[Mesa-dev] [PATCH kmscube 2/6] configure: Check for the GBM modifiers

--- configure.ac | 16 1 file changed, 16 insertions(+) diff --git a/configure.ac b/configure.ac index aa0ef36..33167e4 100644 --- a/configure.ac +++ b/configure.ac @@ -49,5 +49,21 @@ if test "x$HAVE_GST" = "xyes"; then fi AM_CONDITIONAL(ENABLE_GST, [test "x$HAVE_GST" =

[Mesa-dev] [PATCH kmscube 5/6] common: Use libdrm AddFB with modifiers

Note: nothing happens here yet since LINEAR == 0. --- configure.ac | 2 +- drm-common.c | 37 + 2 files changed, 34 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 33167e4..f564ef3 100644 --- a/configure.ac +++ b/configure.ac @@

[Mesa-dev] [PATCH kmscube 4/6] common: Use the create with modifiers interface

--- common.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/common.c b/common.c index 4bf3c5a..e63bb39 100644 --- a/common.c +++ b/common.c @@ -31,10 +31,23 @@ static struct gbm gbm; +#ifndef DRM_FORMAT_MOD_LINEAR +#define DRM_FORMAT_MOD_LINEAR 0 +#endif +static int

[Mesa-dev] [PATCH kmscube 6/6] common: Give cmdline parameter for forcing modifiers

--- common.c | 13 - common.h | 11 ++- kmscube.c | 14 +++--- 3 files changed, 29 insertions(+), 9 deletions(-) diff --git a/common.c b/common.c index e63bb39..eaaa9a4 100644 --- a/common.c +++ b/common.c @@ -31,9 +31,6 @@ static struct gbm gbm; -#ifndef

[Mesa-dev] [PATCH kmscube 3/6] common: include config.h

--- common.h | 4 1 file changed, 4 insertions(+) diff --git a/common.h b/common.h index 2eceac7..f3d9d32 100644 --- a/common.h +++ b/common.h @@ -32,6 +32,10 @@ #include #include +#ifdef HAVE_CONFIG_H + #include "config.h" +#endif + #ifndef EGL_KHR_platform_gbm #define

[Mesa-dev] [PATCH kmscube 1/6] drm: Provide a failure path when getting the fb

This is helpful for debugging as you will bail early with an error message instead of a random SIGSEGV (or something more obscure). --- drm-atomic.c | 9 + drm-legacy.c | 8 2 files changed, 17 insertions(+) diff --git a/drm-atomic.c b/drm-atomic.c index 27c6b1e..c06e52f 100644

Re: [Mesa-dev] [PATCH v2 2/4] egl, dri: Propagate context priority hint to driver->CreateContext

uint32_t flags, bool notify_reset, + unsigned priority, unsigned *error, void *sharedContextPrivate) { LGTM on i965 (i915) and dri bits. Acked-by: Ben Widawsky <b...@bwidawsk.net> -- Ben Widawsky, Intel Open S

Re: [Mesa-dev] [PATCH v2 1/4] egl: Support IMG_context_priority

ITY_LOW_IMG: + bit = __EGL_CONTEXT_PRIORITY_LOW_BIT; + break; +default: + bit = -1; + break; +} unreachable()? Either way: Reviewed-by: Ben Widawsky <b...@bwidawsk.net> + +if (bit <

[Mesa-dev] [PATCH] gbm: Assert modifiers and count are copacetic

Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/gbm/backends/dri/gbm_dri.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 8df6a6b64d..71590d7110 100644 --- a/src/gbm/backends/dri/gbm_dri.c +++ b/src/gbm/

Re: [Mesa-dev] [PATCH 1/2] egl: Support IMG_context_priority

On 17-04-06 20:12:35, Chris Wilson wrote: IMG_context_priority https://www.khronos.org/registry/egl/extensions/IMG/EGL_IMG_context_priority.txt "This extension allows an EGLContext to be created with a priority hint. It is possible that an implementation will not honour the hint,

Re: [Mesa-dev] [PATCH 26/34] i965: Pretend that CCS modified images are two planes

On 17-03-23 14:02:13, Daniel Stone wrote: Hi Ben, On 24 January 2017 at 06:21, Ben Widawsky <b...@bwidawsk.net> wrote: @@ -1018,9 +1018,18 @@ intel_from_planar(__DRIimage *parent, int plane, void *loaderPrivate) int width, height, offset, stride, dri_format, index;

[Mesa-dev] [PATCH 5/8] [v4] i965/dri: Handle the linear fb modifier

of identifying no modifiers found (because 0 is LINEAR) (Jason) v4: Remove the logic to prune unknown modifiers (like those from other vendors) and simply handle is in select_best_modifier (Jason) Requested-by: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Widawsky <b...@bwi

Re: [Mesa-dev] [PATCH] i965/dri: Handle the linear fb modifier

On 17-03-21 14:15:05, Jason Ekstrand wrote: On Tue, Mar 21, 2017 at 2:09 PM, Ben Widawsky <b...@bwidawsk.net> wrote: At image creation create a path for dealing with the linear modifier. This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR was specified. During devel

[Mesa-dev] [PATCH] i965/dri: Handle Y-tiled modifier

functionality was introduced and then reverted here: commit 6a0d036483caf87d43ebe2edd1905873446c9589 Author: Ben Widawsky <b...@bwidawsk.net> Date: Thu Apr 21 20:14:58 2016 -0700 i965: Always use Y-tiled buffers on SKL+ v2: Use last set bit instead of first set bit in modifiers to address bug

[Mesa-dev] [PATCH] i965/dri: Handle the linear fb modifier

of identifying no modifiers found (because 0 is LINEAR) (Jason) Requested-by: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> --- src/mesa/drivers/dri/i965/i

Re: [Mesa-dev] [PATCH 6/8] i965/dri: Handle Y-tiled modifier

On 17-03-21 13:52:12, Jason Ekstrand wrote: On Tue, Mar 21, 2017 at 1:45 PM, Ben Widawsky <b...@bwidawsk.net> wrote: This patch begins introducing how we'll actually handle the potentially many modifiers coming in from the API, how we'll store them, and the structure in the code to s

Re: [Mesa-dev] [PATCH 5/8] i965/dri: Handle the linear fb modifier

On 17-03-21 13:48:13, Jason Ekstrand wrote: On Tue, Mar 21, 2017 at 1:45 PM, Ben Widawsky <b...@bwidawsk.net> wrote: At image creation create a path for dealing with the linear modifier. This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR was specified. During devel

[Mesa-dev] [PATCH 6/8] i965/dri: Handle Y-tiled modifier

functionality was introduced and then reverted here: commit 6a0d036483caf87d43ebe2edd1905873446c9589 Author: Ben Widawsky <b...@bwidawsk.net> Date: Thu Apr 21 20:14:58 2016 -0700 i965: Always use Y-tiled buffers on SKL+ v2: Use last set bit instead of first set bit in modifiers to address bug

[Mesa-dev] [PATCH 7/8] i965/dri: Handle X-tiled modifier

øgsberg <k...@bitplanet.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> --- src/mesa/drivers/dri/i965/intel_screen.c | 9 + 1 file changed, 9 insertions(+) diff

[Mesa-dev] [PATCH 8/8] i965/dri: Turn on support for image modifiers

All the plumbing is in place so the extension just needs to be advertised. Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> --- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[Mesa-dev] [PATCH 5/8] i965/dri: Handle the linear fb modifier

ed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> --- src/mesa/drivers/dri/i965/intel_screen.c | 55 +--- 1 file changed, 44 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c

[Mesa-dev] [PATCH 4/8] i965/dri: Enable modifier queries

the surface (ie. stupid clients could be broken before this patch, but in more ways than this). Obviously, there are no modifiers being actually stored yet - so this patch shouldn't do anything other than allow the API to get back 0 (or the LINEAR modifier). Signed-off-by: Ben Widawsky &l

[Mesa-dev] [PATCH 3/8] i965/dri: Store the screen associated with the image

I intend to need to get to the devinfo structure, and storing the screen is an easy way to do that. It seems to be the consensus that you cannot share an image between multiple screens. Scape-goat: Rob Clark <robdcl...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Revie

[Mesa-dev] [PATCH 1/8] i965/dri: Disallow image with INVALID modifier

Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index af9c9a45f3..b77933e100 100644 --- a/src/mesa/drive

[Mesa-dev] [PATCH 2/8] gbm: Disallow INVALID modifiers returned upon image creation

Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/gbm/backends/dri/gbm_dri.c | 28 1 file changed, 28 insertions(+) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index a7ac149365..283a73454e 100644 --- a/src/gbm/backen

[Mesa-dev] [PATCH 0/8] [v2] i965 tiling modifiers

. As before, Y-tiled (as well as X, and linear) modifier can be used for DRI images at the end of this patch series in i965. Jason has reviewed most of this already, but since I added a few patches I thought it was necessary to resend the whole thing. Ben Widawsky (8): i965/dri: Disallow image

Re: [Mesa-dev] [PATCH 4/6] [v2] i965: Handle Y-tiled modifier

On 17-03-21 08:07:22, Jason Ekstrand wrote: On Tue, Mar 21, 2017 at 8:04 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: On Mon, Mar 20, 2017 at 8:35 PM, Ben Widawsky <b...@bwidawsk.net> wrote: This patch begins introducing how we'll actually handle the potentially many modi

[Mesa-dev] [PATCH 5/6] [v2] i965: Handle X-tiled modifier

tiled. Cc: Kristian Høgsberg <k...@bitplanet.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_scre

[Mesa-dev] [PATCH 4/6] [v2] i965: Handle Y-tiled modifier

was introduced and then reverted here: commit 6a0d036483caf87d43ebe2edd1905873446c9589 Author: Ben Widawsky <b...@bwidawsk.net> Date: Thu Apr 21 20:14:58 2016 -0700 i965: Always use Y-tiled buffers on SKL+ v2: Use last set bit instead of first set bit in modifiers to address bug

[Mesa-dev] [PATCH 3/6] [v2] i965: Handle the linear fb modifier

ed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/mesa/drivers/dri/i965/intel_screen.c | 50 +++- 1 file changed, 42 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 2455649032

[Mesa-dev] [PATCH 2/6] [v2] i965: Enable modifier queries

the surface (ie. stupid clients could be broken before this patch, but in more ways than this). Obviously, there are no modifiers being actually stored yet - so this patch shouldn't do anything other than allow the API to get back 0 (or the LINEAR modifier). Signed-off-by: Ben Widawsky &l

[Mesa-dev] [PATCH 2/6] [v2] i965: Enable modifier queries

the surface (ie. stupid clients could be broken before this patch, but in more ways than this). Obviously, there are no modifiers being actually stored yet - so this patch shouldn't do anything other than allow the API to get back 0 (or the LINEAR modifier). Signed-off-by: Ben Widawsky &l

Re: [Mesa-dev] [PATCH 6/5] i965: Turn on support for image modifiers

On 17-03-20 16:21:53, Jason Ekstrand wrote: On Mon, Mar 20, 2017 at 4:15 PM, Ben Widawsky <b...@bwidawsk.net> wrote: On 17-03-20 12:03:24, Jason Ekstrand wrote: My only question here is whether or not we want to add a "supported modifiers" query to DRIimage before we bump th

Re: [Mesa-dev] [PATCH 6/5] i965: Turn on support for image modifiers

nd me what the reasoning is for support modifiers? I thought we agreed to just use GET_PLANE2? Supported modifiers is difficult because mesa has no idea of per plane constraints. On Sat, Mar 18, 2017 at 1:00 PM, Ben Widawsky <b...@bwidawsk.net> wrote: All the plumbing is in place so the exte

Re: [Mesa-dev] [PATCH 4/5] i965: Handle Y-tiled modifier

On 17-03-20 15:36:37, Jason Ekstrand wrote: On Mon, Mar 20, 2017 at 3:25 PM, Ben Widawsky <b...@bwidawsk.net> wrote: On 17-03-20 12:00:44, Jason Ekstrand wrote: On Fri, Mar 17, 2017 at 5:34 PM, Ben Widawsky <b...@bwidawsk.net> wrote: This patch begins introducing how we'll act

Re: [Mesa-dev] [PATCH 4/5] i965: Handle Y-tiled modifier

On 17-03-20 12:00:44, Jason Ekstrand wrote: On Fri, Mar 17, 2017 at 5:34 PM, Ben Widawsky <b...@bwidawsk.net> wrote: This patch begins introducing how we'll actually handle the potentially many modifiers coming in from the API, how we'll store them, and the structure in the code to s

[Mesa-dev] [PATCH 6/5] i965: Turn on support for image modifiers

All the plumbing is in place so the extension just needs to be advertised. Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/d

[Mesa-dev] [PATCH 1/5] i965/dri: Store the screen associated with the image

I intend to need to get to the devinfo structure, and storing the screen is an easy way to do that. It seems to be the consensus that you cannot share an image between multiple screens. Scape-goat: Rob Clark <robdcl...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Revie

[Mesa-dev] [PATCH 5/5] i965: Handle X-tiled modifier

tiled. v2: priority lits was in reverse order. Cc: Kristian Høgsberg <k...@bitplanet.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 16 ++-- 1 file changed, 14 insertions(+)

[Mesa-dev] [PATCH 3/5] i965: Handle the linear fb modifier

. As a result, 0 was repurposed to mean a modifier for a LINEAR layout. NOTE: This patch was added for v3 of the patch series. References: https://patchwork.kernel.org/patch/9419157/ Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/mesa/drivers/dri/i965/intel_screen.

[Mesa-dev] [PATCH 4/5] i965: Handle Y-tiled modifier

Similar functionality was introduced and then reverted here: commit 6a0d036483caf87d43ebe2edd1905873446c9589 Author: Ben Widawsky <b...@bwidawsk.net> Date: Thu Apr 21 20:14:58 2016 -0700 i965: Always use Y-tiled buffers on SKL+ v2: Use last set bit instead of first set bit in mod

[Mesa-dev] [PATCH 0/5] i965 tiling modifiers

the modesetting driver, and Weston (and other GBM clients) to use Y tiled scanout buffers on gen9+. Ben Widawsky (5): i965/dri: Store the screen associated with the image i965: Enable modifier queries i965: Handle the linear fb modifier i965: Handle Y-tiled modifier i965: Handle X-tiled

[Mesa-dev] [PATCH 2/5] i965: Enable modifier queries

the surface (ie. stupid clients could be broken before this patch, but in more ways than this). Obviously, there are no modifiers being actually stored yet - so this patch shouldn't do anything other than allow the API to get back 0 (or the LINEAR modifier). Signed-off-by: Ben Widawsky &l

[Mesa-dev] [PATCH 3/6] [v6] gbm: Introduce modifiers into surface/bo creation

anet.net> References (v4): https://lists.freedesktop.org/archives/intel-gfx/2017-January/116636.html Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> (v1) Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> Acked-by: Daniel S

Re: [Mesa-dev] [PATCH 3/6] gbm: Introduce modifiers into surface/bo creation

On 17-03-14 08:53:45, Jason Ekstrand wrote: On Mon, Mar 13, 2017 at 10:24 PM, Ben Widawsky <b...@bwidawsk.net> wrote: The idea behind modifiers like this is that the user of GBM will have some mechanism to query what properties the hardware supports for its BO or surface. This infor

[Mesa-dev] [PATCH 4/6] egl/drm: Use modifiers for backbuffer creation

Split into a separate patch from the previous patch as requested by Emil. Requeted-by: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/egl/drivers/dri2/platform_drm.c | 19 +++ 1 file changed, 15 insertions(+),

[Mesa-dev] [PATCH 1/6] dri: Add an image creation with modifiers

elikov <emil.l.veli...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> (v1) Acked-by: Daniel Stone <dani...@collabora.com> --- include/GL/internal/dri_interface.h | 27 ++- 1 file changed

[Mesa-dev] [PATCH 2/6] i965: Implement basic modifier image creation

This is just a stub for now and will be filled in later. This was split out of an earlier patch Requested-by: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/mesa/drivers/dri/i965/intel_screen.c | 38

[Mesa-dev] [PATCH 3/6] gbm: Introduce modifiers into surface/bo creation

ts.freedesktop.org/archives/intel-gfx/2017-January/116636.html Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> (v1) Acked-by: Daniel Stone <dani...@collabora.com> --- src/gbm/backends/dri/gbm_dri.c | 62 +++

[Mesa-dev] [PATCH 6/6] gbm: Export a get modifiers

This patch originally had i965 specific code and was named: commit 61cd3c52b868cf8cb90b06e53a382a921eb42754 Author: Ben Widawsky <b...@bwidawsk.net> Date: Thu Oct 20 18:21:24 2016 -0700 gbm: Get modifiers from DRI To accomplish this, two new query tokens are added to the ext

[Mesa-dev] [PATCH 5/6] i965: introduce modifier selection.

Nothing special here other than a brief introduction to modifier selection. Originally this was part of another patch but was split out from gbm: Introduce modifiers into surface/bo creation by request of Emil. Requested-by: Emil Velikov <emil.veli...@collabora.com> Signed-off-by: Ben Widaw

Re: [Mesa-dev] [PATCH 2/3] gbm: Introduce modifiers into surface/bo creation

On 17-03-10 11:32:35, Emil Velikov wrote: On 10 March 2017 at 01:48, Ben Widawsky <b...@bwidawsk.net> wrote: The idea behind modifiers like this is that the user of GBM will have some mechanism to query what properties the hardware supports for its BO or surface. This information is di

Re: [Mesa-dev] [PATCH 2/3] gbm: Introduce modifiers into surface/bo creation

On 17-03-09 18:52:52, Jason Ekstrand wrote: On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky <b...@bwidawsk.net> wrote: The idea behind modifiers like this is that the user of GBM will have some mechanism to query what properties the hardware supports for its BO or surface. This infor

Re: [Mesa-dev] [PATCH 2/3] gbm: Introduce modifiers into surface/bo creation

On 17-03-10 11:34:19, Jason Ekstrand wrote: On Thu, Mar 9, 2017 at 6:52 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky <b...@bwidawsk.net> wrote: The idea behind modifiers like this is that the user of GBM will have some mechanism t

Re: [Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

On 17-03-10 10:28:42, Emil Velikov wrote: Hi Ben, Mostly pointing out a few things that look strange, pardon if some seem too pedantic. On 10 March 2017 at 01:48, Ben Widawsky <b...@bwidawsk.net> wrote: --- include/GL/internal/dri_interface.h | 27 ++-

Re: [Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

On 17-03-09 18:38:15, Jason Ekstrand wrote: On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky <b...@bwidawsk.net> wrote: Modifiers will be obtains or guessed by the client and passed in during "obtained" Got it. image creation/import. This requires bumping the

[Mesa-dev] [PATCH 2/3] gbm: Introduce modifiers into surface/bo creation

ts.freedesktop.org/archives/intel-gfx/2017-January/116636.html Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> (v1) Acked-by: Daniel Stone <dani...@collabora.com> --- src/egl/drivers/dri2/platform_drm.c | 19 ++

[Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

+ modifiers v3: Make NAND actually NAND. Bug introduced in v2. (Jason) Cc: Kristian Høgsberg <k...@bitplanet.net> Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> (v1) Acke

[Mesa-dev] [PATCH 0/3] GBM modifier plumbing

as well as exposing the new entry points. Ben Widawsky (3): dri: Add an image creation with modifiers gbm: Introduce modifiers into surface/bo creation gbm: Export a get modifiers include/GL/internal/dri_interface.h | 27 ++- src/egl/drivers/dri2/platform_drm.c | 19

[Mesa-dev] [PATCH 3/3] gbm: Export a get modifiers

This patch originally had i965 specific code and was named: commit 61cd3c52b868cf8cb90b06e53a382a921eb42754 Author: Ben Widawsky <b...@bwidawsk.net> Date: Thu Oct 20 18:21:24 2016 -0700 gbm: Get modifiers from DRI To accomplish this, two new query tokens are added to the ext

[Mesa-dev] [PATCH 0/3] GBM modifier plumbing

as well as exposing the new entry points. Ben Widawsky (3): dri: Add an image creation with modifiers gbm: Introduce modifiers into surface/bo creation gbm: Export a get modifiers include/GL/internal/dri_interface.h | 27 ++- src/egl/drivers/dri2/platform_drm.c | 19

[Mesa-dev] [PATCH 5/5] [v2] gbm: Export a per plane getter for offset

Jason's recommendation for handling the non-planar case. v4: Return int64_t so we can get real errors Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Acked-by: Daniel Stone <dani...@collabora.com> --- src/gbm/backends/

[Mesa-dev] [PATCH 4/5] gbm: Export a per plane getter for stride

n's recommended change) Make plane 0 return planar stride. This might break legacy behavior (Jason) v4: Move bogus hunk for get_handle_for_plane to the right patch (Jason) Fix error handling path to be cleaner (Jason) Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Wi

[Mesa-dev] [PATCH 2/5] [v2] gbm: Export a getter for per plane handles

== 0 (Jason) - Add a comment about new restriction on planar dumb bo which is not an earlier patch in the series. - Correctly refactor from v2 in this patch; it ended up rebased into the wrong patch. Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.n

Re: [Mesa-dev] [PATCH 4/5] gbm: Export a per plane getter for stride

On 17-03-07 08:33:32, Jason Ekstrand wrote: On Mon, Mar 6, 2017 at 6:37 PM, Ben Widawsky <b...@bwidawsk.net> wrote: v2: Preserve legacy behavior when plane is 0 (Jason Ekstrand) EINVAL when input plane is greater than total planes (Jason Ekstrand) Don't leak the image after fromPlanar (

[Mesa-dev] [PATCH] [v2] gbm: Explicitly disallow a planar dumb BO

<ja...@jlekstrand.net> Cc: Daniel Stone <dani...@collabora.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/gbm/backends/dri/gbm_dri.c | 31 +++ 1 file changed, 31 insertions(+) diff

[Mesa-dev] [PATCH] gbm: Explicitly disallow a planar dumb BO

net> Cc: Daniel Stone <dani...@collabora.com> Cc: Kristian H. Kristensen <hoegsb...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> --- src/gbm/backends/dri/gbm_dri.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/gbm/backends

Re: [Mesa-dev] [PATCH 2/5] gbm: Export a getter for per plane handles

On 17-03-07 08:28:09, Jason Ekstrand wrote: On Mon, Mar 6, 2017 at 6:37 PM, Ben Widawsky <b...@bwidawsk.net> wrote: v2: Make the error return be -1 instead of 0 because I think 0 is actually valid. v3: Set errno to EINVAL when the specified plane is above the total planes. (Jason Ek

[Mesa-dev] [PATCH 3/5] gbm: Create a gbm_device getter for stride

This will be used so we can query information per plane. Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Acked-by: Daniel Stone <dani...@collabora.com> --- src/gbm/backends/dri/gbm_dri.c | 7 +++ src/gbm/main/gbm

[Mesa-dev] [PATCH 1/5] gbm: Export a plane getter function

, ie. dumb bo (Daniel) Cc: Daniel Stone <dani...@collabora.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Acked-by: Daniel Stone <dani...@collabora.com> --- src/gbm/backends/dri/gbm_dri.c | 27 ++

[Mesa-dev] [PATCH 4/5] gbm: Export a per plane getter for stride

n's recommended change) Make plane 0 return planar stride. This might break legacy behavior (Jason) Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> (v1) Acked-by: Daniel Stone &

[Mesa-dev] [PATCH 5/5] gbm: Export a per plane getter for offset

Jason's recommendation for handling the non-planar case. Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Acked-by: Daniel Stone <dani...@collabora.com> --- src/gbm/backends/dri/gbm_dri.c | 33 + s

[Mesa-dev] [PATCH 2/5] gbm: Export a getter for per plane handles

v2: Make the error return be -1 instead of 0 because I think 0 is actually valid. v3: Set errno to EINVAL when the specified plane is above the total planes. (Jason Ekstrand) Return the bo's handle if there is no image ie. for dumb images like cursor (Daniel) Signed-off-by: Ben Widawsky &l

[Mesa-dev] [PATCH 0/5] Per plane GBM functions

e <dan...@fooishbar.org> Cc: Eric Engestrom <e...@engestrom.ch> Cc: Jason Ekstrand <ja...@jlekstrand.net> Ben Widawsky (5): gbm: Export a plane getter function gbm: Export a getter for per plane handles gbm: Create a gbm_device getter for stride gbm: Export a per plane

Re: [Mesa-dev] [PATCH 27/34] i965: Make CCS stride match kernel's expectations

On 17-02-28 11:44:24, Jason Ekstrand wrote: On Mon, Feb 27, 2017 at 7:23 PM, Ben Widawsky <b...@bwidawsk.net> wrote: On 17-02-27 18:40:41, Jason Ekstrand wrote: On Mon, Feb 27, 2017 at 5:38 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: On Mon, Feb 27, 2017 at 4:56 PM, Ben

  1   2   3   4   5   6   7   8   9   10   >