[Mesa-dev] [PATCH 2/2] svga: add new num-failed-allocations HUD query

This counter is incremented if we fail to allocate memory for vertex/index/const buffers, textures, etc. --- src/gallium/drivers/svga/svga_context.h| 1 + src/gallium/drivers/svga/svga_pipe_query.c | 7 +++ src/gallium/drivers/svga/svga_resource.c | 17 +++--

[Mesa-dev] [PATCH 1/2] gallium/hud: support GALLIUM_HUD_DUMP_DIR feature on Windows

Use a dummy implementation of the access() function. Use \ path separator. Add a few comments. --- src/gallium/auxiliary/hud/hud_context.c | 36 +++-- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c

[Mesa-dev] [PATCH] svga: add some missing SVGA_STATS_* enum values, prefix strings

To fix the build when VMX86_STATS is defined. Also, some minor whitespace changes to match upstream code. --- src/gallium/drivers/svga/svga_winsys.h | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/svga/svga_winsys.h

[Mesa-dev] [PATCH] gallium/docs: improve docs for SAMPLE_POS, SAMPLE_INFO, TXQS, MSAA semantics

For the SAMPLE_POS and SAMPLE_INFO opcodes, clarify resource vs. render target queries, range of postion values, swizzling, etc. We basically follow the DX10.1 conventions. For the TXQS opcode and TGSI_SEMANTIC_SAMPLEID, clarify return value and type. For the TGSI_SEMANTIC_SAMPLEPOS system

[Mesa-dev] [PATCH 2/2] draw: check for line_width != 1.0f in validate_pipeline()

We shouldn't use the wide line stage if the line width is 1. This check isn't strictly needed because all drivers are (now) specifying a line wide threshold of at least 1.0 pixels, but let's play it safe. --- src/gallium/auxiliary/draw/draw_pipe_validate.c | 7 --- 1 file changed, 4

[Mesa-dev] [PATCH 1/2] svga: clamp device line width to at least 1 to fix HWv8 line stippling

The line stipple fallback code for virtual HW version 8 didn't work. With HW version 8, we were getting zero when querying the max line widths (AA and non-AA). This means we were setting the draw module's wide line threshold to zero. This caused the wide line stage to always get enabled. That

Re: [Mesa-dev] [PATCH] automake: increase the MESA_GIT_SHA1 hash id length from 7 to 10 digits

On 06/15/2017 08:14 AM, Eric Engestrom wrote: On Thursday, 2017-06-15 08:06:54 -0600, Brian Paul wrote: The SCons build has been using 10 digits of the git hash id for the MESA_GIT_SHA1 string in git_sha1.h for about a year now. I bumped it up after running into a case where a 7-digit hash ID

[Mesa-dev] [PATCH] automake: increase the MESA_GIT_SHA1 hash id length from 7 to 10 digits

The SCons build has been using 10 digits of the git hash id for the MESA_GIT_SHA1 string in git_sha1.h for about a year now. I bumped it up after running into a case where a 7-digit hash ID was ambiguous. This patch makes the same change for the autotools build. The command "git log | grep

Re: [Mesa-dev] [PATCH] automake: increase the MESA_GIT_SHA1 hash id length from 7 to 10 digits

On 06/15/2017 07:10 AM, Emil Velikov wrote: On 15 June 2017 at 13:54, Brian Paul <bri...@vmware.com> wrote: On 06/15/2017 03:38 AM, Emil Velikov wrote: On 15 June 2017 at 10:12, Eric Engestrom <eric.engest...@imgtec.com> wrote: On Thursday, 2017-06-15 09:56:55 +0100, Emil V

Re: [Mesa-dev] [PATCH] automake: increase the MESA_GIT_SHA1 hash id length from 7 to 10 digits

On 06/15/2017 03:38 AM, Emil Velikov wrote: On 15 June 2017 at 10:12, Eric Engestrom <eric.engest...@imgtec.com> wrote: On Thursday, 2017-06-15 09:56:55 +0100, Emil Velikov wrote: Hi Brian, On 15 June 2017 at 04:46, Brian Paul <bri...@vmware.com> wrote: The SCons build has b

[Mesa-dev] [PATCH] automake: increase the MESA_GIT_SHA1 hash id length from 7 to 10 digits

The SCons build has been using 10 digits of the git hash id for the MESA_GIT_SHA1 string in git_sha1.h for about a year now. I bumped it up after running into a case where a 7-digit hash ID was ambiguous. This patch makes the same change for the autotools build. The command "git log | grep

Re: [Mesa-dev] [PATCH 1/7] gallium: add pipe_blend_state::srgb_enable and the CAP

On 06/14/2017 02:38 PM, Jose Fonseca wrote: On 14/06/17 21:21, Marek Olšák wrote: On Wed, Jun 14, 2017 at 10:13 PM, Jose Fonseca wrote: On 14/06/17 21:07, Marek Olšák wrote: On Wed, Jun 14, 2017 at 9:45 PM, Jose Fonseca wrote: On 14/06/17 17:12,

Re: [Mesa-dev] [PATCH 1/2] gallium/docs: improve docs for SAMPLE_POS, SAMPLE_INFO, TXQS, MSAA semantics

On 06/12/2017 05:33 PM, Roland Scheidegger wrote: Am 12.06.2017 um 21:19 schrieb Brian Paul: On 06/12/2017 11:50 AM, Nicolai Hähnle wrote: On 12.06.2017 19:37, Brian Paul wrote: For the SAMPLE_POS and SAMPLE_INFO opcodes, clarify resource vs. render target queries, range of postion values

Re: [Mesa-dev] [PATCH 02/31] mesa: stop using _NEW_STENCIL with st/mesa, use DriverFlags.NewStencil instead

n inline function: _mesa_state_change(). I did a quick review of the series and it generally looks good to me. Reviewed-by: Brian Paul <bri...@vmware.com> -Brian ctx->Stencil.Enabled = state; break; case GL_TEXTURE_1D: if (ctx->API != API_OPENGL_C

[Mesa-dev] [PATCH 1/2] gallium/docs: improve docs for SAMPLE_POS, SAMPLE_INFO, TXQS, MSAA semantics

For the SAMPLE_POS and SAMPLE_INFO opcodes, clarify resource vs. render target queries, range of postion values, swizzling, etc. We basically follow the DX10.1 conventions. For the TXQS opcode and TGSI_SEMANTIC_SAMPLEID, clarify return value and type. For the TGSI_SEMANTIC_SAMPLEPOS system

[Mesa-dev] [PATCH 2/2] gallium/docs: clarify TGSI_SEMANTIC_SAMPLEMASK, again

I've since discovered the fragment shader sample mask system value (which corresponds to gl_SampleMaskIn). v2: It's a system value, not a shader input. --- src/gallium/docs/source/tgsi.rst | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] gallium/docs: improve docs for SAMPLE_POS, SAMPLE_INFO, TXQS, MSAA semantics

PM, Brian Paul <bri...@vmware.com> wrote: Or say they're undefined: sample pos = (x, y, undef, undef), for example. I'd be OK with that. You? -Brian On 06/12/2017 11:47 AM, Ilia Mirkin wrote: Perhaps this is wrong in the grand scheme of things, but at least nouveau will *only* set the d

Re: [Mesa-dev] [PATCH 1/2] gallium/docs: improve docs for SAMPLE_POS, SAMPLE_INFO, TXQS, MSAA semantics

ones. Perhaps we should zero those out? On Mon, Jun 12, 2017 at 1:37 PM, Brian Paul <bri...@vmware.com> wrote: For the SAMPLE_POS and SAMPLE_INFO opcodes, clarify resource vs. render target queries, range of postion values, swizzling, etc. We basically follow the DX10.1 conventions. For th

Re: [Mesa-dev] [PATCH 1/2] gallium/docs: improve docs for SAMPLE_POS, SAMPLE_INFO, TXQS, MSAA semantics

On 06/12/2017 11:50 AM, Nicolai Hähnle wrote: On 12.06.2017 19:37, Brian Paul wrote: For the SAMPLE_POS and SAMPLE_INFO opcodes, clarify resource vs. render target queries, range of postion values, swizzling, etc. We basically follow the DX10.1 conventions. For the TXQS opcode

Re: [Mesa-dev] [PATCH 2/2] gallium/docs: clarify TGSI_SEMANTIC_SAMPLEMASK, again

Oops, yes, I misread the code. I'll fix that. Thanks. -Brian On 06/12/2017 11:49 AM, Ilia Mirkin wrote: It's actually a sysval, not an input. On Mon, Jun 12, 2017 at 1:37 PM, Brian Paul <bri...@vmware.com> wrote: I've since discovered the fragment shader sample mask input

Re: [Mesa-dev] [PATCH 2/2] gallium/docs: clarify TGSI_SEMANTIC_SAMPLEMASK, again

On 06/12/2017 11:49 AM, Nicolai Hähnle wrote: On 12.06.2017 19:37, Brian Paul wrote: I've since discovered the fragment shader sample mask input (which corresponds to gl_SampleMaskIn). --- src/gallium/docs/source/tgsi.rst | 15 +++ 1 file changed, 11 insertions(+), 4 deletions

[Mesa-dev] TGSI MSAA docs

Regarding my two patches to the TGSI docs, please let me know if there's anything that doesn't jive with current drivers and their interpretations of these items (like default values, sample positions, etc.). -Brian ___ mesa-dev mailing list

[Mesa-dev] [PATCH 1/2] gallium/docs: improve docs for SAMPLE_POS, SAMPLE_INFO, TXQS, MSAA semantics

For the SAMPLE_POS and SAMPLE_INFO opcodes, clarify resource vs. render target queries, range of postion values, swizzling, etc. We basically follow the DX10.1 conventions. For the TXQS opcode and TGSI_SEMANTIC_SAMPLEID, clarify return value and type. For the TGSI_SEMANTIC_SAMPLEPOS system

[Mesa-dev] [PATCH 2/2] gallium/docs: clarify TGSI_SEMANTIC_SAMPLEMASK, again

I've since discovered the fragment shader sample mask input (which corresponds to gl_SampleMaskIn). --- src/gallium/docs/source/tgsi.rst | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index

Re: [Mesa-dev] [PATCH v3 0/3] Fix missing initializer errors in generated tables

Benedikt, We normally prefix the first line of the git commit message with a prefix to indicate the module effected. So in this case, you might use "amd: Fix missing..." or "r600: Fix missing". You can use git log to get an idea. -Brian On 06/11/2017 11:17 AM, Benedikt Schemmer wrote:

[Mesa-dev] [PATCH] st/mesa: unmap the stream_uploader buffer before drawing

Some drivers require that the vertex buffers be unmapped prior to drawing. This change unmaps the stream_uploader buffer after we've uploaded the zero-stride attributes (unless the driver supports rendering with mapped buffers). This fixes a regression in the VMware driver since

[Mesa-dev] [PATCH] gallium/util: whitespace, formatting fixes in u_upload_mgr.c

--- src/gallium/auxiliary/util/u_upload_mgr.c | 54 +-- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c b/src/gallium/auxiliary/util/u_upload_mgr.c index 9528495..4bb14d6 100644 ---

Re: [Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter

0 for idiv but all-ones for idiv64 and so on, it's not really consistent... Roland Am 08.06.2017 um 21:51 schrieb Brian Paul: Marius, As long as you're working on this, would you review src/gallium/docs/source/tgsi.rst to check if all the div/mod instructions document div/mod by zero behavio

[Mesa-dev] [PATCH] tgsi: clarify TGSI_SEMANTIC_SAMPLEMASK documentation

--- src/gallium/docs/source/tgsi.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index eceaa6d..7fb963f 100644 --- a/src/gallium/docs/source/tgsi.rst +++ b/src/gallium/docs/source/tgsi.rst @@ -3298,8

Re: [Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter

Marius, As long as you're working on this, would you review src/gallium/docs/source/tgsi.rst to check if all the div/mod instructions document div/mod by zero behavior? Thanks. -Brian On 06/08/2017 11:10 AM, Roland Scheidegger wrote: I don't really know if it makes sense to have

Re: [Mesa-dev] [PATCH V2 4/8] mesa: stop passing state bitfield to UpdateState()

Reviewed-by: Brian Paul <bri...@vmware.com> On 06/07/2017 05:39 PM, Timothy Arceri wrote: The code comment which seems to have been added in cab974cf6c2db (from year 2000) says: "Set ctx->NewState to zero to avoid recursion if Driver.UpdateState() has to call FLUSH_VERTI

Re: [Mesa-dev] [PATCH 1/2] mesa: add DECL_GLAPIENTRY macro

On Wed, Jun 7, 2017 at 7:29 AM, Samuel Pitoiset wrote: > To declare both errors and no errors GL prototypes. > > Signed-off-by: Samuel Pitoiset > --- > src/mesa/main/glheader.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 6/8] mesa: inline vbo_exec_invalidate_state() and call from mesa core

For 6-8, Reviewed-by: Brian Paul <bri...@vmware.com> On 06/07/2017 12:02 AM, Timothy Arceri wrote: Rather than calling it indirectly in each driver. --- src/mesa/drivers/dri/i915/i915_context.c | 1 - src/mesa/drivers/dri/i915/intel_context.c| 1 - src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH 3/8] st/mesa: add st_invalidate_buffers() helper

It would be great if you could put a comment on the new function explaining what it's doing. Many readers would not know why invalidating framebuffer state requires invalidating all that other state. Thanks. -Brian On 06/07/2017 12:02 AM, Timothy Arceri wrote: ---

Re: [Mesa-dev] [PATCH 2/8] osmesa: remove useless osmesa_update_state() call

On 06/07/2017 12:01 AM, Timothy Arceri wrote: As far as I can tell this shouldn't do anything as we were just passing a state of 0. --- src/mesa/drivers/osmesa/osmesa.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c

Re: [Mesa-dev] [PATCH 5/8] mesa: rework vbo_exec_init()

On 06/07/2017 12:02 AM, Timothy Arceri wrote: Here we make some assumptions about the AEcontext and set the recalculate bools directly. Some formating fixes are also made while we are here. --- src/mesa/main/api_arrayelt.c | 6 ++ src/mesa/main/api_arrayelt.h | 1 +

[Mesa-dev] [PATCH] gallium/u_threaded: fixes for MSVC

Replace some static assertions with runtime assertions. The static asserts don't work/fail on MSVC, despite the offsets being multiples of 16 (checked with softpipe). Use correct parameter types for a few gallium context functions. --- src/gallium/auxiliary/util/u_threaded_context.c | 16

Re: [Mesa-dev] [PATCH 1/3] mesa: only emit _NEW_MULTISAMPLE when coverage parameters change

On 06/05/2017 09:26 AM, Samuel Pitoiset wrote: On 06/02/2017 09:11 PM, Brian Paul wrote: On 06/02/2017 09:52 AM, Samuel Pitoiset wrote: We usually check that given parameters are different before updating the state. Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- sr

Re: [Mesa-dev] [PATCH] tgsi/scan: fix scanning fragment shaders with PrimID and Position/Face

nfo->num_system_values = MAX2(info->num_system_values, index + 1); switch (semName) { Reviewed-by: Brian Paul <bri...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] mesa: only emit _NEW_MULTISAMPLE when coverage parameters change

On 06/02/2017 09:52 AM, Samuel Pitoiset wrote: We usually check that given parameters are different before updating the state. Signed-off-by: Samuel Pitoiset --- src/mesa/main/multisample.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

Re: [Mesa-dev] [PATCH] automake: Link all libGL.so variants with -Bsymbolic.

$(GL_MAJOR):$(GL_MINOR):$(GL_PATCH) \ + $(BSYMBOLIC) \ $(GC_SECTIONS) \ $(LD_NO_UNDEFINED) LGTM. Reviewed-by: Brian Paul <bri...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/m

Re: [Mesa-dev] [PATCH] llvmpipe: add LP_NEW_GS flag for updating vertex info

EW_RASTERIZER | LP_NEW_FS | + LP_NEW_GS | LP_NEW_VS)) compute_vertex_info(llvmpipe); Makes sense. Reviewed-by: Brian Paul <bri...@vmware.com> ___ mesa-de

Re: [Mesa-dev] Proposal to branch off old drivers

On 05/25/2017 06:45 PM, Timothy Arceri wrote: Hi all, Following on from the discussion here:

Re: [Mesa-dev] [Patch v2] osmesa: link with libunwind if enabled (v2)

viewed-by: Brian Paul <bri...@vmware.com> Do you need me to push this for you? -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/7] Revert "gallium: remove unused PIPE_CC_GCC_VERSION"

This reverts commit e60928f4c4bd4484821d83f2b16a910ea9f5f9d9. PIPE_CC_GCC_VERSION is used by some of our in-house code which hasn't been upstreamed yet. --- src/gallium/include/pipe/p_config.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_config.h

[Mesa-dev] [PATCH 7/7] svga: move logging initialization code into new function

Plus a few other minor clean-ups. Reviewed-by: Sinclair Yeh --- src/gallium/drivers/svga/svga_screen.c | 53 -- src/gallium/drivers/svga/svga_screen.h | 2 -- 2 files changed, 31 insertions(+), 24 deletions(-) diff --git

[Mesa-dev] [PATCH 5/7] svga: log the process command line to the vmware.log file

This is useful for Piglit when thousands of tests are run and we want to determine which test triggered a device error. v2: only log command line info if the new SVGA_EXTRA_LOGGING env var is set Reviewed-by: Charmaine Lee --- docs/envvars.html | 2

[Mesa-dev] [PATCH 6/7] svga: init local vars to silence uninitialized use warnings

Reviewed-by: Sinclair Yeh --- src/gallium/drivers/svga/svga_msg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/svga/svga_msg.c b/src/gallium/drivers/svga/svga_msg.c index e3f72b6..e0346de 100755 ---

[Mesa-dev] [PATCH 4/7] svga: Limit svga message capability to newer compilers

mware.com> Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/drivers/svga/svga_msg.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/svga/svga_msg.c b/src/gallium/drivers/svga/svga_msg.c index 3bbe89f..e3f72b6 100755 --

[Mesa-dev] [PATCH 2/7] svga: Add the ability to log messages to vmware.log on the host.

From: Sinclair Yeh <s...@vmware.com> For now this capability only exists in the SVGA driver but can be exported later if other modules, e.g. winsys, wants to use it for logging. Reviewed-by: Brian Paul <bri...@vmware.com> --- src/gallium/drivers/svga/Makefile.sources | 2 +

[Mesa-dev] [PATCH 3/7] svga: Fix MSVC build.

This let us compile the code with MSVC, but it no-ops the log function. Reviewed-by: Jose Fonseca --- src/gallium/drivers/svga/svga_msg.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) mode change 100644 => 100755

Re: [Mesa-dev] [PATCH] Revert "gallium: remove unused PIPE_CC_GCC_VERSION"

. -Brian On 23/05/17 02:31, Brian Paul wrote: This reverts commit e60928f4c4bd4484821d83f2b16a910ea9f5f9d9. PIPE_CC_GCC_VERSION is used by some of our in-house code which hasn't been upstreamed yet. --- src/gallium/include/pipe/p_config.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src

Re: [Mesa-dev] [RFC] ARB_gl_spirv and NIR backend for radeonsi

On 05/22/2017 07:15 PM, Timothy Arceri wrote: On 23/05/17 10:44, Marek Olšák wrote: On Tue, May 23, 2017 at 12:07 AM, Timothy Arceri wrote: On 23/05/17 05:02, Marek Olšák wrote: On Sun, May 21, 2017 at 12:48 PM, Nicolai Hähnle wrote: Hi all,

Re: [Mesa-dev] How does FakeGLX work since Mesa 10?

On 05/09/2017 12:07 PM, Tom Hudson wrote: I'm trying to upgrade a Mesa 10 installation to Mesa 17. There have been plenty of changes, but only one breakage that's left me perplexed. https://cgit.freedesktop.org/mesa/mesa/commit/?id=c00b250c8061d042d9905e61b9077462ee91008b In this CL, Mesa

[Mesa-dev] [PATCH] Revert "gallium: remove unused PIPE_CC_GCC_VERSION"

This reverts commit e60928f4c4bd4484821d83f2b16a910ea9f5f9d9. PIPE_CC_GCC_VERSION is used by some of our in-house code which hasn't been upstreamed yet. --- src/gallium/include/pipe/p_config.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_config.h

Re: [Mesa-dev] [PATCH v13 13/36] st/dri: support format queries

On 05/19/2017 08:48 AM, Lucas Stach wrote: Am Freitag, den 19.05.2017, 10:37 +0100 schrieb Daniel Stone: From: Varad Gautam ask the driver for supported dmabuf formats v2: rebase to master. v3: return false on failure. v4: use pscreen->is_format_supported instead

[Mesa-dev] [PATCH] glsl: Fix g++ initializer order warning

Fixes this warning: In file included from ../../../src/compiler/glsl/ir.cpp:25:0: ../../../src/compiler/glsl/ir.h: In constructor 'ir_swizzle::ir_swizzle(ir_rvalue*, ir_swizzle_mask)': ../../../src/compiler/glsl/ir.h:1955:20: warning: 'ir_swizzle::mask' will be initialized after [-Wreorder]

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

On 05/03/2017 10:37 PM, Brian Paul wrote: On 05/01/2017 10:03 AM, Brian Paul wrote: On 05/01/2017 08:32 AM, Brian Paul wrote: On 04/28/2017 05:12 PM, Marek Olšák wrote: Hi, This series shrinks various gallium structures and removes set_index_buffer in order to decrease CPU overhead. PART 1

Re: [Mesa-dev] [PATCH 12/18] mesa: remove unused _mesa_total_buffer_object_memory()

On 05/04/2017 01:41 AM, Timothy Arceri wrote: --- src/mesa/main/bufferobj.c | 31 --- src/mesa/main/bufferobj.h | 3 --- 2 files changed, 34 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 6161271..2944dce 100644 ---

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

On 05/01/2017 10:03 AM, Brian Paul wrote: On 05/01/2017 08:32 AM, Brian Paul wrote: On 04/28/2017 05:12 PM, Marek Olšák wrote: Hi, This series shrinks various gallium structures and removes set_index_buffer in order to decrease CPU overhead. PART 1: Performance results All testing below

[Mesa-dev] [PATCH 1/2] wglinfo: query format bitmap, pbuffer GDI rendering ability

Only reported with -v option for now. --- src/wgl/wglinfo.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/wgl/wglinfo.c b/src/wgl/wglinfo.c index f81978b..faccbb1 100644 --- a/src/wgl/wglinfo.c +++ b/src/wgl/wglinfo.c @@ -44,6 +44,7 @@ static

[Mesa-dev] [PATCH 2/2] wglgears: fix up wglChoosePixelFormatARB() attribute list

Specify WGL_DRAW_TO_WINDOW_ARB and WGL_COLOR_BITS_ARB. Improve some comments, per Charmaine. --- src/wgl/wglgears.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/wgl/wglgears.c b/src/wgl/wglgears.c index 7d43822..d673143 100644 --- a/src/wgl/wglgears.c +++

Re: [Mesa-dev] [PATCH v2 5/7] docs/releasing: added relevant people for build/check with Windows

On 05/03/2017 12:14 PM, Andres Gomez wrote: v2: Brian Paul as main contact point and Jose Fonseca as fallback (Vinson, Jose) Signed-off-by: Andres Gomez <ago...@igalia.com> Cc: Emil Velikov <emil.veli...@collabora.com> Cc: Vinson Lee <v...@freedesktop.org> Cc: Brian Paul

Re: [Mesa-dev] [PATCH 1/2] draw: fix max_index initializer in draw_pipeline_run()

On 05/02/2017 01:26 PM, Grazvydas Ignotas wrote: On Tue, May 2, 2017 at 10:21 PM, Brian Paul <bri...@vmware.com <mailto:bri...@vmware.com>> wrote: Note, this is just some debug code. --- src/gallium/auxiliary/draw/draw_pipe.c | 2 +- 1 file changed, 1 ins

[Mesa-dev] [PATCH 2/2] mesa: add const qualifier on _mesa_valid_to_render()

--- src/mesa/main/api_validate.c | 2 +- src/mesa/main/api_validate.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index bddde29..4694c36 100644 --- a/src/mesa/main/api_validate.c +++

[Mesa-dev] [PATCH 1/2] draw: fix max_index initializer in draw_pipeline_run()

Note, this is just some debug code. --- src/gallium/auxiliary/draw/draw_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_pipe.c b/src/gallium/auxiliary/draw/draw_pipe.c index 27a3762..3581698 100644 ---

Re: [Mesa-dev] [PATCH 08/17] st/mesa: simplify code due to unification to st_common_program

On 05/02/2017 10:46 AM, Marek Olšák wrote: switch (shader->Stage) { case MESA_SHADER_VERTEX: stvp = (struct st_vertex_program *)prog; stvp->glsl_to_tgsi = v; break; case MESA_SHADER_FRAGMENT: stfp = (struct st_fragment_program *)prog;

Re: [Mesa-dev] [PATCH v2] mesa/vbo: reduce prim array size

On 05/02/2017 05:19 AM, Bartosz Tomczyk wrote: We always use only single element. v2: Change signle element arrays to variables "single" Looks good. Reviewed-by: Brian Paul <bri...@vmware.com> --- src/mesa/vbo/vbo_exec_array.c | 74 +---

Re: [Mesa-dev] [PATCH 08/17] st/mesa: simplify code due to unification to st_common_program

break; } case MESA_SHADER_FRAGMENT: { struct st_fragment_program *stfp = (struct st_fragment_program *) prog; sha1 = stfp->sha1; write_tgsi_to_cache(blob, >tgsi, st, sha1, num_tokens); Other than those nits, the series LGTM. Reviewed-by: Brian Paul <bri...@vmware.com> -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 06/17] st/mesa: unify TCS, TES, GS st_*_program structures

On 05/01/2017 06:52 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_atom.c | 12 ++--- src/mesa/state_tracker/st_atom_constbuf.c | 6 +-- src/mesa/state_tracker/st_atom_shader.c| 24 -

Re: [Mesa-dev] [PATCH 07/17] st/mesa: simplify update_constants functions

On 05/01/2017 06:52 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_atom_constbuf.c | 45 +-- src/mesa/state_tracker/st_atom_constbuf.h | 4 +-- src/mesa/state_tracker/st_cb_bitmap.c | 2 +-

Re: [Mesa-dev] [PATCH 02/17] st/mesa: decrease the size of st_vertex_program

On 05/01/2017 06:52 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 8 src/mesa/state_tracker/st_atifs_to_tgsi.h | 4 ++-- src/mesa/state_tracker/st_cb_rasterpos.c | 4 ++-- src/mesa/state_tracker/st_context.h

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

On 05/01/2017 08:32 AM, Brian Paul wrote: On 04/28/2017 05:12 PM, Marek Olšák wrote: Hi, This series shrinks various gallium structures and removes set_index_buffer in order to decrease CPU overhead. PART 1: Performance results All testing below was done with radeonsi, and I used

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

On 04/28/2017 05:12 PM, Marek Olšák wrote: Hi, This series shrinks various gallium structures and removes set_index_buffer in order to decrease CPU overhead. PART 1: Performance results All testing below was done with radeonsi, and I used the drawoverhead microbenchmark from mesa/demos

[Mesa-dev] [PATCH] glx: add missing sRGB attribute check in fbconfigs_compatible()

From: Neha Bhende <bhen...@vmware.com> This patch will allow driver to choose srgb capable FBconfig if GLX_FRAMEBUFFER_SRGB_CAPABLE_ARB attribute is 1 Reviewed-by: Brian Paul <bri...@vmware.com> Reviewed-by: Charmaine Lee <charmai...@vmware.com> --- src/glx/glxcmds.c | 1 +

[Mesa-dev] [PATCH] st/mesa: add more fallback gallium formats for GL integer formats

The VMware driver has a limited set of integer texture formats. We often have to fall back to 4-component formats when 1- or 2-component formats are missing. This fixes about 8 integer texture Piglit tests with the VMware driver on Linux. We've had this code in-house for a long time but I guess

[Mesa-dev] [PATCH] mesa: optimize color_buffer_writes_enabled()

Return as soon as we find an existing color channel that's enabled for writing. Typically, this allows us to return true on the first loop iteration intead of doing four iterations. No piglit regressions. --- src/mesa/main/clear.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

[Mesa-dev] [PATCH 1/2] wglgears.c: add -srgb option

To test sRGB pixel format selection and sRGB rendering. This involves choosing a new pixel format, creating a new context, etc. --- src/wgl/wglgears.c | 91 -- 1 file changed, 88 insertions(+), 3 deletions(-) diff --git a/src/wgl/wglgears.c

[Mesa-dev] [PATCH 2/2] wglinfo: query/print sRGB and float pixel format info

Print the columns in the same place as glxinfo. Use 3 digit hexadecimal field for printing pixel format number. Remove the 'caveat' field which is non-existant in WGL. This also fixes a minor bug when we query WGL_PIXEL_TYPE_ARB. We previously stored the result in info->pfd.iPixelType which is a

[Mesa-dev] [PATCH] st/mesa: minor clean-ups in st_update_renderbuffer_surface()

Remove unneeded parens. Add const qualifiers. Move var decls closer to where they're used. --- src/mesa/state_tracker/st_cb_fbo.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index

Re: [Mesa-dev] [RFC PATCH 3/4] ff_fragment_shader: mark impossible switch values with unreachable

On 04/22/2017 03:46 PM, Giuseppe Bilotta wrote: On Sat, Apr 22, 2017 at 11:45 AM, Nicolai Hähnle wrote: @@ -495,8 +492,8 @@ static GLboolean args_match( const struct state_key *key, GLuint unit ) return GL_FALSE; } break; - default: -

Re: [Mesa-dev] Anti-aliasing problem using OSMesa

On 04/21/2017 12:25 AM, green we wrote: I tried to use OSMesa to do offscreen rendering, refer to the osdemo and the tutorial here: http://www.alecjacobson.com/weblog/?p=2827 There are obvious serrations on the edge of the model. I have tried these solution but all failed, can any one gieve me

Re: [Mesa-dev] [PATCH] RFC: mesa: remove MESA_VERBOSE env variable

On 04/21/2017 05:02 AM, Emil Velikov wrote: On 21 April 2017 at 07:18, Jordan Justen wrote: On 2017-04-20 18:49:57, Timothy Arceri wrote: On 21/04/17 11:37, Jordan Justen wrote: On 2017-04-20 12:33:45, Samuel Pitoiset wrote: I have used it sometimes, but since

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

On 04/19/2017 05:23 AM, Emil Velikov wrote: On 11 April 2017 at 13:10, Jean Hertel wrote: Any more thoughts on this? I would really appreciate feedback from more contributors. Indeed. Brian, Eric, others - how do you feel with the Sphinx edition of the site? If

Re: [Mesa-dev] [PATCH] RFC: mesa: remove MESA_VERBOSE env variable

text.h _mesa_GetGraphicsResetStatusARB in src/mesa/main/robustness.c _mesa_print_state() in src/mesa/main/state.c _mesa_notifySwapBuffers() in src/mesa/main/context.c Do we want to keep any of the MESA_VERBOSE instances? If so documenting the variable seems reasonable. Cc: Brian Paul <bri...@v

Re: [Mesa-dev] [PATCH 1/2] c11/threads: implement thrd_current on Windows

Series LGTM. Jose should probably take a look too, though. One typo below? Reviewed-by: Brian Paul <bri...@vmware.com> On 04/20/2017 08:15 AM, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> Earlier commit removed the implementation due to a subtle bug, in

Re: [Mesa-dev] [PATCH] mesa/glthread: correctly comparae thread handles

In the subject line "compare" Reviewed-by: Brian Paul <bri...@vmware.com> On 04/20/2017 09:24 AM, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> As mentioned in the manual - comparing pthread_t handles via the C comparison operator is incorrect and

[Mesa-dev] [PATCH] mesa: fix Windows build error related to getuid()

getuid() and geteuid() are not present on Windows. --- src/mesa/main/context.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 984c9e0..3570f94 100644 --- a/src/mesa/main/context.c +++ b/src/mesa/main/context.c @@

Re: [Mesa-dev] [PATCH] configure.ac: manually expand PKG_CHECK_VAR

On 04/18/2017 04:43 AM, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> The macro is introduced with pkgconfig v0.28 which isn't universally available. Thus it will error at configure stage. Cc: Brian Paul <bri...@vmware.com> Reported-by: Brian Paul <br

Re: [Mesa-dev] Mesa (master): EGL: Implement the libglvnd interface for EGL (v3)

On 04/17/2017 07:34 AM, Emil Velikov wrote: Module: Mesa Branch: master Commit: ce562f9e3fab769d64b0e5453ec2b4f8710a31ce URL:

[Mesa-dev] [PATCH] mesa: print target string in glBindTexture() error message

--- src/mesa/main/texobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index ad644ca..00feb97 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -1663,7 +1663,8 @@ _mesa_BindTexture( GLenum target, GLuint

Re: [Mesa-dev] [PATCH 7/7] st/mesa: use one big translation table in st_pipe_vertex_format

ample. Otherwise, the rest of the series looks OK to me, though I didn't do a super-detailed review. Hopefully, someone else can. For the series, Reviewed-by: Brian Paul <bri...@vmware.com> + { + { + PIPE_FORMAT_R8_SSCALED, + PIPE_FORMA

Re: [Mesa-dev] [PATCH 03/14] mesa: add _mesa_is_no_error_enabled() helper

On 04/13/2017 06:14 PM, Timothy Arceri wrote: On 13/04/17 12:54, Brian Paul wrote: On 04/12/2017 05:42 PM, Timothy Arceri wrote: --- src/mesa/main/context.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index 9704a96..ccb5463

Re: [Mesa-dev] [PATCH] mesa: rename _mesa_add_renderbuffer* functions

Looks ok, just minor formatting nit-picks below. Reviewed-by: Brian Paul <bri...@vmware.com> On 04/13/2017 09:42 PM, Timothy Arceri wrote: These names so make is easier to understand what is going on in regards to references. Cc: Brian Paul <bri...@vmware.com> --- src/mesa/driv

Re: [Mesa-dev] [PATCH 08/14] mesa/varray: rename update_array_format() -> validate_array_format()

On 04/12/2017 05:42 PM, Timothy Arceri wrote: We also move _mesa_update_array_format() into the caller. This gets these functions ready for KHR_no_error support. --- src/mesa/main/varray.c | 68 +++--- 1 file changed, 43 insertions(+), 25

Re: [Mesa-dev] [PATCH 07/14] mesa/varray: create get_array_format() helper

On 04/12/2017 05:42 PM, Timothy Arceri wrote: This will help us split array validation from array update. --- src/mesa/main/varray.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index

Re: [Mesa-dev] [PATCH 06/14] mesa/varray: split update_array() into validate_array() and update_array()

On 04/12/2017 05:42 PM, Timothy Arceri wrote: This will be used for adding KHR_no_error support. --- src/mesa/main/varray.c | 55 +- 1 file changed, 41 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c

Re: [Mesa-dev] [PATCH 03/14] mesa: add _mesa_is_no_error_enabled() helper

On 04/12/2017 05:42 PM, Timothy Arceri wrote: --- src/mesa/main/context.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h index 9704a96..ccb5463 100644 --- a/src/mesa/main/context.h +++ b/src/mesa/main/context.h @@ -317,20 +317,27

Re: [Mesa-dev] [RFC PATCH 1/3] gallium: decrease the size of pipe_vertex_buffer - 24 -> 16 bytes

On 04/11/2017 02:15 PM, Marek Olšák wrote: From: Marek Olšák New interface: union pipe_buffer_binding { struct pipe_resource *buffer; /**< the actual buffer */ const void *user_buffer; /**< pointer to a user buffer */ }; struct pipe_vertex_buffer { uint16_t

[Mesa-dev] [PATCH 1/2] st/mesa: minor optimization in st_DrawBuffers()

We only do on-demand renderbuffer allocation for window-system FBOs, not user-created FBOs. So put the loop inside a conditional. Plus, add some comments. No piglit regressions. --- src/mesa/state_tracker/st_cb_fbo.c | 24 1 file changed, 16 insertions(+), 8

<    5   6   7   8   9   10   11   12   13   14   >