Re: [Mesa-dev] [RFC 00/22] DRI3 v1.1, ANV dmabuf

Hi, On 14 June 2017 at 07:45, Chad Versace wrote: > On Thu 08 Jun 2017, Jason Ekstrand wrote: >> I'm just getting started looking at these. The first thing to say is that >> I'm pretty sure I made a bunch of comments the first time they were sent >> out and I don't see

Re: [Mesa-dev] [PATCH 1/2] gbm: add API to to import FD with modifier

g similar for minigbm; I would prefer to reuse that directly but the API is slightly worse (missing num_fds). So, this series is: Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freede

[Mesa-dev] [RFC 12/22] anv: Set anv_surface::offset earlier

From: Chad Versace <chadvers...@chromium.org> Set anv_surface::offset *before* calling add_surface(). No intended change in behavior. This patch prepares for supporting user-provided surface offsets, a feature required for VK_MESAX_external_image_dma_buf. Signed-off-by: Daniel Stone

[Mesa-dev] [RFC 06/22] anv: Annotate anv_get_*format() as pure

From: Chad Versace <chadvers...@chromium.org> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/vulkan/anv_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h inde

[Mesa-dev] [RFC 13/22] RFC: vulkan: Update registry for MESAX dma_buf extensions

-03-06-VK_MESAX_external Reference[2]: https://github.com/chadversary/vulkan-spec/commits/wip/1.0-VK_MESAX_external Signed-off-by: Daniel Stone <dani...@collabora.com> --- include/vulkan/vulkan.h| 104 src/vulkan/registry/

[Mesa-dev] [RFC 19/22] RFC: anv: Drop unused anv_image_create()

From: Chad Versace <chadvers...@chromium.org> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/vulkan/anv_image.c | 26 ++ src/intel/vulkan/anv_private.h | 5 - 2 files changed, 6 insertions(+), 25 deletions(-) diff --git a/src/

[Mesa-dev] [RFC 09/22] anv/image: Fix return type of make_surface()

From: Chad Versace <chadvers...@chromium.org> make_surface() always returns VK_SUCCESS, so change its return type to 'void'. This simplifies the return-code handling in anv_image_create_info() and removes a goto. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/

[Mesa-dev] [RFC 21/22] RFC: vulkan/wsi: Add modifiers to WSI image creation

driver which is not modifier-aware. Currently none of the AMD tiling modes have modifier tokens defined, and forcing to linear would be an unacceptable performance penalty. For now, just stick our head in the sand. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/amd/vulkan/radv

[Mesa-dev] [RFC 10/22] anv/image: Refactor creation of aux surfaces

_maybe() For clarity, also rename make_surface() to make_main_surface(). Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/vulkan/anv_image.c | 178 ++- 1 file changed, 110 insertions(+), 68 deletions(-) diff --git a/src/intel/vulkan/a

[Mesa-dev] [RFC 14/22] RFC: anv: Implement VK_EXT_get_image_properties

From: Chad Versace <chadvers...@chromium.org> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_image.c| 13 + 2 files changed, 14 insertions(+) diff --git a/src/

[Mesa-dev] [RFC 15/22] RFC: anv: Implement VK_MESAX_external_memory_dma_buf

From: Chad Versace <chadvers...@chromium.org> For now, we support dma_bufs only for VkBuffers. The VK_MESAX_external_memory_dma_buf spec allows us to support dma_buf VkImages, but we choose to defer that support until VK_MESAX_external_image_dma_buf. Signed-off-by: Daniel Stone

[Mesa-dev] [RFC 20/22] RFC: anv: Drop unneeded struct anv_image_create_info

From: Chad Versace <chadvers...@chromium.org> Now that anv_image_create() is gone, there is no need for struct anv_image_create_info. The struct just adds an unused layer of indirection. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/vulkan/anv_im

[Mesa-dev] [RFC 17/22] RFC: anv: Drop vkCreateDmaBufImageINTEL()

t a real dma_buf extension, VK_MESAX_external_image_dma_buf, that can replace this function. Signed-off-by: Daniel Stone <dani...@collabora.com> --- include/vulkan/vulkan_intel.h | 62 -- src/intel/Makefile.sources | 1 - src/intel/vulkan/Makefi

[Mesa-dev] [RFC 07/22] anv/image: Better var names in vkCreateImage

coming extensions, because the extensions define yet more "create info" structs. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/vulkan/anv_image.c | 72 ++-- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/src/inte

[Mesa-dev] [RFC 08/22] anv/image: Refactor how tiling is chosen

omplex. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/vulkan/anv_image.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 15e4fef690..4d74e8efb7 100644 ---

[Mesa-dev] [RFC 18/22] RFC: anv/wsi: Use VK_MESAX_external_image_dma_buf

ma_buf. In anv_wsi.c, replace the combo of anv_image_create() + struct anv_image_create_info with anv_CreateImage() + VkExportImageDmaBufInfoMESAX No intended change in behavior. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/Makefile.vulkan.am | 3 --- src/intel/vulkan/a

[Mesa-dev] [RFC 16/22] RFC: anv: Implement VK_MESAX_external_image_dma_buf

From: Chad Versace <chadvers...@chromium.org> For now, we support dma_buf images for only a single format, VK_FORMAT_R8G8B8A8_UNORM. And the image must be a "simple" image: 2D, single-sample, non-mipmappped, non-array, non-cube. Signed-off-by: Daniel Stone <dani...@collabora.

[Mesa-dev] [RFC 22/22] RFC: vulkan/wsi: Add support for DRI3 v1.1

Adds support for multiple planes and buffer modifiers. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/vulkan/anv_wsi.c | 7 +- src/vulkan/wsi/wsi_common_x11.c | 137 2 files changed, 131 insertions(+), 13 deletions(-) diff

[Mesa-dev] [RFC 11/22] anv: Handle failure in make_hiz_surface_maybe()

_maybe() to do the same. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/vulkan/anv_image.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 6e7d943014..dae7ed9311 100644 --- a/src/

[Mesa-dev] [RFC 01/22] RFC: egl/x11: Support DRI3 v1.1

AP_KHR). Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/egl/drivers/dri2/egl_dri2.c | 3 + src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/drivers/dri2/platform_x11_dri3.c | 62 +++- src/glx/dri3_glx.c | 10 +- src/loader/loader_d

[Mesa-dev] [RFC 02/22] intel/isl: Add ISL <-> DRM modifier conversion

From: Chad Versace <chadvers...@chromium.org> It converts a DRM format modifier to and from enum isl_tiling and aux_usage. That's all. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/Makefile.isl.am | 1 + src/intel/isl/isl.

[Mesa-dev] [RFC 05/22] anv: Add func anv_get_raw_format()

From: Chad Versace <chadvers...@chromium.org> Like anv_get_format(), but the returned format is not adjusted, not even for the aspect. Add anv_get_raw_isl_format() too, to match anv_get_isl_format(). Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/vulkan/anv_f

[Mesa-dev] [RFC 04/22] isl: Add isl_surf_get_drm_format_mod()

From: Chad Versace <chadvers...@chromium.org> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/isl/isl.c | 35 +++ src/intel/isl/isl.h | 15 +++ 2 files changed, 50 insertions(+) diff --git a/src/intel/isl/isl.c b/src/int

[Mesa-dev] [RFC 03/22] intel/isl: Add ISL <-> GEM tiling conversion

Add a simple conversion from ISL tiling to GEM BO tiling flags, and use that instead of hardcoding I915_TILING_X in the ANV WSI. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/intel/isl/isl.c| 28 src/intel/isl/isl.h| 8 +++

[Mesa-dev] [RFC 00/22] DRI3 v1.1, ANV dmabuf

Hi, With full support for modifiers in DRIimage, this patch series adds support for fully plumbing them through X11. A patchset proposing an extension to DRI3 to support multiple planes and modifiers can be found here: https://lists.x.org/archives/xorg-devel/2017-June/053854.html The Git trees,

Re: [Mesa-dev] [PATCH 2/6] i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D()

Hi Chad, On 8 June 2017 at 00:45, Chad Versace <chadvers...@chromium.org> wrote: > On Tue 06 Jun 2017, Daniel Stone wrote: >> I wonder if it wouldn't be better to do this in >> intel_create_image_from_name. That way it would be more obvious >> up-front wh

Re: [Mesa-dev] [PATCH 2/6] i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D()

Hi Chad, On 6 June 2017 at 21:36, Chad Versace wrote: > @@ -254,8 +255,22 @@ create_mt_for_dri_image(struct brw_context *brw, > struct gl_context *ctx = >ctx; > struct intel_mipmap_tree *mt; > uint32_t draw_x, draw_y; > + mesa_format format =

Re: [Mesa-dev] [PATCH 1/7] egl/dri2: Avoid sign extension when building modifier

Hi Eric, On 6 June 2017 at 18:27, Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Tuesday, 2017-06-06 18:18:31 +0100, Daniel Stone wrote: >> diff --git a/src/egl/drivers/dri2/egl_dri2.c >> b/src/egl/drivers/dri2/egl_dri2.c >> index d31a0bf8e0..7175e827c9 1006

[Mesa-dev] [PATCH v15 06/16] i965: Add logic for allocating BO with CCS

able, reviewable, and to have the CCS_MODIFIER token saved for the last patch, this patch now does less so it was renamed. v2: Leave "image+mod" (Topi) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen &

[Mesa-dev] [PATCH v15 07/16] i965/miptree: Add a return for updating of winsys

fails. (Jason) Signed-off-by: Ben Widawsky <benjamin.widaw...@intel.com> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> (v2) Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri

[Mesa-dev] [PATCH v15 14/16] i965/miptree: Remove dead code assertion

pohjolai...@intel.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 79429a8c8

[Mesa-dev] [PATCH v15 15/16] i965: Remove scanout restriction from lossless compression

: Remove the assert entirely Cc: Topi Pohjolainen <topi.pohjolai...@intel.com> Cc: Chad Versace <chadvers...@chromium.org> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjolai..

[Mesa-dev] [PATCH v15 10/16] i965: Change resolve flags to enum

binary selection. v2: Make setting the hint more concise (Topi) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> Signed-off-by: Daniel Stone <dani...@collabora.com>

[Mesa-dev] [PATCH v15 09/16] i965: Pretend that CCS modified images are two planes

awsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 98 +++- 1 file changed, 83 insertions(+), 15 deletions(-) diff --git a/src/mesa/drivers/dri/i965/inte

[Mesa-dev] [PATCH v15 16/16] i965: Handle compression modifier

Write bandwidth: 337.83 MiB/s v2: Move all references to the new fourcc code(s) to this patch. v3: Rebase, remove Yf_CCS (Daniel) Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Signed-of

[Mesa-dev] [PATCH v15 05/16] i965: add a no_aux field to identify buffers without aux data

From: Varad Gautam <varad.gau...@collabora.com> v2: split this into a separate patch (Jason) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Jason Ekstrand <ja...@jlekstrand.net> --- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH v15 08/16] i965/miptree: Allocate mt earlier in update winsys

porary no_aux variable since mt allocation should work correctly now. Unref the BO is miptree creation fails (Jason) v3: Rebase (Daniel) Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Signed-of

[Mesa-dev] [PATCH v15 03/16] i965/miptree: Allocate mcs_buf for an image's CCS_E

ned-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 92 +++

[Mesa-dev] [PATCH v15 11/16] i965: Plumb resolve hints from miptrees to blorp

From: Ben Widawsky <b...@bwidawsk.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mes

[Mesa-dev] [PATCH v15 12/16] i965: Add new resolve hints full and partial

et> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 +++- 2 fil

[Mesa-dev] [PATCH v15 01/16] i965: Support images with offset aux buffers

object. This patch just makes having an aux offset possible. Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_image.h | 3 +++ src/mesa/drivers/dri

[Mesa-dev] [PATCH v15 13/16] i965: Use partial resolves for CCS buffers being scanned out

kernel for display. v2: Add early exit from intel_miptree_make_shareable() when it's scanout. v3: Add another assert for mt->mcs_buf->offset. (Topi) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjol

[Mesa-dev] [PATCH v15 04/16] i965: Restructure CCS disabling

Split no_aux into a separate patch (Jason) Cc: "Pohjolainen, Topi" <topi.pohjolai...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Jason Ekstrand <ja...@jlekstrand.net> --- src/mesa/d

[Mesa-dev] [PATCH v15 02/16] i965/miptree: Add a helper function for image creation

ed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_fbo.c | 17 - src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 25 +++

[Mesa-dev] [PATCH v15 00/16] i965: CCS support

Hi, Building on top of the previous v15 to add support for buffers with modifiers to i965, this adds CCS support. I'm parking this until Jason has finished his blorp/etc work, so this should be purely informational until then. It also depends on a kernel series which hasn't got any review yet.

[Mesa-dev] [PATCH 3/7] i965: Move fallback size assignment out of bufmgr

level up. This also resolves a chicken/egg we have when importing bufers without explicit modifiers, namely that we need the tiling mode to calculate the size, but we need the BO imported to query the tiling mode. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dr

[Mesa-dev] [PATCH v15 0/7] i965 modifier import and advertisement

Hi, With the initial modifier enablement patches being merged, and Jason's comments about doing a lot of work in the vicinity of CCS with blorp/ISL, I'm cleaving this patch series into 3. Varad is taking over the Gallium/Freedreno parts as an independent series, since there are no longer any

[Mesa-dev] [PATCH 6/7] i965: Support dmabuf import with modifiers

Signed-off-by: Varad Gautam <varadgau...@gmail.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 94 ++-- 1 file changed, 76 insertions(+), 18 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_sc

[Mesa-dev] [PATCH 2/7] i965: Invert image modifier/tiling inference

this to a tiling mode. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 35 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dr

[Mesa-dev] [PATCH 4/7] i965: Allocate tile aligned height

libdrm or kernel does something incorrectly. v2: Do proper alignment for X tiling, and make sure non-tiled case is handled (Jason) v3: Rebase (Daniel) Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@coll

[Mesa-dev] [PATCH 1/7] egl/dri2: Avoid sign extension when building modifier

Since the EGL attributes are signed integers, a straight OR would also perform sign extension, Fixes: 6f10e7c37a ("egl/dri2: Create EGLImages with dmabuf modifiers") Cc: Varad Gautam <varad.gau...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> ---

[Mesa-dev] [PATCH 5/7] i965: Improve same-buffer restriction for imports

buffer is the same. Instead of checking the FDs for equality, we must check if they actually point to the same buffer (Jason). Signed-off-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Varad Gautam <varad.gau...@collabora.com> --- src/mesa/drivers/dri/i965/intel_s

[Mesa-dev] [PATCH 7/7] i965: Add format/modifier advertising

From: Varad Gautam <varad.gau...@collabora.com> v2: Rebase and reuse tiling/modifier map. (Daniel Stone) v3: bump DRIimageExtension to version 15, fill external_only array. Signed-off-by: Varad Gautam <varadgau...@gmail.com> Signed-off-by: Daniel Stone <dani...@collabora.com

Re: [Mesa-dev] [PATCH v14 15/36] i965: Improve same-buffer restriction for imports

Hi Varad, On 5 June 2017 at 15:13, Varad Gautam <varad.gau...@collabora.com> wrote: > On Mon, 2017-06-05 at 14:53 +0100, Daniel Stone wrote: >> This above takes a ref, which gets leaked. >> >>struct brw_bo *aux = >> brw_bo_gem_create_from_p

Re: [Mesa-dev] [PATCH v14 15/36] i965: Improve same-buffer restriction for imports

Hi Varad, On 30 May 2017 at 12:53, Varad Gautam wrote: > + /* We only support all planes from the same bo. > +* brw_bo_gem_create_from_prime() should return the same pointer for all > +* fds received here */ > + bo = brw_bo_gem_create_from_prime(screen->bufmgr,

Re: [Mesa-dev] [PATCH v13 16/36] i965: Remove same-FD restriction for imports

Hi, Getting back to this after holidays ... On 19 May 2017 at 19:26, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Fri, May 19, 2017 at 2:37 AM, Daniel Stone <dani...@collabora.com> wrote: >> >> Intel hardware requires that all planes of an image come fro

Re: [Mesa-dev] [RFC 1/3] egl/dri2: enable EGL_NOK_texture_from_pixmap everywhere

Hi, On 5 June 2017 at 09:30, Tapani Pälli wrote: > Android does not support pixmaps, so this should be set to false there. I > think otherwise this should be fine. Wayland, GBM and surfaceless also don't support pixmaps, so I'd probably lean towards just dropping this

Re: [Mesa-dev] [PATCH] configure.ac: Add --with-wayland-scanner-path

Hi Jussi, On 26 May 2017 at 14:55, Jussi Kukkonen wrote: > On 26 May 2017 at 14:32, Emil Velikov wrote: >> b) with a wrapper script - see [1]. >> I think that the "export PKG_CONFIG_DIR=" is a typo (should be ..PATH >> instead) and is not

Re: [Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

Hi Varad, On 23 May 2017 at 14:19, Varad Gautam <varad.gau...@collabora.com> wrote: > On Mon, 2017-05-22 at 14:03 +0100, Emil Velikov wrote: >> On 19 May 2017 at 10:37, Daniel Stone <dani...@collabora.com> wrote: >> > + if (external_only != NULL) { >> > +

Re: [Mesa-dev] [PATCH v13 02/36] egl/main: add support for fourth plane tokens

Hey, On 22 May 2017 at 13:43, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 19 May 2017 at 10:37, Daniel Stone <dani...@collabora.com> wrote: >> The EGL_EXT_dma_buf_import_modifiers extension adds support for a >> fourth plane, just like DRM KMS API does. >&

Re: [Mesa-dev] [PATCH] egl/wayland: verify event queue was allocated

On 22 May 2017 at 11:07, Lionel Landwerlin <lionel.g.landwer...@intel.com> wrote: > We're already verified that 'window' wasn't NULL, I'm guess this > allocation error is about the newly created queue. Reviewed-by: Daniel Stone <dani..

Re: [Mesa-dev] [PATCH libdrm] header: update drm_fourcc.h

Hi Lucas, On 22 May 2017 at 11:53, Lucas Stach wrote: > Am Dienstag, den 02.05.2017, 16:35 +0200 schrieb Lucas Stach: >> Mostly to pull in the Vivante tiling format modifiers, but some other >> little changes included. > > If there are no objections to this patch, I'm

Re: [Mesa-dev] [PATCH v4 3/4] egl: implement __DRIbackgroundCallableExtension.isThreadSafe

Hi Gregory, On 21 May 2017 at 15:59, Gregory Hainaut wrote: > +static GLboolean > +dri_is_thread_safe(void *loaderPrivate) > +{ > +#ifdef HAVE_X11_PLATFORM > + struct dri2_egl_surface *dri2_surf = loaderPrivate; > + _EGLDisplay *display =

Re: [Mesa-dev] [PATCH] vulkan/wsi/wayland: Fix proxy wrappers for swapchain recreation

Hi Philipp, On 19 May 2017 at 23:07, Philipp Zabel wrote: > Before the swapchain event queue is destroyed, all proxy objects that > reference > it must be dropped. Otherwise we risk a use-after-free if a frame callback > event > or buffer release events are received

[Mesa-dev] [PATCH v13 03/36] dri: support DRIimage creation from dmabufs with modifiers

From: Pekka Paalanen <pekka.paala...@collabora.co.uk> add createImageFromDmaBufs2 function which accepts per-plane dmabuf format modifiers. Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Signed-off-by: Varad Gautam <varad.gau...@collabora.com> Reviewed-by:

[Mesa-dev] [PATCH v13 35/36] i965: Support dmabuf import with modifiers

From: Varad Gautam <varadgau...@gmail.com> Add support for createImageFromDmaBufs2, adding a modifier to the original. Signed-off-by: Varad Gautam <varadgau...@gmail.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [PATCH v13 20/36] i965/miptree: Allocate mcs_buf for an image's CCS_E

requested by Topi) Remove bogus is_scanout check in miptree_release v3: Remove is_scanout assert in intel_miptree_create. It doesn't work with latest codebase - not sure it ever should have worked. Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@colla

[Mesa-dev] [PATCH v13 11/36] st/dri: implement createImageWithModifiers in DRIimage

From: Varad Gautam <varad.gau...@collabora.com> adds a pscreen->resource_create_with_modifiers() to create textures with modifier. Signed-off-by: Varad Gautam <varad.gau...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/gallium/include/p

[Mesa-dev] [PATCH v13 22/36] i965: Allocate tile aligned height

libdrm or kernel does something incorrectly. v2: Do proper alignment for X tiling, and make sure non-tiled case is handled (Jason) v3: Rebase (Daniel) Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@coll

[Mesa-dev] [PATCH v13 14/36] gallium: introduce format modifier querying

return false on query failure. v4: use pscreen->is_format_supported instead of adding a separate format query handle, remove PIPE_CAP_QUERY_DMABUF_ATTRIBS. (Lucas Stach) Signed-off-by: Varad Gautam <varad.gau...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com

[Mesa-dev] [PATCH v13 34/36] i965: Add tiling mode to BO import

When importing a dmabuf, verify that the tiling mode matches what was expected. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 12 ++-- src/mesa/drivers/dri/i965/brw_bufmgr.h | 3 ++- src/mesa/drivers/dri/i965/intel_screen.

[Mesa-dev] [PATCH v13 15/36] st/dri: support format modifier queries

ed-off-by: Varad Gautam <varad.gau...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/gallium/state_trackers/dri/dri2.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/

[Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

Daniel Stone) Signed-off-by: Varad Gautam <varad.gau...@collabora.com> Reviewed-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/egl/drivers/dri2/egl_dri2.c | 36 src/egl/main

[Mesa-dev] [PATCH v13 26/36] i965: Pretend that CCS modified images are two planes

awsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 98 +++- 1 file changed, 83 insertions(+), 15 deletions(-) diff --git a/src/mesa/drivers/dri/i965/inte

[Mesa-dev] [PATCH v13 05/36] dri: add queryDmaBufFormats and queryDmaBufModifiers to DRIimage

abora.com> Reviewed-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- include/GL/internal/dri_interface.h | 42 - 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_i

[Mesa-dev] [PATCH v13 27/36] i965: Change resolve flags to enum

binary selection. v2: Make setting the hint more concise (Topi) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> Signed-off-by: Daniel Stone <dani...@collabora.com>

[Mesa-dev] [PATCH v13 04/36] egl/dri2: Create EGLImages with dmabuf modifiers

switch-case (Emil Velikov) - treat zero as valid modifier (Daniel Stone) - ensure same modifier across all dmabuf planes (Emil Velikov) v4: - allow modifiers to add extra planes (Louis-Francis Ratté-Boulianne) Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Signed-off-by:

[Mesa-dev] [PATCH v13 19/36] i965/miptree: Add a helper function for image creation

ed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_fbo.c | 17 - src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 25 +++

[Mesa-dev] [PATCH v13 21/36] i965: Restructure CCS disabling

l. Cc: "Pohjolainen, Topi" <topi.pohjolai...@gmail.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Topi's changes Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/brw_context.c | 3 +++ src/mesa/drivers/dri/i965/intel_fbo.h

[Mesa-dev] [PATCH v13 24/36] i965/miptree: Add a return for updating of winsys

fails. (Jason) Signed-off-by: Ben Widawsky <benjamin.widaw...@intel.com> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> (v2) Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri

[Mesa-dev] [PATCH v13 16/36] i965: Remove same-FD restriction for imports

buffer is the same. Since there is nothing we can do to detect this properly, just remove the test for now. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/drivers/dr

[Mesa-dev] [PATCH v13 13/36] st/dri: support format queries

> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/gallium/state_trackers/dri/dri2.c | 91 +++ 1 file changed, 91 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index 3f83cc96cc..814a08

[Mesa-dev] [PATCH v13 30/36] i965: Use partial resolves for CCS buffers being scanned out

kernel for display. v2: Add early exit from intel_miptree_make_shareable() when it's scanout. Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> (v1) Signed-off-by: Daniel Stone <dani

[Mesa-dev] [PATCH v13 28/36] i965: Plumb resolve hints from miptrees to blorp

From: Ben Widawsky <b...@bwidawsk.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mes

[Mesa-dev] [PATCH v13 10/36] st/dri: enable DRIimage modifier queries

From: Varad Gautam <varad.gau...@collabora.com> introduce modifier field in DRIimage and set it to DRM_FORMAT_MOD_INVALID for now. support DRIimage modifier queries. Suggested-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Varad Gautam <varad.gau...@collabora.com> Sig

[Mesa-dev] [PATCH v13 29/36] i965: Add new resolve hints full and partial

et> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 +++- 2 fil

[Mesa-dev] [PATCH v13 23/36] i965: Add logic for allocating BO with CCS

able, reviewable, and to have the CCS_MODIFIER token saved for the last patch, this patch now does less so it was renamed. v2: Leave "image+mod" (Topi) Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Topi Pohjolainen &

[Mesa-dev] [PATCH v13 32/36] i965: Remove scanout restriction from lossless compression

: Remove the assert entirely Cc: Topi Pohjolainen <topi.pohjolai...@intel.com> Cc: Chad Versace <chadvers...@chromium.org> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> ---

[Mesa-dev] [PATCH v13 25/36] i965/miptree: Allocate mt earlier in update winsys

porary no_aux variable since mt allocation should work correctly now. Unref the BO is miptree creation fails (Jason) v3: Rebase (Daniel) Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Signed-of

[Mesa-dev] [PATCH v13 08/36] egl: advertise EGL_EXT_image_dma_buf_import_modifiers

From: Varad Gautam <varad.gau...@collabora.com> Signed-off-by: Varad Gautam <varad.gau...@collabora.com> Reviewed-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/egl/drivers/dri2/egl_dri2.c | 6 ++ src/egl/main/egl

[Mesa-dev] [PATCH v13 06/36] egl: implement eglQueryDmaBufFormatsEXT

From: Varad Gautam <varad.gau...@collabora.com> allow egl clients to query the dmabuf formats supported on this platform. v2: return EGLBoolean. v3: Check DRIimageExtension version before querying (Daniel Stone) Signed-off-by: Louis-Francis Ratté-Boulianne <l...@collabora.com>

[Mesa-dev] [PATCH v13 36/36] i965: Add format/modifier advertising

From: Varad Gautam <varadgau...@gmail.com> v2: Rebase and reuse tiling/modifier map. (Daniel Stone) Signed-off-by: Varad Gautam <varadgau...@gmail.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 59 ++

[Mesa-dev] [PATCH v13 17/36] i965: Invert image modifier/tiling inference

this to a tiling mode. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 35 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dr

[Mesa-dev] [PATCH v13 33/36] i965: Handle compression modifier

Write bandwidth: 337.83 MiB/s v2: Move all references to the new fourcc code(s) to this patch. v3: Rebase, remove Yf_CCS (Daniel) Cc: Jason Ekstrand <ja...@jlekstrand.net> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Acked-by: Daniel Stone <dani...@collabora.com> Signed-of

[Mesa-dev] [PATCH v13 12/36] st/dri: implement DRIimage creation from dmabufs with modifiers

From: Varad Gautam <varad.gau...@collabora.com> support importing dmabufs into DRIimage while taking format modifiers in account, as per DRIimage extension version 15. bump __DRIimageExtension to 15. v2: initialize winsys modifier to DRM_FORMAT_MOD_INVALID (Daniel Stone) Signed-off-by:

[Mesa-dev] [PATCH v13 31/36] i965/miptree: Remove dead code assertion

lainen <topi.pohjolai...@intel.com> Signed-off-by: Ben Widawsky <b...@bwidawsk.net> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_m

[Mesa-dev] [PATCH v13 00/36] EGL dmabuf modifiers import & i915 CCS

Hi, This series is an amalgamation of two series: Varad's EGL_EXT_image_dma_buf_import_modifiers support (last seen at v3), and Ben's i915 CCS support (last seen at v12). I've fairly heavily rebased them, fixed up the Intel paths, and Varad had also fixed up the Gallium/pipe parts from Lucas's

[Mesa-dev] [PATCH v13 09/36] st/dri: refactor multi-planar YUV import path

to dri, allowing us to return the correct fourcc format from DRIimage queries, and simplifies the multiplane import logic. Signed-off-by: Varad Gautam <varad.gau...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/gallium/state_trackers/dri/

[Mesa-dev] [PATCH v13 02/36] egl/main: add support for fourth plane tokens

ifiers is not suported. (Emil Velikov) Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Signed-off-by: Varad Gautam <varad.gau...@collabora.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Reviewed-by: Daniel Stone <dani...@collabora.com> Sig

[Mesa-dev] [PATCH v13 01/36] egl: introduce DMA_BUF_MAX_PLANES

strom <eric.engest...@imgtec.com> Reviewed-by: Daniel Stone <dani...@collabora.com> Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/egl/drivers/dri2/egl_dri2.c | 8 src/egl/main/eglimage.h | 8 +--- 2 files changed, 9 insertions(+), 7 deletions(-

<    1   2   3   4   5   6   7   8   >