Re: [Mesa-dev] [PATCH v2] vulkan: autotools: build Wayland part conditionally

On Wednesday, 2018-03-21 14:10:57 +0100, Juan A. Suarez Romero wrote: > Eric, can I get this R-b by you? This looks sensible, but I don't know enough about how/when the wayland bits are built, especially under autotools Acked-by: Eric Engestrom <eric.engest...@imgtec.com> > &g

Re: [Mesa-dev] [PATCH] i965/tiled_memcpy: realign rgba8_copy_aligned_dst stack in 32-bit builds

On Tuesday, 2018-03-20 13:39:25 -0700, Scott D Phillips wrote: > When building intel_tiled_memcpy for i686, the stack will only be > 4-byte aligned. This isn't sufficient for SSE temporaries which > require 16-byte alignment. Use the force_align_arg_pointer > function attribute in that case to

Re: [Mesa-dev] [PATCH kmscube] cube-tex: make use of modifiers

m> LGTM! Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > cube-tex.c | 32 > 1 file changed, 24 insertions(+), 8 deletions(-) > > diff --git a/cube-tex.c b/cube-tex.c > index 9e38ae8..dba19ff 100644 > --- a/cube-tex.c >

Re: [Mesa-dev] [PATCH 2/8] vulkan: autotools: build Wayland part conditionally

On Monday, 2018-03-19 18:49:05 +0100, Juan A. Suarez Romero wrote: > Build vulkan/wsi/wayland if Wayland platform is enabled. > > CC: Daniel Stone > Fixes: bfa22266cd4d ("vulkan/wsi/wayland: Add support for zwp_dmabuf") > Bugzilla:

Re: [Mesa-dev] [PATCH 2/2] meson: Don't build svga on ARM/AArch64

ult/ in the commit title, but other than that nit, the series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 88e90fe8119..24cad58c61

Re: [Mesa-dev] [PATCH mesa 1/3] egl: add Ozone section to eglplatform.h

On March 16, 2018 5:49:12 PM UTC, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 16 March 2018 at 15:58, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > This pulls in commit a93f559e9c11fa53fb5f1cc255b8f75433f85d2a "Add > Ozone > > section to

[Mesa-dev] [PATCH mesa 3/3] egl: pull update from Khronos and drop local define

ry/pull/36 Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- include/EGL/eglext.h | 1 + include/EGL/eglmesaext.h | 7 --- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/include/EGL/eglext.h b/include/EGL/eglext.h index f7dc66884ee9a673041e..2f990cc54d6

[Mesa-dev] [PATCH mesa 1/3] egl: add Ozone section to eglplatform.h

ronosGroup/EGL-Registry/pull/26 Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- include/EGL/eglplatform.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/EGL/eglplatform.h b/include/EGL/eglplatform.h index bf9ec0bf5f4fbf7105cd..8a78a9eaddd2f47ff2c0 100644 -

[Mesa-dev] [PATCH mesa 2/3] egl: align the formatting of Haiku section of eglplatform.h with Khronos'

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- include/EGL/eglplatform.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/include/EGL/eglplatform.h b/include/EGL/eglplatform.h index 8a78a9eaddd2f47ff2c0..b0541d52aed6584c63f2 100644 --- a/inclu

Re: [Mesa-dev] [PATCH] egl/dri2: move wayland header inclusion where applicable

protocol elements */ > +/* forward declarations to avoid pulling wayland headers everywhere */ > +struct wl_egl_window; > +struct wl_event_queue; > +struct wl_callback; > +struct wl_display; > +struct wl_drm; > +struct wl_registry; > +struct wl_shm; > +struct wl_surface; Hav

Re: [Mesa-dev] [PATCH] meson: fix pipe-loaders after omx changes

33ff >("meson: Re-add auto option for omx") > Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> And a quick grep confirms this was the only place that was still using `with_gallium_omx` as a bool. >

Re: [Mesa-dev] [PATCH 2/3] meson: Use the same version for all libdrm checks

lan Baker <dylan.c.ba...@intel.com> Makes sense, and looks cleaner than my earlier variant :) Series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> (small nit below) > --- > meson.build | 67 +- > 1

Re: [Mesa-dev] [PATCH] meson: don't use compiler.has_header

, and compilation will work. > > Fixes compilation on x32 architecture. > > Gentoo Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=649746 > meson bug: https://github.com/mesonbuild/meson/issues/2246 > CC: Matt Turner <matts...@gmail.com> > Signed-off-by: Dylan Ba

Re: [Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

On Monday, 2018-03-12 10:19:49 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-03-12 07:33:27) > > We're trying to be -Wundef clean so that we can turn it on (and > > eventually make it an error). > > > > Note that the OMX code already used `#if ENAB

[Mesa-dev] [PATCH mesa] meson: simplify omx logic

and let's make sure `with_gallium_omx` is never 'auto' and can only be one of [bellagio, tizonia, disabled]. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff

[Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Dylan, was there any reason to have -Werror=missing-prototypes and -Werror=implicit-function-declaration in C but not C++? Both sound to me like something we always want. --- meson.build | 17 ++--- 1 file chan

[Mesa-dev] [PATCH mesa] omx: always define ENABLE_ST_OMX_{BELLAGIO, TIZONIA}

. Fixes: 83d4a5d5aea5a8a05be2 "st/omx/tizonia: Add H.264 decoder" Fixes: b2f2236dc565dd1460f0 "st/omx/tizonia: Add H.264 encoder" Fixes: c62cf1f165919bc74296 "st/omx/tizonia/h264d: Add EGLImage support" Cc: Gurkirpal Singh <gurkirpal...@gmail.com> Signed

Re: [Mesa-dev] [PATCH] gallium: Use struct gl_array_attributes* as st_pipe_vertex_format argument.

Please review > best > Mathias > > > Signed-off-by: Mathias Fröhlich <mathias.froehl...@web.de> Looks good to me! Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/mesa/state_tracker/st_atom.h | 3 +-- > src/mesa/state_tracker/st_atom_a

Re: [Mesa-dev] [PATCH 1/2] egl/wayland: Add 10bpc BGR configs

On Thursday, 2018-03-08 17:36:39 +, Daniel Stone wrote: > Add support for XBGR2101010 and ABGR2101010. > > Signed-off-by: Daniel Stone <dani...@collabora.com> > Cc: Ilia Mirkin <imir...@alum.mit.edu> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com>

Re: [Mesa-dev] [PATCH] vulkan: simplify VK_USE_PLATFORM_*_KHR handling

> Inspired by the same convention from the kernel. Oh right, I didn't get what you meant at first, but this makes sense. As the number of supported platform increases, this will be much cleaner. > > Cc: Eric Engestrom <eric.engest...@imgtec.com> > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH] meson: Add moduledir to d3d.pc

t; > Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/gallium/targets/d3dadapter9/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/targets/d3dadapter9/meson.b

Re: [Mesa-dev] [PATCH mesa] vulkan/wsi: clean up cleanup path

On Thursday, 2018-03-08 18:16:11 +, Emil Velikov wrote: > On 26 February 2018 at 13:51, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > Cc: Keith Packard <kei...@keithp.com> > > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > > --

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

On Thursday, 2018-03-08 10:04:03 -0800, Keith Packard wrote: > Eric Engestrom <eric.engest...@imgtec.com> writes: > > > I'm still slightly bothered by the build options inconsistency between > > autotools: reuse --with-platform=drm > > meson: new -D platfor

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

emantics, even if undefined. > > Suggested-by: Jason Ekstrand <ja...@jlekstrand.net> > > * Simplify addition of VK_USE_PLATFORM_DISPLAY_KHR to > vulkan_wsi_args > > Suggested-by: Eric Engestrom <eric.engest...@imgtec.com> > > v3: >

Re: [Mesa-dev] [PATCH 3/5] meson: Re-add auto option for omx

On Tuesday, 2018-03-06 11:57:14 -0800, Dylan Baker wrote: > This re-adds the auto option for omx, without it we default to tizonia > and the build fails almost immediately, this is especially obnoxious > those building a driver that doesn't support the OMX state tracker to > begin with. > > CC:

Re: [Mesa-dev] [PATCH 0/5] Fix meson omx compilation

On Tuesday, 2018-03-06 11:57:11 -0800, Dylan Baker wrote: > This fixes a couple of problems with the meson build support for the > recent omx tizonia integration, namely that it breaks a lot of > previously working meson configurations. Thanks! Series is: Reviewed-by: Eric Engestrom <

Re: [Mesa-dev] [PATCH RFC] radeonsi: Disable IEEE_MODE.

On Monday, 2018-03-05 14:07:24 -0500, Jan Vesely wrote: > On Mon, 2018-03-05 at 10:04 +0000, Eric Engestrom wrote: > > On Saturday, 2018-03-03 18:35:02 -0500, Jan Vesely wrote: > > > Neither GL nor CL nor SPIRV needs the IEEE handling of sNaNs. > > > > > >

Re: [Mesa-dev] [PATCH] freedreno: bump required libdrm version

ian Gmeiner <christian.gmei...@gmail.com> > > --- > > configure.ac | 2 +- > > meson.build | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > Should cover the slip-up that Eric noticed yesterday [1]. Indeed :) Reviewed-by: Eric Engestrom <eric.engest...@imgtec

Re: [Mesa-dev] [PATCH] configure: remove unused AM_CONDITIONAL

On Monday, 2018-03-05 18:15:24 +, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > configure.ac | 1 - > 1 f

[Mesa-dev] [PATCH mesa] freedreno: add missing include

Fixes: 26a9321d0ae819f2a49d7 "freedreno: add global_bindings state" Cc: Rob Clark <robdcl...@gmail.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gallium/drivers/freedreno/freedreno_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gal

Re: [Mesa-dev] [PATCH] travis: keep meson version below 0.45.0

On Monday, 2018-03-05 17:25:36 +0200, Andres Gomez wrote: > Recently Meson upgraded to 0.45.0 and it needs python 3.5+, which is > not available in Trusty. I was looking at this issue right now, thanks for beating me to it :) Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> &

[Mesa-dev] [PATCH mesa] gbm: give a name to rgba fields

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Note: `gbm_dri_visuals_table` doesn't need any modification, as the channel order doesn't change, so `rgba_mask = { r, g, b, a }` still works. --- src/egl/drivers/dri2/platform_drm.c | 16 src/gbm/backen

Re: [Mesa-dev] [PATCH] disk cache: Link with -latomic if necessary

On Sunday, 2018-03-04 00:20:16 +, Mike Lothian wrote: > Hi > > Sorry to be a pain again > > I've just tested this with clang and the 32bit build still fails without > -latomic This fix was for meson, and you're using make here; does it work if you build using meson? First thing is to figure

Re: [Mesa-dev] [PATCH RFC] radeonsi: Disable IEEE_MODE.

On Saturday, 2018-03-03 18:35:02 -0500, Jan Vesely wrote: > Neither GL nor CL nor SPIRV needs the IEEE handling of sNaNs. > > Signed-off-by: Jan Vesely > --- > This is the 3rd way to handle broken fmin/fmax in clover CL. > It can be worked around in libclc (to not use >

Re: [Mesa-dev] [PATCH] r600/egd_tables.py: make the script python 2+3 compatible

On Friday, 2018-03-02 13:03:02 +, Stefan Dirsch wrote: > On Fri, Mar 02, 2018 at 01:39:40PM +0100, Gustaw Smolarczyk wrote: > > 2018-03-02 12:59 GMT+01:00 Stefan Dirsch <sndir...@suse.de>: > > > > On Fri, Mar 02, 2018 at 11:47:57AM +, Eric Engestrom wrote: &

Re: [Mesa-dev] [PATCH] Update the documentation for meson

gned-off-by: Dylan Baker <dylan.c.ba...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > docs/meson.html | 34 +- > 1 file changed, 21 insertions(+), 13 deletions(-) > > diff --git a/docs/meson.html b/docs/meson

Re: [Mesa-dev] [PATCH] egl: remove redundant initialization

On Friday, 2018-03-02 13:28:28 +0200, Andres Gomez wrote: > Found by inspection. > > Cc: Ian Romanick <ian.d.roman...@intel.com> > Cc: Emil Velikov <emil.veli...@collabora.com> > Cc: Eric Engestrom <eric.engest...@imgtec.com> > Signed-off-by: Andres Gomez <a

Re: [Mesa-dev] [PATCH] r600/egd_tables.py: make the script python 2+3 compatible

On Friday, 2018-03-02 12:25:11 +0100, Stefan Dirsch wrote: > On Fri, Mar 02, 2018 at 11:03:53AM +0000, Eric Engestrom wrote: > > On Friday, 2018-03-02 11:41:00 +0100, Stefan Dirsch wrote: > > > Patch by "Tomas Chvatal" <tchva...@suse.com> with modifications &g

Re: [Mesa-dev] [PATCH] r600/egd_tables.py: make the script python 2+3 compatible

On Friday, 2018-03-02 11:41:00 +0100, Stefan Dirsch wrote: > Patch by "Tomas Chvatal" with modifications > by "Michal Srb" to not break python 2. > > https://bugzilla.suse.com/show_bug.cgi?id=1082303 > > v2: > - no longer try to encode a unicode > - make use

Re: [Mesa-dev] [PATCH] loader: Add support for platform and host1x busses

;fullname; > + else > + fullname = device->businfo.host1x->fullname; > + > + name = strrchr(fullname, '/'); > + if (!name) > + name = strdup(fullname); > + else > + name = strdup(++name); Looks like UB to me; how about this instead? n

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

On February 28, 2018 8:30:14 PM UTC, Andres Gomez <ago...@igalia.com> wrote: > On Wed, 2018-02-28 at 17:12 +0000, Eric Engestrom wrote: > > On Wednesday, 2018-02-28 17:08:41 +, Eric Engestrom wrote: > > > On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wro

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

On Wednesday, 2018-02-28 17:08:41 +, Eric Engestrom wrote: > On Wednesday, 2018-02-28 17:02:50 +0000, Eric Engestrom wrote: > > On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > > > 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you > &

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: > On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > > 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you > > have installed 3.4 or below, meson will fail even when we may not make

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you > have installed 3.4 or below, meson will fail even when we may not make > use of LLVM. > > Cc: Dylan Baker <dy...@pnwbakers.com> > Cc: Eri

Re: [Mesa-dev] [PATCH 2/2] travis: make Meson find the proper llvm-config

nd our wanted version sooner than the one at > /usr/local/bin > > Once this is corrected, we would still need a patch similar to: > https://lists.freedesktop.org/archives/mesa-dev/2017-December/180217.html > > Cc: Eric Engestrom <eric.engest...@imgtec.com> Reviewed-and-Te

Re: [Mesa-dev] [PATCH v2 1/2] meson: Add default DRI drivers for ARM/AArch64

On Wednesday, 2018-02-28 09:36:51 +, Daniel Stone wrote: > Hi, > > On 28 February 2018 at 09:33, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > On Tuesday, 2018-02-27 18:01:11 +, Daniel Stone wrote: > >> On all Arm architectures (ARMv7 an

Re: [Mesa-dev] [PATCH] radeonsi: fix radeon create encoder return

. > > Signed-off-by: Boyuan Zhang <boyuan.zh...@amd.com> Fixes: b38b208ff8886e799d6a2 "radeonsi:create uvd hevc enc entry" Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/gallium/drivers/radeonsi/si_uvd.c | 2 +- > 1 file changed, 1 insertion

Re: [Mesa-dev] [PATCH v2 1/2] meson: Add default DRI drivers for ARM/AArch64

On Tuesday, 2018-02-27 18:01:11 +, Daniel Stone wrote: > On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as > 'aarch64'), only build swrast for DRI drivers. The commit message and the code don't align anymore in v2; which one was intended? > The only classic drivers >

Re: [Mesa-dev] [RFC PATCH mesa 5/5] WIP - meson: add a message block at the end of the configuration stage

On Friday, 2018-02-23 16:49:14 -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2018-02-23 10:08:48) > > The messages are basically the same as the ones in configure.ac > > > > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > > --- > > Sent

Re: [Mesa-dev] [PATCH] meson: Add default DRI drivers for ARM/AArch64

ly enough > that it shouldn't be the default. > > Signed-off-by: Daniel Stone <dani...@collabora.com> > Reported-by: Javier Jardón <jjar...@gnome.org> > Cc: Dylan Baker <dy...@pnwbakers.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > meson.bui

Re: [Mesa-dev] [PATCH] meson: fix building without GL

On Monday, 2018-02-26 16:56:46 +, Eric Engestrom wrote: > On Monday, 2018-02-26 08:46:54 -0800, Dylan Baker wrote: > > libgl will be undefined if with_glx == 'disabled', so move that check > > inside the `if with_glx == 'disabled'` block immediately after

Re: [Mesa-dev] [PATCH] meson: fix building without GL

On Monday, 2018-02-26 08:46:54 -0800, Dylan Baker wrote: > libgl will be undefined if with_glx == 'disabled', so move that check > inside the `if with_glx == 'disabled'` block immediately after that typo: s/==/!=/^^ Acked-by: Eric Engestrom <eric.engest...@imgtec.com&

Re: [Mesa-dev] [PATCH] swr/rast: Fix macOS macro.

On Saturday, 2018-02-24 23:55:21 +, Vinson Lee wrote: > Fixes: a25093de7188 ("swr/rast: Implement JIT shader caching to disk") > Signed-off-by: Vinson Lee <v...@freedesktop.org> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/gal

Re: [Mesa-dev] Killing broken configure toggles and fixing autotools gl.pc

bit ... > > Any feedback, even a general ACK will be appreciated. > Emil > > Cc: Brian Paul <bri...@vmware.com> > Cc: Dylan Baker <dy...@pnwbakers.com> > 3 & 4 are: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> and the rest of the series is:

[Mesa-dev] [PATCH mesa] vulkan/wsi: clean up cleanup path

Cc: Keith Packard <kei...@keithp.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- This will make Keith's addition much cleaner as well :) --- src/vulkan/wsi/wsi_common.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sr

[Mesa-dev] [RFC PATCH mesa 3/5] meson: avoid changing types for the dri3 option

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 28d068742ff914a623f6..6c22601f9e8864f08e08 100644 --- a/meson.build +++ b/meson.build @@ -380,11 +

[Mesa-dev] [RFC PATCH mesa 1/5] meson: give different names to the vars containing dri drivers vs gallium drivers

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/meson.build b/meson.build index e470e62074da9a46767c..2d474b140373292e49e7 100644 --- a/meson.build +++ b/meson

[Mesa-dev] [RFC PATCH mesa 4/5] meson: store the result of whether we have gallium-extra-hud and lmsensors

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 4 1 file changed, 4 insertions(+) diff --git a/meson.build b/meson.build index 6c22601f9e8864f08e08..770fdc7e50653bcfa7c2 100644 --- a/meson.build +++ b/meson.build @@ -1187,15 +1187,19 @@ if with_platfo

[Mesa-dev] [RFC PATCH mesa 5/5] WIP - meson: add a message block at the end of the configuration stage

The messages are basically the same as the ones in configure.ac Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Sent out because it's as much as I could do before the weekend, and before I try to figure out the last bits I'd love some confirmation that this is what w

[Mesa-dev] [RFC PATCH mesa 2/5] meson: simplify the gbm option code, and avoid changing types

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- meson.build | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/meson.build b/meson.build index 2d474b140373292e49e7..28d068742ff914a623f6 100644 --- a/meson.build +++ b/meson.build @@ -303,16 +

[Mesa-dev] [PATCH mesa] *-symbol-check: use correct `nm` path when cross-compiling

Inspired-by: a similar patch for libdrm by Heiko Becker Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- configure.ac | 1 + meson.build | 3 +++ src/egl/egl-symbols

Re: [Mesa-dev] [PATCH] egl/dri2: fix segfault when display initialisation fails

quot;loader_dri3/glx/egl: Optionally use a blit > context for blitting operations") > Signed-off-by: Frank Binns <francisbi...@gmail.com> Error paths are basically never tested... You're entirely right, thanks for catching this! Reviewed-by: Eric Engestrom <eric.engest...@im

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

On Wednesday, 2018-02-21 09:48:54 -0500, Chuck Atkins wrote: > > > - if (xmdpy->smapi->destroy) > > > - xmdpy->smapi->destroy(xmdpy->smapi); > > > - free(xmdpy->smapi); > > > + if (xmdpy->smapi) > > > + { > > > + if (xmdpy->smapi->destroy) > > > +

Re: [Mesa-dev] [PATCH v11 12/15] x11/dri3: Don't open-code ARRAY_SIZE

On Wednesday, 2018-02-21 14:05:56 +, Daniel Stone wrote: > Signed-off-by: Daniel Stone <dani...@collabora.com> > --- > src/loader/loader_dri3_helper.c | 5 +++-- > src/loader/meson.build | 2 +- Assuming automake already has the right include path, Reviewed-

Re: [Mesa-dev] [PATCH v11 13/15] x11/dri3: Store raw present completion mode

' > field to the raw present completion mode from the server. > > Signed-off-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/loader/loader_dri3_helper.c | 12 +++- > src/loader/loader_dri3_helper.h |

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

On Wednesday, 2018-02-21 09:26:34 -0500, Chuck Atkins wrote: > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > used on an unsupported architecture. > > Signed-off-by: Chuck Atkins > Cc: mesa-sta...@lists.freedesktop.org > Cc: George Kyriazis

[Mesa-dev] [PATCH mesa] docs: fix patent url

Reported-by: Pierre Moreau <pierre.mor...@free.fr> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- docs/patents.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/patents.txt b/docs/patents.txt index b20a045d4b579cba36c3..91c5757d14dc8c7

Re: [Mesa-dev] [PATCH] configure.ac: pthread-stubs not present on OpenBSD

*BSD people, can you confirm whether pthread-stubs is still needed on FreeBSD, DragonflyBSD and NetBSD? Either Mesa is missing this code, or libdrm doesn't need it anymore. This patch itself is Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > Signed-off-by: Jonathan Gr

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support v4

On Monday, 2018-02-19 11:20:37 +, Eric Engestrom wrote: > On Friday, 2018-02-16 14:27:03 -0600, Alexander von Gluck IV wrote: > > --- > > include/meson.build| 8 + > > meson.build| 16 +++--- >

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support v4

copy, modify, merge, publish, distribute, sublicense, and/or sell > +# copies of the Software, and to permit persons to whom the Software is > +# furnished to do so, subject to the following conditions: > + > +# The above copyright notice and this permission notice shall be inclu

[Mesa-dev] [PATCH mesa v2] egl/wayland: check for invalid format index

v2: just tell the compiler to assume the format will always be found, as it comes from the table itself to begin with. CID: 1429516 Fixes: d32b23f3830099a328b91 "egl/wayland: Add bpp to visual map" Cc: Daniel Stone <dani...@collabora.com> Signed-off-by: Eric Engestrom <eric.e

Re: [Mesa-dev] [PATCH mesa] egl/wayland: check for invalid format index

On Thursday, 2018-02-15 11:25:33 +, Daniel Stone wrote: > Hi Eric, > > On 15 February 2018 at 11:17, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > Daniel, `w` seemed like the "least bad" thing to return in this case; > > would you prefer

[Mesa-dev] [PATCH mesa] egl/wayland: check for invalid format index

CID: 1429516 Fixes: d32b23f3830099a328b91 "egl/wayland: Add bpp to visual map" Cc: Daniel Stone <dani...@collabora.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Daniel, `w` seemed like the "least bad" thing to return in this case; would you

[Mesa-dev] [PATCH mesa] glsl: fix sizeof(pointer) bug

Doesn't really change anything to the test though ¯\_(ツ)_/¯ CID: 1429511 Fixes: e8495646afb06a9dd7786 "glsl/tests: changes to test_disk_cache_create test" Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/compiler/glsl/tests/cache_test.c | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH 07/15] util/bitset: Add C++ wrapper for static-size bitsets.

On Wednesday, 2018-02-14 13:18:29 -0800, Francisco Jerez wrote: > --- > src/util/bitset.h | 114 > ++ > 1 file changed, 114 insertions(+) > > diff --git a/src/util/bitset.h b/src/util/bitset.h > index 2404ce7f630..7bb5f3c83cf 100644 > ---

Re: [Mesa-dev] [PATCH mesa] dri: use a supported API in driCreateNewContext

On Wednesday, 2018-02-14 09:06:41 -0500, Ilia Mirkin wrote: > On Feb 14, 2018 7:38 AM, "Eric Engestrom" <eric.engest...@imgtec.com> wrote: > > From: Brendan King <brendan.k...@imgtec.com> > > Don't assume the screen supports OpenGL when creating a new

[Mesa-dev] [PATCH mesa] dri: use a supported API in driCreateNewContext

From: Brendan King <brendan.k...@imgtec.com> Don't assume the screen supports OpenGL when creating a new context, use an API that the screen supports. Signed-off-by: Brendan King <brendan.k...@imgtec.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> [Eric: rebased o

Re: [Mesa-dev] [PATCH 07/21] vulkan: Add EXT_acquire_xlib_display

_CPPFLAGS += \ > VULKAN_WSI_SOURCES += $(VULKAN_WSI_DISPLAY_FILES) > endif > > +if HAVE_XLIB_LEASE > +AM_CPPFLAGS += \ > + -DVK_USE_PLATFORM_XLIB_XRANDR_EXT > +endif > + > BUILT_SOURCES += $(VULKAN_WSI_WAYLAND_GENERATED_FILES) > CLEANFILES = $(BUILT_SOURC

Re: [Mesa-dev] [PATCH] mesa: add missing switch case for EXTRA_VERSION_40 in check_extra()

ms required by GL_ARB_sample_shading" Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/mesa/main/get.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c > index 2188017..57a2118 100644 > --- a/src/

Re: [Mesa-dev] [PATCH v4 02/12] meson: add libswdri and libswkmsdri tolink_with unconditionally

t;[files('description.c', 'getproc.c', 'drm.c'), xmlpool_options_h], > > @@ -60,8 +53,8 @@ libgallium_nine = shared_library( > >link_depends : gallium_nine_link_depends, > >link_with : [ > > libgalliumvl_stub, libgallium, libnine_st, libmesa_util, libddebug,

Re: [Mesa-dev] [PATCH 09/17] spirv: Silence compiler warning about undefined srcs[0]

On Monday, 2018-02-12 13:52:23 -0800, Ian Romanick wrote: > On 02/10/2018 08:33 AM, Eric Anholt wrote: > > It doesn't know that elems >= 1. > > Does adding assume(elems >= 1) help? Indeed, I was going to reply this too; I think a number of "let's always initialise to shut the compiler up"

Re: [Mesa-dev] [PATCH 08/17] loader: Fix compiler warnings about truncating the PCI ID path.

an avoid this careful calculation by just using asprintf (as we do > elsewhere in the file). > > Cc: Eric Engestrom <eric.engest...@imgtec.com> That is indeed better, thanks! Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/loader/loader.c | 15 +++

Re: [Mesa-dev] How to know which exact llvm version to build/link against?

On Tuesday, 2018-02-13 01:44:53 -0800, Andrew A. wrote: > On Wed, Feb 7, 2018 at 1:37 AM, Michel Dänzer wrote: > > For a non-current snapshot of Mesa Git master, one may have to find an > > LLVM SVN snapshot from around the same time. > > Just so I understand, a statement

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

On Friday, 2018-02-09 20:45:10 -0800, Keith Packard wrote: > This adds support for the KHR_display extension to the anv and radv > Vulkan drivers. The drivers now attempt to open the master DRM node > when the KHR_display extension is requested so that the common winsys > code can perform the

Re: [Mesa-dev] [PATCH] i965: perf: ensure reading config IDs from sysfs isn't interrupted

g> The Fixes: tag with a commit which is in 18.0 already nominates it for backporting to that branch, you don't need to manually Cc: 18.0 :) Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/mesa/drivers/dri/i965/brw_performance_query.c | 3 ++- > 1 file changed, 2

Re: [Mesa-dev] [PATCH demos 4/4] egl: Install eglinfo binary

Yes please :) Btw, I already pointed out 2/4 during its review, I guess Brian forgot to fix it :P Series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > src/egl/opengl/Makefile.am | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/s

[Mesa-dev] [PATCH mesa] r200: remove left over dead code

0aaa27f29187ffb739c7 removed the references to this array without removing the array itself Cc: Ian Romanick <ian.d.roman...@intel.com> Fixes: 0aaa27f29187ffb739c7 "mesa: Pass the translated color logic op dd_function_table::LogicOpcode" Signed-off-by: Eric Engestrom <eric.e

Re: [Mesa-dev] [PATCH 01/18] egl/wayland: Fix ARGB/XRGB transposition in config map

his is harmless. > > Signed-off-by: Daniel Stone <dani...@collabora.com> > Fixes: 0b2b7191214eb ("egl/wayland: introduce > dri2_wl_add_configs_for_visuals() helper") > Cc: Emil Velikov <emil.veli...@collabora.com> > Cc: Eric Engestrom <e...@engestrom.ch>

Re: [Mesa-dev] [PATCH] meson: Add build option for tools

s about to say that, good thing I read the replies first :) > With that: > > Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH kmscube] formats: use weston's egl config matching logic, move format defines up

config_index = 0; > + > + if (config_index == -1) > + config_index = match_config_to_visual(egl->display, > + visual_id, > + configs, > +

Re: [Mesa-dev] [PATCH] glxinfo/wglinfo: query/print more GL limits

On Wednesday, 2018-02-07 10:23:06 -0700, Brian Paul wrote: > On 02/07/2018 10:12 AM, Eric Engestrom wrote: > > On Wednesday, 2018-02-07 08:48:06 -0700, Brian Paul wrote: > > > Query/print limits for GL 3.0 through GL 4.6, plus > > > GL_ARB_transform_feedback3. Also, p

Re: [Mesa-dev] [PATCH] glxinfo/wglinfo: query/print more GL limits

On Wednesday, 2018-02-07 08:48:06 -0700, Brian Paul wrote: > Query/print limits for GL 3.0 through GL 4.6, plus > GL_ARB_transform_feedback3. Also, print the GL extension or GL version > for each set of queries to make it more readable. > --- > src/xdemos/glinfo_common.c | 127 >

Re: [Mesa-dev] [PATCH 1/2] mesa: simplify _mesa_get_compressed_formats()

; > + formats[n++] = GL_COMPRESSED_SRGB8_ALPHA8_ASTC_4x3x3_OES; > + formats[n++] = GL_COMPRESSED_SRGB8_ALPHA8_ASTC_4x4x3_OES; > + formats[n++] = GL_COMPRESSED_SRGB8_ALPHA8_ASTC_4x4x4_OES; > + formats[n++] = GL_COMPRESSED_SRGB8_ALPHA8_ASTC_5x4x4_OES; > +

Re: [Mesa-dev] [PATCH] meson: ensure xmlpool/options.h is generated for libgallium

> See also 26bde1e3. > > Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/gallium/targets/dri/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/

Re: [Mesa-dev] [PATCH] radeonsi: set indent_size in .editorconfig

On Sunday, 2018-02-04 00:19:33 +0200, Grazvydas Ignotas wrote: > At least with vim, this is needed to actually get tab instead of > 3 spaces after hitting the tab key. Are you sure? The doc [1] says: > indent_size: > [...] > When set to tab, the value of tab_width (if specified) will be used.

Re: [Mesa-dev] [PATCH 3/6] glx/apple: include util/debug.h for env_var_as_boolean prototype

uot; Fixes: 5c68ea29f31283768c8e1 "egl+glx: turn LIBGL_ALWAYS_SOFTWARE into a boolean" Fixes: 43e2d58698f76b96b36ff "glx: turn LIBGL_ALLOW_SOFTWARE into a boolean" Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/glx/apple/apple_visual.c | 1 +

Re: [Mesa-dev] [PATCH] meson: don't install windows headers on non-windowsplatforms

On Thursday, 2018-02-01 15:29:25 +0100, Marc Dietrich wrote: > Am Donnerstag, 1. Februar 2018, 15:07:55 CET schrieb Eric Engestrom: > > On Thursday, 2018-02-01 13:27:28 +0100, Marc Dietrich wrote: > > > Only dive into the windows subdir if windows platform is selected. >

Re: [Mesa-dev] [PATCH] meson: don't install windows headers on non-windows platforms

w; we got lucky :P Fixes: 5ef75cb02b2b4db5506b8 "meson: build src/glx/windows" Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Do you have commit access? > --- > src/glx/meson.build | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --g

[Mesa-dev] [PATCH mesa] gallium/util: used designated initialisers in formats table

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- v2: I missed a few lines in v1 for some reason; converted as well --- src/gallium/auxiliary/util/u_format_table.py | 108 ++- 1 file changed, 55 insertions(+), 53 deletions(-) diff --git a/src/gallium/aux

[Mesa-dev] [PATCH mesa 1/2] radv: used designated initialisers in formats table

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/amd/vulkan/vk_format_table.py | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/amd/vulkan/vk_format_table.py b/src/amd/vulkan/vk_format_table.py index 36352b108d0b52

<    5   6   7   8   9   10   11   12   13   14   >