[Mesa-dev] [PATCH 0/7] timestamp/arch directory removal for disk_cache

2017-03-12 Thread Grazvydas Ignotas
hash it in too, if it's how others want it to be. This series should also solve bug 100091. Grazvydas Ignotas (7): util/mesa-sha1: add a context clone function util/mesa-sha1: allow to finish without taking the result util/disk_cache: use a helper to compute cache keys util/disk_

[Mesa-dev] [PATCH 2/7] util/mesa-sha1: allow to finish without taking the result

2017-03-12 Thread Grazvydas Ignotas
Useful if we just want to free the context, in error paths for example. Signed-off-by: Grazvydas Ignotas --- src/util/mesa-sha1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/mesa-sha1.c b/src/util/mesa-sha1.c index 2c47465..66be707 100644 --- a/src/util/mesa

[Mesa-dev] [PATCH 3/7] util/disk_cache: use a helper to compute cache keys

2017-03-12 Thread Grazvydas Ignotas
This will allow to hash additional data into the cache keys or even change the hashing algorithm easily, should we decide to do so. Signed-off-by: Grazvydas Ignotas --- src/compiler/glsl/glsl_parser_extras.cpp| 2 +- src/compiler/glsl/shader_cache.cpp | 2 +- src/compiler

Re: [Mesa-dev] [PATCH] i965: Delete render ring prelude.

2017-03-12 Thread Grazvydas Ignotas
It seems this has not removed enough and introduced a warning: intel_batchbuffer.c: In function ‘intel_batchbuffer_require_space’: intel_batchbuffer.c:132:22: warning: unused variable ‘prev_ring’ [-Wunused-variable] enum brw_gpu_ring prev_ring = brw->batch.ring; Gražvydas On Wed, Mar 8, 2017

Re: [Mesa-dev] [PATCH] anv: Stall before fast-clear operations

2017-03-11 Thread Grazvydas Ignotas
On Sat, Mar 11, 2017 at 9:04 AM, Jason Ekstrand wrote: > During initial CCS bring-up, I discovered that you have to do a full CS > stall prior to doing a CCS resolve as well as afterwards. It appears > that the same is needed for fast-clears as well. This fixes rendering > corruptions on The Tal

Re: [Mesa-dev] [PATCH 4/8] util/disk_cache: make disk_cache_put() compatible with u_queue

2017-03-10 Thread Grazvydas Ignotas
On Fri, Mar 10, 2017 at 4:28 AM, Timothy Arceri wrote: > --- > src/compiler/glsl/shader_cache.cpp | 5 - > src/compiler/glsl/tests/cache_test.c| 29 > - > src/gallium/drivers/radeonsi/si_state_shaders.c | 9 ++-- > src/mesa/state_tracker

Re: [Mesa-dev] [PATCH 1/3] util/disk_cache: use LRU eviction rather than random eviction (v2)

2017-03-10 Thread Grazvydas Ignotas
On Fri, Mar 10, 2017 at 6:23 AM, Timothy Arceri wrote: > On 07/03/17 12:25, Alan Swanson wrote: >> >> Still using random selection of two-character subdirectory in which >> to check cache files rather than scanning entire cache. >> >> v2: Factor out double strlen call >> --- >> src/util/disk_cach

[Mesa-dev] [PATCH 1/2] util/disk_cache: fix compressed size calculation

2017-03-08 Thread Grazvydas Ignotas
It incorrectly doubles the size on each iteration. Fixes: 85a9b1b5 "util/disk_cache: compress individual cache entries" Signed-off-by: Grazvydas Ignotas --- src/util/disk_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/disk_cache.c b/src/util/di

[Mesa-dev] [PATCH 2/2] util/disk_cache: fix size subtraction on 32bit

2017-03-08 Thread Grazvydas Ignotas
Negating size_t on 32bit produces a 32bit result. This was effectively adding values close to UINT_MAX to the cache size (the files are usually small) instead of intended subtraction. Fixes 'make check' disk_cache failures on 32bit. Signed-off-by: Grazvydas Ignotas --- src/util/disk_c

Re: [Mesa-dev] [PATCH] glsl/blob: clear padding bytes

2017-03-08 Thread Grazvydas Ignotas
(CCing some people who touched or reviewed blob) Ping. I think writing stale heap contents to cache should be avoided and this patch is an improvement. Gražvydas On Fri, Mar 3, 2017 at 1:59 AM, Grazvydas Ignotas wrote: > Since blob is intended for serializing data, it's not a good

Re: [Mesa-dev] [PATCH] glx: allow 0 for glXSwapIntervalSGI

2017-03-08 Thread Grazvydas Ignotas
On Wed, Mar 8, 2017 at 4:37 AM, Ian Romanick wrote: > On 03/07/2017 05:09 PM, Grazvydas Ignotas wrote: >> Makes vsync option work in The Talos Principle. > > NAK. The GLX_SGI_swap_control spec says: > > glXSwapIntervalSGI returns GLX_BAD_VALUE if parameter is >

[Mesa-dev] [PATCH] glx: allow 0 for glXSwapIntervalSGI

2017-03-07 Thread Grazvydas Ignotas
Makes vsync option work in The Talos Principle. Signed-off-by: Grazvydas Ignotas --- no commit access perhaps this is stable worthy? src/glx/glxcmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 53c9f9c..7be4e73 100644 --- a

Re: [Mesa-dev] [PATCH 2/3] util/disk_cache: actually enforce cache size

2017-03-06 Thread Grazvydas Ignotas
This seems to break "make check", so needs to update tests I guess. Gražvydas On Mon, Mar 6, 2017 at 6:17 PM, Alan Swanson wrote: > Currently only a one in one out eviction so if at max_size and > cache files were to constantly increase in size then so would the > cache. Restrict to limit of 8 e

Re: [Mesa-dev] [PATCH 1/3] util/disc_cache: use LRU eviction rather than random eviction

2017-03-06 Thread Grazvydas Ignotas
; > - > - count++; > + if (fstatat(dirfd(dir), entry->d_name, &sb, 0) == 0) { > + if (!lru_atime || (sb.st_atime < lru_atime)) { > +tmp = realloc(lru_name, strlen(entry->d_name) + 1); > +if (tmp) { > + lru_name = tmp; > +

Re: [Mesa-dev] [PATCH 3/4] radv: check for upload alloc failure

2017-03-05 Thread Grazvydas Ignotas
On Mon, Mar 6, 2017 at 12:05 AM, Bas Nieuwenhuizen wrote: > On Sun, Mar 5, 2017 at 10:04 PM, Grazvydas Ignotas wrote: >> Mainly to avoid gcc's complains about uninitialized ptr and offset use >> later in that code. >> >> Signed-off-by: Grazvydas Ig

Re: [Mesa-dev] [PATCH] util/disk_cache: don't require 64bit atomic operations

2017-03-05 Thread Grazvydas Ignotas
On Sun, Mar 5, 2017 at 10:29 PM, Matt Turner wrote: > On Sun, Mar 5, 2017 at 11:14 AM, Grazvydas Ignotas wrote: >> There are still some distributions trying to support unfortunate people >> with old or exotic CPUs that don't have 64bit atomic operations. Missing >&g

[Mesa-dev] [PATCH v2] i965: don't require 64bit cmpxchg

2017-03-05 Thread Grazvydas Ignotas
e, as suggested by Matt Turner Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93089 Signed-off-by: Grazvydas Ignotas --- no commit access src/intel/common/gen_debug.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_debug.c b/src/

[Mesa-dev] [PATCH 4/4] radv: use VK_NULL_HANDLE for handles

2017-03-05 Thread Grazvydas Ignotas
Avoids warnings on 32bit. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_meta_bufimage.c | 8 src/amd/vulkan/radv_wsi.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_meta_bufimage.c b/src/amd/vulkan/radv_meta_bufimage.c

[Mesa-dev] [PATCH 2/4] radv: don't use uninitialized value on failure

2017-03-05 Thread Grazvydas Ignotas
Mainly to avoid a warning. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_descriptor_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c index ca5b280..7dade3e 100644 --- a/src/amd

[Mesa-dev] [PATCH 3/4] radv: check for upload alloc failure

2017-03-05 Thread Grazvydas Ignotas
Mainly to avoid gcc's complains about uninitialized ptr and offset use later in that code. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_cmd_buffer.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/v

[Mesa-dev] [PATCH 0/4] Make radv warning-free again

2017-03-05 Thread Grazvydas Ignotas
Please push if these are ok. Grazvydas Ignotas (4): radv: avoid casting warnings on 32bit radv: don't use uninitialized value on failure radv: check for upload alloc failure radv: use VK_NULL_HANDLE for handles src/amd/vulkan/radv_cmd_buffer.c | 7 --- src/amd/v

[Mesa-dev] [PATCH 1/4] radv: avoid casting warnings on 32bit

2017-03-05 Thread Grazvydas Ignotas
Use the same helpers as for other handle<->pointer conversions. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_device.c | 5 ++--- src/amd/vulkan/radv_private.h | 3 +++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/

[Mesa-dev] [PATCH] util/disk_cache: mark read-only arguments const

2017-03-05 Thread Grazvydas Ignotas
No functional changes. Signed-off-by: Grazvydas Ignotas --- no commit access src/util/disk_cache.c | 35 ++- src/util/disk_cache.h | 20 ++-- 2 files changed, 28 insertions(+), 27 deletions(-) diff --git a/src/util/disk_cache.c b/src/util

[Mesa-dev] [PATCH] util/disk_cache: don't require 64bit atomic operations

2017-03-05 Thread Grazvydas Ignotas
zilla: https://bugs.freedesktop.org/show_bug.cgi?id=93089 Signed-off-by: Grazvydas Ignotas --- no commit access src/util/disk_cache.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 4a8ee21..daa5c7b 100644 ---

[Mesa-dev] [PATCH] i965: don't require 64bit cmpxchg

2017-03-05 Thread Grazvydas Ignotas
ly by multiple threads that somehow manage to change the environment variable without affecting each other, so just provide a thread-unsafe fallback. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93089 Signed-off-by: Grazvydas Ignotas --- no commit access src/intel/common/gen_debug.

Re: [Mesa-dev] [PATCH V3] util/disk_cache: support caches for multiple architectures

2017-03-04 Thread Grazvydas Ignotas
ggestion from Emil to make even more generic/fix issue > with __ILP32__ not being declared on gcc for regular 32-bit builds. Now it works, launching steam (32bit) no longer wipes all cache from 64bit games, everything works as expected. Tested-by: Grazv

Re: [Mesa-dev] [PATCH V2] util/disk_cache: support caches for multiple architectures

2017-03-04 Thread Grazvydas Ignotas
On Sat, Mar 4, 2017 at 4:44 PM, Emil Velikov wrote: > On 3 March 2017 at 23:37, Timothy Arceri wrote: >> >> I'm tempted to just push this: >> https://patchwork.freedesktop.org/patch/141891/ >> >> And worry about issues later if that's not good enough. >> > Can we use anything like the following a

[Mesa-dev] [PATCH] ralloc: don't leave out the alignment factor

2017-03-03 Thread Grazvydas Ignotas
lways specify a suitable alignment factor. Cc: Jonas Pfeil Fixes: cd2b55e5 "ralloc: Make sure ralloc() allocations match malloc()'s alignment." Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100049 Signed-off-by: Grazvydas Ignotas --- no commit access src/util/ralloc.c | 4

Re: [Mesa-dev] [PATCH V2] util/disk_cache: support caches for multiple architectures

2017-03-03 Thread Grazvydas Ignotas
On Fri, Mar 3, 2017 at 5:27 AM, Timothy Arceri wrote: > Previously we were deleting the entire cache if a user switched > between 32 and 64 bit applications. > > V2: make the check more generic, it should now work with any > platform we are likely to support. > --- > src/util/disk_cache.c | 19 ++

[Mesa-dev] [PATCH] glsl/blob: clear padding bytes

2017-03-02 Thread Grazvydas Ignotas
Since blob is intended for serializing data, it's not a good idea to leave padding holes with uninitialized data, which may leak heap contents and hurt compression if the blob is later compressed, like done by shader cache. Clear it. Signed-off-by: Grazvydas Ignotas --- I don't kno

[Mesa-dev] [PATCH] tgsi/ureg: return correct token count in ureg_get_tokens

2017-03-02 Thread Grazvydas Ignotas
regressions elsewhere because the only ureg_get_tokens() user that cares about token count is the shader cache. Cc: Timothy Arceri Signed-off-by: Grazvydas Ignotas --- no commit access src/gallium/auxiliary/tgsi/tgsi_ureg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

Re: [Mesa-dev] [PATCH 1/2] util/disk_cache: support caches for multiple architectures

2017-03-02 Thread Grazvydas Ignotas
On Thu, Mar 2, 2017 at 8:36 AM, Timothy Arceri wrote: > > > On 02/03/17 17:17, Ilia Mirkin wrote: >> >> On Thu, Mar 2, 2017 at 1:08 AM, Timothy Arceri >> wrote: >>> >>> Previously we were deleting the entire cache if a user switched >>> between 32 and 64 bit applications. >>> --- >>> src/util/di

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

2017-03-01 Thread Grazvydas Ignotas
On Wed, Mar 1, 2017 at 7:25 AM, Timothy Arceri wrote: > ... > diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c > index 2a0edca..03aae02 100644 > --- a/src/util/disk_cache.c > +++ b/src/util/disk_cache.c > @@ -30,20 +30,21 @@ > #include > #include > #include > #include > #include

Re: [Mesa-dev] [PATCH 1/4] util/disk_cache: add support for detecting corrupt cache entries

2017-03-01 Thread Grazvydas Ignotas
On Wed, Mar 1, 2017 at 7:25 AM, Timothy Arceri wrote: > --- > src/util/disk_cache.c | 37 ++--- > 1 file changed, 34 insertions(+), 3 deletions(-) > > diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c > index f5e1145..2a0edca 100644 > --- a/src/util/disk_c

[Mesa-dev] [PATCH 1/2] gallium/u_queue: fix a crash with atexit handlers

2017-02-25 Thread Grazvydas Ignotas
ns. Fixes: 4aea8fe "gallium/u_queue: fix random crashes when the app calls exit()" Signed-off-by: Grazvydas Ignotas --- no commit access src/gallium/auxiliary/util/u_queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/util/u_queue.c b/src/gallium/auxi

[Mesa-dev] [PATCH 2/2] gallium/u_queue: set num_threads correctly if not all threads start

2017-02-25 Thread Grazvydas Ignotas
If i-th thread could not be created it means we have i threads, not i+1, because we start from 0. Fixes: 404d0d5 "gallium/u_queue: add an option to have multiple worker threads" Signed-off-by: Grazvydas Ignotas --- no commit access src/gallium/auxiliary/util/u_queue.c | 2 +- 1 file

Re: [Mesa-dev] [PATCH 1/8] util/disk_cache: fix bug with deleting old cache dirs

2017-02-22 Thread Grazvydas Ignotas
On Wed, Feb 22, 2017 at 5:45 AM, Timothy Arceri wrote: > If there was more than a single directory in the .cache/mesa dir > then it would only remove one (or none) of the directories. > > Apparently Valgrind was also reporting: > Conditional jump or move depends on uninitialised value uninitialis

Re: [Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

2017-02-20 Thread Grazvydas Ignotas
So, as there are no better solutions in sight, can somebody please push this patch? Gražvydas On Wed, Feb 15, 2017 at 5:33 AM, Alex Deucher wrote: > On Tue, Feb 14, 2017 at 10:27 PM, Michel Dänzer wrote: >> On 14/02/17 08:25 PM, Marek Olšák wrote: >>> I've changed my mind. The patch can be merg

Re: [Mesa-dev] [PATCH 1/2] util: Add helpers for iterating over Vulkan extension structs

2017-02-15 Thread Grazvydas Ignotas
On Wed, Feb 15, 2017 at 2:03 AM, Jason Ekstrand wrote: > --- > src/util/Makefile.sources | 3 ++- > src/util/vk_util.h| 43 +++ > 2 files changed, 45 insertions(+), 1 deletion(-) > create mode 100644 src/util/vk_util.h > > diff --git a/src/util/Ma

Re: [Mesa-dev] Query with respect to support of x32

2017-02-14 Thread Grazvydas Ignotas
On Tue, Feb 14, 2017 at 3:12 PM, Haridasan, Sujith wrote: > I am using mesa 12.0.1 from yocto project > (http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-graphics/mesa/mesa_12.0.1.bb?h=morty). > While building core-image-sato ( which is the graphical image ), I found > that Qt5 exa

Re: [Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

2017-02-13 Thread Grazvydas Ignotas
On Mon, Feb 13, 2017 at 10:22 AM, Michel Dänzer wrote: > On 13/02/17 05:17 PM, Michel Dänzer wrote: >> On 11/02/17 08:01 AM, Grazvydas Ignotas wrote: >>> They cause regressions on little endian. >>> >>> Fixes: 172bfdaa9e ("r300g: add support for PIP

Re: [Mesa-dev] [PATCH 3/4] gallium/radeon: add a HUD query for monitoring the CS thread activity

2017-02-11 Thread Grazvydas Ignotas
On Sat, Feb 11, 2017 at 9:58 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/r600_query.c | 25 > ++- > src/gallium/drivers/radeon/r600_query.h | 1 + > src/gallium/drivers/radeon/radeon_winsys.h| 1 + > src/galli

[Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

2017-02-10 Thread Grazvydas Ignotas
They cause regressions on little endian. Fixes: 172bfdaa9e ("r300g: add support for PIPE_FORMAT_x8R8G8B8_*") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98869 Signed-off-by: Grazvydas Ignotas --- no commit access src/gallium/drivers/r300/r300_texture.c | 5 + 1 file

Re: [Mesa-dev] [PATCH] util/disk_cache: stop using ralloc_asprintf() unnecessarily

2017-02-09 Thread Grazvydas Ignotas
On Thu, Feb 9, 2017 at 12:06 AM, Timothy Arceri wrote: > --- > src/util/disk_cache.c | 25 - > 1 file changed, 12 insertions(+), 13 deletions(-) > > diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c > index 7691621..edfff73 100644 > --- a/src/util/disk_cache.c > +

[Mesa-dev] [PATCH] radv: don't resubmit the same cs over and over while tracing

2017-01-23 Thread Grazvydas Ignotas
Fixes: 97dfff54 ("radv: Dump command buffer on hang.") Signed-off-by: Grazvydas Ignotas --- no commit access src/amd/vulkan/radv_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index d27a66

[Mesa-dev] [PATCH] anv: remove some unused macros and functions

2017-01-13 Thread Grazvydas Ignotas
VK_ICD_WSI_PLATFORM_MAX is used, but a duplicate from wsi_common.h . Signed-off-by: Grazvydas Ignotas --- no commit access requested by Emil: https://lists.freedesktop.org/archives/mesa-dev/2017-January/140733.html src/intel/vulkan/anv_private.h | 15 --- src/intel/vulkan

Re: [Mesa-dev] [PATCH] gallium: add Tegra renderonly support

2017-01-13 Thread Grazvydas Ignotas
Hi, just out of the interest, can this be used on Tegra X1 right now? If so, what would I need to get it to work (kernel, firmware, something else)? I'd be interested to run mesa on the Shield TV. Gražvydas On Fri, Jan 13, 2017 at 9:47 AM, Alexandre Courbot wrote: > From: Christian Gmeiner > >

Re: [Mesa-dev] [PATCH] ac/debug: move .gitignore for sid_tables.h too

2017-01-12 Thread Grazvydas Ignotas
On Thu, Jan 12, 2017 at 12:26 PM, Nicolai Hähnle wrote: > On 12.01.2017 00:58, Grazvydas Ignotas wrote: >> >> b838f642 "ac/debug: Move sid_tables.h generation to common code." moved >> sid_tables.h but forgot the corresponding .gitignore. >> >> Sig

Re: [Mesa-dev] [PATCH] mapi: update the asm code to support x32

2017-01-12 Thread Grazvydas Ignotas
As the branchpoint is near, can someone push it, please? Gražvydas On Sun, Jan 8, 2017 at 11:22 PM, Matt Turner wrote: > On Sun, Jan 8, 2017 at 9:38 AM, Grazvydas Ignotas wrote: >> Fixes crashes when both glx-tls and asm are enabled on x32. >> >> Cc: mesa-sta...@

[Mesa-dev] [PATCH] ac/debug: move .gitignore for sid_tables.h too

2017-01-11 Thread Grazvydas Ignotas
b838f642 "ac/debug: Move sid_tables.h generation to common code." moved sid_tables.h but forgot the corresponding .gitignore. Signed-off-by: Grazvydas Ignotas --- no commit access src/amd/common/.gitignore | 1 + src/gallium/drivers/radeonsi/.gitignore | 1 - 2 files

Re: [Mesa-dev] [PATCH] radeonsi: handle big number of immediates dynamically

2017-01-11 Thread Grazvydas Ignotas
On Tue, Jan 10, 2017 at 7:33 PM, Samuel Pitoiset wrote: > diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c > b/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c > index 3e0f7c4f76..3cd87f2f66 100644 > --- a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c > +++ b/src/gallium/

[Mesa-dev] [PATCH v2] radv: remove some unused macros and functions

2017-01-10 Thread Grazvydas Ignotas
These seem unlikely to be used. Also remove irrelevant comment about SKL. v2: forgot to rebase on master Signed-off-by: Grazvydas Ignotas --- no commit access src/amd/vulkan/radv_private.h | 15 +-- src/amd/vulkan/radv_util.c| 19 --- 2 files changed, 1

[Mesa-dev] [PATCH] radv: remove some unused macros and functions

2017-01-10 Thread Grazvydas Ignotas
These seem unlikely to be used. Also remove irrelevant comment about SKL. Signed-off-by: Grazvydas Ignotas --- no commit access src/amd/vulkan/radv_private.h | 15 +-- src/amd/vulkan/radv_util.c| 19 --- 2 files changed, 1 insertion(+), 33 deletions(-) diff

Re: [Mesa-dev] [PATCH 06/10] amd/common: unify cube map coordinate handling between radeonsi and radv

2017-01-10 Thread Grazvydas Ignotas
Unfortunately this one breaks at least (surprise!) texturecubemap SaschaWillemsVulkan demo. I recommend you try it yourself, there are even precompiled binaries available (see README.md): https://github.com/SaschaWillems/Vulkan Gražvydas On Tue, Jan 10, 2017 at 5:12 PM, Nicolai Hähnle wrote: > F

[Mesa-dev] [PATCH] mapi: update the asm code to support x32

2017-01-08 Thread Grazvydas Ignotas
Fixes crashes when both glx-tls and asm are enabled on x32. Cc: mesa-sta...@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94512 Signed-off-by: Grazvydas Ignotas --- no commit access, please push src/mapi/entry_x86-64_tls.h | 31 --- 1

Re: [Mesa-dev] [PATCH 11/12] glcpp: Create fast path hand-written scanner

2017-01-08 Thread Grazvydas Ignotas
On Sun, Jan 8, 2017 at 4:11 PM, Grazvydas Ignotas wrote: > On Sat, Jan 7, 2017 at 9:02 PM, Vladislav Egorov wrote: >> @@ -582,6 +609,333 @@ HEXADECIMAL_INTEGER 0[xX][0-9a-fA-F]+[uU]? >> >> %% >> >> +static void >> +glcpp_fast_skip_singleline_commen

Re: [Mesa-dev] [PATCH 11/12] glcpp: Create fast path hand-written scanner

2017-01-08 Thread Grazvydas Ignotas
On Sat, Jan 7, 2017 at 9:02 PM, Vladislav Egorov wrote: > @@ -582,6 +609,333 @@ HEXADECIMAL_INTEGER 0[xX][0-9a-fA-F]+[uU]? > > %% > > +static void > +glcpp_fast_skip_singleline_comment (glcpp_parser_t *parser, char **input) > +{ > + /* Skip // */ > + char *buf = *input + 2; > + > + wh

Re: [Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-08 Thread Grazvydas Ignotas
On Sun, Jan 8, 2017 at 4:05 PM, Grazvydas Ignotas wrote: > On Sat, Jan 7, 2017 at 9:02 PM, Vladislav Egorov wrote: >> +* >> +* Check for INT_MAX for the only reason that utility > > "... only for the only reason that ..." sounds b

Re: [Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-08 Thread Grazvydas Ignotas
Some spelling suggestions, since you seem to be doing another version of these patches: On Sat, Jan 7, 2017 at 9:02 PM, Vladislav Egorov wrote: > glcpp's printing is an obvious low hanging fruit: > > 1. It unnecessarily uses formatted printing to print output of >preprocessing. To print just

Re: [Mesa-dev] [PATCH v2] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-23 Thread Grazvydas Ignotas
On Thu, Dec 22, 2016 at 11:54 PM, Jason Ekstrand wrote: > This sequence shows up The Talos Principal, at least under Vulkan, Not really important, except maybe when looking for patches affecting the game, but I've noticed you keep calling it "Principal", while the game is "The Talos Principle".

[Mesa-dev] [PATCH v2] i965: fix release build unused variable warning

2016-12-11 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- v2: take Eduardo Lima's suggestion further - remove the variable completely no commit access src/mesa/drivers/dri/i965/brw_blorp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src

[Mesa-dev] [PATCH 1/2] vulkan: deduplicate the util code

2016-12-11 Thread Grazvydas Ignotas
anv_util.c and radv_util.c are essentially duplicates, so create a new vk_util.c to be shared by both vulkan drivers. Some other content from anv_private.h and radv_private.h was moved to vk_util.h too. Signed-off-by: Grazvydas Ignotas --- no commit access configure.ac

[Mesa-dev] [PATCH 2/2] vulkan: fix 'statement with no effect' warning

2016-12-11 Thread Grazvydas Ignotas
Emitted on release build in case vk_error() return is not used. Signed-off-by: Grazvydas Ignotas --- no commit access src/vulkan/vk_util.c | 4 src/vulkan/vk_util.h | 13 - 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/vulkan/vk_util.c b/src/vulkan

[Mesa-dev] [PATCH] i965: fix release build unused variable warning

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- src/mesa/drivers/dri/i965/brw_blorp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 4c1d858..8b5750c 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH] softpipe: fix release build unused variable warning

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/gallium/drivers/softpipe/sp_state_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_state_shader.c b/src/gallium/drivers/softpipe/sp_state_shader.c index

[Mesa-dev] [PATCH] intel/aubinator: fix 32bit shift overflow warning

2016-12-10 Thread Grazvydas Ignotas
Doesn't look like this can work on 32bit, just rids of annoying warning. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/intel/tools/aubinator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/

[Mesa-dev] [PATCH] anv: fix release build unused variable warnings

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/intel/vulkan/anv_blorp.c | 3 ++- src/intel/vulkan/genX_cmd_buffer.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index

[Mesa-dev] [PATCH 3/3] radv/ac: some fix maybe-uninitialized warnings

2016-12-10 Thread Grazvydas Ignotas
Mark some paths unreachable so that compiler knows variables are initialized in all valid paths. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/amd/common/ac_nir_to_llvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/common

[Mesa-dev] [PATCH] radeonsi: fix release build unused variable warnings

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/gallium/drivers/radeonsi/si_blit.c | 2 +- src/gallium/drivers/radeonsi/si_state.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium

[Mesa-dev] [PATCH 1/3] radv: fix release build unused variable warnings

2016-12-10 Thread Grazvydas Ignotas
Just mark with MAYBE_UNUSED. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/amd/vulkan/radv_cmd_buffer.c | 34 ++ src/amd/vulkan/radv_query.c | 6 +++--- 2 files changed, 21 insertions(+), 19 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 2/3] radv/meta: use VK_NULL_HANDLE for handles

2016-12-10 Thread Grazvydas Ignotas
Otherwise we get 32bit warnings because handle is plain uint64_t there and NULL is not suited to initialize that. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/amd/vulkan/radv_meta_blit2d.c | 2 +- src/amd/vulkan/radv_meta_bufimage.c | 2 +- src/amd

Re: [Mesa-dev] [PATCH] radv: Suffix the intel_icd file with the host CPU

2016-11-09 Thread Grazvydas Ignotas
On Wed, Nov 9, 2016 at 8:11 PM, Emil Velikov wrote: > From: Emil Velikov > > Port of the anv commit d96345de989 ("anv: Suffix the intel_icd file with > the host CPU"). I guess the subject of this patch should say radeon_icd instead of intel_icd. Gražvydas ___

Re: [Mesa-dev] [PATCH] radeonsi: emit TA_CS_BC_BASE_ADDR on SI only if the kernel allows it

2016-10-11 Thread Grazvydas Ignotas
On Mon, Oct 10, 2016 at 2:25 PM, Marek Olšák wrote: > From: Marek Olšák > > The kernel patch has been sent to amd-gfx. > --- > src/gallium/drivers/radeonsi/si_compute.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_compute.c > b/s

Re: [Mesa-dev] [PATCH 1/4] amd/common: add nir->llvm translation.

2016-10-04 Thread Grazvydas Ignotas
On Tue, Oct 4, 2016 at 1:09 PM, Nicolai Hähnle wrote: > On 04.10.2016 03:48, Dave Airlie wrote: > > [snip] >> >> diff --git a/src/amd/common/ac_llvm_helper.cpp >> b/src/amd/common/ac_llvm_helper.cpp >> new file mode 100644 >> index 000..feafdaf >> --- /dev/null >> +++ b/src/amd/common/ac_llvm_

Re: [Mesa-dev] [PATCH 1/5] i965: wrap assert param in #ifndef NDEBUG

2016-10-04 Thread Grazvydas Ignotas
On Tue, Oct 4, 2016 at 3:15 AM, Timothy Arceri wrote: > This fixes an unused variable warning on release builds. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 1/3] gallium/os: add os_get_process_cmd_line

2016-07-30 Thread Grazvydas Ignotas
On Sat, Jul 30, 2016 at 6:22 PM, Marek Olšák wrote: > From: Marek Olšák > > for debugging > --- > src/gallium/auxiliary/os/os_process.c | 37 > +++ > src/gallium/auxiliary/os/os_process.h | 2 ++ > 2 files changed, 39 insertions(+) > > diff --git a/src/gallium/a

Re: [Mesa-dev] [PATCH] gallium/os: use CLOCK_MONOTONIC for sleeps

2016-07-18 Thread Grazvydas Ignotas
On Mon, Jul 18, 2016 at 3:14 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/auxiliary/os/os_time.c | 15 +-- > src/gallium/auxiliary/os/os_time.h | 4 > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/src/gallium/auxiliary/os/os_time.c > b/

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

2016-07-16 Thread Grazvydas Ignotas
On Sat, Jul 16, 2016 at 2:00 AM, Marek Olšák wrote: > On Wed, Jul 13, 2016 at 10:50 AM, Vedran Miletić wrote: >> On 07/13/2016 05:19 AM, Timothy Arceri wrote: >>> >>> So I finally got around to setting up my new polaris card on fedora. I >>> was curious to see how Talos performed compared to i965

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

2016-07-13 Thread Grazvydas Ignotas
On Wed, Jul 13, 2016 at 2:56 AM, Timothy Arceri wrote: > On Sat, 2016-07-09 at 20:21 +0300, Grazvydas Ignotas wrote: >> >> I think I still have some more: >> - running 32bit program after 64bit version of the same thing (or >> vice >> versa) leads to segfaults and

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add a workaround for a compute VGPR-usage LLVM bug

2016-07-13 Thread Grazvydas Ignotas
On Tue, Jul 12, 2016 at 11:52 PM, Marek Olšák wrote: > From: Marek Olšák > > This patch may be dropped depending on feedback. > > Cc: 12.0 > --- > src/gallium/drivers/radeonsi/si_shader.c | 33 > > 1 file changed, 33 insertions(+) > > diff --git a/src/gallium/d

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

2016-07-09 Thread Grazvydas Ignotas
On Sat, Jul 9, 2016 at 6:49 PM, Marek Olšák wrote: > On Fri, Jul 8, 2016 at 3:20 AM, Timothy Arceri > wrote: >> On Wed, 2016-06-29 at 18:32 +0200, Marek Olšák wrote: >>> Hi, >>> >>> This series implements basic multithreaded LLVM shader compilation >>> in a minimally invasive way. (+51 lines of c

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

2016-07-09 Thread Grazvydas Ignotas
On Sat, Jul 9, 2016 at 10:02 AM, Timothy Arceri wrote: > On Fri, 2016-07-01 at 14:12 +1000, Timothy Arceri wrote: >> On Thu, 2016-06-30 at 00:59 +0300, Grazvydas Ignotas wrote: >> > On Wed, Jun 29, 2016 at 3:11 PM, Timothy Arceri >> > wrote: >> > > On We

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

2016-06-29 Thread Grazvydas Ignotas
On Wed, Jun 29, 2016 at 3:11 PM, Timothy Arceri wrote: > On Wed, 2016-06-29 at 03:47 +0300, Grazvydas Ignotas wrote: >> On Tue, Jun 28, 2016 at 10:53 AM, Timothy Arceri >> wrote: >> > On Mon, 2016-06-27 at 00:46 +1000, Timothy Arceri wrote: >> > > On Sun,

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

2016-06-28 Thread Grazvydas Ignotas
On Tue, Jun 28, 2016 at 10:53 AM, Timothy Arceri wrote: > On Mon, 2016-06-27 at 00:46 +1000, Timothy Arceri wrote: >> On Sun, 2016-06-26 at 16:15 +0300, Grazvydas Ignotas wrote: >> > Tried this while playing with apitrace and am getting segfaults >> > when >>

[Mesa-dev] [PATCH] doc: improve INTEL_DEBUG documentation

2016-06-27 Thread Grazvydas Ignotas
Remove 'reg' option that does not actually exist, elaborate more about 'sync' and add the missing options. Signed-off-by: Grazvydas Ignotas --- no commit access, if this is ok please somebody push docs/envvars.html | 12 ++-- 1 file changed, 10 insertions(+),

Re: [Mesa-dev] [Piglit] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

2016-06-26 Thread Grazvydas Ignotas
On Sat, Jun 25, 2016 at 4:54 PM, Alejandro Piñeiro wrote: > In theory they don't overdrawn. The test has a square formed by N > non-overlapping triangles. With just one call to glDrawRangeElements, > this always works. But if we split it in M subsets, so M calls to > glDrawRangeElements with N/M t

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

2016-06-26 Thread Grazvydas Ignotas
Tried this while playing with apitrace and am getting segfaults when running any trace with a cached (second) run. Not sure if it's "wrong" traces I've chosen or what, you can take one example from this bug: https://bugs.freedesktop.org/show_bug.cgi?id=96425 It would also be good idea to hide the

Re: [Mesa-dev] [PATCH 7/9] anv/pipeline: Silently pass tests if depth or stencil is missing

2016-06-02 Thread Grazvydas Ignotas
On Thu, Jun 2, 2016 at 12:44 AM, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > Cc: "12.0" > Cc: Ian Romanick > --- > src/intel/vulkan/gen7_pipeline.c | 12 ++-- > src/intel/vulkan/gen8_pipeline.c | 12 ++-- > src/intel/vulkan/genX_pipeline_util.h | 30 ++

Re: [Mesa-dev] [PATCH 00/10] R600: Cache flush fixes and cleanup v2

2016-06-01 Thread Grazvydas Ignotas
On Wed, Jun 1, 2016 at 9:57 PM, Marek Olšák wrote: > Hi, > > This is version 2 of the previous series. This time it's been tested!! > > Tested cards: > - RV670 > - RV730 > - EG/REDWOOD > - CAYMAN All good on JUNIPER now (piglit and a few random games). Tested-by:

Re: [Mesa-dev] [PATCH 2/2] i965: Add norbc debug option

2016-05-31 Thread Grazvydas Ignotas
On Tue, May 31, 2016 at 5:16 PM, Topi Pohjolainen wrote: > This INTEL_DEBUG option disables lossless compression (also known > as render buffer compression). > > Suggested-by: Eero Tamminen > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_debug.c | 1 + > src/mesa

Re: [Mesa-dev] [PATCH 2/2] automake: bring back the .PHONY git_sha1.h.tmp rule

2016-05-31 Thread Grazvydas Ignotas
ed to ensure that the header is regenerated when on each > make invocation, while the latter helps us avoid the unneeded rebuild(s) > when the SHA1 hasn't changed. > > Cc: Grazvydas Ignotas > Reported-by: Grazvydas Ignotas > Signed-off-by: Emil Velikov > --- > And the br

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

2016-05-30 Thread Grazvydas Ignotas
On Tue, May 31, 2016 at 2:58 AM, Grazvydas Ignotas wrote: > I've patched the CS validator and there seem to be some regressions: > > arb_map_buffer_range 11/11 5/11 > copybuffersubdata decrement-offset > copybuffersubdata increment-offset > copybuffersubdata offset=0 >

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

2016-05-30 Thread Grazvydas Ignotas
nch is based on, don't know if it has any effect. Should I attempt to bisect? Gražvydas On Tue, May 31, 2016 at 1:30 AM, Marek Olšák wrote: > On Tue, May 31, 2016 at 12:17 AM, Grazvydas Ignotas wrote: >> I've tried it on AMD JUNIPER (DRM 2.43.0 / 4.6.0) and it does not pa

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

2016-05-30 Thread Grazvydas Ignotas
I've tried it on AMD JUNIPER (DRM 2.43.0 / 4.6.0) and it does not pass the kernel CS validator with [drm:evergreen_packet3_check.isra.14 [radeon]] *ERROR* Packet3 opcode 42 not supported printed many times. I guess it needs some kernel patch? I haven't found anything relevant in Alex's kernel git.

Re: [Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

2016-05-30 Thread Grazvydas Ignotas
On Mon, May 30, 2016 at 3:46 PM, Emil Velikov wrote: > From: Emil Velikov > > As we'll need the file in the release tarball, rework the rule so that > the file is regenerated _only_ if we're in a git repository. > > With this in place we can build vulkan (anv) from a release tarball. After this

Re: [Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

2016-04-17 Thread Grazvydas Ignotas
On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov wrote: > On 16 April 2016 at 02:00, Grazvydas Ignotas wrote: >> This is mostly for variables that are only used in asserts and cause >> unused-but-set-variable warnings in release builds. Could just use >> UNUSED directly, but M

[Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

2016-04-15 Thread Grazvydas Ignotas
on both GCC 4.2 (oldest supported by mesa) and clang 3.0 (just some random old version, nut sure what's the minimum for mesa). Signed-off-by: Grazvydas Ignotas --- I have no commit access, if this patch is ok, please someone push. src/util/macros.h | 2 ++ 1 file changed, 2 insertions(+)

[Mesa-dev] [PATCH 3/7] gallium: fix warnings in release build

2016-04-15 Thread Grazvydas Ignotas
Mark variables MAYBE_UNUSED to avoid unused-but-set-variable warnings in release build. Signed-off-by: Grazvydas Ignotas --- I have no commit access, if this patch is ok, please someone push. src/gallium/auxiliary/pipebuffer/pb_buffer_fenced.c | 2 +- src/gallium/auxiliary/util/u_surface.c

[Mesa-dev] [PATCH 6/7] anv: fix warnings in release build

2016-04-15 Thread Grazvydas Ignotas
Mark variables MAYBE_UNUSED to avoid unused-but-set-variable warnings in release build. Signed-off-by: Grazvydas Ignotas --- I have no commit access, if this patch is ok, please someone push. src/intel/vulkan/anv_dump.c | 2 +- src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 0/7] release build warning fixes

2016-04-15 Thread Grazvydas Ignotas
I guess almost everyone here builds mesa with asserts enabled, but many forget asserts are off by default, so ordinary users get thrown at quite a lot of warnings. This tries to improve the situation somewhat. Grazvydas Ignotas (7): util: add MAYBE_UNUSED for config dependent variables glsl

<    1   2   3   4   >