Re: [Mesa-dev] [PATCH 2/2] radv: ignore inline uniform blocks in radv_CmdPushDescriptorSetKHR()

On Tue, Jun 11, 2019 at 12:19 PM Samuel Iglesias Gonsálvez wrote: > Right, it should be detected by the Validation Layers. However it is > arguable what to do in the driver's side. We can just keep it as it is > now, ignore inline uniform block updates (this patch) or even add an > assert if it

Re: [Mesa-dev] [PATCH 2/2] radv: ignore inline uniform blocks in radv_CmdPushDescriptorSetKHR()

On Tue, Jun 11, 2019 at 11:57 AM Samuel Iglesias Gonsálvez wrote: > > According to the Vulkan spec, uniform blocks are not allowed to be > updated through vkCmdPushDescriptorSetKHR(). > > There are these spec quotes from "13.2.1. Descriptor Set Layout" > that are relevant for this case: > >

[Mesa-dev] [PATCH] radv: clear vertex bindings while resetting command buffer

Only vertex inputs accessed by vertex shader must have valid buffers bound. Signed-off-by: Józef Kucia --- src/amd/vulkan/radv_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

Re: [Mesa-dev] [PATCH] mesa: Fix GL_NUM_DEVICE_UUIDS_EXT

On Thu, Mar 21, 2019 at 1:24 PM Tapani Pälli wrote: > Yeah, checked that value matches of find_value_indexed; > > Reviewed-by: Tapani Pälli I don't have commits rights. Please push the patch for me. > Does this affect 'ext_semaphore-api-errors' Piglit test that calls this > in any way? No.

Re: [Mesa-dev] [PATCH] mesa: Fix GL_NUM_DEVICE_UUIDS_EXT

On Tue, Mar 12, 2019 at 4:11 PM Józef Kucia wrote: > src/mesa/main/get.c | 3 +++ > 1 file changed, 3 insertions(+) Ping. The patch fixes glGetIntegerv(GL_NUM_DEVICE_UUIDS_EXT, ...). GL_NUM_DEVICE_UUIDS_EXT is implemented in the same way in find_value_i

[Mesa-dev] [PATCH] mesa: Fix GL_NUM_DEVICE_UUIDS_EXT

Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/get.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index ee77c45d03c1..efc9c11f79d3 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -906,6 +906,9 @@ find_custom_value(struct

[Mesa-dev] [PATCH] radv: Fix driverUUID

--- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 83d218fb6bf0..6deb69d22d48 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -337,7 +337,7 @@

Re: [Mesa-dev] [PATCH] anv: flush pipeline before query result copies

On Thu, Nov 29, 2018 at 5:25 PM Lionel Landwerlin wrote: > Pretty easy. > > Fetch http://source.winehq.org/git/vkd3d.git > > Usual autotool compilation. > > make tests/d3d12 > > I commented the tests I wasn't interested in for to make it easier and using > vktrace to understand what's going on.

Re: [Mesa-dev] [PATCH] nir: Fix assert in print_intrinsic_instr().

On Mon, Nov 26, 2018 at 4:23 PM Lionel Landwerlin wrote: > > On 26/11/2018 15:04, Józef Kucia wrote: > > Signed-off-by: Józef Kucia > > > Reviewed-by: Lionel Landwerlin > > Please push the patch for me. I don't have commit access. _

Re: [Mesa-dev] [PATCH] anv: flush pipeline before query result copies

On Thu, Nov 29, 2018 at 4:43 PM Lionel Landwerlin wrote: > > Pipeline barriers inserted through vkCmdPipelineBarrier() should be > taken into account when copying results. > > In the particular bug below, the results of the > vkCmdCopyQueryPoolResults() command was being overwritten by the >

[Mesa-dev] [PATCH] nir: Fix assert in print_intrinsic_instr().

Signed-off-by: Józef Kucia --- src/compiler/nir/nir_print.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c index e20c28fec874..9ecb2a7c54e6 100644 --- a/src/compiler/nir/nir_print.c +++ b/src/compiler/nir

Re: [Mesa-dev] [PATCH] radv: fix resetting the pool for timestamp queries

p.org/show_bug.cgi?id=108164 > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_query.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) Thanks! Tested-by: Józef Kucia ___ mesa-dev mailing list mesa-d

Re: [Mesa-dev] [PATCH] nir/alu_to_scalar: Use ssa_for_alu_src in hand-rolled expansions

_lower_alu_to_scalar.c | 33 -- > 1 file changed, 18 insertions(+), 15 deletions(-) Fixes a regression I've noticed in one of our D3D12 to Vulkan translation samples. Thanks! Tested-by: Józef Kucia ___ mesa-dev mailing list mesa-d

[Mesa-dev] [PATCH] radeonsi: avoid sending GS_EMIT in shaders without outputs

Fixes GPU hangs. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107857 Signed-off-by: Józef Kucia --- src/gallium/drivers/radeonsi/si_shader.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

On Fri, Sep 7, 2018 at 6:44 PM Ilia Mirkin wrote: > > On Fri, Sep 7, 2018 at 12:35 PM, Józef Kucia wrote: > > On Fri, Sep 7, 2018 at 4:42 PM Danylo Piliaiev > > wrote: > > > >> @@ -1546,8 +1548,8 @@ update_image_surface(struct brw_context *brw, &

Re: [Mesa-dev] [PATCH] i965: Fix calculation of layers array length for isl_view

On Fri, Sep 7, 2018 at 4:42 PM Danylo Piliaiev wrote: > @@ -1546,8 +1548,8 @@ update_image_surface(struct brw_context *brw, > .format = format, > .base_level = obj->MinLevel + u->Level, > .levels = 1, > -.base_array_layer = obj->MinLayer +

Re: [Mesa-dev] [PATCH] radv: advertise 8 bits of subpixel precision for viewports

On Wed, Apr 11, 2018 at 10:38 AM, Samuel Pitoiset wrote: > Agreed. > > Reviewed-by: Samuel Pitoiset Please push the patch for me. I don't have commit access. ___ mesa-dev mailing list

[Mesa-dev] [PATCH] radv: advertise 8 bits of subpixel precision for viewports

This is what radeonsi does. --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 4fc7392e65e6..35b686ab7f02 100644 --- a/src/amd/vulkan/radv_device.c +++

Re: [Mesa-dev] [PATCH 1/2] radv: remove one invalid case in radv_tex_dim()

On Wed, Feb 21, 2018 at 3:27 PM, Samuel Pitoiset wrote: > According to "Table 1. Image and image view parameter compatibility > requirements", this is invalid. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_image.c | 5 +

Re: [Mesa-dev] [PATCH] radv: set no-signed-zeros-fp-math

On Wed, Jan 10, 2018 at 10:31 PM, Samuel Pitoiset wrote: > + LLVMAddTargetDependentFunctionAttr(main_function, > + "no-signed-zeros-fp-math", > + "true"); > + Is this option safe to

Re: [Mesa-dev] [PATCH 00/17] anv: Rework state tracking to better separate

ssions: Tested-by: Józef Kucia <joseph.ku...@gmail.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radeonsi: fix alpha-to-coverage if color writes are disabled

If alpha-to-coverage is enabled, we have to compute alpha even if color writes are disabled. Signed-off-by: Józef Kucia <joseph.ku...@gmail.com> --- Found while running The Witness under Wine. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 5 - 1 file changed, 4 insertions

[Mesa-dev] [PATCH] anv: Do not assert() on VK_ATTACHMENT_UNUSED

--- src/intel/vulkan/genX_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 93d360a1bb..43437c8eb0 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++

[Mesa-dev] [PATCH] spirv: Fix SpvOpAtomicISub

Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/spirv/spirv_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 8fe379e4e0..079ff0fe95 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++

Re: [Mesa-dev] [PATCH 1/2] anv: Fix vkCmdFillBuffer()

e the change, when the fill value is 0xabcdef buffers are filled with 0xcdefcdef or 0xefefefef. > > > On 02/10/17 18:58, Józef Kucia wrote: >> >> The vkCmdFillBuffer() command fills a buffer with an uint32_t value. >> --- >> src/intel/vulkan/anv_blorp.c | 4 ++-- >

[Mesa-dev] [PATCH 2/2] anv: Remove unreachable cases from isl_format_for_size()

The dstOffset and fillSize parameters must be multiple of 4. --- src/intel/vulkan/anv_blorp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index a8ebdb384c..8dead1d87a 100644 --- a/src/intel/vulkan/anv_blorp.c +++

[Mesa-dev] [PATCH 1/2] anv: Fix vkCmdFillBuffer()

The vkCmdFillBuffer() command fills a buffer with an uint32_t value. --- src/intel/vulkan/anv_blorp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 8d0c275248..a8ebdb384c 100644 ---

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv: Fix descriptors copying

On Wed, Sep 20, 2017 at 12:55 PM, Juan A. Suarez Romero wrote: > On Sat, 2017-09-16 at 08:56 -0700, Jason Ekstrand wrote: >> Oh, and >> >> Reviewed-by: Jason Ekstrand >> >> > > Józef, are you pushing this patch? It is not in master yet, and it > would

[Mesa-dev] [PATCH] anv: Fix descriptors copying

Trivial. Cc: mesa-sta...@lists.freedesktop.org --- I do not have commit access. --- src/intel/vulkan/anv_descriptor_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index

Re: [Mesa-dev] [PATCH] radv: fix possible GPU hangs by zeroing the descriptor set

On Fri, Sep 8, 2017 at 2:43 PM, Samuel Pitoiset wrote: > when an application doesn't update the contents of a descriptor > set object, it contains random values and this might end up with > GPU VM faults if a shader tries to access that descriptor. > > The Vulkan spec

Re: [Mesa-dev] [RFC] st/mesa: Add both front and back buffers for double-buffer visuals

On Wed, Jan 18, 2017 at 2:25 AM, Boyan Ding wrote: > I don't think I find that. The only place in state tracker where > _mesa_add_renderbuffer is called is st_framebuffer_create and only one > of the front and back buffers is allocated based on the default > behavior. When

Re: [Mesa-dev] [PATCH] main: allow NEAREST_MIPMAP_NEAREST for stencil texturing

s well, hoping there aren't any crazy tests which want to see an error > there... (Compile tested only.) > > Reported by Józef Kucia <joseph.ku...@gmail.com> > --- > src/mesa/main/texobj.h | 23 --- > 1 file changed, 8 insertions(+), 15 del

[Mesa-dev] GL_DEPTH_STENCIL_TEXTURE_MODE and filter type

ing DEPTH_STENCIL_TEXTURE_MODE? Or was this change meant to be just for STENCIL_INDEX textures? Is there are a reason why NEAREST_MIPMAP_NEAREST cannot also be used with depth stencil textures and DEPTH_STENCIL_TEXTURE_MODE? Is this just an inconsistency in the GL spec? Cheers, Józef Kucia __

[Mesa-dev] [PATCH] nvc0: advertise 8 bits subpixel precision for viewport bounds

Based on subpixel precision returned by the blob. Signed-off-by: Józef Kucia <joseph.ku...@gmail.com> --- I've checked that the blob returns 8 for the following GPUs: GeForce GTX 460 (GF104), GeForce GTX 760 (GK104), GeForce GTX 970 (GM204). Generally, I expect that 8 bits precision

Re: [Mesa-dev] [PATCH RFC 5/8] gm107/ir: add emission for SUSTx and SULDx

On Mon, Jul 18, 2016 at 10:55 PM, Samuel Pitoiset wrote: > + } else if (insn->tex.target == TEX_TARGET_2D_ARRAY || > + insn->tex.target == TEX_TARGET_CUBE || > + insn->tex.target == TEX_TARGET_CUBE_ARRAY) { > + target = 8; > + } else

[Mesa-dev] [PATCH 1/3] gallium: add a cap for VIEWPORT_SUBPIXEL_BITS (v2)

This allows Gallium drivers to advertise the subpixel precision for floating point viewports bounds. v2: - Set ViewportSubpixelBits in st_init_limits. Signed-off-by: Józef Kucia <joseph.ku...@gmail.com> --- Currently all Mesa drivers return 0 for GL_VIEWPORT_SUBPIXEL_BITS regardless w

[Mesa-dev] [PATCH 3/3] radeonsi: advertise 8 bits subpixel precision for viewport bounds

Signed-off-by: Józef Kucia <joseph.ku...@gmail.com> --- src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 768dc8c..6a496c2 100644 --- a/src/g

[Mesa-dev] [PATCH 2/3] r600: advertise 8 bits subpixel precision for viewport bounds

Signed-off-by: Józef Kucia <joseph.ku...@gmail.com> --- src/gallium/drivers/r600/r600_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 6bd027b..a3b6189 100644 --- a/src/gallium/d

Re: [Mesa-dev] [PATCH] gallium: add a cap for VIEWPORT_SUBPIXEL_BITS

On Mon, Jul 18, 2016 at 1:35 PM, Marek Olšák wrote: > FWIW, r600 and radeonsi should return 8. > > Marek Thanks, I'll send patches. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] gallium: add a cap for VIEWPORT_SUBPIXEL_BITS

On Sat, Jul 16, 2016 at 11:51 PM, Ilia Mirkin wrote: > Of course none of this actually changes backends to return > 0 bits... > did you mean to follow up with further patches? Yes, I wanted to try to change GL_VIEWPORT_SUBPIXEL_BITS at least for some drivers (r600,

[Mesa-dev] [PATCH] gallium: add a cap for VIEWPORT_SUBPIXEL_BITS

This allows Gallium drivers to advertise the subpixel precision for floating point viewports bounds. Signed-off-by: Józef Kucia <joseph.ku...@gmail.com> --- Currently all Mesa drivers return 0 for GL_VIEWPORT_SUBPIXEL_BITS regardless whether floating point viewport bounds are supported.