Re: [Mesa-dev] Trying to build a opencl dev env

2021-04-27 Thread Jan Vesely
On Tue, Apr 27, 2021 at 7:50 AM Luke A. Guest wrote: > > > On 27/04/2021 08:00, Pierre Moreau wrote: > > Hello Luke, > > > > If you set `PKG_CONFIG_PATH=$PATH_TO_LIBCLC_INSTALL/share/pkgconfig` when > > running meson, it should pick that version instead of the system one. > > > > I run it as

Re: [Mesa-dev] clover's interface to clang

2020-11-15 Thread Jan Vesely
On Thu, 2020-11-12 at 06:37 +1000, Dave Airlie wrote: > On Thu, 12 Nov 2020 at 06:23, Francisco Jerez wrote: > > I don't remember the specifics of why we ended up interfacing with Clang > > this way. What is technically wrong with it, specifically? I don't > > have any objection to switching to

Re: [Mesa-dev] [clover] Compilation of latest 'libclc git' with LLVM 11.0.0git need ROCm?! - Didn't hit that ever before.

2020-04-16 Thread Jan Vesely
On Wed, 2020-04-15 at 06:31 +0200, Dieter Nützel wrote: > Am 15.04.2020 05:50, schrieb Jan Vesely: > > On Wed, 2020-04-15 at 05:40 +0200, Dieter Nützel wrote: > > > Addendum > > > > > > I'm building LLVM git (llvm + SPIRV-LLVM-Translator) for X86;AMDGPU >

Re: [Mesa-dev] [clover] Compilation of latest 'libclc git' with LLVM 11.0.0git need ROCm?! - Didn't hit that ever before.

2020-04-14 Thread Jan Vesely
On Wed, 2020-04-15 at 05:40 +0200, Dieter Nützel wrote: > Addendum > > I'm building LLVM git (llvm + SPIRV-LLVM-Translator) for X86;AMDGPU like > this: there's nothing wrong with your build. rocm libs are required by clang when it targets amdgcn--amdhsa target. Unless you know that you want

[Mesa-dev] [PATCH] clover: Fix build after llvm 1dfede3122eec

2019-11-14 Thread Jan Vesely
CodeGenFileType enum was moved to Support/CodeGen.h Signed-off-by: Jan Vesely --- Tested by building and running CLOVER_DEBUG=llvm,native clinfo using both llvm-git (10) and llvm-9 .../state_trackers/clover/llvm/codegen/native.cpp| 10 -- src/gallium/state_trackers/clover/llvm

Re: [Mesa-dev] [PATCH] radeonsi: Bump number of allowed global buffers to 48 (again, for clover Blender assertion)

2019-08-08 Thread Jan Vesely
shared pool to accommodate global buffers). cl global buffers are created in cl context so I think there shouldn't be too much trouble moving it to the driver equivalent of that. Jan > > Marek > > On Tue, Aug 6, 2019 at 10:50 PM Dieter Nützel wrote: > > > Am 20.06.201

Re: [Mesa-dev] [PATCH v2] clover: Fix build after clang r367864

2019-08-06 Thread Jan Vesely
g 6, 2019 at 12:59 PM Jan Vesely wrote: > > v2: Drop special case of llvm-9 > > Signed-off-by: Jan Vesely > > --- > > src/gallium/state_trackers/clover/llvm/compat.hpp | 10 -- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --gi

[Mesa-dev] [PATCH v2] clover: Fix build after clang r367864

2019-08-06 Thread Jan Vesely
v2: Drop special case of llvm-9 Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/compat.hpp | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/compat.hpp b/src/gallium/state_trackers/clover/llvm/compat.hpp

[Mesa-dev] [PATCH] clover: Fix build after clang r367864

2019-08-06 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/compat.hpp | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/compat.hpp b/src/gallium/state_trackers/clover/llvm/compat.hpp index 0ecf622a9af..b273abf75af

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] amd: Apply elf relocations and allow code with relocations

2019-06-20 Thread Jan Vesely
On Sat, 2019-06-15 at 07:38 +0200, Dieter Nützel wrote: > Am 14.06.2019 08:13, schrieb Jan Vesely: > > On Thu, 2019-06-13 at 21:20 +0200, Dieter Nützel wrote: > > > Am 13.06.2019 07:10, schrieb Marek Olšák: > > > > FYI, I just pushed the new linker. > > >

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] amd: Apply elf relocations and allow code with relocations

2019-06-14 Thread Jan Vesely
finished in 2.08s. > > blender: ../src/gallium/drivers/radeonsi/si_compute.c:319: > si_set_global_binding: Assertion `first + n <= MAX_GLOBAL_BUFFERS' > failed. > > [1]Abbruch blender (core dumped) The number of max global buffers was bumped in 06bf567

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] amd: Apply elf relocations and allow code with relocations

2019-06-13 Thread Jan Vesely
On Thu, 2019-06-13 at 01:10 -0400, Marek Olšák wrote: > FYI, I just pushed the new linker. thanks. I've checked the handling and the current approach works for sections as well (even if not handled explicitly). Jan > > Marek > > On Mon, Jun 3, 2019 at 10:39 PM Jan Vesely wrot

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] amd: Add relocation type and relocation target type to reloc structure

2019-06-03 Thread Jan Vesely
nes to patch that in. is there an ETA for the linker series? Jan > > Marek > > On Mon, Jun 3, 2019 at 10:39 PM Jan Vesely wrote: > > > Cc: mesa-sta...@lists.freedesktop.org > > Signed-off-by: Jan Vesely > > --- > > src/amd/common/ac_binary.c | 2 ++ > >

[Mesa-dev] [PATCH 2/3] amd: Check return value from ac_elf_read

2019-06-03 Thread Jan Vesely
Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Jan Vesely --- src/gallium/drivers/radeonsi/si_compute.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 51da06fe550

[Mesa-dev] [PATCH 1/3] amd: Add relocation type and relocation target type to reloc structure

2019-06-03 Thread Jan Vesely
Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Jan Vesely --- src/amd/common/ac_binary.c | 2 ++ src/amd/common/ac_binary.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/amd/common/ac_binary.c b/src/amd/common/ac_binary.c index 8f4755ebe16..18dc72c61f0 100644 --- a/src/amd

[Mesa-dev] [PATCH 3/3] amd: Apply elf relocations and allow code with relocations

2019-06-03 Thread Jan Vesely
Fixes piglits: call.cl calls-larget-struct.cl calls-struct.cl calls-workitem-id.cl realign-stack.cl tail-calls.cl Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Jan Vesely --- The piglit test now pass using llvm-7,8,git. ImageMagick works

Re: [Mesa-dev] Error: unsupported relocations

2019-06-02 Thread Jan Vesely
On Mon, 2019-06-03 at 11:12 +1000, Dave Airlie wrote: > On Mon, 3 Jun 2019 at 10:58, Jan Vesely wrote: > > On Sun, 2019-06-02 at 20:09 -0400, James Harvey wrote: > > > I've started a thread on the llvm mailing list. See > > > https://nam02.safelinks.protection.

Re: [Mesa-dev] Error: unsupported relocations

2019-06-02 Thread Jan Vesely
taking the LLVM fix. I've started looking, but the elf structure lists relocations against a section (STT_SECTION), so I still don't know where to get target address. Jan > > On Sat, Jun 1, 2019 at 10:56 PM Jan Vesely wrote: > > Hi, > > > > On Sat, 2019-06-01 at 18:21

Re: [Mesa-dev] Error: unsupported relocations

2019-06-02 Thread Jan Vesely
On Mon, 2019-06-03 at 09:14 +1000, Dave Airlie wrote: > On Mon, 3 Jun 2019 at 09:13, Dave Airlie wrote: > > On Sun, 2 Jun 2019 at 23:13, Jan Vesely wrote: > > > On Sun, 2019-06-02 at 07:17 -0400, James Harvey wrote: > > > > On Sun, Jun 2, 2019 at 7:01 AM Ba

Re: [Mesa-dev] Error: unsupported relocations

2019-06-02 Thread Jan Vesely
s. something like 'OCD_ICD_VENDORS=/var/empty' (any directory other than /etc/OpenCL/vendors will do) effectively disables OpenCL by reporting 0 available platforms. Jan -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Error: unsupported relocations

2019-06-01 Thread Jan Vesely
contributions and needs are inferior to corporate stakeholders (not even worth CI cycles). thus, clover on amd gpus is in damage mitigation mode; errors are better than crashes, crashes are better than hangs. Chances are that clover over NIR will work before the current issues are fixed. regards,

Re: [Mesa-dev] [PATCH] radeonsi: fix timestamp queries for compute-only contexts

2019-05-27 Thread Jan Vesely
assert(16 * ctx->screen->info.num_render_backends <= > scratch->b.b.width0); > radeon_emit(cs, PKT3(PKT3_EVENT_WRITE, 2, 0)); > radeon_emit(cs, EVENT_TYPE(EVENT_TYPE_ZPASS_DONE

Re: [Mesa-dev] [PATCH] radeonsi: allow query functions for compute-only contexts

2019-05-20 Thread Jan Vesely
On Mon, May 13, 2019 at 6:40 PM Marek Olšák wrote: > > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_pipe.c | 2 +- > src/gallium/drivers/radeonsi/si_query.c | 7 --- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_pipe.c >

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-05-16 Thread Jan Vesely
nly process compute flags. */ > + flags &= SI_CONTEXT_INV_ICACHE | > + SI_CONTEXT_INV_SMEM_L1 | > + SI_CONTEXT_INV_VMEM_L1 | > + SI_CONTEXT_INV_GLOBAL_L2 | > + SI_CONTEXT_WRITEBACK_GLO

Re: [Mesa-dev] [PATCH] gallium/aux: Report error if loading of a pipe driver fails.

2019-04-10 Thread Jan Vesely
On Wed, Apr 10, 2019 at 9:33 PM Marek Olšák wrote: > > Reviewed-by: Marek Olšák thank you. pushed. Jan > > Marek > > On Wed, Apr 3, 2019 at 2:02 AM Jan Vesely wrote: >> >> Skip over non-existent files. >> Signed-off-by: Jan Vesely >> --- >>

Re: [Mesa-dev] [PATCH] Partially revert "gallium: fix autotools build of pipe_msm.la"

2019-04-10 Thread Jan Vesely
On Tue, Apr 9, 2019 at 5:36 PM Vinson Lee wrote: > > On Tue, Apr 9, 2019 at 1:29 PM Jan Vesely wrote: > > > > On Sat, Apr 6, 2019 at 10:11 PM Dieter Nützel wrote: > > > > > > Tested-by: Dieter Nützel > > > Acked-by: Dieter Nützel > > &

Re: [Mesa-dev] [PATCH] gallium/aux: Report error if loading of a pipe driver fails.

2019-04-09 Thread Jan Vesely
On Wed, Apr 3, 2019 at 2:02 AM Jan Vesely wrote: > > Skip over non-existent files. > Signed-off-by: Jan Vesely > --- > This should help detect instances of messed up/missing symbols in the driver. > windows build seems OK: > https://ci.appveyor.com/project/jvesely/mesa/

Re: [Mesa-dev] [PATCH] Partially revert "gallium: fix autotools build of pipe_msm.la"

2019-04-09 Thread Jan Vesely
rs. > > Dieter > > Am 06.04.2019 06:43, schrieb Jan Vesely: > > This partially reverts commit 356ec7a21960d77db282f67af577dcdb46966b5a. > > There are missing symbols needed by libglsl, so we might as well skip > > the entire library (which should be present in the me

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-04-09 Thread Jan Vesely
>>>> On Mon, Apr 1, 2019 at 1:28 PM Jan Vesely > >>> wrote: > >>>>> On Mon, 2019-04-01 at 12:30 -0400, Marek Olšák wrote: > >>>>>> Does the attached patch fix the copy-buffer test? > >>>>> > >>>>&

Re: [Mesa-dev] gitlab: Let's delete a buildsystem

2019-04-08 Thread Jan Vesely
Hi, is there a release with that change planned any time soon? thanks, Jan On Mon, Apr 8, 2019 at 4:23 PM Dylan Baker wrote: > > As per the discussion last time around, the last feature meson needed to grow > to > be able to remove autotools was support for remembering PKG_CONFIG_PATH, since

[Mesa-dev] [PATCH] Partially revert "gallium: fix autotools build of pipe_msm.la"

2019-04-05 Thread Jan Vesely
This partially reverts commit 356ec7a21960d77db282f67af577dcdb46966b5a. There are missing symbols needed by libglsl, so we might as well skip the entire library (which should be present in the mesa stat tracker). Signed-off-by: Jan Vesely --- Hi Timur, Vinson, this patch is enough to get

[Mesa-dev] [PATCH] gallium/aux: Report error if loading of a pipe driver fails.

2019-04-03 Thread Jan Vesely
Skip over non-existent files. Signed-off-by: Jan Vesely --- This should help detect instances of messed up/missing symbols in the driver. windows build seems OK: https://ci.appveyor.com/project/jvesely/mesa/builds/23550498#L1292 .../auxiliary/pipe-loader/pipe_loader.c | 5 +- src/gallium

Re: [Mesa-dev] [PATCH] radeonsi: don't use PFP_SYNC_ME with compute-only contexts

2019-04-02 Thread Jan Vesely
On Mon, 2019-04-01 at 18:37 -0400, Marek Olšák wrote: > From: Marek Olšák Tested-by: Jan Vesely Can you add a note along the lines; "compute rings don't have PFP" or anything more descriptive on the commit message? thanks, Jan > > Fixes: a1378639ab1 "radeonsi:

Re: [Mesa-dev] Commit 'gallium: fix autotools build of pipe_msm.la' broke Clover - bisected

2019-04-02 Thread Jan Vesely
On Tue, 2019-04-02 at 02:37 +0200, Dieter Nützel wrote: > Am 01.04.2019 07:43, schrieb Jan Vesely: > > Hi, > > > > On Mon, 2019-04-01 at 06:24 +0200, Dieter Nützel wrote: > > > Hello, > > > > > > commit #356ec7a2196 'gallium: fix autotools

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-04-01 Thread Jan Vesely
nks, Jan > > Thanks, > Marek > > On Sat, Mar 2, 2019 at 10:58 PM Jan Vesely wrote: > > > On Thu, 2019-02-28 at 17:48 -0500, Marek Olšák wrote: > > > On Thu, Feb 28, 2019 at 4:44 AM Jan Vesely > > wrote: > > > > On Tue, 2019-02-26 at 18:34 -

Re: [Mesa-dev] Commit 'gallium: fix autotools build of pipe_msm.la' broke Clover - bisected

2019-03-31 Thread Jan Vesely
gallium-xvmc=false > -Dgallium-omx=disabled -Dgallium-xa=false > > Only -Dgallium-opencl=disabled works. > > Thanks, > Dieter > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedes

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-03-02 Thread Jan Vesely
On Thu, 2019-02-28 at 17:48 -0500, Marek Olšák wrote: > On Thu, Feb 28, 2019 at 4:44 AM Jan Vesely wrote: > > > On Tue, 2019-02-26 at 18:34 -0500, Marek Olšák wrote: > > > I ran a simple test verifying that compute is working properly on the > > >

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-02-28 Thread Jan Vesely
When clover is using compute rings, it doesn't stall/block graphics > operations. I'd be nice to include this information in the commit message. Jan > > Marek > > On Tue, Feb 26, 2019 at 4:10 PM Jan Vesely wrote: > > > Can you add a bit of background why clover should/should

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-02-26 Thread Jan Vesely
Can you add a bit of background why clover should/should not use other rings? I planned to test this, but my raven system can't run clover since kernel 4.20 release (BZ 109649), so I need to bisect that first. Can this patch help address the soft lockup issue on CIK (BZ 108879)? presumably, it

Re: [Mesa-dev] mesa git break nvidia opencl

2019-01-14 Thread Jan Vesely
d > in platform > > ICD loader properties > ICD loader Name OpenCL ICD Loader > ICD loader Vendor OCL Icd free software > ICD loader Version 2.2.12 > ICD loader Profile

Re: [Mesa-dev] mesa git break nvidia opencl

2019-01-12 Thread Jan Vesely
> > The stable 18.3.1 it works. > > Don't know how to analise this kind of problem. > > Sincerely > > AndyBe > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mai

Re: [Mesa-dev] [PATCH] meson, anv: Add inc_vulkan to include directories

2018-12-29 Thread Jan Vesely
On Wed, 2018-12-26 at 15:26 +, Eric Engestrom wrote: > On Tuesday, 2018-12-25 23:09:53 +0100, Jan Vesely wrote: > > Guess my meson-fu is still pretty weak. > > Now I see the build failure again: > > In file included from ../mesa/src/intel/vulkan/anv_private.h:77:0, >

Re: [Mesa-dev] [PATCH] meson, anv: Add inc_vulkan to include directories

2018-12-25 Thread Jan Vesely
2018 at 10:51 AM Jan Vesely wrote: > On Sun, 2018-12-23 at 15:35 +, Eric Engestrom wrote: > > On Sunday, 2018-12-23 12:31:20 +0100, Jan Vesely wrote: > > > From: Jan Vesely > > > > > > intel_vulkan.h uses '#include "vulkan.h"' so the file needs to be

Re: [Mesa-dev] [PATCH] meson, anv: Add inc_vulkan to include directories

2018-12-24 Thread Jan Vesely
On Sun, 2018-12-23 at 15:35 +, Eric Engestrom wrote: > On Sunday, 2018-12-23 12:31:20 +0100, Jan Vesely wrote: > > From: Jan Vesely > > > > intel_vulkan.h uses '#include "vulkan.h"' so the file needs to be in > > include path. > > Fixes mes

[Mesa-dev] [PATCH] meson, anv: Add inc_vulkan to include directories

2018-12-23 Thread Jan Vesely
From: Jan Vesely intel_vulkan.h uses '#include "vulkan.h"' so the file needs to be in include path. Fixes meson build of anv Signed-off-by: Jan Vesely --- src/intel/vulkan/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/meson.build b

Re: [Mesa-dev] [PATCH 1/1] clover: Fix build after clang r348827

2018-12-16 Thread Jan Vesely
On Sun, 2018-12-16 at 10:36 +0100, Kai Wasserbäch wrote: > Jan Vesely wrote on 13.12.18 22:17: > > CodeGenOptions were moved to Basic. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109039 > > Signed-off-by: Jan Vesely > > Since this

[Mesa-dev] [PATCH 1/1] clover: Fix build after clang r348827

2018-12-13 Thread Jan Vesely
CodeGenOptions were moved to Basic. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109039 Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/compat.hpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-04 Thread Jan Vesely
On Mon, 2018-12-03 at 16:17 -0800, Dylan Baker wrote: > Quoting Bas Nieuwenhuizen (2018-12-03 14:14:19) > > On Mon, Dec 3, 2018 at 7:30 PM Jan Vesely wrote: > > > On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > > > > Cc: Emil Velikov > > &g

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-03 Thread Jan Vesely
On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > Cc: Emil Velikov > Cc: Andres Gomez > Cc: Juan A. Suarez Romero > Cc: Dylan Baker > Signed-off-by: Eric Engestrom > --- > This patch depends on the releasing procedure in docs/releasing.html to > be updated to not rely on autotools

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Jan Vesely
On Wed, 2018-11-07 at 13:05 -0800, Matt Turner wrote: > On Wed, Nov 7, 2018 at 12:53 PM Jan Vesely wrote: > > On Wed, 2018-11-07 at 18:51 +, Emil Velikov wrote: > > > On Wed, 7 Nov 2018 at 18:39, Jan Vesely wrote: > > > > On Tue, 2018-11-06 at 1

Re: [Mesa-dev] [PATCH 08/12] meson doesn't use env vars, WAS: configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Jan Vesely
On Wed, 2018-11-07 at 11:34 -0800, Dylan Baker wrote: > Quoting Jan Vesely (2018-11-07 10:39:48) > > On Tue, 2018-11-06 at 12:09 +, Emil Velikov wrote: > > > On Thu, 1 Nov 2018 at 16:13, Michel Dänzer wrote: > > > > On 2018-11-01 5:03 p.m., Jan Vesely wrote: >

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Jan Vesely
On Wed, 2018-11-07 at 18:51 +, Emil Velikov wrote: > On Wed, 7 Nov 2018 at 18:39, Jan Vesely wrote: > > On Tue, 2018-11-06 at 12:09 +, Emil Velikov wrote: > > > On Thu, 1 Nov 2018 at 16:13, Michel Dänzer wrote: > > > > On 2018-11-01 5:03 p.m., Jan Vesely wr

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-11-07 Thread Jan Vesely
On Tue, 2018-11-06 at 12:09 +, Emil Velikov wrote: > On Thu, 1 Nov 2018 at 16:13, Michel Dänzer wrote: > > On 2018-11-01 5:03 p.m., Jan Vesely wrote: > > > On Wed, 2018-10-31 at 18:40 +, Emil Velikov wrote: > > > > On Wed, 31 Oct 2018 at 17:41, Jan Vesely wr

[Mesa-dev] [PATCH] amd: Make vgpr-spilling depend on llvm version

2018-11-01 Thread Jan Vesely
The option was removed in LLVM r345763 Signed-off-by: Jan Vesely --- src/amd/common/ac_llvm_util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/common/ac_llvm_util.c index 69d9f7b9f3..dc9b684e9d 100644 --- a/src/amd/common

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-11-01 Thread Jan Vesely
On Wed, 2018-10-31 at 18:40 +, Emil Velikov wrote: > On Wed, 31 Oct 2018 at 17:41, Jan Vesely wrote: > > On Wed, 2018-10-31 at 17:22 +, Emil Velikov wrote: > > > On Wed, 31 Oct 2018 at 16:24, Michel Dänzer wrote: > > > > On 2018-10-31 5:19 p.m., Jan Vesely

Re: [Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

2018-10-31 Thread Jan Vesely
On Wed, 2018-10-31 at 16:14 -0700, Dylan Baker wrote: > Quoting Jan Vesely (2018-10-31 11:37:19) > > On Wed, 2018-10-31 at 11:22 -0700, Francisco Jerez wrote: > > > I don't object removing the pre-LLVM 5.0 paths, nor keeping them around > > > in order to make r600

Re: [Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

2018-10-31 Thread Jan Vesely
o the new style of metadata passing and updating libclc builtins. There are things higher on my priority list wrt clover/libclc (fixing rounding routines, replacing the build system, adding support for buffer sharing between devices). it will take some time unless someone else volunteers. Jan >

Re: [Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

2018-10-31 Thread Jan Vesely
On Wed, 2018-10-31 at 17:02 +, Emil Velikov wrote: > On Wed, 31 Oct 2018 at 15:57, Jan Vesely wrote: > > On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > LLVM versions earlier than 5.0.1 are no longer supported.

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-10-31 Thread Jan Vesely
On Wed, 2018-10-31 at 17:22 +, Emil Velikov wrote: > On Wed, 31 Oct 2018 at 16:24, Michel Dänzer wrote: > > On 2018-10-31 5:19 p.m., Jan Vesely wrote: > > > On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: > > > > From: Emil Velikov > > > > &

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

2018-10-31 Thread Jan Vesely
On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: > From: Emil Velikov > > The option has been long superseded with LLVM_CONFIG. > Distributions have been using it for a couple of years now. I've been using it in my configure setup. This might be a stupid question; is the LLVM_CONFIG env

Re: [Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

2018-10-31 Thread Jan Vesely
On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: > From: Emil Velikov > > LLVM versions earlier than 5.0.1 are no longer supported. I'd prefer to keep llvm-3.9, since it's the last version that supports images for r600, but I'd leave the final decision to Francisco. Jan >

Re: [Mesa-dev] [PATCH 2/3] anv: Stop generating weak references for instance entrypoints

2018-10-18 Thread Jan Vesely
Hi, I think this patch breaks the build: https://travis-ci.org/jvesely/mesa/jobs/443356781 Jan On Tue, 2018-10-16 at 08:18 -0500, Jason Ekstrand wrote: > FYI, patch 1 is required for this patch to build. It also means this patch > found a nice little bug. I'll respond to patch 1 in more

[Mesa-dev] [PATCH 1/1] radeonsi: Bump number of allowed global buffers to 32

2018-10-18 Thread Jan Vesely
Fixes assertion failure/crash when running luxmark/luxball on clover. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108272 CC: mesa-sta...@lists.freedesktop.org Signed-off-by: Jan Vesely --- This is just a stop gap measure. OpenCL does not limit the number of global buffers, but we can

Re: [Mesa-dev] [PATCH 2/4] radeonsi: use compute shaders for clear_buffer & copy_buffer

2018-10-18 Thread Jan Vesely
On Thu, 2018-10-18 at 09:32 +0200, Michel Dänzer wrote: > On 2018-10-17 6:43 p.m., Marek Olšák wrote: > > Can you test the attached patch? > > Doesn't help, unfortunately. Backtraces with the patch attached. > > FWIW, this is on Bonaire. Hi, fwiw, I don't see this hang on my carrizo/iceland

Re: [Mesa-dev] [PATCH 2/2] .travis: Drop note about Clover builds being slow

2018-09-25 Thread Jan Vesely
On Tue, 2018-09-25 at 18:11 +0100, Emil Velikov wrote: > On 12 September 2018 at 23:20, Jan Vesely wrote: > > SWR takes 17+ minutes to build. Clover builds take ~6-7 minutes. > > > > Clover takes the same time as all the other state-trackers combined. > Ideally we'll t

Re: [Mesa-dev] [PATCH 2/2] .travis: Drop note about Clover builds being slow

2018-09-25 Thread Jan Vesely
On Wed, 2018-09-19 at 11:43 -0400, Jan Vesely wrote: > On Wed, 2018-09-12 at 18:20 -0400, Jan Vesely wrote: > > SWR takes 17+ minutes to build. Clover builds take ~6-7 minutes. > > > > Signed-off-by: Jan Vesely > > --- > > .travis.yml | 4 > > 1 fil

Re: [Mesa-dev] [PATCH mesa 2/6] nouveau: silence paranoid compiler's -Wclass-memaccess

2018-09-22 Thread Jan Vesely
The warning is correct. In the first case, memset tries to zero "Target" object which has a non-trivial constructor and non-trivial copy-constructor. The original code is broken in the way it mixes C and C++ initialization and the patch only papers over the issue. The correct fix would be to

Re: [Mesa-dev] [PATCH 2/2] .travis: Drop note about Clover builds being slow

2018-09-19 Thread Jan Vesely
On Wed, 2018-09-12 at 18:20 -0400, Jan Vesely wrote: > SWR takes 17+ minutes to build. Clover builds take ~6-7 minutes. > > Signed-off-by: Jan Vesely > --- > .travis.yml | 4 > 1 file changed, 4 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 40

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Jan Vesely
Hi, On Mon, 2018-09-17 at 09:44 -0700, Dylan Baker wrote: > I feel like for !windows meson is in good enough shape at this point that we > can start having the discussion about deleting the autotools build. So, is > there > anything left that autotools can do that meson cannot (that we actually

[Mesa-dev] [PATCH 1/2] .travis: Add LLVM-7 Clover build

2018-09-12 Thread Jan Vesely
Signed-off-by: Jan Vesely --- .travis.yml | 33 + 1 file changed, 33 insertions(+) diff --git a/.travis.yml b/.travis.yml index 895030cc1b..4035a729ff 100644 --- a/.travis.yml +++ b/.travis.yml @@ -329,6 +329,39 @@ matrix: - libx11-xcb-dev

[Mesa-dev] [PATCH 2/2] .travis: Drop note about Clover builds being slow

2018-09-12 Thread Jan Vesely
SWR takes 17+ minutes to build. Clover builds take ~6-7 minutes. Signed-off-by: Jan Vesely --- .travis.yml | 4 1 file changed, 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 4035a729ff..78e6d251ae 100644 --- a/.travis.yml +++ b/.travis.yml @@ -186,7 +186,6 @@ matrix

Re: [Mesa-dev] OpenCL Support on older AMD GPUs

2018-08-23 Thread Jan Vesely
0_Serie s_Instruction_Set_Architecture.pdf > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Jan Vesely signature.asc Description: This is a digitally signed message part _

Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Jan Vesely
On Tue, Aug 7, 2018 at 12:28 PM, Juan A. Suarez Romero wrote: > On Tue, 2018-08-07 at 16:12 +0100, Emil Velikov wrote: > > On 6 August 2018 at 11:17, Juan A. Suarez Romero > wrote: > > > LLVM 6.0 requires GCC 4.9, which is not available in main Travis > > > repository. > > > > > > > We're not

Re: [Mesa-dev] [PATCH] clover: Don't extend illegal integer types.

2018-07-26 Thread Jan Vesely
On Thu, 2018-07-26 at 10:51 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > It's OK to pass them in memory, which is what kernel invocation needs. > > Fixes AMDGCN regressions since llvm r337535 ("Reapply "AMDGPU: Fix handling > > of alignmen

[Mesa-dev] [PATCH v2] clover: Reduce wait_count in abort path.

2018-07-24 Thread Jan Vesely
Trigger waiter condition variable. Passes 'events' CTS on carrizo and turks. v2: reduce to 0 Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/core/event.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/event.cpp b

[Mesa-dev] [PATCH] clover: Reduce wait_count in abort path.

2018-07-24 Thread Jan Vesely
Trigger waiter condition variable. Passes 'events' CTS on turks and carrizo. Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/core/event.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/event.cpp b/src/gallium

[Mesa-dev] [PATCH] clover: Don't extend illegal integer types.

2018-07-24 Thread Jan Vesely
rithemtic-short scalar-arithmetic-ushort scalar-comparison-char scalar-comparison-uchar scalar-comparison-short scalar-comparison-ushort Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/codegen/common.cpp | 3 +-- src/gallium/state_track

Re: [Mesa-dev] [PATCH 1/2] clover: Catch errors from executing event action

2018-07-17 Thread Jan Vesely
On Tue, 2018-07-17 at 15:22 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Tue, 2018-07-17 at 14:17 -0700, Francisco Jerez wrote: > > > Jan Vesely writes: > > > > > > > Abort all dependent events. > > > > Signed-off-by: Jan V

Re: [Mesa-dev] [PATCH 1/2] clover: Catch errors from executing event action

2018-07-17 Thread Jan Vesely
On Tue, 2018-07-17 at 14:17 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > Abort all dependent events. > > Signed-off-by: Jan Vesely > > --- > > src/gallium/state_trackers/clover/core/event.cpp | 7 ++- > > 1 file changed, 6 insertions(+), 1 d

Re: [Mesa-dev] [PATCH 1/2] clover: Catch errors from executing event action

2018-07-17 Thread Jan Vesely
Waiting for tasks to finish executing > Checking task status after setting user event status > Unsuccessful user event case passed. > test_userevents passed > HUNG HERE > > --Aaron > > On Tue, Jul 17, 2018 at 9:38 AM, Jan Vesely wrote: > > Abort all dependent events. &g

[Mesa-dev] [PATCH 2/2] clover: Report error when pipe driver fails to create compute state

2018-07-17 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/core/kernel.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp index 4716705323..dab7ef8683 100644 --- a/src/gallium

[Mesa-dev] [PATCH 1/2] clover: Catch errors from executing event action

2018-07-17 Thread Jan Vesely
Abort all dependent events. Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/core/event.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/event.cpp b/src/gallium/state_trackers/clover/core/event.cpp index

[Mesa-dev] [PATCH] radeonsi: Refuse to accept code with unhandled relocations

2018-07-17 Thread Jan Vesely
They might lead to unrecoverable GPU hang. Signed-off-by: Jan Vesely --- src/gallium/drivers/radeonsi/si_compute.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 5d3341ff61..2349be9584 100644

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 5.0

2018-07-02 Thread Jan Vesely
> > expand > > -* the pointer into a full descriptor like below. We have to use > > -* s_load_dword instead. The only case when LLVM 5.0 would > > select > > -* s_buffer_load_dword (that we have to prevent)

[Mesa-dev] [PATCH 1/1] drisw: Fix invalid pointer arithmetic

2018-06-07 Thread Jan Vesely
Use of void * in pointer arithmetic is illegal, use char * instead. Fixes: cf54bd5e8381dba18d52fe438acda20cc1685bf3 ("drisw: use shared memory when possible") Signed-off-by: Jan Vesely --- src/gallium/winsys/sw/dri/dri_sw_winsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [Mesa-dev] [PATCH 1/3] clover: Fix build after llvm r332881.

2018-05-24 Thread Jan Vesely
On Thu, 2018-05-24 at 13:08 -0500, Aaron Watry wrote: > On Tue, May 22, 2018 at 6:43 PM, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > r332881 added an extra parameter to the emit function. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106619 > > Signed-

[Mesa-dev] [PATCH 3/3] travis: Add clover llvm-6.0 build

2018-05-22 Thread Jan Vesely
Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- .travis.yml | 35 +++ 1 file changed, 35 insertions(+) diff --git a/.travis.yml b/.travis.yml index e3471d47ac..33dcbcc8da 100644 --- a/.travis.yml +++ b/.travis.yml @@ -290,6 +290,41 @@

[Mesa-dev] [PATCH 2/3] clover: Cleanup compat code for llvm < 3.9

2018-05-22 Thread Jan Vesely
Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- I've confirmed that simple piglits run on turks(llvm-7) and carrizo(llvm-6,7). Travis says it builds ok for all supported llvm versions. .../clover/llvm/codegen/native.cpp| 7 +- .../state_trackers/clover/llvm/comp

[Mesa-dev] [PATCH 1/3] clover: Fix build after llvm r332881.

2018-05-22 Thread Jan Vesely
r332881 added an extra parameter to the emit function. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106619 Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- .../state_trackers/clover/llvm/codegen/native.cpp | 3 +-- src/gallium/state_trackers/clover/llvm/compat.hpp

Re: [Mesa-dev] [RFC PATCH] Replace an flock with a random filename to evade some very ugly system dependent code

2018-05-20 Thread Jan Vesely
; - /* With the temporary file open, we take an exclusive flock on > -* it. If the flock fails, then another process still has the file > -* open with the flock held. So just let that file be responsible > -* for writing the file. > -*/ > - err = flock(fd, LOCK_EX | LOCK_NB);

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-18 Thread Jan Vesely
On Fri, 2018-05-18 at 21:31 -0500, Aaron Watry wrote: > On Fri, May 18, 2018 at 1:15 PM, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > On Thu, 2018-05-17 at 19:20 -0500, Aaron Watry wrote: > > > They're not used anywhere else, so keep them private > > > >

Re: [Mesa-dev] [PATCH 2/2] r600/compute: Mark several functions as static

2018-05-18 Thread Jan Vesely
age. Either way: Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> Jan > --- > .../drivers/r600/compute_memory_pool.c| 35 +++ > .../drivers/r600/compute_memory_pool.h| 24 - > 2 files changed, 29 insertions(+), 30 deletions(-) > >

[Mesa-dev] [PATCH 1/1] travis: Adapt to radeonsi dropping support for LLVM 4

2018-05-17 Thread Jan Vesely
meson Vulkan, Clover, and autotools Vulkan need to be switched to llvm 5 Fixes: f9eb1ef870eba9fdacf9a8cbd815ec3bff81db05 Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- .travis.yml | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.trav

Re: [Mesa-dev] [PATCH v2 1/1] eg/compute: Use reference counting to handle compute memory pool.

2018-05-15 Thread Jan Vesely
On Wed, 2018-05-09 at 15:54 -0400, Jan Vesely wrote: > Use pipe_refernce to release old RAT surfaces. > RAT surface adds a reference to pool bo. So use reference counting for > pool->bo > as well. > > v2: Use the same pattern for both defrag paths > Drop confusing co

Re: [Mesa-dev] [PATCH 7/9] radeonsi: avoid a crash in gallivm_dispose_target_library_info

2018-05-14 Thread Jan Vesely
On Thu, 2018-05-10 at 17:10 -0400, Marek Olšák wrote: > On Thu, May 10, 2018 at 4:39 PM, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > > Is this still needed for llvm-6.0.1? > > > > Probably. was it reproducible on non-ubuntu systems? There's still some time u

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-14 Thread Jan Vesely
: > Hello Jan and Kai, > > would be nice if this lands (have T-b from me). > > Dieter > > Am 13.05.2018 19:10, schrieb Jan Vesely: > > Hi, > > > > sorry for the delay. I thought maybe Emil is on holiday. I plan to > > push this on Monday evening (EDT)

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-13 Thread Jan Vesely
an FTBFS, has two > T-b > and one A-b. > > > Kai Wasserbäch wrote on 07.05.2018 16:48: > > Jan Vesely wrote on 02.05.2018 22:38: > >> On Wed, 2018-05-02 at 18:38 +0200, Kai Wasserbäch wrote: > >>> [...] > >> > >> Thank for looking into th

[Mesa-dev] [PATCH 1/1] winsys/amdgpu: Destroy dev_hash table when the last winsys is removed.

2018-05-10 Thread Jan Vesely
Fixes memory leak on module unload. CC: <mesa-sta...@lists.freedesktop.org> Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/amd

Re: [Mesa-dev] [PATCH 7/9] radeonsi: avoid a crash in gallivm_dispose_target_library_info

2018-05-10 Thread Jan Vesely
Is this still needed for llvm-6.0.1? On Mon, Apr 16, 2018 at 8:52 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_pipe.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

[Mesa-dev] [PATCH v2 1/1] eg/compute: Use reference counting to handle compute memory pool.

2018-05-09 Thread Jan Vesely
Use pipe_refernce to release old RAT surfaces. RAT surface adds a reference to pool bo. So use reference counting for pool->bo as well. v2: Use the same pattern for both defrag paths Drop confusing comment CC: <mesa-sta...@lists.freedesktop.org> Signed-off-by: Jan Vesely

  1   2   3   4   5   6   >